Re: [RESEND PATCH 1/2] arm:omap2+: put omap_uart_phys/virt/lsr in .text section when ZIMAGE is true
* Hoeun Ryu[170613 23:57]: > On Tue, 2017-06-13 at 22:27 -0700, Tony Lindgren wrote: > > So I converted all these to use the 8250 debug_ll yesterday > > which should solve the DEBUG_UNCOMPRESS issue for you and > > allows us to remove this file. Will post the series shortly > > for testing with you in Cc after I've done a bit more testing > > here. > > It sounds good. > patch 01 is dropped though, are you using the second patch ? > "[PATCH 2/2] arm:omap2+: drop dependence on DEBUG_OMAP2PLUS_UART for > DEBUG_UNCOMPRESS" I folded it into the patch removing all users of DEBUG_OMAP2PLUS_UART as that seems to make most sense here. Regards, Tony
Re: [RESEND PATCH 1/2] arm:omap2+: put omap_uart_phys/virt/lsr in .text section when ZIMAGE is true
* Hoeun Ryu [170613 23:57]: > On Tue, 2017-06-13 at 22:27 -0700, Tony Lindgren wrote: > > So I converted all these to use the 8250 debug_ll yesterday > > which should solve the DEBUG_UNCOMPRESS issue for you and > > allows us to remove this file. Will post the series shortly > > for testing with you in Cc after I've done a bit more testing > > here. > > It sounds good. > patch 01 is dropped though, are you using the second patch ? > "[PATCH 2/2] arm:omap2+: drop dependence on DEBUG_OMAP2PLUS_UART for > DEBUG_UNCOMPRESS" I folded it into the patch removing all users of DEBUG_OMAP2PLUS_UART as that seems to make most sense here. Regards, Tony
Re: [RESEND PATCH 1/2] arm:omap2+: put omap_uart_phys/virt/lsr in .text section when ZIMAGE is true
On Tue, 2017-06-13 at 22:27 -0700, Tony Lindgren wrote: > Hi, > > * Hoeun Ryu[170612 18:18]: > > > > --- a/arch/arm/include/debug/omap2plus.S > > +++ b/arch/arm/include/debug/omap2plus.S > > @@ -58,11 +58,22 @@ > > > > #define UART_OFFSET(addr) ((addr) & 0x00ff) > > > > +/* > > + * Definition of ZIMAGE is in arch/arm/boot/compressed/Makefile. > > + * Place the following block in .text section only when this file > > is > > + * included by arch/arm/boot/compressed/* to make it possible to > > + * enable CONFIG_DEBUG_UNCOMPRESS and DEBUG in > > arch/arm/boot/compressed/head.S > > + * on OMAP2+ SoCs. > > + */ > > +#ifndef ZIMAGE > > .pushsection .data > > +#endif > > omap_uart_phys:.word 0 > > omap_uart_virt:.word 0 > > omap_uart_lsr: .word 0 > > +#ifndef ZIMAGE > > .popsection > > +#endif > So I converted all these to use the 8250 debug_ll yesterday > which should solve the DEBUG_UNCOMPRESS issue for you and > allows us to remove this file. Will post the series shortly > for testing with you in Cc after I've done a bit more testing > here. It sounds good. patch 01 is dropped though, are you using the second patch ? "[PATCH 2/2] arm:omap2+: drop dependence on DEBUG_OMAP2PLUS_UART for DEBUG_UNCOMPRESS" Thank you. > > Regards, > > Tony
Re: [RESEND PATCH 1/2] arm:omap2+: put omap_uart_phys/virt/lsr in .text section when ZIMAGE is true
On Tue, 2017-06-13 at 22:27 -0700, Tony Lindgren wrote: > Hi, > > * Hoeun Ryu [170612 18:18]: > > > > --- a/arch/arm/include/debug/omap2plus.S > > +++ b/arch/arm/include/debug/omap2plus.S > > @@ -58,11 +58,22 @@ > > > > #define UART_OFFSET(addr) ((addr) & 0x00ff) > > > > +/* > > + * Definition of ZIMAGE is in arch/arm/boot/compressed/Makefile. > > + * Place the following block in .text section only when this file > > is > > + * included by arch/arm/boot/compressed/* to make it possible to > > + * enable CONFIG_DEBUG_UNCOMPRESS and DEBUG in > > arch/arm/boot/compressed/head.S > > + * on OMAP2+ SoCs. > > + */ > > +#ifndef ZIMAGE > > .pushsection .data > > +#endif > > omap_uart_phys:.word 0 > > omap_uart_virt:.word 0 > > omap_uart_lsr: .word 0 > > +#ifndef ZIMAGE > > .popsection > > +#endif > So I converted all these to use the 8250 debug_ll yesterday > which should solve the DEBUG_UNCOMPRESS issue for you and > allows us to remove this file. Will post the series shortly > for testing with you in Cc after I've done a bit more testing > here. It sounds good. patch 01 is dropped though, are you using the second patch ? "[PATCH 2/2] arm:omap2+: drop dependence on DEBUG_OMAP2PLUS_UART for DEBUG_UNCOMPRESS" Thank you. > > Regards, > > Tony
Re: [RESEND PATCH 1/2] arm:omap2+: put omap_uart_phys/virt/lsr in .text section when ZIMAGE is true
Hi, * Hoeun Ryu[170612 18:18]: > --- a/arch/arm/include/debug/omap2plus.S > +++ b/arch/arm/include/debug/omap2plus.S > @@ -58,11 +58,22 @@ > > #define UART_OFFSET(addr)((addr) & 0x00ff) > > +/* > + * Definition of ZIMAGE is in arch/arm/boot/compressed/Makefile. > + * Place the following block in .text section only when this file is > + * included by arch/arm/boot/compressed/* to make it possible to > + * enable CONFIG_DEBUG_UNCOMPRESS and DEBUG in > arch/arm/boot/compressed/head.S > + * on OMAP2+ SoCs. > + */ > +#ifndef ZIMAGE > .pushsection .data > +#endif > omap_uart_phys: .word 0 > omap_uart_virt: .word 0 > omap_uart_lsr: .word 0 > +#ifndef ZIMAGE > .popsection > +#endif So I converted all these to use the 8250 debug_ll yesterday which should solve the DEBUG_UNCOMPRESS issue for you and allows us to remove this file. Will post the series shortly for testing with you in Cc after I've done a bit more testing here. Regards, Tony
Re: [RESEND PATCH 1/2] arm:omap2+: put omap_uart_phys/virt/lsr in .text section when ZIMAGE is true
Hi, * Hoeun Ryu [170612 18:18]: > --- a/arch/arm/include/debug/omap2plus.S > +++ b/arch/arm/include/debug/omap2plus.S > @@ -58,11 +58,22 @@ > > #define UART_OFFSET(addr)((addr) & 0x00ff) > > +/* > + * Definition of ZIMAGE is in arch/arm/boot/compressed/Makefile. > + * Place the following block in .text section only when this file is > + * included by arch/arm/boot/compressed/* to make it possible to > + * enable CONFIG_DEBUG_UNCOMPRESS and DEBUG in > arch/arm/boot/compressed/head.S > + * on OMAP2+ SoCs. > + */ > +#ifndef ZIMAGE > .pushsection .data > +#endif > omap_uart_phys: .word 0 > omap_uart_virt: .word 0 > omap_uart_lsr: .word 0 > +#ifndef ZIMAGE > .popsection > +#endif So I converted all these to use the 8250 debug_ll yesterday which should solve the DEBUG_UNCOMPRESS issue for you and allows us to remove this file. Will post the series shortly for testing with you in Cc after I've done a bit more testing here. Regards, Tony
Re: [PATCH 1/2] arm:omap2+: put omap_uart_phys/virt/lsr in .text section when ZIMAGE is true
* Russell King - ARM Linux[170610 03:24]: > On Sat, Jun 10, 2017 at 01:44:00PM +0900, Hoeun Ryu wrote: > > Hello, Russell. > > > > Would you please review this patch ? > > It's really up to Tony Lindgren, who is the OMAP maintainer. I'll take a look today. I think we can simplify things quite a bit as we no longer use machine type for configuring the UART. Regards, Tony
Re: [PATCH 1/2] arm:omap2+: put omap_uart_phys/virt/lsr in .text section when ZIMAGE is true
* Russell King - ARM Linux [170610 03:24]: > On Sat, Jun 10, 2017 at 01:44:00PM +0900, Hoeun Ryu wrote: > > Hello, Russell. > > > > Would you please review this patch ? > > It's really up to Tony Lindgren, who is the OMAP maintainer. I'll take a look today. I think we can simplify things quite a bit as we no longer use machine type for configuring the UART. Regards, Tony
[RESEND PATCH 1/2] arm:omap2+: put omap_uart_phys/virt/lsr in .text section when ZIMAGE is true
omap_uart_phys, omap_uart_virt and omap_uart_lsr reside in .data section and it's right implementation. But because of this, we cannot enable CONFIG_DEBUG_UNCOMPRESS. LL_DEBUG and DEBUG_UNCOMPRESS are very useful tools for debugging early boot stage when something goes wrong if you don't have any hardware based debugging tools like a JTAG debugger. This patch is to put the variables into .text section instead only when the DEBUG_LL_INCLUDE file is included in the kernel decompressor, which is only when ZIMAGE is defined. This patch does not change anything when DEBUG_LL_INCLUDE is included in the other kernel parts like arch/arm/kernel/* Signed-off-by: Hoeun Ryu--- * to mail to relevant recipients, no respond yet from them - TO=Tony Lindgren - CC=linux-o...@vger.kernel.org * indentical to previous patch arch/arm/include/debug/omap2plus.S | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/include/debug/omap2plus.S b/arch/arm/include/debug/omap2plus.S index 6d867ae..6ce6ef9 100644 --- a/arch/arm/include/debug/omap2plus.S +++ b/arch/arm/include/debug/omap2plus.S @@ -58,11 +58,22 @@ #define UART_OFFSET(addr) ((addr) & 0x00ff) +/* + * Definition of ZIMAGE is in arch/arm/boot/compressed/Makefile. + * Place the following block in .text section only when this file is + * included by arch/arm/boot/compressed/* to make it possible to + * enable CONFIG_DEBUG_UNCOMPRESS and DEBUG in arch/arm/boot/compressed/head.S + * on OMAP2+ SoCs. + */ +#ifndef ZIMAGE .pushsection .data +#endif omap_uart_phys:.word 0 omap_uart_virt:.word 0 omap_uart_lsr: .word 0 +#ifndef ZIMAGE .popsection +#endif .macro addruart, rp, rv, tmp -- 2.7.4
[RESEND PATCH 1/2] arm:omap2+: put omap_uart_phys/virt/lsr in .text section when ZIMAGE is true
omap_uart_phys, omap_uart_virt and omap_uart_lsr reside in .data section and it's right implementation. But because of this, we cannot enable CONFIG_DEBUG_UNCOMPRESS. LL_DEBUG and DEBUG_UNCOMPRESS are very useful tools for debugging early boot stage when something goes wrong if you don't have any hardware based debugging tools like a JTAG debugger. This patch is to put the variables into .text section instead only when the DEBUG_LL_INCLUDE file is included in the kernel decompressor, which is only when ZIMAGE is defined. This patch does not change anything when DEBUG_LL_INCLUDE is included in the other kernel parts like arch/arm/kernel/* Signed-off-by: Hoeun Ryu --- * to mail to relevant recipients, no respond yet from them - TO=Tony Lindgren - CC=linux-o...@vger.kernel.org * indentical to previous patch arch/arm/include/debug/omap2plus.S | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/include/debug/omap2plus.S b/arch/arm/include/debug/omap2plus.S index 6d867ae..6ce6ef9 100644 --- a/arch/arm/include/debug/omap2plus.S +++ b/arch/arm/include/debug/omap2plus.S @@ -58,11 +58,22 @@ #define UART_OFFSET(addr) ((addr) & 0x00ff) +/* + * Definition of ZIMAGE is in arch/arm/boot/compressed/Makefile. + * Place the following block in .text section only when this file is + * included by arch/arm/boot/compressed/* to make it possible to + * enable CONFIG_DEBUG_UNCOMPRESS and DEBUG in arch/arm/boot/compressed/head.S + * on OMAP2+ SoCs. + */ +#ifndef ZIMAGE .pushsection .data +#endif omap_uart_phys:.word 0 omap_uart_virt:.word 0 omap_uart_lsr: .word 0 +#ifndef ZIMAGE .popsection +#endif .macro addruart, rp, rv, tmp -- 2.7.4
Re: [PATCH 1/2] arm:omap2+: put omap_uart_phys/virt/lsr in .text section when ZIMAGE is true
On Sat, Jun 10, 2017 at 01:44:00PM +0900, Hoeun Ryu wrote: > Hello, Russell. > > Would you please review this patch ? It's really up to Tony Lindgren, who is the OMAP maintainer. > > Than you > > > On Jun 8, 2017, at 11:16 AM, Hoeun Ryuwrote: > > > > omap_uart_phys, omap_uart_virt and omap_uart_lsr reside in .data section > > and it's right implementation. But because of this, we cannot enable > > CONFIG_DEBUG_UNCOMPRESS. LL_DEBUG and DEBUG_UNCOMPRESS are very useful tools > > for debugging early boot stage when something goes wrong if you don't have > > any hardware based debugging tools like a JTAG debugger. > > This patch is to put the variables into .text section instead only when the > > DEBUG_LL_INCLUDE file is included in the kernel decompressor, which is only > > when ZIMAGE is defined. > > This patch does not change anything when DEBUG_LL_INCLUDE is included in > > the other kernel parts like arch/arm/kernel/* > > > > Signed-off-by: Hoeun Ryu > > --- > > arch/arm/include/debug/omap2plus.S | 11 +++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/arch/arm/include/debug/omap2plus.S > > b/arch/arm/include/debug/omap2plus.S > > index 6d867ae..6ce6ef9 100644 > > --- a/arch/arm/include/debug/omap2plus.S > > +++ b/arch/arm/include/debug/omap2plus.S > > @@ -58,11 +58,22 @@ > > > > #define UART_OFFSET(addr)((addr) & 0x00ff) > > > > +/* > > + * Definition of ZIMAGE is in arch/arm/boot/compressed/Makefile. > > + * Place the following block in .text section only when this file is > > + * included by arch/arm/boot/compressed/* to make it possible to > > + * enable CONFIG_DEBUG_UNCOMPRESS and DEBUG in > > arch/arm/boot/compressed/head.S > > + * on OMAP2+ SoCs. > > + */ > > +#ifndef ZIMAGE > >.pushsection .data > > +#endif > > omap_uart_phys:.word0 > > omap_uart_virt:.word0 > > omap_uart_lsr:.word0 > > +#ifndef ZIMAGE > >.popsection > > +#endif > > > >.macroaddruart, rp, rv, tmp > > > > -- > > 2.7.4 > > -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.
Re: [PATCH 1/2] arm:omap2+: put omap_uart_phys/virt/lsr in .text section when ZIMAGE is true
On Sat, Jun 10, 2017 at 01:44:00PM +0900, Hoeun Ryu wrote: > Hello, Russell. > > Would you please review this patch ? It's really up to Tony Lindgren, who is the OMAP maintainer. > > Than you > > > On Jun 8, 2017, at 11:16 AM, Hoeun Ryu wrote: > > > > omap_uart_phys, omap_uart_virt and omap_uart_lsr reside in .data section > > and it's right implementation. But because of this, we cannot enable > > CONFIG_DEBUG_UNCOMPRESS. LL_DEBUG and DEBUG_UNCOMPRESS are very useful tools > > for debugging early boot stage when something goes wrong if you don't have > > any hardware based debugging tools like a JTAG debugger. > > This patch is to put the variables into .text section instead only when the > > DEBUG_LL_INCLUDE file is included in the kernel decompressor, which is only > > when ZIMAGE is defined. > > This patch does not change anything when DEBUG_LL_INCLUDE is included in > > the other kernel parts like arch/arm/kernel/* > > > > Signed-off-by: Hoeun Ryu > > --- > > arch/arm/include/debug/omap2plus.S | 11 +++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/arch/arm/include/debug/omap2plus.S > > b/arch/arm/include/debug/omap2plus.S > > index 6d867ae..6ce6ef9 100644 > > --- a/arch/arm/include/debug/omap2plus.S > > +++ b/arch/arm/include/debug/omap2plus.S > > @@ -58,11 +58,22 @@ > > > > #define UART_OFFSET(addr)((addr) & 0x00ff) > > > > +/* > > + * Definition of ZIMAGE is in arch/arm/boot/compressed/Makefile. > > + * Place the following block in .text section only when this file is > > + * included by arch/arm/boot/compressed/* to make it possible to > > + * enable CONFIG_DEBUG_UNCOMPRESS and DEBUG in > > arch/arm/boot/compressed/head.S > > + * on OMAP2+ SoCs. > > + */ > > +#ifndef ZIMAGE > >.pushsection .data > > +#endif > > omap_uart_phys:.word0 > > omap_uart_virt:.word0 > > omap_uart_lsr:.word0 > > +#ifndef ZIMAGE > >.popsection > > +#endif > > > >.macroaddruart, rp, rv, tmp > > > > -- > > 2.7.4 > > -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.
Re: [PATCH 1/2] arm:omap2+: put omap_uart_phys/virt/lsr in .text section when ZIMAGE is true
Hello, Russell. Would you please review this patch ? Than you > On Jun 8, 2017, at 11:16 AM, Hoeun Ryuwrote: > > omap_uart_phys, omap_uart_virt and omap_uart_lsr reside in .data section > and it's right implementation. But because of this, we cannot enable > CONFIG_DEBUG_UNCOMPRESS. LL_DEBUG and DEBUG_UNCOMPRESS are very useful tools > for debugging early boot stage when something goes wrong if you don't have > any hardware based debugging tools like a JTAG debugger. > This patch is to put the variables into .text section instead only when the > DEBUG_LL_INCLUDE file is included in the kernel decompressor, which is only > when ZIMAGE is defined. > This patch does not change anything when DEBUG_LL_INCLUDE is included in > the other kernel parts like arch/arm/kernel/* > > Signed-off-by: Hoeun Ryu > --- > arch/arm/include/debug/omap2plus.S | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm/include/debug/omap2plus.S > b/arch/arm/include/debug/omap2plus.S > index 6d867ae..6ce6ef9 100644 > --- a/arch/arm/include/debug/omap2plus.S > +++ b/arch/arm/include/debug/omap2plus.S > @@ -58,11 +58,22 @@ > > #define UART_OFFSET(addr)((addr) & 0x00ff) > > +/* > + * Definition of ZIMAGE is in arch/arm/boot/compressed/Makefile. > + * Place the following block in .text section only when this file is > + * included by arch/arm/boot/compressed/* to make it possible to > + * enable CONFIG_DEBUG_UNCOMPRESS and DEBUG in > arch/arm/boot/compressed/head.S > + * on OMAP2+ SoCs. > + */ > +#ifndef ZIMAGE >.pushsection .data > +#endif > omap_uart_phys:.word0 > omap_uart_virt:.word0 > omap_uart_lsr:.word0 > +#ifndef ZIMAGE >.popsection > +#endif > >.macroaddruart, rp, rv, tmp > > -- > 2.7.4 >
Re: [PATCH 1/2] arm:omap2+: put omap_uart_phys/virt/lsr in .text section when ZIMAGE is true
Hello, Russell. Would you please review this patch ? Than you > On Jun 8, 2017, at 11:16 AM, Hoeun Ryu wrote: > > omap_uart_phys, omap_uart_virt and omap_uart_lsr reside in .data section > and it's right implementation. But because of this, we cannot enable > CONFIG_DEBUG_UNCOMPRESS. LL_DEBUG and DEBUG_UNCOMPRESS are very useful tools > for debugging early boot stage when something goes wrong if you don't have > any hardware based debugging tools like a JTAG debugger. > This patch is to put the variables into .text section instead only when the > DEBUG_LL_INCLUDE file is included in the kernel decompressor, which is only > when ZIMAGE is defined. > This patch does not change anything when DEBUG_LL_INCLUDE is included in > the other kernel parts like arch/arm/kernel/* > > Signed-off-by: Hoeun Ryu > --- > arch/arm/include/debug/omap2plus.S | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm/include/debug/omap2plus.S > b/arch/arm/include/debug/omap2plus.S > index 6d867ae..6ce6ef9 100644 > --- a/arch/arm/include/debug/omap2plus.S > +++ b/arch/arm/include/debug/omap2plus.S > @@ -58,11 +58,22 @@ > > #define UART_OFFSET(addr)((addr) & 0x00ff) > > +/* > + * Definition of ZIMAGE is in arch/arm/boot/compressed/Makefile. > + * Place the following block in .text section only when this file is > + * included by arch/arm/boot/compressed/* to make it possible to > + * enable CONFIG_DEBUG_UNCOMPRESS and DEBUG in > arch/arm/boot/compressed/head.S > + * on OMAP2+ SoCs. > + */ > +#ifndef ZIMAGE >.pushsection .data > +#endif > omap_uart_phys:.word0 > omap_uart_virt:.word0 > omap_uart_lsr:.word0 > +#ifndef ZIMAGE >.popsection > +#endif > >.macroaddruart, rp, rv, tmp > > -- > 2.7.4 >
[PATCH 1/2] arm:omap2+: put omap_uart_phys/virt/lsr in .text section when ZIMAGE is true
omap_uart_phys, omap_uart_virt and omap_uart_lsr reside in .data section and it's right implementation. But because of this, we cannot enable CONFIG_DEBUG_UNCOMPRESS. LL_DEBUG and DEBUG_UNCOMPRESS are very useful tools for debugging early boot stage when something goes wrong if you don't have any hardware based debugging tools like a JTAG debugger. This patch is to put the variables into .text section instead only when the DEBUG_LL_INCLUDE file is included in the kernel decompressor, which is only when ZIMAGE is defined. This patch does not change anything when DEBUG_LL_INCLUDE is included in the other kernel parts like arch/arm/kernel/* Signed-off-by: Hoeun Ryu--- arch/arm/include/debug/omap2plus.S | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/include/debug/omap2plus.S b/arch/arm/include/debug/omap2plus.S index 6d867ae..6ce6ef9 100644 --- a/arch/arm/include/debug/omap2plus.S +++ b/arch/arm/include/debug/omap2plus.S @@ -58,11 +58,22 @@ #define UART_OFFSET(addr) ((addr) & 0x00ff) +/* + * Definition of ZIMAGE is in arch/arm/boot/compressed/Makefile. + * Place the following block in .text section only when this file is + * included by arch/arm/boot/compressed/* to make it possible to + * enable CONFIG_DEBUG_UNCOMPRESS and DEBUG in arch/arm/boot/compressed/head.S + * on OMAP2+ SoCs. + */ +#ifndef ZIMAGE .pushsection .data +#endif omap_uart_phys:.word 0 omap_uart_virt:.word 0 omap_uart_lsr: .word 0 +#ifndef ZIMAGE .popsection +#endif .macro addruart, rp, rv, tmp -- 2.7.4
[PATCH 1/2] arm:omap2+: put omap_uart_phys/virt/lsr in .text section when ZIMAGE is true
omap_uart_phys, omap_uart_virt and omap_uart_lsr reside in .data section and it's right implementation. But because of this, we cannot enable CONFIG_DEBUG_UNCOMPRESS. LL_DEBUG and DEBUG_UNCOMPRESS are very useful tools for debugging early boot stage when something goes wrong if you don't have any hardware based debugging tools like a JTAG debugger. This patch is to put the variables into .text section instead only when the DEBUG_LL_INCLUDE file is included in the kernel decompressor, which is only when ZIMAGE is defined. This patch does not change anything when DEBUG_LL_INCLUDE is included in the other kernel parts like arch/arm/kernel/* Signed-off-by: Hoeun Ryu --- arch/arm/include/debug/omap2plus.S | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/include/debug/omap2plus.S b/arch/arm/include/debug/omap2plus.S index 6d867ae..6ce6ef9 100644 --- a/arch/arm/include/debug/omap2plus.S +++ b/arch/arm/include/debug/omap2plus.S @@ -58,11 +58,22 @@ #define UART_OFFSET(addr) ((addr) & 0x00ff) +/* + * Definition of ZIMAGE is in arch/arm/boot/compressed/Makefile. + * Place the following block in .text section only when this file is + * included by arch/arm/boot/compressed/* to make it possible to + * enable CONFIG_DEBUG_UNCOMPRESS and DEBUG in arch/arm/boot/compressed/head.S + * on OMAP2+ SoCs. + */ +#ifndef ZIMAGE .pushsection .data +#endif omap_uart_phys:.word 0 omap_uart_virt:.word 0 omap_uart_lsr: .word 0 +#ifndef ZIMAGE .popsection +#endif .macro addruart, rp, rv, tmp -- 2.7.4