Re: [PATCH 1/2] regulator: tps65217: Fix build warnings

2014-06-24 Thread Mark Brown 
On Tue, Jun 24, 2014 at 01:59:15PM +0530, Sachin Kamat wrote:
> rdev_get_id() returns an int. Convert rid to type int to avoid the
> following warnings:

Applied, thanks.


signature.asc
Description: Digital signature

[PATCH 1/2] regulator: tps65217: Fix build warnings

2014-06-24 Thread Sachin Kamat 
rdev_get_id() returns an int. Convert rid to type int to avoid the
following warnings:

drivers/regulator/tps65217-regulator.c:73:10: warning: comparison of unsigned 
expression < 0 is always false [-Wtype-limits]
drivers/regulator/tps65217-regulator.c:87:10: warning: comparison of unsigned 
expression < 0 is always false [-Wtype-limits]

Signed-off-by: Sachin Kamat 
---
Series compile tested.
---
 drivers/regulator/tps65217-regulator.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/tps65217-regulator.c 
b/drivers/regulator/tps65217-regulator.c
index f7ed20a5a8b9..d58db72a63b0 100644
--- a/drivers/regulator/tps65217-regulator.c
+++ b/drivers/regulator/tps65217-regulator.c
@@ -68,7 +68,7 @@ static const struct regulator_linear_range 
tps65217_uv2_ranges[] = {
 static int tps65217_pmic_enable(struct regulator_dev *dev)
 {
struct tps65217 *tps = rdev_get_drvdata(dev);
-   unsigned int rid = rdev_get_id(dev);
+   int rid = rdev_get_id(dev);
 
if (rid < TPS65217_DCDC_1 || rid > TPS65217_LDO_4)
return -EINVAL;
@@ -82,7 +82,7 @@ static int tps65217_pmic_enable(struct regulator_dev *dev)
 static int tps65217_pmic_disable(struct regulator_dev *dev)
 {
struct tps65217 *tps = rdev_get_drvdata(dev);
-   unsigned int rid = rdev_get_id(dev);
+   int rid = rdev_get_id(dev);
 
if (rid < TPS65217_DCDC_1 || rid > TPS65217_LDO_4)
return -EINVAL;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/2] regulator: tps65217: Fix build warnings

2014-06-24 Thread Sachin Kamat 
rdev_get_id() returns an int. Convert rid to type int to avoid the
following warnings:

drivers/regulator/tps65217-regulator.c:73:10: warning: comparison of unsigned 
expression  0 is always false [-Wtype-limits]
drivers/regulator/tps65217-regulator.c:87:10: warning: comparison of unsigned 
expression  0 is always false [-Wtype-limits]

Signed-off-by: Sachin Kamat sachin.ka...@samsung.com
---
Series compile tested.
---
 drivers/regulator/tps65217-regulator.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/tps65217-regulator.c 
b/drivers/regulator/tps65217-regulator.c
index f7ed20a5a8b9..d58db72a63b0 100644
--- a/drivers/regulator/tps65217-regulator.c
+++ b/drivers/regulator/tps65217-regulator.c
@@ -68,7 +68,7 @@ static const struct regulator_linear_range 
tps65217_uv2_ranges[] = {
 static int tps65217_pmic_enable(struct regulator_dev *dev)
 {
struct tps65217 *tps = rdev_get_drvdata(dev);
-   unsigned int rid = rdev_get_id(dev);
+   int rid = rdev_get_id(dev);
 
if (rid  TPS65217_DCDC_1 || rid  TPS65217_LDO_4)
return -EINVAL;
@@ -82,7 +82,7 @@ static int tps65217_pmic_enable(struct regulator_dev *dev)
 static int tps65217_pmic_disable(struct regulator_dev *dev)
 {
struct tps65217 *tps = rdev_get_drvdata(dev);
-   unsigned int rid = rdev_get_id(dev);
+   int rid = rdev_get_id(dev);
 
if (rid  TPS65217_DCDC_1 || rid  TPS65217_LDO_4)
return -EINVAL;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/2] regulator: tps65217: Fix build warnings

2014-06-24 Thread Mark Brown 
On Tue, Jun 24, 2014 at 01:59:15PM +0530, Sachin Kamat wrote:
 rdev_get_id() returns an int. Convert rid to type int to avoid the
 following warnings:

Applied, thanks.


signature.asc
Description: Digital signature