Re: [PATCH 1/3] platform/chrome: chromeos_laptop: Add Leon Touch

[Benson Leung]

Hi Enric,

On Mon, Feb 15, 2016 at 3:58 PM, Enric Balletbo i Serra
 wrote:
> From: Gene Chen 
>
> Add support for Leon touch devices, which is the same as
> slippy/falco/peppy/wolf on the same buses using the LynxPoint-LP I2C via
> the i2c-designware-pci driver.
>
> Based on the following patch:
> https://chromium-review.googlesource.com/#/c/168351/
>
> Signed-off-by: Gene Chen 
> Reviewed-by: Benson Leung 
> Signed-off-by: Enric Balletbo i Serra 

I'll have to nack this patch. This actually already landed here :
963cb6f platform/chrome: chromeos_laptop - Add Toshiba CB35 Touch

As we've been upstreaming these patches, I've been changing the names
in this file to reflect the public model names instead of the
codenames we used for development. Sorry for the confusion.




-- 
Benson Leung
Senior Software Engineer, Chrom* OS
ble...@chromium.org

Re: [PATCH 1/3] platform/chrome: chromeos_laptop: Add Leon Touch

[Benson Leung]

Hi Enric,

On Mon, Feb 15, 2016 at 3:58 PM, Enric Balletbo i Serra
 wrote:
> From: Gene Chen 
>
> Add support for Leon touch devices, which is the same as
> slippy/falco/peppy/wolf on the same buses using the LynxPoint-LP I2C via
> the i2c-designware-pci driver.
>
> Based on the following patch:
> https://chromium-review.googlesource.com/#/c/168351/
>
> Signed-off-by: Gene Chen 
> Reviewed-by: Benson Leung 
> Signed-off-by: Enric Balletbo i Serra 

I'll have to nack this patch. This actually already landed here :
963cb6f platform/chrome: chromeos_laptop - Add Toshiba CB35 Touch

As we've been upstreaming these patches, I've been changing the names
in this file to reflect the public model names instead of the
codenames we used for development. Sorry for the confusion.




-- 
Benson Leung
Senior Software Engineer, Chrom* OS
ble...@chromium.org

[PATCH 1/3] platform/chrome: chromeos_laptop: Add Leon Touch

[Enric Balletbo i Serra]

From: Gene Chen 

Add support for Leon touch devices, which is the same as
slippy/falco/peppy/wolf on the same buses using the LynxPoint-LP I2C via
the i2c-designware-pci driver.

Based on the following patch:
https://chromium-review.googlesource.com/#/c/168351/

Signed-off-by: Gene Chen 
Reviewed-by: Benson Leung 
Signed-off-by: Enric Balletbo i Serra 
---
 drivers/platform/chrome/chromeos_laptop.c | 15 +++
 1 file changed, 15 insertions(+)

diff --git a/drivers/platform/chrome/chromeos_laptop.c 
b/drivers/platform/chrome/chromeos_laptop.c
index 2b441e9..f5aa0a3 100644
--- a/drivers/platform/chrome/chromeos_laptop.c
+++ b/drivers/platform/chrome/chromeos_laptop.c
@@ -494,6 +494,13 @@ static struct chromeos_laptop cr48 = {
},
 };
 
+static struct chromeos_laptop leon = {
+   .i2c_peripherals = {
+   /* Touchpad. */
+   { .add = setup_cyapa_tp, I2C_ADAPTER_DESIGNWARE_0 },
+   },
+};
+
 #define _CBDD(board_) \
.callback = chromeos_laptop_dmi_matched, \
.driver_data = (void *)_
@@ -581,6 +588,14 @@ static struct dmi_system_id chromeos_laptop_dmi_table[] 
__initdata = {
},
_CBDD(cr48),
},
+   {
+   .ident = "Leon",
+   .matches = {
+   DMI_MATCH(DMI_BIOS_VENDOR, "coreboot"),
+   DMI_MATCH(DMI_PRODUCT_NAME, "Leon"),
+   },
+   _CBDD(leon),
+   },
{ }
 };
 MODULE_DEVICE_TABLE(dmi, chromeos_laptop_dmi_table);
-- 
2.1.0

[PATCH 1/3] platform/chrome: chromeos_laptop: Add Leon Touch

[Enric Balletbo i Serra]

From: Gene Chen 

Add support for Leon touch devices, which is the same as
slippy/falco/peppy/wolf on the same buses using the LynxPoint-LP I2C via
the i2c-designware-pci driver.

Based on the following patch:
https://chromium-review.googlesource.com/#/c/168351/

Signed-off-by: Gene Chen 
Reviewed-by: Benson Leung 
Signed-off-by: Enric Balletbo i Serra 
---
 drivers/platform/chrome/chromeos_laptop.c | 15 +++
 1 file changed, 15 insertions(+)

diff --git a/drivers/platform/chrome/chromeos_laptop.c 
b/drivers/platform/chrome/chromeos_laptop.c
index 2b441e9..f5aa0a3 100644
--- a/drivers/platform/chrome/chromeos_laptop.c
+++ b/drivers/platform/chrome/chromeos_laptop.c
@@ -494,6 +494,13 @@ static struct chromeos_laptop cr48 = {
},
 };
 
+static struct chromeos_laptop leon = {
+   .i2c_peripherals = {
+   /* Touchpad. */
+   { .add = setup_cyapa_tp, I2C_ADAPTER_DESIGNWARE_0 },
+   },
+};
+
 #define _CBDD(board_) \
.callback = chromeos_laptop_dmi_matched, \
.driver_data = (void *)_
@@ -581,6 +588,14 @@ static struct dmi_system_id chromeos_laptop_dmi_table[] 
__initdata = {
},
_CBDD(cr48),
},
+   {
+   .ident = "Leon",
+   .matches = {
+   DMI_MATCH(DMI_BIOS_VENDOR, "coreboot"),
+   DMI_MATCH(DMI_PRODUCT_NAME, "Leon"),
+   },
+   _CBDD(leon),
+   },
{ }
 };
 MODULE_DEVICE_TABLE(dmi, chromeos_laptop_dmi_table);
-- 
2.1.0