Re: [PATCH 2/4] power: make goldfish_battery depend on GOLDFISH || COMPILE_TEST
On Thu, Jul 04, 2013 at 01:39:11AM -0400, Paul Gortmaker wrote: > Nearly all the other goldfish peripherals (mtd, keyboard, etc) > have a dependency on the main platform's GOLDFISH Kconfig item, > but this one got skipped. Even with consistency as a > justification, there was initial resistance[1] from some people > to adding it however, as they wanted the extra compile coverage. > > Now, with CONFIG_COMPILE_TEST, we have the middle ground that > will give people the coverage who want it, and let those who > don't want it to skip ever seeing the option presented. > > [1] https://lkml.org/lkml/2013/2/27/333 > > Cc: Anton Vorontsov > Cc: David Woodhouse > Cc: Jiri Slaby > Cc: Greg Kroah-Hartman > Signed-off-by: Paul Gortmaker > --- So, CONFIG_AKPM... kinda. :) It works for me. Applied, thank you! Anton -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/4] power: make goldfish_battery depend on GOLDFISH || COMPILE_TEST
On Thu, Jul 04, 2013 at 01:39:11AM -0400, Paul Gortmaker wrote: Nearly all the other goldfish peripherals (mtd, keyboard, etc) have a dependency on the main platform's GOLDFISH Kconfig item, but this one got skipped. Even with consistency as a justification, there was initial resistance[1] from some people to adding it however, as they wanted the extra compile coverage. Now, with CONFIG_COMPILE_TEST, we have the middle ground that will give people the coverage who want it, and let those who don't want it to skip ever seeing the option presented. [1] https://lkml.org/lkml/2013/2/27/333 Cc: Anton Vorontsov c...@mail.ru Cc: David Woodhouse dw...@infradead.org Cc: Jiri Slaby jsl...@suse.cz Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Signed-off-by: Paul Gortmaker paul.gortma...@windriver.com --- So, CONFIG_AKPM... kinda. :) It works for me. Applied, thank you! Anton -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 2/4] power: make goldfish_battery depend on GOLDFISH || COMPILE_TEST
Nearly all the other goldfish peripherals (mtd, keyboard, etc) have a dependency on the main platform's GOLDFISH Kconfig item, but this one got skipped. Even with consistency as a justification, there was initial resistance[1] from some people to adding it however, as they wanted the extra compile coverage. Now, with CONFIG_COMPILE_TEST, we have the middle ground that will give people the coverage who want it, and let those who don't want it to skip ever seeing the option presented. [1] https://lkml.org/lkml/2013/2/27/333 Cc: Anton Vorontsov Cc: David Woodhouse Cc: Jiri Slaby Cc: Greg Kroah-Hartman Signed-off-by: Paul Gortmaker --- drivers/power/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/Kconfig b/drivers/power/Kconfig index 7b8979c..dcc0d9e 100644 --- a/drivers/power/Kconfig +++ b/drivers/power/Kconfig @@ -357,7 +357,7 @@ config AB8500_BM config BATTERY_GOLDFISH tristate "Goldfish battery driver" - depends on GENERIC_HARDIRQS + depends on GENERIC_HARDIRQS && (GOLDFISH || COMPILE_TEST) help Say Y to enable support for the battery and AC power in the Goldfish emulator. -- 1.8.1.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 2/4] power: make goldfish_battery depend on GOLDFISH || COMPILE_TEST
Nearly all the other goldfish peripherals (mtd, keyboard, etc) have a dependency on the main platform's GOLDFISH Kconfig item, but this one got skipped. Even with consistency as a justification, there was initial resistance[1] from some people to adding it however, as they wanted the extra compile coverage. Now, with CONFIG_COMPILE_TEST, we have the middle ground that will give people the coverage who want it, and let those who don't want it to skip ever seeing the option presented. [1] https://lkml.org/lkml/2013/2/27/333 Cc: Anton Vorontsov c...@mail.ru Cc: David Woodhouse dw...@infradead.org Cc: Jiri Slaby jsl...@suse.cz Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Signed-off-by: Paul Gortmaker paul.gortma...@windriver.com --- drivers/power/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/Kconfig b/drivers/power/Kconfig index 7b8979c..dcc0d9e 100644 --- a/drivers/power/Kconfig +++ b/drivers/power/Kconfig @@ -357,7 +357,7 @@ config AB8500_BM config BATTERY_GOLDFISH tristate Goldfish battery driver - depends on GENERIC_HARDIRQS + depends on GENERIC_HARDIRQS (GOLDFISH || COMPILE_TEST) help Say Y to enable support for the battery and AC power in the Goldfish emulator. -- 1.8.1.2 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
