Re: [PATCH 3/3] dynamic_debug: replace obselete simple_strtoul() with kstrtouint()

2014-01-24 Thread Greg KH
On Fri, Jan 24, 2014 at 03:03:38PM -0500, Jason Baron wrote:
> Hi,
> 
> I think we want some sort of commit message for this patch. But they
> all look good to me and they tested fine.
> 
> Acked-by: Jason Baron 
> 
> Greg, Can you pick up this series?

Will do, after 3.14-rc1 is out, thanks.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH 3/3] dynamic_debug: replace obselete simple_strtoul() with kstrtouint()

2014-01-24 Thread Jason Baron
Hi,

I think we want some sort of commit message for this patch. But they
all look good to me and they tested fine.

Acked-by: Jason Baron 

Greg, Can you pick up this series?

Thanks,

-Jason

On 01/23/2014 08:20 AM, Andrey Ryabinin wrote:
> Signed-off-by: Andrey Ryabinin 
> ---
>  lib/dynamic_debug.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
> index e488d9a..7288e38 100644
> --- a/lib/dynamic_debug.c
> +++ b/lib/dynamic_debug.c
> @@ -268,14 +268,12 @@ static int ddebug_tokenize(char *buf, char *words[], 
> int maxwords)
>   */
>  static inline int parse_lineno(const char *str, unsigned int *val)
>  {
> - char *end = NULL;
>   BUG_ON(str == NULL);
>   if (*str == '\0') {
>   *val = 0;
>   return 0;
>   }
> - *val = simple_strtoul(str, , 10);
> - if (end == NULL || end == str || *end != '\0') {
> + if (kstrtouint(str, 10, val) < 0) {
>   pr_err("bad line-number: %s\n", str);
>   return -EINVAL;
>   }

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH 3/3] dynamic_debug: replace obselete simple_strtoul() with kstrtouint()

2014-01-24 Thread Jason Baron
Hi,

I think we want some sort of commit message for this patch. But they
all look good to me and they tested fine.

Acked-by: Jason Baron jba...@akamai.com

Greg, Can you pick up this series?

Thanks,

-Jason

On 01/23/2014 08:20 AM, Andrey Ryabinin wrote:
 Signed-off-by: Andrey Ryabinin a.ryabi...@samsung.com
 ---
  lib/dynamic_debug.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)

 diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
 index e488d9a..7288e38 100644
 --- a/lib/dynamic_debug.c
 +++ b/lib/dynamic_debug.c
 @@ -268,14 +268,12 @@ static int ddebug_tokenize(char *buf, char *words[], 
 int maxwords)
   */
  static inline int parse_lineno(const char *str, unsigned int *val)
  {
 - char *end = NULL;
   BUG_ON(str == NULL);
   if (*str == '\0') {
   *val = 0;
   return 0;
   }
 - *val = simple_strtoul(str, end, 10);
 - if (end == NULL || end == str || *end != '\0') {
 + if (kstrtouint(str, 10, val)  0) {
   pr_err(bad line-number: %s\n, str);
   return -EINVAL;
   }

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH 3/3] dynamic_debug: replace obselete simple_strtoul() with kstrtouint()

2014-01-24 Thread Greg KH
On Fri, Jan 24, 2014 at 03:03:38PM -0500, Jason Baron wrote:
 Hi,
 
 I think we want some sort of commit message for this patch. But they
 all look good to me and they tested fine.
 
 Acked-by: Jason Baron jba...@akamai.com
 
 Greg, Can you pick up this series?

Will do, after 3.14-rc1 is out, thanks.

greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH 3/3] dynamic_debug: replace obselete simple_strtoul() with kstrtouint()

2014-01-23 Thread Andrey Ryabinin
Signed-off-by: Andrey Ryabinin 
---
 lib/dynamic_debug.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index e488d9a..7288e38 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -268,14 +268,12 @@ static int ddebug_tokenize(char *buf, char *words[], int 
maxwords)
  */
 static inline int parse_lineno(const char *str, unsigned int *val)
 {
-   char *end = NULL;
BUG_ON(str == NULL);
if (*str == '\0') {
*val = 0;
return 0;
}
-   *val = simple_strtoul(str, , 10);
-   if (end == NULL || end == str || *end != '\0') {
+   if (kstrtouint(str, 10, val) < 0) {
pr_err("bad line-number: %s\n", str);
return -EINVAL;
}
-- 
1.8.3.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH 3/3] dynamic_debug: replace obselete simple_strtoul() with kstrtouint()

2014-01-23 Thread Andrey Ryabinin
Signed-off-by: Andrey Ryabinin a.ryabi...@samsung.com
---
 lib/dynamic_debug.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index e488d9a..7288e38 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -268,14 +268,12 @@ static int ddebug_tokenize(char *buf, char *words[], int 
maxwords)
  */
 static inline int parse_lineno(const char *str, unsigned int *val)
 {
-   char *end = NULL;
BUG_ON(str == NULL);
if (*str == '\0') {
*val = 0;
return 0;
}
-   *val = simple_strtoul(str, end, 10);
-   if (end == NULL || end == str || *end != '\0') {
+   if (kstrtouint(str, 10, val)  0) {
pr_err(bad line-number: %s\n, str);
return -EINVAL;
}
-- 
1.8.3.2

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/