Re: [PATCH 3/4] ARM: nomadik: add dynamic irq flag to the timer
On 03/01/2013 09:56 AM, Vincent Guittot wrote: On 1 March 2013 02:13, Linus Walleij wrote: On Tue, Feb 26, 2013 at 11:17 PM, Daniel Lezcano wrote: Add the dynamic irq affinity feature to the timer clock device. Signed-off-by: Daniel Lezcano Looks reasonable to me, sadly I do not fully grasp the patch set, Vincent+Rickard can you have a look at this? ux500 is able to trig the wake up on one CPU and let the other one in WFI. This patch will minimize the spurious wake up of CPU0 when CPU1 is the target CPU of the broadcast timer. One main consequence is that we will not uselessly execute all the deferrable and newly idle activities on the CPU0 . you can add my reviewed-by if you want Vincent It looks ok to me as well. BR Rickard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 3/4] ARM: nomadik: add dynamic irq flag to the timer
On 1 March 2013 02:13, Linus Walleij wrote: > On Tue, Feb 26, 2013 at 11:17 PM, Daniel Lezcano > wrote: > >> Add the dynamic irq affinity feature to the timer clock device. >> >> Signed-off-by: Daniel Lezcano > > Looks reasonable to me, sadly I do not fully grasp the patch set, > Vincent+Rickard can you have a look at this? ux500 is able to trig the wake up on one CPU and let the other one in WFI. This patch will minimize the spurious wake up of CPU0 when CPU1 is the target CPU of the broadcast timer. One main consequence is that we will not uselessly execute all the deferrable and newly idle activities on the CPU0 . you can add my reviewed-by if you want Vincent > > Yours, > Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 3/4] ARM: nomadik: add dynamic irq flag to the timer
On 1 March 2013 02:13, Linus Walleij linus.wall...@linaro.org wrote: On Tue, Feb 26, 2013 at 11:17 PM, Daniel Lezcano daniel.lezc...@linaro.org wrote: Add the dynamic irq affinity feature to the timer clock device. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Looks reasonable to me, sadly I do not fully grasp the patch set, Vincent+Rickard can you have a look at this? ux500 is able to trig the wake up on one CPU and let the other one in WFI. This patch will minimize the spurious wake up of CPU0 when CPU1 is the target CPU of the broadcast timer. One main consequence is that we will not uselessly execute all the deferrable and newly idle activities on the CPU0 . you can add my reviewed-by if you want Vincent Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 3/4] ARM: nomadik: add dynamic irq flag to the timer
On 03/01/2013 09:56 AM, Vincent Guittot wrote: On 1 March 2013 02:13, Linus Walleijlinus.wall...@linaro.org wrote: On Tue, Feb 26, 2013 at 11:17 PM, Daniel Lezcano daniel.lezc...@linaro.org wrote: Add the dynamic irq affinity feature to the timer clock device. Signed-off-by: Daniel Lezcanodaniel.lezc...@linaro.org Looks reasonable to me, sadly I do not fully grasp the patch set, Vincent+Rickard can you have a look at this? ux500 is able to trig the wake up on one CPU and let the other one in WFI. This patch will minimize the spurious wake up of CPU0 when CPU1 is the target CPU of the broadcast timer. One main consequence is that we will not uselessly execute all the deferrable and newly idle activities on the CPU0 . you can add my reviewed-by if you want Vincent It looks ok to me as well. BR Rickard -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 3/4] ARM: nomadik: add dynamic irq flag to the timer
On Tue, Feb 26, 2013 at 11:17 PM, Daniel Lezcano wrote: > Add the dynamic irq affinity feature to the timer clock device. > > Signed-off-by: Daniel Lezcano Looks reasonable to me, sadly I do not fully grasp the patch set, Vincent+Rickard can you have a look at this? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 3/4] ARM: nomadik: add dynamic irq flag to the timer
On Tue, Feb 26, 2013 at 11:17 PM, Daniel Lezcano daniel.lezc...@linaro.org wrote: Add the dynamic irq affinity feature to the timer clock device. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Looks reasonable to me, sadly I do not fully grasp the patch set, Vincent+Rickard can you have a look at this? Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 3/4] ARM: nomadik: add dynamic irq flag to the timer
Add the dynamic irq affinity feature to the timer clock device.
Signed-off-by: Daniel Lezcano
---
drivers/clocksource/nomadik-mtu.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/clocksource/nomadik-mtu.c
b/drivers/clocksource/nomadik-mtu.c
index 7cbcaa0..73dc540 100644
--- a/drivers/clocksource/nomadik-mtu.c
+++ b/drivers/clocksource/nomadik-mtu.c
@@ -136,7 +136,8 @@ static void nmdk_clkevt_mode(enum clock_event_mode mode,
static struct clock_event_device nmdk_clkevt = {
.name = "mtu_1",
- .features = CLOCK_EVT_FEAT_ONESHOT | CLOCK_EVT_FEAT_PERIODIC,
+ .features = CLOCK_EVT_FEAT_ONESHOT | CLOCK_EVT_FEAT_PERIODIC |
+ CLOCK_EVT_FEAT_DYNIRQ,
.rating = 200,
.set_mode = nmdk_clkevt_mode,
.set_next_event = nmdk_clkevt_next,
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 3/4] ARM: nomadik: add dynamic irq flag to the timer
Add the dynamic irq affinity feature to the timer clock device.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
drivers/clocksource/nomadik-mtu.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/clocksource/nomadik-mtu.c
b/drivers/clocksource/nomadik-mtu.c
index 7cbcaa0..73dc540 100644
--- a/drivers/clocksource/nomadik-mtu.c
+++ b/drivers/clocksource/nomadik-mtu.c
@@ -136,7 +136,8 @@ static void nmdk_clkevt_mode(enum clock_event_mode mode,
static struct clock_event_device nmdk_clkevt = {
.name = mtu_1,
- .features = CLOCK_EVT_FEAT_ONESHOT | CLOCK_EVT_FEAT_PERIODIC,
+ .features = CLOCK_EVT_FEAT_ONESHOT | CLOCK_EVT_FEAT_PERIODIC |
+ CLOCK_EVT_FEAT_DYNIRQ,
.rating = 200,
.set_mode = nmdk_clkevt_mode,
.set_next_event = nmdk_clkevt_next,
--
1.7.9.5
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
