Re: [PATCH 3/6] hid: make device_attribute const
On Mon, 21 Aug 2017, Bhumika Goyal wrote: > Make this const as it is only passed as an argument to the > function device_create_file and device_remove_file and the corresponding > arguments are of type const. > Done using Coccinelle > > Signed-off-by: Bhumika Goyal> --- > drivers/hid/hid-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c > index 9bc9116..24e929c 100644 > --- a/drivers/hid/hid-core.c > +++ b/drivers/hid/hid-core.c > @@ -1662,7 +1662,7 @@ static bool hid_hiddev(struct hid_device *hdev) > .size = HID_MAX_DESCRIPTOR_SIZE, > }; > > -static struct device_attribute dev_attr_country = { > +static const struct device_attribute dev_attr_country = { > .attr = { .name = "country", .mode = 0444 }, > .show = show_country, Applied, thanks. -- Jiri Kosina SUSE Labs
Re: [PATCH 3/6] hid: make device_attribute const
On Mon, 21 Aug 2017, Bhumika Goyal wrote: > Make this const as it is only passed as an argument to the > function device_create_file and device_remove_file and the corresponding > arguments are of type const. > Done using Coccinelle > > Signed-off-by: Bhumika Goyal > --- > drivers/hid/hid-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c > index 9bc9116..24e929c 100644 > --- a/drivers/hid/hid-core.c > +++ b/drivers/hid/hid-core.c > @@ -1662,7 +1662,7 @@ static bool hid_hiddev(struct hid_device *hdev) > .size = HID_MAX_DESCRIPTOR_SIZE, > }; > > -static struct device_attribute dev_attr_country = { > +static const struct device_attribute dev_attr_country = { > .attr = { .name = "country", .mode = 0444 }, > .show = show_country, Applied, thanks. -- Jiri Kosina SUSE Labs
[PATCH 3/6] hid: make device_attribute const
Make this const as it is only passed as an argument to the function device_create_file and device_remove_file and the corresponding arguments are of type const. Done using Coccinelle Signed-off-by: Bhumika Goyal--- drivers/hid/hid-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index 9bc9116..24e929c 100644 --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c @@ -1662,7 +1662,7 @@ static bool hid_hiddev(struct hid_device *hdev) .size = HID_MAX_DESCRIPTOR_SIZE, }; -static struct device_attribute dev_attr_country = { +static const struct device_attribute dev_attr_country = { .attr = { .name = "country", .mode = 0444 }, .show = show_country, }; -- 1.9.1
[PATCH 3/6] hid: make device_attribute const
Make this const as it is only passed as an argument to the function device_create_file and device_remove_file and the corresponding arguments are of type const. Done using Coccinelle Signed-off-by: Bhumika Goyal --- drivers/hid/hid-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index 9bc9116..24e929c 100644 --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c @@ -1662,7 +1662,7 @@ static bool hid_hiddev(struct hid_device *hdev) .size = HID_MAX_DESCRIPTOR_SIZE, }; -static struct device_attribute dev_attr_country = { +static const struct device_attribute dev_attr_country = { .attr = { .name = "country", .mode = 0444 }, .show = show_country, }; -- 1.9.1