Re: [PATCH 7/9] drivers: ata: sata_dwc_460ex: use devm_platform_ioremap_resource()

[Bartlomiej Zolnierkiewicz]

On 8/20/19 2:35 PM, Enrico Weigelt, metux IT consult wrote:
> Use the new helper that wraps the calls to platform_get_resource()
> and devm_ioremap_resource() together.
> 
> Signed-off-by: Enrico Weigelt, metux IT consult 

Acked-by: Bartlomiej Zolnierkiewicz 

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R Institute Poland
Samsung Electronics

> ---
>  drivers/ata/sata_dwc_460ex.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_460ex.c
> index 9dcef6a..de248fa 100644
> --- a/drivers/ata/sata_dwc_460ex.c
> +++ b/drivers/ata/sata_dwc_460ex.c
> @@ -237,7 +237,6 @@ static int sata_dwc_dma_init_old(struct platform_device 
> *pdev,
>struct sata_dwc_device *hsdev)
>  {
>   struct device_node *np = pdev->dev.of_node;
> - struct resource *res;
>  
>   hsdev->dma = devm_kzalloc(>dev, sizeof(*hsdev->dma), GFP_KERNEL);
>   if (!hsdev->dma)
> @@ -254,8 +253,7 @@ static int sata_dwc_dma_init_old(struct platform_device 
> *pdev,
>   }
>  
>   /* Get physical SATA DMA register base address */
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> - hsdev->dma->regs = devm_ioremap_resource(>dev, res);
> + hsdev->dma->regs = devm_platform_ioremap_resource(pdev, 1);
>   if (IS_ERR(hsdev->dma->regs))
>   return PTR_ERR(hsdev->dma->regs);

[PATCH 7/9] drivers: ata: sata_dwc_460ex: use devm_platform_ioremap_resource()

[Enrico Weigelt, metux IT consult]

Use the new helper that wraps the calls to platform_get_resource()
and devm_ioremap_resource() together.

Signed-off-by: Enrico Weigelt, metux IT consult 
---
 drivers/ata/sata_dwc_460ex.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_460ex.c
index 9dcef6a..de248fa 100644
--- a/drivers/ata/sata_dwc_460ex.c
+++ b/drivers/ata/sata_dwc_460ex.c
@@ -237,7 +237,6 @@ static int sata_dwc_dma_init_old(struct platform_device 
*pdev,
 struct sata_dwc_device *hsdev)
 {
struct device_node *np = pdev->dev.of_node;
-   struct resource *res;
 
hsdev->dma = devm_kzalloc(>dev, sizeof(*hsdev->dma), GFP_KERNEL);
if (!hsdev->dma)
@@ -254,8 +253,7 @@ static int sata_dwc_dma_init_old(struct platform_device 
*pdev,
}
 
/* Get physical SATA DMA register base address */
-   res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
-   hsdev->dma->regs = devm_ioremap_resource(>dev, res);
+   hsdev->dma->regs = devm_platform_ioremap_resource(pdev, 1);
if (IS_ERR(hsdev->dma->regs))
return PTR_ERR(hsdev->dma->regs);
 
-- 
1.9.1

[PATCH 7/9] drivers: ata: sata_dwc_460ex: use devm_platform_ioremap_resource()

[Enrico Weigelt, metux IT consult]

Use the new helper that wraps the calls to platform_get_resource()
and devm_ioremap_resource() together.

Signed-off-by: Enrico Weigelt, metux IT consult 
---
 drivers/ata/sata_dwc_460ex.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_460ex.c
index 6f142aa..c57b348 100644
--- a/drivers/ata/sata_dwc_460ex.c
+++ b/drivers/ata/sata_dwc_460ex.c
@@ -241,7 +241,6 @@ static int sata_dwc_dma_init_old(struct platform_device 
*pdev,
 struct sata_dwc_device *hsdev)
 {
struct device_node *np = pdev->dev.of_node;
-   struct resource *res;
 
hsdev->dma = devm_kzalloc(>dev, sizeof(*hsdev->dma), GFP_KERNEL);
if (!hsdev->dma)
@@ -258,8 +257,7 @@ static int sata_dwc_dma_init_old(struct platform_device 
*pdev,
}
 
/* Get physical SATA DMA register base address */
-   res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
-   hsdev->dma->regs = devm_ioremap_resource(>dev, res);
+   hsdev->dma->regs = devm_platform_ioremap_resource(pdev, 1);
if (IS_ERR(hsdev->dma->regs))
return PTR_ERR(hsdev->dma->regs);
 
-- 
1.9.1