Re: [PATCH V7 1/4] dt-bindings: fsl: scu: add general interrupt support

2019-04-11 Thread Shawn Guo
On Tue, Apr 09, 2019 at 04:59:49AM +, Anson Huang wrote:
> Add scu general interrupt function support.
> 
> Signed-off-by: Anson Huang 
> Reviewed-by: Rob Herring 
> Reviewed-by: Dong Aisheng 

Applied, thanks.


RE: [PATCH V7 1/4] dt-bindings: fsl: scu: add general interrupt support

2019-04-10 Thread Anson Huang
Hi, Shawn
Can you pick up this patch series if no additional comments? We need 
this feature to support many modules IRQ function including suspend/resume, 
thanks. 

Best Regards!
Anson Huang

> -Original Message-
> From: Anson Huang
> Sent: 2019年4月9日 13:00
> To: robh...@kernel.org; mark.rutl...@arm.com; shawn...@kernel.org;
> s.ha...@pengutronix.de; ker...@pengutronix.de; feste...@gmail.com;
> a.zu...@towertech.it; alexandre.bell...@bootlin.com; Aisheng Dong
> ; ulf.hans...@linaro.org; sb...@kernel.org; Peng
> Fan ; Daniel Baluta ;
> devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm-
> ker...@lists.infradead.org; linux-...@vger.kernel.org
> Cc: dl-linux-imx 
> Subject: [PATCH V7 1/4] dt-bindings: fsl: scu: add general interrupt support
> 
> Add scu general interrupt function support.
> 
> Signed-off-by: Anson Huang 
> Reviewed-by: Rob Herring 
> Reviewed-by: Dong Aisheng 
> ---
> No changes.
> ---
>  .../devicetree/bindings/arm/freescale/fsl,scu.txt  | 29 +--
> ---
>  1 file changed, 23 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> index 72d481c..5d7dbab 100644
> --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> @@ -22,9 +22,11 @@ Required properties:
>  ---
>  - compatible:should be "fsl,imx-scu".
>  - mbox-names:should include "tx0", "tx1", "tx2", "tx3",
> -"rx0", "rx1", "rx2", "rx3".
> -- mboxes:List of phandle of 4 MU channels for tx and 4 MU channels
> - for rx. All 8 MU channels must be in the same MU instance.
> +"rx0", "rx1", "rx2", "rx3";
> + include "gip3" if want to support general MU interrupt.
> +- mboxes:List of phandle of 4 MU channels for tx, 4 MU channels for
> + rx, and 1 optional MU channel for general interrupt.
> + All MU channels must be in the same MU instance.
>   Cross instances are not allowed. The MU instance can only
>   be one of LSIO MU0~M4 for imx8qxp and imx8qm. Users
> need
>   to make sure use the one which is not conflict with other @@
> -34,6 +36,7 @@ Required properties:
>   Channel 1 must be "tx1" or "rx1".
>   Channel 2 must be "tx2" or "rx2".
>   Channel 3 must be "tx3" or "rx3".
> + General interrupt rx channel must be "gip3".
>   e.g.
>   mboxes = <_mu1 0 0
> _mu1 0 1
> @@ -42,10 +45,18 @@ Required properties:
> _mu1 1 0
> _mu1 1 1
> _mu1 1 2
> -   _mu1 1 3>;
> +   _mu1 1 3
> +   _mu1 3 3>;
>   See Documentation/devicetree/bindings/mailbox/fsl,mu.txt
>   for detailed mailbox binding.
> 
> +Note: Each mu which supports general interrupt should have an alias
> +correctly numbered in "aliases" node.
> +e.g.
> +aliases {
> + mu1 = _mu1;
> +};
> +
>  i.MX SCU Client Device Node:
>  
> 
> @@ -124,6 +135,10 @@ Required properties:
> 
>  Example (imx8qxp):
>  -
> +aliases {
> + mu1 = _mu1;
> +};
> +
>  lsio_mu1: mailbox@5d1c {
>   ...
>   #mbox-cells = <2>;
> @@ -133,7 +148,8 @@ firmware {
>   scu {
>   compatible = "fsl,imx-scu";
>   mbox-names = "tx0", "tx1", "tx2", "tx3",
> -  "rx0", "rx1", "rx2", "rx3";
> +  "rx0", "rx1", "rx2", "rx3",
> +  "gip3";
>   mboxes = <_mu1 0 0
> _mu1 0 1
> _mu1 0 2
> @@ -141,7 +157,8 @@ firmware {
> _mu1 1 0
> _mu1 1 1
> _mu1 1 2
> -   _mu1 1 3>;
> +   _mu1 1 3
> +   _mu1 3 3>;
> 
>   clk: clk {
>   compatible = "fsl,imx8qxp-clk", "fsl,scu-clk";
> --
> 2.7.4



[PATCH V7 1/4] dt-bindings: fsl: scu: add general interrupt support

2019-04-08 Thread Anson Huang
Add scu general interrupt function support.

Signed-off-by: Anson Huang 
Reviewed-by: Rob Herring 
Reviewed-by: Dong Aisheng 
---
No changes.
---
 .../devicetree/bindings/arm/freescale/fsl,scu.txt  | 29 +-
 1 file changed, 23 insertions(+), 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt 
b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
index 72d481c..5d7dbab 100644
--- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
+++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
@@ -22,9 +22,11 @@ Required properties:
 ---
 - compatible:  should be "fsl,imx-scu".
 - mbox-names:  should include "tx0", "tx1", "tx2", "tx3",
-  "rx0", "rx1", "rx2", "rx3".
-- mboxes:  List of phandle of 4 MU channels for tx and 4 MU channels
-   for rx. All 8 MU channels must be in the same MU instance.
+  "rx0", "rx1", "rx2", "rx3";
+   include "gip3" if want to support general MU interrupt.
+- mboxes:  List of phandle of 4 MU channels for tx, 4 MU channels for
+   rx, and 1 optional MU channel for general interrupt.
+   All MU channels must be in the same MU instance.
Cross instances are not allowed. The MU instance can only
be one of LSIO MU0~M4 for imx8qxp and imx8qm. Users need
to make sure use the one which is not conflict with other
@@ -34,6 +36,7 @@ Required properties:
Channel 1 must be "tx1" or "rx1".
Channel 2 must be "tx2" or "rx2".
Channel 3 must be "tx3" or "rx3".
+   General interrupt rx channel must be "gip3".
e.g.
mboxes = <_mu1 0 0
  _mu1 0 1
@@ -42,10 +45,18 @@ Required properties:
  _mu1 1 0
  _mu1 1 1
  _mu1 1 2
- _mu1 1 3>;
+ _mu1 1 3
+ _mu1 3 3>;
See Documentation/devicetree/bindings/mailbox/fsl,mu.txt
for detailed mailbox binding.
 
+Note: Each mu which supports general interrupt should have an alias correctly
+numbered in "aliases" node.
+e.g.
+aliases {
+   mu1 = _mu1;
+};
+
 i.MX SCU Client Device Node:
 
 
@@ -124,6 +135,10 @@ Required properties:
 
 Example (imx8qxp):
 -
+aliases {
+   mu1 = _mu1;
+};
+
 lsio_mu1: mailbox@5d1c {
...
#mbox-cells = <2>;
@@ -133,7 +148,8 @@ firmware {
scu {
compatible = "fsl,imx-scu";
mbox-names = "tx0", "tx1", "tx2", "tx3",
-"rx0", "rx1", "rx2", "rx3";
+"rx0", "rx1", "rx2", "rx3",
+"gip3";
mboxes = <_mu1 0 0
  _mu1 0 1
  _mu1 0 2
@@ -141,7 +157,8 @@ firmware {
  _mu1 1 0
  _mu1 1 1
  _mu1 1 2
- _mu1 1 3>;
+ _mu1 1 3
+ _mu1 3 3>;
 
clk: clk {
compatible = "fsl,imx8qxp-clk", "fsl,scu-clk";
-- 
2.7.4