Re: [PATCH net-next] net: dsa: remove dsa_port_is_bridged

[David Miller]

From: Vivien Didelot 
Date: Fri, 26 May 2017 18:12:42 -0400

> The helper is only used once and makes the code more complicated that it
> should. Remove it and reorganize the variables so that it fits on 80
> columns.
> 
> Signed-off-by: Vivien Didelot 

Applied, thanks.

Re: [PATCH net-next] net: dsa: remove dsa_port_is_bridged

[David Miller]

From: Vivien Didelot 
Date: Fri, 26 May 2017 18:12:42 -0400

> The helper is only used once and makes the code more complicated that it
> should. Remove it and reorganize the variables so that it fits on 80
> columns.
> 
> Signed-off-by: Vivien Didelot 

Applied, thanks.

[PATCH net-next] net: dsa: remove dsa_port_is_bridged

[Vivien Didelot]

The helper is only used once and makes the code more complicated that it
should. Remove it and reorganize the variables so that it fits on 80
columns.

Signed-off-by: Vivien Didelot 
---
 net/dsa/slave.c | 13 -
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/net/dsa/slave.c b/net/dsa/slave.c
index 887e26695519..0442b6bf52fa 100644
--- a/net/dsa/slave.c
+++ b/net/dsa/slave.c
@@ -69,18 +69,13 @@ static int dsa_slave_get_iflink(const struct net_device 
*dev)
return p->dp->ds->dst->master_netdev->ifindex;
 }
 
-static inline bool dsa_port_is_bridged(struct dsa_port *dp)
-{
-   return !!dp->bridge_dev;
-}
-
 static int dsa_slave_open(struct net_device *dev)
 {
struct dsa_slave_priv *p = netdev_priv(dev);
-   struct net_device *master = p->dp->ds->dst->master_netdev;
-   struct dsa_switch *ds = p->dp->ds;
-   u8 stp_state = dsa_port_is_bridged(p->dp) ?
-   BR_STATE_BLOCKING : BR_STATE_FORWARDING;
+   struct dsa_port *dp = p->dp;
+   struct dsa_switch *ds = dp->ds;
+   struct net_device *master = ds->dst->master_netdev;
+   u8 stp_state = dp->bridge_dev ? BR_STATE_BLOCKING : BR_STATE_FORWARDING;
int err;
 
if (!(master->flags & IFF_UP))
-- 
2.13.0

[PATCH net-next] net: dsa: remove dsa_port_is_bridged

[Vivien Didelot]

The helper is only used once and makes the code more complicated that it
should. Remove it and reorganize the variables so that it fits on 80
columns.

Signed-off-by: Vivien Didelot 
---
 net/dsa/slave.c | 13 -
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/net/dsa/slave.c b/net/dsa/slave.c
index 887e26695519..0442b6bf52fa 100644
--- a/net/dsa/slave.c
+++ b/net/dsa/slave.c
@@ -69,18 +69,13 @@ static int dsa_slave_get_iflink(const struct net_device 
*dev)
return p->dp->ds->dst->master_netdev->ifindex;
 }
 
-static inline bool dsa_port_is_bridged(struct dsa_port *dp)
-{
-   return !!dp->bridge_dev;
-}
-
 static int dsa_slave_open(struct net_device *dev)
 {
struct dsa_slave_priv *p = netdev_priv(dev);
-   struct net_device *master = p->dp->ds->dst->master_netdev;
-   struct dsa_switch *ds = p->dp->ds;
-   u8 stp_state = dsa_port_is_bridged(p->dp) ?
-   BR_STATE_BLOCKING : BR_STATE_FORWARDING;
+   struct dsa_port *dp = p->dp;
+   struct dsa_switch *ds = dp->ds;
+   struct net_device *master = ds->dst->master_netdev;
+   u8 stp_state = dp->bridge_dev ? BR_STATE_BLOCKING : BR_STATE_FORWARDING;
int err;
 
if (!(master->flags & IFF_UP))
-- 
2.13.0

Re: [PATCH net-next] net: dsa: remove dsa_port_is_bridged

[Florian Fainelli]

On 05/26/2017 03:12 PM, Vivien Didelot wrote:
> The helper is only used once and makes the code more complicated that it
> should. Remove it and reorganize the variables so that it fits on 80
> columns.
> 
> Signed-off-by: Vivien Didelot 

Reviewed-by: Florian Fainelli 
-- 
Florian

Re: [PATCH net-next] net: dsa: remove dsa_port_is_bridged

[Florian Fainelli]

On 05/26/2017 03:12 PM, Vivien Didelot wrote:
> The helper is only used once and makes the code more complicated that it
> should. Remove it and reorganize the variables so that it fits on 80
> columns.
> 
> Signed-off-by: Vivien Didelot 

Reviewed-by: Florian Fainelli 
-- 
Florian