Re: [PATCH v14 0/3] Add drm driver for Rockchip Socs
On Thu, Nov 27, 2014 at 4:56 PM, Arnd Bergmann wrote: > On Thursday 27 November 2014 14:05:00 Daniel Kurtz wrote: >> On Thu, Nov 27, 2014 at 2:08 AM, Mark yao wrote: >> > >> > On 2014年11月27日 10:12, Dave Airlie wrote: >> >> >> >>> Hi Dave >> >>> Do you mean that I need send you a branch, based on drm-next, merge >> >>> with >> >>> iommu tree and rockchip drm? >> >> >> >> Yes, grab drm-next, git pull the arm/rockchip branch from Joerg's >> >> tree, put rockchip drm >> >> patches on top, send me pull request. >> >> >> >> I'll validate it then. >> >> >> >> Dave. >> >> >> > Hi Dave >> > I have send a pull request to you, with Joerg's iommu arm/rockchip >> > branch. >> > >> > I got a same problem when use "make multi_v7_defconfig" as Heiko said: >> > drivers/video/fbdev/Kconfig:5:error: recursive dependency detected! >> > drivers/video/fbdev/Kconfig:5:symbol FB is selected by >> > DRM_KMS_FB_HELPER >> > drivers/gpu/drm/Kconfig:34:symbol DRM_KMS_FB_HELPER is >> > selected by DRM_ROCKCHIP >> > drivers/gpu/drm/rockchip/Kconfig:1:symbol DRM_ROCKCHIP depends >> > on ARM_DMA_USE_IOMMU >> > arch/arm/Kconfig:95:symbol ARM_DMA_USE_IOMMU is selected by >> > VIDEO_OMAP3 >> > drivers/media/platform/Kconfig:96:symbol VIDEO_OMAP3 depends >> > on VIDEO_V4L2 >> > drivers/media/v4l2-core/Kconfig:6:symbol VIDEO_V4L2 depends on >> > I2C >> > drivers/i2c/Kconfig:7:symbol I2C is selected by FB_DDC >> > drivers/video/fbdev/Kconfig:59:symbol FB_DDC is selected by >> > FB_CYBER2000_DDC >> > drivers/video/fbdev/Kconfig:374:symbol FB_CYBER2000_DDC >> > depends on FB_CYBER2000 >> > drivers/video/fbdev/Kconfig:362:symbol FB_CYBER2000 depends on >> > FB >> > >> > I was confused how to solve the recursive dependency, remove depends >> > on ARM_DMA_USE_IOMMU & IOMMU_API? >> >> The "depends on ARM_DMA_USE_IOMMU & IOMMU_API" was suggested by Arnd >> Bergmann during code review (originally they were selected). >> >> Removing them definitely fixes the dependency recursion. >> Also, since they are both already selected by ROCKCHIP_IOMMU, >> everything will build correctly. >> So, this sounds good to me, but I am no expert on Kconfig. >> > > I think the problem here is VIDEO_OMAP3 (among others), it should do the > same as rockchips and use 'depends on' instead of 'select'. > > Another problem is the 'select I2C' in FB_DDC, but that would be much harder > to fix. that 'select I2C' is the source of many loops.. I'd looked at it briefly before, but then ran away in despair. BR, -R > Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v14 0/3] Add drm driver for Rockchip Socs
Am Donnerstag, 27. November 2014, 14:05:00 schrieb Daniel Kurtz: > On Thu, Nov 27, 2014 at 2:08 AM, Mark yao wrote: > > On 2014年11月27日 10:12, Dave Airlie wrote: > >>> Hi Dave > >>> > >>> Do you mean that I need send you a branch, based on drm-next, merge > >>> with > >>> > >>> iommu tree and rockchip drm? > >> > >> Yes, grab drm-next, git pull the arm/rockchip branch from Joerg's > >> tree, put rockchip drm > >> patches on top, send me pull request. > >> > >> I'll validate it then. > >> > >> Dave. > > > > Hi Dave > > > > I have send a pull request to you, with Joerg's iommu arm/rockchip > > branch. > > > > I got a same problem when use "make multi_v7_defconfig" as Heiko said: > > drivers/video/fbdev/Kconfig:5:error: recursive dependency > > detected! > > drivers/video/fbdev/Kconfig:5:symbol FB is selected by > > DRM_KMS_FB_HELPER drivers/gpu/drm/Kconfig:34:symbol > > DRM_KMS_FB_HELPER is selected by DRM_ROCKCHIP > > drivers/gpu/drm/rockchip/Kconfig:1:symbol DRM_ROCKCHIP > > depends on ARM_DMA_USE_IOMMU arch/arm/Kconfig:95:symbol > > ARM_DMA_USE_IOMMU is selected by VIDEO_OMAP3 > > drivers/media/platform/Kconfig:96:symbol VIDEO_OMAP3 depends > > on VIDEO_V4L2 drivers/media/v4l2-core/Kconfig:6:symbol > > VIDEO_V4L2 depends on I2C drivers/i2c/Kconfig:7:symbol I2C is > > selected by FB_DDC > > drivers/video/fbdev/Kconfig:59:symbol FB_DDC is selected by > > FB_CYBER2000_DDC drivers/video/fbdev/Kconfig:374:symbol > > FB_CYBER2000_DDC depends on FB_CYBER2000 > > drivers/video/fbdev/Kconfig:362:symbol FB_CYBER2000 depends > > on FB> > > I was confused how to solve the recursive dependency, remove depends > > on ARM_DMA_USE_IOMMU & IOMMU_API? > The "depends on ARM_DMA_USE_IOMMU & IOMMU_API" was suggested by Arnd > Bergmann during code review (originally they were selected). > > Removing them definitely fixes the dependency recursion. > Also, since they are both already selected by ROCKCHIP_IOMMU, > everything will build correctly. > So, this sounds good to me, but I am no expert on Kconfig. personally I'd think the omap v4l stuff is at fault here. It is selecting ARM_DMA_USE_IOMMU and OMAP_IOMMU instead of depending on them. And OMAP_IOMMU is a regular driver option which can be selected through Kconfig, so I don't think it should get selected but enabled by choice. It would be interesting to know if the Exynos drm is also affected by this, as it is using a similar depency-structure by depending on the iommu and ARM_DMA_USE_IOMMU. Heiko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v14 0/3] Add drm driver for Rockchip Socs
On Thursday 27 November 2014 14:05:00 Daniel Kurtz wrote: > On Thu, Nov 27, 2014 at 2:08 AM, Mark yao wrote: > > > > On 2014年11月27日 10:12, Dave Airlie wrote: > > > >>> Hi Dave > >>> Do you mean that I need send you a branch, based on drm-next, merge > >>> with > >>> iommu tree and rockchip drm? > >> > >> Yes, grab drm-next, git pull the arm/rockchip branch from Joerg's > >> tree, put rockchip drm > >> patches on top, send me pull request. > >> > >> I'll validate it then. > >> > >> Dave. > >> > > Hi Dave > > I have send a pull request to you, with Joerg's iommu arm/rockchip > > branch. > > > > I got a same problem when use "make multi_v7_defconfig" as Heiko said: > > drivers/video/fbdev/Kconfig:5:error: recursive dependency detected! > > drivers/video/fbdev/Kconfig:5:symbol FB is selected by > > DRM_KMS_FB_HELPER > > drivers/gpu/drm/Kconfig:34:symbol DRM_KMS_FB_HELPER is selected > > by DRM_ROCKCHIP > > drivers/gpu/drm/rockchip/Kconfig:1:symbol DRM_ROCKCHIP depends > > on ARM_DMA_USE_IOMMU > > arch/arm/Kconfig:95:symbol ARM_DMA_USE_IOMMU is selected by > > VIDEO_OMAP3 > > drivers/media/platform/Kconfig:96:symbol VIDEO_OMAP3 depends on > > VIDEO_V4L2 > > drivers/media/v4l2-core/Kconfig:6:symbol VIDEO_V4L2 depends on > > I2C > > drivers/i2c/Kconfig:7:symbol I2C is selected by FB_DDC > > drivers/video/fbdev/Kconfig:59:symbol FB_DDC is selected by > > FB_CYBER2000_DDC > > drivers/video/fbdev/Kconfig:374:symbol FB_CYBER2000_DDC depends > > on FB_CYBER2000 > > drivers/video/fbdev/Kconfig:362:symbol FB_CYBER2000 depends on > > FB > > > > I was confused how to solve the recursive dependency, remove depends on > > ARM_DMA_USE_IOMMU & IOMMU_API? > > The "depends on ARM_DMA_USE_IOMMU & IOMMU_API" was suggested by Arnd > Bergmann during code review (originally they were selected). > > Removing them definitely fixes the dependency recursion. > Also, since they are both already selected by ROCKCHIP_IOMMU, > everything will build correctly. > So, this sounds good to me, but I am no expert on Kconfig. > I think the problem here is VIDEO_OMAP3 (among others), it should do the same as rockchips and use 'depends on' instead of 'select'. Another problem is the 'select I2C' in FB_DDC, but that would be much harder to fix. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v14 0/3] Add drm driver for Rockchip Socs
On Thu, Nov 27, 2014 at 2:08 AM, Mark yao wrote: > > On 2014年11月27日 10:12, Dave Airlie wrote: >>> Hi Dave >>> Do you mean that I need send you a branch, based on drm-next, merge >>> with >>> iommu tree and rockchip drm? >> >> Yes, grab drm-next, git pull the arm/rockchip branch from Joerg's >> tree, put rockchip drm >> patches on top, send me pull request. >> >> I'll validate it then. >> >> Dave. >> > Hi Dave > I have send a pull request to you, with Joerg's iommu arm/rockchip branch. > > I got a same problem when use "make multi_v7_defconfig" as Heiko said: > drivers/video/fbdev/Kconfig:5:error: recursive dependency detected! > drivers/video/fbdev/Kconfig:5:symbol FB is selected by > DRM_KMS_FB_HELPER > drivers/gpu/drm/Kconfig:34:symbol DRM_KMS_FB_HELPER is selected > by DRM_ROCKCHIP > drivers/gpu/drm/rockchip/Kconfig:1:symbol DRM_ROCKCHIP depends on > ARM_DMA_USE_IOMMU > arch/arm/Kconfig:95:symbol ARM_DMA_USE_IOMMU is selected by > VIDEO_OMAP3 > drivers/media/platform/Kconfig:96:symbol VIDEO_OMAP3 depends on > VIDEO_V4L2 > drivers/media/v4l2-core/Kconfig:6:symbol VIDEO_V4L2 depends on I2C > drivers/i2c/Kconfig:7:symbol I2C is selected by FB_DDC > drivers/video/fbdev/Kconfig:59:symbol FB_DDC is selected by > FB_CYBER2000_DDC > drivers/video/fbdev/Kconfig:374:symbol FB_CYBER2000_DDC depends > on FB_CYBER2000 > drivers/video/fbdev/Kconfig:362:symbol FB_CYBER2000 depends on FB > > I was confused how to solve the recursive dependency, remove depends on > ARM_DMA_USE_IOMMU & IOMMU_API? The "depends on ARM_DMA_USE_IOMMU & IOMMU_API" was suggested by Arnd Bergmann during code review (originally they were selected). Removing them definitely fixes the dependency recursion. Also, since they are both already selected by ROCKCHIP_IOMMU, everything will build correctly. So, this sounds good to me, but I am no expert on Kconfig. -Dan > > - Mark -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v14 0/3] Add drm driver for Rockchip Socs
On Thu, Nov 27, 2014 at 2:08 AM, Mark yao mark@rock-chips.com wrote: On 2014年11月27日 10:12, Dave Airlie wrote: Hi Dave Do you mean that I need send you a branch, based on drm-next, merge with iommu tree and rockchip drm? Yes, grab drm-next, git pull the arm/rockchip branch from Joerg's tree, put rockchip drm patches on top, send me pull request. I'll validate it then. Dave. Hi Dave I have send a pull request to you, with Joerg's iommu arm/rockchip branch. I got a same problem when use make multi_v7_defconfig as Heiko said: drivers/video/fbdev/Kconfig:5:error: recursive dependency detected! drivers/video/fbdev/Kconfig:5:symbol FB is selected by DRM_KMS_FB_HELPER drivers/gpu/drm/Kconfig:34:symbol DRM_KMS_FB_HELPER is selected by DRM_ROCKCHIP drivers/gpu/drm/rockchip/Kconfig:1:symbol DRM_ROCKCHIP depends on ARM_DMA_USE_IOMMU arch/arm/Kconfig:95:symbol ARM_DMA_USE_IOMMU is selected by VIDEO_OMAP3 drivers/media/platform/Kconfig:96:symbol VIDEO_OMAP3 depends on VIDEO_V4L2 drivers/media/v4l2-core/Kconfig:6:symbol VIDEO_V4L2 depends on I2C drivers/i2c/Kconfig:7:symbol I2C is selected by FB_DDC drivers/video/fbdev/Kconfig:59:symbol FB_DDC is selected by FB_CYBER2000_DDC drivers/video/fbdev/Kconfig:374:symbol FB_CYBER2000_DDC depends on FB_CYBER2000 drivers/video/fbdev/Kconfig:362:symbol FB_CYBER2000 depends on FB I was confused how to solve the recursive dependency, remove depends on ARM_DMA_USE_IOMMU IOMMU_API? The depends on ARM_DMA_USE_IOMMU IOMMU_API was suggested by Arnd Bergmann during code review (originally they were selected). Removing them definitely fixes the dependency recursion. Also, since they are both already selected by ROCKCHIP_IOMMU, everything will build correctly. So, this sounds good to me, but I am no expert on Kconfig. -Dan - Mark -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v14 0/3] Add drm driver for Rockchip Socs
On Thursday 27 November 2014 14:05:00 Daniel Kurtz wrote: On Thu, Nov 27, 2014 at 2:08 AM, Mark yao mark@rock-chips.com wrote: On 2014年11月27日 10:12, Dave Airlie wrote: Hi Dave Do you mean that I need send you a branch, based on drm-next, merge with iommu tree and rockchip drm? Yes, grab drm-next, git pull the arm/rockchip branch from Joerg's tree, put rockchip drm patches on top, send me pull request. I'll validate it then. Dave. Hi Dave I have send a pull request to you, with Joerg's iommu arm/rockchip branch. I got a same problem when use make multi_v7_defconfig as Heiko said: drivers/video/fbdev/Kconfig:5:error: recursive dependency detected! drivers/video/fbdev/Kconfig:5:symbol FB is selected by DRM_KMS_FB_HELPER drivers/gpu/drm/Kconfig:34:symbol DRM_KMS_FB_HELPER is selected by DRM_ROCKCHIP drivers/gpu/drm/rockchip/Kconfig:1:symbol DRM_ROCKCHIP depends on ARM_DMA_USE_IOMMU arch/arm/Kconfig:95:symbol ARM_DMA_USE_IOMMU is selected by VIDEO_OMAP3 drivers/media/platform/Kconfig:96:symbol VIDEO_OMAP3 depends on VIDEO_V4L2 drivers/media/v4l2-core/Kconfig:6:symbol VIDEO_V4L2 depends on I2C drivers/i2c/Kconfig:7:symbol I2C is selected by FB_DDC drivers/video/fbdev/Kconfig:59:symbol FB_DDC is selected by FB_CYBER2000_DDC drivers/video/fbdev/Kconfig:374:symbol FB_CYBER2000_DDC depends on FB_CYBER2000 drivers/video/fbdev/Kconfig:362:symbol FB_CYBER2000 depends on FB I was confused how to solve the recursive dependency, remove depends on ARM_DMA_USE_IOMMU IOMMU_API? The depends on ARM_DMA_USE_IOMMU IOMMU_API was suggested by Arnd Bergmann during code review (originally they were selected). Removing them definitely fixes the dependency recursion. Also, since they are both already selected by ROCKCHIP_IOMMU, everything will build correctly. So, this sounds good to me, but I am no expert on Kconfig. I think the problem here is VIDEO_OMAP3 (among others), it should do the same as rockchips and use 'depends on' instead of 'select'. Another problem is the 'select I2C' in FB_DDC, but that would be much harder to fix. Arnd -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v14 0/3] Add drm driver for Rockchip Socs
Am Donnerstag, 27. November 2014, 14:05:00 schrieb Daniel Kurtz: On Thu, Nov 27, 2014 at 2:08 AM, Mark yao mark@rock-chips.com wrote: On 2014年11月27日 10:12, Dave Airlie wrote: Hi Dave Do you mean that I need send you a branch, based on drm-next, merge with iommu tree and rockchip drm? Yes, grab drm-next, git pull the arm/rockchip branch from Joerg's tree, put rockchip drm patches on top, send me pull request. I'll validate it then. Dave. Hi Dave I have send a pull request to you, with Joerg's iommu arm/rockchip branch. I got a same problem when use make multi_v7_defconfig as Heiko said: drivers/video/fbdev/Kconfig:5:error: recursive dependency detected! drivers/video/fbdev/Kconfig:5:symbol FB is selected by DRM_KMS_FB_HELPER drivers/gpu/drm/Kconfig:34:symbol DRM_KMS_FB_HELPER is selected by DRM_ROCKCHIP drivers/gpu/drm/rockchip/Kconfig:1:symbol DRM_ROCKCHIP depends on ARM_DMA_USE_IOMMU arch/arm/Kconfig:95:symbol ARM_DMA_USE_IOMMU is selected by VIDEO_OMAP3 drivers/media/platform/Kconfig:96:symbol VIDEO_OMAP3 depends on VIDEO_V4L2 drivers/media/v4l2-core/Kconfig:6:symbol VIDEO_V4L2 depends on I2C drivers/i2c/Kconfig:7:symbol I2C is selected by FB_DDC drivers/video/fbdev/Kconfig:59:symbol FB_DDC is selected by FB_CYBER2000_DDC drivers/video/fbdev/Kconfig:374:symbol FB_CYBER2000_DDC depends on FB_CYBER2000 drivers/video/fbdev/Kconfig:362:symbol FB_CYBER2000 depends on FB I was confused how to solve the recursive dependency, remove depends on ARM_DMA_USE_IOMMU IOMMU_API? The depends on ARM_DMA_USE_IOMMU IOMMU_API was suggested by Arnd Bergmann during code review (originally they were selected). Removing them definitely fixes the dependency recursion. Also, since they are both already selected by ROCKCHIP_IOMMU, everything will build correctly. So, this sounds good to me, but I am no expert on Kconfig. personally I'd think the omap v4l stuff is at fault here. It is selecting ARM_DMA_USE_IOMMU and OMAP_IOMMU instead of depending on them. And OMAP_IOMMU is a regular driver option which can be selected through Kconfig, so I don't think it should get selected but enabled by choice. It would be interesting to know if the Exynos drm is also affected by this, as it is using a similar depency-structure by depending on the iommu and ARM_DMA_USE_IOMMU. Heiko -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v14 0/3] Add drm driver for Rockchip Socs
On Thu, Nov 27, 2014 at 4:56 PM, Arnd Bergmann a...@arndb.de wrote: On Thursday 27 November 2014 14:05:00 Daniel Kurtz wrote: On Thu, Nov 27, 2014 at 2:08 AM, Mark yao mark@rock-chips.com wrote: On 2014年11月27日 10:12, Dave Airlie wrote: Hi Dave Do you mean that I need send you a branch, based on drm-next, merge with iommu tree and rockchip drm? Yes, grab drm-next, git pull the arm/rockchip branch from Joerg's tree, put rockchip drm patches on top, send me pull request. I'll validate it then. Dave. Hi Dave I have send a pull request to you, with Joerg's iommu arm/rockchip branch. I got a same problem when use make multi_v7_defconfig as Heiko said: drivers/video/fbdev/Kconfig:5:error: recursive dependency detected! drivers/video/fbdev/Kconfig:5:symbol FB is selected by DRM_KMS_FB_HELPER drivers/gpu/drm/Kconfig:34:symbol DRM_KMS_FB_HELPER is selected by DRM_ROCKCHIP drivers/gpu/drm/rockchip/Kconfig:1:symbol DRM_ROCKCHIP depends on ARM_DMA_USE_IOMMU arch/arm/Kconfig:95:symbol ARM_DMA_USE_IOMMU is selected by VIDEO_OMAP3 drivers/media/platform/Kconfig:96:symbol VIDEO_OMAP3 depends on VIDEO_V4L2 drivers/media/v4l2-core/Kconfig:6:symbol VIDEO_V4L2 depends on I2C drivers/i2c/Kconfig:7:symbol I2C is selected by FB_DDC drivers/video/fbdev/Kconfig:59:symbol FB_DDC is selected by FB_CYBER2000_DDC drivers/video/fbdev/Kconfig:374:symbol FB_CYBER2000_DDC depends on FB_CYBER2000 drivers/video/fbdev/Kconfig:362:symbol FB_CYBER2000 depends on FB I was confused how to solve the recursive dependency, remove depends on ARM_DMA_USE_IOMMU IOMMU_API? The depends on ARM_DMA_USE_IOMMU IOMMU_API was suggested by Arnd Bergmann during code review (originally they were selected). Removing them definitely fixes the dependency recursion. Also, since they are both already selected by ROCKCHIP_IOMMU, everything will build correctly. So, this sounds good to me, but I am no expert on Kconfig. I think the problem here is VIDEO_OMAP3 (among others), it should do the same as rockchips and use 'depends on' instead of 'select'. Another problem is the 'select I2C' in FB_DDC, but that would be much harder to fix. that 'select I2C' is the source of many loops.. I'd looked at it briefly before, but then ran away in despair. BR, -R Arnd -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v14 0/3] Add drm driver for Rockchip Socs
On 2014年11月27日 10:12, Dave Airlie wrote: Hi Dave Do you mean that I need send you a branch, based on drm-next, merge with iommu tree and rockchip drm? Yes, grab drm-next, git pull the arm/rockchip branch from Joerg's tree, put rockchip drm patches on top, send me pull request. I'll validate it then. Dave. Hi Dave I have send a pull request to you, with Joerg's iommu arm/rockchip branch. I got a same problem when use "make multi_v7_defconfig" as Heiko said: drivers/video/fbdev/Kconfig:5:error: recursive dependency detected! drivers/video/fbdev/Kconfig:5:symbol FB is selected by DRM_KMS_FB_HELPER drivers/gpu/drm/Kconfig:34:symbol DRM_KMS_FB_HELPER is selected by DRM_ROCKCHIP drivers/gpu/drm/rockchip/Kconfig:1:symbol DRM_ROCKCHIP depends on ARM_DMA_USE_IOMMU arch/arm/Kconfig:95:symbol ARM_DMA_USE_IOMMU is selected by VIDEO_OMAP3 drivers/media/platform/Kconfig:96:symbol VIDEO_OMAP3 depends on VIDEO_V4L2 drivers/media/v4l2-core/Kconfig:6:symbol VIDEO_V4L2 depends on I2C drivers/i2c/Kconfig:7:symbol I2C is selected by FB_DDC drivers/video/fbdev/Kconfig:59:symbol FB_DDC is selected by FB_CYBER2000_DDC drivers/video/fbdev/Kconfig:374:symbol FB_CYBER2000_DDC depends on FB_CYBER2000 drivers/video/fbdev/Kconfig:362:symbol FB_CYBER2000 depends on FB I was confused how to solve the recursive dependency, remove depends on ARM_DMA_USE_IOMMU & IOMMU_API? - Mark -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v14 0/3] Add drm driver for Rockchip Socs
>> >> > Hi Dave > Do you mean that I need send you a branch, based on drm-next, merge with > iommu tree and rockchip drm? Yes, grab drm-next, git pull the arm/rockchip branch from Joerg's tree, put rockchip drm patches on top, send me pull request. I'll validate it then. Dave. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v14 0/3] Add drm driver for Rockchip Socs
On 2014年11月27日 06:53, Dave Airlie wrote: On 26 November 2014 at 17:34, Joerg Roedel wrote: On Wed, Nov 26, 2014 at 01:37:51AM +0100, Heiko Stübner wrote: Joerg, is your arm/rockchip branch [0] considered stable? [0] https://git.kernel.org/cgit/linux/kernel/git/joro/iommu.git/log/?h=arm/rockchip Yes, this branch will not be rebased. It can be pulled into another tree. Great, so if we can get a rockchip drm tree based on drm-next with that tree pulled into it that would be good. Dave. Hi Dave Do you mean that I need send you a branch, based on drm-next, merge with iommu tree and rockchip drm? - Mark -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v14 0/3] Add drm driver for Rockchip Socs
On 26 November 2014 at 17:34, Joerg Roedel wrote: > On Wed, Nov 26, 2014 at 01:37:51AM +0100, Heiko Stübner wrote: >> >> Joerg, is your arm/rockchip branch [0] considered stable? >> >> [0] >> https://git.kernel.org/cgit/linux/kernel/git/joro/iommu.git/log/?h=arm/rockchip >> > > Yes, this branch will not be rebased. It can be pulled into another > tree. Great, so if we can get a rockchip drm tree based on drm-next with that tree pulled into it that would be good. Dave. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v14 0/3] Add drm driver for Rockchip Socs
On 26 November 2014 at 17:34, Joerg Roedel jroe...@suse.de wrote: On Wed, Nov 26, 2014 at 01:37:51AM +0100, Heiko Stübner wrote: Joerg, is your arm/rockchip branch [0] considered stable? [0] https://git.kernel.org/cgit/linux/kernel/git/joro/iommu.git/log/?h=arm/rockchip Yes, this branch will not be rebased. It can be pulled into another tree. Great, so if we can get a rockchip drm tree based on drm-next with that tree pulled into it that would be good. Dave. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v14 0/3] Add drm driver for Rockchip Socs
On 2014年11月27日 06:53, Dave Airlie wrote: On 26 November 2014 at 17:34, Joerg Roedel jroe...@suse.de wrote: On Wed, Nov 26, 2014 at 01:37:51AM +0100, Heiko Stübner wrote: Joerg, is your arm/rockchip branch [0] considered stable? [0] https://git.kernel.org/cgit/linux/kernel/git/joro/iommu.git/log/?h=arm/rockchip Yes, this branch will not be rebased. It can be pulled into another tree. Great, so if we can get a rockchip drm tree based on drm-next with that tree pulled into it that would be good. Dave. Hi Dave Do you mean that I need send you a branch, based on drm-next, merge with iommu tree and rockchip drm? - Mark -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v14 0/3] Add drm driver for Rockchip Socs
Hi Dave Do you mean that I need send you a branch, based on drm-next, merge with iommu tree and rockchip drm? Yes, grab drm-next, git pull the arm/rockchip branch from Joerg's tree, put rockchip drm patches on top, send me pull request. I'll validate it then. Dave. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v14 0/3] Add drm driver for Rockchip Socs
On 2014年11月27日 10:12, Dave Airlie wrote: Hi Dave Do you mean that I need send you a branch, based on drm-next, merge with iommu tree and rockchip drm? Yes, grab drm-next, git pull the arm/rockchip branch from Joerg's tree, put rockchip drm patches on top, send me pull request. I'll validate it then. Dave. Hi Dave I have send a pull request to you, with Joerg's iommu arm/rockchip branch. I got a same problem when use make multi_v7_defconfig as Heiko said: drivers/video/fbdev/Kconfig:5:error: recursive dependency detected! drivers/video/fbdev/Kconfig:5:symbol FB is selected by DRM_KMS_FB_HELPER drivers/gpu/drm/Kconfig:34:symbol DRM_KMS_FB_HELPER is selected by DRM_ROCKCHIP drivers/gpu/drm/rockchip/Kconfig:1:symbol DRM_ROCKCHIP depends on ARM_DMA_USE_IOMMU arch/arm/Kconfig:95:symbol ARM_DMA_USE_IOMMU is selected by VIDEO_OMAP3 drivers/media/platform/Kconfig:96:symbol VIDEO_OMAP3 depends on VIDEO_V4L2 drivers/media/v4l2-core/Kconfig:6:symbol VIDEO_V4L2 depends on I2C drivers/i2c/Kconfig:7:symbol I2C is selected by FB_DDC drivers/video/fbdev/Kconfig:59:symbol FB_DDC is selected by FB_CYBER2000_DDC drivers/video/fbdev/Kconfig:374:symbol FB_CYBER2000_DDC depends on FB_CYBER2000 drivers/video/fbdev/Kconfig:362:symbol FB_CYBER2000 depends on FB I was confused how to solve the recursive dependency, remove depends on ARM_DMA_USE_IOMMU IOMMU_API? - Mark -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v14 0/3] Add drm driver for Rockchip Socs
On Wed, Nov 26, 2014 at 01:37:51AM +0100, Heiko Stübner wrote: > > Joerg, is your arm/rockchip branch [0] considered stable? > > [0] > https://git.kernel.org/cgit/linux/kernel/git/joro/iommu.git/log/?h=arm/rockchip > Yes, this branch will not be rebased. It can be pulled into another tree. Joerg -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v14 0/3] Add drm driver for Rockchip Socs
Hi Joerg, Dave, Am Mittwoch, 26. November 2014, 09:12:56 schrieb Dave Airlie: > On 26 November 2014 at 02:38, Heiko Stübner wrote: > > Mark, > > > > Am Donnerstag, 20. November 2014, 09:46:34 schrieb Mark Yao: > >> This a series of patches is a DRM Driver for Rockchip Socs, add support > >> for vop devices. Future patches will add additional encoders/connectors, > >> such as eDP, HDMI. > >> > >> The basic "crtc" for rockchip is a "VOP" - Video Output Processor. > >> the vop devices found on Rockchip rk3288 Soc, rk3288 soc have two similar > >> Vop devices. Vop devices support iommu mapping, we use dma-mapping API > >> with > >> ARM_DMA_USE_IOMMU. > > > > it looks like everybody is more or less happy with this version - in past > > versions responses voicing concerns where quite swift. > > > > As David requested a pull request the last time, it might be time to do > > so, so that we maybe still reach 3.19. > > I need the iommu changes the drm driver depends on in a stable > maintainer git tree, > I'm not pulling in code I can't build. Joerg, is your arm/rockchip branch [0] considered stable? [0] https://git.kernel.org/cgit/linux/kernel/git/joro/iommu.git/log/?h=arm/rockchip > I'm happy if the rockchip drm pull stays static and I can pull it in > once the iommu bits > are done. While testing this I noticed a quite big kconfig warning (on both 3.18-rc1 and 3.18-rc6): drivers/video/fbdev/Kconfig:5:error: recursive dependency detected! drivers/video/fbdev/Kconfig:5: symbol FB is selected by DRM_KMS_FB_HELPER drivers/gpu/drm/Kconfig:34: symbol DRM_KMS_FB_HELPER is selected by DRM_ROCKCHIP drivers/gpu/drm/rockchip/Kconfig:1: symbol DRM_ROCKCHIP depends on ARM_DMA_USE_IOMMU arch/arm/Kconfig:95:symbol ARM_DMA_USE_IOMMU is selected by VIDEO_OMAP3 drivers/media/platform/Kconfig:96: symbol VIDEO_OMAP3 depends on VIDEO_V4L2 drivers/media/v4l2-core/Kconfig:6: symbol VIDEO_V4L2 depends on I2C drivers/i2c/Kconfig:7: symbol I2C is selected by FB_DDC drivers/video/fbdev/Kconfig:59: symbol FB_DDC is selected by FB_CYBER2000_DDC drivers/video/fbdev/Kconfig:374:symbol FB_CYBER2000_DDC depends on FB_CYBER2000 drivers/video/fbdev/Kconfig:362:symbol FB_CYBER2000 depends on FB It looks like the VIDEO_OMAP3 is selecting ARM_DMA_USE_IOMMU and OMAP_IOMMU instead of depending on it. I'm not sure which driver should change but looking at the exynos drm driver it is also depends on the iommu parts instead of selecting them [like the rockchip drm currently does] Heiko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v14 0/3] Add drm driver for Rockchip Socs
On 26 November 2014 at 02:38, Heiko Stübner wrote: > Mark, > > Am Donnerstag, 20. November 2014, 09:46:34 schrieb Mark Yao: >> This a series of patches is a DRM Driver for Rockchip Socs, add support >> for vop devices. Future patches will add additional encoders/connectors, >> such as eDP, HDMI. >> >> The basic "crtc" for rockchip is a "VOP" - Video Output Processor. >> the vop devices found on Rockchip rk3288 Soc, rk3288 soc have two similar >> Vop devices. Vop devices support iommu mapping, we use dma-mapping API with >> ARM_DMA_USE_IOMMU. > > it looks like everybody is more or less happy with this version - in past > versions responses voicing concerns where quite swift. > > As David requested a pull request the last time, it might be time to do so, so > that we maybe still reach 3.19. > I need the iommu changes the drm driver depends on in a stable maintainer git tree, I'm not pulling in code I can't build. I'm happy if the rockchip drm pull stays static and I can pull it in once the iommu bits are done. Dave. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v14 0/3] Add drm driver for Rockchip Socs
Mark, Am Donnerstag, 20. November 2014, 09:46:34 schrieb Mark Yao: > This a series of patches is a DRM Driver for Rockchip Socs, add support > for vop devices. Future patches will add additional encoders/connectors, > such as eDP, HDMI. > > The basic "crtc" for rockchip is a "VOP" - Video Output Processor. > the vop devices found on Rockchip rk3288 Soc, rk3288 soc have two similar > Vop devices. Vop devices support iommu mapping, we use dma-mapping API with > ARM_DMA_USE_IOMMU. it looks like everybody is more or less happy with this version - in past versions responses voicing concerns where quite swift. As David requested a pull request the last time, it might be time to do so, so that we maybe still reach 3.19. Heiko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v14 0/3] Add drm driver for Rockchip Socs
Mark, Am Donnerstag, 20. November 2014, 09:46:34 schrieb Mark Yao: This a series of patches is a DRM Driver for Rockchip Socs, add support for vop devices. Future patches will add additional encoders/connectors, such as eDP, HDMI. The basic crtc for rockchip is a VOP - Video Output Processor. the vop devices found on Rockchip rk3288 Soc, rk3288 soc have two similar Vop devices. Vop devices support iommu mapping, we use dma-mapping API with ARM_DMA_USE_IOMMU. it looks like everybody is more or less happy with this version - in past versions responses voicing concerns where quite swift. As David requested a pull request the last time, it might be time to do so, so that we maybe still reach 3.19. Heiko -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v14 0/3] Add drm driver for Rockchip Socs
On 26 November 2014 at 02:38, Heiko Stübner he...@sntech.de wrote: Mark, Am Donnerstag, 20. November 2014, 09:46:34 schrieb Mark Yao: This a series of patches is a DRM Driver for Rockchip Socs, add support for vop devices. Future patches will add additional encoders/connectors, such as eDP, HDMI. The basic crtc for rockchip is a VOP - Video Output Processor. the vop devices found on Rockchip rk3288 Soc, rk3288 soc have two similar Vop devices. Vop devices support iommu mapping, we use dma-mapping API with ARM_DMA_USE_IOMMU. it looks like everybody is more or less happy with this version - in past versions responses voicing concerns where quite swift. As David requested a pull request the last time, it might be time to do so, so that we maybe still reach 3.19. I need the iommu changes the drm driver depends on in a stable maintainer git tree, I'm not pulling in code I can't build. I'm happy if the rockchip drm pull stays static and I can pull it in once the iommu bits are done. Dave. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v14 0/3] Add drm driver for Rockchip Socs
Hi Joerg, Dave, Am Mittwoch, 26. November 2014, 09:12:56 schrieb Dave Airlie: On 26 November 2014 at 02:38, Heiko Stübner he...@sntech.de wrote: Mark, Am Donnerstag, 20. November 2014, 09:46:34 schrieb Mark Yao: This a series of patches is a DRM Driver for Rockchip Socs, add support for vop devices. Future patches will add additional encoders/connectors, such as eDP, HDMI. The basic crtc for rockchip is a VOP - Video Output Processor. the vop devices found on Rockchip rk3288 Soc, rk3288 soc have two similar Vop devices. Vop devices support iommu mapping, we use dma-mapping API with ARM_DMA_USE_IOMMU. it looks like everybody is more or less happy with this version - in past versions responses voicing concerns where quite swift. As David requested a pull request the last time, it might be time to do so, so that we maybe still reach 3.19. I need the iommu changes the drm driver depends on in a stable maintainer git tree, I'm not pulling in code I can't build. Joerg, is your arm/rockchip branch [0] considered stable? [0] https://git.kernel.org/cgit/linux/kernel/git/joro/iommu.git/log/?h=arm/rockchip I'm happy if the rockchip drm pull stays static and I can pull it in once the iommu bits are done. While testing this I noticed a quite big kconfig warning (on both 3.18-rc1 and 3.18-rc6): drivers/video/fbdev/Kconfig:5:error: recursive dependency detected! drivers/video/fbdev/Kconfig:5: symbol FB is selected by DRM_KMS_FB_HELPER drivers/gpu/drm/Kconfig:34: symbol DRM_KMS_FB_HELPER is selected by DRM_ROCKCHIP drivers/gpu/drm/rockchip/Kconfig:1: symbol DRM_ROCKCHIP depends on ARM_DMA_USE_IOMMU arch/arm/Kconfig:95:symbol ARM_DMA_USE_IOMMU is selected by VIDEO_OMAP3 drivers/media/platform/Kconfig:96: symbol VIDEO_OMAP3 depends on VIDEO_V4L2 drivers/media/v4l2-core/Kconfig:6: symbol VIDEO_V4L2 depends on I2C drivers/i2c/Kconfig:7: symbol I2C is selected by FB_DDC drivers/video/fbdev/Kconfig:59: symbol FB_DDC is selected by FB_CYBER2000_DDC drivers/video/fbdev/Kconfig:374:symbol FB_CYBER2000_DDC depends on FB_CYBER2000 drivers/video/fbdev/Kconfig:362:symbol FB_CYBER2000 depends on FB It looks like the VIDEO_OMAP3 is selecting ARM_DMA_USE_IOMMU and OMAP_IOMMU instead of depending on it. I'm not sure which driver should change but looking at the exynos drm driver it is also depends on the iommu parts instead of selecting them [like the rockchip drm currently does] Heiko -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v14 0/3] Add drm driver for Rockchip Socs
On Wed, Nov 26, 2014 at 01:37:51AM +0100, Heiko Stübner wrote: Joerg, is your arm/rockchip branch [0] considered stable? [0] https://git.kernel.org/cgit/linux/kernel/git/joro/iommu.git/log/?h=arm/rockchip Yes, this branch will not be rebased. It can be pulled into another tree. Joerg -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v14 0/3] Add drm driver for Rockchip Socs
This a series of patches is a DRM Driver for Rockchip Socs, add support for vop devices. Future patches will add additional encoders/connectors, such as eDP, HDMI. The basic "crtc" for rockchip is a "VOP" - Video Output Processor. the vop devices found on Rockchip rk3288 Soc, rk3288 soc have two similar Vop devices. Vop devices support iommu mapping, we use dma-mapping API with ARM_DMA_USE_IOMMU. Changes in v2: - add DRM master device node to list all display nodes that comprise the graphics subsystem. - use the component framework to defer main drm driver probe until all VOP devices have been probed. - use dma-mapping API with ARM_DMA_USE_IOMMU, create dma mapping by master device and each vop device can shared the drm dma mapping. - use drm_crtc_init_with_planes and drm_universal_plane_init. - remove unnecessary middle layers. - add cursor set, move funcs to rockchip drm crtc. - add vop reset. Changes in v3: - change "crtc->fb" to "crtc->primary-fb" Adviced by Daniel Vetter - init cursor plane with universal api, remove unnecessary cursor set,move Changes in v4: Adviced by David Herrmann - remove drm_platform_*() usage, use register drm device directly. Adviced by Rob Clark - remove special mmap ioctl, do userspace mmap with normal mmap() or mmap offset Changes in v5: Adviced by Arnd Bergmann - doing DMA start with a 32-bit masks with dma_mask and dma_coherent_mark - fix some incorrect dependencies. Adviced by Boris BREZILLON - fix some mistake and bugs. Adviced by Daniel Vetter - drop all special ioctl and use generic kms ioctl instead. Adviced by Rob Clark - use unlocked api for drm_fb_helper_restore_fbdev_mode. - remove unused rockchip_gem_prime_import_sg_table. Changes in v6: - set gem buffer pitch 64 bytes align, needed by mali gpu. Adviced by Daniel Kurtz - fix some mistake, bugs, remove unused define, more better code style etc. - use clk_prepare()/unprepare() at probe()/remove() and clk_enable()/disable() at runtime instead of clk_prepare_enable(). - provide a help function from vop for encoder to do mode config, instead of using drm_diaplay_mode private method. - change vop mode_set timing to make it more safely. Changes in v7: - fix memory leakage problem. Changes in v8: - fix iommu crash when use dual crtc. - use frame start interrupt for vsync instead of line flag interrupt, because the win config take affect at frame start time, if we use ling flag interrupt, the address check often failed. Adviced by Daniel Kurtz - fix some bugs, mistake, remove unused function - keep clock and vop disabled when probe end - use drm_plane_helper_check_update to check update_plane if vaild Changes in v9: - fix suspend and resume bug, make iommu attach and detach safely. - fix mail info style. Changes in v10: Adviced by Andrzej Hajda - check drm_dev if it's NULL at PM suspend/resume Adviced by Sean Paul - use drm_fb_helper_prepare to init fb_helper funcs - Optimized code structure and remove some unnecessary Variables. Changes in v11: - fix mistake that use wrong variable at rockchip sys_resume/sys_suspend Changes in v12: - fix compile problem with drm-next - Optimization framebuffer reference/unreference - Optimization Code structure - fix pm suspend/resume problem - fix vblank irq can't close problem Changes in v13: - fix vop compile warning. Adviced by Daniel Vetter - directly call rockchip_drm_load before register instead of call ->load at the middle of drm register. Changes in v14: - revert v13 directly call rockchip_drm_load at bind, connector, crtc _init should before dev-node kms object lookup idr and conector sysfs need below minor node register, I don't like split the connector init and register, so just call ->load at the midile of drm register. Mark yao (3): drm: rockchip: Add basic drm driver dt-bindings: video: Add for rockchip display subsytem dt-bindings: video: Add documentation for rockchip vop .../devicetree/bindings/video/rockchip-drm.txt | 19 + .../devicetree/bindings/video/rockchip-vop.txt | 58 + drivers/gpu/drm/Kconfig|2 + drivers/gpu/drm/Makefile |1 + drivers/gpu/drm/rockchip/Kconfig | 17 + drivers/gpu/drm/rockchip/Makefile |8 + drivers/gpu/drm/rockchip/rockchip_drm_drv.c| 483 +++ drivers/gpu/drm/rockchip/rockchip_drm_drv.h| 55 + drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 200 +++ drivers/gpu/drm/rockchip/rockchip_drm_fb.h | 28 + drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 210 +++ drivers/gpu/drm/rockchip/rockchip_drm_fbdev.h | 21 + drivers/gpu/drm/rockchip/rockchip_drm_gem.c| 294 drivers/gpu/drm/rockchip/rockchip_drm_gem.h| 54 + drivers/gpu/drm/rockchip/rockchip_drm_vop.c| 1459 drivers/gpu/drm/rockchip/rockchip_drm_vop.h| 201 +++ 16 files changed, 3110 insertions(+) -- 1.7.9.5 --
[PATCH v14 0/3] Add drm driver for Rockchip Socs
This a series of patches is a DRM Driver for Rockchip Socs, add support for vop devices. Future patches will add additional encoders/connectors, such as eDP, HDMI. The basic crtc for rockchip is a VOP - Video Output Processor. the vop devices found on Rockchip rk3288 Soc, rk3288 soc have two similar Vop devices. Vop devices support iommu mapping, we use dma-mapping API with ARM_DMA_USE_IOMMU. Changes in v2: - add DRM master device node to list all display nodes that comprise the graphics subsystem. - use the component framework to defer main drm driver probe until all VOP devices have been probed. - use dma-mapping API with ARM_DMA_USE_IOMMU, create dma mapping by master device and each vop device can shared the drm dma mapping. - use drm_crtc_init_with_planes and drm_universal_plane_init. - remove unnecessary middle layers. - add cursor set, move funcs to rockchip drm crtc. - add vop reset. Changes in v3: - change crtc-fb to crtc-primary-fb Adviced by Daniel Vetter - init cursor plane with universal api, remove unnecessary cursor set,move Changes in v4: Adviced by David Herrmann - remove drm_platform_*() usage, use register drm device directly. Adviced by Rob Clark - remove special mmap ioctl, do userspace mmap with normal mmap() or mmap offset Changes in v5: Adviced by Arnd Bergmann - doing DMA start with a 32-bit masks with dma_mask and dma_coherent_mark - fix some incorrect dependencies. Adviced by Boris BREZILLON - fix some mistake and bugs. Adviced by Daniel Vetter - drop all special ioctl and use generic kms ioctl instead. Adviced by Rob Clark - use unlocked api for drm_fb_helper_restore_fbdev_mode. - remove unused rockchip_gem_prime_import_sg_table. Changes in v6: - set gem buffer pitch 64 bytes align, needed by mali gpu. Adviced by Daniel Kurtz - fix some mistake, bugs, remove unused define, more better code style etc. - use clk_prepare()/unprepare() at probe()/remove() and clk_enable()/disable() at runtime instead of clk_prepare_enable(). - provide a help function from vop for encoder to do mode config, instead of using drm_diaplay_mode private method. - change vop mode_set timing to make it more safely. Changes in v7: - fix memory leakage problem. Changes in v8: - fix iommu crash when use dual crtc. - use frame start interrupt for vsync instead of line flag interrupt, because the win config take affect at frame start time, if we use ling flag interrupt, the address check often failed. Adviced by Daniel Kurtz - fix some bugs, mistake, remove unused function - keep clock and vop disabled when probe end - use drm_plane_helper_check_update to check update_plane if vaild Changes in v9: - fix suspend and resume bug, make iommu attach and detach safely. - fix mail info style. Changes in v10: Adviced by Andrzej Hajda - check drm_dev if it's NULL at PM suspend/resume Adviced by Sean Paul - use drm_fb_helper_prepare to init fb_helper funcs - Optimized code structure and remove some unnecessary Variables. Changes in v11: - fix mistake that use wrong variable at rockchip sys_resume/sys_suspend Changes in v12: - fix compile problem with drm-next - Optimization framebuffer reference/unreference - Optimization Code structure - fix pm suspend/resume problem - fix vblank irq can't close problem Changes in v13: - fix vop compile warning. Adviced by Daniel Vetter - directly call rockchip_drm_load before register instead of call -load at the middle of drm register. Changes in v14: - revert v13 directly call rockchip_drm_load at bind, connector, crtc _init should before dev-node kms object lookup idr and conector sysfs need below minor node register, I don't like split the connector init and register, so just call -load at the midile of drm register. Mark yao (3): drm: rockchip: Add basic drm driver dt-bindings: video: Add for rockchip display subsytem dt-bindings: video: Add documentation for rockchip vop .../devicetree/bindings/video/rockchip-drm.txt | 19 + .../devicetree/bindings/video/rockchip-vop.txt | 58 + drivers/gpu/drm/Kconfig|2 + drivers/gpu/drm/Makefile |1 + drivers/gpu/drm/rockchip/Kconfig | 17 + drivers/gpu/drm/rockchip/Makefile |8 + drivers/gpu/drm/rockchip/rockchip_drm_drv.c| 483 +++ drivers/gpu/drm/rockchip/rockchip_drm_drv.h| 55 + drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 200 +++ drivers/gpu/drm/rockchip/rockchip_drm_fb.h | 28 + drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 210 +++ drivers/gpu/drm/rockchip/rockchip_drm_fbdev.h | 21 + drivers/gpu/drm/rockchip/rockchip_drm_gem.c| 294 drivers/gpu/drm/rockchip/rockchip_drm_gem.h| 54 + drivers/gpu/drm/rockchip/rockchip_drm_vop.c| 1459 drivers/gpu/drm/rockchip/rockchip_drm_vop.h| 201 +++ 16 files changed, 3110 insertions(+) -- 1.7.9.5 -- To
