Re: [PATCH v2] ARM: at91: add Atmel's SAMA5D3 Xplained board

2014-02-10 Thread Nicolas Ferre
On 07/02/2014 18:19, Jean-Christophe PLAGNIOL-VILLARD :
> On 15:37 Fri 07 Feb , Nicolas Ferre wrote:
>> On 07/02/2014 09:01, Jean-Christophe PLAGNIOL-VILLARD :
>>> On 09:35 Wed 05 Feb , Nicolas Ferre wrote:
 Add DT file for new SAMA5D3 Xpained board.
 This board is based on Atmel's SAMA5D36 Cortex-A5 SoC.

 Signed-off-by: Nicolas Ferre 
 ---
  arch/arm/boot/dts/Makefile  |   1 +
  arch/arm/boot/dts/at91-sama5d3_xplained.dts | 233 
 
  2 files changed, 234 insertions(+)
  create mode 100644 arch/arm/boot/dts/at91-sama5d3_xplained.dts

 diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
 index b9d6a8b485e0..6d1e43d46187 100644
 --- a/arch/arm/boot/dts/Makefile
 +++ b/arch/arm/boot/dts/Makefile
 @@ -38,6 +38,7 @@ dtb-$(CONFIG_ARCH_AT91) += at91sam9g35ek.dtb
  dtb-$(CONFIG_ARCH_AT91) += at91sam9x25ek.dtb
  dtb-$(CONFIG_ARCH_AT91) += at91sam9x35ek.dtb
  # sama5d3
 +dtb-$(CONFIG_ARCH_AT91)   += at91-sama5d3_xplained.dtb
  dtb-$(CONFIG_ARCH_AT91)   += sama5d31ek.dtb
  dtb-$(CONFIG_ARCH_AT91)   += sama5d33ek.dtb
  dtb-$(CONFIG_ARCH_AT91)   += sama5d34ek.dtb
 diff --git a/arch/arm/boot/dts/at91-sama5d3_xplained.dts 
 b/arch/arm/boot/dts/at91-sama5d3_xplained.dts
 new file mode 100644
 index ..fb1349ca60a4
 --- /dev/null
 +++ b/arch/arm/boot/dts/at91-sama5d3_xplained.dts
 @@ -0,0 +1,233 @@
 +/*
 + * at91-sama5d3_xplained.dts - Device Tree file for the SAMA5D3 Xplained 
 board
 + *
 + *  Copyright (C) 2014 Atmel,
 + *  2014 Nicolas Ferre 
 + *
 + * Licensed under GPLv2 or later.
 + */
 +/dts-v1/;
 +#include "sama5d36.dtsi"
 +
 +/ {
 +  model = "SAMA5D3 Xplained";
 +  compatible = "atmel,sama5d3-xplained", "atmel,sama5d3", "atmel,sama5";
 +
 +  chosen {
 +  bootargs = "console=ttyS0,115200";
>>> can you describe it via linux,stdout
>>
>> Well I would have liked, but the code in the serial driver is not there yet.
>> So, I keep it like this for the moment.
>>
 +  };
 +
 +  memory {
 +  reg = <0x2000 0x1000>;
 +  };
 +
 +  ahb {
 +  apb {
 +  mmc0: mmc@f000 {
 +  pinc§trl-names = "default";
>>> ?? this is SoC should never been seen here
> this need to move to dtsi not here

Yes. It is done already.

 +  pinctrl-0 = <_mmc0_clk_cmd_dat0 
 _mmc0_dat1_3 _mmc0_dat4_7 _mmc0_cd>;
 +  status = "okay";
 +  slot@0 {
 +  reg = <0>;
 +  bus-width = <8>;
 +  cd-gpios = < 0 GPIO_ACTIVE_LOW>;
 +  };
 +  };
 +
 +  spi0: spi@f0004000 {
 +  cs-gpios = < 13 0>, <0>, <0>, <0>;
>>> if you use only one CS no need to specified all
>>>
>>> we need to add macro per SoC for the hw CS used as GPIO so it's more clear
>>
>> No, I do not think so.
> 
> yes as you dopy  13 0 everywhere instead of doing
> 
> #define SAMA5D3_SPI_CS0_GPIO   13 GPIO_ACTIVE_LOW
> 
> and then
> 
>   cs-gpios = ;

I do not see any benefit in doing this.


> and drop the
>   , <0>, <0>, <0>;

Already done.

> 
 +  status = "okay";
 +  };
 +
 +  can0: can@f000c000 {
 +  status = "okay";
 +  };
 +
 +  i2c0: i2c@f0014000 {
 +  status = "okay";
 +  };
 +
 +  i2c1: i2c@f0018000 {
 +  status = "okay";
 +  };
 +
 +  macb0: ethernet@f0028000 {
 +  phy-mode = "rgmii";
 +  status = "okay";
 +  };
 +
 +  usart0: serial@f001c000 {
 +  status = "okay";
 +  };
 +
 +  usart1: serial@f002 {
 +  pinctrl-names = "default";
>>> same as mmc
 +  pinctrl-0 = <_usart1 
 _usart1_rts_cts>;
 +  status = "okay";
 +  };
 +
 +  uart0: serial@f0024000 {
 +  status = "okay";
 +  };
 +
 +  mmc1: mmc@f800 {
 +  pinctrl-names = "default";
>>> ditto
 +  pinctrl-0 = <_mmc1_clk_cmd_dat0 
 _mmc1_dat1_3 _mmc1_cd>;
 +  status = "okay";
 

Re: [PATCH v2] ARM: at91: add Atmel's SAMA5D3 Xplained board

2014-02-10 Thread Nicolas Ferre
On 07/02/2014 18:19, Jean-Christophe PLAGNIOL-VILLARD :
 On 15:37 Fri 07 Feb , Nicolas Ferre wrote:
 On 07/02/2014 09:01, Jean-Christophe PLAGNIOL-VILLARD :
 On 09:35 Wed 05 Feb , Nicolas Ferre wrote:
 Add DT file for new SAMA5D3 Xpained board.
 This board is based on Atmel's SAMA5D36 Cortex-A5 SoC.

 Signed-off-by: Nicolas Ferre nicolas.fe...@atmel.com
 ---
  arch/arm/boot/dts/Makefile  |   1 +
  arch/arm/boot/dts/at91-sama5d3_xplained.dts | 233 
 
  2 files changed, 234 insertions(+)
  create mode 100644 arch/arm/boot/dts/at91-sama5d3_xplained.dts

 diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
 index b9d6a8b485e0..6d1e43d46187 100644
 --- a/arch/arm/boot/dts/Makefile
 +++ b/arch/arm/boot/dts/Makefile
 @@ -38,6 +38,7 @@ dtb-$(CONFIG_ARCH_AT91) += at91sam9g35ek.dtb
  dtb-$(CONFIG_ARCH_AT91) += at91sam9x25ek.dtb
  dtb-$(CONFIG_ARCH_AT91) += at91sam9x35ek.dtb
  # sama5d3
 +dtb-$(CONFIG_ARCH_AT91)   += at91-sama5d3_xplained.dtb
  dtb-$(CONFIG_ARCH_AT91)   += sama5d31ek.dtb
  dtb-$(CONFIG_ARCH_AT91)   += sama5d33ek.dtb
  dtb-$(CONFIG_ARCH_AT91)   += sama5d34ek.dtb
 diff --git a/arch/arm/boot/dts/at91-sama5d3_xplained.dts 
 b/arch/arm/boot/dts/at91-sama5d3_xplained.dts
 new file mode 100644
 index ..fb1349ca60a4
 --- /dev/null
 +++ b/arch/arm/boot/dts/at91-sama5d3_xplained.dts
 @@ -0,0 +1,233 @@
 +/*
 + * at91-sama5d3_xplained.dts - Device Tree file for the SAMA5D3 Xplained 
 board
 + *
 + *  Copyright (C) 2014 Atmel,
 + *  2014 Nicolas Ferre nicolas.fe...@atmel.com
 + *
 + * Licensed under GPLv2 or later.
 + */
 +/dts-v1/;
 +#include sama5d36.dtsi
 +
 +/ {
 +  model = SAMA5D3 Xplained;
 +  compatible = atmel,sama5d3-xplained, atmel,sama5d3, atmel,sama5;
 +
 +  chosen {
 +  bootargs = console=ttyS0,115200;
 can you describe it via linux,stdout

 Well I would have liked, but the code in the serial driver is not there yet.
 So, I keep it like this for the moment.

 +  };
 +
 +  memory {
 +  reg = 0x2000 0x1000;
 +  };
 +
 +  ahb {
 +  apb {
 +  mmc0: mmc@f000 {
 +  pinc§trl-names = default;
 ?? this is SoC should never been seen here
 this need to move to dtsi not here

Yes. It is done already.

 +  pinctrl-0 = pinctrl_mmc0_clk_cmd_dat0 
 pinctrl_mmc0_dat1_3 pinctrl_mmc0_dat4_7 pinctrl_mmc0_cd;
 +  status = okay;
 +  slot@0 {
 +  reg = 0;
 +  bus-width = 8;
 +  cd-gpios = pioE 0 GPIO_ACTIVE_LOW;
 +  };
 +  };
 +
 +  spi0: spi@f0004000 {
 +  cs-gpios = pioD 13 0, 0, 0, 0;
 if you use only one CS no need to specified all

 we need to add macro per SoC for the hw CS used as GPIO so it's more clear

 No, I do not think so.
 
 yes as you dopy pioD 13 0 everywhere instead of doing
 
 #define SAMA5D3_SPI_CS0_GPIO  pioD 13 GPIO_ACTIVE_LOW
 
 and then
 
   cs-gpios = SAMA5D3_SPI_CS0_GPIO;

I do not see any benefit in doing this.


 and drop the
   , 0, 0, 0;

Already done.

 
 +  status = okay;
 +  };
 +
 +  can0: can@f000c000 {
 +  status = okay;
 +  };
 +
 +  i2c0: i2c@f0014000 {
 +  status = okay;
 +  };
 +
 +  i2c1: i2c@f0018000 {
 +  status = okay;
 +  };
 +
 +  macb0: ethernet@f0028000 {
 +  phy-mode = rgmii;
 +  status = okay;
 +  };
 +
 +  usart0: serial@f001c000 {
 +  status = okay;
 +  };
 +
 +  usart1: serial@f002 {
 +  pinctrl-names = default;
 same as mmc
 +  pinctrl-0 = pinctrl_usart1 
 pinctrl_usart1_rts_cts;
 +  status = okay;
 +  };
 +
 +  uart0: serial@f0024000 {
 +  status = okay;
 +  };
 +
 +  mmc1: mmc@f800 {
 +  pinctrl-names = default;
 ditto
 +  pinctrl-0 = pinctrl_mmc1_clk_cmd_dat0 
 pinctrl_mmc1_dat1_3 pinctrl_mmc1_cd;
 +  status = okay;
 +  slot@0 {
 +  reg = 0;
 +  bus-width = 4;
 +  cd-gpios = pioE 1 GPIO_ACTIVE_HIGH;
 +  };
 +  };
 +
 +  spi1: spi@f8008000 {
 +  cs-gpios = pioC 25 0, 0, 0, pioD 16 0;
 +  status = okay;
 +

Re: [PATCH v2] ARM: at91: add Atmel's SAMA5D3 Xplained board

2014-02-07 Thread Jean-Christophe PLAGNIOL-VILLARD
On 15:37 Fri 07 Feb , Nicolas Ferre wrote:
> On 07/02/2014 09:01, Jean-Christophe PLAGNIOL-VILLARD :
> > On 09:35 Wed 05 Feb , Nicolas Ferre wrote:
> >> Add DT file for new SAMA5D3 Xpained board.
> >> This board is based on Atmel's SAMA5D36 Cortex-A5 SoC.
> >>
> >> Signed-off-by: Nicolas Ferre 
> >> ---
> >>  arch/arm/boot/dts/Makefile  |   1 +
> >>  arch/arm/boot/dts/at91-sama5d3_xplained.dts | 233 
> >> 
> >>  2 files changed, 234 insertions(+)
> >>  create mode 100644 arch/arm/boot/dts/at91-sama5d3_xplained.dts
> >>
> >> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> >> index b9d6a8b485e0..6d1e43d46187 100644
> >> --- a/arch/arm/boot/dts/Makefile
> >> +++ b/arch/arm/boot/dts/Makefile
> >> @@ -38,6 +38,7 @@ dtb-$(CONFIG_ARCH_AT91) += at91sam9g35ek.dtb
> >>  dtb-$(CONFIG_ARCH_AT91) += at91sam9x25ek.dtb
> >>  dtb-$(CONFIG_ARCH_AT91) += at91sam9x35ek.dtb
> >>  # sama5d3
> >> +dtb-$(CONFIG_ARCH_AT91)   += at91-sama5d3_xplained.dtb
> >>  dtb-$(CONFIG_ARCH_AT91)   += sama5d31ek.dtb
> >>  dtb-$(CONFIG_ARCH_AT91)   += sama5d33ek.dtb
> >>  dtb-$(CONFIG_ARCH_AT91)   += sama5d34ek.dtb
> >> diff --git a/arch/arm/boot/dts/at91-sama5d3_xplained.dts 
> >> b/arch/arm/boot/dts/at91-sama5d3_xplained.dts
> >> new file mode 100644
> >> index ..fb1349ca60a4
> >> --- /dev/null
> >> +++ b/arch/arm/boot/dts/at91-sama5d3_xplained.dts
> >> @@ -0,0 +1,233 @@
> >> +/*
> >> + * at91-sama5d3_xplained.dts - Device Tree file for the SAMA5D3 Xplained 
> >> board
> >> + *
> >> + *  Copyright (C) 2014 Atmel,
> >> + *  2014 Nicolas Ferre 
> >> + *
> >> + * Licensed under GPLv2 or later.
> >> + */
> >> +/dts-v1/;
> >> +#include "sama5d36.dtsi"
> >> +
> >> +/ {
> >> +  model = "SAMA5D3 Xplained";
> >> +  compatible = "atmel,sama5d3-xplained", "atmel,sama5d3", "atmel,sama5";
> >> +
> >> +  chosen {
> >> +  bootargs = "console=ttyS0,115200";
> > can you describe it via linux,stdout
> 
> Well I would have liked, but the code in the serial driver is not there yet.
> So, I keep it like this for the moment.
> 
> >> +  };
> >> +
> >> +  memory {
> >> +  reg = <0x2000 0x1000>;
> >> +  };
> >> +
> >> +  ahb {
> >> +  apb {
> >> +  mmc0: mmc@f000 {
> >> +  pinc§trl-names = "default";
> > ?? this is SoC should never been seen here
this need to move to dtsi not here
> >> +  pinctrl-0 = <_mmc0_clk_cmd_dat0 
> >> _mmc0_dat1_3 _mmc0_dat4_7 _mmc0_cd>;
> >> +  status = "okay";
> >> +  slot@0 {
> >> +  reg = <0>;
> >> +  bus-width = <8>;
> >> +  cd-gpios = < 0 GPIO_ACTIVE_LOW>;
> >> +  };
> >> +  };
> >> +
> >> +  spi0: spi@f0004000 {
> >> +  cs-gpios = < 13 0>, <0>, <0>, <0>;
> > if you use only one CS no need to specified all
> > 
> > we need to add macro per SoC for the hw CS used as GPIO so it's more clear
> 
> No, I do not think so.

yes as you dopy  13 0 everywhere instead of doing

#define SAMA5D3_SPI_CS0_GPIO 13 GPIO_ACTIVE_LOW

and then

cs-gpios = ;
and drop the
, <0>, <0>, <0>;

> >> +  status = "okay";
> >> +  };
> >> +
> >> +  can0: can@f000c000 {
> >> +  status = "okay";
> >> +  };
> >> +
> >> +  i2c0: i2c@f0014000 {
> >> +  status = "okay";
> >> +  };
> >> +
> >> +  i2c1: i2c@f0018000 {
> >> +  status = "okay";
> >> +  };
> >> +
> >> +  macb0: ethernet@f0028000 {
> >> +  phy-mode = "rgmii";
> >> +  status = "okay";
> >> +  };
> >> +
> >> +  usart0: serial@f001c000 {
> >> +  status = "okay";
> >> +  };
> >> +
> >> +  usart1: serial@f002 {
> >> +  pinctrl-names = "default";
> > same as mmc
> >> +  pinctrl-0 = <_usart1 
> >> _usart1_rts_cts>;
> >> +  status = "okay";
> >> +  };
> >> +
> >> +  uart0: serial@f0024000 {
> >> +  status = "okay";
> >> +  };
> >> +
> >> +  mmc1: mmc@f800 {
> >> +  pinctrl-names = "default";
> > ditto
> >> +  pinctrl-0 = <_mmc1_clk_cmd_dat0 
> >> _mmc1_dat1_3 _mmc1_cd>;
> >> +  status = "okay";
> >> +  slot@0 {
> >> +  reg = <0>;
> >> +  bus-width = <4>;
> >> +   

Re: [PATCH v2] ARM: at91: add Atmel's SAMA5D3 Xplained board

2014-02-07 Thread Nicolas Ferre
On 07/02/2014 09:01, Jean-Christophe PLAGNIOL-VILLARD :
> On 09:35 Wed 05 Feb , Nicolas Ferre wrote:
>> Add DT file for new SAMA5D3 Xpained board.
>> This board is based on Atmel's SAMA5D36 Cortex-A5 SoC.
>>
>> Signed-off-by: Nicolas Ferre 
>> ---
>>  arch/arm/boot/dts/Makefile  |   1 +
>>  arch/arm/boot/dts/at91-sama5d3_xplained.dts | 233 
>> 
>>  2 files changed, 234 insertions(+)
>>  create mode 100644 arch/arm/boot/dts/at91-sama5d3_xplained.dts
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index b9d6a8b485e0..6d1e43d46187 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -38,6 +38,7 @@ dtb-$(CONFIG_ARCH_AT91) += at91sam9g35ek.dtb
>>  dtb-$(CONFIG_ARCH_AT91) += at91sam9x25ek.dtb
>>  dtb-$(CONFIG_ARCH_AT91) += at91sam9x35ek.dtb
>>  # sama5d3
>> +dtb-$(CONFIG_ARCH_AT91) += at91-sama5d3_xplained.dtb
>>  dtb-$(CONFIG_ARCH_AT91) += sama5d31ek.dtb
>>  dtb-$(CONFIG_ARCH_AT91) += sama5d33ek.dtb
>>  dtb-$(CONFIG_ARCH_AT91) += sama5d34ek.dtb
>> diff --git a/arch/arm/boot/dts/at91-sama5d3_xplained.dts 
>> b/arch/arm/boot/dts/at91-sama5d3_xplained.dts
>> new file mode 100644
>> index ..fb1349ca60a4
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/at91-sama5d3_xplained.dts
>> @@ -0,0 +1,233 @@
>> +/*
>> + * at91-sama5d3_xplained.dts - Device Tree file for the SAMA5D3 Xplained 
>> board
>> + *
>> + *  Copyright (C) 2014 Atmel,
>> + *2014 Nicolas Ferre 
>> + *
>> + * Licensed under GPLv2 or later.
>> + */
>> +/dts-v1/;
>> +#include "sama5d36.dtsi"
>> +
>> +/ {
>> +model = "SAMA5D3 Xplained";
>> +compatible = "atmel,sama5d3-xplained", "atmel,sama5d3", "atmel,sama5";
>> +
>> +chosen {
>> +bootargs = "console=ttyS0,115200";
> can you describe it via linux,stdout

Well I would have liked, but the code in the serial driver is not there yet.
So, I keep it like this for the moment.

>> +};
>> +
>> +memory {
>> +reg = <0x2000 0x1000>;
>> +};
>> +
>> +ahb {
>> +apb {
>> +mmc0: mmc@f000 {
>> +pinc§trl-names = "default";
> ?? this is SoC should never been seen here
>> +pinctrl-0 = <_mmc0_clk_cmd_dat0 
>> _mmc0_dat1_3 _mmc0_dat4_7 _mmc0_cd>;
>> +status = "okay";
>> +slot@0 {
>> +reg = <0>;
>> +bus-width = <8>;
>> +cd-gpios = < 0 GPIO_ACTIVE_LOW>;
>> +};
>> +};
>> +
>> +spi0: spi@f0004000 {
>> +cs-gpios = < 13 0>, <0>, <0>, <0>;
> if you use only one CS no need to specified all
> 
> we need to add macro per SoC for the hw CS used as GPIO so it's more clear

No, I do not think so.

>> +status = "okay";
>> +};
>> +
>> +can0: can@f000c000 {
>> +status = "okay";
>> +};
>> +
>> +i2c0: i2c@f0014000 {
>> +status = "okay";
>> +};
>> +
>> +i2c1: i2c@f0018000 {
>> +status = "okay";
>> +};
>> +
>> +macb0: ethernet@f0028000 {
>> +phy-mode = "rgmii";
>> +status = "okay";
>> +};
>> +
>> +usart0: serial@f001c000 {
>> +status = "okay";
>> +};
>> +
>> +usart1: serial@f002 {
>> +pinctrl-names = "default";
> same as mmc
>> +pinctrl-0 = <_usart1 
>> _usart1_rts_cts>;
>> +status = "okay";
>> +};
>> +
>> +uart0: serial@f0024000 {
>> +status = "okay";
>> +};
>> +
>> +mmc1: mmc@f800 {
>> +pinctrl-names = "default";
> ditto
>> +pinctrl-0 = <_mmc1_clk_cmd_dat0 
>> _mmc1_dat1_3 _mmc1_cd>;
>> +status = "okay";
>> +slot@0 {
>> +reg = <0>;
>> +bus-width = <4>;
>> +cd-gpios = < 1 GPIO_ACTIVE_HIGH>;
>> +};
>> +};
>> +
>> +spi1: spi@f8008000 {
>> +cs-gpios = < 25 0>, <0>, <0>, < 16 0>;
>> +status = "okay";
>> +};
>> +
>> +adc0: adc@f8018000 {
>> +pinctrl-names = "default";
> ditto
>> 

Re: [PATCH v2] ARM: at91: add Atmel's SAMA5D3 Xplained board

2014-02-07 Thread Jean-Christophe PLAGNIOL-VILLARD
On 09:35 Wed 05 Feb , Nicolas Ferre wrote:
> Add DT file for new SAMA5D3 Xpained board.
> This board is based on Atmel's SAMA5D36 Cortex-A5 SoC.
> 
> Signed-off-by: Nicolas Ferre 
> ---
>  arch/arm/boot/dts/Makefile  |   1 +
>  arch/arm/boot/dts/at91-sama5d3_xplained.dts | 233 
> 
>  2 files changed, 234 insertions(+)
>  create mode 100644 arch/arm/boot/dts/at91-sama5d3_xplained.dts
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index b9d6a8b485e0..6d1e43d46187 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -38,6 +38,7 @@ dtb-$(CONFIG_ARCH_AT91) += at91sam9g35ek.dtb
>  dtb-$(CONFIG_ARCH_AT91) += at91sam9x25ek.dtb
>  dtb-$(CONFIG_ARCH_AT91) += at91sam9x35ek.dtb
>  # sama5d3
> +dtb-$(CONFIG_ARCH_AT91)  += at91-sama5d3_xplained.dtb
>  dtb-$(CONFIG_ARCH_AT91)  += sama5d31ek.dtb
>  dtb-$(CONFIG_ARCH_AT91)  += sama5d33ek.dtb
>  dtb-$(CONFIG_ARCH_AT91)  += sama5d34ek.dtb
> diff --git a/arch/arm/boot/dts/at91-sama5d3_xplained.dts 
> b/arch/arm/boot/dts/at91-sama5d3_xplained.dts
> new file mode 100644
> index ..fb1349ca60a4
> --- /dev/null
> +++ b/arch/arm/boot/dts/at91-sama5d3_xplained.dts
> @@ -0,0 +1,233 @@
> +/*
> + * at91-sama5d3_xplained.dts - Device Tree file for the SAMA5D3 Xplained 
> board
> + *
> + *  Copyright (C) 2014 Atmel,
> + * 2014 Nicolas Ferre 
> + *
> + * Licensed under GPLv2 or later.
> + */
> +/dts-v1/;
> +#include "sama5d36.dtsi"
> +
> +/ {
> + model = "SAMA5D3 Xplained";
> + compatible = "atmel,sama5d3-xplained", "atmel,sama5d3", "atmel,sama5";
> +
> + chosen {
> + bootargs = "console=ttyS0,115200";
can you describe it via linux,stdout
> + };
> +
> + memory {
> + reg = <0x2000 0x1000>;
> + };
> +
> + ahb {
> + apb {
> + mmc0: mmc@f000 {
> + pinc§trl-names = "default";
?? this is SoC should never been seen here
> + pinctrl-0 = <_mmc0_clk_cmd_dat0 
> _mmc0_dat1_3 _mmc0_dat4_7 _mmc0_cd>;
> + status = "okay";
> + slot@0 {
> + reg = <0>;
> + bus-width = <8>;
> + cd-gpios = < 0 GPIO_ACTIVE_LOW>;
> + };
> + };
> +
> + spi0: spi@f0004000 {
> + cs-gpios = < 13 0>, <0>, <0>, <0>;
if you use only one CS no need to specified all

we need to add macro per SoC for the hw CS used as GPIO so it's more clear
> + status = "okay";
> + };
> +
> + can0: can@f000c000 {
> + status = "okay";
> + };
> +
> + i2c0: i2c@f0014000 {
> + status = "okay";
> + };
> +
> + i2c1: i2c@f0018000 {
> + status = "okay";
> + };
> +
> + macb0: ethernet@f0028000 {
> + phy-mode = "rgmii";
> + status = "okay";
> + };
> +
> + usart0: serial@f001c000 {
> + status = "okay";
> + };
> +
> + usart1: serial@f002 {
> + pinctrl-names = "default";
same as mmc
> + pinctrl-0 = <_usart1 
> _usart1_rts_cts>;
> + status = "okay";
> + };
> +
> + uart0: serial@f0024000 {
> + status = "okay";
> + };
> +
> + mmc1: mmc@f800 {
> + pinctrl-names = "default";
ditto
> + pinctrl-0 = <_mmc1_clk_cmd_dat0 
> _mmc1_dat1_3 _mmc1_cd>;
> + status = "okay";
> + slot@0 {
> + reg = <0>;
> + bus-width = <4>;
> + cd-gpios = < 1 GPIO_ACTIVE_HIGH>;
> + };
> + };
> +
> + spi1: spi@f8008000 {
> + cs-gpios = < 25 0>, <0>, <0>, < 16 0>;
> + status = "okay";
> + };
> +
> + adc0: adc@f8018000 {
> + pinctrl-names = "default";
ditto
> + pinctrl-0 = <
> + _adc0_adtrg
> + _adc0_ad0
> + _adc0_ad1
> + _adc0_ad2
> +   

Re: [PATCH v2] ARM: at91: add Atmel's SAMA5D3 Xplained board

2014-02-07 Thread Jean-Christophe PLAGNIOL-VILLARD
On 09:35 Wed 05 Feb , Nicolas Ferre wrote:
 Add DT file for new SAMA5D3 Xpained board.
 This board is based on Atmel's SAMA5D36 Cortex-A5 SoC.
 
 Signed-off-by: Nicolas Ferre nicolas.fe...@atmel.com
 ---
  arch/arm/boot/dts/Makefile  |   1 +
  arch/arm/boot/dts/at91-sama5d3_xplained.dts | 233 
 
  2 files changed, 234 insertions(+)
  create mode 100644 arch/arm/boot/dts/at91-sama5d3_xplained.dts
 
 diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
 index b9d6a8b485e0..6d1e43d46187 100644
 --- a/arch/arm/boot/dts/Makefile
 +++ b/arch/arm/boot/dts/Makefile
 @@ -38,6 +38,7 @@ dtb-$(CONFIG_ARCH_AT91) += at91sam9g35ek.dtb
  dtb-$(CONFIG_ARCH_AT91) += at91sam9x25ek.dtb
  dtb-$(CONFIG_ARCH_AT91) += at91sam9x35ek.dtb
  # sama5d3
 +dtb-$(CONFIG_ARCH_AT91)  += at91-sama5d3_xplained.dtb
  dtb-$(CONFIG_ARCH_AT91)  += sama5d31ek.dtb
  dtb-$(CONFIG_ARCH_AT91)  += sama5d33ek.dtb
  dtb-$(CONFIG_ARCH_AT91)  += sama5d34ek.dtb
 diff --git a/arch/arm/boot/dts/at91-sama5d3_xplained.dts 
 b/arch/arm/boot/dts/at91-sama5d3_xplained.dts
 new file mode 100644
 index ..fb1349ca60a4
 --- /dev/null
 +++ b/arch/arm/boot/dts/at91-sama5d3_xplained.dts
 @@ -0,0 +1,233 @@
 +/*
 + * at91-sama5d3_xplained.dts - Device Tree file for the SAMA5D3 Xplained 
 board
 + *
 + *  Copyright (C) 2014 Atmel,
 + * 2014 Nicolas Ferre nicolas.fe...@atmel.com
 + *
 + * Licensed under GPLv2 or later.
 + */
 +/dts-v1/;
 +#include sama5d36.dtsi
 +
 +/ {
 + model = SAMA5D3 Xplained;
 + compatible = atmel,sama5d3-xplained, atmel,sama5d3, atmel,sama5;
 +
 + chosen {
 + bootargs = console=ttyS0,115200;
can you describe it via linux,stdout
 + };
 +
 + memory {
 + reg = 0x2000 0x1000;
 + };
 +
 + ahb {
 + apb {
 + mmc0: mmc@f000 {
 + pinc§trl-names = default;
?? this is SoC should never been seen here
 + pinctrl-0 = pinctrl_mmc0_clk_cmd_dat0 
 pinctrl_mmc0_dat1_3 pinctrl_mmc0_dat4_7 pinctrl_mmc0_cd;
 + status = okay;
 + slot@0 {
 + reg = 0;
 + bus-width = 8;
 + cd-gpios = pioE 0 GPIO_ACTIVE_LOW;
 + };
 + };
 +
 + spi0: spi@f0004000 {
 + cs-gpios = pioD 13 0, 0, 0, 0;
if you use only one CS no need to specified all

we need to add macro per SoC for the hw CS used as GPIO so it's more clear
 + status = okay;
 + };
 +
 + can0: can@f000c000 {
 + status = okay;
 + };
 +
 + i2c0: i2c@f0014000 {
 + status = okay;
 + };
 +
 + i2c1: i2c@f0018000 {
 + status = okay;
 + };
 +
 + macb0: ethernet@f0028000 {
 + phy-mode = rgmii;
 + status = okay;
 + };
 +
 + usart0: serial@f001c000 {
 + status = okay;
 + };
 +
 + usart1: serial@f002 {
 + pinctrl-names = default;
same as mmc
 + pinctrl-0 = pinctrl_usart1 
 pinctrl_usart1_rts_cts;
 + status = okay;
 + };
 +
 + uart0: serial@f0024000 {
 + status = okay;
 + };
 +
 + mmc1: mmc@f800 {
 + pinctrl-names = default;
ditto
 + pinctrl-0 = pinctrl_mmc1_clk_cmd_dat0 
 pinctrl_mmc1_dat1_3 pinctrl_mmc1_cd;
 + status = okay;
 + slot@0 {
 + reg = 0;
 + bus-width = 4;
 + cd-gpios = pioE 1 GPIO_ACTIVE_HIGH;
 + };
 + };
 +
 + spi1: spi@f8008000 {
 + cs-gpios = pioC 25 0, 0, 0, pioD 16 0;
 + status = okay;
 + };
 +
 + adc0: adc@f8018000 {
 + pinctrl-names = default;
ditto
 + pinctrl-0 = 
 + pinctrl_adc0_adtrg
 + pinctrl_adc0_ad0
 + pinctrl_adc0_ad1
 + pinctrl_adc0_ad2
 + pinctrl_adc0_ad3
 + 

Re: [PATCH v2] ARM: at91: add Atmel's SAMA5D3 Xplained board

2014-02-07 Thread Nicolas Ferre
On 07/02/2014 09:01, Jean-Christophe PLAGNIOL-VILLARD :
 On 09:35 Wed 05 Feb , Nicolas Ferre wrote:
 Add DT file for new SAMA5D3 Xpained board.
 This board is based on Atmel's SAMA5D36 Cortex-A5 SoC.

 Signed-off-by: Nicolas Ferre nicolas.fe...@atmel.com
 ---
  arch/arm/boot/dts/Makefile  |   1 +
  arch/arm/boot/dts/at91-sama5d3_xplained.dts | 233 
 
  2 files changed, 234 insertions(+)
  create mode 100644 arch/arm/boot/dts/at91-sama5d3_xplained.dts

 diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
 index b9d6a8b485e0..6d1e43d46187 100644
 --- a/arch/arm/boot/dts/Makefile
 +++ b/arch/arm/boot/dts/Makefile
 @@ -38,6 +38,7 @@ dtb-$(CONFIG_ARCH_AT91) += at91sam9g35ek.dtb
  dtb-$(CONFIG_ARCH_AT91) += at91sam9x25ek.dtb
  dtb-$(CONFIG_ARCH_AT91) += at91sam9x35ek.dtb
  # sama5d3
 +dtb-$(CONFIG_ARCH_AT91) += at91-sama5d3_xplained.dtb
  dtb-$(CONFIG_ARCH_AT91) += sama5d31ek.dtb
  dtb-$(CONFIG_ARCH_AT91) += sama5d33ek.dtb
  dtb-$(CONFIG_ARCH_AT91) += sama5d34ek.dtb
 diff --git a/arch/arm/boot/dts/at91-sama5d3_xplained.dts 
 b/arch/arm/boot/dts/at91-sama5d3_xplained.dts
 new file mode 100644
 index ..fb1349ca60a4
 --- /dev/null
 +++ b/arch/arm/boot/dts/at91-sama5d3_xplained.dts
 @@ -0,0 +1,233 @@
 +/*
 + * at91-sama5d3_xplained.dts - Device Tree file for the SAMA5D3 Xplained 
 board
 + *
 + *  Copyright (C) 2014 Atmel,
 + *2014 Nicolas Ferre nicolas.fe...@atmel.com
 + *
 + * Licensed under GPLv2 or later.
 + */
 +/dts-v1/;
 +#include sama5d36.dtsi
 +
 +/ {
 +model = SAMA5D3 Xplained;
 +compatible = atmel,sama5d3-xplained, atmel,sama5d3, atmel,sama5;
 +
 +chosen {
 +bootargs = console=ttyS0,115200;
 can you describe it via linux,stdout

Well I would have liked, but the code in the serial driver is not there yet.
So, I keep it like this for the moment.

 +};
 +
 +memory {
 +reg = 0x2000 0x1000;
 +};
 +
 +ahb {
 +apb {
 +mmc0: mmc@f000 {
 +pinc§trl-names = default;
 ?? this is SoC should never been seen here
 +pinctrl-0 = pinctrl_mmc0_clk_cmd_dat0 
 pinctrl_mmc0_dat1_3 pinctrl_mmc0_dat4_7 pinctrl_mmc0_cd;
 +status = okay;
 +slot@0 {
 +reg = 0;
 +bus-width = 8;
 +cd-gpios = pioE 0 GPIO_ACTIVE_LOW;
 +};
 +};
 +
 +spi0: spi@f0004000 {
 +cs-gpios = pioD 13 0, 0, 0, 0;
 if you use only one CS no need to specified all
 
 we need to add macro per SoC for the hw CS used as GPIO so it's more clear

No, I do not think so.

 +status = okay;
 +};
 +
 +can0: can@f000c000 {
 +status = okay;
 +};
 +
 +i2c0: i2c@f0014000 {
 +status = okay;
 +};
 +
 +i2c1: i2c@f0018000 {
 +status = okay;
 +};
 +
 +macb0: ethernet@f0028000 {
 +phy-mode = rgmii;
 +status = okay;
 +};
 +
 +usart0: serial@f001c000 {
 +status = okay;
 +};
 +
 +usart1: serial@f002 {
 +pinctrl-names = default;
 same as mmc
 +pinctrl-0 = pinctrl_usart1 
 pinctrl_usart1_rts_cts;
 +status = okay;
 +};
 +
 +uart0: serial@f0024000 {
 +status = okay;
 +};
 +
 +mmc1: mmc@f800 {
 +pinctrl-names = default;
 ditto
 +pinctrl-0 = pinctrl_mmc1_clk_cmd_dat0 
 pinctrl_mmc1_dat1_3 pinctrl_mmc1_cd;
 +status = okay;
 +slot@0 {
 +reg = 0;
 +bus-width = 4;
 +cd-gpios = pioE 1 GPIO_ACTIVE_HIGH;
 +};
 +};
 +
 +spi1: spi@f8008000 {
 +cs-gpios = pioC 25 0, 0, 0, pioD 16 0;
 +status = okay;
 +};
 +
 +adc0: adc@f8018000 {
 +pinctrl-names = default;
 ditto
 +pinctrl-0 = 
 +pinctrl_adc0_adtrg
 +pinctrl_adc0_ad0
 +pinctrl_adc0_ad1
 

Re: [PATCH v2] ARM: at91: add Atmel's SAMA5D3 Xplained board

2014-02-07 Thread Jean-Christophe PLAGNIOL-VILLARD
On 15:37 Fri 07 Feb , Nicolas Ferre wrote:
 On 07/02/2014 09:01, Jean-Christophe PLAGNIOL-VILLARD :
  On 09:35 Wed 05 Feb , Nicolas Ferre wrote:
  Add DT file for new SAMA5D3 Xpained board.
  This board is based on Atmel's SAMA5D36 Cortex-A5 SoC.
 
  Signed-off-by: Nicolas Ferre nicolas.fe...@atmel.com
  ---
   arch/arm/boot/dts/Makefile  |   1 +
   arch/arm/boot/dts/at91-sama5d3_xplained.dts | 233 
  
   2 files changed, 234 insertions(+)
   create mode 100644 arch/arm/boot/dts/at91-sama5d3_xplained.dts
 
  diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
  index b9d6a8b485e0..6d1e43d46187 100644
  --- a/arch/arm/boot/dts/Makefile
  +++ b/arch/arm/boot/dts/Makefile
  @@ -38,6 +38,7 @@ dtb-$(CONFIG_ARCH_AT91) += at91sam9g35ek.dtb
   dtb-$(CONFIG_ARCH_AT91) += at91sam9x25ek.dtb
   dtb-$(CONFIG_ARCH_AT91) += at91sam9x35ek.dtb
   # sama5d3
  +dtb-$(CONFIG_ARCH_AT91)   += at91-sama5d3_xplained.dtb
   dtb-$(CONFIG_ARCH_AT91)   += sama5d31ek.dtb
   dtb-$(CONFIG_ARCH_AT91)   += sama5d33ek.dtb
   dtb-$(CONFIG_ARCH_AT91)   += sama5d34ek.dtb
  diff --git a/arch/arm/boot/dts/at91-sama5d3_xplained.dts 
  b/arch/arm/boot/dts/at91-sama5d3_xplained.dts
  new file mode 100644
  index ..fb1349ca60a4
  --- /dev/null
  +++ b/arch/arm/boot/dts/at91-sama5d3_xplained.dts
  @@ -0,0 +1,233 @@
  +/*
  + * at91-sama5d3_xplained.dts - Device Tree file for the SAMA5D3 Xplained 
  board
  + *
  + *  Copyright (C) 2014 Atmel,
  + *  2014 Nicolas Ferre nicolas.fe...@atmel.com
  + *
  + * Licensed under GPLv2 or later.
  + */
  +/dts-v1/;
  +#include sama5d36.dtsi
  +
  +/ {
  +  model = SAMA5D3 Xplained;
  +  compatible = atmel,sama5d3-xplained, atmel,sama5d3, atmel,sama5;
  +
  +  chosen {
  +  bootargs = console=ttyS0,115200;
  can you describe it via linux,stdout
 
 Well I would have liked, but the code in the serial driver is not there yet.
 So, I keep it like this for the moment.
 
  +  };
  +
  +  memory {
  +  reg = 0x2000 0x1000;
  +  };
  +
  +  ahb {
  +  apb {
  +  mmc0: mmc@f000 {
  +  pinc§trl-names = default;
  ?? this is SoC should never been seen here
this need to move to dtsi not here
  +  pinctrl-0 = pinctrl_mmc0_clk_cmd_dat0 
  pinctrl_mmc0_dat1_3 pinctrl_mmc0_dat4_7 pinctrl_mmc0_cd;
  +  status = okay;
  +  slot@0 {
  +  reg = 0;
  +  bus-width = 8;
  +  cd-gpios = pioE 0 GPIO_ACTIVE_LOW;
  +  };
  +  };
  +
  +  spi0: spi@f0004000 {
  +  cs-gpios = pioD 13 0, 0, 0, 0;
  if you use only one CS no need to specified all
  
  we need to add macro per SoC for the hw CS used as GPIO so it's more clear
 
 No, I do not think so.

yes as you dopy pioD 13 0 everywhere instead of doing

#define SAMA5D3_SPI_CS0_GPIOpioD 13 GPIO_ACTIVE_LOW

and then

cs-gpios = SAMA5D3_SPI_CS0_GPIO;
and drop the
, 0, 0, 0;

  +  status = okay;
  +  };
  +
  +  can0: can@f000c000 {
  +  status = okay;
  +  };
  +
  +  i2c0: i2c@f0014000 {
  +  status = okay;
  +  };
  +
  +  i2c1: i2c@f0018000 {
  +  status = okay;
  +  };
  +
  +  macb0: ethernet@f0028000 {
  +  phy-mode = rgmii;
  +  status = okay;
  +  };
  +
  +  usart0: serial@f001c000 {
  +  status = okay;
  +  };
  +
  +  usart1: serial@f002 {
  +  pinctrl-names = default;
  same as mmc
  +  pinctrl-0 = pinctrl_usart1 
  pinctrl_usart1_rts_cts;
  +  status = okay;
  +  };
  +
  +  uart0: serial@f0024000 {
  +  status = okay;
  +  };
  +
  +  mmc1: mmc@f800 {
  +  pinctrl-names = default;
  ditto
  +  pinctrl-0 = pinctrl_mmc1_clk_cmd_dat0 
  pinctrl_mmc1_dat1_3 pinctrl_mmc1_cd;
  +  status = okay;
  +  slot@0 {
  +  reg = 0;
  +  bus-width = 4;
  +  cd-gpios = pioE 1 GPIO_ACTIVE_HIGH;
  +  };
  +  };
  +
  +  spi1: spi@f8008000 {
  +  cs-gpios = pioC 25 0, 0, 0, pioD 16 0;
  +  status = okay;
  +  

[PATCH v2] ARM: at91: add Atmel's SAMA5D3 Xplained board

2014-02-05 Thread Nicolas Ferre
Add DT file for new SAMA5D3 Xpained board.
This board is based on Atmel's SAMA5D36 Cortex-A5 SoC.

Signed-off-by: Nicolas Ferre 
---
 arch/arm/boot/dts/Makefile  |   1 +
 arch/arm/boot/dts/at91-sama5d3_xplained.dts | 233 
 2 files changed, 234 insertions(+)
 create mode 100644 arch/arm/boot/dts/at91-sama5d3_xplained.dts

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index b9d6a8b485e0..6d1e43d46187 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -38,6 +38,7 @@ dtb-$(CONFIG_ARCH_AT91) += at91sam9g35ek.dtb
 dtb-$(CONFIG_ARCH_AT91) += at91sam9x25ek.dtb
 dtb-$(CONFIG_ARCH_AT91) += at91sam9x35ek.dtb
 # sama5d3
+dtb-$(CONFIG_ARCH_AT91)+= at91-sama5d3_xplained.dtb
 dtb-$(CONFIG_ARCH_AT91)+= sama5d31ek.dtb
 dtb-$(CONFIG_ARCH_AT91)+= sama5d33ek.dtb
 dtb-$(CONFIG_ARCH_AT91)+= sama5d34ek.dtb
diff --git a/arch/arm/boot/dts/at91-sama5d3_xplained.dts 
b/arch/arm/boot/dts/at91-sama5d3_xplained.dts
new file mode 100644
index ..fb1349ca60a4
--- /dev/null
+++ b/arch/arm/boot/dts/at91-sama5d3_xplained.dts
@@ -0,0 +1,233 @@
+/*
+ * at91-sama5d3_xplained.dts - Device Tree file for the SAMA5D3 Xplained board
+ *
+ *  Copyright (C) 2014 Atmel,
+ *   2014 Nicolas Ferre 
+ *
+ * Licensed under GPLv2 or later.
+ */
+/dts-v1/;
+#include "sama5d36.dtsi"
+
+/ {
+   model = "SAMA5D3 Xplained";
+   compatible = "atmel,sama5d3-xplained", "atmel,sama5d3", "atmel,sama5";
+
+   chosen {
+   bootargs = "console=ttyS0,115200";
+   };
+
+   memory {
+   reg = <0x2000 0x1000>;
+   };
+
+   ahb {
+   apb {
+   mmc0: mmc@f000 {
+   pinctrl-names = "default";
+   pinctrl-0 = <_mmc0_clk_cmd_dat0 
_mmc0_dat1_3 _mmc0_dat4_7 _mmc0_cd>;
+   status = "okay";
+   slot@0 {
+   reg = <0>;
+   bus-width = <8>;
+   cd-gpios = < 0 GPIO_ACTIVE_LOW>;
+   };
+   };
+
+   spi0: spi@f0004000 {
+   cs-gpios = < 13 0>, <0>, <0>, <0>;
+   status = "okay";
+   };
+
+   can0: can@f000c000 {
+   status = "okay";
+   };
+
+   i2c0: i2c@f0014000 {
+   status = "okay";
+   };
+
+   i2c1: i2c@f0018000 {
+   status = "okay";
+   };
+
+   macb0: ethernet@f0028000 {
+   phy-mode = "rgmii";
+   status = "okay";
+   };
+
+   usart0: serial@f001c000 {
+   status = "okay";
+   };
+
+   usart1: serial@f002 {
+   pinctrl-names = "default";
+   pinctrl-0 = <_usart1 
_usart1_rts_cts>;
+   status = "okay";
+   };
+
+   uart0: serial@f0024000 {
+   status = "okay";
+   };
+
+   mmc1: mmc@f800 {
+   pinctrl-names = "default";
+   pinctrl-0 = <_mmc1_clk_cmd_dat0 
_mmc1_dat1_3 _mmc1_cd>;
+   status = "okay";
+   slot@0 {
+   reg = <0>;
+   bus-width = <4>;
+   cd-gpios = < 1 GPIO_ACTIVE_HIGH>;
+   };
+   };
+
+   spi1: spi@f8008000 {
+   cs-gpios = < 25 0>, <0>, <0>, < 16 0>;
+   status = "okay";
+   };
+
+   adc0: adc@f8018000 {
+   pinctrl-names = "default";
+   pinctrl-0 = <
+   _adc0_adtrg
+   _adc0_ad0
+   _adc0_ad1
+   _adc0_ad2
+   _adc0_ad3
+   _adc0_ad4
+   _adc0_ad5
+   _adc0_ad6
+   _adc0_ad7
+   _adc0_ad8
+   _adc0_ad9
+   >;
+

[PATCH v2] ARM: at91: add Atmel's SAMA5D3 Xplained board

2014-02-05 Thread Nicolas Ferre
Add DT file for new SAMA5D3 Xpained board.
This board is based on Atmel's SAMA5D36 Cortex-A5 SoC.

Signed-off-by: Nicolas Ferre nicolas.fe...@atmel.com
---
 arch/arm/boot/dts/Makefile  |   1 +
 arch/arm/boot/dts/at91-sama5d3_xplained.dts | 233 
 2 files changed, 234 insertions(+)
 create mode 100644 arch/arm/boot/dts/at91-sama5d3_xplained.dts

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index b9d6a8b485e0..6d1e43d46187 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -38,6 +38,7 @@ dtb-$(CONFIG_ARCH_AT91) += at91sam9g35ek.dtb
 dtb-$(CONFIG_ARCH_AT91) += at91sam9x25ek.dtb
 dtb-$(CONFIG_ARCH_AT91) += at91sam9x35ek.dtb
 # sama5d3
+dtb-$(CONFIG_ARCH_AT91)+= at91-sama5d3_xplained.dtb
 dtb-$(CONFIG_ARCH_AT91)+= sama5d31ek.dtb
 dtb-$(CONFIG_ARCH_AT91)+= sama5d33ek.dtb
 dtb-$(CONFIG_ARCH_AT91)+= sama5d34ek.dtb
diff --git a/arch/arm/boot/dts/at91-sama5d3_xplained.dts 
b/arch/arm/boot/dts/at91-sama5d3_xplained.dts
new file mode 100644
index ..fb1349ca60a4
--- /dev/null
+++ b/arch/arm/boot/dts/at91-sama5d3_xplained.dts
@@ -0,0 +1,233 @@
+/*
+ * at91-sama5d3_xplained.dts - Device Tree file for the SAMA5D3 Xplained board
+ *
+ *  Copyright (C) 2014 Atmel,
+ *   2014 Nicolas Ferre nicolas.fe...@atmel.com
+ *
+ * Licensed under GPLv2 or later.
+ */
+/dts-v1/;
+#include sama5d36.dtsi
+
+/ {
+   model = SAMA5D3 Xplained;
+   compatible = atmel,sama5d3-xplained, atmel,sama5d3, atmel,sama5;
+
+   chosen {
+   bootargs = console=ttyS0,115200;
+   };
+
+   memory {
+   reg = 0x2000 0x1000;
+   };
+
+   ahb {
+   apb {
+   mmc0: mmc@f000 {
+   pinctrl-names = default;
+   pinctrl-0 = pinctrl_mmc0_clk_cmd_dat0 
pinctrl_mmc0_dat1_3 pinctrl_mmc0_dat4_7 pinctrl_mmc0_cd;
+   status = okay;
+   slot@0 {
+   reg = 0;
+   bus-width = 8;
+   cd-gpios = pioE 0 GPIO_ACTIVE_LOW;
+   };
+   };
+
+   spi0: spi@f0004000 {
+   cs-gpios = pioD 13 0, 0, 0, 0;
+   status = okay;
+   };
+
+   can0: can@f000c000 {
+   status = okay;
+   };
+
+   i2c0: i2c@f0014000 {
+   status = okay;
+   };
+
+   i2c1: i2c@f0018000 {
+   status = okay;
+   };
+
+   macb0: ethernet@f0028000 {
+   phy-mode = rgmii;
+   status = okay;
+   };
+
+   usart0: serial@f001c000 {
+   status = okay;
+   };
+
+   usart1: serial@f002 {
+   pinctrl-names = default;
+   pinctrl-0 = pinctrl_usart1 
pinctrl_usart1_rts_cts;
+   status = okay;
+   };
+
+   uart0: serial@f0024000 {
+   status = okay;
+   };
+
+   mmc1: mmc@f800 {
+   pinctrl-names = default;
+   pinctrl-0 = pinctrl_mmc1_clk_cmd_dat0 
pinctrl_mmc1_dat1_3 pinctrl_mmc1_cd;
+   status = okay;
+   slot@0 {
+   reg = 0;
+   bus-width = 4;
+   cd-gpios = pioE 1 GPIO_ACTIVE_HIGH;
+   };
+   };
+
+   spi1: spi@f8008000 {
+   cs-gpios = pioC 25 0, 0, 0, pioD 16 0;
+   status = okay;
+   };
+
+   adc0: adc@f8018000 {
+   pinctrl-names = default;
+   pinctrl-0 = 
+   pinctrl_adc0_adtrg
+   pinctrl_adc0_ad0
+   pinctrl_adc0_ad1
+   pinctrl_adc0_ad2
+   pinctrl_adc0_ad3
+   pinctrl_adc0_ad4
+   pinctrl_adc0_ad5
+   pinctrl_adc0_ad6
+   pinctrl_adc0_ad7
+