Re: [PATCH v2] arm64: dts: qcom: Update iommu property for simultaneous playback

[Stephen Boyd]

Quoting Srinivasa Rao Mandadapu (2021-04-09 22:17:07)
> Hi Stephen.
> 
> Thanks for your time!!!
> 
> 
> On 4/9/2021 10:31 PM, Stephen Boyd wrote:
> > Quoting Srinivasa Rao Mandadapu (2021-04-06 09:33:30)
> >> From: V Sujith Kumar Reddy 
> >>
> >> Update iommu property in lpass cpu node for supporting
> >> simultaneous playback on headset and speaker.
> >>
> >> Signed-off-by: V Sujith Kumar Reddy 
> >> Signed-off-by: Srinivasa Rao Mandadapu 
> >> ---
> >> Changes since v1:
> >> -- Commit messge header change
> >>
> >>   arch/arm64/boot/dts/qcom/sc7180.dtsi | 3 ++-
> >>   1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi 
> >> b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> >> index a6da78d31fdd..6228ba2d8513 100644
> >> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> >> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> >> @@ -3566,7 +3566,8 @@ lpass_cpu: lpass@62f0 {
> >>  reg = <0 0x62f0 0 0x29000>;
> >>  reg-names = "lpass-lpaif";
> >>   
> >> -   iommus = <_smmu 0x1020 0>;
> >> +   iommus = <_smmu 0x1020 0>,
> >> +   <_smmu 0x1021 0>;
> > The stream ID 0x1032 was also dropped in this version but there's no
> > mention of that in the changelog. Why?
> That is ID is for HDMI Stream, so as part of DP patches that will be added.

Ok, got it.

Re: [PATCH v2] arm64: dts: qcom: Update iommu property for simultaneous playback

[Stephen Boyd]

Quoting Srinivasa Rao Mandadapu (2021-04-06 09:33:30)
> From: V Sujith Kumar Reddy 
> 
> Update iommu property in lpass cpu node for supporting
> simultaneous playback on headset and speaker.
> 
> Signed-off-by: V Sujith Kumar Reddy 
> Signed-off-by: Srinivasa Rao Mandadapu 
> ---

Reviewed-by: Stephen Boyd 

Re: [PATCH v2] arm64: dts: qcom: Update iommu property for simultaneous playback

[Srinivasa Rao Mandadapu]

Hi Stephen.

Thanks for your time!!!


On 4/9/2021 10:31 PM, Stephen Boyd wrote:

Quoting Srinivasa Rao Mandadapu (2021-04-06 09:33:30)

From: V Sujith Kumar Reddy 

Update iommu property in lpass cpu node for supporting
simultaneous playback on headset and speaker.

Signed-off-by: V Sujith Kumar Reddy 
Signed-off-by: Srinivasa Rao Mandadapu 
---
Changes since v1:
-- Commit messge header change

  arch/arm64/boot/dts/qcom/sc7180.dtsi | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi 
b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index a6da78d31fdd..6228ba2d8513 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -3566,7 +3566,8 @@ lpass_cpu: lpass@62f0 {
 reg = <0 0x62f0 0 0x29000>;
 reg-names = "lpass-lpaif";
  
-   iommus = <_smmu 0x1020 0>;

+   iommus = <_smmu 0x1020 0>,
+   <_smmu 0x1021 0>;

The stream ID 0x1032 was also dropped in this version but there's no
mention of that in the changelog. Why?

That is ID is for HDMI Stream, so as part of DP patches that will be added.


  
 power-domains = <_hm LPASS_CORE_HM_GDSCR>;



--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.

Re: [PATCH v2] arm64: dts: qcom: Update iommu property for simultaneous playback

[Stephen Boyd]

Quoting Srinivasa Rao Mandadapu (2021-04-06 09:33:30)
> From: V Sujith Kumar Reddy 
> 
> Update iommu property in lpass cpu node for supporting
> simultaneous playback on headset and speaker.
> 
> Signed-off-by: V Sujith Kumar Reddy 
> Signed-off-by: Srinivasa Rao Mandadapu 
> ---
> Changes since v1:
>-- Commit messge header change
> 
>  arch/arm64/boot/dts/qcom/sc7180.dtsi | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi 
> b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index a6da78d31fdd..6228ba2d8513 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -3566,7 +3566,8 @@ lpass_cpu: lpass@62f0 {
> reg = <0 0x62f0 0 0x29000>;
> reg-names = "lpass-lpaif";
>  
> -   iommus = <_smmu 0x1020 0>;
> +   iommus = <_smmu 0x1020 0>,
> +   <_smmu 0x1021 0>;

The stream ID 0x1032 was also dropped in this version but there's no
mention of that in the changelog. Why?

>  
> power-domains = <_hm LPASS_CORE_HM_GDSCR>;
>

[PATCH v2] arm64: dts: qcom: Update iommu property for simultaneous playback

[Srinivasa Rao Mandadapu]

From: V Sujith Kumar Reddy 

Update iommu property in lpass cpu node for supporting
simultaneous playback on headset and speaker.

Signed-off-by: V Sujith Kumar Reddy 
Signed-off-by: Srinivasa Rao Mandadapu 
---
Changes since v1:
   -- Commit messge header change

 arch/arm64/boot/dts/qcom/sc7180.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi 
b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index a6da78d31fdd..6228ba2d8513 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -3566,7 +3566,8 @@ lpass_cpu: lpass@62f0 {
reg = <0 0x62f0 0 0x29000>;
reg-names = "lpass-lpaif";
 
-   iommus = <_smmu 0x1020 0>;
+   iommus = <_smmu 0x1020 0>,
+   <_smmu 0x1021 0>;
 
power-domains = <_hm LPASS_CORE_HM_GDSCR>;
 
-- 
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.