Re: [PATCH v2 0/6] menuconfig: jump to search results
On 23.8.2012 20:55, Benjamin Poirier wrote: > This patch series adds "jump to" keys (similar to the cscope interface) to the > search results of "make menuconfig" so that we can go directly to the menu > entry for a config option after searching for it. > > Patches 1-4 implement the basic functionality. > Patches 5-6 are an optional improvement. Applied to kbuild.git#kconfig, thanks a lot. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 0/6] menuconfig: jump to search results
On 23.8.2012 20:55, Benjamin Poirier wrote: This patch series adds jump to keys (similar to the cscope interface) to the search results of make menuconfig so that we can go directly to the menu entry for a config option after searching for it. Patches 1-4 implement the basic functionality. Patches 5-6 are an optional improvement. Applied to kbuild.git#kconfig, thanks a lot. Michal -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 0/6] menuconfig: jump to search results
On 2012/08/24 17:49, Borislav Petkov wrote: > On Thu, Aug 23, 2012 at 02:55:02PM -0400, Benjamin Poirier wrote: > > This patch series adds "jump to" keys (similar to the cscope interface) to > > the > > search results of "make menuconfig" so that we can go directly to the menu > > entry for a config option after searching for it. > > > > Patches 1-4 implement the basic functionality. > > Patches 5-6 are an optional improvement. > > > > Changes v1-v2: > > * add a short description to patches 2 & 3 > > * correct checkpatch style warnings on patch 6 > > > > It should be targeted for v3.7 > > Ok, did a quick test on -rc3 here. Is it a feature that if I do a > search, go to the result, then do a search again and go to another > result from the second search... and do that a couple of times, clicking > on Exit at the lower part of the menu returns me back to all the > searches I had done? Much like a stack. > > I mean, I don't mind it that way, it is workable - I'm just asking :). That's how it's meant, yes. As stated in the log for patch 4: menuconfig: Add jump keys to search results [...] After exiting this menu, the user is returned to the search results where he may jump further in or elsewhere. ... and after exiting the search results the user is returned to the menu where he was before performing the search. That's the current behavior. A likely alternative would be that jumping to a menu entry would exit the search results, forget the current position in the menus and go to the new one as if the user had navigated to it from the root menu. The current mconf.c code structure lends itself much better to the "stacked" way of doing things. Each navigation to a deeper menu corresponds to a nested conf() call. To do it the second way we'd have to add logic to exit these nested conf() calls and redo new ones without user intervention or change how it's handled altogether. It seemed to me that choosing one approach over the other was debatable UI-wise but that the first approach was definitely simpler code-wise. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 0/6] menuconfig: jump to search results
On Thu, Aug 23, 2012 at 02:55:02PM -0400, Benjamin Poirier wrote: > This patch series adds "jump to" keys (similar to the cscope interface) to the > search results of "make menuconfig" so that we can go directly to the menu > entry for a config option after searching for it. > > Patches 1-4 implement the basic functionality. > Patches 5-6 are an optional improvement. > > Changes v1-v2: > * add a short description to patches 2 & 3 > * correct checkpatch style warnings on patch 6 > > It should be targeted for v3.7 Ok, did a quick test on -rc3 here. Is it a feature that if I do a search, go to the result, then do a search again and go to another result from the second search... and do that a couple of times, clicking on Exit at the lower part of the menu returns me back to all the searches I had done? Much like a stack. I mean, I don't mind it that way, it is workable - I'm just asking :). Thanks. -- Regards/Gruss, Boris. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 0/6] menuconfig: jump to search results
On Thu, Aug 23, 2012 at 02:55:02PM -0400, Benjamin Poirier wrote: This patch series adds jump to keys (similar to the cscope interface) to the search results of make menuconfig so that we can go directly to the menu entry for a config option after searching for it. Patches 1-4 implement the basic functionality. Patches 5-6 are an optional improvement. Changes v1-v2: * add a short description to patches 2 3 * correct checkpatch style warnings on patch 6 It should be targeted for v3.7 Ok, did a quick test on -rc3 here. Is it a feature that if I do a search, go to the result, then do a search again and go to another result from the second search... and do that a couple of times, clicking on Exit at the lower part of the menu returns me back to all the searches I had done? Much like a stack. I mean, I don't mind it that way, it is workable - I'm just asking :). Thanks. -- Regards/Gruss, Boris. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 0/6] menuconfig: jump to search results
On 2012/08/24 17:49, Borislav Petkov wrote: On Thu, Aug 23, 2012 at 02:55:02PM -0400, Benjamin Poirier wrote: This patch series adds jump to keys (similar to the cscope interface) to the search results of make menuconfig so that we can go directly to the menu entry for a config option after searching for it. Patches 1-4 implement the basic functionality. Patches 5-6 are an optional improvement. Changes v1-v2: * add a short description to patches 2 3 * correct checkpatch style warnings on patch 6 It should be targeted for v3.7 Ok, did a quick test on -rc3 here. Is it a feature that if I do a search, go to the result, then do a search again and go to another result from the second search... and do that a couple of times, clicking on Exit at the lower part of the menu returns me back to all the searches I had done? Much like a stack. I mean, I don't mind it that way, it is workable - I'm just asking :). That's how it's meant, yes. As stated in the log for patch 4: menuconfig: Add jump keys to search results [...] After exiting this menu, the user is returned to the search results where he may jump further in or elsewhere. ... and after exiting the search results the user is returned to the menu where he was before performing the search. That's the current behavior. A likely alternative would be that jumping to a menu entry would exit the search results, forget the current position in the menus and go to the new one as if the user had navigated to it from the root menu. The current mconf.c code structure lends itself much better to the stacked way of doing things. Each navigation to a deeper menu corresponds to a nested conf() call. To do it the second way we'd have to add logic to exit these nested conf() calls and redo new ones without user intervention or change how it's handled altogether. It seemed to me that choosing one approach over the other was debatable UI-wise but that the first approach was definitely simpler code-wise. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2 0/6] menuconfig: jump to search results
This patch series adds "jump to" keys (similar to the cscope interface) to the search results of "make menuconfig" so that we can go directly to the menu entry for a config option after searching for it. Patches 1-4 implement the basic functionality. Patches 5-6 are an optional improvement. Changes v1-v2: * add a short description to patches 2 & 3 * correct checkpatch style warnings on patch 6 It should be targeted for v3.7 Enjoy, -Benjamin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2 0/6] menuconfig: jump to search results
This patch series adds jump to keys (similar to the cscope interface) to the search results of make menuconfig so that we can go directly to the menu entry for a config option after searching for it. Patches 1-4 implement the basic functionality. Patches 5-6 are an optional improvement. Changes v1-v2: * add a short description to patches 2 3 * correct checkpatch style warnings on patch 6 It should be targeted for v3.7 Enjoy, -Benjamin -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
