Re: [PATCH v2 1/9] staging: ccree: introduce CryptoCell HW driver
Hi, [ Re sending with all recipients this time ... ] On Thu, Apr 20, 2017 at 5:01 PM, Greg Kroah-Hartmanwrote: >> > Oh, I have to ask, do you really mean "any later version" here and >> > elsewhere? >> > >> > If so, then your MODULE_LICENSE() marking is wrong, please fix that up, >> > or fix up the license text, I can't take incompatible ones without >> > getting angry emails from legal people sent to me... >> > >> >> Thanks for noticing this. >> >> The copyright + license notice is a boilerplate I got from the powers >> that be here. >> >> I'll consult internally what is the proper action. I don't want to >> make legal mad either... :-) > > Ok, I'll drop this patch series then, and wait for an updated one with > this fixed up. This issue, along with some others pointed by reviewers, are fixed in v3 of the patch set. I will be happy if you choose to take it into the staging tree and will continue to work to cut down the TODO list. Thanks, Gilad -- Gilad Ben-Yossef Chief Coffee Drinker "If you take a class in large-scale robotics, can you end up in a situation where the homework eats your dog?" -- Jean-Baptiste Queru
Re: [PATCH v2 1/9] staging: ccree: introduce CryptoCell HW driver
Hi, [ Re sending with all recipients this time ... ] On Thu, Apr 20, 2017 at 5:01 PM, Greg Kroah-Hartman wrote: >> > Oh, I have to ask, do you really mean "any later version" here and >> > elsewhere? >> > >> > If so, then your MODULE_LICENSE() marking is wrong, please fix that up, >> > or fix up the license text, I can't take incompatible ones without >> > getting angry emails from legal people sent to me... >> > >> >> Thanks for noticing this. >> >> The copyright + license notice is a boilerplate I got from the powers >> that be here. >> >> I'll consult internally what is the proper action. I don't want to >> make legal mad either... :-) > > Ok, I'll drop this patch series then, and wait for an updated one with > this fixed up. This issue, along with some others pointed by reviewers, are fixed in v3 of the patch set. I will be happy if you choose to take it into the staging tree and will continue to work to cut down the TODO list. Thanks, Gilad -- Gilad Ben-Yossef Chief Coffee Drinker "If you take a class in large-scale robotics, can you end up in a situation where the homework eats your dog?" -- Jean-Baptiste Queru
Re: [PATCH v2 1/9] staging: ccree: introduce CryptoCell HW driver
Hi Gilad, [auto build test ERROR on linus/master] [also build test ERROR on v4.11-rc7] [cannot apply to staging/staging-testing next-20170420] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Gilad-Ben-Yossef/staging-ccree-add-Arm-TrustZone-CryptoCell-REE-driver/20170420-222023 config: i386-allmodconfig (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=i386 All error/warnings (new ones prefixed by >>): In file included from drivers/staging/ccree/ssi_driver.h:48:0, from drivers/staging/ccree/ssi_driver.c:60: >> drivers/staging/ccree/cc_hal.h:29:2: error: #error Unsupported platform #error Unsupported platform ^ drivers/staging/ccree/ssi_driver.c: In function 'cc_isr': >> drivers/staging/ccree/cc_hal.h:33:38: error: implicit declaration of >> function 'READ_REGISTER' [-Werror=implicit-function-declaration] #define CC_HAL_READ_REGISTER(offset) READ_REGISTER(cc_base + offset) ^ >> drivers/staging/ccree/ssi_driver.c:120:8: note: in expansion of macro >> 'CC_HAL_READ_REGISTER' irr = CC_HAL_READ_REGISTER(CC_REG_OFFSET(HOST_RGF, HOST_IRR)); ^~~~ >> drivers/staging/ccree/cc_hal.h:32:44: error: implicit declaration of >> function 'WRITE_REGISTER' [-Werror=implicit-function-declaration] #define CC_HAL_WRITE_REGISTER(offset, val) WRITE_REGISTER(cc_base + offset, val) ^ >> drivers/staging/ccree/ssi_driver.c:129:2: note: in expansion of macro >> 'CC_HAL_WRITE_REGISTER' CC_HAL_WRITE_REGISTER(CC_REG_OFFSET(HOST_RGF, HOST_ICR), irr); ^ cc1: some warnings being treated as errors -- In file included from drivers/staging/ccree/ssi_driver.h:48:0, from drivers/staging/ccree/ssi_sysfs.c:19: >> drivers/staging/ccree/cc_hal.h:29:2: error: #error Unsupported platform #error Unsupported platform ^ drivers/staging/ccree/ssi_sysfs.c: In function 'ssi_sys_regdump_show': >> drivers/staging/ccree/cc_hal.h:33:38: error: implicit declaration of >> function 'READ_REGISTER' [-Werror=implicit-function-declaration] #define CC_HAL_READ_REGISTER(offset) READ_REGISTER(cc_base + offset) ^ >> drivers/staging/ccree/ssi_sysfs.c:291:19: note: in expansion of macro >> 'CC_HAL_READ_REGISTER' register_value = CC_HAL_READ_REGISTER(CC_REG_OFFSET(HOST_RGF, HOST_SIGNATURE)); ^~~~ cc1: some warnings being treated as errors -- In file included from drivers/staging/ccree/ssi_driver.h:48:0, from drivers/staging/ccree/ssi_buffer_mgr.h:27, from drivers/staging/ccree/ssi_buffer_mgr.c:28: >> drivers/staging/ccree/cc_hal.h:29:2: error: #error Unsupported platform #error Unsupported platform ^ -- In file included from drivers/staging/ccree/ssi_driver.h:48:0, from drivers/staging/ccree/ssi_request_mgr.c:27: >> drivers/staging/ccree/cc_hal.h:29:2: error: #error Unsupported platform #error Unsupported platform ^ drivers/staging/ccree/ssi_request_mgr.c: In function 'request_mgr_init': >> drivers/staging/ccree/ssi_request_mgr.c:198:29: error: implicit declaration >> of function 'READ_REGISTER' [-Werror=implicit-function-declaration] req_mgr_h->hw_queue_size = READ_REGISTER(drvdata->cc_base + ^ In file included from drivers/staging/ccree/ssi_driver.h:48:0, from drivers/staging/ccree/ssi_request_mgr.c:27: drivers/staging/ccree/ssi_request_mgr.c: In function 'comp_handler': >> drivers/staging/ccree/cc_hal.h:32:44: error: implicit declaration of >> function 'WRITE_REGISTER' [-Werror=implicit-function-declaration] #define CC_HAL_WRITE_REGISTER(offset, val) WRITE_REGISTER(cc_base + offset, val) ^ >> drivers/staging/ccree/ssi_request_mgr.c:595:3: note: in expansion of macro >> 'CC_HAL_WRITE_REGISTER' CC_HAL_WRITE_REGISTER(CC_REG_OFFSET(HOST_RGF, HOST_ICR), SSI_COMP_IRQ_MASK); ^ cc1: some warnings being treated as errors -- In file included from drivers/staging/ccree/ssi_driver.h:48:0, from drivers/staging/ccree/ssi_pm.c:24: >> drivers/staging/ccree/cc_hal.h:29:2: error: #error Unsupported platform #error Unsupported platform ^ drivers/staging/ccree/ssi_pm.c: In function 'ssi_power_mgr_runtime_suspend': >> drivers/staging/ccree/ssi_pm.c:46:2: error: implicit declaration of function >> 'WRITE_REGISTER' [-Werror=implicit-function-declaration] WRITE_REGISTER(drvdata->cc_base + CC_REG_OFFSET(HOST_RGF, HOST_POWER_DOWN_EN), POWER_DOWN_ENABLE);
Re: [PATCH v2 1/9] staging: ccree: introduce CryptoCell HW driver
Hi Gilad, [auto build test ERROR on linus/master] [also build test ERROR on v4.11-rc7] [cannot apply to staging/staging-testing next-20170420] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Gilad-Ben-Yossef/staging-ccree-add-Arm-TrustZone-CryptoCell-REE-driver/20170420-222023 config: i386-allmodconfig (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=i386 All error/warnings (new ones prefixed by >>): In file included from drivers/staging/ccree/ssi_driver.h:48:0, from drivers/staging/ccree/ssi_driver.c:60: >> drivers/staging/ccree/cc_hal.h:29:2: error: #error Unsupported platform #error Unsupported platform ^ drivers/staging/ccree/ssi_driver.c: In function 'cc_isr': >> drivers/staging/ccree/cc_hal.h:33:38: error: implicit declaration of >> function 'READ_REGISTER' [-Werror=implicit-function-declaration] #define CC_HAL_READ_REGISTER(offset) READ_REGISTER(cc_base + offset) ^ >> drivers/staging/ccree/ssi_driver.c:120:8: note: in expansion of macro >> 'CC_HAL_READ_REGISTER' irr = CC_HAL_READ_REGISTER(CC_REG_OFFSET(HOST_RGF, HOST_IRR)); ^~~~ >> drivers/staging/ccree/cc_hal.h:32:44: error: implicit declaration of >> function 'WRITE_REGISTER' [-Werror=implicit-function-declaration] #define CC_HAL_WRITE_REGISTER(offset, val) WRITE_REGISTER(cc_base + offset, val) ^ >> drivers/staging/ccree/ssi_driver.c:129:2: note: in expansion of macro >> 'CC_HAL_WRITE_REGISTER' CC_HAL_WRITE_REGISTER(CC_REG_OFFSET(HOST_RGF, HOST_ICR), irr); ^ cc1: some warnings being treated as errors -- In file included from drivers/staging/ccree/ssi_driver.h:48:0, from drivers/staging/ccree/ssi_sysfs.c:19: >> drivers/staging/ccree/cc_hal.h:29:2: error: #error Unsupported platform #error Unsupported platform ^ drivers/staging/ccree/ssi_sysfs.c: In function 'ssi_sys_regdump_show': >> drivers/staging/ccree/cc_hal.h:33:38: error: implicit declaration of >> function 'READ_REGISTER' [-Werror=implicit-function-declaration] #define CC_HAL_READ_REGISTER(offset) READ_REGISTER(cc_base + offset) ^ >> drivers/staging/ccree/ssi_sysfs.c:291:19: note: in expansion of macro >> 'CC_HAL_READ_REGISTER' register_value = CC_HAL_READ_REGISTER(CC_REG_OFFSET(HOST_RGF, HOST_SIGNATURE)); ^~~~ cc1: some warnings being treated as errors -- In file included from drivers/staging/ccree/ssi_driver.h:48:0, from drivers/staging/ccree/ssi_buffer_mgr.h:27, from drivers/staging/ccree/ssi_buffer_mgr.c:28: >> drivers/staging/ccree/cc_hal.h:29:2: error: #error Unsupported platform #error Unsupported platform ^ -- In file included from drivers/staging/ccree/ssi_driver.h:48:0, from drivers/staging/ccree/ssi_request_mgr.c:27: >> drivers/staging/ccree/cc_hal.h:29:2: error: #error Unsupported platform #error Unsupported platform ^ drivers/staging/ccree/ssi_request_mgr.c: In function 'request_mgr_init': >> drivers/staging/ccree/ssi_request_mgr.c:198:29: error: implicit declaration >> of function 'READ_REGISTER' [-Werror=implicit-function-declaration] req_mgr_h->hw_queue_size = READ_REGISTER(drvdata->cc_base + ^ In file included from drivers/staging/ccree/ssi_driver.h:48:0, from drivers/staging/ccree/ssi_request_mgr.c:27: drivers/staging/ccree/ssi_request_mgr.c: In function 'comp_handler': >> drivers/staging/ccree/cc_hal.h:32:44: error: implicit declaration of >> function 'WRITE_REGISTER' [-Werror=implicit-function-declaration] #define CC_HAL_WRITE_REGISTER(offset, val) WRITE_REGISTER(cc_base + offset, val) ^ >> drivers/staging/ccree/ssi_request_mgr.c:595:3: note: in expansion of macro >> 'CC_HAL_WRITE_REGISTER' CC_HAL_WRITE_REGISTER(CC_REG_OFFSET(HOST_RGF, HOST_ICR), SSI_COMP_IRQ_MASK); ^ cc1: some warnings being treated as errors -- In file included from drivers/staging/ccree/ssi_driver.h:48:0, from drivers/staging/ccree/ssi_pm.c:24: >> drivers/staging/ccree/cc_hal.h:29:2: error: #error Unsupported platform #error Unsupported platform ^ drivers/staging/ccree/ssi_pm.c: In function 'ssi_power_mgr_runtime_suspend': >> drivers/staging/ccree/ssi_pm.c:46:2: error: implicit declaration of function >> 'WRITE_REGISTER' [-Werror=implicit-function-declaration] WRITE_REGISTER(drvdata->cc_base + CC_REG_OFFSET(HOST_RGF, HOST_POWER_DOWN_EN), POWER_DOWN_ENABLE);
Re: [PATCH v2 1/9] staging: ccree: introduce CryptoCell HW driver
On Thu, Apr 20, 2017 at 04:40:56PM +0300, Gilad Ben-Yossef wrote: > On Thu, Apr 20, 2017 at 4:33 PM, Greg Kroah-Hartman >wrote: > > On Thu, Apr 20, 2017 at 04:12:55PM +0300, Gilad Ben-Yossef wrote: > >> +++ b/drivers/staging/ccree/bsp.h > >> @@ -0,0 +1,21 @@ > >> +/* > >> + * Copyright (C) 2012-2016 ARM Limited or its affiliates. > >> + * > >> + * This program is free software; you can redistribute it and/or modify it > >> + * under the terms of the GNU General Public License as published by the > >> Free > >> + * Software Foundation; either version 2 of the License, or (at your > >> option) > >> + * any later version. > > > > Oh, I have to ask, do you really mean "any later version" here and > > elsewhere? > > > > If so, then your MODULE_LICENSE() marking is wrong, please fix that up, > > or fix up the license text, I can't take incompatible ones without > > getting angry emails from legal people sent to me... > > > > Thanks for noticing this. > > The copyright + license notice is a boilerplate I got from the powers > that be here. > > I'll consult internally what is the proper action. I don't want to > make legal mad either... :-) Ok, I'll drop this patch series then, and wait for an updated one with this fixed up. thanks, greg k-h
Re: [PATCH v2 1/9] staging: ccree: introduce CryptoCell HW driver
On Thu, Apr 20, 2017 at 04:40:56PM +0300, Gilad Ben-Yossef wrote: > On Thu, Apr 20, 2017 at 4:33 PM, Greg Kroah-Hartman > wrote: > > On Thu, Apr 20, 2017 at 04:12:55PM +0300, Gilad Ben-Yossef wrote: > >> +++ b/drivers/staging/ccree/bsp.h > >> @@ -0,0 +1,21 @@ > >> +/* > >> + * Copyright (C) 2012-2016 ARM Limited or its affiliates. > >> + * > >> + * This program is free software; you can redistribute it and/or modify it > >> + * under the terms of the GNU General Public License as published by the > >> Free > >> + * Software Foundation; either version 2 of the License, or (at your > >> option) > >> + * any later version. > > > > Oh, I have to ask, do you really mean "any later version" here and > > elsewhere? > > > > If so, then your MODULE_LICENSE() marking is wrong, please fix that up, > > or fix up the license text, I can't take incompatible ones without > > getting angry emails from legal people sent to me... > > > > Thanks for noticing this. > > The copyright + license notice is a boilerplate I got from the powers > that be here. > > I'll consult internally what is the proper action. I don't want to > make legal mad either... :-) Ok, I'll drop this patch series then, and wait for an updated one with this fixed up. thanks, greg k-h
Re: [PATCH v2 1/9] staging: ccree: introduce CryptoCell HW driver
On Thu, Apr 20, 2017 at 4:33 PM, Greg Kroah-Hartmanwrote: > On Thu, Apr 20, 2017 at 04:12:55PM +0300, Gilad Ben-Yossef wrote: >> +++ b/drivers/staging/ccree/bsp.h >> @@ -0,0 +1,21 @@ >> +/* >> + * Copyright (C) 2012-2016 ARM Limited or its affiliates. >> + * >> + * This program is free software; you can redistribute it and/or modify it >> + * under the terms of the GNU General Public License as published by the >> Free >> + * Software Foundation; either version 2 of the License, or (at your option) >> + * any later version. > > Oh, I have to ask, do you really mean "any later version" here and > elsewhere? > > If so, then your MODULE_LICENSE() marking is wrong, please fix that up, > or fix up the license text, I can't take incompatible ones without > getting angry emails from legal people sent to me... > Thanks for noticing this. The copyright + license notice is a boilerplate I got from the powers that be here. I'll consult internally what is the proper action. I don't want to make legal mad either... :-) Thanks again, Gilad -- Gilad Ben-Yossef Chief Coffee Drinker "If you take a class in large-scale robotics, can you end up in a situation where the homework eats your dog?" -- Jean-Baptiste Queru
Re: [PATCH v2 1/9] staging: ccree: introduce CryptoCell HW driver
On Thu, Apr 20, 2017 at 4:33 PM, Greg Kroah-Hartman wrote: > On Thu, Apr 20, 2017 at 04:12:55PM +0300, Gilad Ben-Yossef wrote: >> +++ b/drivers/staging/ccree/bsp.h >> @@ -0,0 +1,21 @@ >> +/* >> + * Copyright (C) 2012-2016 ARM Limited or its affiliates. >> + * >> + * This program is free software; you can redistribute it and/or modify it >> + * under the terms of the GNU General Public License as published by the >> Free >> + * Software Foundation; either version 2 of the License, or (at your option) >> + * any later version. > > Oh, I have to ask, do you really mean "any later version" here and > elsewhere? > > If so, then your MODULE_LICENSE() marking is wrong, please fix that up, > or fix up the license text, I can't take incompatible ones without > getting angry emails from legal people sent to me... > Thanks for noticing this. The copyright + license notice is a boilerplate I got from the powers that be here. I'll consult internally what is the proper action. I don't want to make legal mad either... :-) Thanks again, Gilad -- Gilad Ben-Yossef Chief Coffee Drinker "If you take a class in large-scale robotics, can you end up in a situation where the homework eats your dog?" -- Jean-Baptiste Queru
Re: [PATCH v2 1/9] staging: ccree: introduce CryptoCell HW driver
On Thu, Apr 20, 2017 at 04:12:55PM +0300, Gilad Ben-Yossef wrote: > +++ b/drivers/staging/ccree/bsp.h > @@ -0,0 +1,21 @@ > +/* > + * Copyright (C) 2012-2016 ARM Limited or its affiliates. > + * > + * This program is free software; you can redistribute it and/or modify it > + * under the terms of the GNU General Public License as published by the Free > + * Software Foundation; either version 2 of the License, or (at your option) > + * any later version. Oh, I have to ask, do you really mean "any later version" here and elsewhere? If so, then your MODULE_LICENSE() marking is wrong, please fix that up, or fix up the license text, I can't take incompatible ones without getting angry emails from legal people sent to me... thanks, greg k-h
Re: [PATCH v2 1/9] staging: ccree: introduce CryptoCell HW driver
On Thu, Apr 20, 2017 at 04:12:55PM +0300, Gilad Ben-Yossef wrote: > +++ b/drivers/staging/ccree/bsp.h > @@ -0,0 +1,21 @@ > +/* > + * Copyright (C) 2012-2016 ARM Limited or its affiliates. > + * > + * This program is free software; you can redistribute it and/or modify it > + * under the terms of the GNU General Public License as published by the Free > + * Software Foundation; either version 2 of the License, or (at your option) > + * any later version. Oh, I have to ask, do you really mean "any later version" here and elsewhere? If so, then your MODULE_LICENSE() marking is wrong, please fix that up, or fix up the license text, I can't take incompatible ones without getting angry emails from legal people sent to me... thanks, greg k-h