Re: [PATCH v2 5/5] kconfig: fix bug in search results string: use strlen(gstr->s), not gstr->len
On 2013/10/03 19:25, Martin Walch wrote: > From: Martin Walch > Date: Thu, 3 Oct 2013 18:35:16 +0200 > Subject: [PATCH v2 5/5] kconfig: fix bug in search results string: use > strlen(gstr->s), not gstr->len > Good catch, thank you. Acked-by: Benjamin Poirier -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 5/5] kconfig: fix bug in search results string: use strlen(gstr-s), not gstr-len
On 2013/10/03 19:25, Martin Walch wrote: From: Martin Walch walch.mar...@web.de Date: Thu, 3 Oct 2013 18:35:16 +0200 Subject: [PATCH v2 5/5] kconfig: fix bug in search results string: use strlen(gstr-s), not gstr-len Good catch, thank you. Acked-by: Benjamin Poirier bpoir...@suse.de -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 5/5] kconfig: fix bug in search results string: use strlen(gstr->s), not gstr->len
On Thu, Oct 03, 2013 at 07:25:53PM +0200, Martin Walch wrote: > From: Martin Walch > Date: Thu, 3 Oct 2013 18:35:16 +0200 > Subject: [PATCH v2 5/5] kconfig: fix bug in search results string: use > strlen(gstr->s), not gstr->len > > The struct gstr has a capacity that may differ from the actual string length. > > However, a string manipulation in the function search_conf made the assumption > that it is the same, which led to messing up some search results, especially > when the content of the gstr in use had not yet reached at least 63 chars. > > Signed-off-by: Martin Walch Acked-by: Wang YanQing Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 5/5] kconfig: fix bug in search results string: use strlen(gstr-s), not gstr-len
On Thu, Oct 03, 2013 at 07:25:53PM +0200, Martin Walch wrote: From: Martin Walch walch.mar...@web.de Date: Thu, 3 Oct 2013 18:35:16 +0200 Subject: [PATCH v2 5/5] kconfig: fix bug in search results string: use strlen(gstr-s), not gstr-len The struct gstr has a capacity that may differ from the actual string length. However, a string manipulation in the function search_conf made the assumption that it is the same, which led to messing up some search results, especially when the content of the gstr in use had not yet reached at least 63 chars. Signed-off-by: Martin Walch walch.mar...@web.de Acked-by: Wang YanQing udkni...@gmail.com Thanks. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2 5/5] kconfig: fix bug in search results string: use strlen(gstr->s), not gstr->len
From: Martin Walch
Date: Thu, 3 Oct 2013 18:35:16 +0200
Subject: [PATCH v2 5/5] kconfig: fix bug in search results string: use
strlen(gstr->s), not gstr->len
The struct gstr has a capacity that may differ from the actual string length.
However, a string manipulation in the function search_conf made the assumption
that it is the same, which led to messing up some search results, especially
when the content of the gstr in use had not yet reached at least 63 chars.
Signed-off-by: Martin Walch
---
scripts/kconfig/menu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
index 9e69f19..db1512a 100644
--- a/scripts/kconfig/menu.c
+++ b/scripts/kconfig/menu.c
@@ -584,7 +584,7 @@ static void get_prompt_str(struct gstr *r, struct property
*prop,
for (j = 4; --i >= 0; j += 2) {
menu = submenu[i];
if (head && location && menu == location)
- jump->offset = r->len - 1;
+ jump->offset = strlen(r->s);
str_printf(r, "%*c-> %s", j, ' ',
_(menu_get_prompt(menu)));
if (menu->sym) {
--
1.8.1.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2 5/5] kconfig: fix bug in search results string: use strlen(gstr-s), not gstr-len
From: Martin Walch walch.mar...@web.de
Date: Thu, 3 Oct 2013 18:35:16 +0200
Subject: [PATCH v2 5/5] kconfig: fix bug in search results string: use
strlen(gstr-s), not gstr-len
The struct gstr has a capacity that may differ from the actual string length.
However, a string manipulation in the function search_conf made the assumption
that it is the same, which led to messing up some search results, especially
when the content of the gstr in use had not yet reached at least 63 chars.
Signed-off-by: Martin Walch walch.mar...@web.de
---
scripts/kconfig/menu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
index 9e69f19..db1512a 100644
--- a/scripts/kconfig/menu.c
+++ b/scripts/kconfig/menu.c
@@ -584,7 +584,7 @@ static void get_prompt_str(struct gstr *r, struct property
*prop,
for (j = 4; --i = 0; j += 2) {
menu = submenu[i];
if (head location menu == location)
- jump-offset = r-len - 1;
+ jump-offset = strlen(r-s);
str_printf(r, %*c- %s, j, ' ',
_(menu_get_prompt(menu)));
if (menu-sym) {
--
1.8.1.5
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
