Re: [RESEND PATCH v4 1/4] mfd: syscon: Set name of regmap_config

[JeffyChen]

Hi Lee,

On 03/12/2018 05:12 PM, Lee Jones wrote:

On Fri, 09 Mar 2018, Jeffy Chen wrote:


>We are now allowing to register debugfs without a valid device, and not
>having a valid name will end up using "dummy*" to create debugfs dir.
>
>Signed-off-by: Jeffy Chen
>---
>
>Changes in v4: None
>Changes in v3:
>Modify commit message.
>
>  drivers/mfd/syscon.c | 1 +
>  1 file changed, 1 insertion(+)

Is this the RESEND I requested?  I can still only see this patch.

oops, sorry, i was using patman, and i force it to CC everyone in the 
cover letter's CC list, but that doesn't contain your mail address..i'll 
try another way :)

Re: [RESEND PATCH v4 1/4] mfd: syscon: Set name of regmap_config

[JeffyChen]

Hi Lee,

On 03/12/2018 05:12 PM, Lee Jones wrote:

On Fri, 09 Mar 2018, Jeffy Chen wrote:


>We are now allowing to register debugfs without a valid device, and not
>having a valid name will end up using "dummy*" to create debugfs dir.
>
>Signed-off-by: Jeffy Chen
>---
>
>Changes in v4: None
>Changes in v3:
>Modify commit message.
>
>  drivers/mfd/syscon.c | 1 +
>  1 file changed, 1 insertion(+)

Is this the RESEND I requested?  I can still only see this patch.

oops, sorry, i was using patman, and i force it to CC everyone in the 
cover letter's CC list, but that doesn't contain your mail address..i'll 
try another way :)

Re: [RESEND PATCH v4 1/4] mfd: syscon: Set name of regmap_config

[Lee Jones]

On Fri, 09 Mar 2018, Jeffy Chen wrote:

> We are now allowing to register debugfs without a valid device, and not
> having a valid name will end up using "dummy*" to create debugfs dir.
> 
> Signed-off-by: Jeffy Chen 
> ---
> 
> Changes in v4: None
> Changes in v3:
> Modify commit message.
> 
>  drivers/mfd/syscon.c | 1 +
>  1 file changed, 1 insertion(+)

Is this the RESEND I requested?  I can still only see this patch.

> diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c
> index fc9ba0ea4e44..b6d05cd934e6 100644
> --- a/drivers/mfd/syscon.c
> +++ b/drivers/mfd/syscon.c
> @@ -110,6 +110,7 @@ static struct syscon *of_syscon_register(struct 
> device_node *np)
>   syscon_config.reg_stride = reg_io_width;
>   syscon_config.val_bits = reg_io_width * 8;
>   syscon_config.max_register = resource_size() - reg_io_width;
> + syscon_config.name = of_node_full_name(np);
>  
>   regmap = regmap_init_mmio(NULL, base, _config);
>   if (IS_ERR(regmap)) {

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [RESEND PATCH v4 1/4] mfd: syscon: Set name of regmap_config

[Lee Jones]

On Fri, 09 Mar 2018, Jeffy Chen wrote:

> We are now allowing to register debugfs without a valid device, and not
> having a valid name will end up using "dummy*" to create debugfs dir.
> 
> Signed-off-by: Jeffy Chen 
> ---
> 
> Changes in v4: None
> Changes in v3:
> Modify commit message.
> 
>  drivers/mfd/syscon.c | 1 +
>  1 file changed, 1 insertion(+)

Is this the RESEND I requested?  I can still only see this patch.

> diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c
> index fc9ba0ea4e44..b6d05cd934e6 100644
> --- a/drivers/mfd/syscon.c
> +++ b/drivers/mfd/syscon.c
> @@ -110,6 +110,7 @@ static struct syscon *of_syscon_register(struct 
> device_node *np)
>   syscon_config.reg_stride = reg_io_width;
>   syscon_config.val_bits = reg_io_width * 8;
>   syscon_config.max_register = resource_size() - reg_io_width;
> + syscon_config.name = of_node_full_name(np);
>  
>   regmap = regmap_init_mmio(NULL, base, _config);
>   if (IS_ERR(regmap)) {

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[RESEND PATCH v4 1/4] mfd: syscon: Set name of regmap_config

[Jeffy Chen]

We are now allowing to register debugfs without a valid device, and not
having a valid name will end up using "dummy*" to create debugfs dir.

Signed-off-by: Jeffy Chen 
---

Changes in v4: None
Changes in v3:
Modify commit message.

 drivers/mfd/syscon.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c
index fc9ba0ea4e44..b6d05cd934e6 100644
--- a/drivers/mfd/syscon.c
+++ b/drivers/mfd/syscon.c
@@ -110,6 +110,7 @@ static struct syscon *of_syscon_register(struct device_node 
*np)
syscon_config.reg_stride = reg_io_width;
syscon_config.val_bits = reg_io_width * 8;
syscon_config.max_register = resource_size() - reg_io_width;
+   syscon_config.name = of_node_full_name(np);
 
regmap = regmap_init_mmio(NULL, base, _config);
if (IS_ERR(regmap)) {
-- 
2.11.0

[RESEND PATCH v4 1/4] mfd: syscon: Set name of regmap_config

[Jeffy Chen]

We are now allowing to register debugfs without a valid device, and not
having a valid name will end up using "dummy*" to create debugfs dir.

Signed-off-by: Jeffy Chen 
---

Changes in v4: None
Changes in v3:
Modify commit message.

 drivers/mfd/syscon.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c
index fc9ba0ea4e44..b6d05cd934e6 100644
--- a/drivers/mfd/syscon.c
+++ b/drivers/mfd/syscon.c
@@ -110,6 +110,7 @@ static struct syscon *of_syscon_register(struct device_node 
*np)
syscon_config.reg_stride = reg_io_width;
syscon_config.val_bits = reg_io_width * 8;
syscon_config.max_register = resource_size() - reg_io_width;
+   syscon_config.name = of_node_full_name(np);
 
regmap = regmap_init_mmio(NULL, base, _config);
if (IS_ERR(regmap)) {
-- 
2.11.0

Re: [PATCH v4 1/4] mfd: syscon: Set name of regmap_config

[Lee Jones]

On Fri, 09 Mar 2018, Jeffy Chen wrote:

> We are now allowing to register debugfs without a valid device, and not
> having a valid name will end up using "dummy*" to create debugfs dir.
> 
> Signed-off-by: Jeffy Chen 
> ---
> 
> Changes in v4: None
> Changes in v3:
> Modify commit message.
> 
>  drivers/mfd/syscon.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c
> index fc9ba0ea4e44..b6d05cd934e6 100644
> --- a/drivers/mfd/syscon.c
> +++ b/drivers/mfd/syscon.c
> @@ -110,6 +110,7 @@ static struct syscon *of_syscon_register(struct 
> device_node *np)
>   syscon_config.reg_stride = reg_io_width;
>   syscon_config.val_bits = reg_io_width * 8;
>   syscon_config.max_register = resource_size() - reg_io_width;
> + syscon_config.name = of_node_full_name(np);

It's difficult to review, since we cannot see what's happening with
the rest of the patch set.  Would you mind re-sending the whole set to
all parties please?

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v4 1/4] mfd: syscon: Set name of regmap_config

[Lee Jones]

On Fri, 09 Mar 2018, Jeffy Chen wrote:

> We are now allowing to register debugfs without a valid device, and not
> having a valid name will end up using "dummy*" to create debugfs dir.
> 
> Signed-off-by: Jeffy Chen 
> ---
> 
> Changes in v4: None
> Changes in v3:
> Modify commit message.
> 
>  drivers/mfd/syscon.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c
> index fc9ba0ea4e44..b6d05cd934e6 100644
> --- a/drivers/mfd/syscon.c
> +++ b/drivers/mfd/syscon.c
> @@ -110,6 +110,7 @@ static struct syscon *of_syscon_register(struct 
> device_node *np)
>   syscon_config.reg_stride = reg_io_width;
>   syscon_config.val_bits = reg_io_width * 8;
>   syscon_config.max_register = resource_size() - reg_io_width;
> + syscon_config.name = of_node_full_name(np);

It's difficult to review, since we cannot see what's happening with
the rest of the patch set.  Would you mind re-sending the whole set to
all parties please?

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[PATCH v4 1/4] mfd: syscon: Set name of regmap_config

[Jeffy Chen]

We are now allowing to register debugfs without a valid device, and not
having a valid name will end up using "dummy*" to create debugfs dir.

Signed-off-by: Jeffy Chen 
---

Changes in v4: None
Changes in v3:
Modify commit message.

 drivers/mfd/syscon.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c
index fc9ba0ea4e44..b6d05cd934e6 100644
--- a/drivers/mfd/syscon.c
+++ b/drivers/mfd/syscon.c
@@ -110,6 +110,7 @@ static struct syscon *of_syscon_register(struct device_node 
*np)
syscon_config.reg_stride = reg_io_width;
syscon_config.val_bits = reg_io_width * 8;
syscon_config.max_register = resource_size() - reg_io_width;
+   syscon_config.name = of_node_full_name(np);
 
regmap = regmap_init_mmio(NULL, base, _config);
if (IS_ERR(regmap)) {
-- 
2.11.0

[PATCH v4 1/4] mfd: syscon: Set name of regmap_config

[Jeffy Chen]

We are now allowing to register debugfs without a valid device, and not
having a valid name will end up using "dummy*" to create debugfs dir.

Signed-off-by: Jeffy Chen 
---

Changes in v4: None
Changes in v3:
Modify commit message.

 drivers/mfd/syscon.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c
index fc9ba0ea4e44..b6d05cd934e6 100644
--- a/drivers/mfd/syscon.c
+++ b/drivers/mfd/syscon.c
@@ -110,6 +110,7 @@ static struct syscon *of_syscon_register(struct device_node 
*np)
syscon_config.reg_stride = reg_io_width;
syscon_config.val_bits = reg_io_width * 8;
syscon_config.max_register = resource_size() - reg_io_width;
+   syscon_config.name = of_node_full_name(np);
 
regmap = regmap_init_mmio(NULL, base, _config);
if (IS_ERR(regmap)) {
-- 
2.11.0