Re: [PATCH v5 00/35] mtd: st_spi_fsm: Add new driver
On Tue, Feb 18, 2014 at 02:55:27PM +, Lee Jones wrote: > This should be the final version. :) I had a few more comments. Contrary to my comment on patch 1, I don't think too many of my comments were repeats. But nothing too big anyway. I expect that I'll merge this as soon as you address my last comments. Thanks for the patience. Brian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v5 00/35] mtd: st_spi_fsm: Add new driver
On Tue, Feb 18, 2014 at 02:55:27PM +, Lee Jones wrote: This should be the final version. :) I had a few more comments. Contrary to my comment on patch 1, I don't think too many of my comments were repeats. But nothing too big anyway. I expect that I'll merge this as soon as you address my last comments. Thanks for the patience. Brian -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v5 00/35] mtd: st_spi_fsm: Add new driver
This should be the final version. Version 5: Tended to Christophe, Ludovic and Angus' comments. Version 4: Tended to Brian's review comments - Checkpatch acceptance - MODULE_DEVICE_TABLE() name slip correction - Timeout issue(s) resolved - Potential infinite loop mitigated - Code clarity suggests heeded - Duplication with MTD core code removed - Upgraded to using ROUND_UP() helper - Moved non-shared header code into main driver - Relocated dynamic msg sequence stores into main struct - Averted adaption of static (table) data - Basic whitespace/spelling/data type/dev_err suggestions applied Version 3: Okay, this thing should be fully functional now. Identify a chip based on it's JEDEC ID, Read, Write, Erase (all or by sector). Support for various chip quirks added too. Version 2: The first bunch of these patches have been on the MLs before, but didn't receive a great deal of attention for the most part. We are a little more featureful this time however. We can now successfully setup and configure the N25Q256. We still can't read/write/erase it though. I'll start work on that next week and will provide it in the next instalment. Version 1: First stab at getting this thing Mainlined. It doesn't do a great deal yet, but we are able to initialise the device and dynamically set it up correctly based on an extracted JEDEC ID. Documentation/devicetree/bindings/mtd/st-fsm.txt | 26 ++ arch/arm/boot/dts/stih416-b2105.dts | 14 + arch/arm/boot/dts/stih416-pinctrl.dtsi | 12 + drivers/mtd/devices/Kconfig |8 + drivers/mtd/devices/Makefile |1 + drivers/mtd/devices/serial_flash_cmds.h | 81 + drivers/mtd/devices/st_spi_fsm.c | 2122 7 files changed, 2264 insertions(+) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v5 00/35] mtd: st_spi_fsm: Add new driver
This should be the final version. Version 5: Tended to Christophe, Ludovic and Angus' comments. Version 4: Tended to Brian's review comments - Checkpatch acceptance - MODULE_DEVICE_TABLE() name slip correction - Timeout issue(s) resolved - Potential infinite loop mitigated - Code clarity suggests heeded - Duplication with MTD core code removed - Upgraded to using ROUND_UP() helper - Moved non-shared header code into main driver - Relocated dynamic msg sequence stores into main struct - Averted adaption of static (table) data - Basic whitespace/spelling/data type/dev_err suggestions applied Version 3: Okay, this thing should be fully functional now. Identify a chip based on it's JEDEC ID, Read, Write, Erase (all or by sector). Support for various chip quirks added too. Version 2: The first bunch of these patches have been on the MLs before, but didn't receive a great deal of attention for the most part. We are a little more featureful this time however. We can now successfully setup and configure the N25Q256. We still can't read/write/erase it though. I'll start work on that next week and will provide it in the next instalment. Version 1: First stab at getting this thing Mainlined. It doesn't do a great deal yet, but we are able to initialise the device and dynamically set it up correctly based on an extracted JEDEC ID. Documentation/devicetree/bindings/mtd/st-fsm.txt | 26 ++ arch/arm/boot/dts/stih416-b2105.dts | 14 + arch/arm/boot/dts/stih416-pinctrl.dtsi | 12 + drivers/mtd/devices/Kconfig |8 + drivers/mtd/devices/Makefile |1 + drivers/mtd/devices/serial_flash_cmds.h | 81 + drivers/mtd/devices/st_spi_fsm.c | 2122 7 files changed, 2264 insertions(+) -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
