Re: [PATCH v6 1/2] dt-bindings: hwlock: add sun6i_hwspinlock
On Tue, 2 Mar 2021 18:22:33 +0100 Maxime Ripard wrote: > On Mon, Mar 01, 2021 at 03:06:35PM +0100, Wilken Gottwalt wrote: > > On Mon, 1 Mar 2021 14:12:44 +0100 > > Maxime Ripard wrote: > > > > > On Sat, Feb 27, 2021 at 02:03:28PM +0100, Wilken Gottwalt wrote: > > > > Adds documentation on how to use the sun6i_hwspinlock driver for sun6i > > > > compatible series SoCs. > > > > > > > > Signed-off-by: Wilken Gottwalt > > > > --- > > > > Changes in v6: > > > > - fixed formating and name issues in dt documentation > > > > > > > > Changes in v5: > > > > - changed binding to earliest known supported SoC sun6i-a31 > > > > - dropped unnecessary entries > > > > > > > > Changes in v4: > > > > - changed binding to sun8i-a33-hwpinlock > > > > - added changes suggested by Maxime Ripard > > > > > > > > Changes in v3: > > > > - changed symbols from sunxi to sun8i > > > > > > > > Changes in v2: > > > > - fixed memory ranges > > > > --- > > > > .../hwlock/allwinner,sun6i-hwspinlock.yaml| 45 +++ > > > > > > The name of the file doesn't match the compatible, once fixed: > > > Acked-by: Maxime Ripard > > > > This is something that still confuses me. What if you have more than one > > compatible string? > > In this case, it's fairly easy there's only one :) > > But we're following the same rule than the compatible: the first SoC > that got the compatible wins > > > This won't be solvable. See the qcom binding for example, > > there are two strings and none matches. In the omap bindings are also two > > strings and only one matches. In all cases, including mine, the bindings > > check script is fine with that. > > If other platforms want to follow other rules, good for them :) > > > So, you basically want it to be called > > "allwinner,sun6i-a31-hwspinlock.yaml"? > > Yes Is it okay if I provide only the fixed bindings? I assume the v6 driver is fine now. greetings, Will
Re: [PATCH v6 1/2] dt-bindings: hwlock: add sun6i_hwspinlock
On Mon, Mar 01, 2021 at 03:06:35PM +0100, Wilken Gottwalt wrote: > On Mon, 1 Mar 2021 14:12:44 +0100 > Maxime Ripard wrote: > > > On Sat, Feb 27, 2021 at 02:03:28PM +0100, Wilken Gottwalt wrote: > > > Adds documentation on how to use the sun6i_hwspinlock driver for sun6i > > > compatible series SoCs. > > > > > > Signed-off-by: Wilken Gottwalt > > > --- > > > Changes in v6: > > > - fixed formating and name issues in dt documentation > > > > > > Changes in v5: > > > - changed binding to earliest known supported SoC sun6i-a31 > > > - dropped unnecessary entries > > > > > > Changes in v4: > > > - changed binding to sun8i-a33-hwpinlock > > > - added changes suggested by Maxime Ripard > > > > > > Changes in v3: > > > - changed symbols from sunxi to sun8i > > > > > > Changes in v2: > > > - fixed memory ranges > > > --- > > > .../hwlock/allwinner,sun6i-hwspinlock.yaml| 45 +++ > > > > The name of the file doesn't match the compatible, once fixed: > > Acked-by: Maxime Ripard > > This is something that still confuses me. What if you have more than one > compatible string? In this case, it's fairly easy there's only one :) But we're following the same rule than the compatible: the first SoC that got the compatible wins > This won't be solvable. See the qcom binding for example, > there are two strings and none matches. In the omap bindings are also two > strings and only one matches. In all cases, including mine, the bindings > check script is fine with that. If other platforms want to follow other rules, good for them :) > So, you basically want it to be called > "allwinner,sun6i-a31-hwspinlock.yaml"? Yes Maxime signature.asc Description: PGP signature
Re: [PATCH v6 1/2] dt-bindings: hwlock: add sun6i_hwspinlock
On Mon, 1 Mar 2021 14:12:44 +0100 Maxime Ripard wrote: > On Sat, Feb 27, 2021 at 02:03:28PM +0100, Wilken Gottwalt wrote: > > Adds documentation on how to use the sun6i_hwspinlock driver for sun6i > > compatible series SoCs. > > > > Signed-off-by: Wilken Gottwalt > > --- > > Changes in v6: > > - fixed formating and name issues in dt documentation > > > > Changes in v5: > > - changed binding to earliest known supported SoC sun6i-a31 > > - dropped unnecessary entries > > > > Changes in v4: > > - changed binding to sun8i-a33-hwpinlock > > - added changes suggested by Maxime Ripard > > > > Changes in v3: > > - changed symbols from sunxi to sun8i > > > > Changes in v2: > > - fixed memory ranges > > --- > > .../hwlock/allwinner,sun6i-hwspinlock.yaml| 45 +++ > > The name of the file doesn't match the compatible, once fixed: > Acked-by: Maxime Ripard This is something that still confuses me. What if you have more than one compatible string? This won't be solvable. See the qcom binding for example, there are two strings and none matches. In the omap bindings are also two strings and only one matches. In all cases, including mine, the bindings check script is fine with that. So, you basically want it to be called "allwinner,sun6i-a31-hwspinlock.yaml"? Sorry if I come up with this, but I don't want to just do it, I want to understand it. > Maxime
Re: [PATCH v6 1/2] dt-bindings: hwlock: add sun6i_hwspinlock
On Sat, Feb 27, 2021 at 02:03:28PM +0100, Wilken Gottwalt wrote: > Adds documentation on how to use the sun6i_hwspinlock driver for sun6i > compatible series SoCs. > > Signed-off-by: Wilken Gottwalt > --- > Changes in v6: > - fixed formating and name issues in dt documentation > > Changes in v5: > - changed binding to earliest known supported SoC sun6i-a31 > - dropped unnecessary entries > > Changes in v4: > - changed binding to sun8i-a33-hwpinlock > - added changes suggested by Maxime Ripard > > Changes in v3: > - changed symbols from sunxi to sun8i > > Changes in v2: > - fixed memory ranges > --- > .../hwlock/allwinner,sun6i-hwspinlock.yaml| 45 +++ The name of the file doesn't match the compatible, once fixed: Acked-by: Maxime Ripard Maxime
[PATCH v6 1/2] dt-bindings: hwlock: add sun6i_hwspinlock
Adds documentation on how to use the sun6i_hwspinlock driver for sun6i
compatible series SoCs.
Signed-off-by: Wilken Gottwalt
---
Changes in v6:
- fixed formating and name issues in dt documentation
Changes in v5:
- changed binding to earliest known supported SoC sun6i-a31
- dropped unnecessary entries
Changes in v4:
- changed binding to sun8i-a33-hwpinlock
- added changes suggested by Maxime Ripard
Changes in v3:
- changed symbols from sunxi to sun8i
Changes in v2:
- fixed memory ranges
---
.../hwlock/allwinner,sun6i-hwspinlock.yaml| 45 +++
1 file changed, 45 insertions(+)
create mode 100644
Documentation/devicetree/bindings/hwlock/allwinner,sun6i-hwspinlock.yaml
diff --git
a/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-hwspinlock.yaml
b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-hwspinlock.yaml
new file mode 100644
index ..733c3d01e56c
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-hwspinlock.yaml
@@ -0,0 +1,45 @@
+# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/hwlock/allwinner,sun6i-hwspinlock.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: SUN6I hardware spinlock driver for Allwinner sun6i compatible SoCs
+
+maintainers:
+ - Wilken Gottwalt
+
+description:
+ The hardware unit provides semaphores between the ARM cores and the embedded
+ companion core on the SoC.
+
+properties:
+ compatible:
+const: allwinner,sun6i-a31-hwspinlock
+
+ reg:
+maxItems: 1
+
+ clocks:
+maxItems: 1
+
+ resets:
+maxItems: 1
+
+required:
+ - compatible
+ - reg
+ - clocks
+ - resets
+
+additionalProperties: false
+
+examples:
+ - |
+hwlock@1c18000 {
+compatible = "allwinner,sun6i-a31-hwspinlock";
+reg = <0x01c18000 0x1000>;
+clocks = < CLK_BUS_SPINLOCK>;
+resets = < RST_BUS_SPINLOCK>;
+};
+...
--
2.30.1
