Re: [PATCH v8 02/11] dt-bindings: power: supply: add DT bindings for max77650
On Tue, Apr 9, 2019 at 10:38 AM Bartosz Golaszewski wrote: > > wt., 9 kwi 2019 o 13:04 Bartosz Golaszewski napisał(a): > > > > wt., 9 kwi 2019 o 03:10 Rob Herring napisał(a): > > > > > > On Mon, Apr 8, 2019 at 7:25 AM Bartosz Golaszewski wrote: > > > > > > > > sob., 6 kwi 2019 o 09:07 Rob Herring napisał(a): > > > > > > > > > > On Wed, Apr 03, 2019 at 11:00:59AM +0200, Bartosz Golaszewski wrote: > > > > > > From: Bartosz Golaszewski > > > > > > > > > > > > Add the DT binding document for the battery charger module of > > > > > > max77650. > > > > > > > > > > > > Signed-off-by: Bartosz Golaszewski > > > > > > --- > > > > > > .../power/supply/max77650-charger.txt | 27 > > > > > > +++ > > > > > > 1 file changed, 27 insertions(+) > > > > > > create mode 100644 > > > > > > Documentation/devicetree/bindings/power/supply/max77650-charger.txt > > > > > > > > > > > > diff --git > > > > > > a/Documentation/devicetree/bindings/power/supply/max77650-charger.txt > > > > > > > > > > > > b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt > > > > > > new file mode 100644 > > > > > > index ..fef188144386 > > > > > > --- /dev/null > > > > > > +++ > > > > > > b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt > > > > > > @@ -0,0 +1,27 @@ > > > > > > +Battery charger driver for MAX77650 PMIC from Maxim Integrated. > > > > > > + > > > > > > +This module is part of the MAX77650 MFD device. For more details > > > > > > +see Documentation/devicetree/bindings/mfd/max77650.txt. > > > > > > + > > > > > > +The charger is represented as a sub-node of the PMIC node on the > > > > > > device tree. > > > > > > + > > > > > > +Required properties: > > > > > > + > > > > > > +- compatible:Must be "maxim,max77650-charger" > > > > > > + > > > > > > +Optional properties: > > > > > > + > > > > > > +- min-microvolt: Minimum CHGIN regulation voltage (in > > > > > > microvolts). Must be > > > > > > + one of: 400, 410, 420, 430, > > > > > > 440, > > > > > > + 450, 460, 470. > > > > > > +- current-limit-microamp:CHGIN input current limit (in > > > > > > microamps). Must > > > > > > + be one of: 95000, 19, 285000, > > > > > > 38, 475000. > > > > > > > > > > To repeat what I said on v6, these should be common properties IMO > > > > > (and > > > > > therefore documented as such). > > > > > > > > > > > > > Do you mean a separate "charger.txt" document in > > > > Documentation/devicetree/bindings/power/supply/? > > > > > > Yes, though I thought we had something already. > > > > > > Rob > > > > We don't AFAICT. There's only a binding document for "simple-battery" > > in power supply. > > > > Bart > > Can we have it locally for now but without the maxim prefix and then > reuse it if any other charger needs such functionality? To make it > even more generic we can name it: "input-voltage-min-microvolt" & > "input-current-limit-microamp". I guess. And defining these as 'input' is good because we do have similar property names already for battery current limit and voltages. Rob
Re: [PATCH v8 02/11] dt-bindings: power: supply: add DT bindings for max77650
wt., 9 kwi 2019 o 13:04 Bartosz Golaszewski napisał(a): > > wt., 9 kwi 2019 o 03:10 Rob Herring napisał(a): > > > > On Mon, Apr 8, 2019 at 7:25 AM Bartosz Golaszewski wrote: > > > > > > sob., 6 kwi 2019 o 09:07 Rob Herring napisał(a): > > > > > > > > On Wed, Apr 03, 2019 at 11:00:59AM +0200, Bartosz Golaszewski wrote: > > > > > From: Bartosz Golaszewski > > > > > > > > > > Add the DT binding document for the battery charger module of > > > > > max77650. > > > > > > > > > > Signed-off-by: Bartosz Golaszewski > > > > > --- > > > > > .../power/supply/max77650-charger.txt | 27 > > > > > +++ > > > > > 1 file changed, 27 insertions(+) > > > > > create mode 100644 > > > > > Documentation/devicetree/bindings/power/supply/max77650-charger.txt > > > > > > > > > > diff --git > > > > > a/Documentation/devicetree/bindings/power/supply/max77650-charger.txt > > > > > b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt > > > > > new file mode 100644 > > > > > index ..fef188144386 > > > > > --- /dev/null > > > > > +++ > > > > > b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt > > > > > @@ -0,0 +1,27 @@ > > > > > +Battery charger driver for MAX77650 PMIC from Maxim Integrated. > > > > > + > > > > > +This module is part of the MAX77650 MFD device. For more details > > > > > +see Documentation/devicetree/bindings/mfd/max77650.txt. > > > > > + > > > > > +The charger is represented as a sub-node of the PMIC node on the > > > > > device tree. > > > > > + > > > > > +Required properties: > > > > > + > > > > > +- compatible:Must be "maxim,max77650-charger" > > > > > + > > > > > +Optional properties: > > > > > + > > > > > +- min-microvolt: Minimum CHGIN regulation voltage (in > > > > > microvolts). Must be > > > > > + one of: 400, 410, 420, 430, > > > > > 440, > > > > > + 450, 460, 470. > > > > > +- current-limit-microamp:CHGIN input current limit (in > > > > > microamps). Must > > > > > + be one of: 95000, 19, 285000, > > > > > 38, 475000. > > > > > > > > To repeat what I said on v6, these should be common properties IMO (and > > > > therefore documented as such). > > > > > > > > > > Do you mean a separate "charger.txt" document in > > > Documentation/devicetree/bindings/power/supply/? > > > > Yes, though I thought we had something already. > > > > Rob > > We don't AFAICT. There's only a binding document for "simple-battery" > in power supply. > > Bart Can we have it locally for now but without the maxim prefix and then reuse it if any other charger needs such functionality? To make it even more generic we can name it: "input-voltage-min-microvolt" & "input-current-limit-microamp". Bart
Re: [PATCH v8 02/11] dt-bindings: power: supply: add DT bindings for max77650
wt., 9 kwi 2019 o 03:10 Rob Herring napisał(a): > > On Mon, Apr 8, 2019 at 7:25 AM Bartosz Golaszewski wrote: > > > > sob., 6 kwi 2019 o 09:07 Rob Herring napisał(a): > > > > > > On Wed, Apr 03, 2019 at 11:00:59AM +0200, Bartosz Golaszewski wrote: > > > > From: Bartosz Golaszewski > > > > > > > > Add the DT binding document for the battery charger module of max77650. > > > > > > > > Signed-off-by: Bartosz Golaszewski > > > > --- > > > > .../power/supply/max77650-charger.txt | 27 +++ > > > > 1 file changed, 27 insertions(+) > > > > create mode 100644 > > > > Documentation/devicetree/bindings/power/supply/max77650-charger.txt > > > > > > > > diff --git > > > > a/Documentation/devicetree/bindings/power/supply/max77650-charger.txt > > > > b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt > > > > new file mode 100644 > > > > index ..fef188144386 > > > > --- /dev/null > > > > +++ > > > > b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt > > > > @@ -0,0 +1,27 @@ > > > > +Battery charger driver for MAX77650 PMIC from Maxim Integrated. > > > > + > > > > +This module is part of the MAX77650 MFD device. For more details > > > > +see Documentation/devicetree/bindings/mfd/max77650.txt. > > > > + > > > > +The charger is represented as a sub-node of the PMIC node on the > > > > device tree. > > > > + > > > > +Required properties: > > > > + > > > > +- compatible:Must be "maxim,max77650-charger" > > > > + > > > > +Optional properties: > > > > + > > > > +- min-microvolt: Minimum CHGIN regulation voltage (in microvolts). > > > > Must be > > > > + one of: 400, 410, 420, 430, > > > > 440, > > > > + 450, 460, 470. > > > > +- current-limit-microamp:CHGIN input current limit (in microamps). > > > > Must > > > > + be one of: 95000, 19, 285000, 38, > > > > 475000. > > > > > > To repeat what I said on v6, these should be common properties IMO (and > > > therefore documented as such). > > > > > > > Do you mean a separate "charger.txt" document in > > Documentation/devicetree/bindings/power/supply/? > > Yes, though I thought we had something already. > > Rob We don't AFAICT. There's only a binding document for "simple-battery" in power supply. Bart
Re: [PATCH v8 02/11] dt-bindings: power: supply: add DT bindings for max77650
On Mon, Apr 8, 2019 at 7:25 AM Bartosz Golaszewski wrote: > > sob., 6 kwi 2019 o 09:07 Rob Herring napisał(a): > > > > On Wed, Apr 03, 2019 at 11:00:59AM +0200, Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski > > > > > > Add the DT binding document for the battery charger module of max77650. > > > > > > Signed-off-by: Bartosz Golaszewski > > > --- > > > .../power/supply/max77650-charger.txt | 27 +++ > > > 1 file changed, 27 insertions(+) > > > create mode 100644 > > > Documentation/devicetree/bindings/power/supply/max77650-charger.txt > > > > > > diff --git > > > a/Documentation/devicetree/bindings/power/supply/max77650-charger.txt > > > b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt > > > new file mode 100644 > > > index ..fef188144386 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt > > > @@ -0,0 +1,27 @@ > > > +Battery charger driver for MAX77650 PMIC from Maxim Integrated. > > > + > > > +This module is part of the MAX77650 MFD device. For more details > > > +see Documentation/devicetree/bindings/mfd/max77650.txt. > > > + > > > +The charger is represented as a sub-node of the PMIC node on the device > > > tree. > > > + > > > +Required properties: > > > + > > > +- compatible:Must be "maxim,max77650-charger" > > > + > > > +Optional properties: > > > + > > > +- min-microvolt: Minimum CHGIN regulation voltage (in microvolts). > > > Must be > > > + one of: 400, 410, 420, 430, 440, > > > + 450, 460, 470. > > > +- current-limit-microamp:CHGIN input current limit (in microamps). > > > Must > > > + be one of: 95000, 19, 285000, 38, > > > 475000. > > > > To repeat what I said on v6, these should be common properties IMO (and > > therefore documented as such). > > > > Do you mean a separate "charger.txt" document in > Documentation/devicetree/bindings/power/supply/? Yes, though I thought we had something already. Rob
Re: [PATCH v8 02/11] dt-bindings: power: supply: add DT bindings for max77650
sob., 6 kwi 2019 o 09:07 Rob Herring napisał(a):
>
> On Wed, Apr 03, 2019 at 11:00:59AM +0200, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski
> >
> > Add the DT binding document for the battery charger module of max77650.
> >
> > Signed-off-by: Bartosz Golaszewski
> > ---
> > .../power/supply/max77650-charger.txt | 27 +++
> > 1 file changed, 27 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/power/supply/max77650-charger.txt
> >
> > diff --git
> > a/Documentation/devicetree/bindings/power/supply/max77650-charger.txt
> > b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt
> > new file mode 100644
> > index ..fef188144386
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt
> > @@ -0,0 +1,27 @@
> > +Battery charger driver for MAX77650 PMIC from Maxim Integrated.
> > +
> > +This module is part of the MAX77650 MFD device. For more details
> > +see Documentation/devicetree/bindings/mfd/max77650.txt.
> > +
> > +The charger is represented as a sub-node of the PMIC node on the device
> > tree.
> > +
> > +Required properties:
> > +
> > +- compatible:Must be "maxim,max77650-charger"
> > +
> > +Optional properties:
> > +
> > +- min-microvolt: Minimum CHGIN regulation voltage (in microvolts).
> > Must be
> > + one of: 400, 410, 420, 430, 440,
> > + 450, 460, 470.
> > +- current-limit-microamp:CHGIN input current limit (in microamps). Must
> > + be one of: 95000, 19, 285000, 38,
> > 475000.
>
> To repeat what I said on v6, these should be common properties IMO (and
> therefore documented as such).
>
Do you mean a separate "charger.txt" document in
Documentation/devicetree/bindings/power/supply/?
Bart
> > +
> > +Example:
> > +
> > +
> > + charger {
> > + compatible = "maxim,max77650-charger";
> > + min-microvolt = <420>;
> > + curr-lim-microamp = <285000>;
> > + };
> > --
> > 2.21.0
> >
Re: [PATCH v8 02/11] dt-bindings: power: supply: add DT bindings for max77650
On Wed, Apr 03, 2019 at 11:00:59AM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski
>
> Add the DT binding document for the battery charger module of max77650.
>
> Signed-off-by: Bartosz Golaszewski
> ---
> .../power/supply/max77650-charger.txt | 27 +++
> 1 file changed, 27 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/power/supply/max77650-charger.txt
>
> diff --git
> a/Documentation/devicetree/bindings/power/supply/max77650-charger.txt
> b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt
> new file mode 100644
> index ..fef188144386
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt
> @@ -0,0 +1,27 @@
> +Battery charger driver for MAX77650 PMIC from Maxim Integrated.
> +
> +This module is part of the MAX77650 MFD device. For more details
> +see Documentation/devicetree/bindings/mfd/max77650.txt.
> +
> +The charger is represented as a sub-node of the PMIC node on the device tree.
> +
> +Required properties:
> +
> +- compatible:Must be "maxim,max77650-charger"
> +
> +Optional properties:
> +
> +- min-microvolt: Minimum CHGIN regulation voltage (in microvolts). Must
> be
> + one of: 400, 410, 420, 430, 440,
> + 450, 460, 470.
> +- current-limit-microamp:CHGIN input current limit (in microamps). Must
> + be one of: 95000, 19, 285000, 38,
> 475000.
To repeat what I said on v6, these should be common properties IMO (and
therefore documented as such).
> +
> +Example:
> +
> +
> + charger {
> + compatible = "maxim,max77650-charger";
> + min-microvolt = <420>;
> + curr-lim-microamp = <285000>;
> + };
> --
> 2.21.0
>
[PATCH v8 02/11] dt-bindings: power: supply: add DT bindings for max77650
From: Bartosz Golaszewski
Add the DT binding document for the battery charger module of max77650.
Signed-off-by: Bartosz Golaszewski
---
.../power/supply/max77650-charger.txt | 27 +++
1 file changed, 27 insertions(+)
create mode 100644
Documentation/devicetree/bindings/power/supply/max77650-charger.txt
diff --git
a/Documentation/devicetree/bindings/power/supply/max77650-charger.txt
b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt
new file mode 100644
index ..fef188144386
--- /dev/null
+++ b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt
@@ -0,0 +1,27 @@
+Battery charger driver for MAX77650 PMIC from Maxim Integrated.
+
+This module is part of the MAX77650 MFD device. For more details
+see Documentation/devicetree/bindings/mfd/max77650.txt.
+
+The charger is represented as a sub-node of the PMIC node on the device tree.
+
+Required properties:
+
+- compatible: Must be "maxim,max77650-charger"
+
+Optional properties:
+
+- min-microvolt: Minimum CHGIN regulation voltage (in microvolts). Must
be
+ one of: 400, 410, 420, 430, 440,
+ 450, 460, 470.
+- current-limit-microamp: CHGIN input current limit (in microamps). Must
+ be one of: 95000, 19, 285000, 38,
475000.
+
+Example:
+
+
+ charger {
+ compatible = "maxim,max77650-charger";
+ min-microvolt = <420>;
+ curr-lim-microamp = <285000>;
+ };
--
2.21.0
