Re: [PATCHSET 0/5] perf tools: Speed up dwarf callchain post-unwinding for libunwind (v4)

2014-10-23 Thread Namhyung Kim
On Fri, Oct 24, 2014 at 10:56 AM, Arnaldo Carvalho de Melo
 wrote:
> Em Fri, Oct 24, 2014 at 09:44:17AM +0900, Namhyung Kim escreveu:
>> On Thu, 23 Oct 2014 20:35:42 -0300, Arnaldo Carvalho de Melo wrote:
>> > I'll push later and will drop you a note, so that you can, please, check
>> > if the end result is sane.
>>
>> Thank you!
>
> It should be on my perf/core branch by now.

Looks ok to me.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCHSET 0/5] perf tools: Speed up dwarf callchain post-unwinding for libunwind (v4)

2014-10-23 Thread Arnaldo Carvalho de Melo
Em Fri, Oct 24, 2014 at 09:44:17AM +0900, Namhyung Kim escreveu:
> On Thu, 23 Oct 2014 20:35:42 -0300, Arnaldo Carvalho de Melo wrote:
> > I'll push later and will drop you a note, so that you can, please, check
> > if the end result is sane.
> 
> Thank you!

It should be on my perf/core branch by now.
 
> > Sorry for the slip up,
> 
> No problem. :)

:-)

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCHSET 0/5] perf tools: Speed up dwarf callchain post-unwinding for libunwind (v4)

2014-10-23 Thread Namhyung Kim
On Thu, 23 Oct 2014 20:35:42 -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Oct 22, 2014 at 10:34:27AM +0900, Namhyung Kim escreveu:
>> Hi Arnaldo,
>> 
>> On Wed, 15 Oct 2014 17:06:30 -0300, Arnaldo Carvalho de Melo wrote:
>> > Next time please run: (I'm fixing this up this time)
>> >
>> > [acme@zoo linux]$ time make -C tools/perf build-test
>> ...
>> > In file included from util/machine.c:14:0:
>> > util/unwind.h: In function ‘unwind__prepare_access’:
>> > util/unwind.h:47:57: error: unused parameter ‘thread’
>> > [-Werror=unused-parameter]
>> >  static inline int unwind__prepare_access(struct thread *thread)
>> >  ^
>> > util/unwind.h: In function ‘unwind__finish_access’:
>> > util/unwind.h:52:57: error: unused parameter ‘thread’
>> > [-Werror=unused-parameter]
>> >  static inline void unwind__finish_access(struct thread *thread) {}
>> >  ^
>> > cc1: all warnings being treated as errors
>> > make[3]: *** [util/machine.o] Error 1
>> > make[3]: *** Waiting for unfinished jobs
>> > make[2]: *** [all] Error 2
>> >   test: test -x ./perf
>> > make[1]: *** [make_no_libelf] Error 1
>> > make: *** [build-test] Error 2
>> > make: Leaving directory `/home/git/linux/tools/perf'
>> 
>> So it seems you didn't include the patch 3/5 which is the key of this
>> series..  Could you please check it again?
>
> Yeah, I'm adding it now, and in this case as well the __maybe_unused was
> missing, added.

It was my bad to miss the annotation, sorry.


>
> I'll push later and will drop you a note, so that you can, please, check
> if the end result is sane.

Thank you!

> Sorry for the slip up,

No problem. :)

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCHSET 0/5] perf tools: Speed up dwarf callchain post-unwinding for libunwind (v4)

2014-10-23 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 22, 2014 at 10:34:27AM +0900, Namhyung Kim escreveu:
> Hi Arnaldo,
> 
> On Wed, 15 Oct 2014 17:06:30 -0300, Arnaldo Carvalho de Melo wrote:
> > Next time please run: (I'm fixing this up this time)
> >
> > [acme@zoo linux]$ time make -C tools/perf build-test
> ...
> > In file included from util/machine.c:14:0:
> > util/unwind.h: In function ‘unwind__prepare_access’:
> > util/unwind.h:47:57: error: unused parameter ‘thread’
> > [-Werror=unused-parameter]
> >  static inline int unwind__prepare_access(struct thread *thread)
> >  ^
> > util/unwind.h: In function ‘unwind__finish_access’:
> > util/unwind.h:52:57: error: unused parameter ‘thread’
> > [-Werror=unused-parameter]
> >  static inline void unwind__finish_access(struct thread *thread) {}
> >  ^
> > cc1: all warnings being treated as errors
> > make[3]: *** [util/machine.o] Error 1
> > make[3]: *** Waiting for unfinished jobs
> > make[2]: *** [all] Error 2
> >   test: test -x ./perf
> > make[1]: *** [make_no_libelf] Error 1
> > make: *** [build-test] Error 2
> > make: Leaving directory `/home/git/linux/tools/perf'
> 
> So it seems you didn't include the patch 3/5 which is the key of this
> series..  Could you please check it again?

Yeah, I'm adding it now, and in this case as well the __maybe_unused was
missing, added.

I'll push later and will drop you a note, so that you can, please, check
if the end result is sane.

Sorry for the slip up,

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCHSET 0/5] perf tools: Speed up dwarf callchain post-unwinding for libunwind (v4)

2014-10-23 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 22, 2014 at 10:34:27AM +0900, Namhyung Kim escreveu:
 Hi Arnaldo,
 
 On Wed, 15 Oct 2014 17:06:30 -0300, Arnaldo Carvalho de Melo wrote:
  Next time please run: (I'm fixing this up this time)
 
  [acme@zoo linux]$ time make -C tools/perf build-test
 ...
  In file included from util/machine.c:14:0:
  util/unwind.h: In function ‘unwind__prepare_access’:
  util/unwind.h:47:57: error: unused parameter ‘thread’
  [-Werror=unused-parameter]
   static inline int unwind__prepare_access(struct thread *thread)
   ^
  util/unwind.h: In function ‘unwind__finish_access’:
  util/unwind.h:52:57: error: unused parameter ‘thread’
  [-Werror=unused-parameter]
   static inline void unwind__finish_access(struct thread *thread) {}
   ^
  cc1: all warnings being treated as errors
  make[3]: *** [util/machine.o] Error 1
  make[3]: *** Waiting for unfinished jobs
  make[2]: *** [all] Error 2
test: test -x ./perf
  make[1]: *** [make_no_libelf] Error 1
  make: *** [build-test] Error 2
  make: Leaving directory `/home/git/linux/tools/perf'
 
 So it seems you didn't include the patch 3/5 which is the key of this
 series..  Could you please check it again?

Yeah, I'm adding it now, and in this case as well the __maybe_unused was
missing, added.

I'll push later and will drop you a note, so that you can, please, check
if the end result is sane.

Sorry for the slip up,

- Arnaldo
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCHSET 0/5] perf tools: Speed up dwarf callchain post-unwinding for libunwind (v4)

2014-10-23 Thread Namhyung Kim
On Thu, 23 Oct 2014 20:35:42 -0300, Arnaldo Carvalho de Melo wrote:
 Em Wed, Oct 22, 2014 at 10:34:27AM +0900, Namhyung Kim escreveu:
 Hi Arnaldo,
 
 On Wed, 15 Oct 2014 17:06:30 -0300, Arnaldo Carvalho de Melo wrote:
  Next time please run: (I'm fixing this up this time)
 
  [acme@zoo linux]$ time make -C tools/perf build-test
 ...
  In file included from util/machine.c:14:0:
  util/unwind.h: In function ‘unwind__prepare_access’:
  util/unwind.h:47:57: error: unused parameter ‘thread’
  [-Werror=unused-parameter]
   static inline int unwind__prepare_access(struct thread *thread)
   ^
  util/unwind.h: In function ‘unwind__finish_access’:
  util/unwind.h:52:57: error: unused parameter ‘thread’
  [-Werror=unused-parameter]
   static inline void unwind__finish_access(struct thread *thread) {}
   ^
  cc1: all warnings being treated as errors
  make[3]: *** [util/machine.o] Error 1
  make[3]: *** Waiting for unfinished jobs
  make[2]: *** [all] Error 2
test: test -x ./perf
  make[1]: *** [make_no_libelf] Error 1
  make: *** [build-test] Error 2
  make: Leaving directory `/home/git/linux/tools/perf'
 
 So it seems you didn't include the patch 3/5 which is the key of this
 series..  Could you please check it again?

 Yeah, I'm adding it now, and in this case as well the __maybe_unused was
 missing, added.

It was my bad to miss the annotation, sorry.



 I'll push later and will drop you a note, so that you can, please, check
 if the end result is sane.

Thank you!

 Sorry for the slip up,

No problem. :)

Thanks,
Namhyung
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCHSET 0/5] perf tools: Speed up dwarf callchain post-unwinding for libunwind (v4)

2014-10-23 Thread Arnaldo Carvalho de Melo
Em Fri, Oct 24, 2014 at 09:44:17AM +0900, Namhyung Kim escreveu:
 On Thu, 23 Oct 2014 20:35:42 -0300, Arnaldo Carvalho de Melo wrote:
  I'll push later and will drop you a note, so that you can, please, check
  if the end result is sane.
 
 Thank you!

It should be on my perf/core branch by now.
 
  Sorry for the slip up,
 
 No problem. :)

:-)

- Arnaldo
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCHSET 0/5] perf tools: Speed up dwarf callchain post-unwinding for libunwind (v4)

2014-10-23 Thread Namhyung Kim
On Fri, Oct 24, 2014 at 10:56 AM, Arnaldo Carvalho de Melo
a...@kernel.org wrote:
 Em Fri, Oct 24, 2014 at 09:44:17AM +0900, Namhyung Kim escreveu:
 On Thu, 23 Oct 2014 20:35:42 -0300, Arnaldo Carvalho de Melo wrote:
  I'll push later and will drop you a note, so that you can, please, check
  if the end result is sane.

 Thank you!

 It should be on my perf/core branch by now.

Looks ok to me.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCHSET 0/5] perf tools: Speed up dwarf callchain post-unwinding for libunwind (v4)

2014-10-21 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 22, 2014 at 10:34:27AM +0900, Namhyung Kim escreveu:
> Hi Arnaldo,
> 
> On Wed, 15 Oct 2014 17:06:30 -0300, Arnaldo Carvalho de Melo wrote:
> > Next time please run: (I'm fixing this up this time)
> >
> > [acme@zoo linux]$ time make -C tools/perf build-test
> ...
> > In file included from util/machine.c:14:0:
> > util/unwind.h: In function ‘unwind__prepare_access’:
> > util/unwind.h:47:57: error: unused parameter ‘thread’
> > [-Werror=unused-parameter]
> >  static inline int unwind__prepare_access(struct thread *thread)
> >  ^
> > util/unwind.h: In function ‘unwind__finish_access’:
> > util/unwind.h:52:57: error: unused parameter ‘thread’
> > [-Werror=unused-parameter]
> >  static inline void unwind__finish_access(struct thread *thread) {}
> >  ^
> > cc1: all warnings being treated as errors
> > make[3]: *** [util/machine.o] Error 1
> > make[3]: *** Waiting for unfinished jobs
> > make[2]: *** [all] Error 2
> >   test: test -x ./perf
> > make[1]: *** [make_no_libelf] Error 1
> > make: *** [build-test] Error 2
> > make: Leaving directory `/home/git/linux/tools/perf'
> 
> So it seems you didn't include the patch 3/5 which is the key of this
> series..  Could you please check it again?

I'll check it tomorrow.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCHSET 0/5] perf tools: Speed up dwarf callchain post-unwinding for libunwind (v4)

2014-10-21 Thread Namhyung Kim
Hi Arnaldo,

On Wed, 15 Oct 2014 17:06:30 -0300, Arnaldo Carvalho de Melo wrote:
> Next time please run: (I'm fixing this up this time)
>
> [acme@zoo linux]$ time make -C tools/perf build-test
...
> In file included from util/machine.c:14:0:
> util/unwind.h: In function ‘unwind__prepare_access’:
> util/unwind.h:47:57: error: unused parameter ‘thread’
> [-Werror=unused-parameter]
>  static inline int unwind__prepare_access(struct thread *thread)
>  ^
> util/unwind.h: In function ‘unwind__finish_access’:
> util/unwind.h:52:57: error: unused parameter ‘thread’
> [-Werror=unused-parameter]
>  static inline void unwind__finish_access(struct thread *thread) {}
>  ^
> cc1: all warnings being treated as errors
> make[3]: *** [util/machine.o] Error 1
> make[3]: *** Waiting for unfinished jobs
> make[2]: *** [all] Error 2
>   test: test -x ./perf
> make[1]: *** [make_no_libelf] Error 1
> make: *** [build-test] Error 2
> make: Leaving directory `/home/git/linux/tools/perf'

So it seems you didn't include the patch 3/5 which is the key of this
series..  Could you please check it again?

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCHSET 0/5] perf tools: Speed up dwarf callchain post-unwinding for libunwind (v4)

2014-10-21 Thread Namhyung Kim
Hi Arnaldo,

On Wed, 15 Oct 2014 17:06:30 -0300, Arnaldo Carvalho de Melo wrote:
 Next time please run: (I'm fixing this up this time)

 [acme@zoo linux]$ time make -C tools/perf build-test
...
 In file included from util/machine.c:14:0:
 util/unwind.h: In function ‘unwind__prepare_access’:
 util/unwind.h:47:57: error: unused parameter ‘thread’
 [-Werror=unused-parameter]
  static inline int unwind__prepare_access(struct thread *thread)
  ^
 util/unwind.h: In function ‘unwind__finish_access’:
 util/unwind.h:52:57: error: unused parameter ‘thread’
 [-Werror=unused-parameter]
  static inline void unwind__finish_access(struct thread *thread) {}
  ^
 cc1: all warnings being treated as errors
 make[3]: *** [util/machine.o] Error 1
 make[3]: *** Waiting for unfinished jobs
 make[2]: *** [all] Error 2
   test: test -x ./perf
 make[1]: *** [make_no_libelf] Error 1
 make: *** [build-test] Error 2
 make: Leaving directory `/home/git/linux/tools/perf'

So it seems you didn't include the patch 3/5 which is the key of this
series..  Could you please check it again?

Thanks,
Namhyung
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCHSET 0/5] perf tools: Speed up dwarf callchain post-unwinding for libunwind (v4)

2014-10-21 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 22, 2014 at 10:34:27AM +0900, Namhyung Kim escreveu:
 Hi Arnaldo,
 
 On Wed, 15 Oct 2014 17:06:30 -0300, Arnaldo Carvalho de Melo wrote:
  Next time please run: (I'm fixing this up this time)
 
  [acme@zoo linux]$ time make -C tools/perf build-test
 ...
  In file included from util/machine.c:14:0:
  util/unwind.h: In function ‘unwind__prepare_access’:
  util/unwind.h:47:57: error: unused parameter ‘thread’
  [-Werror=unused-parameter]
   static inline int unwind__prepare_access(struct thread *thread)
   ^
  util/unwind.h: In function ‘unwind__finish_access’:
  util/unwind.h:52:57: error: unused parameter ‘thread’
  [-Werror=unused-parameter]
   static inline void unwind__finish_access(struct thread *thread) {}
   ^
  cc1: all warnings being treated as errors
  make[3]: *** [util/machine.o] Error 1
  make[3]: *** Waiting for unfinished jobs
  make[2]: *** [all] Error 2
test: test -x ./perf
  make[1]: *** [make_no_libelf] Error 1
  make: *** [build-test] Error 2
  make: Leaving directory `/home/git/linux/tools/perf'
 
 So it seems you didn't include the patch 3/5 which is the key of this
 series..  Could you please check it again?

I'll check it tomorrow.

- Arnaldo
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCHSET 0/5] perf tools: Speed up dwarf callchain post-unwinding for libunwind (v4)

2014-10-16 Thread Namhyung Kim
Hi Arnaldo,

On Thu, Oct 16, 2014 at 5:06 AM, Arnaldo Carvalho de Melo
 wrote:
> Em Wed, Oct 15, 2014 at 04:24:41PM -0300, Arnaldo Carvalho de Melo escreveu:
>> Em Mon, Oct 13, 2014 at 08:11:58PM +0200, Jiri Olsa escreveu:
>> > On Mon, Oct 06, 2014 at 09:45:58AM +0900, Namhyung Kim wrote:
>> > > Hello,
>> > >
>> > > This is v4 for libunwind callchain post processing speed up.  It was
>> > > able to reduce 50% of processing time by using global cache provided
>> > > in libunwind.  In this version, I decided to use the existing
>> > > callchain_param.record_mode instead of adding a new field in the
>> > > symbol_conf.
>> > >
>> > > The patch 4 and 5 are just cleanups so that we can easily find out
>> > > that which part of code uses the thread->priv.
>> > >
>> > > You can also get it from 'perf/callchain-unwind-v4' branch on my tree:
>> > >
>> > >   git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
>> > >
>> > > Thanks,
>> > > Namhyung
>> > >
>> > >
>> > > Namhyung Kim (5):
>> > >   perf report: Set callchain_param.record_mode for future use
>> > >   perf callchain: Create an address space per thread
>> > >   perf callchain: Use global caching provided by libunwind
>> > >   perf kvm: Use thread_{,_set}_priv helpers
>> > >   perf trace: Use thread_{,_set}_priv helpers
>> >
>> > Acked-by: Jiri Olsa 
>>
>> Thanks, applied.
>
> Next time please run: (I'm fixing this up this time)

Sorry about that.  I'll check it next time.

Thanks,
Namhyung


>
> [acme@zoo linux]$ time make -C tools/perf build-test
> make: Entering directory `/home/git/linux/tools/perf'
> - make_pure: cd . && make -f Makefile DESTDIR=/tmp/tmp.RXWD6DlpLb
> - make_clean_all: cd . && make -f Makefile DESTDIR=/tmp/tmp.Xb83Au0dtp
>   clean all
> - make_python_perf_so: cd . && make -f Makefile
>   DESTDIR=/tmp/tmp.JjiHtvNXGP python/perf.so
> - make_debug: cd . && make -f Makefile DESTDIR=/tmp/tmp.4mbBkoB1Jz
>   DEBUG=1
> - make_no_libperl: cd . && make -f Makefile DESTDIR=/tmp/tmp.2I0aglyOsB
>   NO_LIBPERL=1
> - make_no_libpython: cd . && make -f Makefile
>   DESTDIR=/tmp/tmp.NDG6pNk8J0 NO_LIBPYTHON=1
> - make_no_scripts: cd . && make -f Makefile DESTDIR=/tmp/tmp.00jcSmJ2uP
>   NO_LIBPYTHON=1 NO_LIBPERL=1
> - make_no_newt: cd . && make -f Makefile DESTDIR=/tmp/tmp.rpiHSaU8sm
>   NO_NEWT=1
> - make_no_slang: cd . && make -f Makefile DESTDIR=/tmp/tmp.eq62JNazPt
>   NO_SLANG=1
> - make_no_gtk2: cd . && make -f Makefile DESTDIR=/tmp/tmp.D3uwXogwqj
>   NO_GTK2=1
> - make_no_ui: cd . && make -f Makefile DESTDIR=/tmp/tmp.0Dw4cAw1RZ
>   NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
> - make_no_demangle: cd . && make -f Makefile DESTDIR=/tmp/tmp.6kFBIeDeSB
>   NO_DEMANGLE=1
> - make_no_libelf: cd . && make -f Makefile DESTDIR=/tmp/tmp.KTyAsiNqK5
>   NO_LIBELF=1
> cd . && make -f Makefile DESTDIR=/tmp/tmp.KTyAsiNqK5 NO_LIBELF=1
>   BUILD:   Doing 'make -j4' parallel build
> config/Makefile:396: Disabling post unwind, no support found.
>
> Auto-detecting system features:
> ... dwarf: [ on  ]
> ... glibc: [ on  ]
> ...  gtk2: [ on  ]
> ...  libaudit: [ on  ]
> ...libbfd: [ on  ]
> ...libelf: [ on  ]
> ...   libnuma: [ on  ]
> ...   libperl: [ on  ]
> ... libpython: [ on  ]
> ...  libslang: [ on  ]
> ... libunwind: [ on  ]
> ...libdw-dwarf-unwind: [ on  ]
>
>   GEN  common-cmds.h
>   BISONutil/pmu-bison.c
>   FLAGS:   * new build flags or prefix
>   BISONutil/parse-events-bison.c
>   CC   util/path.o
>   CC   util/rbtree.o
>   CC   util/bitmap.o
>   CC   util/hweight.o
>   CC   util/run-command.o
>   CC   util/quote.o
>   CC   util/strbuf.o
>   CC   util/strlist.o
>   CC   util/string.o
>   CC   util/strfilter.o
>   CC   util/top.o
>   CC   util/usage.o
>   CC   util/wrapper.o
>   CC   util/sigchain.o
>   CC   util/dso.o
>   CC   util/symbol.o
>   CC   util/color.o
>   CC   util/pager.o
>   CC   util/header.o
>   CC   util/callchain.o
>   CC   util/values.o
>   CC   util/debug.o
>   CC   util/machine.o
>   PERF_VERSION = 3.17.ga3a146
>   CC   util/map.o
> In file included from util/machine.c:14:0:
> util/unwind.h: In function ‘unwind__prepare_access’:
> util/unwind.h:47:57: error: unused parameter ‘thread’
> [-Werror=unused-parameter]
>  static inline int unwind__prepare_access(struct thread *thread)
>  ^
> util/unwind.h: In function ‘unwind__finish_access’:
> util/unwind.h:52:57: error: unused parameter ‘thread’
> [-Werror=unused-parameter]
>  static inline void unwind__finish_access(struct thread *thread) {}
>  ^
> cc1: all warnings being treated as errors
> make[3]: *** [util/machine.o] 

Re: [PATCHSET 0/5] perf tools: Speed up dwarf callchain post-unwinding for libunwind (v4)

2014-10-16 Thread Namhyung Kim
Hi Arnaldo,

On Thu, Oct 16, 2014 at 5:06 AM, Arnaldo Carvalho de Melo
a...@kernel.org wrote:
 Em Wed, Oct 15, 2014 at 04:24:41PM -0300, Arnaldo Carvalho de Melo escreveu:
 Em Mon, Oct 13, 2014 at 08:11:58PM +0200, Jiri Olsa escreveu:
  On Mon, Oct 06, 2014 at 09:45:58AM +0900, Namhyung Kim wrote:
   Hello,
  
   This is v4 for libunwind callchain post processing speed up.  It was
   able to reduce 50% of processing time by using global cache provided
   in libunwind.  In this version, I decided to use the existing
   callchain_param.record_mode instead of adding a new field in the
   symbol_conf.
  
   The patch 4 and 5 are just cleanups so that we can easily find out
   that which part of code uses the thread-priv.
  
   You can also get it from 'perf/callchain-unwind-v4' branch on my tree:
  
 git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
  
   Thanks,
   Namhyung
  
  
   Namhyung Kim (5):
 perf report: Set callchain_param.record_mode for future use
 perf callchain: Create an address space per thread
 perf callchain: Use global caching provided by libunwind
 perf kvm: Use thread_{,_set}_priv helpers
 perf trace: Use thread_{,_set}_priv helpers
 
  Acked-by: Jiri Olsa jo...@kernel.org

 Thanks, applied.

 Next time please run: (I'm fixing this up this time)

Sorry about that.  I'll check it next time.

Thanks,
Namhyung



 [acme@zoo linux]$ time make -C tools/perf build-test
 make: Entering directory `/home/git/linux/tools/perf'
 - make_pure: cd .  make -f Makefile DESTDIR=/tmp/tmp.RXWD6DlpLb
 - make_clean_all: cd .  make -f Makefile DESTDIR=/tmp/tmp.Xb83Au0dtp
   clean all
 - make_python_perf_so: cd .  make -f Makefile
   DESTDIR=/tmp/tmp.JjiHtvNXGP python/perf.so
 - make_debug: cd .  make -f Makefile DESTDIR=/tmp/tmp.4mbBkoB1Jz
   DEBUG=1
 - make_no_libperl: cd .  make -f Makefile DESTDIR=/tmp/tmp.2I0aglyOsB
   NO_LIBPERL=1
 - make_no_libpython: cd .  make -f Makefile
   DESTDIR=/tmp/tmp.NDG6pNk8J0 NO_LIBPYTHON=1
 - make_no_scripts: cd .  make -f Makefile DESTDIR=/tmp/tmp.00jcSmJ2uP
   NO_LIBPYTHON=1 NO_LIBPERL=1
 - make_no_newt: cd .  make -f Makefile DESTDIR=/tmp/tmp.rpiHSaU8sm
   NO_NEWT=1
 - make_no_slang: cd .  make -f Makefile DESTDIR=/tmp/tmp.eq62JNazPt
   NO_SLANG=1
 - make_no_gtk2: cd .  make -f Makefile DESTDIR=/tmp/tmp.D3uwXogwqj
   NO_GTK2=1
 - make_no_ui: cd .  make -f Makefile DESTDIR=/tmp/tmp.0Dw4cAw1RZ
   NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
 - make_no_demangle: cd .  make -f Makefile DESTDIR=/tmp/tmp.6kFBIeDeSB
   NO_DEMANGLE=1
 - make_no_libelf: cd .  make -f Makefile DESTDIR=/tmp/tmp.KTyAsiNqK5
   NO_LIBELF=1
 cd .  make -f Makefile DESTDIR=/tmp/tmp.KTyAsiNqK5 NO_LIBELF=1
   BUILD:   Doing 'make -j4' parallel build
 config/Makefile:396: Disabling post unwind, no support found.

 Auto-detecting system features:
 ... dwarf: [ on  ]
 ... glibc: [ on  ]
 ...  gtk2: [ on  ]
 ...  libaudit: [ on  ]
 ...libbfd: [ on  ]
 ...libelf: [ on  ]
 ...   libnuma: [ on  ]
 ...   libperl: [ on  ]
 ... libpython: [ on  ]
 ...  libslang: [ on  ]
 ... libunwind: [ on  ]
 ...libdw-dwarf-unwind: [ on  ]

   GEN  common-cmds.h
   BISONutil/pmu-bison.c
   FLAGS:   * new build flags or prefix
   BISONutil/parse-events-bison.c
   CC   util/path.o
   CC   util/rbtree.o
   CC   util/bitmap.o
   CC   util/hweight.o
   CC   util/run-command.o
   CC   util/quote.o
   CC   util/strbuf.o
   CC   util/strlist.o
   CC   util/string.o
   CC   util/strfilter.o
   CC   util/top.o
   CC   util/usage.o
   CC   util/wrapper.o
   CC   util/sigchain.o
   CC   util/dso.o
   CC   util/symbol.o
   CC   util/color.o
   CC   util/pager.o
   CC   util/header.o
   CC   util/callchain.o
   CC   util/values.o
   CC   util/debug.o
   CC   util/machine.o
   PERF_VERSION = 3.17.ga3a146
   CC   util/map.o
 In file included from util/machine.c:14:0:
 util/unwind.h: In function ‘unwind__prepare_access’:
 util/unwind.h:47:57: error: unused parameter ‘thread’
 [-Werror=unused-parameter]
  static inline int unwind__prepare_access(struct thread *thread)
  ^
 util/unwind.h: In function ‘unwind__finish_access’:
 util/unwind.h:52:57: error: unused parameter ‘thread’
 [-Werror=unused-parameter]
  static inline void unwind__finish_access(struct thread *thread) {}
  ^
 cc1: all warnings being treated as errors
 make[3]: *** [util/machine.o] Error 1
 make[3]: *** Waiting for unfinished jobs
 make[2]: *** [all] Error 2
   test: test -x ./perf
 make[1]: *** [make_no_libelf] Error 1
 make: *** [build-test] Error 2
 make: Leaving directory 

Re: [PATCHSET 0/5] perf tools: Speed up dwarf callchain post-unwinding for libunwind (v4)

2014-10-15 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 15, 2014 at 04:24:41PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Mon, Oct 13, 2014 at 08:11:58PM +0200, Jiri Olsa escreveu:
> > On Mon, Oct 06, 2014 at 09:45:58AM +0900, Namhyung Kim wrote:
> > > Hello,
> > > 
> > > This is v4 for libunwind callchain post processing speed up.  It was
> > > able to reduce 50% of processing time by using global cache provided
> > > in libunwind.  In this version, I decided to use the existing
> > > callchain_param.record_mode instead of adding a new field in the
> > > symbol_conf.
> > > 
> > > The patch 4 and 5 are just cleanups so that we can easily find out
> > > that which part of code uses the thread->priv.
> > > 
> > > You can also get it from 'perf/callchain-unwind-v4' branch on my tree:
> > > 
> > >   git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
> > > 
> > > Thanks,
> > > Namhyung
> > > 
> > > 
> > > Namhyung Kim (5):
> > >   perf report: Set callchain_param.record_mode for future use
> > >   perf callchain: Create an address space per thread
> > >   perf callchain: Use global caching provided by libunwind
> > >   perf kvm: Use thread_{,_set}_priv helpers
> > >   perf trace: Use thread_{,_set}_priv helpers
> > 
> > Acked-by: Jiri Olsa 
> 
> Thanks, applied.

Next time please run: (I'm fixing this up this time)

[acme@zoo linux]$ time make -C tools/perf build-test
make: Entering directory `/home/git/linux/tools/perf'
- make_pure: cd . && make -f Makefile DESTDIR=/tmp/tmp.RXWD6DlpLb 
- make_clean_all: cd . && make -f Makefile DESTDIR=/tmp/tmp.Xb83Au0dtp
  clean all
- make_python_perf_so: cd . && make -f Makefile
  DESTDIR=/tmp/tmp.JjiHtvNXGP python/perf.so
- make_debug: cd . && make -f Makefile DESTDIR=/tmp/tmp.4mbBkoB1Jz
  DEBUG=1
- make_no_libperl: cd . && make -f Makefile DESTDIR=/tmp/tmp.2I0aglyOsB
  NO_LIBPERL=1
- make_no_libpython: cd . && make -f Makefile
  DESTDIR=/tmp/tmp.NDG6pNk8J0 NO_LIBPYTHON=1
- make_no_scripts: cd . && make -f Makefile DESTDIR=/tmp/tmp.00jcSmJ2uP
  NO_LIBPYTHON=1 NO_LIBPERL=1
- make_no_newt: cd . && make -f Makefile DESTDIR=/tmp/tmp.rpiHSaU8sm
  NO_NEWT=1
- make_no_slang: cd . && make -f Makefile DESTDIR=/tmp/tmp.eq62JNazPt
  NO_SLANG=1
- make_no_gtk2: cd . && make -f Makefile DESTDIR=/tmp/tmp.D3uwXogwqj
  NO_GTK2=1
- make_no_ui: cd . && make -f Makefile DESTDIR=/tmp/tmp.0Dw4cAw1RZ
  NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
- make_no_demangle: cd . && make -f Makefile DESTDIR=/tmp/tmp.6kFBIeDeSB
  NO_DEMANGLE=1
- make_no_libelf: cd . && make -f Makefile DESTDIR=/tmp/tmp.KTyAsiNqK5
  NO_LIBELF=1
cd . && make -f Makefile DESTDIR=/tmp/tmp.KTyAsiNqK5 NO_LIBELF=1
  BUILD:   Doing 'make -j4' parallel build
config/Makefile:396: Disabling post unwind, no support found.

Auto-detecting system features:
... dwarf: [ on  ]
... glibc: [ on  ]
...  gtk2: [ on  ]
...  libaudit: [ on  ]
...libbfd: [ on  ]
...libelf: [ on  ]
...   libnuma: [ on  ]
...   libperl: [ on  ]
... libpython: [ on  ]
...  libslang: [ on  ]
... libunwind: [ on  ]
...libdw-dwarf-unwind: [ on  ]

  GEN  common-cmds.h
  BISONutil/pmu-bison.c
  FLAGS:   * new build flags or prefix
  BISONutil/parse-events-bison.c
  CC   util/path.o
  CC   util/rbtree.o
  CC   util/bitmap.o
  CC   util/hweight.o
  CC   util/run-command.o
  CC   util/quote.o
  CC   util/strbuf.o
  CC   util/strlist.o
  CC   util/string.o
  CC   util/strfilter.o
  CC   util/top.o
  CC   util/usage.o
  CC   util/wrapper.o
  CC   util/sigchain.o
  CC   util/dso.o
  CC   util/symbol.o
  CC   util/color.o
  CC   util/pager.o
  CC   util/header.o
  CC   util/callchain.o
  CC   util/values.o
  CC   util/debug.o
  CC   util/machine.o
  PERF_VERSION = 3.17.ga3a146
  CC   util/map.o
In file included from util/machine.c:14:0:
util/unwind.h: In function ‘unwind__prepare_access’:
util/unwind.h:47:57: error: unused parameter ‘thread’
[-Werror=unused-parameter]
 static inline int unwind__prepare_access(struct thread *thread)
 ^
util/unwind.h: In function ‘unwind__finish_access’:
util/unwind.h:52:57: error: unused parameter ‘thread’
[-Werror=unused-parameter]
 static inline void unwind__finish_access(struct thread *thread) {}
 ^
cc1: all warnings being treated as errors
make[3]: *** [util/machine.o] Error 1
make[3]: *** Waiting for unfinished jobs
make[2]: *** [all] Error 2
  test: test -x ./perf
make[1]: *** [make_no_libelf] Error 1
make: *** [build-test] Error 2
make: Leaving directory `/home/git/linux/tools/perf'

real4m40.869s
user8m57.124s
sys 1m12.853s
[acme@zoo linux]$ 

--
To unsubscribe from this list: send the line 

Re: [PATCHSET 0/5] perf tools: Speed up dwarf callchain post-unwinding for libunwind (v4)

2014-10-15 Thread Arnaldo Carvalho de Melo
Em Mon, Oct 13, 2014 at 08:11:58PM +0200, Jiri Olsa escreveu:
> On Mon, Oct 06, 2014 at 09:45:58AM +0900, Namhyung Kim wrote:
> > Hello,
> > 
> > This is v4 for libunwind callchain post processing speed up.  It was
> > able to reduce 50% of processing time by using global cache provided
> > in libunwind.  In this version, I decided to use the existing
> > callchain_param.record_mode instead of adding a new field in the
> > symbol_conf.
> > 
> > The patch 4 and 5 are just cleanups so that we can easily find out
> > that which part of code uses the thread->priv.
> > 
> > You can also get it from 'perf/callchain-unwind-v4' branch on my tree:
> > 
> >   git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
> > 
> > Thanks,
> > Namhyung
> > 
> > 
> > Namhyung Kim (5):
> >   perf report: Set callchain_param.record_mode for future use
> >   perf callchain: Create an address space per thread
> >   perf callchain: Use global caching provided by libunwind
> >   perf kvm: Use thread_{,_set}_priv helpers
> >   perf trace: Use thread_{,_set}_priv helpers
> 
> Acked-by: Jiri Olsa 

Thanks, applied.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCHSET 0/5] perf tools: Speed up dwarf callchain post-unwinding for libunwind (v4)

2014-10-15 Thread Arnaldo Carvalho de Melo
Em Mon, Oct 13, 2014 at 08:11:58PM +0200, Jiri Olsa escreveu:
 On Mon, Oct 06, 2014 at 09:45:58AM +0900, Namhyung Kim wrote:
  Hello,
  
  This is v4 for libunwind callchain post processing speed up.  It was
  able to reduce 50% of processing time by using global cache provided
  in libunwind.  In this version, I decided to use the existing
  callchain_param.record_mode instead of adding a new field in the
  symbol_conf.
  
  The patch 4 and 5 are just cleanups so that we can easily find out
  that which part of code uses the thread-priv.
  
  You can also get it from 'perf/callchain-unwind-v4' branch on my tree:
  
git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
  
  Thanks,
  Namhyung
  
  
  Namhyung Kim (5):
perf report: Set callchain_param.record_mode for future use
perf callchain: Create an address space per thread
perf callchain: Use global caching provided by libunwind
perf kvm: Use thread_{,_set}_priv helpers
perf trace: Use thread_{,_set}_priv helpers
 
 Acked-by: Jiri Olsa jo...@kernel.org

Thanks, applied.

- Arnaldo
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCHSET 0/5] perf tools: Speed up dwarf callchain post-unwinding for libunwind (v4)

2014-10-15 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 15, 2014 at 04:24:41PM -0300, Arnaldo Carvalho de Melo escreveu:
 Em Mon, Oct 13, 2014 at 08:11:58PM +0200, Jiri Olsa escreveu:
  On Mon, Oct 06, 2014 at 09:45:58AM +0900, Namhyung Kim wrote:
   Hello,
   
   This is v4 for libunwind callchain post processing speed up.  It was
   able to reduce 50% of processing time by using global cache provided
   in libunwind.  In this version, I decided to use the existing
   callchain_param.record_mode instead of adding a new field in the
   symbol_conf.
   
   The patch 4 and 5 are just cleanups so that we can easily find out
   that which part of code uses the thread-priv.
   
   You can also get it from 'perf/callchain-unwind-v4' branch on my tree:
   
 git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
   
   Thanks,
   Namhyung
   
   
   Namhyung Kim (5):
 perf report: Set callchain_param.record_mode for future use
 perf callchain: Create an address space per thread
 perf callchain: Use global caching provided by libunwind
 perf kvm: Use thread_{,_set}_priv helpers
 perf trace: Use thread_{,_set}_priv helpers
  
  Acked-by: Jiri Olsa jo...@kernel.org
 
 Thanks, applied.

Next time please run: (I'm fixing this up this time)

[acme@zoo linux]$ time make -C tools/perf build-test
make: Entering directory `/home/git/linux/tools/perf'
- make_pure: cd .  make -f Makefile DESTDIR=/tmp/tmp.RXWD6DlpLb 
- make_clean_all: cd .  make -f Makefile DESTDIR=/tmp/tmp.Xb83Au0dtp
  clean all
- make_python_perf_so: cd .  make -f Makefile
  DESTDIR=/tmp/tmp.JjiHtvNXGP python/perf.so
- make_debug: cd .  make -f Makefile DESTDIR=/tmp/tmp.4mbBkoB1Jz
  DEBUG=1
- make_no_libperl: cd .  make -f Makefile DESTDIR=/tmp/tmp.2I0aglyOsB
  NO_LIBPERL=1
- make_no_libpython: cd .  make -f Makefile
  DESTDIR=/tmp/tmp.NDG6pNk8J0 NO_LIBPYTHON=1
- make_no_scripts: cd .  make -f Makefile DESTDIR=/tmp/tmp.00jcSmJ2uP
  NO_LIBPYTHON=1 NO_LIBPERL=1
- make_no_newt: cd .  make -f Makefile DESTDIR=/tmp/tmp.rpiHSaU8sm
  NO_NEWT=1
- make_no_slang: cd .  make -f Makefile DESTDIR=/tmp/tmp.eq62JNazPt
  NO_SLANG=1
- make_no_gtk2: cd .  make -f Makefile DESTDIR=/tmp/tmp.D3uwXogwqj
  NO_GTK2=1
- make_no_ui: cd .  make -f Makefile DESTDIR=/tmp/tmp.0Dw4cAw1RZ
  NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
- make_no_demangle: cd .  make -f Makefile DESTDIR=/tmp/tmp.6kFBIeDeSB
  NO_DEMANGLE=1
- make_no_libelf: cd .  make -f Makefile DESTDIR=/tmp/tmp.KTyAsiNqK5
  NO_LIBELF=1
cd .  make -f Makefile DESTDIR=/tmp/tmp.KTyAsiNqK5 NO_LIBELF=1
  BUILD:   Doing 'make -j4' parallel build
config/Makefile:396: Disabling post unwind, no support found.

Auto-detecting system features:
... dwarf: [ on  ]
... glibc: [ on  ]
...  gtk2: [ on  ]
...  libaudit: [ on  ]
...libbfd: [ on  ]
...libelf: [ on  ]
...   libnuma: [ on  ]
...   libperl: [ on  ]
... libpython: [ on  ]
...  libslang: [ on  ]
... libunwind: [ on  ]
...libdw-dwarf-unwind: [ on  ]

  GEN  common-cmds.h
  BISONutil/pmu-bison.c
  FLAGS:   * new build flags or prefix
  BISONutil/parse-events-bison.c
  CC   util/path.o
  CC   util/rbtree.o
  CC   util/bitmap.o
  CC   util/hweight.o
  CC   util/run-command.o
  CC   util/quote.o
  CC   util/strbuf.o
  CC   util/strlist.o
  CC   util/string.o
  CC   util/strfilter.o
  CC   util/top.o
  CC   util/usage.o
  CC   util/wrapper.o
  CC   util/sigchain.o
  CC   util/dso.o
  CC   util/symbol.o
  CC   util/color.o
  CC   util/pager.o
  CC   util/header.o
  CC   util/callchain.o
  CC   util/values.o
  CC   util/debug.o
  CC   util/machine.o
  PERF_VERSION = 3.17.ga3a146
  CC   util/map.o
In file included from util/machine.c:14:0:
util/unwind.h: In function ‘unwind__prepare_access’:
util/unwind.h:47:57: error: unused parameter ‘thread’
[-Werror=unused-parameter]
 static inline int unwind__prepare_access(struct thread *thread)
 ^
util/unwind.h: In function ‘unwind__finish_access’:
util/unwind.h:52:57: error: unused parameter ‘thread’
[-Werror=unused-parameter]
 static inline void unwind__finish_access(struct thread *thread) {}
 ^
cc1: all warnings being treated as errors
make[3]: *** [util/machine.o] Error 1
make[3]: *** Waiting for unfinished jobs
make[2]: *** [all] Error 2
  test: test -x ./perf
make[1]: *** [make_no_libelf] Error 1
make: *** [build-test] Error 2
make: Leaving directory `/home/git/linux/tools/perf'

real4m40.869s
user8m57.124s
sys 1m12.853s
[acme@zoo linux]$ 

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo 

Re: [PATCHSET 0/5] perf tools: Speed up dwarf callchain post-unwinding for libunwind (v4)

2014-10-14 Thread Arnaldo Carvalho de Melo
Em Mon, Oct 13, 2014 at 08:11:58PM +0200, Jiri Olsa escreveu:
> On Mon, Oct 06, 2014 at 09:45:58AM +0900, Namhyung Kim wrote:
> > Namhyung Kim (5):
> >   perf report: Set callchain_param.record_mode for future use
> >   perf callchain: Create an address space per thread
> >   perf callchain: Use global caching provided by libunwind
> >   perf kvm: Use thread_{,_set}_priv helpers
> >   perf trace: Use thread_{,_set}_priv helpers
> 
> Acked-by: Jiri Olsa 

Ok, will merge/test/put it in my next patchkit,

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCHSET 0/5] perf tools: Speed up dwarf callchain post-unwinding for libunwind (v4)

2014-10-14 Thread Arnaldo Carvalho de Melo
Em Mon, Oct 13, 2014 at 08:11:58PM +0200, Jiri Olsa escreveu:
 On Mon, Oct 06, 2014 at 09:45:58AM +0900, Namhyung Kim wrote:
  Namhyung Kim (5):
perf report: Set callchain_param.record_mode for future use
perf callchain: Create an address space per thread
perf callchain: Use global caching provided by libunwind
perf kvm: Use thread_{,_set}_priv helpers
perf trace: Use thread_{,_set}_priv helpers
 
 Acked-by: Jiri Olsa jo...@kernel.org

Ok, will merge/test/put it in my next patchkit,

- Arnaldo
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCHSET 0/5] perf tools: Speed up dwarf callchain post-unwinding for libunwind (v4)

2014-10-13 Thread Jiri Olsa
On Mon, Oct 06, 2014 at 09:45:58AM +0900, Namhyung Kim wrote:
> Hello,
> 
> This is v4 for libunwind callchain post processing speed up.  It was
> able to reduce 50% of processing time by using global cache provided
> in libunwind.  In this version, I decided to use the existing
> callchain_param.record_mode instead of adding a new field in the
> symbol_conf.
> 
> The patch 4 and 5 are just cleanups so that we can easily find out
> that which part of code uses the thread->priv.
> 
> You can also get it from 'perf/callchain-unwind-v4' branch on my tree:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
> 
> Thanks,
> Namhyung
> 
> 
> Namhyung Kim (5):
>   perf report: Set callchain_param.record_mode for future use
>   perf callchain: Create an address space per thread
>   perf callchain: Use global caching provided by libunwind
>   perf kvm: Use thread_{,_set}_priv helpers
>   perf trace: Use thread_{,_set}_priv helpers

Acked-by: Jiri Olsa 

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCHSET 0/5] perf tools: Speed up dwarf callchain post-unwinding for libunwind (v4)

2014-10-13 Thread Jiri Olsa
On Mon, Oct 06, 2014 at 09:45:58AM +0900, Namhyung Kim wrote:
 Hello,
 
 This is v4 for libunwind callchain post processing speed up.  It was
 able to reduce 50% of processing time by using global cache provided
 in libunwind.  In this version, I decided to use the existing
 callchain_param.record_mode instead of adding a new field in the
 symbol_conf.
 
 The patch 4 and 5 are just cleanups so that we can easily find out
 that which part of code uses the thread-priv.
 
 You can also get it from 'perf/callchain-unwind-v4' branch on my tree:
 
   git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
 
 Thanks,
 Namhyung
 
 
 Namhyung Kim (5):
   perf report: Set callchain_param.record_mode for future use
   perf callchain: Create an address space per thread
   perf callchain: Use global caching provided by libunwind
   perf kvm: Use thread_{,_set}_priv helpers
   perf trace: Use thread_{,_set}_priv helpers

Acked-by: Jiri Olsa jo...@kernel.org

thanks,
jirka
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCHSET 0/5] perf tools: Speed up dwarf callchain post-unwinding for libunwind (v4)

2014-10-05 Thread Namhyung Kim
Hello,

This is v4 for libunwind callchain post processing speed up.  It was
able to reduce 50% of processing time by using global cache provided
in libunwind.  In this version, I decided to use the existing
callchain_param.record_mode instead of adding a new field in the
symbol_conf.

The patch 4 and 5 are just cleanups so that we can easily find out
that which part of code uses the thread->priv.

You can also get it from 'perf/callchain-unwind-v4' branch on my tree:

  git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git

Thanks,
Namhyung


Namhyung Kim (5):
  perf report: Set callchain_param.record_mode for future use
  perf callchain: Create an address space per thread
  perf callchain: Use global caching provided by libunwind
  perf kvm: Use thread_{,_set}_priv helpers
  perf trace: Use thread_{,_set}_priv helpers

 tools/perf/builtin-kvm.c   |  6 ++---
 tools/perf/builtin-report.c|  7 ++
 tools/perf/builtin-trace.c | 16 ++---
 tools/perf/tests/dwarf-unwind.c|  3 +++
 tools/perf/util/callchain.h|  2 ++
 tools/perf/util/hist.h |  2 --
 tools/perf/util/thread.c   |  9 +++
 tools/perf/util/unwind-libunwind.c | 48 ++
 tools/perf/util/unwind.h   | 20 
 9 files changed, 95 insertions(+), 18 deletions(-)

-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCHSET 0/5] perf tools: Speed up dwarf callchain post-unwinding for libunwind (v4)

2014-10-05 Thread Namhyung Kim
Hello,

This is v4 for libunwind callchain post processing speed up.  It was
able to reduce 50% of processing time by using global cache provided
in libunwind.  In this version, I decided to use the existing
callchain_param.record_mode instead of adding a new field in the
symbol_conf.

The patch 4 and 5 are just cleanups so that we can easily find out
that which part of code uses the thread-priv.

You can also get it from 'perf/callchain-unwind-v4' branch on my tree:

  git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git

Thanks,
Namhyung


Namhyung Kim (5):
  perf report: Set callchain_param.record_mode for future use
  perf callchain: Create an address space per thread
  perf callchain: Use global caching provided by libunwind
  perf kvm: Use thread_{,_set}_priv helpers
  perf trace: Use thread_{,_set}_priv helpers

 tools/perf/builtin-kvm.c   |  6 ++---
 tools/perf/builtin-report.c|  7 ++
 tools/perf/builtin-trace.c | 16 ++---
 tools/perf/tests/dwarf-unwind.c|  3 +++
 tools/perf/util/callchain.h|  2 ++
 tools/perf/util/hist.h |  2 --
 tools/perf/util/thread.c   |  9 +++
 tools/perf/util/unwind-libunwind.c | 48 ++
 tools/perf/util/unwind.h   | 20 
 9 files changed, 95 insertions(+), 18 deletions(-)

-- 
2.1.0

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/