Re: [PATCHv3 3/7] dmaengine: dw_dmac: remove CLK dependency
On Thu, Sep 27, 2012 at 01:47:58PM +0530, viresh kumar wrote: > On Thu, Sep 27, 2012 at 1:12 PM, Felipe Balbi wrote: > > Hi, > > > > On Thu, Sep 27, 2012 at 10:31:57AM +0300, Andy Shevchenko wrote: > >> From: Heikki Krogerus > >> > >> This driver could be used on different platforms. Thus, the HAVE_CLK > >> dependency > >> is dropped away. > >> > >> Signed-off-by: Heikki Krogerus > >> Signed-off-by: Andy Shevchenko > >> --- > >> drivers/dma/Kconfig |1 - > >> 1 file changed, 1 deletion(-) > >> > >> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig > >> index 677cd6e..df32537 100644 > >> --- a/drivers/dma/Kconfig > >> +++ b/drivers/dma/Kconfig > >> @@ -83,7 +83,6 @@ config INTEL_IOP_ADMA > >> > >> config DW_DMAC > >> tristate "Synopsys DesignWare AHB DMA support" > >> - depends on HAVE_CLK > > > > as is, this will break compilation of any arch which doesn't set > > HAVE_CLK. > > No, it will not due to following commit id: > > commit 93abe8e4b13ae9a0428ce940a8a03ac72a7626f1 > Author: Viresh Kumar > Date: Mon Jul 30 14:39:27 2012 -0700 > > clk: add non CONFIG_HAVE_CLK routines > > > @Andy: > > Acked-by: Viresh Kumar Reviewed-by: Felipe Balbi -- balbi signature.asc Description: Digital signature
Re: [PATCHv3 3/7] dmaengine: dw_dmac: remove CLK dependency
On Thu, Sep 27, 2012 at 1:12 PM, Felipe Balbi wrote: > Hi, > > On Thu, Sep 27, 2012 at 10:31:57AM +0300, Andy Shevchenko wrote: >> From: Heikki Krogerus >> >> This driver could be used on different platforms. Thus, the HAVE_CLK >> dependency >> is dropped away. >> >> Signed-off-by: Heikki Krogerus >> Signed-off-by: Andy Shevchenko >> --- >> drivers/dma/Kconfig |1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig >> index 677cd6e..df32537 100644 >> --- a/drivers/dma/Kconfig >> +++ b/drivers/dma/Kconfig >> @@ -83,7 +83,6 @@ config INTEL_IOP_ADMA >> >> config DW_DMAC >> tristate "Synopsys DesignWare AHB DMA support" >> - depends on HAVE_CLK > > as is, this will break compilation of any arch which doesn't set > HAVE_CLK. No, it will not due to following commit id: commit 93abe8e4b13ae9a0428ce940a8a03ac72a7626f1 Author: Viresh Kumar Date: Mon Jul 30 14:39:27 2012 -0700 clk: add non CONFIG_HAVE_CLK routines @Andy: Acked-by: Viresh Kumar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCHv3 3/7] dmaengine: dw_dmac: remove CLK dependency
Hi, On Thu, Sep 27, 2012 at 11:04:54AM +0300, Andy Shevchenko wrote: > On Thu, Sep 27, 2012 at 10:42 AM, Felipe Balbi wrote: > >> - depends on HAVE_CLK > > > > as is, this will break compilation of any arch which doesn't set > > HAVE_CLK. > As Viresh suggested and I checked it's not. > He wrote nice patch that adds stubs for such case. Great, that finally reached mainline. I was waiting for that patch for a long time, actually :-) thanks for the note -- balbi signature.asc Description: Digital signature
Re: [PATCHv3 3/7] dmaengine: dw_dmac: remove CLK dependency
On Thu, Sep 27, 2012 at 10:42 AM, Felipe Balbi wrote: >> - depends on HAVE_CLK > > as is, this will break compilation of any arch which doesn't set > HAVE_CLK. As Viresh suggested and I checked it's not. He wrote nice patch that adds stubs for such case. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCHv3 3/7] dmaengine: dw_dmac: remove CLK dependency
Hi, On Thu, Sep 27, 2012 at 10:31:57AM +0300, Andy Shevchenko wrote: > From: Heikki Krogerus > > This driver could be used on different platforms. Thus, the HAVE_CLK > dependency > is dropped away. > > Signed-off-by: Heikki Krogerus > Signed-off-by: Andy Shevchenko > --- > drivers/dma/Kconfig |1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig > index 677cd6e..df32537 100644 > --- a/drivers/dma/Kconfig > +++ b/drivers/dma/Kconfig > @@ -83,7 +83,6 @@ config INTEL_IOP_ADMA > > config DW_DMAC > tristate "Synopsys DesignWare AHB DMA support" > - depends on HAVE_CLK as is, this will break compilation of any arch which doesn't set HAVE_CLK. -- balbi signature.asc Description: Digital signature
[PATCHv3 3/7] dmaengine: dw_dmac: remove CLK dependency
From: Heikki Krogerus This driver could be used on different platforms. Thus, the HAVE_CLK dependency is dropped away. Signed-off-by: Heikki Krogerus Signed-off-by: Andy Shevchenko --- drivers/dma/Kconfig |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig index 677cd6e..df32537 100644 --- a/drivers/dma/Kconfig +++ b/drivers/dma/Kconfig @@ -83,7 +83,6 @@ config INTEL_IOP_ADMA config DW_DMAC tristate "Synopsys DesignWare AHB DMA support" - depends on HAVE_CLK select DMA_ENGINE default y if CPU_AT32AP7000 help -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCHv3 3/7] dmaengine: dw_dmac: remove CLK dependency
From: Heikki Krogerus heikki.kroge...@linux.intel.com This driver could be used on different platforms. Thus, the HAVE_CLK dependency is dropped away. Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/dma/Kconfig |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig index 677cd6e..df32537 100644 --- a/drivers/dma/Kconfig +++ b/drivers/dma/Kconfig @@ -83,7 +83,6 @@ config INTEL_IOP_ADMA config DW_DMAC tristate Synopsys DesignWare AHB DMA support - depends on HAVE_CLK select DMA_ENGINE default y if CPU_AT32AP7000 help -- 1.7.10.4 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCHv3 3/7] dmaengine: dw_dmac: remove CLK dependency
Hi, On Thu, Sep 27, 2012 at 10:31:57AM +0300, Andy Shevchenko wrote: From: Heikki Krogerus heikki.kroge...@linux.intel.com This driver could be used on different platforms. Thus, the HAVE_CLK dependency is dropped away. Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/dma/Kconfig |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig index 677cd6e..df32537 100644 --- a/drivers/dma/Kconfig +++ b/drivers/dma/Kconfig @@ -83,7 +83,6 @@ config INTEL_IOP_ADMA config DW_DMAC tristate Synopsys DesignWare AHB DMA support - depends on HAVE_CLK as is, this will break compilation of any arch which doesn't set HAVE_CLK. -- balbi signature.asc Description: Digital signature
Re: [PATCHv3 3/7] dmaengine: dw_dmac: remove CLK dependency
On Thu, Sep 27, 2012 at 10:42 AM, Felipe Balbi ba...@ti.com wrote: - depends on HAVE_CLK as is, this will break compilation of any arch which doesn't set HAVE_CLK. As Viresh suggested and I checked it's not. He wrote nice patch that adds stubs for such case. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCHv3 3/7] dmaengine: dw_dmac: remove CLK dependency
Hi, On Thu, Sep 27, 2012 at 11:04:54AM +0300, Andy Shevchenko wrote: On Thu, Sep 27, 2012 at 10:42 AM, Felipe Balbi ba...@ti.com wrote: - depends on HAVE_CLK as is, this will break compilation of any arch which doesn't set HAVE_CLK. As Viresh suggested and I checked it's not. He wrote nice patch that adds stubs for such case. Great, that finally reached mainline. I was waiting for that patch for a long time, actually :-) thanks for the note -- balbi signature.asc Description: Digital signature
Re: [PATCHv3 3/7] dmaengine: dw_dmac: remove CLK dependency
On Thu, Sep 27, 2012 at 1:12 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Thu, Sep 27, 2012 at 10:31:57AM +0300, Andy Shevchenko wrote: From: Heikki Krogerus heikki.kroge...@linux.intel.com This driver could be used on different platforms. Thus, the HAVE_CLK dependency is dropped away. Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/dma/Kconfig |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig index 677cd6e..df32537 100644 --- a/drivers/dma/Kconfig +++ b/drivers/dma/Kconfig @@ -83,7 +83,6 @@ config INTEL_IOP_ADMA config DW_DMAC tristate Synopsys DesignWare AHB DMA support - depends on HAVE_CLK as is, this will break compilation of any arch which doesn't set HAVE_CLK. No, it will not due to following commit id: commit 93abe8e4b13ae9a0428ce940a8a03ac72a7626f1 Author: Viresh Kumar viresh.ku...@st.com Date: Mon Jul 30 14:39:27 2012 -0700 clk: add non CONFIG_HAVE_CLK routines @Andy: Acked-by: Viresh Kumar viresh.ku...@linaro.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCHv3 3/7] dmaengine: dw_dmac: remove CLK dependency
On Thu, Sep 27, 2012 at 01:47:58PM +0530, viresh kumar wrote: On Thu, Sep 27, 2012 at 1:12 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Thu, Sep 27, 2012 at 10:31:57AM +0300, Andy Shevchenko wrote: From: Heikki Krogerus heikki.kroge...@linux.intel.com This driver could be used on different platforms. Thus, the HAVE_CLK dependency is dropped away. Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/dma/Kconfig |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig index 677cd6e..df32537 100644 --- a/drivers/dma/Kconfig +++ b/drivers/dma/Kconfig @@ -83,7 +83,6 @@ config INTEL_IOP_ADMA config DW_DMAC tristate Synopsys DesignWare AHB DMA support - depends on HAVE_CLK as is, this will break compilation of any arch which doesn't set HAVE_CLK. No, it will not due to following commit id: commit 93abe8e4b13ae9a0428ce940a8a03ac72a7626f1 Author: Viresh Kumar viresh.ku...@st.com Date: Mon Jul 30 14:39:27 2012 -0700 clk: add non CONFIG_HAVE_CLK routines @Andy: Acked-by: Viresh Kumar viresh.ku...@linaro.org Reviewed-by: Felipe Balbi ba...@ti.com -- balbi signature.asc Description: Digital signature
