Re: [linux-sunxi] [PATCH 1/3] ARM: dts: sun7i-a20: Rename bananapi as bananapi m1

[Maxime Ripard]

On Tue, May 30, 2017 at 08:22:44AM +0200, Karsten Merker wrote:
> On Tue, May 30, 2017 at 10:00:49AM +0530, Jagan Teki wrote:
> > On Tue, May 30, 2017 at 3:15 AM, Karsten Merker  wrote:
> > > On Mon, May 29, 2017 at 07:30:26PM +, Jagan Teki wrote:
> > >> From: Jagan Teki 
> > >>
> > >> from BPI(BIPAI KEJI LIMITED) products the Bananapi board
> > >> is named as 'Bananapi M1' and this is the starting
> > >> bananapi board from M1 series.
> > >>
> > >> So rename dts and suffix 'M1' on model for the same,
> > >> so-that next sequence on bananapi starts like M1 Plus, M2 and so..on
> > >>
> > >> Signed-off-by: Jagan Teki 
> > >> ---
> > >> Note: Bananapi BPI product site
> > >> http://www.banana-pi.org/product.html
> > >>
> > >>  arch/arm/boot/dts/Makefile  |   2 +-
> > >>  arch/arm/boot/dts/sun7i-a20-bananapi-m1.dts | 286 
> > >> 
> > >>  arch/arm/boot/dts/sun7i-a20-bananapi.dts| 286 
> > >> 
> > >>  3 files changed, 287 insertions(+), 287 deletions(-)
> > >>  create mode 100644 arch/arm/boot/dts/sun7i-a20-bananapi-m1.dts
> > >>  delete mode 100644 arch/arm/boot/dts/sun7i-a20-bananapi.dts
> > >>
> > >> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> > >> index 45c6e65..1b086f0 100644
> > >> --- a/arch/arm/boot/dts/Makefile
> > >> +++ b/arch/arm/boot/dts/Makefile
> > >> @@ -851,7 +851,7 @@ dtb-$(CONFIG_MACH_SUN6I) += \
> > >>   sun6i-a31s-sinovoip-bpi-m2.dtb \
> > >>   sun6i-a31s-yones-toptech-bs1078-v2.dtb
> > >>  dtb-$(CONFIG_MACH_SUN7I) += \
> > >> - sun7i-a20-bananapi.dtb \
> > >> + sun7i-a20-bananapi-m1.dtb \
> > >>   sun7i-a20-bananapi-m1-plus.dtb \
> > >>   sun7i-a20-bananapro.dtb \
> > >>   sun7i-a20-cubieboard2.dtb \
> > >> diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi-m1.dts 
> > >> b/arch/arm/boot/dts/sun7i-a20-bananapi-m1.dts
> > >> new file mode 100644
> > >> index 000..8b97b89
> > >> --- /dev/null
> > >> +++ b/arch/arm/boot/dts/sun7i-a20-bananapi-m1.dts
> > >> @@ -0,0 +1,286 @@
> > >> +/*
> > >> + * Copyright 2014 Hans de Goede 
> > >> + *
> > >> + * Hans de Goede 
> > > [...]
> > >> +/dts-v1/;
> > >> +#include "sun7i-a20.dtsi"
> > >> +#include "sunxi-common-regulators.dtsi"
> > >> +
> > >> +#include 
> > >> +#include 
> > >> +
> > >> +/ {
> > >> + model = "LeMaker Banana Pi M1";
> > >> + compatible = "lemaker,bananapi", "allwinner,sun7i-a20";
> > > [...]
> > >> diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi.dts 
> > >> b/arch/arm/boot/dts/sun7i-a20-bananapi.dts
> > >> deleted file mode 100644
> > >> index ed2f35a..000
> > >> --- a/arch/arm/boot/dts/sun7i-a20-bananapi.dts
> > >> +++ /dev/null
> > >
> > > NACK!
> > >
> > > Please neither rename the dts nor change the model string. Such a
> > > change would make newer kernels unusable on many existing
> > > installations without manual fixups by the end user.  Linux
> > > distributions use databases with model-specific setup information
> > > (such as the dtb file name, the platform-specific bootscript to
> > > use, usable kernel flavours (lpae or non-lpae), etc.) on kernel
> > > installations and kernel upgrades, and those use the model string
> > > as their key for finding the relevant information.  If you change
> > > either the dts file name or the model string inside the dts,
> > > you'll effectively break the proper installation of newer kernel
> > > versions on existing end user systems.
> > 
> > I understand your concerns about distribution change, but with new
> > change in 'bananapi' brand owned by BIPAI KEJI(BPI) the model must
> > need to update and this is not technically as Bananapi board it is
> > Bananapi  M1 [1]
> > 
> > These are generic changes based on the hardware vendor info.
> > 
> > [1] http://www.banana-pi.org/m1.html
> 
> Hello Jagan,
> 
> I have to disagree here. Whatever BIPAI KEJI(BPI) chooses to name
> their products today or in the future doesn't change history. 
> The "original" Banana Pi was sold under the LeMaker brand and it
> was named "Banana Pi" and not "Banana Pi M1".  The fact that
> LeMaker has stopped selling their Banana Pi board and BIPAI
> KEJI(BPI) (a different company than LeMaker!) now sells a board
> that is compatible to the original "LeMaker Banana Pi" under the
> name "Banana Pi M1" (and not "LeMaker Banana Pi M1" as you claim
> in your modified dts) doesn't matter at all for an existing dts
> and is in no way a valid reason to make an incompatible change
> that breaks existing systems.
> 
> If you wanted to add a new (technically identical) dts with a
> different model string under a new dts file name and keep the
> existing one unchanged, I would find that unneccessary but at
> least acceptable insofar as it wouldn't break existing end user
> systems, but breaking existing systems in the wild is clearly
> unacceptable.  I assume 

Re: [linux-sunxi] [PATCH 1/3] ARM: dts: sun7i-a20: Rename bananapi as bananapi m1

[Maxime Ripard]

On Tue, May 30, 2017 at 08:22:44AM +0200, Karsten Merker wrote:
> On Tue, May 30, 2017 at 10:00:49AM +0530, Jagan Teki wrote:
> > On Tue, May 30, 2017 at 3:15 AM, Karsten Merker  wrote:
> > > On Mon, May 29, 2017 at 07:30:26PM +, Jagan Teki wrote:
> > >> From: Jagan Teki 
> > >>
> > >> from BPI(BIPAI KEJI LIMITED) products the Bananapi board
> > >> is named as 'Bananapi M1' and this is the starting
> > >> bananapi board from M1 series.
> > >>
> > >> So rename dts and suffix 'M1' on model for the same,
> > >> so-that next sequence on bananapi starts like M1 Plus, M2 and so..on
> > >>
> > >> Signed-off-by: Jagan Teki 
> > >> ---
> > >> Note: Bananapi BPI product site
> > >> http://www.banana-pi.org/product.html
> > >>
> > >>  arch/arm/boot/dts/Makefile  |   2 +-
> > >>  arch/arm/boot/dts/sun7i-a20-bananapi-m1.dts | 286 
> > >> 
> > >>  arch/arm/boot/dts/sun7i-a20-bananapi.dts| 286 
> > >> 
> > >>  3 files changed, 287 insertions(+), 287 deletions(-)
> > >>  create mode 100644 arch/arm/boot/dts/sun7i-a20-bananapi-m1.dts
> > >>  delete mode 100644 arch/arm/boot/dts/sun7i-a20-bananapi.dts
> > >>
> > >> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> > >> index 45c6e65..1b086f0 100644
> > >> --- a/arch/arm/boot/dts/Makefile
> > >> +++ b/arch/arm/boot/dts/Makefile
> > >> @@ -851,7 +851,7 @@ dtb-$(CONFIG_MACH_SUN6I) += \
> > >>   sun6i-a31s-sinovoip-bpi-m2.dtb \
> > >>   sun6i-a31s-yones-toptech-bs1078-v2.dtb
> > >>  dtb-$(CONFIG_MACH_SUN7I) += \
> > >> - sun7i-a20-bananapi.dtb \
> > >> + sun7i-a20-bananapi-m1.dtb \
> > >>   sun7i-a20-bananapi-m1-plus.dtb \
> > >>   sun7i-a20-bananapro.dtb \
> > >>   sun7i-a20-cubieboard2.dtb \
> > >> diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi-m1.dts 
> > >> b/arch/arm/boot/dts/sun7i-a20-bananapi-m1.dts
> > >> new file mode 100644
> > >> index 000..8b97b89
> > >> --- /dev/null
> > >> +++ b/arch/arm/boot/dts/sun7i-a20-bananapi-m1.dts
> > >> @@ -0,0 +1,286 @@
> > >> +/*
> > >> + * Copyright 2014 Hans de Goede 
> > >> + *
> > >> + * Hans de Goede 
> > > [...]
> > >> +/dts-v1/;
> > >> +#include "sun7i-a20.dtsi"
> > >> +#include "sunxi-common-regulators.dtsi"
> > >> +
> > >> +#include 
> > >> +#include 
> > >> +
> > >> +/ {
> > >> + model = "LeMaker Banana Pi M1";
> > >> + compatible = "lemaker,bananapi", "allwinner,sun7i-a20";
> > > [...]
> > >> diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi.dts 
> > >> b/arch/arm/boot/dts/sun7i-a20-bananapi.dts
> > >> deleted file mode 100644
> > >> index ed2f35a..000
> > >> --- a/arch/arm/boot/dts/sun7i-a20-bananapi.dts
> > >> +++ /dev/null
> > >
> > > NACK!
> > >
> > > Please neither rename the dts nor change the model string. Such a
> > > change would make newer kernels unusable on many existing
> > > installations without manual fixups by the end user.  Linux
> > > distributions use databases with model-specific setup information
> > > (such as the dtb file name, the platform-specific bootscript to
> > > use, usable kernel flavours (lpae or non-lpae), etc.) on kernel
> > > installations and kernel upgrades, and those use the model string
> > > as their key for finding the relevant information.  If you change
> > > either the dts file name or the model string inside the dts,
> > > you'll effectively break the proper installation of newer kernel
> > > versions on existing end user systems.
> > 
> > I understand your concerns about distribution change, but with new
> > change in 'bananapi' brand owned by BIPAI KEJI(BPI) the model must
> > need to update and this is not technically as Bananapi board it is
> > Bananapi  M1 [1]
> > 
> > These are generic changes based on the hardware vendor info.
> > 
> > [1] http://www.banana-pi.org/m1.html
> 
> Hello Jagan,
> 
> I have to disagree here. Whatever BIPAI KEJI(BPI) chooses to name
> their products today or in the future doesn't change history. 
> The "original" Banana Pi was sold under the LeMaker brand and it
> was named "Banana Pi" and not "Banana Pi M1".  The fact that
> LeMaker has stopped selling their Banana Pi board and BIPAI
> KEJI(BPI) (a different company than LeMaker!) now sells a board
> that is compatible to the original "LeMaker Banana Pi" under the
> name "Banana Pi M1" (and not "LeMaker Banana Pi M1" as you claim
> in your modified dts) doesn't matter at all for an existing dts
> and is in no way a valid reason to make an incompatible change
> that breaks existing systems.
> 
> If you wanted to add a new (technically identical) dts with a
> different model string under a new dts file name and keep the
> existing one unchanged, I would find that unneccessary but at
> least acceptable insofar as it wouldn't break existing end user
> systems, but breaking existing systems in the wild is clearly
> unacceptable.  I assume that the kernel dts maintainers would
> probably still object to such an addition as it is unneccessary
> from a 

Re: [linux-sunxi] [PATCH 1/3] ARM: dts: sun7i-a20: Rename bananapi as bananapi m1

[Jagan Teki]

On Tue, May 30, 2017 at 3:15 AM, Karsten Merker  wrote:
> On Mon, May 29, 2017 at 07:30:26PM +, Jagan Teki wrote:
>> From: Jagan Teki 
>>
>> from BPI(BIPAI KEJI LIMITED) products the Bananapi board
>> is named as 'Bananapi M1' and this is the starting
>> bananapi board from M1 series.
>>
>> So rename dts and suffix 'M1' on model for the same,
>> so-that next sequence on bananapi starts like M1 Plus, M2 and so..on
>>
>> Signed-off-by: Jagan Teki 
>> ---
>> Note: Bananapi BPI product site
>> http://www.banana-pi.org/product.html
>>
>>  arch/arm/boot/dts/Makefile  |   2 +-
>>  arch/arm/boot/dts/sun7i-a20-bananapi-m1.dts | 286 
>> 
>>  arch/arm/boot/dts/sun7i-a20-bananapi.dts| 286 
>> 
>>  3 files changed, 287 insertions(+), 287 deletions(-)
>>  create mode 100644 arch/arm/boot/dts/sun7i-a20-bananapi-m1.dts
>>  delete mode 100644 arch/arm/boot/dts/sun7i-a20-bananapi.dts
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index 45c6e65..1b086f0 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -851,7 +851,7 @@ dtb-$(CONFIG_MACH_SUN6I) += \
>>   sun6i-a31s-sinovoip-bpi-m2.dtb \
>>   sun6i-a31s-yones-toptech-bs1078-v2.dtb
>>  dtb-$(CONFIG_MACH_SUN7I) += \
>> - sun7i-a20-bananapi.dtb \
>> + sun7i-a20-bananapi-m1.dtb \
>>   sun7i-a20-bananapi-m1-plus.dtb \
>>   sun7i-a20-bananapro.dtb \
>>   sun7i-a20-cubieboard2.dtb \
>> diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi-m1.dts 
>> b/arch/arm/boot/dts/sun7i-a20-bananapi-m1.dts
>> new file mode 100644
>> index 000..8b97b89
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/sun7i-a20-bananapi-m1.dts
>> @@ -0,0 +1,286 @@
>> +/*
>> + * Copyright 2014 Hans de Goede 
>> + *
>> + * Hans de Goede 
> [...]
>> +/dts-v1/;
>> +#include "sun7i-a20.dtsi"
>> +#include "sunxi-common-regulators.dtsi"
>> +
>> +#include 
>> +#include 
>> +
>> +/ {
>> + model = "LeMaker Banana Pi M1";
>> + compatible = "lemaker,bananapi", "allwinner,sun7i-a20";
> [...]
>> diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi.dts 
>> b/arch/arm/boot/dts/sun7i-a20-bananapi.dts
>> deleted file mode 100644
>> index ed2f35a..000
>> --- a/arch/arm/boot/dts/sun7i-a20-bananapi.dts
>> +++ /dev/null
>
> NACK!
>
> Please neither rename the dts nor change the model string. Such a
> change would make newer kernels unusable on many existing
> installations without manual fixups by the end user.  Linux
> distributions use databases with model-specific setup information
> (such as the dtb file name, the platform-specific bootscript to
> use, usable kernel flavours (lpae or non-lpae), etc.) on kernel
> installations and kernel upgrades, and those use the model string
> as their key for finding the relevant information.  If you change
> either the dts file name or the model string inside the dts,
> you'll effectively break the proper installation of newer kernel
> versions on existing end user systems.

I understand your concerns about distribution change, but with new
change in 'bananapi' brand owned by BIPAI KEJI(BPI) the model must
need to update and this is not technically as Bananapi board it is
Bananapi  M1 [1]

These are generic changes based on the hardware vendor info.

[1] http://www.banana-pi.org/m1.html

thanks!
-- 
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.

Re: [linux-sunxi] [PATCH 1/3] ARM: dts: sun7i-a20: Rename bananapi as bananapi m1

[Jagan Teki]

On Tue, May 30, 2017 at 3:15 AM, Karsten Merker  wrote:
> On Mon, May 29, 2017 at 07:30:26PM +, Jagan Teki wrote:
>> From: Jagan Teki 
>>
>> from BPI(BIPAI KEJI LIMITED) products the Bananapi board
>> is named as 'Bananapi M1' and this is the starting
>> bananapi board from M1 series.
>>
>> So rename dts and suffix 'M1' on model for the same,
>> so-that next sequence on bananapi starts like M1 Plus, M2 and so..on
>>
>> Signed-off-by: Jagan Teki 
>> ---
>> Note: Bananapi BPI product site
>> http://www.banana-pi.org/product.html
>>
>>  arch/arm/boot/dts/Makefile  |   2 +-
>>  arch/arm/boot/dts/sun7i-a20-bananapi-m1.dts | 286 
>> 
>>  arch/arm/boot/dts/sun7i-a20-bananapi.dts| 286 
>> 
>>  3 files changed, 287 insertions(+), 287 deletions(-)
>>  create mode 100644 arch/arm/boot/dts/sun7i-a20-bananapi-m1.dts
>>  delete mode 100644 arch/arm/boot/dts/sun7i-a20-bananapi.dts
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index 45c6e65..1b086f0 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -851,7 +851,7 @@ dtb-$(CONFIG_MACH_SUN6I) += \
>>   sun6i-a31s-sinovoip-bpi-m2.dtb \
>>   sun6i-a31s-yones-toptech-bs1078-v2.dtb
>>  dtb-$(CONFIG_MACH_SUN7I) += \
>> - sun7i-a20-bananapi.dtb \
>> + sun7i-a20-bananapi-m1.dtb \
>>   sun7i-a20-bananapi-m1-plus.dtb \
>>   sun7i-a20-bananapro.dtb \
>>   sun7i-a20-cubieboard2.dtb \
>> diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi-m1.dts 
>> b/arch/arm/boot/dts/sun7i-a20-bananapi-m1.dts
>> new file mode 100644
>> index 000..8b97b89
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/sun7i-a20-bananapi-m1.dts
>> @@ -0,0 +1,286 @@
>> +/*
>> + * Copyright 2014 Hans de Goede 
>> + *
>> + * Hans de Goede 
> [...]
>> +/dts-v1/;
>> +#include "sun7i-a20.dtsi"
>> +#include "sunxi-common-regulators.dtsi"
>> +
>> +#include 
>> +#include 
>> +
>> +/ {
>> + model = "LeMaker Banana Pi M1";
>> + compatible = "lemaker,bananapi", "allwinner,sun7i-a20";
> [...]
>> diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi.dts 
>> b/arch/arm/boot/dts/sun7i-a20-bananapi.dts
>> deleted file mode 100644
>> index ed2f35a..000
>> --- a/arch/arm/boot/dts/sun7i-a20-bananapi.dts
>> +++ /dev/null
>
> NACK!
>
> Please neither rename the dts nor change the model string. Such a
> change would make newer kernels unusable on many existing
> installations without manual fixups by the end user.  Linux
> distributions use databases with model-specific setup information
> (such as the dtb file name, the platform-specific bootscript to
> use, usable kernel flavours (lpae or non-lpae), etc.) on kernel
> installations and kernel upgrades, and those use the model string
> as their key for finding the relevant information.  If you change
> either the dts file name or the model string inside the dts,
> you'll effectively break the proper installation of newer kernel
> versions on existing end user systems.

I understand your concerns about distribution change, but with new
change in 'bananapi' brand owned by BIPAI KEJI(BPI) the model must
need to update and this is not technically as Bananapi board it is
Bananapi  M1 [1]

These are generic changes based on the hardware vendor info.

[1] http://www.banana-pi.org/m1.html

thanks!
-- 
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.

Re: [linux-sunxi] [PATCH 1/3] ARM: dts: sun7i-a20: Rename bananapi as bananapi m1

[Icenowy Zheng]

于 2017年5月30日 GMT+08:00 上午3:30:26, Jagan Teki  写到:
>From: Jagan Teki 
>
>from BPI(BIPAI KEJI LIMITED) products the Bananapi board
>is named as 'Bananapi M1' and this is the starting
>bananapi board from M1 series.
>
>So rename dts and suffix 'M1' on model for the same,
>so-that next sequence on bananapi starts like M1 Plus, M2 and so..on
>
>Signed-off-by: Jagan Teki 
>---
>Note: Bananapi BPI product site
>http://www.banana-pi.org/product.html
>
> arch/arm/boot/dts/Makefile  |   2 +-
>arch/arm/boot/dts/sun7i-a20-bananapi-m1.dts | 286
>
>arch/arm/boot/dts/sun7i-a20-bananapi.dts| 286
>
> 3 files changed, 287 insertions(+), 287 deletions(-)
> create mode 100644 arch/arm/boot/dts/sun7i-a20-bananapi-m1.dts
> delete mode 100644 arch/arm/boot/dts/sun7i-a20-bananapi.dts
>
>diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>index 45c6e65..1b086f0 100644
>--- a/arch/arm/boot/dts/Makefile
>+++ b/arch/arm/boot/dts/Makefile
>@@ -851,7 +851,7 @@ dtb-$(CONFIG_MACH_SUN6I) += \
>   sun6i-a31s-sinovoip-bpi-m2.dtb \
>   sun6i-a31s-yones-toptech-bs1078-v2.dtb
> dtb-$(CONFIG_MACH_SUN7I) += \
>-  sun7i-a20-bananapi.dtb \
>+  sun7i-a20-bananapi-m1.dtb \
>   sun7i-a20-bananapi-m1-plus.dtb \
>   sun7i-a20-bananapro.dtb \
>   sun7i-a20-cubieboard2.dtb \
>diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi-m1.dts
>b/arch/arm/boot/dts/sun7i-a20-bananapi-m1.dts
>new file mode 100644
>index 000..8b97b89
>--- /dev/null
>+++ b/arch/arm/boot/dts/sun7i-a20-bananapi-m1.dts
>@@ -0,0 +1,286 @@
>+/*
>+ * Copyright 2014 Hans de Goede 
>+ *
>+ * Hans de Goede 
>+ *
>+ * This file is dual-licensed: you can use it either under the terms
>+ * of the GPL or the X11 license, at your option. Note that this dual
>+ * licensing only applies to this file, and not this project as a
>+ * whole.
>+ *
>+ *  a) This file is free software; you can redistribute it and/or
>+ * modify it under the terms of the GNU General Public License as
>+ * published by the Free Software Foundation; either version 2 of
>the
>+ * License, or (at your option) any later version.
>+ *
>+ * This file is distributed in the hope that it will be useful,
>+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
>+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>+ * GNU General Public License for more details.
>+ *
>+ * Or, alternatively,
>+ *
>+ *  b) Permission is hereby granted, free of charge, to any person
>+ * obtaining a copy of this software and associated documentation
>+ * files (the "Software"), to deal in the Software without
>+ * restriction, including without limitation the rights to use,
>+ * copy, modify, merge, publish, distribute, sublicense, and/or
>+ * sell copies of the Software, and to permit persons to whom the
>+ * Software is furnished to do so, subject to the following
>+ * conditions:
>+ *
>+ * The above copyright notice and this permission notice shall be
>+ * included in all copies or substantial portions of the Software.
>+ *
>+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
>+ * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
>+ * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
>+ * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
>+ * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
>+ * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
>+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
>+ * OTHER DEALINGS IN THE SOFTWARE.
>+ */
>+
>+/dts-v1/;
>+#include "sun7i-a20.dtsi"
>+#include "sunxi-common-regulators.dtsi"
>+
>+#include 
>+#include 
>+
>+/ {
>+  model = "LeMaker Banana Pi M1";
>+  compatible = "lemaker,bananapi", "allwinner,sun7i-a20";

LeMaker never name this BPI M1.

The M1 tag is made by Sinovoip and Bipai.

I suggest you just set model to "Banana Pi M1" and compatible to
three:
"bananapi,bpi-m1", "lemaker,bananapi" (Sinovoip BPi
M1 is fully compatible with the original Banana Pi by LeMaker,
so here're these compatibles) and "allwinner,sun7i-a20".

>+
>+  aliases {
>+  serial0 = 
>+  serial1 = 
>+  serial2 = 
>+  };
>+
>+  chosen {
>+  stdout-path = "serial0:115200n8";
>+  };
>+
>+  leds {
>+  compatible = "gpio-leds";
>+  pinctrl-names = "default";
>+  pinctrl-0 = <_pins_bananapi>;
>+
>+  green {
>+  label = "bananapi:green:usr";
>+  gpios = < 7 24 GPIO_ACTIVE_HIGH>;
>+  };
>+  };
>+
>+  reg_gmac_3v3: gmac-3v3 {
>+  compatible = "regulator-fixed";
>+  pinctrl-names = "default";
>+ 

Re: [linux-sunxi] [PATCH 1/3] ARM: dts: sun7i-a20: Rename bananapi as bananapi m1

[Icenowy Zheng]

于 2017年5月30日 GMT+08:00 上午3:30:26, Jagan Teki  写到:
>From: Jagan Teki 
>
>from BPI(BIPAI KEJI LIMITED) products the Bananapi board
>is named as 'Bananapi M1' and this is the starting
>bananapi board from M1 series.
>
>So rename dts and suffix 'M1' on model for the same,
>so-that next sequence on bananapi starts like M1 Plus, M2 and so..on
>
>Signed-off-by: Jagan Teki 
>---
>Note: Bananapi BPI product site
>http://www.banana-pi.org/product.html
>
> arch/arm/boot/dts/Makefile  |   2 +-
>arch/arm/boot/dts/sun7i-a20-bananapi-m1.dts | 286
>
>arch/arm/boot/dts/sun7i-a20-bananapi.dts| 286
>
> 3 files changed, 287 insertions(+), 287 deletions(-)
> create mode 100644 arch/arm/boot/dts/sun7i-a20-bananapi-m1.dts
> delete mode 100644 arch/arm/boot/dts/sun7i-a20-bananapi.dts
>
>diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>index 45c6e65..1b086f0 100644
>--- a/arch/arm/boot/dts/Makefile
>+++ b/arch/arm/boot/dts/Makefile
>@@ -851,7 +851,7 @@ dtb-$(CONFIG_MACH_SUN6I) += \
>   sun6i-a31s-sinovoip-bpi-m2.dtb \
>   sun6i-a31s-yones-toptech-bs1078-v2.dtb
> dtb-$(CONFIG_MACH_SUN7I) += \
>-  sun7i-a20-bananapi.dtb \
>+  sun7i-a20-bananapi-m1.dtb \
>   sun7i-a20-bananapi-m1-plus.dtb \
>   sun7i-a20-bananapro.dtb \
>   sun7i-a20-cubieboard2.dtb \
>diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi-m1.dts
>b/arch/arm/boot/dts/sun7i-a20-bananapi-m1.dts
>new file mode 100644
>index 000..8b97b89
>--- /dev/null
>+++ b/arch/arm/boot/dts/sun7i-a20-bananapi-m1.dts
>@@ -0,0 +1,286 @@
>+/*
>+ * Copyright 2014 Hans de Goede 
>+ *
>+ * Hans de Goede 
>+ *
>+ * This file is dual-licensed: you can use it either under the terms
>+ * of the GPL or the X11 license, at your option. Note that this dual
>+ * licensing only applies to this file, and not this project as a
>+ * whole.
>+ *
>+ *  a) This file is free software; you can redistribute it and/or
>+ * modify it under the terms of the GNU General Public License as
>+ * published by the Free Software Foundation; either version 2 of
>the
>+ * License, or (at your option) any later version.
>+ *
>+ * This file is distributed in the hope that it will be useful,
>+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
>+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>+ * GNU General Public License for more details.
>+ *
>+ * Or, alternatively,
>+ *
>+ *  b) Permission is hereby granted, free of charge, to any person
>+ * obtaining a copy of this software and associated documentation
>+ * files (the "Software"), to deal in the Software without
>+ * restriction, including without limitation the rights to use,
>+ * copy, modify, merge, publish, distribute, sublicense, and/or
>+ * sell copies of the Software, and to permit persons to whom the
>+ * Software is furnished to do so, subject to the following
>+ * conditions:
>+ *
>+ * The above copyright notice and this permission notice shall be
>+ * included in all copies or substantial portions of the Software.
>+ *
>+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
>+ * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
>+ * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
>+ * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
>+ * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
>+ * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
>+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
>+ * OTHER DEALINGS IN THE SOFTWARE.
>+ */
>+
>+/dts-v1/;
>+#include "sun7i-a20.dtsi"
>+#include "sunxi-common-regulators.dtsi"
>+
>+#include 
>+#include 
>+
>+/ {
>+  model = "LeMaker Banana Pi M1";
>+  compatible = "lemaker,bananapi", "allwinner,sun7i-a20";

LeMaker never name this BPI M1.

The M1 tag is made by Sinovoip and Bipai.

I suggest you just set model to "Banana Pi M1" and compatible to
three:
"bananapi,bpi-m1", "lemaker,bananapi" (Sinovoip BPi
M1 is fully compatible with the original Banana Pi by LeMaker,
so here're these compatibles) and "allwinner,sun7i-a20".

>+
>+  aliases {
>+  serial0 = 
>+  serial1 = 
>+  serial2 = 
>+  };
>+
>+  chosen {
>+  stdout-path = "serial0:115200n8";
>+  };
>+
>+  leds {
>+  compatible = "gpio-leds";
>+  pinctrl-names = "default";
>+  pinctrl-0 = <_pins_bananapi>;
>+
>+  green {
>+  label = "bananapi:green:usr";
>+  gpios = < 7 24 GPIO_ACTIVE_HIGH>;
>+  };
>+  };
>+
>+  reg_gmac_3v3: gmac-3v3 {
>+  compatible = "regulator-fixed";
>+  pinctrl-names = "default";
>+  pinctrl-0 = <_power_pin_bananapi>;
>+  regulator-name = "gmac-3v3";
>+