Re: [PATCH] [275/2many] MAINTAINERS - KDUMP
On Wed, 2007-10-17 at 12:48 +0900, Simon Horman wrote: > Do you have a criteria for including files. A file or file pattern specific to a maintained "subsystem". Any time a subsystem file pattern matches a file, maintainers would be cc'd. The matching is non-exclusive. Multiple subsystems can include the same file pattern. For KDUMP, maybe a file pattern should be: F: arch/*/kernel/crash_dump.c F: include/linux/crash_dump.h > Are they files that only apply to KEXEC/KDUMP, > or files that have KEXEC/KDUMP code and other code? I think it should be files specific to KDUMP and not files shared with other subsystems but perhaps it's maintainer taste. If the files patterns are not specific to kdump, the kdump maintainers will be cc'd on patches that change files where kdump functions aren't modified. The list of files that include crash_dump.h is pretty long. $ grep -P -l -r --include=*.[ch] crash_dump.h * arch/i386/kernel/crash_dump.c arch/i386/kernel/setup.c arch/ia64/hp/common/sba_iommu.c arch/ia64/kernel/crash.c arch/ia64/kernel/setup.c arch/powerpc/kernel/crash.c arch/powerpc/kernel/crash_dump.c arch/sh/kernel/crash_dump.c arch/x86_64/kernel/crash_dump.c arch/x86_64/kernel/setup.c drivers/char/mem.c fs/proc/proc_misc.c fs/proc/vmcore.c The list of files that use CONFIG_CRASH_DUMP is also pretty long and seemingly unrelated. $ grep -P -l -r --include=*.[ch] CONFIG_CRASH_DUMP * arch/i386/kernel/apic.c arch/i386/kernel/e820.c arch/ia64/hp/common/sba_iommu.c arch/ia64/kernel/efi.c arch/powerpc/kernel/iommu.c arch/powerpc/platforms/cell/ras.c arch/powerpc/platforms/pseries/iommu.c arch/x86_64/kernel/e820.c drivers/char/mem.c include/asm-powerpc/kdump.h include/linux/bootmem.h include/linux/crash_dump.h mm/bootmem.c - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [275/2many] MAINTAINERS - KDUMP
On Tue, Oct 16, 2007 at 07:45:34PM -0700, Joe Perches wrote: > On Wed, 2007-10-17 at 11:19 +0900, Simon Horman wrote: > > > I take it that these changes got shelved or canned, > > as I still don't seem them in Linus' tree. > > I have all the changes kept up-to-date. > I still hope to get some variant into a future release. > > > But just for the record, the file lists seem > > to be somewhat sort. I'm not sure exactly what the criteria is, but for > > starters, shouldn't all the architecture specific files that only > > contain kexec or kdump code be in there too? > > If one of the maintainers, Vivek Goyal or Haren Myneni, cared > to improve the kdump list of files, I'd happily accept it. Understood. I'm happy to make a start on that. Do you have a criteria for including files. Are they files that only apply to KEXEC/KDUMP, or files that have KEXEC/KDUMP code and other code? > My maintainer entry for kdump is: > > KDUMP > P:Vivek Goyal > M:[EMAIL PROTECTED] > P:Haren Myneni > M:[EMAIL PROTECTED] > L:[EMAIL PROTECTED] > L:linux-kernel@vger.kernel.org > W:http://lse.sourceforge.net/kdump/ > S:Maintained > F:Documentation/kdump > > and if Eric Biederman wants to improve kexec: > > KEXEC > P:Eric Biederman > M:[EMAIL PROTECTED] > W:http://www.xmission.com/~ebiederm/files/kexec/ > L:linux-kernel@vger.kernel.org > L:[EMAIL PROTECTED] > S:Maintained > F:include/linux/kexec.h > F:kernel/kexec.c > > > > > ___ > kexec mailing list > [EMAIL PROTECTED] > http://lists.infradead.org/mailman/listinfo/kexec -- Horms H: http://www.vergenet.net/~horms/ W: http://www.valinux.co.jp/en/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [275/2many] MAINTAINERS - KDUMP
On Tue, 16 Oct 2007 19:45:34 -0700 Joe Perches <[EMAIL PROTECTED]> wrote: > If one of the maintainers, Vivek Goyal or Haren Myneni, cared > to improve the kdump list of files, I'd happily accept it. meh. Bug-reporters only manage to cc the right mailing list 10% of the time even when it's utterly obvious which subsystem went splat. I wouldn't worry about fine details such as this. Anyway, everyone just sends stuff to the great kernel routing service (ie: me) for the traditional forward-and-ignore treatment. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [275/2many] MAINTAINERS - KDUMP
On Wed, 2007-10-17 at 11:19 +0900, Simon Horman wrote: > I take it that these changes got shelved or canned, > as I still don't seem them in Linus' tree. I have all the changes kept up-to-date. I still hope to get some variant into a future release. > But just for the record, the file lists seem > to be somewhat sort. I'm not sure exactly what the criteria is, but for > starters, shouldn't all the architecture specific files that only > contain kexec or kdump code be in there too? If one of the maintainers, Vivek Goyal or Haren Myneni, cared to improve the kdump list of files, I'd happily accept it. My maintainer entry for kdump is: KDUMP P: Vivek Goyal M: [EMAIL PROTECTED] P: Haren Myneni M: [EMAIL PROTECTED] L: [EMAIL PROTECTED] L: linux-kernel@vger.kernel.org W: http://lse.sourceforge.net/kdump/ S: Maintained F: Documentation/kdump and if Eric Biederman wants to improve kexec: KEXEC P: Eric Biederman M: [EMAIL PROTECTED] W: http://www.xmission.com/~ebiederm/files/kexec/ L: linux-kernel@vger.kernel.org L: [EMAIL PROTECTED] S: Maintained F: include/linux/kexec.h F: kernel/kexec.c - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [275/2many] MAINTAINERS - KDUMP
On Sun, Aug 12, 2007 at 11:30:38PM -0700, [EMAIL PROTECTED] wrote: > Add file pattern to MAINTAINER entry > > Signed-off-by: Joe Perches <[EMAIL PROTECTED]> > > diff --git a/MAINTAINERS b/MAINTAINERS > index 1ea2c63..d61676a 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -2634,6 +2634,7 @@ L: [EMAIL PROTECTED] > L: linux-kernel@vger.kernel.org > W: http://lse.sourceforge.net/kdump/ > S: Maintained > +F: Documentation/kdump > > KERNEL AUTOMOUNTER (AUTOFS) > P: H. Peter Anvin > > ___ > kexec mailing list > [EMAIL PROTECTED] > http://lists.infradead.org/mailman/listinfo/kexec On Sun, Aug 12, 2007 at 11:30:49PM -0700, [EMAIL PROTECTED] wrote: > Add file pattern to MAINTAINER entry > > Signed-off-by: Joe Perches <[EMAIL PROTECTED]> > > diff --git a/MAINTAINERS b/MAINTAINERS > index d9a53d9..71738bd 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -2694,6 +2694,8 @@ W: http://www.xmission.com/~ebiederm/files/kexec/ > L: linux-kernel@vger.kernel.org > L: [EMAIL PROTECTED] > S: Maintained > +F: include/linux/kexec.h > +F: kernel/kexec.c > > KPROBES > P: Prasanna S Panchamukhi I take it that these changes got shelved or canned, as I still don't seem them in Linus' tree. But just for the record, the file lists seem to be somewhat sort. I'm not sure exactly what the criteria is, but for starters, shouldn't all the architecture specific files that only contain kexec or kdump code be in there too? -- Horms H: http://www.vergenet.net/~horms/ W: http://www.valinux.co.jp/en/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [275/2many] MAINTAINERS - KDUMP
On Sun, Aug 12, 2007 at 11:30:38PM -0700, [EMAIL PROTECTED] wrote: Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches [EMAIL PROTECTED] diff --git a/MAINTAINERS b/MAINTAINERS index 1ea2c63..d61676a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2634,6 +2634,7 @@ L: [EMAIL PROTECTED] L: linux-kernel@vger.kernel.org W: http://lse.sourceforge.net/kdump/ S: Maintained +F: Documentation/kdump KERNEL AUTOMOUNTER (AUTOFS) P: H. Peter Anvin ___ kexec mailing list [EMAIL PROTECTED] http://lists.infradead.org/mailman/listinfo/kexec On Sun, Aug 12, 2007 at 11:30:49PM -0700, [EMAIL PROTECTED] wrote: Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches [EMAIL PROTECTED] diff --git a/MAINTAINERS b/MAINTAINERS index d9a53d9..71738bd 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2694,6 +2694,8 @@ W: http://www.xmission.com/~ebiederm/files/kexec/ L: linux-kernel@vger.kernel.org L: [EMAIL PROTECTED] S: Maintained +F: include/linux/kexec.h +F: kernel/kexec.c KPROBES P: Prasanna S Panchamukhi I take it that these changes got shelved or canned, as I still don't seem them in Linus' tree. But just for the record, the file lists seem to be somewhat sort. I'm not sure exactly what the criteria is, but for starters, shouldn't all the architecture specific files that only contain kexec or kdump code be in there too? -- Horms H: http://www.vergenet.net/~horms/ W: http://www.valinux.co.jp/en/ - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [275/2many] MAINTAINERS - KDUMP
On Wed, 2007-10-17 at 11:19 +0900, Simon Horman wrote: I take it that these changes got shelved or canned, as I still don't seem them in Linus' tree. I have all the changes kept up-to-date. I still hope to get some variant into a future release. But just for the record, the file lists seem to be somewhat sort. I'm not sure exactly what the criteria is, but for starters, shouldn't all the architecture specific files that only contain kexec or kdump code be in there too? If one of the maintainers, Vivek Goyal or Haren Myneni, cared to improve the kdump list of files, I'd happily accept it. My maintainer entry for kdump is: KDUMP P: Vivek Goyal M: [EMAIL PROTECTED] P: Haren Myneni M: [EMAIL PROTECTED] L: [EMAIL PROTECTED] L: linux-kernel@vger.kernel.org W: http://lse.sourceforge.net/kdump/ S: Maintained F: Documentation/kdump and if Eric Biederman wants to improve kexec: KEXEC P: Eric Biederman M: [EMAIL PROTECTED] W: http://www.xmission.com/~ebiederm/files/kexec/ L: linux-kernel@vger.kernel.org L: [EMAIL PROTECTED] S: Maintained F: include/linux/kexec.h F: kernel/kexec.c - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [275/2many] MAINTAINERS - KDUMP
On Tue, 16 Oct 2007 19:45:34 -0700 Joe Perches [EMAIL PROTECTED] wrote: If one of the maintainers, Vivek Goyal or Haren Myneni, cared to improve the kdump list of files, I'd happily accept it. meh. Bug-reporters only manage to cc the right mailing list 10% of the time even when it's utterly obvious which subsystem went splat. I wouldn't worry about fine details such as this. Anyway, everyone just sends stuff to the great kernel routing service (ie: me) for the traditional forward-and-ignore treatment. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [275/2many] MAINTAINERS - KDUMP
On Tue, Oct 16, 2007 at 07:45:34PM -0700, Joe Perches wrote: On Wed, 2007-10-17 at 11:19 +0900, Simon Horman wrote: I take it that these changes got shelved or canned, as I still don't seem them in Linus' tree. I have all the changes kept up-to-date. I still hope to get some variant into a future release. But just for the record, the file lists seem to be somewhat sort. I'm not sure exactly what the criteria is, but for starters, shouldn't all the architecture specific files that only contain kexec or kdump code be in there too? If one of the maintainers, Vivek Goyal or Haren Myneni, cared to improve the kdump list of files, I'd happily accept it. Understood. I'm happy to make a start on that. Do you have a criteria for including files. Are they files that only apply to KEXEC/KDUMP, or files that have KEXEC/KDUMP code and other code? My maintainer entry for kdump is: KDUMP P:Vivek Goyal M:[EMAIL PROTECTED] P:Haren Myneni M:[EMAIL PROTECTED] L:[EMAIL PROTECTED] L:linux-kernel@vger.kernel.org W:http://lse.sourceforge.net/kdump/ S:Maintained F:Documentation/kdump and if Eric Biederman wants to improve kexec: KEXEC P:Eric Biederman M:[EMAIL PROTECTED] W:http://www.xmission.com/~ebiederm/files/kexec/ L:linux-kernel@vger.kernel.org L:[EMAIL PROTECTED] S:Maintained F:include/linux/kexec.h F:kernel/kexec.c ___ kexec mailing list [EMAIL PROTECTED] http://lists.infradead.org/mailman/listinfo/kexec -- Horms H: http://www.vergenet.net/~horms/ W: http://www.valinux.co.jp/en/ - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [275/2many] MAINTAINERS - KDUMP
On Wed, 2007-10-17 at 12:48 +0900, Simon Horman wrote: Do you have a criteria for including files. A file or file pattern specific to a maintained subsystem. Any time a subsystem file pattern matches a file, maintainers would be cc'd. The matching is non-exclusive. Multiple subsystems can include the same file pattern. For KDUMP, maybe a file pattern should be: F: arch/*/kernel/crash_dump.c F: include/linux/crash_dump.h Are they files that only apply to KEXEC/KDUMP, or files that have KEXEC/KDUMP code and other code? I think it should be files specific to KDUMP and not files shared with other subsystems but perhaps it's maintainer taste. If the files patterns are not specific to kdump, the kdump maintainers will be cc'd on patches that change files where kdump functions aren't modified. The list of files that include crash_dump.h is pretty long. $ grep -P -l -r --include=*.[ch] crash_dump.h * arch/i386/kernel/crash_dump.c arch/i386/kernel/setup.c arch/ia64/hp/common/sba_iommu.c arch/ia64/kernel/crash.c arch/ia64/kernel/setup.c arch/powerpc/kernel/crash.c arch/powerpc/kernel/crash_dump.c arch/sh/kernel/crash_dump.c arch/x86_64/kernel/crash_dump.c arch/x86_64/kernel/setup.c drivers/char/mem.c fs/proc/proc_misc.c fs/proc/vmcore.c The list of files that use CONFIG_CRASH_DUMP is also pretty long and seemingly unrelated. $ grep -P -l -r --include=*.[ch] CONFIG_CRASH_DUMP * arch/i386/kernel/apic.c arch/i386/kernel/e820.c arch/ia64/hp/common/sba_iommu.c arch/ia64/kernel/efi.c arch/powerpc/kernel/iommu.c arch/powerpc/platforms/cell/ras.c arch/powerpc/platforms/pseries/iommu.c arch/x86_64/kernel/e820.c drivers/char/mem.c include/asm-powerpc/kdump.h include/linux/bootmem.h include/linux/crash_dump.h mm/bootmem.c - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
