Re: [PATCH] wm831x-dcdc: fix coccinelle warnings of missing IRQF_ONESHOT
On Fri, Aug 10, 2012 at 08:58:24AM +0800, Feng Tang wrote: > From: Fengguang Wu > > /c/kernel-tests/src/linux/drivers/regulator/wm831x-dcdc.c:829:7-27: ERROR: > Threaded IRQ with no primary handler requested without IRQF_ONESHOT > /c/kernel-tests/src/linux/drivers/regulator/wm831x-dcdc.c:695:7-27: ERROR: > Threaded IRQ with no primary handler requested without IRQF_ONESHOT > /c/kernel-tests/src/linux/drivers/regulator/wm831x-dcdc.c:533:7-27: ERROR: > Threaded IRQ with no primary handler requested without IRQF_ONESHOT > /c/kernel-tests/src/linux/drivers/regulator/wm831x-dcdc.c:542:7-27: ERROR: > Threaded IRQ with no primary handler requested without IRQF_ONESHOT > Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci > Make sure threaded IRQs without a primary handler are always request with > IRQF_ONESHOT This is actually a false positive - _ONESHOT is only needed for interrupts without a primary handler if the interrupt controller is not threaded. For this driver (and most of the other wm831x drivers, as well as many other MFDs) we are guaranteed that the primary handler can never be called. It's not going to hurt, though. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] wm831x-dcdc: fix coccinelle warnings of missing IRQF_ONESHOT
On Fri, Aug 10, 2012 at 08:58:24AM +0800, Feng Tang wrote: From: Fengguang Wu fengguang...@intel.com /c/kernel-tests/src/linux/drivers/regulator/wm831x-dcdc.c:829:7-27: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT /c/kernel-tests/src/linux/drivers/regulator/wm831x-dcdc.c:695:7-27: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT /c/kernel-tests/src/linux/drivers/regulator/wm831x-dcdc.c:533:7-27: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT /c/kernel-tests/src/linux/drivers/regulator/wm831x-dcdc.c:542:7-27: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci Make sure threaded IRQs without a primary handler are always request with IRQF_ONESHOT This is actually a false positive - _ONESHOT is only needed for interrupts without a primary handler if the interrupt controller is not threaded. For this driver (and most of the other wm831x drivers, as well as many other MFDs) we are guaranteed that the primary handler can never be called. It's not going to hurt, though. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
