Re: [PATCH 1/2] sched/debug: Inform the number of rt/dl task that can migrate

2017-06-22 Thread Daniel Bristot de Oliveira 
On 06/22/2017 11:29 AM, Ingo Molnar wrote:
> Note that this patch breaks in various cross-builds - here's the Alpha 
> defconfig 
> build:
> 
> /home/mingo/tip/kernel/sched/debug.c: In function 'print_rt_rq':
> /home/mingo/tip/kernel/sched/debug.c:556:60: error: 'struct rt_rq' has no 
> member 
> named 'rt_nr_migratory'
>   SEQ_printf(m, "  .%-30s: %lu\n", #x, (unsigned long)(rt_rq->x))
> ^
> /home/mingo/tip/kernel/sched/debug.c:33:17: note: in definition of macro 
> 'SEQ_printf'
>seq_printf(m, x);  \
> ...

Oops...

The rt_nr_migratory is conditioned to:

#ifdef CONFIG_SMP

Sorry for the miss attention, I will fix this.

-- Daniel

Re: [PATCH 1/2] sched/debug: Inform the number of rt/dl task that can migrate

2017-06-22 Thread Daniel Bristot de Oliveira 
On 06/22/2017 11:29 AM, Ingo Molnar wrote:
> Note that this patch breaks in various cross-builds - here's the Alpha 
> defconfig 
> build:
> 
> /home/mingo/tip/kernel/sched/debug.c: In function 'print_rt_rq':
> /home/mingo/tip/kernel/sched/debug.c:556:60: error: 'struct rt_rq' has no 
> member 
> named 'rt_nr_migratory'
>   SEQ_printf(m, "  .%-30s: %lu\n", #x, (unsigned long)(rt_rq->x))
> ^
> /home/mingo/tip/kernel/sched/debug.c:33:17: note: in definition of macro 
> 'SEQ_printf'
>seq_printf(m, x);  \
> ...

Oops...

The rt_nr_migratory is conditioned to:

#ifdef CONFIG_SMP

Sorry for the miss attention, I will fix this.

-- Daniel

Re: [PATCH 1/2] sched/debug: Inform the number of rt/dl task that can migrate

2017-06-22 Thread Ingo Molnar 

* Daniel Bristot de Oliveira  wrote:

> Add the value of the rt_rq.rt_nr_migratory and dl_rq.dl_nr_migratory
> to the sched_debug output, for instance:
> 
> rt_rq[0]:
>   .rt_nr_running : 2
>   .rt_nr_migratory   : 1 <--- Like this
>   .rt_throttled  : 0
>   .rt_time   : 828.645877
>   .rt_runtime: 1000.00
> 
> This is useful to debug problems related to the dl/rt schedulers.
> 
> This also fixes the format of some variables, that were unsigned, rather
> than signed.
> 
> [ I am sending this patch to be able to demonstrate   ]
> [ the problem in the kernel-rt, however, this patch can   ]
> [ be merged in the vanilla kernel, if people decide it]
> [ is worth having it. ]

Note that this patch breaks in various cross-builds - here's the Alpha 
defconfig 
build:

/home/mingo/tip/kernel/sched/debug.c: In function 'print_rt_rq':
/home/mingo/tip/kernel/sched/debug.c:556:60: error: 'struct rt_rq' has no 
member 
named 'rt_nr_migratory'
  SEQ_printf(m, "  .%-30s: %lu\n", #x, (unsigned long)(rt_rq->x))
^
/home/mingo/tip/kernel/sched/debug.c:33:17: note: in definition of macro 
'SEQ_printf'
   seq_printf(m, x);  \
...

Thanks,

Ingo

Re: [PATCH 1/2] sched/debug: Inform the number of rt/dl task that can migrate

2017-06-22 Thread Ingo Molnar 

* Daniel Bristot de Oliveira  wrote:

> Add the value of the rt_rq.rt_nr_migratory and dl_rq.dl_nr_migratory
> to the sched_debug output, for instance:
> 
> rt_rq[0]:
>   .rt_nr_running : 2
>   .rt_nr_migratory   : 1 <--- Like this
>   .rt_throttled  : 0
>   .rt_time   : 828.645877
>   .rt_runtime: 1000.00
> 
> This is useful to debug problems related to the dl/rt schedulers.
> 
> This also fixes the format of some variables, that were unsigned, rather
> than signed.
> 
> [ I am sending this patch to be able to demonstrate   ]
> [ the problem in the kernel-rt, however, this patch can   ]
> [ be merged in the vanilla kernel, if people decide it]
> [ is worth having it. ]

Note that this patch breaks in various cross-builds - here's the Alpha 
defconfig 
build:

/home/mingo/tip/kernel/sched/debug.c: In function 'print_rt_rq':
/home/mingo/tip/kernel/sched/debug.c:556:60: error: 'struct rt_rq' has no 
member 
named 'rt_nr_migratory'
  SEQ_printf(m, "  .%-30s: %lu\n", #x, (unsigned long)(rt_rq->x))
^
/home/mingo/tip/kernel/sched/debug.c:33:17: note: in definition of macro 
'SEQ_printf'
   seq_printf(m, x);  \
...

Thanks,

Ingo