Re: [PATCH 7/8] Kconfig: silicon backplane dependency.
On Monday 23 April 2007 13:48, Arnd Bergmann wrote: > On Monday 23 April 2007, Martin Schwidefsky wrote: > > > > > Isn't B44 already behind a WIRELESS or IEEE80211 or similar option that > > > can't be selected on s390? > > > > No, the option can be found in drivers/net/Kconfig under menu "Ethernet > > (10 or 100Mbit)". > > Ah, I was confusing it with b43. > > Depends on HAS_IOMEM sounds good then. I'd prefer to make it > 'depends on SSB' instead of 'select SSB', but I don't want to get into > that argument ;-) No, don't. Add depends on to SSB and B44. -- Greetings Michael. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 7/8] Kconfig: silicon backplane dependency.
On Monday 23 April 2007, Martin Schwidefsky wrote: > > > Isn't B44 already behind a WIRELESS or IEEE80211 or similar option that > > can't be selected on s390? > > No, the option can be found in drivers/net/Kconfig under menu "Ethernet > (10 or 100Mbit)". Ah, I was confusing it with b43. Depends on HAS_IOMEM sounds good then. I'd prefer to make it 'depends on SSB' instead of 'select SSB', but I don't want to get into that argument ;-) Arnd <>< - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 7/8] Kconfig: silicon backplane dependency.
On Mon, 2007-04-23 at 13:22 +0200, Arnd Bergmann wrote: > > The current Kconfig code does not check all select statements if they > > can be enabled before allowing the config option that does the select. > > So the rule for using select statements is that the depends line of the > > config option that selects another config option needs to be at least as > > restrictive as the depends line of the selected option. Hence I'll add > > the HAS_IOMEM depends to B44 as well. Okay ? > > Isn't B44 already behind a WIRELESS or IEEE80211 or similar option that > can't be selected on s390? No, the option can be found in drivers/net/Kconfig under menu "Ethernet (10 or 100Mbit)". -- blue skies, IBM Deutschland Entwicklung GmbH MartinVorsitzender des Aufsichtsrats: Johann Weihen Geschäftsführung: Herbert Kircher Martin Schwidefsky Sitz der Gesellschaft: Böblingen Linux on zSeries Registergericht: Amtsgericht Stuttgart, Development HRB 243294 "Reality continues to ruin my life." - Calvin. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 7/8] Kconfig: silicon backplane dependency.
On Monday 23 April 2007, Martin Schwidefsky wrote: > The current Kconfig code does not check all select statements if they > can be enabled before allowing the config option that does the select. > So the rule for using select statements is that the depends line of the > config option that selects another config option needs to be at least as > restrictive as the depends line of the selected option. Hence I'll add > the HAS_IOMEM depends to B44 as well. Okay ? Isn't B44 already behind a WIRELESS or IEEE80211 or similar option that can't be selected on s390? Arnd <>< - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 7/8] Kconfig: silicon backplane dependency.
On Sun, 2007-04-22 at 11:46 +0200, Michael Buesch wrote: > > > No, this doesn't look right. There are other devices that come with > > > SiliconBackplane but are not PCI or PCMCIA style devices. > > > > Yes, Michael already told me about that. The current solution is to use > > !S390, could we use HAS_IOMEM instead ? > > I'd think either should be fine. I will use HAS_IOMEM then. The oddity with the select statement still exists though. I have to add the "depends on HAS_IOMEM" to SSB and B44. If I just add it to SSB then the config option for B44 exists for s390 and you can enable it. The select statement will then enable SSB as well (.config contains CONFIG_SSB=y for allyesconfig). This is in contradiction to the depends statement since HAS_IOMEM=n on s390. The current Kconfig code does not check all select statements if they can be enabled before allowing the config option that does the select. So the rule for using select statements is that the depends line of the config option that selects another config option needs to be at least as restrictive as the depends line of the selected option. Hence I'll add the HAS_IOMEM depends to B44 as well. Okay ? -- blue skies, IBM Deutschland Entwicklung GmbH MartinVorsitzender des Aufsichtsrats: Johann Weihen Geschäftsführung: Herbert Kircher Martin Schwidefsky Sitz der Gesellschaft: Böblingen Linux on zSeries Registergericht: Amtsgericht Stuttgart, Development HRB 243294 "Reality continues to ruin my life." - Calvin. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 7/8] Kconfig: silicon backplane dependency.
On Sun, 2007-04-22 at 11:46 +0200, Michael Buesch wrote: No, this doesn't look right. There are other devices that come with SiliconBackplane but are not PCI or PCMCIA style devices. Yes, Michael already told me about that. The current solution is to use !S390, could we use HAS_IOMEM instead ? I'd think either should be fine. I will use HAS_IOMEM then. The oddity with the select statement still exists though. I have to add the depends on HAS_IOMEM to SSB and B44. If I just add it to SSB then the config option for B44 exists for s390 and you can enable it. The select statement will then enable SSB as well (.config contains CONFIG_SSB=y for allyesconfig). This is in contradiction to the depends statement since HAS_IOMEM=n on s390. The current Kconfig code does not check all select statements if they can be enabled before allowing the config option that does the select. So the rule for using select statements is that the depends line of the config option that selects another config option needs to be at least as restrictive as the depends line of the selected option. Hence I'll add the HAS_IOMEM depends to B44 as well. Okay ? -- blue skies, IBM Deutschland Entwicklung GmbH MartinVorsitzender des Aufsichtsrats: Johann Weihen Geschäftsführung: Herbert Kircher Martin Schwidefsky Sitz der Gesellschaft: Böblingen Linux on zSeries Registergericht: Amtsgericht Stuttgart, Development HRB 243294 Reality continues to ruin my life. - Calvin. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 7/8] Kconfig: silicon backplane dependency.
On Monday 23 April 2007, Martin Schwidefsky wrote: The current Kconfig code does not check all select statements if they can be enabled before allowing the config option that does the select. So the rule for using select statements is that the depends line of the config option that selects another config option needs to be at least as restrictive as the depends line of the selected option. Hence I'll add the HAS_IOMEM depends to B44 as well. Okay ? Isn't B44 already behind a WIRELESS or IEEE80211 or similar option that can't be selected on s390? Arnd - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 7/8] Kconfig: silicon backplane dependency.
On Mon, 2007-04-23 at 13:22 +0200, Arnd Bergmann wrote: The current Kconfig code does not check all select statements if they can be enabled before allowing the config option that does the select. So the rule for using select statements is that the depends line of the config option that selects another config option needs to be at least as restrictive as the depends line of the selected option. Hence I'll add the HAS_IOMEM depends to B44 as well. Okay ? Isn't B44 already behind a WIRELESS or IEEE80211 or similar option that can't be selected on s390? No, the option can be found in drivers/net/Kconfig under menu Ethernet (10 or 100Mbit). -- blue skies, IBM Deutschland Entwicklung GmbH MartinVorsitzender des Aufsichtsrats: Johann Weihen Geschäftsführung: Herbert Kircher Martin Schwidefsky Sitz der Gesellschaft: Böblingen Linux on zSeries Registergericht: Amtsgericht Stuttgart, Development HRB 243294 Reality continues to ruin my life. - Calvin. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 7/8] Kconfig: silicon backplane dependency.
On Monday 23 April 2007, Martin Schwidefsky wrote: Isn't B44 already behind a WIRELESS or IEEE80211 or similar option that can't be selected on s390? No, the option can be found in drivers/net/Kconfig under menu Ethernet (10 or 100Mbit). Ah, I was confusing it with b43. Depends on HAS_IOMEM sounds good then. I'd prefer to make it 'depends on SSB' instead of 'select SSB', but I don't want to get into that argument ;-) Arnd - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 7/8] Kconfig: silicon backplane dependency.
On Monday 23 April 2007 13:48, Arnd Bergmann wrote: On Monday 23 April 2007, Martin Schwidefsky wrote: Isn't B44 already behind a WIRELESS or IEEE80211 or similar option that can't be selected on s390? No, the option can be found in drivers/net/Kconfig under menu Ethernet (10 or 100Mbit). Ah, I was confusing it with b43. Depends on HAS_IOMEM sounds good then. I'd prefer to make it 'depends on SSB' instead of 'select SSB', but I don't want to get into that argument ;-) No, don't. Add depends on to SSB and B44. -- Greetings Michael. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 7/8] Kconfig: silicon backplane dependency.
On Sunday 22 April 2007 09:53, Martin Schwidefsky wrote: > On Sun, 2007-04-22 at 01:19 +0200, Arnd Bergmann wrote: > > > diff -urpN linux-2.6/drivers/ssb/Kconfig > > > linux-2.6-patched/drivers/ssb/Kconfig > > > --- linux-2.6/drivers/ssb/Kconfig 2007-04-19 15:24:40.0 > > > +0200 > > > +++ linux-2.6-patched/drivers/ssb/Kconfig 2007-04-19 > > > 15:55:44.0 +0200 > > > @@ -1,4 +1,5 @@ > > > menu "Sonics Silicon Backplane" > > > + depends on PCI || PCMCIA > > > > No, this doesn't look right. There are other devices that come with > > SiliconBackplane but are not PCI or PCMCIA style devices. > > Yes, Michael already told me about that. The current solution is to use > !S390, could we use HAS_IOMEM instead ? I'd think either should be fine. -- Greetings Michael. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 7/8] Kconfig: silicon backplane dependency.
On Sun, 2007-04-22 at 01:19 +0200, Arnd Bergmann wrote: > > diff -urpN linux-2.6/drivers/ssb/Kconfig > > linux-2.6-patched/drivers/ssb/Kconfig > > --- linux-2.6/drivers/ssb/Kconfig 2007-04-19 15:24:40.0 +0200 > > +++ linux-2.6-patched/drivers/ssb/Kconfig 2007-04-19 > > 15:55:44.0 +0200 > > @@ -1,4 +1,5 @@ > > menu "Sonics Silicon Backplane" > > + depends on PCI || PCMCIA > > No, this doesn't look right. There are other devices that come with > SiliconBackplane but are not PCI or PCMCIA style devices. Yes, Michael already told me about that. The current solution is to use !S390, could we use HAS_IOMEM instead ? -- blue skies, IBM Deutschland Entwicklung GmbH MartinVorsitzender des Aufsichtsrats: Johann Weihen Geschäftsführung: Herbert Kircher Martin Schwidefsky Sitz der Gesellschaft: Böblingen Linux on zSeries Registergericht: Amtsgericht Stuttgart, Development HRB 243294 "Reality continues to ruin my life." - Calvin. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 7/8] Kconfig: silicon backplane dependency.
On Sun, 2007-04-22 at 01:19 +0200, Arnd Bergmann wrote: diff -urpN linux-2.6/drivers/ssb/Kconfig linux-2.6-patched/drivers/ssb/Kconfig --- linux-2.6/drivers/ssb/Kconfig 2007-04-19 15:24:40.0 +0200 +++ linux-2.6-patched/drivers/ssb/Kconfig 2007-04-19 15:55:44.0 +0200 @@ -1,4 +1,5 @@ menu Sonics Silicon Backplane + depends on PCI || PCMCIA No, this doesn't look right. There are other devices that come with SiliconBackplane but are not PCI or PCMCIA style devices. Yes, Michael already told me about that. The current solution is to use !S390, could we use HAS_IOMEM instead ? -- blue skies, IBM Deutschland Entwicklung GmbH MartinVorsitzender des Aufsichtsrats: Johann Weihen Geschäftsführung: Herbert Kircher Martin Schwidefsky Sitz der Gesellschaft: Böblingen Linux on zSeries Registergericht: Amtsgericht Stuttgart, Development HRB 243294 Reality continues to ruin my life. - Calvin. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 7/8] Kconfig: silicon backplane dependency.
On Sunday 22 April 2007 09:53, Martin Schwidefsky wrote: On Sun, 2007-04-22 at 01:19 +0200, Arnd Bergmann wrote: diff -urpN linux-2.6/drivers/ssb/Kconfig linux-2.6-patched/drivers/ssb/Kconfig --- linux-2.6/drivers/ssb/Kconfig 2007-04-19 15:24:40.0 +0200 +++ linux-2.6-patched/drivers/ssb/Kconfig 2007-04-19 15:55:44.0 +0200 @@ -1,4 +1,5 @@ menu Sonics Silicon Backplane + depends on PCI || PCMCIA No, this doesn't look right. There are other devices that come with SiliconBackplane but are not PCI or PCMCIA style devices. Yes, Michael already told me about that. The current solution is to use !S390, could we use HAS_IOMEM instead ? I'd think either should be fine. -- Greetings Michael. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 7/8] Kconfig: silicon backplane dependency.
On Friday 20 April 2007, Martin Schwidefsky wrote: > > From: Martin Schwidefsky <[EMAIL PROTECTED]> > > Make the "Sonics Silicon Backplane" menu dependent on the two buses > it can be found on. > Goes on top of git-wireless.patch. > > Cc: Michael Buesch <[EMAIL PROTECTED]> > Cc: John W. Linville <[EMAIL PROTECTED]> > Signed-off-by: Martin Schwidefsky <[EMAIL PROTECTED]> > --- > > drivers/ssb/Kconfig | 1 + > 1 files changed, 1 insertion(+) > > diff -urpN linux-2.6/drivers/ssb/Kconfig linux-2.6-patched/drivers/ssb/Kconfig > --- linux-2.6/drivers/ssb/Kconfig 2007-04-19 15:24:40.0 +0200 > +++ linux-2.6-patched/drivers/ssb/Kconfig 2007-04-19 15:55:44.0 > +0200 > @@ -1,4 +1,5 @@ > menu "Sonics Silicon Backplane" > + depends on PCI || PCMCIA No, this doesn't look right. There are other devices that come with SiliconBackplane but are not PCI or PCMCIA style devices. I'd make this 'depends on MMIO' as well if you add that option. Arnd <>< - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 7/8] Kconfig: silicon backplane dependency.
On Fri, 2007-04-20 at 22:45 +0200, Michael Buesch wrote: > This is wrong. SSB does not depend on PCI or PCMCIA. > SSB can (and does) stay very well on its own feet and > can be the main system bus. > Most Linksys WRT routers work that way. They have no > PCI bus, but a SSB bus instead. > > Nevertheless, I'm not sure what your problem really is. > Does a s390 machine exist with a B44 card? I doubt it. > So what about the following: We simply add > a DEPENDS ON !S390 to both SSB and B44. > I really thing that is the right fix for this. > The patch above is clearly not, as it breaks things for > embedded devices without PCI or PCMCIA bus. Ok, thanks. I will change the patch accordingly. -- blue skies, IBM Deutschland Entwicklung GmbH MartinVorsitzender des Aufsichtsrats: Johann Weihen Geschäftsführung: Herbert Kircher Martin Schwidefsky Sitz der Gesellschaft: Böblingen Linux on zSeries Registergericht: Amtsgericht Stuttgart, Development HRB 243294 "Reality continues to ruin my life." - Calvin. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 7/8] Kconfig: silicon backplane dependency.
On Fri, 2007-04-20 at 22:45 +0200, Michael Buesch wrote: This is wrong. SSB does not depend on PCI or PCMCIA. SSB can (and does) stay very well on its own feet and can be the main system bus. Most Linksys WRT routers work that way. They have no PCI bus, but a SSB bus instead. Nevertheless, I'm not sure what your problem really is. Does a s390 machine exist with a B44 card? I doubt it. So what about the following: We simply add a DEPENDS ON !S390 to both SSB and B44. I really thing that is the right fix for this. The patch above is clearly not, as it breaks things for embedded devices without PCI or PCMCIA bus. Ok, thanks. I will change the patch accordingly. -- blue skies, IBM Deutschland Entwicklung GmbH MartinVorsitzender des Aufsichtsrats: Johann Weihen Geschäftsführung: Herbert Kircher Martin Schwidefsky Sitz der Gesellschaft: Böblingen Linux on zSeries Registergericht: Amtsgericht Stuttgart, Development HRB 243294 Reality continues to ruin my life. - Calvin. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 7/8] Kconfig: silicon backplane dependency.
On Friday 20 April 2007, Martin Schwidefsky wrote: From: Martin Schwidefsky [EMAIL PROTECTED] Make the Sonics Silicon Backplane menu dependent on the two buses it can be found on. Goes on top of git-wireless.patch. Cc: Michael Buesch [EMAIL PROTECTED] Cc: John W. Linville [EMAIL PROTECTED] Signed-off-by: Martin Schwidefsky [EMAIL PROTECTED] --- drivers/ssb/Kconfig | 1 + 1 files changed, 1 insertion(+) diff -urpN linux-2.6/drivers/ssb/Kconfig linux-2.6-patched/drivers/ssb/Kconfig --- linux-2.6/drivers/ssb/Kconfig 2007-04-19 15:24:40.0 +0200 +++ linux-2.6-patched/drivers/ssb/Kconfig 2007-04-19 15:55:44.0 +0200 @@ -1,4 +1,5 @@ menu Sonics Silicon Backplane + depends on PCI || PCMCIA No, this doesn't look right. There are other devices that come with SiliconBackplane but are not PCI or PCMCIA style devices. I'd make this 'depends on MMIO' as well if you add that option. Arnd - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 7/8] Kconfig: silicon backplane dependency.
On Friday 20 April 2007 13:35, Martin Schwidefsky wrote: > From: Martin Schwidefsky <[EMAIL PROTECTED]> > > Make the "Sonics Silicon Backplane" menu dependent on the two buses > it can be found on. > Goes on top of git-wireless.patch. > > Cc: Michael Buesch <[EMAIL PROTECTED]> > Cc: John W. Linville <[EMAIL PROTECTED]> > Signed-off-by: Martin Schwidefsky <[EMAIL PROTECTED]> > --- > > drivers/ssb/Kconfig |1 + > 1 files changed, 1 insertion(+) > > diff -urpN linux-2.6/drivers/ssb/Kconfig linux-2.6-patched/drivers/ssb/Kconfig > --- linux-2.6/drivers/ssb/Kconfig 2007-04-19 15:24:40.0 +0200 > +++ linux-2.6-patched/drivers/ssb/Kconfig 2007-04-19 15:55:44.0 > +0200 > @@ -1,4 +1,5 @@ > menu "Sonics Silicon Backplane" > + depends on PCI || PCMCIA This is wrong. SSB does not depend on PCI or PCMCIA. SSB can (and does) stay very well on its own feet and can be the main system bus. Most Linksys WRT routers work that way. They have no PCI bus, but a SSB bus instead. Nevertheless, I'm not sure what your problem really is. Does a s390 machine exist with a B44 card? I doubt it. So what about the following: We simply add a DEPENDS ON !S390 to both SSB and B44. I really thing that is the right fix for this. The patch above is clearly not, as it breaks things for embedded devices without PCI or PCMCIA bus. -- Greetings Michael. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 7/8] Kconfig: silicon backplane dependency.
On Friday 20 April 2007 13:35, Martin Schwidefsky wrote: From: Martin Schwidefsky [EMAIL PROTECTED] Make the Sonics Silicon Backplane menu dependent on the two buses it can be found on. Goes on top of git-wireless.patch. Cc: Michael Buesch [EMAIL PROTECTED] Cc: John W. Linville [EMAIL PROTECTED] Signed-off-by: Martin Schwidefsky [EMAIL PROTECTED] --- drivers/ssb/Kconfig |1 + 1 files changed, 1 insertion(+) diff -urpN linux-2.6/drivers/ssb/Kconfig linux-2.6-patched/drivers/ssb/Kconfig --- linux-2.6/drivers/ssb/Kconfig 2007-04-19 15:24:40.0 +0200 +++ linux-2.6-patched/drivers/ssb/Kconfig 2007-04-19 15:55:44.0 +0200 @@ -1,4 +1,5 @@ menu Sonics Silicon Backplane + depends on PCI || PCMCIA This is wrong. SSB does not depend on PCI or PCMCIA. SSB can (and does) stay very well on its own feet and can be the main system bus. Most Linksys WRT routers work that way. They have no PCI bus, but a SSB bus instead. Nevertheless, I'm not sure what your problem really is. Does a s390 machine exist with a B44 card? I doubt it. So what about the following: We simply add a DEPENDS ON !S390 to both SSB and B44. I really thing that is the right fix for this. The patch above is clearly not, as it breaks things for embedded devices without PCI or PCMCIA bus. -- Greetings Michael. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/