Re: Keyspan USB PDA adapter && test12pre3 hang
That fixed it. Thanks Greg KH wrote: > Are you using the usb-uhci host driver? > > If so, the following fix from Georg Acher should do the trick: > > - > Replace line 275 (insert_td()) > qh->hw.qh.element = virt_to_bus (new) | UHCI_PTR_TERM; > by > qh->hw.qh.element = virt_to_bus (new) ; > > - > > Let me (and the list) know if this doesn't fix your problem. > > greg k-h > -- = Mohammad A. Haque http://www.haque.net/ [EMAIL PROTECTED] "Alcohol and calculus don't mix. Project Lead Don't drink and derive." --Unknown http://wm.themes.org/ [EMAIL PROTECTED] = - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Keyspan USB PDA adapter && test12pre3 hang
Wed, Nov 29, 2000 at 11:44:20PM -0800
X-Operating-System: Linux 2.2.17-immunix (i686)
On Wed, Nov 29, 2000 at 11:44:20PM -0800, Greg KH wrote:
> If so, the following fix from Georg Acher should do the trick:
>
> -
> Replace line 275 (insert_td())
> qh->hw.qh.element = virt_to_bus (new) | UHCI_PTR_TERM;
> by
> qh->hw.qh.element = virt_to_bus (new) ;
>
> -
Here's the above in patch form to make it easier for people to apply.
greg k-h
--
greg@(kroah|wirex).com
diff -Naur -X dontdiff linux-2.4.0-test12-pre3/drivers/usb/usb-uhci.c
linux-2.4.0-test12-pre3-greg/drivers/usb/usb-uhci.c
--- linux-2.4.0-test12-pre3/drivers/usb/usb-uhci.c Wed Nov 29 23:37:19 2000
+++ linux-2.4.0-test12-pre3-greg/drivers/usb/usb-uhci.c Thu Nov 30 00:17:29 2000
@@ -272,7 +272,7 @@
if (qh == prev ) {
// virgin qh without any tds
- qh->hw.qh.element = virt_to_bus (new) | UHCI_PTR_TERM;
+ qh->hw.qh.element = virt_to_bus (new);
}
else {
// already tds inserted, implicitely remove TERM bit of prev
Re: Keyspan USB PDA adapter test12pre3 hang
Wed, Nov 29, 2000 at 11:44:20PM -0800
X-Operating-System: Linux 2.2.17-immunix (i686)
On Wed, Nov 29, 2000 at 11:44:20PM -0800, Greg KH wrote:
If so, the following fix from Georg Acher should do the trick:
-
Replace line 275 (insert_td())
qh-hw.qh.element = virt_to_bus (new) | UHCI_PTR_TERM;
by
qh-hw.qh.element = virt_to_bus (new) ;
-
Here's the above in patch form to make it easier for people to apply.
greg k-h
--
greg@(kroah|wirex).com
diff -Naur -X dontdiff linux-2.4.0-test12-pre3/drivers/usb/usb-uhci.c
linux-2.4.0-test12-pre3-greg/drivers/usb/usb-uhci.c
--- linux-2.4.0-test12-pre3/drivers/usb/usb-uhci.c Wed Nov 29 23:37:19 2000
+++ linux-2.4.0-test12-pre3-greg/drivers/usb/usb-uhci.c Thu Nov 30 00:17:29 2000
@@ -272,7 +272,7 @@
if (qh == prev ) {
// virgin qh without any tds
- qh-hw.qh.element = virt_to_bus (new) | UHCI_PTR_TERM;
+ qh-hw.qh.element = virt_to_bus (new);
}
else {
// already tds inserted, implicitely remove TERM bit of prev
Re: Keyspan USB PDA adapter test12pre3 hang
That fixed it. Thanks Greg KH wrote: Are you using the usb-uhci host driver? If so, the following fix from Georg Acher should do the trick: - Replace line 275 (insert_td()) qh-hw.qh.element = virt_to_bus (new) | UHCI_PTR_TERM; by qh-hw.qh.element = virt_to_bus (new) ; - Let me (and the list) know if this doesn't fix your problem. greg k-h -- = Mohammad A. Haque http://www.haque.net/ [EMAIL PROTECTED] "Alcohol and calculus don't mix. Project Lead Don't drink and derive." --Unknown http://wm.themes.org/ [EMAIL PROTECTED] = - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Keyspan USB PDA adapter && test12pre3 hang
On Thu, Nov 30, 2000 at 12:53:40AM -0500, Mohammad A. Haque wrote: > Anyone else out there with a Keyspan USB PDA adapter using test12-pre3? > I'm experiencing hangs when I try to send data to my Palm Vx using it. > Locks up the machine hard. No SysRq. No messages. USB serial debug > output doesn't have much either... Are you using the usb-uhci host driver? If so, the following fix from Georg Acher should do the trick: - Replace line 275 (insert_td()) qh->hw.qh.element = virt_to_bus (new) | UHCI_PTR_TERM; by qh->hw.qh.element = virt_to_bus (new) ; - Let me (and the list) know if this doesn't fix your problem. greg k-h -- greg@(kroah|wirex).com http://immunix.org/~greg - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Keyspan USB PDA adapter test12pre3 hang
On Thu, Nov 30, 2000 at 12:53:40AM -0500, Mohammad A. Haque wrote: Anyone else out there with a Keyspan USB PDA adapter using test12-pre3? I'm experiencing hangs when I try to send data to my Palm Vx using it. Locks up the machine hard. No SysRq. No messages. USB serial debug output doesn't have much either... Are you using the usb-uhci host driver? If so, the following fix from Georg Acher should do the trick: - Replace line 275 (insert_td()) qh-hw.qh.element = virt_to_bus (new) | UHCI_PTR_TERM; by qh-hw.qh.element = virt_to_bus (new) ; - Let me (and the list) know if this doesn't fix your problem. greg k-h -- greg@(kroah|wirex).com http://immunix.org/~greg - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
