RE: linux-next: Tree for Aug 29 (mlx5)

2019-08-29 Thread Haiyang Zhang


> -Original Message-
> From: Saeed Mahameed 
> Sent: Thursday, August 29, 2019 4:04 PM
> To: s...@canb.auug.org.au; Eran Ben Elisha ; linux-
> n...@vger.kernel.org; rdun...@infradead.org; Haiyang Zhang
> 
> Cc: linux-kernel@vger.kernel.org; net...@vger.kernel.org; Leon
> Romanovsky 
> Subject: Re: linux-next: Tree for Aug 29 (mlx5)
> 
> On Thu, 2019-08-29 at 21:48 +, Haiyang Zhang wrote:
> > > -Original Message-
> > > From: Saeed Mahameed 
> > > Sent: Thursday, August 29, 2019 2:32 PM
> > > To: s...@canb.auug.org.au; Eran Ben Elisha ;
> > > linux-
> > > n...@vger.kernel.org; rdun...@infradead.org; Haiyang Zhang
> > > 
> > > Cc: linux-kernel@vger.kernel.org; net...@vger.kernel.org; Leon
> > > Romanovsky 
> > > Subject: Re: linux-next: Tree for Aug 29 (mlx5)
> > >
> > > On Thu, 2019-08-29 at 12:55 -0700, Randy Dunlap wrote:
> > > > On 8/29/19 12:54 PM, Randy Dunlap wrote:
> > > > > On 8/29/19 4:08 AM, Stephen Rothwell wrote:
> > > > > > Hi all,
> > > > > >
> > > > > > Changes since 20190828:
> > > > > >
> > > > >
> > > > > on x86_64:
> > > > > when CONFIG_PCI_HYPERV=m
> > > >
> > > > and CONFIG_PCI_HYPERV_INTERFACE=m
> > > >
> > >
> > > Haiyang and Eran, I think CONFIG_PCI_HYPERV_INTERFACE was never
> > > supposed to be a module ? it supposed to provide an always available
> > > interface to drivers ..
> > >
> > > Anyway, maybe we need to imply CONFIG_PCI_HYPERV_INTERFACE in
> mlx5.
> >
> > The symbolic dependency by driver mlx5e,  automatically triggers
> > loading of pci_hyperv_interface module. And this module can be loaded
> > in any platforms.
> >
> 
> This only works when both are modules.
> 
> 
> > Currently, mlx5e driver has #if
> > IS_ENABLED(CONFIG_PCI_HYPERV_INTERFACE)
> > around the code using the interface.
> >
> > I agree --
> > Adding "select PCI_HYPERV_INTERFACE" for mlx5e will clean up these
> > #if's.
> >
> 
> No, not "select", "imply".
> 
> if one wants PCI_HYPERV_INTERFACE off, imply will keep it off for you.

This looks good.

- Haiyang


Re: linux-next: Tree for Aug 29 (mlx5)

2019-08-29 Thread Saeed Mahameed
On Thu, 2019-08-29 at 21:48 +, Haiyang Zhang wrote:
> > -Original Message-
> > From: Saeed Mahameed 
> > Sent: Thursday, August 29, 2019 2:32 PM
> > To: s...@canb.auug.org.au; Eran Ben Elisha ;
> > linux-
> > n...@vger.kernel.org; rdun...@infradead.org; Haiyang Zhang
> > 
> > Cc: linux-kernel@vger.kernel.org; net...@vger.kernel.org; Leon
> > Romanovsky 
> > Subject: Re: linux-next: Tree for Aug 29 (mlx5)
> > 
> > On Thu, 2019-08-29 at 12:55 -0700, Randy Dunlap wrote:
> > > On 8/29/19 12:54 PM, Randy Dunlap wrote:
> > > > On 8/29/19 4:08 AM, Stephen Rothwell wrote:
> > > > > Hi all,
> > > > > 
> > > > > Changes since 20190828:
> > > > > 
> > > > 
> > > > on x86_64:
> > > > when CONFIG_PCI_HYPERV=m
> > > 
> > > and CONFIG_PCI_HYPERV_INTERFACE=m
> > > 
> > 
> > Haiyang and Eran, I think CONFIG_PCI_HYPERV_INTERFACE was never
> > supposed to be a module ? it supposed to provide an always
> > available
> > interface to drivers ..
> > 
> > Anyway, maybe we need to imply CONFIG_PCI_HYPERV_INTERFACE in mlx5.
> 
> The symbolic dependency by driver mlx5e,  automatically triggers
> loading of
> pci_hyperv_interface module. And this module can be loaded in any
> platforms.
> 

This only works when both are modules. 


> Currently, mlx5e driver has #if
> IS_ENABLED(CONFIG_PCI_HYPERV_INTERFACE)
> around the code using the interface.
> 
> I agree --
> Adding "select PCI_HYPERV_INTERFACE" for mlx5e will clean up these
> #if's.
> 

No, not "select", "imply".

if one wants PCI_HYPERV_INTERFACE off, imply will keep it off for you.

> Thanks,
> - Haiyang


RE: linux-next: Tree for Aug 29 (mlx5)

2019-08-29 Thread Haiyang Zhang


> -Original Message-
> From: Saeed Mahameed 
> Sent: Thursday, August 29, 2019 2:32 PM
> To: s...@canb.auug.org.au; Eran Ben Elisha ; linux-
> n...@vger.kernel.org; rdun...@infradead.org; Haiyang Zhang
> 
> Cc: linux-kernel@vger.kernel.org; net...@vger.kernel.org; Leon
> Romanovsky 
> Subject: Re: linux-next: Tree for Aug 29 (mlx5)
> 
> On Thu, 2019-08-29 at 12:55 -0700, Randy Dunlap wrote:
> > On 8/29/19 12:54 PM, Randy Dunlap wrote:
> > > On 8/29/19 4:08 AM, Stephen Rothwell wrote:
> > > > Hi all,
> > > >
> > > > Changes since 20190828:
> > > >
> > >
> > > on x86_64:
> > > when CONFIG_PCI_HYPERV=m
> >
> > and CONFIG_PCI_HYPERV_INTERFACE=m
> >
> 
> Haiyang and Eran, I think CONFIG_PCI_HYPERV_INTERFACE was never
> supposed to be a module ? it supposed to provide an always available
> interface to drivers ..
> 
> Anyway, maybe we need to imply CONFIG_PCI_HYPERV_INTERFACE in mlx5.

The symbolic dependency by driver mlx5e,  automatically triggers loading of
pci_hyperv_interface module. And this module can be loaded in any platforms.

Currently, mlx5e driver has #if IS_ENABLED(CONFIG_PCI_HYPERV_INTERFACE)
around the code using the interface.

I agree --
Adding "select PCI_HYPERV_INTERFACE" for mlx5e will clean up these #if's.

Thanks,
- Haiyang


Re: linux-next: Tree for Aug 29 (mlx5)

2019-08-29 Thread Saeed Mahameed
On Thu, 2019-08-29 at 12:55 -0700, Randy Dunlap wrote:
> On 8/29/19 12:54 PM, Randy Dunlap wrote:
> > On 8/29/19 4:08 AM, Stephen Rothwell wrote:
> > > Hi all,
> > > 
> > > Changes since 20190828:
> > > 
> > 
> > on x86_64:
> > when CONFIG_PCI_HYPERV=m
> 
> and CONFIG_PCI_HYPERV_INTERFACE=m
> 

Haiyang and Eran, I think CONFIG_PCI_HYPERV_INTERFACE was never
supposed to be a module ? it supposed to provide an always available 
interface to drivers .. 

Anyway, maybe we need to imply CONFIG_PCI_HYPERV_INTERFACE in mlx5.

Thanks,
Saeed.
 
> > and mxlx5 is builtin (=y).
> > 
> > ld: drivers/net/ethernet/mellanox/mlx5/core/main.o: in function
> > `mlx5_unload':
> > main.c:(.text+0x5d): undefined reference to `mlx5_hv_vhca_cleanup'
> > ld: drivers/net/ethernet/mellanox/mlx5/core/main.o: in function
> > `mlx5_cleanup_once':
> > main.c:(.text+0x158): undefined reference to `mlx5_hv_vhca_destroy'
> > ld: drivers/net/ethernet/mellanox/mlx5/core/main.o: in function
> > `mlx5_load_one':
> > main.c:(.text+0x4191): undefined reference to `mlx5_hv_vhca_create'
> > ld: main.c:(.text+0x4772): undefined reference to
> > `mlx5_hv_vhca_init'
> > ld: main.c:(.text+0x4b07): undefined reference to
> > `mlx5_hv_vhca_cleanup'
> > 
> > 
> 
> 


Re: linux-next: Tree for Aug 29 (mlx5)

2019-08-29 Thread Randy Dunlap
On 8/29/19 12:54 PM, Randy Dunlap wrote:
> On 8/29/19 4:08 AM, Stephen Rothwell wrote:
>> Hi all,
>>
>> Changes since 20190828:
>>
> 
> 
> on x86_64:
> when CONFIG_PCI_HYPERV=m

and CONFIG_PCI_HYPERV_INTERFACE=m

> and mxlx5 is builtin (=y).
> 
> ld: drivers/net/ethernet/mellanox/mlx5/core/main.o: in function `mlx5_unload':
> main.c:(.text+0x5d): undefined reference to `mlx5_hv_vhca_cleanup'
> ld: drivers/net/ethernet/mellanox/mlx5/core/main.o: in function 
> `mlx5_cleanup_once':
> main.c:(.text+0x158): undefined reference to `mlx5_hv_vhca_destroy'
> ld: drivers/net/ethernet/mellanox/mlx5/core/main.o: in function 
> `mlx5_load_one':
> main.c:(.text+0x4191): undefined reference to `mlx5_hv_vhca_create'
> ld: main.c:(.text+0x4772): undefined reference to `mlx5_hv_vhca_init'
> ld: main.c:(.text+0x4b07): undefined reference to `mlx5_hv_vhca_cleanup'
> 
> 


-- 
~Randy


Re: linux-next: Tree for Aug 29 (mlx5)

2019-08-29 Thread Randy Dunlap
On 8/29/19 4:08 AM, Stephen Rothwell wrote:
> Hi all,
> 
> Changes since 20190828:
> 


on x86_64:
when CONFIG_PCI_HYPERV=m
and mxlx5 is builtin (=y).

ld: drivers/net/ethernet/mellanox/mlx5/core/main.o: in function `mlx5_unload':
main.c:(.text+0x5d): undefined reference to `mlx5_hv_vhca_cleanup'
ld: drivers/net/ethernet/mellanox/mlx5/core/main.o: in function 
`mlx5_cleanup_once':
main.c:(.text+0x158): undefined reference to `mlx5_hv_vhca_destroy'
ld: drivers/net/ethernet/mellanox/mlx5/core/main.o: in function `mlx5_load_one':
main.c:(.text+0x4191): undefined reference to `mlx5_hv_vhca_create'
ld: main.c:(.text+0x4772): undefined reference to `mlx5_hv_vhca_init'
ld: main.c:(.text+0x4b07): undefined reference to `mlx5_hv_vhca_cleanup'


-- 
~Randy


Re: linux-next: Tree for Aug 29

2014-09-02 Thread Tejun Heo
On Mon, Sep 01, 2014 at 04:15:52PM -0500, Christoph Lameter wrote:
> On Mon, 1 Sep 2014, Guenter Roeck wrote:
> 
> > arch/ia64/sn/kernel/setup.c: In function 'sn_cpu_init':
> > arch/ia64/sn/kernel/setup.c:632:13: error: lvalue required as left operand 
> > of assignment
> > make[1]: *** [arch/ia64/sn/kernel/setup.o] Error 1
> > make: *** [arch/ia64/sn/kernel/setup.o] Error 2
> 
> 
> Subject: ia64: sn_nodepda cannot be assigned to after this_cpu conversion. 
> Use __this_cpu_write.
> 
> There must be an explit statement to modify the percpu variable after the 
> conversion of the
> sn_nodpda macro to use this_cpu_read.
> 
> Signed-off-by: Christoph Lameter 

Applied to percpu/for-3.18-consistent-ops.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: linux-next: Tree for Aug 29

2014-09-02 Thread Tejun Heo
On Mon, Sep 01, 2014 at 04:15:52PM -0500, Christoph Lameter wrote:
 On Mon, 1 Sep 2014, Guenter Roeck wrote:
 
  arch/ia64/sn/kernel/setup.c: In function 'sn_cpu_init':
  arch/ia64/sn/kernel/setup.c:632:13: error: lvalue required as left operand 
  of assignment
  make[1]: *** [arch/ia64/sn/kernel/setup.o] Error 1
  make: *** [arch/ia64/sn/kernel/setup.o] Error 2
 
 
 Subject: ia64: sn_nodepda cannot be assigned to after this_cpu conversion. 
 Use __this_cpu_write.
 
 There must be an explit statement to modify the percpu variable after the 
 conversion of the
 sn_nodpda macro to use this_cpu_read.
 
 Signed-off-by: Christoph Lameter c...@linux.com

Applied to percpu/for-3.18-consistent-ops.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: linux-next: Tree for Aug 29

2014-09-01 Thread Guenter Roeck

On 09/01/2014 02:15 PM, Christoph Lameter wrote:

On Mon, 1 Sep 2014, Guenter Roeck wrote:


arch/ia64/sn/kernel/setup.c: In function 'sn_cpu_init':
arch/ia64/sn/kernel/setup.c:632:13: error: lvalue required as left operand of 
assignment
make[1]: *** [arch/ia64/sn/kernel/setup.o] Error 1
make: *** [arch/ia64/sn/kernel/setup.o] Error 2



Subject: ia64: sn_nodepda cannot be assigned to after this_cpu conversion. Use 
__this_cpu_write.

There must be an explit statement to modify the percpu variable after the 
conversion of the
sn_nodpda macro to use this_cpu_read.

Signed-off-by: Christoph Lameter 


FWIW: Compile-tested-by: Guenter Roeck 

Too bad there is no ia64 support in qemu; this could use some "real" testing.

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: linux-next: Tree for Aug 29

2014-09-01 Thread Christoph Lameter
On Mon, 1 Sep 2014, Guenter Roeck wrote:

> arch/ia64/sn/kernel/setup.c: In function 'sn_cpu_init':
> arch/ia64/sn/kernel/setup.c:632:13: error: lvalue required as left operand of 
> assignment
> make[1]: *** [arch/ia64/sn/kernel/setup.o] Error 1
> make: *** [arch/ia64/sn/kernel/setup.o] Error 2


Subject: ia64: sn_nodepda cannot be assigned to after this_cpu conversion. Use 
__this_cpu_write.

There must be an explit statement to modify the percpu variable after the 
conversion of the
sn_nodpda macro to use this_cpu_read.

Signed-off-by: Christoph Lameter 

Index: linux/arch/ia64/sn/kernel/setup.c
===
--- linux.orig/arch/ia64/sn/kernel/setup.c
+++ linux/arch/ia64/sn/kernel/setup.c
@@ -629,7 +629,7 @@ void sn_cpu_init(void)

cnode = nasid_to_cnodeid(nasid);

-   sn_nodepda = nodepdaindr[cnode];
+   __this_cpu_write(__sn_nodepda, nodepdaindr[cnode]);

pda->led_address =
(typeof(pda->led_address)) (LED0 + (slice << LED_CPU_SHIFT));
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: linux-next: Tree for Aug 29

2014-09-01 Thread Guenter Roeck
On Fri, Aug 29, 2014 at 03:07:13PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> I will be on vacation for the next week, so the next linux-next that I
> will release will be next-20140908.  Sorry for the inconvenience.
> 
> Changes since 20140828:
> 
> The staging tree still had its build failure for which I applied a
> fix patch.
> 
> Non-merge commits (relative to Linus' tree): 2327
>  2465 files changed, 66838 insertions(+), 40620 deletions(-)
> 
> 
> 
ia64:defconfig is broken with this build and results in the following error
message.

arch/ia64/sn/kernel/setup.c: In function 'sn_cpu_init':
arch/ia64/sn/kernel/setup.c:632:13: error: lvalue required as left operand of 
assignment
make[1]: *** [arch/ia64/sn/kernel/setup.o] Error 1
make: *** [arch/ia64/sn/kernel/setup.o] Error 2

bisect points to commit 6065a244a039 ('ia64: Replace __get_cpu_var uses').

$ git bisect log
# bad: [d7cf2b3139909a354a71e2885c942e21a60ea062] Add linux-next specific files 
for 20140829
# good: [52addcf9d6669fa439387610bc65c92fa0980cef] Linux 3.17-rc2
git bisect start 'HEAD' 'v3.17-rc2'
# good: [a065408138b1e9876a95c30153087617e9ef56df] Merge remote-tracking branch 
'crypto/master'
git bisect good a065408138b1e9876a95c30153087617e9ef56df
# good: [8032bd58d53bf68cc618ed3c945654d495a3381e] Merge remote-tracking branch 
'xen-tip/linux-next'
git bisect good 8032bd58d53bf68cc618ed3c945654d495a3381e
# bad: [937c09a4fafaa87793584723a9c78070ba1313c7] Merge remote-tracking branch 
'staging/staging-next'
git bisect bad 937c09a4fafaa87793584723a9c78070ba1313c7
# good: [09d6dd7490ee7f1dda926e309df370e28679a71c] staging: comedi: 8255: add a 
comedi_device param to the (*io) callback
git bisect good 09d6dd7490ee7f1dda926e309df370e28679a71c
# bad: [436011f94749fe990ca1fafbdb28d5dc4abe9120] Merge remote-tracking branch 
'regmap/for-next'
git bisect bad 436011f94749fe990ca1fafbdb28d5dc4abe9120
# bad: [0b3fd10cf0cda8f319eae27adffb8b7a45431702] Merge remote-tracking branch 
'workqueues/for-next'
git bisect bad 0b3fd10cf0cda8f319eae27adffb8b7a45431702
# bad: [6065a244a039a23d933e4b803a4e052da2849208] ia64: Replace __get_cpu_var 
uses
git bisect bad 6065a244a039a23d933e4b803a4e052da2849208
# good: [903ceff7ca7b4d80c083a80ee5163b74e9fa359f] net: Replace get_cpu_var 
through this_cpu_ptr
git bisect good 903ceff7ca7b4d80c083a80ee5163b74e9fa359f
# good: [e16321709c8270f9803bbfdb51e5e02235078c7f] uv: Replace __get_cpu_var
git bisect good e16321709c8270f9803bbfdb51e5e02235078c7f
# good: [35898716b4d3382791d219be317faace580b6a41] mips: Replace __get_cpu_var 
uses
git bisect good 35898716b4d3382791d219be317faace580b6a41
# good: [0bf7fcf155160fd483af7ffdc50efd4be96f1c96] s390: cio driver 
&__get_cpu_var replacements
git bisect good 0bf7fcf155160fd483af7ffdc50efd4be96f1c96
# first bad commit: [6065a244a039a23d933e4b803a4e052da2849208] ia64: Replace 
__get_cpu_var uses

Reverting the bad commit fixes the problem.

Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: linux-next: Tree for Aug 29

2014-09-01 Thread Guenter Roeck
On Fri, Aug 29, 2014 at 03:07:13PM +1000, Stephen Rothwell wrote:
 Hi all,
 
 I will be on vacation for the next week, so the next linux-next that I
 will release will be next-20140908.  Sorry for the inconvenience.
 
 Changes since 20140828:
 
 The staging tree still had its build failure for which I applied a
 fix patch.
 
 Non-merge commits (relative to Linus' tree): 2327
  2465 files changed, 66838 insertions(+), 40620 deletions(-)
 
 
 
ia64:defconfig is broken with this build and results in the following error
message.

arch/ia64/sn/kernel/setup.c: In function 'sn_cpu_init':
arch/ia64/sn/kernel/setup.c:632:13: error: lvalue required as left operand of 
assignment
make[1]: *** [arch/ia64/sn/kernel/setup.o] Error 1
make: *** [arch/ia64/sn/kernel/setup.o] Error 2

bisect points to commit 6065a244a039 ('ia64: Replace __get_cpu_var uses').

$ git bisect log
# bad: [d7cf2b3139909a354a71e2885c942e21a60ea062] Add linux-next specific files 
for 20140829
# good: [52addcf9d6669fa439387610bc65c92fa0980cef] Linux 3.17-rc2
git bisect start 'HEAD' 'v3.17-rc2'
# good: [a065408138b1e9876a95c30153087617e9ef56df] Merge remote-tracking branch 
'crypto/master'
git bisect good a065408138b1e9876a95c30153087617e9ef56df
# good: [8032bd58d53bf68cc618ed3c945654d495a3381e] Merge remote-tracking branch 
'xen-tip/linux-next'
git bisect good 8032bd58d53bf68cc618ed3c945654d495a3381e
# bad: [937c09a4fafaa87793584723a9c78070ba1313c7] Merge remote-tracking branch 
'staging/staging-next'
git bisect bad 937c09a4fafaa87793584723a9c78070ba1313c7
# good: [09d6dd7490ee7f1dda926e309df370e28679a71c] staging: comedi: 8255: add a 
comedi_device param to the (*io) callback
git bisect good 09d6dd7490ee7f1dda926e309df370e28679a71c
# bad: [436011f94749fe990ca1fafbdb28d5dc4abe9120] Merge remote-tracking branch 
'regmap/for-next'
git bisect bad 436011f94749fe990ca1fafbdb28d5dc4abe9120
# bad: [0b3fd10cf0cda8f319eae27adffb8b7a45431702] Merge remote-tracking branch 
'workqueues/for-next'
git bisect bad 0b3fd10cf0cda8f319eae27adffb8b7a45431702
# bad: [6065a244a039a23d933e4b803a4e052da2849208] ia64: Replace __get_cpu_var 
uses
git bisect bad 6065a244a039a23d933e4b803a4e052da2849208
# good: [903ceff7ca7b4d80c083a80ee5163b74e9fa359f] net: Replace get_cpu_var 
through this_cpu_ptr
git bisect good 903ceff7ca7b4d80c083a80ee5163b74e9fa359f
# good: [e16321709c8270f9803bbfdb51e5e02235078c7f] uv: Replace __get_cpu_var
git bisect good e16321709c8270f9803bbfdb51e5e02235078c7f
# good: [35898716b4d3382791d219be317faace580b6a41] mips: Replace __get_cpu_var 
uses
git bisect good 35898716b4d3382791d219be317faace580b6a41
# good: [0bf7fcf155160fd483af7ffdc50efd4be96f1c96] s390: cio driver 
__get_cpu_var replacements
git bisect good 0bf7fcf155160fd483af7ffdc50efd4be96f1c96
# first bad commit: [6065a244a039a23d933e4b803a4e052da2849208] ia64: Replace 
__get_cpu_var uses

Reverting the bad commit fixes the problem.

Guenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: linux-next: Tree for Aug 29

2014-09-01 Thread Christoph Lameter
On Mon, 1 Sep 2014, Guenter Roeck wrote:

 arch/ia64/sn/kernel/setup.c: In function 'sn_cpu_init':
 arch/ia64/sn/kernel/setup.c:632:13: error: lvalue required as left operand of 
 assignment
 make[1]: *** [arch/ia64/sn/kernel/setup.o] Error 1
 make: *** [arch/ia64/sn/kernel/setup.o] Error 2


Subject: ia64: sn_nodepda cannot be assigned to after this_cpu conversion. Use 
__this_cpu_write.

There must be an explit statement to modify the percpu variable after the 
conversion of the
sn_nodpda macro to use this_cpu_read.

Signed-off-by: Christoph Lameter c...@linux.com

Index: linux/arch/ia64/sn/kernel/setup.c
===
--- linux.orig/arch/ia64/sn/kernel/setup.c
+++ linux/arch/ia64/sn/kernel/setup.c
@@ -629,7 +629,7 @@ void sn_cpu_init(void)

cnode = nasid_to_cnodeid(nasid);

-   sn_nodepda = nodepdaindr[cnode];
+   __this_cpu_write(__sn_nodepda, nodepdaindr[cnode]);

pda-led_address =
(typeof(pda-led_address)) (LED0 + (slice  LED_CPU_SHIFT));
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: linux-next: Tree for Aug 29

2014-09-01 Thread Guenter Roeck

On 09/01/2014 02:15 PM, Christoph Lameter wrote:

On Mon, 1 Sep 2014, Guenter Roeck wrote:


arch/ia64/sn/kernel/setup.c: In function 'sn_cpu_init':
arch/ia64/sn/kernel/setup.c:632:13: error: lvalue required as left operand of 
assignment
make[1]: *** [arch/ia64/sn/kernel/setup.o] Error 1
make: *** [arch/ia64/sn/kernel/setup.o] Error 2



Subject: ia64: sn_nodepda cannot be assigned to after this_cpu conversion. Use 
__this_cpu_write.

There must be an explit statement to modify the percpu variable after the 
conversion of the
sn_nodpda macro to use this_cpu_read.

Signed-off-by: Christoph Lameter c...@linux.com


FWIW: Compile-tested-by: Guenter Roeck li...@roeck-us.net

Too bad there is no ia64 support in qemu; this could use some real testing.

Guenter

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: linux-next: Tree for Aug 29

2014-08-29 Thread Mark Brown
On Fri, Aug 29, 2014 at 03:07:13PM +1000, Stephen Rothwell wrote:

> I will be on vacation for the next week, so the next linux-next that I
> will release will be next-20140908.  Sorry for the inconvenience.

I'm going to try to cover this with the usual reduced service so
hopefully there should be some builds next week.


signature.asc
Description: Digital signature


Re: linux-next: Tree for Aug 29

2014-08-29 Thread Mark Brown
On Fri, Aug 29, 2014 at 03:07:13PM +1000, Stephen Rothwell wrote:

 I will be on vacation for the next week, so the next linux-next that I
 will release will be next-20140908.  Sorry for the inconvenience.

I'm going to try to cover this with the usual reduced service so
hopefully there should be some builds next week.


signature.asc
Description: Digital signature