Re: linux-next: Fixes tags need some work in the cifs tree
Hi Steve, On Mon, 8 Apr 2019 17:30:20 -0500 Steve French wrote: > > I just fixed these up manually and repushed to cifs-2.6.git for-next Thanks. > I was curious if checkpatch should have flagged this - I reran > checkpatch on the original version of Zhang's patches and it didn't > complain about the spacing (and probably should have). Yeah, I use the attached script to check for these. I was hoping that someone might hack at least some of theses tests into checkpatch, but that hasn't happened yet :-( But, then again, I don't run checkpatch :-) -- Cheers, Stephen Rothwell check_fixes Description: application/shellscript pgp_HoAFhNX2v.pgp Description: OpenPGP digital signature
Re: linux-next: Fixes tags need some work in the cifs tree
I just fixed these up manually and repushed to cifs-2.6.git for-next I was curious if checkpatch should have flagged this - I reran checkpatch on the original version of Zhang's patches and it didn't complain about the spacing (and probably should have). On Mon, Apr 8, 2019 at 4:38 PM Stephen Rothwell wrote: > > Hi all, > > In commit > > 7d672725ba72 ("cifs: Fix lease buffer length error") > > Fixes tags > > Fixes: 9764c02fcbad(SMB3: Add support for multidialect negotiate (SMB2.1 > and later)) > Fixes: d5c7076b772a(smb3: add smb3.1.1 to default dialect list) > > has these problem(s): > > - missing space between the SHA1 and the subject > - missing quotes around the subject > > In commit > > 54492efdd6a2 ("cifs: Fix use-after-free in SMB2_read") > > Fixes tag > > Fixes: eccb4422cf97(smb3: Add ftrace tracepoints for improved SMB3 > debugging) > > has these problem(s): > > - missing space between the SHA1 and the subject > - missing quotes around the subject > > In commit > > 3cc71735cf9f ("cifs: Fix use-after-free in SMB2_write") > > Fixes tag > > Fixes: eccb4422cf97(smb3: Add ftrace tracepoints for improved SMB3 > debugging) > > has these problem(s): > > - missing space between the SHA1 and the subject > - missing quotes around the subject > > -- > Cheers, > Stephen Rothwell -- Thanks, Steve
linux-next: Fixes tags need some work in the cifs tree
Hi all, In commit 7d672725ba72 ("cifs: Fix lease buffer length error") Fixes tags Fixes: 9764c02fcbad(SMB3: Add support for multidialect negotiate (SMB2.1 and later)) Fixes: d5c7076b772a(smb3: add smb3.1.1 to default dialect list) has these problem(s): - missing space between the SHA1 and the subject - missing quotes around the subject In commit 54492efdd6a2 ("cifs: Fix use-after-free in SMB2_read") Fixes tag Fixes: eccb4422cf97(smb3: Add ftrace tracepoints for improved SMB3 debugging) has these problem(s): - missing space between the SHA1 and the subject - missing quotes around the subject In commit 3cc71735cf9f ("cifs: Fix use-after-free in SMB2_write") Fixes tag Fixes: eccb4422cf97(smb3: Add ftrace tracepoints for improved SMB3 debugging) has these problem(s): - missing space between the SHA1 and the subject - missing quotes around the subject -- Cheers, Stephen Rothwell pgpyR2MkkqmzX.pgp Description: OpenPGP digital signature