Re: linux-next: build failure after merge of the final tree (net-next tree related)

2014-03-18 Thread David Miller 
From: Stephen Rothwell 
Date: Tue, 18 Mar 2014 18:27:52 +1100

> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> net/netfilter/nft_hash.c: In function 'nft_hash_tbl_free':
> net/netfilter/nft_hash.c:79:3: error: implicit declaration of function 
> 'vfree' [-Werror=implicit-function-declaration]

I've applied the patch below to fix this, thanks.

> Caused by commit ce6eb0d7c8ec ("netfilter: nft_hash: bug fixes and
> resizing") from the net-next tree.  See Rule 1 in
> Documentation/SubmitChecklist.

This slips through a lot, and would happen less often if core x86
headers didn't bring in vmalloc.h :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2014-03-18 Thread David Miller 
From: Stephen Rothwell 
Date: Mon, 17 Mar 2014 21:21:00 +1100

> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> drivers/net/ethernet/intel/i40evf/built-in.o:(.data+0x1868): multiple 
> definition of `i40e_ptype_lookup'
> drivers/net/ethernet/intel/i40e/built-in.o:(.data+0x3f58): first defined here
> 
> Caused by commit 206812b5fccb ("i40e/i40evf: i40e implementation for
> skb_set_hash") from the net-next tree.
> 
> I applied this patch for today (there is probably a better way):
> 
> From 6964d39f8436eade2cdb0c5236734c579b8b0897 Mon Sep 17 00:00:00 2001
> From: Stephen Rothwell 
> Date: Mon, 17 Mar 2014 21:18:48 +1100
> Subject: [PATCH] i40e/i40evf: i40e implementation for skb_set_hash fix
> 
> Signed-off-by: Stephen Rothwell 

Jeff Kirsher gave me a patch today that fixes this, thanks Stephen.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

linux-next: build failure after merge of the final tree (net-next tree related)

2014-03-18 Thread Stephen Rothwell 
Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

net/netfilter/nft_hash.c: In function 'nft_hash_tbl_free':
net/netfilter/nft_hash.c:79:3: error: implicit declaration of function 'vfree' 
[-Werror=implicit-function-declaration]
   vfree(tbl);
   ^
net/netfilter/nft_hash.c: In function 'nft_hash_tbl_alloc':
net/netfilter/nft_hash.c:92:3: error: implicit declaration of function 
'vzalloc' [-Werror=implicit-function-declaration]
   tbl = vzalloc(size);
   ^
net/netfilter/nft_hash.c:92:7: warning: assignment makes pointer from integer 
without a cast [enabled by default]
   tbl = vzalloc(size);
   ^

Caused by commit ce6eb0d7c8ec ("netfilter: nft_hash: bug fixes and
resizing") from the net-next tree.  See Rule 1 in
Documentation/SubmitChecklist.

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgp19PnRCP17k.pgp
Description: PGP signature

linux-next: build failure after merge of the final tree (net-next tree related)

2014-03-18 Thread Stephen Rothwell 
Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

net/netfilter/nft_hash.c: In function 'nft_hash_tbl_free':
net/netfilter/nft_hash.c:79:3: error: implicit declaration of function 'vfree' 
[-Werror=implicit-function-declaration]
   vfree(tbl);
   ^
net/netfilter/nft_hash.c: In function 'nft_hash_tbl_alloc':
net/netfilter/nft_hash.c:92:3: error: implicit declaration of function 
'vzalloc' [-Werror=implicit-function-declaration]
   tbl = vzalloc(size);
   ^
net/netfilter/nft_hash.c:92:7: warning: assignment makes pointer from integer 
without a cast [enabled by default]
   tbl = vzalloc(size);
   ^

Caused by commit ce6eb0d7c8ec (netfilter: nft_hash: bug fixes and
resizing) from the net-next tree.  See Rule 1 in
Documentation/SubmitChecklist.

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgp19PnRCP17k.pgp
Description: PGP signature

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2014-03-18 Thread David Miller 
From: Stephen Rothwell s...@canb.auug.org.au
Date: Mon, 17 Mar 2014 21:21:00 +1100

 After merging the final tree, today's linux-next build (powerpc
 allyesconfig) failed like this:
 
 drivers/net/ethernet/intel/i40evf/built-in.o:(.data+0x1868): multiple 
 definition of `i40e_ptype_lookup'
 drivers/net/ethernet/intel/i40e/built-in.o:(.data+0x3f58): first defined here
 
 Caused by commit 206812b5fccb (i40e/i40evf: i40e implementation for
 skb_set_hash) from the net-next tree.
 
 I applied this patch for today (there is probably a better way):
 
 From 6964d39f8436eade2cdb0c5236734c579b8b0897 Mon Sep 17 00:00:00 2001
 From: Stephen Rothwell s...@canb.auug.org.au
 Date: Mon, 17 Mar 2014 21:18:48 +1100
 Subject: [PATCH] i40e/i40evf: i40e implementation for skb_set_hash fix
 
 Signed-off-by: Stephen Rothwell s...@canb.auug.org.au

Jeff Kirsher gave me a patch today that fixes this, thanks Stephen.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2014-03-18 Thread David Miller 
From: Stephen Rothwell s...@canb.auug.org.au
Date: Tue, 18 Mar 2014 18:27:52 +1100

 After merging the final tree, today's linux-next build (powerpc
 allyesconfig) failed like this:
 
 net/netfilter/nft_hash.c: In function 'nft_hash_tbl_free':
 net/netfilter/nft_hash.c:79:3: error: implicit declaration of function 
 'vfree' [-Werror=implicit-function-declaration]

I've applied the patch below to fix this, thanks.

 Caused by commit ce6eb0d7c8ec (netfilter: nft_hash: bug fixes and
 resizing) from the net-next tree.  See Rule 1 in
 Documentation/SubmitChecklist.

This slips through a lot, and would happen less often if core x86
headers didn't bring in vmalloc.h :-)
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

linux-next: build failure after merge of the final tree (net-next tree related)

2014-03-17 Thread Stephen Rothwell 
Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/net/ethernet/intel/i40evf/built-in.o:(.data+0x1868): multiple 
definition of `i40e_ptype_lookup'
drivers/net/ethernet/intel/i40e/built-in.o:(.data+0x3f58): first defined here

Caused by commit 206812b5fccb ("i40e/i40evf: i40e implementation for
skb_set_hash") from the net-next tree.

I applied this patch for today (there is probably a better way):

From 6964d39f8436eade2cdb0c5236734c579b8b0897 Mon Sep 17 00:00:00 2001
From: Stephen Rothwell 
Date: Mon, 17 Mar 2014 21:18:48 +1100
Subject: [PATCH] i40e/i40evf: i40e implementation for skb_set_hash fix

Signed-off-by: Stephen Rothwell 
---
 drivers/net/ethernet/intel/i40evf/i40e_common.c| 8 
 drivers/net/ethernet/intel/i40evf/i40e_prototype.h | 4 ++--
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/net/ethernet/intel/i40evf/i40e_common.c 
b/drivers/net/ethernet/intel/i40evf/i40e_common.c
index 78618af271cf..c688a0fc5c29 100644
--- a/drivers/net/ethernet/intel/i40evf/i40e_common.c
+++ b/drivers/net/ethernet/intel/i40evf/i40e_common.c
@@ -160,7 +160,7 @@ i40e_status i40evf_aq_queue_shutdown(struct i40e_hw *hw,
 }
 
 
-/* The i40e_ptype_lookup table is used to convert from the 8-bit ptype in the
+/* The i40evf_ptype_lookup table is used to convert from the 8-bit ptype in the
  * hardware to a bit-field that can be used by SW to more easily determine the
  * packet type.
  *
@@ -173,10 +173,10 @@ i40e_status i40evf_aq_queue_shutdown(struct i40e_hw *hw,
  *
  * Typical work flow:
  *
- * IF NOT i40e_ptype_lookup[ptype].known
+ * IF NOT i40evf_ptype_lookup[ptype].known
  * THEN
  *  Packet is unknown
- * ELSE IF i40e_ptype_lookup[ptype].outer_ip == I40E_RX_PTYPE_OUTER_IP
+ * ELSE IF i40evf_ptype_lookup[ptype].outer_ip == I40E_RX_PTYPE_OUTER_IP
  *  Use the rest of the fields to look at the tunnels, inner protocols, etc
  * ELSE
  *  Use the enum i40e_rx_l2_ptype to decode the packet type
@@ -205,7 +205,7 @@ i40e_status i40evf_aq_queue_shutdown(struct i40e_hw *hw,
 #define I40E_RX_PTYPE_INNER_PROT_TSI40E_RX_PTYPE_INNER_PROT_TIMESYNC
 
 /* Lookup table mapping the HW PTYPE to the bit field for decoding */
-struct i40e_rx_ptype_decoded i40e_ptype_lookup[] = {
+struct i40e_rx_ptype_decoded i40evf_ptype_lookup[] = {
/* L2 Packet types */
I40E_PTT_UNUSED_ENTRY(0),
I40E_PTT(1,  L2, NONE, NOF, NONE, NONE, NOF, NONE, PAY2),
diff --git a/drivers/net/ethernet/intel/i40evf/i40e_prototype.h 
b/drivers/net/ethernet/intel/i40evf/i40e_prototype.h
index 33c99051cc96..862fcdf52675 100644
--- a/drivers/net/ethernet/intel/i40evf/i40e_prototype.h
+++ b/drivers/net/ethernet/intel/i40evf/i40e_prototype.h
@@ -63,11 +63,11 @@ i40e_status i40evf_aq_queue_shutdown(struct i40e_hw *hw,
 
 i40e_status i40e_set_mac_type(struct i40e_hw *hw);
 
-extern struct i40e_rx_ptype_decoded i40e_ptype_lookup[];
+extern struct i40e_rx_ptype_decoded i40evf_ptype_lookup[];
 
 static inline struct i40e_rx_ptype_decoded decode_rx_desc_ptype(u8 ptype)
 {
-   return  i40e_ptype_lookup[ptype];
+   return  i40evf_ptype_lookup[ptype];
 }
 
 /* prototype for functions used for SW locks */
-- 
1.9.0

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgp0KWX4EXtxD.pgp
Description: PGP signature

linux-next: build failure after merge of the final tree (net-next tree related)

2014-03-17 Thread Stephen Rothwell 
Hi all,

After merging the final tree, today's linux-next build (sparc64 defconfig)
failed like this:

drivers/net/ethernet/intel/e1000e/netdev.c:7079:13: error: 'e1000e_pm_suspend' 
undeclared here (not in a function)
drivers/net/ethernet/intel/e1000e/netdev.c:7080:13: error: 'e1000e_pm_resume' 
undeclared here (not in a function)
drivers/net/ethernet/intel/e1000e/netdev.c:7082:11: error: 'e1000e_pm_thaw' 
undeclared here (not in a function)

Caused by commit 2800209994f8 ("e1000e: Refactor PM flows") from the
net-next tree.

I reverted that commit for today (and 63eb48f151b5 "e1000e Refactor of
Runtime Power Management" that conflicts with the revert).

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpDehplBUq5q.pgp
Description: PGP signature

linux-next: build failure after merge of the final tree (net-next tree related)

2014-03-17 Thread Stephen Rothwell 
Hi all,

After merging the final tree, today's linux-next build (sparc64 defconfig)
failed like this:

drivers/net/ethernet/intel/e1000e/netdev.c:7079:13: error: 'e1000e_pm_suspend' 
undeclared here (not in a function)
drivers/net/ethernet/intel/e1000e/netdev.c:7080:13: error: 'e1000e_pm_resume' 
undeclared here (not in a function)
drivers/net/ethernet/intel/e1000e/netdev.c:7082:11: error: 'e1000e_pm_thaw' 
undeclared here (not in a function)

Caused by commit 2800209994f8 (e1000e: Refactor PM flows) from the
net-next tree.

I reverted that commit for today (and 63eb48f151b5 e1000e Refactor of
Runtime Power Management that conflicts with the revert).

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpDehplBUq5q.pgp
Description: PGP signature

linux-next: build failure after merge of the final tree (net-next tree related)

2014-03-17 Thread Stephen Rothwell 
Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/net/ethernet/intel/i40evf/built-in.o:(.data+0x1868): multiple 
definition of `i40e_ptype_lookup'
drivers/net/ethernet/intel/i40e/built-in.o:(.data+0x3f58): first defined here

Caused by commit 206812b5fccb (i40e/i40evf: i40e implementation for
skb_set_hash) from the net-next tree.

I applied this patch for today (there is probably a better way):

From 6964d39f8436eade2cdb0c5236734c579b8b0897 Mon Sep 17 00:00:00 2001
From: Stephen Rothwell s...@canb.auug.org.au
Date: Mon, 17 Mar 2014 21:18:48 +1100
Subject: [PATCH] i40e/i40evf: i40e implementation for skb_set_hash fix

Signed-off-by: Stephen Rothwell s...@canb.auug.org.au
---
 drivers/net/ethernet/intel/i40evf/i40e_common.c| 8 
 drivers/net/ethernet/intel/i40evf/i40e_prototype.h | 4 ++--
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/net/ethernet/intel/i40evf/i40e_common.c 
b/drivers/net/ethernet/intel/i40evf/i40e_common.c
index 78618af271cf..c688a0fc5c29 100644
--- a/drivers/net/ethernet/intel/i40evf/i40e_common.c
+++ b/drivers/net/ethernet/intel/i40evf/i40e_common.c
@@ -160,7 +160,7 @@ i40e_status i40evf_aq_queue_shutdown(struct i40e_hw *hw,
 }
 
 
-/* The i40e_ptype_lookup table is used to convert from the 8-bit ptype in the
+/* The i40evf_ptype_lookup table is used to convert from the 8-bit ptype in the
  * hardware to a bit-field that can be used by SW to more easily determine the
  * packet type.
  *
@@ -173,10 +173,10 @@ i40e_status i40evf_aq_queue_shutdown(struct i40e_hw *hw,
  *
  * Typical work flow:
  *
- * IF NOT i40e_ptype_lookup[ptype].known
+ * IF NOT i40evf_ptype_lookup[ptype].known
  * THEN
  *  Packet is unknown
- * ELSE IF i40e_ptype_lookup[ptype].outer_ip == I40E_RX_PTYPE_OUTER_IP
+ * ELSE IF i40evf_ptype_lookup[ptype].outer_ip == I40E_RX_PTYPE_OUTER_IP
  *  Use the rest of the fields to look at the tunnels, inner protocols, etc
  * ELSE
  *  Use the enum i40e_rx_l2_ptype to decode the packet type
@@ -205,7 +205,7 @@ i40e_status i40evf_aq_queue_shutdown(struct i40e_hw *hw,
 #define I40E_RX_PTYPE_INNER_PROT_TSI40E_RX_PTYPE_INNER_PROT_TIMESYNC
 
 /* Lookup table mapping the HW PTYPE to the bit field for decoding */
-struct i40e_rx_ptype_decoded i40e_ptype_lookup[] = {
+struct i40e_rx_ptype_decoded i40evf_ptype_lookup[] = {
/* L2 Packet types */
I40E_PTT_UNUSED_ENTRY(0),
I40E_PTT(1,  L2, NONE, NOF, NONE, NONE, NOF, NONE, PAY2),
diff --git a/drivers/net/ethernet/intel/i40evf/i40e_prototype.h 
b/drivers/net/ethernet/intel/i40evf/i40e_prototype.h
index 33c99051cc96..862fcdf52675 100644
--- a/drivers/net/ethernet/intel/i40evf/i40e_prototype.h
+++ b/drivers/net/ethernet/intel/i40evf/i40e_prototype.h
@@ -63,11 +63,11 @@ i40e_status i40evf_aq_queue_shutdown(struct i40e_hw *hw,
 
 i40e_status i40e_set_mac_type(struct i40e_hw *hw);
 
-extern struct i40e_rx_ptype_decoded i40e_ptype_lookup[];
+extern struct i40e_rx_ptype_decoded i40evf_ptype_lookup[];
 
 static inline struct i40e_rx_ptype_decoded decode_rx_desc_ptype(u8 ptype)
 {
-   return  i40e_ptype_lookup[ptype];
+   return  i40evf_ptype_lookup[ptype];
 }
 
 /* prototype for functions used for SW locks */
-- 
1.9.0

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgp0KWX4EXtxD.pgp
Description: PGP signature

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2013-09-02 Thread Cong Wang 
On Mon, 2013-09-02 at 19:11 +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> drivers/net/vxlan.c: In function 'vxlan6_xmit_skb':
> drivers/net/vxlan.c:1441:3: error: implicit declaration of function 
> 'csum_ipv6_magic' [-Werror=implicit-function-declaration]
>uh->check = csum_ipv6_magic(saddr, daddr, skb->len,
>^
> 
> Caused by commit e4c7ed415387 ("vxlan: add ipv6 support").
> 
> Please read Rule 1 in Documentation/SubmitChecklist.
> 
> I added the following patch for today:

Hi, Stephen

I sent a same patch this morning:
http://marc.info/?l=linux-netdev=137808763132336=2

Thanks!

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

linux-next: build failure after merge of the final tree (net-next tree related)

2013-09-02 Thread Stephen Rothwell 
Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/net/vxlan.c: In function 'vxlan6_xmit_skb':
drivers/net/vxlan.c:1441:3: error: implicit declaration of function 
'csum_ipv6_magic' [-Werror=implicit-function-declaration]
   uh->check = csum_ipv6_magic(saddr, daddr, skb->len,
   ^

Caused by commit e4c7ed415387 ("vxlan: add ipv6 support").

Please read Rule 1 in Documentation/SubmitChecklist.

I added the following patch for today:

From: Stephen Rothwell 
Date: Mon, 2 Sep 2013 19:04:51 +1000
Subject: [PATCH] vxlan: include the file that declares csum_ipv6_magic

Signed-off-by: Stephen Rothwell 
---
 drivers/net/vxlan.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index 3ffb22d..35c78b3 100644
--- a/drivers/net/vxlan.c
+++ b/drivers/net/vxlan.c
@@ -44,6 +44,7 @@
 #include 
 #include 
 #include 
+#include 
 #endif
 
 #define VXLAN_VERSION  "0.1"
-- 
1.8.4.rc3

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpfl2cvCs3fP.pgp
Description: PGP signature

linux-next: build failure after merge of the final tree (net-next tree related)

2013-09-02 Thread Stephen Rothwell 
Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/net/vxlan.c: In function 'vxlan6_xmit_skb':
drivers/net/vxlan.c:1441:3: error: implicit declaration of function 
'csum_ipv6_magic' [-Werror=implicit-function-declaration]
   uh-check = csum_ipv6_magic(saddr, daddr, skb-len,
   ^

Caused by commit e4c7ed415387 (vxlan: add ipv6 support).

Please read Rule 1 in Documentation/SubmitChecklist.

I added the following patch for today:

From: Stephen Rothwell s...@canb.auug.org.au
Date: Mon, 2 Sep 2013 19:04:51 +1000
Subject: [PATCH] vxlan: include the file that declares csum_ipv6_magic

Signed-off-by: Stephen Rothwell s...@canb.auug.org.au
---
 drivers/net/vxlan.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index 3ffb22d..35c78b3 100644
--- a/drivers/net/vxlan.c
+++ b/drivers/net/vxlan.c
@@ -44,6 +44,7 @@
 #include net/ipv6.h
 #include net/addrconf.h
 #include net/ip6_tunnel.h
+#include net/ip6_checksum.h
 #endif
 
 #define VXLAN_VERSION  0.1
-- 
1.8.4.rc3

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpfl2cvCs3fP.pgp
Description: PGP signature

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2013-09-02 Thread Cong Wang 
On Mon, 2013-09-02 at 19:11 +1000, Stephen Rothwell wrote:
 Hi all,
 
 After merging the final tree, today's linux-next build (powerpc
 allyesconfig) failed like this:
 
 drivers/net/vxlan.c: In function 'vxlan6_xmit_skb':
 drivers/net/vxlan.c:1441:3: error: implicit declaration of function 
 'csum_ipv6_magic' [-Werror=implicit-function-declaration]
uh-check = csum_ipv6_magic(saddr, daddr, skb-len,
^
 
 Caused by commit e4c7ed415387 (vxlan: add ipv6 support).
 
 Please read Rule 1 in Documentation/SubmitChecklist.
 
 I added the following patch for today:

Hi, Stephen

I sent a same patch this morning:
http://marc.info/?l=linux-netdevm=137808763132336w=2

Thanks!

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2013-07-03 Thread David Miller 
From: Stephen Rothwell 
Date: Wed, 3 Jul 2013 17:48:22 +1000

> I cherry-picked the commit 419076f59fc5 ("net: lls fix build with
> allnoconfig") out of tomorrow's net-next tree.  (I am feeling generous
> and noticed that patch being applied :-))

Thank you :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2013-07-03 Thread Eliezer Tamir 


On 03/07/2013 10:48, Stephen Rothwell wrote:

Hi all,

After merging the final tree, today's linux-next build (powerpc
allnoconfig) failed like this:

fs/select.c: In function 'do_select':
fs/select.c:408:2: error: implicit declaration of function 'll_start_time' 
[-Werror=implicit-function-declaration]
   u64 ll_start = ll_start_time(ll_flag);

[..]

Caused by commit 1bc2774d8664 ("net: convert lls to use time_in_range()")
from the net-next tree.

I cherry-picked the commit 419076f59fc5 ("net: lls fix build with
allnoconfig") out of tomorrow's net-next tree.  (I am feeling generous
and noticed that patch being applied :-))


Yes, my bad.
Thank you.

I knew lots of people could get this so I sent out a fix ASAP (at 6AM
my time).

If it's not too much trouble we should add:
Reported-by: kbuild test robot 

-Eliezer
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2013-07-03 Thread Sedat Dilek 
On Wed, Jul 3, 2013 at 9:48 AM, Stephen Rothwell  wrote:
> Hi all,
>
> After merging the final tree, today's linux-next build (powerpc
> allnoconfig) failed like this:
[...]
> Caused by commit 1bc2774d8664 ("net: convert lls to use time_in_range()")
> from the net-next tree.
>
> I cherry-picked the commit 419076f59fc5 ("net: lls fix build with
> allnoconfig") out of tomorrow's net-next tree.  (I am feeling generous
> and noticed that patch being applied :-))
>

/me loves generous coders and shy girls.

- Sedat -

> --
> Cheers,
> Stephen Rothwells...@canb.auug.org.au
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

linux-next: build failure after merge of the final tree (net-next tree related)

2013-07-03 Thread Stephen Rothwell 
Hi all,

After merging the final tree, today's linux-next build (powerpc
allnoconfig) failed like this:

fs/select.c: In function 'do_select':
fs/select.c:408:2: error: implicit declaration of function 'll_start_time' 
[-Werror=implicit-function-declaration]
  u64 ll_start = ll_start_time(ll_flag);
  ^
fs/select.c:409:2: error: implicit declaration of function 'll_run_time' 
[-Werror=implicit-function-declaration]
  u64 ll_time = ll_run_time();
  ^
fs/select.c:504:3: error: too many arguments to function 'can_poll_ll'
   if (ll_flag && can_ll && can_poll_ll(ll_start, ll_time))
   ^
In file included from fs/select.c:31:0:
include/net/ll_poll.h:194:20: note: declared here
 static inline bool can_poll_ll(u64 end_time)
^
fs/select.c: In function 'do_poll':
fs/select.c:826:3: error: too many arguments to function 'can_poll_ll'
   if (ll_flag && can_ll && can_poll_ll(ll_start, ll_time))
   ^
In file included from fs/select.c:31:0:
include/net/ll_poll.h:194:20: note: declared here
 static inline bool can_poll_ll(u64 end_time)
^

Caused by commit 1bc2774d8664 ("net: convert lls to use time_in_range()")
from the net-next tree.

I cherry-picked the commit 419076f59fc5 ("net: lls fix build with
allnoconfig") out of tomorrow's net-next tree.  (I am feeling generous
and noticed that patch being applied :-))

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpLTShvK2udl.pgp
Description: PGP signature

linux-next: build failure after merge of the final tree (net-next tree related)

2013-07-03 Thread Stephen Rothwell 
Hi all,

After merging the final tree, today's linux-next build (powerpc
allnoconfig) failed like this:

fs/select.c: In function 'do_select':
fs/select.c:408:2: error: implicit declaration of function 'll_start_time' 
[-Werror=implicit-function-declaration]
  u64 ll_start = ll_start_time(ll_flag);
  ^
fs/select.c:409:2: error: implicit declaration of function 'll_run_time' 
[-Werror=implicit-function-declaration]
  u64 ll_time = ll_run_time();
  ^
fs/select.c:504:3: error: too many arguments to function 'can_poll_ll'
   if (ll_flag  can_ll  can_poll_ll(ll_start, ll_time))
   ^
In file included from fs/select.c:31:0:
include/net/ll_poll.h:194:20: note: declared here
 static inline bool can_poll_ll(u64 end_time)
^
fs/select.c: In function 'do_poll':
fs/select.c:826:3: error: too many arguments to function 'can_poll_ll'
   if (ll_flag  can_ll  can_poll_ll(ll_start, ll_time))
   ^
In file included from fs/select.c:31:0:
include/net/ll_poll.h:194:20: note: declared here
 static inline bool can_poll_ll(u64 end_time)
^

Caused by commit 1bc2774d8664 (net: convert lls to use time_in_range())
from the net-next tree.

I cherry-picked the commit 419076f59fc5 (net: lls fix build with
allnoconfig) out of tomorrow's net-next tree.  (I am feeling generous
and noticed that patch being applied :-))

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpLTShvK2udl.pgp
Description: PGP signature

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2013-07-03 Thread Sedat Dilek 
On Wed, Jul 3, 2013 at 9:48 AM, Stephen Rothwell s...@canb.auug.org.au wrote:
 Hi all,

 After merging the final tree, today's linux-next build (powerpc
 allnoconfig) failed like this:
[...]
 Caused by commit 1bc2774d8664 (net: convert lls to use time_in_range())
 from the net-next tree.

 I cherry-picked the commit 419076f59fc5 (net: lls fix build with
 allnoconfig) out of tomorrow's net-next tree.  (I am feeling generous
 and noticed that patch being applied :-))


/me loves generous coders and shy girls.

- Sedat -

 --
 Cheers,
 Stephen Rothwells...@canb.auug.org.au
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2013-07-03 Thread Eliezer Tamir 


On 03/07/2013 10:48, Stephen Rothwell wrote:

Hi all,

After merging the final tree, today's linux-next build (powerpc
allnoconfig) failed like this:

fs/select.c: In function 'do_select':
fs/select.c:408:2: error: implicit declaration of function 'll_start_time' 
[-Werror=implicit-function-declaration]
   u64 ll_start = ll_start_time(ll_flag);

[..]

Caused by commit 1bc2774d8664 (net: convert lls to use time_in_range())
from the net-next tree.

I cherry-picked the commit 419076f59fc5 (net: lls fix build with
allnoconfig) out of tomorrow's net-next tree.  (I am feeling generous
and noticed that patch being applied :-))


Yes, my bad.
Thank you.

I knew lots of people could get this so I sent out a fix ASAP (at 6AM
my time).

If it's not too much trouble we should add:
Reported-by: kbuild test robot fengguang...@intel.com

-Eliezer
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2013-07-03 Thread David Miller 
From: Stephen Rothwell s...@canb.auug.org.au
Date: Wed, 3 Jul 2013 17:48:22 +1000

 I cherry-picked the commit 419076f59fc5 (net: lls fix build with
 allnoconfig) out of tomorrow's net-next tree.  (I am feeling generous
 and noticed that patch being applied :-))

Thank you :)
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2013-06-26 Thread David Miller 
From: Alexey Brodkin 
Date: Wed, 26 Jun 2013 08:07:37 +

> On 06/26/2013 11:56 AM, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the final tree, today's linux-next build (powerpc
>> allyesconfig) failed like this:
> []
>> Caused by commit e4f2379db6c6 ("ethernet/arc/arc_emac - Add new driver")
>> from the net-next tree.
>>
>> I have reverted that commit for today.
> 
> I've just sent a patch that fixes reported issues (both errors and 
> warnings).

And I've just applied it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2013-06-26 Thread Alexey Brodkin 
On 06/26/2013 11:56 AM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
[]
> Caused by commit e4f2379db6c6 ("ethernet/arc/arc_emac - Add new driver")
> from the net-next tree.
>
> I have reverted that commit for today.

I've just sent a patch that fixes reported issues (both errors and 
warnings).
===
[PATCH] arc_emac: fix compile-time errors & warnings on PPC64
===
So it could be merged with initial patch.

Or I may send another cumulative re-spin.

What's the best way?

Regards,
Alexey
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

linux-next: build failure after merge of the final tree (net-next tree related)

2013-06-26 Thread Stephen Rothwell 
Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

In file included from arch/powerpc/include/asm/dma-mapping.h:123:0,
 from include/linux/dma-mapping.h:76,
 from include/linux/skbuff.h:33,
 from include/linux/if_ether.h:23,
 from include/linux/etherdevice.h:25,
 from drivers/net/ethernet/arc/emac_main.c:16:
drivers/net/ethernet/arc/emac_main.c: In function 'arc_emac_tx_clean':
include/linux/dma-mapping.h:227:56: error: request for member 'addr' in 
something not a structure or union
 #define dma_unmap_addr(PTR, ADDR_NAME)   ((PTR)->ADDR_NAME)
^
include/asm-generic/dma-mapping-common.h:175:64: note: in definition of macro 
'dma_unmap_single'
 #define dma_unmap_single(d, a, s, r) dma_unmap_single_attrs(d, a, s, r, NULL)
^
drivers/net/ethernet/arc/emac_main.c:174:32: note: in expansion of macro 
'dma_unmap_addr'
   dma_unmap_single(>dev, dma_unmap_addr(_buff, addr),
^
include/linux/dma-mapping.h:229:56: error: request for member 'len' in 
something not a structure or union
 #define dma_unmap_len(PTR, LEN_NAME) ((PTR)->LEN_NAME)
^
include/asm-generic/dma-mapping-common.h:175:67: note: in definition of macro 
'dma_unmap_single'
 #define dma_unmap_single(d, a, s, r) dma_unmap_single_attrs(d, a, s, r, NULL)
   ^
drivers/net/ethernet/arc/emac_main.c:175:6: note: in expansion of macro 
'dma_unmap_len'
  dma_unmap_len(_buff, len), DMA_TO_DEVICE);
  ^
drivers/net/ethernet/arc/emac_main.c: In function 'arc_emac_rx':
include/linux/dma-mapping.h:227:56: error: request for member 'addr' in 
something not a structure or union
 #define dma_unmap_addr(PTR, ADDR_NAME)   ((PTR)->ADDR_NAME)
^
include/asm-generic/dma-mapping-common.h:175:64: note: in definition of macro 
'dma_unmap_single'
 #define dma_unmap_single(d, a, s, r) dma_unmap_single_attrs(d, a, s, r, NULL)
^
drivers/net/ethernet/arc/emac_main.c:243:32: note: in expansion of macro 
'dma_unmap_addr'
   dma_unmap_single(>dev, dma_unmap_addr(_buff, addr),
^
include/linux/dma-mapping.h:229:56: error: request for member 'len' in 
something not a structure or union
 #define dma_unmap_len(PTR, LEN_NAME) ((PTR)->LEN_NAME)
^
include/asm-generic/dma-mapping-common.h:175:67: note: in definition of macro 
'dma_unmap_single'
 #define dma_unmap_single(d, a, s, r) dma_unmap_single_attrs(d, a, s, r, NULL)
   ^
drivers/net/ethernet/arc/emac_main.c:244:6: note: in expansion of macro 
'dma_unmap_len'
  dma_unmap_len(_buff, len), DMA_FROM_DEVICE);
  ^
In file included from include/linux/skbuff.h:33:0,
 from include/linux/if_ether.h:23,
 from include/linux/etherdevice.h:25,
 from drivers/net/ethernet/arc/emac_main.c:16:
include/linux/dma-mapping.h:228:57: error: request for member 'mapping' in 
something not a structure or union
 #define dma_unmap_addr_set(PTR, ADDR_NAME, VAL)  (((PTR)->ADDR_NAME) = (VAL))
 ^
drivers/net/ethernet/arc/emac_main.c:267:3: note: in expansion of macro 
'dma_unmap_addr_set'
   dma_unmap_addr_set(_buff, mapping, addr);
   ^
include/linux/dma-mapping.h:230:57: error: request for member 'len' in 
something not a structure or union
 #define dma_unmap_len_set(PTR, LEN_NAME, VAL)(((PTR)->LEN_NAME) = (VAL))
 ^
drivers/net/ethernet/arc/emac_main.c:268:3: note: in expansion of macro 
'dma_unmap_len_set'
   dma_unmap_len_set(_buff, len, buflen);
   ^
In file included from include/linux/swab.h:4:0,
 from include/uapi/linux/byteorder/big_endian.h:12,
 from include/linux/byteorder/big_endian.h:4,
 from arch/powerpc/include/uapi/asm/byteorder.h:10,
 from include/asm-generic/bitops/le.h:5,
 from arch/powerpc/include/asm/bitops.h:278,
 from include/linux/bitops.h:22,
 from include/linux/kernel.h:10,
 from include/linux/skbuff.h:17,
 from include/linux/if_ether.h:23,
 from include/linux/etherdevice.h:25,
 from drivers/net/ethernet/arc/emac_main.c:16:
include/uapi/linux/swab.h:115:24: warning: cast from pointer to integer of 
different size [-Wpointer-to-int-cast]
  (__builtin_constant_p((__u32)(x)) ? \

linux-next: build failure after merge of the final tree (net-next tree related)

2013-06-26 Thread Stephen Rothwell 
Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

In file included from arch/powerpc/include/asm/dma-mapping.h:123:0,
 from include/linux/dma-mapping.h:76,
 from include/linux/skbuff.h:33,
 from include/linux/if_ether.h:23,
 from include/linux/etherdevice.h:25,
 from drivers/net/ethernet/arc/emac_main.c:16:
drivers/net/ethernet/arc/emac_main.c: In function 'arc_emac_tx_clean':
include/linux/dma-mapping.h:227:56: error: request for member 'addr' in 
something not a structure or union
 #define dma_unmap_addr(PTR, ADDR_NAME)   ((PTR)-ADDR_NAME)
^
include/asm-generic/dma-mapping-common.h:175:64: note: in definition of macro 
'dma_unmap_single'
 #define dma_unmap_single(d, a, s, r) dma_unmap_single_attrs(d, a, s, r, NULL)
^
drivers/net/ethernet/arc/emac_main.c:174:32: note: in expansion of macro 
'dma_unmap_addr'
   dma_unmap_single(ndev-dev, dma_unmap_addr(tx_buff, addr),
^
include/linux/dma-mapping.h:229:56: error: request for member 'len' in 
something not a structure or union
 #define dma_unmap_len(PTR, LEN_NAME) ((PTR)-LEN_NAME)
^
include/asm-generic/dma-mapping-common.h:175:67: note: in definition of macro 
'dma_unmap_single'
 #define dma_unmap_single(d, a, s, r) dma_unmap_single_attrs(d, a, s, r, NULL)
   ^
drivers/net/ethernet/arc/emac_main.c:175:6: note: in expansion of macro 
'dma_unmap_len'
  dma_unmap_len(tx_buff, len), DMA_TO_DEVICE);
  ^
drivers/net/ethernet/arc/emac_main.c: In function 'arc_emac_rx':
include/linux/dma-mapping.h:227:56: error: request for member 'addr' in 
something not a structure or union
 #define dma_unmap_addr(PTR, ADDR_NAME)   ((PTR)-ADDR_NAME)
^
include/asm-generic/dma-mapping-common.h:175:64: note: in definition of macro 
'dma_unmap_single'
 #define dma_unmap_single(d, a, s, r) dma_unmap_single_attrs(d, a, s, r, NULL)
^
drivers/net/ethernet/arc/emac_main.c:243:32: note: in expansion of macro 
'dma_unmap_addr'
   dma_unmap_single(ndev-dev, dma_unmap_addr(rx_buff, addr),
^
include/linux/dma-mapping.h:229:56: error: request for member 'len' in 
something not a structure or union
 #define dma_unmap_len(PTR, LEN_NAME) ((PTR)-LEN_NAME)
^
include/asm-generic/dma-mapping-common.h:175:67: note: in definition of macro 
'dma_unmap_single'
 #define dma_unmap_single(d, a, s, r) dma_unmap_single_attrs(d, a, s, r, NULL)
   ^
drivers/net/ethernet/arc/emac_main.c:244:6: note: in expansion of macro 
'dma_unmap_len'
  dma_unmap_len(rx_buff, len), DMA_FROM_DEVICE);
  ^
In file included from include/linux/skbuff.h:33:0,
 from include/linux/if_ether.h:23,
 from include/linux/etherdevice.h:25,
 from drivers/net/ethernet/arc/emac_main.c:16:
include/linux/dma-mapping.h:228:57: error: request for member 'mapping' in 
something not a structure or union
 #define dma_unmap_addr_set(PTR, ADDR_NAME, VAL)  (((PTR)-ADDR_NAME) = (VAL))
 ^
drivers/net/ethernet/arc/emac_main.c:267:3: note: in expansion of macro 
'dma_unmap_addr_set'
   dma_unmap_addr_set(rx_buff, mapping, addr);
   ^
include/linux/dma-mapping.h:230:57: error: request for member 'len' in 
something not a structure or union
 #define dma_unmap_len_set(PTR, LEN_NAME, VAL)(((PTR)-LEN_NAME) = (VAL))
 ^
drivers/net/ethernet/arc/emac_main.c:268:3: note: in expansion of macro 
'dma_unmap_len_set'
   dma_unmap_len_set(rx_buff, len, buflen);
   ^
In file included from include/linux/swab.h:4:0,
 from include/uapi/linux/byteorder/big_endian.h:12,
 from include/linux/byteorder/big_endian.h:4,
 from arch/powerpc/include/uapi/asm/byteorder.h:10,
 from include/asm-generic/bitops/le.h:5,
 from arch/powerpc/include/asm/bitops.h:278,
 from include/linux/bitops.h:22,
 from include/linux/kernel.h:10,
 from include/linux/skbuff.h:17,
 from include/linux/if_ether.h:23,
 from include/linux/etherdevice.h:25,
 from drivers/net/ethernet/arc/emac_main.c:16:
include/uapi/linux/swab.h:115:24: warning: cast from pointer to integer of 
different size [-Wpointer-to-int-cast]
  (__builtin_constant_p((__u32)(x)) ? \

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2013-06-26 Thread Alexey Brodkin 
On 06/26/2013 11:56 AM, Stephen Rothwell wrote:
 Hi all,

 After merging the final tree, today's linux-next build (powerpc
 allyesconfig) failed like this:
[]
 Caused by commit e4f2379db6c6 (ethernet/arc/arc_emac - Add new driver)
 from the net-next tree.

 I have reverted that commit for today.

I've just sent a patch that fixes reported issues (both errors and 
warnings).
===
[PATCH] arc_emac: fix compile-time errors  warnings on PPC64
===
So it could be merged with initial patch.

Or I may send another cumulative re-spin.

What's the best way?

Regards,
Alexey
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2013-06-26 Thread David Miller 
From: Alexey Brodkin alexey.brod...@synopsys.com
Date: Wed, 26 Jun 2013 08:07:37 +

 On 06/26/2013 11:56 AM, Stephen Rothwell wrote:
 Hi all,

 After merging the final tree, today's linux-next build (powerpc
 allyesconfig) failed like this:
 []
 Caused by commit e4f2379db6c6 (ethernet/arc/arc_emac - Add new driver)
 from the net-next tree.

 I have reverted that commit for today.
 
 I've just sent a patch that fixes reported issues (both errors and 
 warnings).

And I've just applied it.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2013-04-23 Thread David Rientjes 
On Tue, 23 Apr 2013, Stephen Rothwell wrote:

> Hi all,
> 
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> net/netlink/af_netlink.c: In function 'netlink_frame_flush_dcache':
> net/netlink/af_netlink.c:384:40: error: 'NL_MMAP_MSG_HDRLEN' undeclared 
> (first use in this function)
> 
> Caused by commit 9652e931e73b ("netlink: add mmap'ed netlink helper
> functions").  This needed to be build tested on an architecture that has
> ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE set to 1 (like Sparc :-)).
> 

Hijacking this thread since I didn't see the causing patch to be posted to 
lkml.  From linux-next:

net/netlink/af_netlink.c: In function 'netlink_queue_mmaped_skb':
net/netlink/af_netlink.c:663:14: error: incompatible types when assigning to 
type '__u32' from type 'kuid_t'
net/netlink/af_netlink.c:664:14: error: incompatible types when assigning to 
type '__u32' from type 'kgid_t'
net/netlink/af_netlink.c: In function 'netlink_ring_set_copied':
net/netlink/af_netlink.c:693:14: error: incompatible types when assigning to 
type '__u32' from type 'kuid_t'
net/netlink/af_netlink.c:694:14: error: incompatible types when assigning to 
type '__u32' from type 'kgid_t'

for a config with CONFIG_UIDGID_STRICT_TYPE_CHECKS enabled.

Looks like it's coming from f9c2288837ba ("netlink: implement memory 
mapped recvmsg()").  Patrick?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2013-04-23 Thread David Miller 
From: Stephen Rothwell 
Date: Tue, 23 Apr 2013 17:46:18 +1000

> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> net/netlink/af_netlink.c: In function 'netlink_frame_flush_dcache':
> net/netlink/af_netlink.c:384:40: error: 'NL_MMAP_MSG_HDRLEN' undeclared 
> (first use in this function)
> 
> Caused by commit 9652e931e73b ("netlink: add mmap'ed netlink helper
> functions").  This needed to be build tested on an architecture that has
> ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE set to 1 (like Sparc :-)).

Sorry, my Sparcs are busy debugging other things at the moment :-)
> 
> From: Stephen Rothwell 
> Date: Tue, 23 Apr 2013 17:40:35 +1000
> Subject: [PATCH] netlink: fix typo in net/netlink/af_netlink.c
> 
> Signed-off-by: Stephen Rothwell 

Applied, thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

linux-next: build failure after merge of the final tree (net-next tree related)

2013-04-23 Thread Stephen Rothwell 
Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

net/netlink/af_netlink.c: In function 'netlink_frame_flush_dcache':
net/netlink/af_netlink.c:384:40: error: 'NL_MMAP_MSG_HDRLEN' undeclared (first 
use in this function)

Caused by commit 9652e931e73b ("netlink: add mmap'ed netlink helper
functions").  This needed to be build tested on an architecture that has
ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE set to 1 (like Sparc :-)).

I added the following patch for today:

From: Stephen Rothwell 
Date: Tue, 23 Apr 2013 17:40:35 +1000
Subject: [PATCH] netlink: fix typo in net/netlink/af_netlink.c

Signed-off-by: Stephen Rothwell 
---
 net/netlink/af_netlink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
index 2a3e9ba..da5601d 100644
--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -381,7 +381,7 @@ static void netlink_frame_flush_dcache(const struct 
nl_mmap_hdr *hdr)
 
/* First page is flushed through netlink_{get,set}_status */
p_start = pgvec_to_page(hdr + PAGE_SIZE);
-   p_end   = pgvec_to_page((void *)hdr + NL_MMAP_MSG_HDRLEN + hdr->nm_len 
- 1);
+   p_end   = pgvec_to_page((void *)hdr + NL_MMAP_HDRLEN + hdr->nm_len - 1);
while (p_start <= p_end) {
flush_dcache_page(p_start);
p_start++;
-- 
1.8.1

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpLZeIAjRhBj.pgp
Description: PGP signature

linux-next: build failure after merge of the final tree (net-next tree related)

2013-04-23 Thread Stephen Rothwell 
Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

net/netlink/af_netlink.c: In function 'netlink_frame_flush_dcache':
net/netlink/af_netlink.c:384:40: error: 'NL_MMAP_MSG_HDRLEN' undeclared (first 
use in this function)

Caused by commit 9652e931e73b (netlink: add mmap'ed netlink helper
functions).  This needed to be build tested on an architecture that has
ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE set to 1 (like Sparc :-)).

I added the following patch for today:

From: Stephen Rothwell s...@canb.auug.org.au
Date: Tue, 23 Apr 2013 17:40:35 +1000
Subject: [PATCH] netlink: fix typo in net/netlink/af_netlink.c

Signed-off-by: Stephen Rothwell s...@canb.auug.org.au
---
 net/netlink/af_netlink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
index 2a3e9ba..da5601d 100644
--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -381,7 +381,7 @@ static void netlink_frame_flush_dcache(const struct 
nl_mmap_hdr *hdr)
 
/* First page is flushed through netlink_{get,set}_status */
p_start = pgvec_to_page(hdr + PAGE_SIZE);
-   p_end   = pgvec_to_page((void *)hdr + NL_MMAP_MSG_HDRLEN + hdr-nm_len 
- 1);
+   p_end   = pgvec_to_page((void *)hdr + NL_MMAP_HDRLEN + hdr-nm_len - 1);
while (p_start = p_end) {
flush_dcache_page(p_start);
p_start++;
-- 
1.8.1

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpLZeIAjRhBj.pgp
Description: PGP signature

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2013-04-23 Thread David Miller 
From: Stephen Rothwell s...@canb.auug.org.au
Date: Tue, 23 Apr 2013 17:46:18 +1000

 After merging the final tree, today's linux-next build (powerpc
 allyesconfig) failed like this:
 
 net/netlink/af_netlink.c: In function 'netlink_frame_flush_dcache':
 net/netlink/af_netlink.c:384:40: error: 'NL_MMAP_MSG_HDRLEN' undeclared 
 (first use in this function)
 
 Caused by commit 9652e931e73b (netlink: add mmap'ed netlink helper
 functions).  This needed to be build tested on an architecture that has
 ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE set to 1 (like Sparc :-)).

Sorry, my Sparcs are busy debugging other things at the moment :-)
 
 From: Stephen Rothwell s...@canb.auug.org.au
 Date: Tue, 23 Apr 2013 17:40:35 +1000
 Subject: [PATCH] netlink: fix typo in net/netlink/af_netlink.c
 
 Signed-off-by: Stephen Rothwell s...@canb.auug.org.au

Applied, thanks!
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2013-04-23 Thread David Rientjes 
On Tue, 23 Apr 2013, Stephen Rothwell wrote:

 Hi all,
 
 After merging the final tree, today's linux-next build (powerpc
 allyesconfig) failed like this:
 
 net/netlink/af_netlink.c: In function 'netlink_frame_flush_dcache':
 net/netlink/af_netlink.c:384:40: error: 'NL_MMAP_MSG_HDRLEN' undeclared 
 (first use in this function)
 
 Caused by commit 9652e931e73b (netlink: add mmap'ed netlink helper
 functions).  This needed to be build tested on an architecture that has
 ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE set to 1 (like Sparc :-)).
 

Hijacking this thread since I didn't see the causing patch to be posted to 
lkml.  From linux-next:

net/netlink/af_netlink.c: In function 'netlink_queue_mmaped_skb':
net/netlink/af_netlink.c:663:14: error: incompatible types when assigning to 
type '__u32' from type 'kuid_t'
net/netlink/af_netlink.c:664:14: error: incompatible types when assigning to 
type '__u32' from type 'kgid_t'
net/netlink/af_netlink.c: In function 'netlink_ring_set_copied':
net/netlink/af_netlink.c:693:14: error: incompatible types when assigning to 
type '__u32' from type 'kuid_t'
net/netlink/af_netlink.c:694:14: error: incompatible types when assigning to 
type '__u32' from type 'kgid_t'

for a config with CONFIG_UIDGID_STRICT_TYPE_CHECKS enabled.

Looks like it's coming from f9c2288837ba (netlink: implement memory 
mapped recvmsg()).  Patrick?
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2013-04-12 Thread David Miller 
From: Stephen Rothwell 
Date: Fri, 12 Apr 2013 16:00:18 +1000

> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> net/core/netprio_cgroup.c:250:29: error: static declaration of 
> 'net_prio_subsys' follows non-static declaration
> include/linux/cgroup_subsys.h:71:1: note: previous declaration of 
> 'net_prio_subsys' was here
> 
> Caused by commit 763eff57de89 ("netprio_cgroup: make local table static")
> from the net-next tree.
> 
> I have reverted that commit for today.

I've reverted it from net-next too, thanks Stephen.

> /me hates macros that construct symbols ...

/me hates automatic checkers that don't expand macros :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

linux-next: build failure after merge of the final tree (net-next tree related)

2013-04-12 Thread Stephen Rothwell 
Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

net/core/netprio_cgroup.c:250:29: error: static declaration of 
'net_prio_subsys' follows non-static declaration
include/linux/cgroup_subsys.h:71:1: note: previous declaration of 
'net_prio_subsys' was here

Caused by commit 763eff57de89 ("netprio_cgroup: make local table static")
from the net-next tree.

I have reverted that commit for today.

/me hates macros that construct symbols ...

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpyKD9l04mH4.pgp
Description: PGP signature

linux-next: build failure after merge of the final tree (net-next tree related)

2013-04-12 Thread Stephen Rothwell 
Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

net/core/netprio_cgroup.c:250:29: error: static declaration of 
'net_prio_subsys' follows non-static declaration
include/linux/cgroup_subsys.h:71:1: note: previous declaration of 
'net_prio_subsys' was here

Caused by commit 763eff57de89 (netprio_cgroup: make local table static)
from the net-next tree.

I have reverted that commit for today.

/me hates macros that construct symbols ...

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpyKD9l04mH4.pgp
Description: PGP signature

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2013-04-12 Thread David Miller 
From: Stephen Rothwell s...@canb.auug.org.au
Date: Fri, 12 Apr 2013 16:00:18 +1000

 After merging the final tree, today's linux-next build (powerpc
 allyesconfig) failed like this:
 
 net/core/netprio_cgroup.c:250:29: error: static declaration of 
 'net_prio_subsys' follows non-static declaration
 include/linux/cgroup_subsys.h:71:1: note: previous declaration of 
 'net_prio_subsys' was here
 
 Caused by commit 763eff57de89 (netprio_cgroup: make local table static)
 from the net-next tree.
 
 I have reverted that commit for today.

I've reverted it from net-next too, thanks Stephen.

 /me hates macros that construct symbols ...

/me hates automatic checkers that don't expand macros :-)
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2013-03-27 Thread David Miller 
From: Stephen Rothwell 
Date: Thu, 28 Mar 2013 16:04:20 +1100

> Hi all,
> 
> After merging the final tree, today's linux-next build (powerpc
> ppc44x_defconfig) failed like this:
> 
> net/packet/af_packet.c: In function 'packet_sendmsg_spkt':
> net/packet/af_packet.c:1515:2: error: implicit declaration of function 
> 'skb_probe_transport_header' [-Werror=implicit-function-declaration]
> drivers/net/tun.c: In function 'tun_get_user':
> drivers/net/tun.c:1206:2: error: implicit declaration of function 
> 'skb_probe_transport_header' [-Werror=implicit-function-declaration]
> 
> Caused by commit 40893fd0fd4e ("net: switch to use
> skb_probe_transport_header()").  This is a 32 bit build, so that
> "BITS_PER_LONG > 32" is false and so NET_SKBUFF_DATA_USES_OFFSET is not
> defined ... and skb_probe_transport_header() is only defined in an area of
> skbuff.h protected by "#ifdef NET_SKBUFF_DATA_USES_OFFSET"  :-(
> 
> I have reverted that commit for today.

This got fixed about an hour ago :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

linux-next: build failure after merge of the final tree (net-next tree related)

2013-03-27 Thread Stephen Rothwell 
Hi all,

After merging the final tree, today's linux-next build (powerpc
ppc44x_defconfig) failed like this:

net/packet/af_packet.c: In function 'packet_sendmsg_spkt':
net/packet/af_packet.c:1515:2: error: implicit declaration of function 
'skb_probe_transport_header' [-Werror=implicit-function-declaration]
drivers/net/tun.c: In function 'tun_get_user':
drivers/net/tun.c:1206:2: error: implicit declaration of function 
'skb_probe_transport_header' [-Werror=implicit-function-declaration]

Caused by commit 40893fd0fd4e ("net: switch to use
skb_probe_transport_header()").  This is a 32 bit build, so that
"BITS_PER_LONG > 32" is false and so NET_SKBUFF_DATA_USES_OFFSET is not
defined ... and skb_probe_transport_header() is only defined in an area of
skbuff.h protected by "#ifdef NET_SKBUFF_DATA_USES_OFFSET"  :-(

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgp5E6pZjGGBR.pgp
Description: PGP signature

linux-next: build failure after merge of the final tree (net-next tree related)

2013-03-27 Thread Stephen Rothwell 
Hi all,

After merging the final tree, today's linux-next build (powerpc
ppc44x_defconfig) failed like this:

net/packet/af_packet.c: In function 'packet_sendmsg_spkt':
net/packet/af_packet.c:1515:2: error: implicit declaration of function 
'skb_probe_transport_header' [-Werror=implicit-function-declaration]
drivers/net/tun.c: In function 'tun_get_user':
drivers/net/tun.c:1206:2: error: implicit declaration of function 
'skb_probe_transport_header' [-Werror=implicit-function-declaration]

Caused by commit 40893fd0fd4e (net: switch to use
skb_probe_transport_header()).  This is a 32 bit build, so that
BITS_PER_LONG  32 is false and so NET_SKBUFF_DATA_USES_OFFSET is not
defined ... and skb_probe_transport_header() is only defined in an area of
skbuff.h protected by #ifdef NET_SKBUFF_DATA_USES_OFFSET  :-(

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgp5E6pZjGGBR.pgp
Description: PGP signature

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2013-03-27 Thread David Miller 
From: Stephen Rothwell s...@canb.auug.org.au
Date: Thu, 28 Mar 2013 16:04:20 +1100

 Hi all,
 
 After merging the final tree, today's linux-next build (powerpc
 ppc44x_defconfig) failed like this:
 
 net/packet/af_packet.c: In function 'packet_sendmsg_spkt':
 net/packet/af_packet.c:1515:2: error: implicit declaration of function 
 'skb_probe_transport_header' [-Werror=implicit-function-declaration]
 drivers/net/tun.c: In function 'tun_get_user':
 drivers/net/tun.c:1206:2: error: implicit declaration of function 
 'skb_probe_transport_header' [-Werror=implicit-function-declaration]
 
 Caused by commit 40893fd0fd4e (net: switch to use
 skb_probe_transport_header()).  This is a 32 bit build, so that
 BITS_PER_LONG  32 is false and so NET_SKBUFF_DATA_USES_OFFSET is not
 defined ... and skb_probe_transport_header() is only defined in an area of
 skbuff.h protected by #ifdef NET_SKBUFF_DATA_USES_OFFSET  :-(
 
 I have reverted that commit for today.

This got fixed about an hour ago :-)
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2013-01-03 Thread David Miller 
From: Stephen Rothwell 
Date: Thu, 3 Jan 2013 14:23:53 +1100

> From: Stephen Rothwell 
> Date: Thu, 3 Jan 2013 14:19:16 +1100
> Subject: [PATCH] qlcnic: do not duplicate infrastructure functions
> 
> Signed-off-by: Stephen Rothwell 

Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2013-01-03 Thread David Miller 
From: Stephen Rothwell s...@canb.auug.org.au
Date: Thu, 3 Jan 2013 14:23:53 +1100

 From: Stephen Rothwell s...@canb.auug.org.au
 Date: Thu, 3 Jan 2013 14:19:16 +1100
 Subject: [PATCH] qlcnic: do not duplicate infrastructure functions
 
 Signed-off-by: Stephen Rothwell s...@canb.auug.org.au

Applied.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2013-01-02 Thread David Miller 
From: Stephen Rothwell 
Date: Thu, 3 Jan 2013 14:23:53 +1100

> Caused by commit 13159183ec7a ("qlcnic: 83xx base driver") from the
> net-next tree.  Why is this commit adding a function that already exists
> globally?

And this is after I pushed back on this patch series 5 times or so.

You qlogic guys, can you see why I give you such a hard time with
your patch submissions?  Even after I ask you to correct all of the
most obvious problems, there is still garbage like this that shows
up in your changes.

What in the world do I have to do, other than push back on your
submissions even harder, to keep crap like this from happening
in the future?

Tell me.

You, as a group, are the absolute worst networking driver submitters.

This is a real problem because you submit large bodies of code that 1)
nobody wants to review and 2) has a very small user base.  So you
impart an extremely large burdon upon me, in particular, because I'm
the only person that actually reviews your code at all.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

linux-next: build failure after merge of the final tree (net-next tree related)

2013-01-02 Thread Stephen Rothwell 
Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/net/built-in.o: In function `pci_get_domain_bus_and_slot':
(.opd+0x449e8): multiple definition of `pci_get_domain_bus_and_slot'
drivers/pci/built-in.o:(.opd+0x1c98): first defined here

Caused by commit 13159183ec7a ("qlcnic: 83xx base driver") from the
net-next tree.  Why is this commit adding a function that already exists
globally?

I added this patch for today:

From: Stephen Rothwell 
Date: Thu, 3 Jan 2013 14:19:16 +1100
Subject: [PATCH] qlcnic: do not duplicate infrastructure functions

Signed-off-by: Stephen Rothwell 
---
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c |   20 +---
 1 file changed, 1 insertion(+), 19 deletions(-)

diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c 
b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
index e1a3625..3bdb1beae 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
@@ -2,12 +2,6 @@
  * QLogic qlcnic NIC Driver
  * Copyright (c)  2009-2010 QLogic Corporation
  *
- * PCI searching functions pci_get_domain_bus_and_slot & pci_channel_offline
- * Copyright (C) 1993 -- 1997 Drew Eckhardt, Frederic Potter,
- * David Mosberger-Tang
- * Copyright (C) 1997 -- 2000 Martin Mares 
- * Copyright (C) 2003 -- 2004 Greg Kroah-Hartman .
- *
  * See LICENSE.qlcnic for copyright and licensing details.
  */
 
@@ -25,6 +19,7 @@
 #include 
 #include 
 #include 
+#include 
 
 MODULE_DESCRIPTION("QLogic 1/10 GbE Converged/Intelligent Ethernet Driver");
 MODULE_LICENSE("GPL");
@@ -2907,19 +2902,6 @@ reschedule:
qlcnic_schedule_work(adapter, qlcnic_fw_poll_work, FW_POLL_DELAY);
 }
 
-struct pci_dev *pci_get_domain_bus_and_slot(int domain, unsigned int bus,
-   unsigned int devfn)
-{
-   struct pci_dev *dev = NULL;
-
-   while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL) {
-   if (pci_domain_nr(dev->bus) == domain &&
-   (dev->bus->number == bus && dev->devfn == devfn))
-   return dev;
-   }
-   return NULL;
-}
-
 static int qlcnic_is_first_func(struct pci_dev *pdev)
 {
struct pci_dev *oth_pdev;
-- 
1.7.10.280.gaa39

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/


pgpsrL0XEnw8S.pgp
Description: PGP signature

linux-next: build failure after merge of the final tree (net-next tree related)

2013-01-02 Thread Stephen Rothwell 
Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/net/built-in.o: In function `pci_get_domain_bus_and_slot':
(.opd+0x449e8): multiple definition of `pci_get_domain_bus_and_slot'
drivers/pci/built-in.o:(.opd+0x1c98): first defined here

Caused by commit 13159183ec7a (qlcnic: 83xx base driver) from the
net-next tree.  Why is this commit adding a function that already exists
globally?

I added this patch for today:

From: Stephen Rothwell s...@canb.auug.org.au
Date: Thu, 3 Jan 2013 14:19:16 +1100
Subject: [PATCH] qlcnic: do not duplicate infrastructure functions

Signed-off-by: Stephen Rothwell s...@canb.auug.org.au
---
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c |   20 +---
 1 file changed, 1 insertion(+), 19 deletions(-)

diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c 
b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
index e1a3625..3bdb1beae 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
@@ -2,12 +2,6 @@
  * QLogic qlcnic NIC Driver
  * Copyright (c)  2009-2010 QLogic Corporation
  *
- * PCI searching functions pci_get_domain_bus_and_slot  pci_channel_offline
- * Copyright (C) 1993 -- 1997 Drew Eckhardt, Frederic Potter,
- * David Mosberger-Tang
- * Copyright (C) 1997 -- 2000 Martin Mares m...@ucw.cz
- * Copyright (C) 2003 -- 2004 Greg Kroah-Hartman g...@kroah.com.
- *
  * See LICENSE.qlcnic for copyright and licensing details.
  */
 
@@ -25,6 +19,7 @@
 #include linux/inetdevice.h
 #include linux/aer.h
 #include linux/log2.h
+#include linux/pci.h
 
 MODULE_DESCRIPTION(QLogic 1/10 GbE Converged/Intelligent Ethernet Driver);
 MODULE_LICENSE(GPL);
@@ -2907,19 +2902,6 @@ reschedule:
qlcnic_schedule_work(adapter, qlcnic_fw_poll_work, FW_POLL_DELAY);
 }
 
-struct pci_dev *pci_get_domain_bus_and_slot(int domain, unsigned int bus,
-   unsigned int devfn)
-{
-   struct pci_dev *dev = NULL;
-
-   while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL) {
-   if (pci_domain_nr(dev-bus) == domain 
-   (dev-bus-number == bus  dev-devfn == devfn))
-   return dev;
-   }
-   return NULL;
-}
-
 static int qlcnic_is_first_func(struct pci_dev *pdev)
 {
struct pci_dev *oth_pdev;
-- 
1.7.10.280.gaa39

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/


pgpsrL0XEnw8S.pgp
Description: PGP signature

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2013-01-02 Thread David Miller 
From: Stephen Rothwell s...@canb.auug.org.au
Date: Thu, 3 Jan 2013 14:23:53 +1100

 Caused by commit 13159183ec7a (qlcnic: 83xx base driver) from the
 net-next tree.  Why is this commit adding a function that already exists
 globally?

And this is after I pushed back on this patch series 5 times or so.

You qlogic guys, can you see why I give you such a hard time with
your patch submissions?  Even after I ask you to correct all of the
most obvious problems, there is still garbage like this that shows
up in your changes.

What in the world do I have to do, other than push back on your
submissions even harder, to keep crap like this from happening
in the future?

Tell me.

You, as a group, are the absolute worst networking driver submitters.

This is a real problem because you submit large bodies of code that 1)
nobody wants to review and 2) has a very small user base.  So you
impart an extremely large burdon upon me, in particular, because I'm
the only person that actually reviews your code at all.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2012-09-22 Thread Benjamin Herrenschmidt 
On Sat, 2012-09-22 at 16:00 -0400, David Miller wrote:
> 
> I think I'm going to just end up restricting this driver to X86
> as was originally suggested.

Probably the easiest fix indeed.

> There seems to be no real consistent Kconfig protection for users
> of isa_virt_to_bus() and friends.
> 
> We know that ISA_DMA_API doesn't do it, and ISA doesn't do it either
> as powerpc also allows that to bet set for CHRP and friends.

It's a old mess :-( And not an easy one to untangle...

Cheers,
Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2012-09-22 Thread David Miller 
From: Benjamin Herrenschmidt 
Date: Sat, 22 Sep 2012 07:46:40 +1000

> Right, but on ppc, GFP_DMA is a nop (no separate ZONE_DMA, or rather all
> of memory is ZONE_DMA). It's always been like that afaik.
> 
> We could support ISA device limited addressability using the iommu but
> that would involve a map/unmap type API (which I remember we did support
> in the old days by passing NULL to pci_map_*, but we dropped that along
> the way).

I think I'm going to just end up restricting this driver to X86
as was originally suggested.

There seems to be no real consistent Kconfig protection for users
of isa_virt_to_bus() and friends.

We know that ISA_DMA_API doesn't do it, and ISA doesn't do it either
as powerpc also allows that to bet set for CHRP and friends.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2012-09-22 Thread David Miller 
From: Benjamin Herrenschmidt b...@kernel.crashing.org
Date: Sat, 22 Sep 2012 07:46:40 +1000

 Right, but on ppc, GFP_DMA is a nop (no separate ZONE_DMA, or rather all
 of memory is ZONE_DMA). It's always been like that afaik.
 
 We could support ISA device limited addressability using the iommu but
 that would involve a map/unmap type API (which I remember we did support
 in the old days by passing NULL to pci_map_*, but we dropped that along
 the way).

I think I'm going to just end up restricting this driver to X86
as was originally suggested.

There seems to be no real consistent Kconfig protection for users
of isa_virt_to_bus() and friends.

We know that ISA_DMA_API doesn't do it, and ISA doesn't do it either
as powerpc also allows that to bet set for CHRP and friends.

Thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2012-09-22 Thread Benjamin Herrenschmidt 
On Sat, 2012-09-22 at 16:00 -0400, David Miller wrote:
 
 I think I'm going to just end up restricting this driver to X86
 as was originally suggested.

Probably the easiest fix indeed.

 There seems to be no real consistent Kconfig protection for users
 of isa_virt_to_bus() and friends.
 
 We know that ISA_DMA_API doesn't do it, and ISA doesn't do it either
 as powerpc also allows that to bet set for CHRP and friends.

It's a old mess :-( And not an easy one to untangle...

Cheers,
Ben.


--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2012-09-21 Thread Benjamin Herrenschmidt 
On Thu, 2012-09-20 at 18:53 -0400, David Miller wrote:
> From: Benjamin Herrenschmidt 
> Date: Fri, 21 Sep 2012 08:22:44 +1000
> 
> > Hrm, that's ancient gunk, I'll have to dig. We potentially can support
> > ISA devices DMA'ing from an ISA bridge... but via the iommu, which means
> > isa_virt_to_bus is a non-starter.
> > 
> > But then, do we really care ? IE. Is there single device that actually
> > requires ISA_DMA_API and that is expected to work on any currently
> > supported powerpc hw ? :-)
> > 
> > We don't even support PReP anymore, so that leaves us with what ?
> 
> ISA_DMA_API implies a fixed window of addresses which are <= 32-bits
> on the bus, which is a hardware requirement of these devices.
>
> isa_virt_to_bus() goes to that physical address, and the expection is
> that you use GFP_DMA and thus the physical addresses fit inside of
> an unsigned int.

Right, but on ppc, GFP_DMA is a nop (no separate ZONE_DMA, or rather all
of memory is ZONE_DMA). It's always been like that afaik.

We could support ISA device limited addressability using the iommu but
that would involve a map/unmap type API (which I remember we did support
in the old days by passing NULL to pci_map_*, but we dropped that along
the way).

> isa_virt_to_bus() basically amounts to a virt-->phys plus a cast.
> 
> > Anybody has an objection to turning ISA_DMA_API off ?
> 
> Then you can remove all of the DMA api stuff in powerpc's asm/dma.h
> but some of it looks like it might be in use.

I will dig a bit. I think there might be some users of the ISA DMA
engine for legacy floppies and parport on some early pSeries and CHRP
machines (including Pegasos).

Cheers,
Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2012-09-21 Thread Benjamin Herrenschmidt 
On Thu, 2012-09-20 at 18:53 -0400, David Miller wrote:
 From: Benjamin Herrenschmidt b...@kernel.crashing.org
 Date: Fri, 21 Sep 2012 08:22:44 +1000
 
  Hrm, that's ancient gunk, I'll have to dig. We potentially can support
  ISA devices DMA'ing from an ISA bridge... but via the iommu, which means
  isa_virt_to_bus is a non-starter.
  
  But then, do we really care ? IE. Is there single device that actually
  requires ISA_DMA_API and that is expected to work on any currently
  supported powerpc hw ? :-)
  
  We don't even support PReP anymore, so that leaves us with what ?
 
 ISA_DMA_API implies a fixed window of addresses which are = 32-bits
 on the bus, which is a hardware requirement of these devices.

 isa_virt_to_bus() goes to that physical address, and the expection is
 that you use GFP_DMA and thus the physical addresses fit inside of
 an unsigned int.

Right, but on ppc, GFP_DMA is a nop (no separate ZONE_DMA, or rather all
of memory is ZONE_DMA). It's always been like that afaik.

We could support ISA device limited addressability using the iommu but
that would involve a map/unmap type API (which I remember we did support
in the old days by passing NULL to pci_map_*, but we dropped that along
the way).

 isa_virt_to_bus() basically amounts to a virt--phys plus a cast.
 
  Anybody has an objection to turning ISA_DMA_API off ?
 
 Then you can remove all of the DMA api stuff in powerpc's asm/dma.h
 but some of it looks like it might be in use.

I will dig a bit. I think there might be some users of the ISA DMA
engine for legacy floppies and parport on some early pSeries and CHRP
machines (including Pegasos).

Cheers,
Ben.


--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2012-09-20 Thread Stephen Rothwell 
Hi Dave,

On Thu, 20 Sep 2012 17:36:22 +1000 Stephen Rothwell  
wrote:
>
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> drivers/net/ethernet/i825xx/znet.c: In function 'hardware_init':
> drivers/net/ethernet/i825xx/znet.c:868:2: error: implicit declaration of 
> function 'isa_virt_to_bus' [-Werror=implicit-function-declaration]
> 
> Caused by commit 1d3ff76759b7 ("i825xx: znet: fix compiler warnings when
> building a 64-bit kernel").  Is there some Kconfig dependency missing 
> (CONFIG_ISA)?
> 
> I have reverted that commit for today.

Today, I have added the following merge fix patch instead of reverting the
above (just until PowerPC can be fixed one way or the other).  I don't
know if you want to put this into the net-next tree, but it may be a
reasonable temporary measure.

From: Stephen Rothwell 
Date: Fri, 21 Sep 2012 11:32:09 +1000
Subject: [PATCH] i825xx: znet: temporarily disable on PPC

due to build problems

Signed-off-by: Stephen Rothwell 
---
 drivers/net/ethernet/i825xx/Kconfig |1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/i825xx/Kconfig 
b/drivers/net/ethernet/i825xx/Kconfig
index fed5080..9fce38b 100644
--- a/drivers/net/ethernet/i825xx/Kconfig
+++ b/drivers/net/ethernet/i825xx/Kconfig
@@ -151,6 +151,7 @@ config SUN3_82586
 config ZNET
tristate "Zenith Z-Note support (EXPERIMENTAL)"
depends on EXPERIMENTAL && ISA_DMA_API
+   depends on !PPC
---help---
  The Zenith Z-Note notebook computer has a built-in network
  (Ethernet) card, and this is the Linux driver for it. Note that the
-- 
1.7.10.280.gaa39

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpdoLLQvO0kM.pgp
Description: PGP signature

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2012-09-20 Thread David Miller 
From: Benjamin Herrenschmidt 
Date: Fri, 21 Sep 2012 08:22:44 +1000

> Hrm, that's ancient gunk, I'll have to dig. We potentially can support
> ISA devices DMA'ing from an ISA bridge... but via the iommu, which means
> isa_virt_to_bus is a non-starter.
> 
> But then, do we really care ? IE. Is there single device that actually
> requires ISA_DMA_API and that is expected to work on any currently
> supported powerpc hw ? :-)
> 
> We don't even support PReP anymore, so that leaves us with what ?

ISA_DMA_API implies a fixed window of addresses which are <= 32-bits
on the bus, which is a hardware requirement of these devices.

isa_virt_to_bus() goes to that physical address, and the expection is
that you use GFP_DMA and thus the physical addresses fit inside of
an unsigned int.

isa_virt_to_bus() basically amounts to a virt-->phys plus a cast.

> Anybody has an objection to turning ISA_DMA_API off ?

Then you can remove all of the DMA api stuff in powerpc's asm/dma.h
but some of it looks like it might be in use.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2012-09-20 Thread Stephen Rothwell 
Hi Dave,

On Thu, 20 Sep 2012 16:45:58 -0400 (EDT) David Miller  
wrote:
>
> I think the powerpc port is at fault here.
> 
> Part of being able to advertise ISA_DMA_API is providing isa_virt_to_bus().

Not disagreeing, but it would be nice if this was documented somewhere
(maybe in Documentation/DMA-ISA-LPC.txt).  We have not had this problem
before because all the other uses of isa_virt_to_bus() are in drivers
that depend on X86 or ARM or ISA or EISA.

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpH4fIlsoLks.pgp
Description: PGP signature

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2012-09-20 Thread Benjamin Herrenschmidt 

> > I think the powerpc port is at fault here.
> > 
> > Part of being able to advertise ISA_DMA_API is providing isa_virt_to_bus().

Hrm, that's ancient gunk, I'll have to dig. We potentially can support
ISA devices DMA'ing from an ISA bridge... but via the iommu, which means
isa_virt_to_bus is a non-starter.

But then, do we really care ? IE. Is there single device that actually
requires ISA_DMA_API and that is expected to work on any currently
supported powerpc hw ? :-)

We don't even support PReP anymore, so that leaves us with what ?

Anybody has an objection to turning ISA_DMA_API off ?

Cheers,
Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2012-09-20 Thread Stephen Rothwell 
[Just bring this to the attention of the PowerPC folks ...]

On Thu, 20 Sep 2012 16:45:58 -0400 (EDT) David Miller  
wrote:
>
> From: Mika Westerberg 
> Date: Thu, 20 Sep 2012 12:10:14 +0300
> 
> > On Thu, Sep 20, 2012 at 05:36:22PM +1000, Stephen Rothwell wrote:
> >> Hi all,
> >> 
> >> After merging the final tree, today's linux-next build (powerpc
> >> allyesconfig) failed like this:
> >> 
> >> drivers/net/ethernet/i825xx/znet.c: In function 'hardware_init':
> >> drivers/net/ethernet/i825xx/znet.c:868:2: error: implicit declaration of 
> >> function 'isa_virt_to_bus' [-Werror=implicit-function-declaration]
> >> 
> >> Caused by commit 1d3ff76759b7 ("i825xx: znet: fix compiler warnings when
> >> building a 64-bit kernel").  Is there some Kconfig dependency missing 
> >> (CONFIG_ISA)?
> > 
> > If we make it dependent on CONFIG_ISA then the driver cannot be built with
> > 64-bit kernel. Then again is there someone running 64-bit kernel on Zenith
> > Z-note notebook? From the pictures it looks like very ancient "laptop".
> > 
> > An alternative is to make it depend on X86 like this:
> 
> I think the powerpc port is at fault here.
> 
> Part of being able to advertise ISA_DMA_API is providing isa_virt_to_bus().

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgp1w69z4ejdL.pgp
Description: PGP signature

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2012-09-20 Thread David Miller 
From: Mika Westerberg 
Date: Thu, 20 Sep 2012 12:10:14 +0300

> On Thu, Sep 20, 2012 at 05:36:22PM +1000, Stephen Rothwell wrote:
>> Hi all,
>> 
>> After merging the final tree, today's linux-next build (powerpc
>> allyesconfig) failed like this:
>> 
>> drivers/net/ethernet/i825xx/znet.c: In function 'hardware_init':
>> drivers/net/ethernet/i825xx/znet.c:868:2: error: implicit declaration of 
>> function 'isa_virt_to_bus' [-Werror=implicit-function-declaration]
>> 
>> Caused by commit 1d3ff76759b7 ("i825xx: znet: fix compiler warnings when
>> building a 64-bit kernel").  Is there some Kconfig dependency missing 
>> (CONFIG_ISA)?
> 
> If we make it dependent on CONFIG_ISA then the driver cannot be built with
> 64-bit kernel. Then again is there someone running 64-bit kernel on Zenith
> Z-note notebook? From the pictures it looks like very ancient "laptop".
> 
> An alternative is to make it depend on X86 like this:

I think the powerpc port is at fault here.

Part of being able to advertise ISA_DMA_API is providing isa_virt_to_bus().
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2012-09-20 Thread Mika Westerberg 
On Thu, Sep 20, 2012 at 05:36:22PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> drivers/net/ethernet/i825xx/znet.c: In function 'hardware_init':
> drivers/net/ethernet/i825xx/znet.c:868:2: error: implicit declaration of 
> function 'isa_virt_to_bus' [-Werror=implicit-function-declaration]
> 
> Caused by commit 1d3ff76759b7 ("i825xx: znet: fix compiler warnings when
> building a 64-bit kernel").  Is there some Kconfig dependency missing 
> (CONFIG_ISA)?

If we make it dependent on CONFIG_ISA then the driver cannot be built with
64-bit kernel. Then again is there someone running 64-bit kernel on Zenith
Z-note notebook? From the pictures it looks like very ancient "laptop".

An alternative is to make it depend on X86 like this:

diff --git a/drivers/net/ethernet/i825xx/Kconfig 
b/drivers/net/ethernet/i825xx/Kconfig
index fed5080..959faf7 100644
--- a/drivers/net/ethernet/i825xx/Kconfig
+++ b/drivers/net/ethernet/i825xx/Kconfig
@@ -150,7 +150,7 @@ config SUN3_82586
 
 config ZNET
tristate "Zenith Z-Note support (EXPERIMENTAL)"
-   depends on EXPERIMENTAL && ISA_DMA_API
+   depends on EXPERIMENTAL && ISA_DMA_API && X86
---help---
  The Zenith Z-Note notebook computer has a built-in network
  (Ethernet) card, and this is the Linux driver for it. Note that the
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

linux-next: build failure after merge of the final tree (net-next tree related)

2012-09-20 Thread Stephen Rothwell 
Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/net/ethernet/i825xx/znet.c: In function 'hardware_init':
drivers/net/ethernet/i825xx/znet.c:868:2: error: implicit declaration of 
function 'isa_virt_to_bus' [-Werror=implicit-function-declaration]

Caused by commit 1d3ff76759b7 ("i825xx: znet: fix compiler warnings when
building a 64-bit kernel").  Is there some Kconfig dependency missing 
(CONFIG_ISA)?

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpw8jAIAO54T.pgp
Description: PGP signature

linux-next: build failure after merge of the final tree (net-next tree related)

2012-09-20 Thread Stephen Rothwell 
Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/net/ethernet/i825xx/znet.c: In function 'hardware_init':
drivers/net/ethernet/i825xx/znet.c:868:2: error: implicit declaration of 
function 'isa_virt_to_bus' [-Werror=implicit-function-declaration]

Caused by commit 1d3ff76759b7 (i825xx: znet: fix compiler warnings when
building a 64-bit kernel).  Is there some Kconfig dependency missing 
(CONFIG_ISA)?

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpw8jAIAO54T.pgp
Description: PGP signature

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2012-09-20 Thread Mika Westerberg 
On Thu, Sep 20, 2012 at 05:36:22PM +1000, Stephen Rothwell wrote:
 Hi all,
 
 After merging the final tree, today's linux-next build (powerpc
 allyesconfig) failed like this:
 
 drivers/net/ethernet/i825xx/znet.c: In function 'hardware_init':
 drivers/net/ethernet/i825xx/znet.c:868:2: error: implicit declaration of 
 function 'isa_virt_to_bus' [-Werror=implicit-function-declaration]
 
 Caused by commit 1d3ff76759b7 (i825xx: znet: fix compiler warnings when
 building a 64-bit kernel).  Is there some Kconfig dependency missing 
 (CONFIG_ISA)?

If we make it dependent on CONFIG_ISA then the driver cannot be built with
64-bit kernel. Then again is there someone running 64-bit kernel on Zenith
Z-note notebook? From the pictures it looks like very ancient laptop.

An alternative is to make it depend on X86 like this:

diff --git a/drivers/net/ethernet/i825xx/Kconfig 
b/drivers/net/ethernet/i825xx/Kconfig
index fed5080..959faf7 100644
--- a/drivers/net/ethernet/i825xx/Kconfig
+++ b/drivers/net/ethernet/i825xx/Kconfig
@@ -150,7 +150,7 @@ config SUN3_82586
 
 config ZNET
tristate Zenith Z-Note support (EXPERIMENTAL)
-   depends on EXPERIMENTAL  ISA_DMA_API
+   depends on EXPERIMENTAL  ISA_DMA_API  X86
---help---
  The Zenith Z-Note notebook computer has a built-in network
  (Ethernet) card, and this is the Linux driver for it. Note that the
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2012-09-20 Thread David Miller 
From: Mika Westerberg mika.westerb...@linux.intel.com
Date: Thu, 20 Sep 2012 12:10:14 +0300

 On Thu, Sep 20, 2012 at 05:36:22PM +1000, Stephen Rothwell wrote:
 Hi all,
 
 After merging the final tree, today's linux-next build (powerpc
 allyesconfig) failed like this:
 
 drivers/net/ethernet/i825xx/znet.c: In function 'hardware_init':
 drivers/net/ethernet/i825xx/znet.c:868:2: error: implicit declaration of 
 function 'isa_virt_to_bus' [-Werror=implicit-function-declaration]
 
 Caused by commit 1d3ff76759b7 (i825xx: znet: fix compiler warnings when
 building a 64-bit kernel).  Is there some Kconfig dependency missing 
 (CONFIG_ISA)?
 
 If we make it dependent on CONFIG_ISA then the driver cannot be built with
 64-bit kernel. Then again is there someone running 64-bit kernel on Zenith
 Z-note notebook? From the pictures it looks like very ancient laptop.
 
 An alternative is to make it depend on X86 like this:

I think the powerpc port is at fault here.

Part of being able to advertise ISA_DMA_API is providing isa_virt_to_bus().
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2012-09-20 Thread Stephen Rothwell 
[Just bring this to the attention of the PowerPC folks ...]

On Thu, 20 Sep 2012 16:45:58 -0400 (EDT) David Miller da...@davemloft.net 
wrote:

 From: Mika Westerberg mika.westerb...@linux.intel.com
 Date: Thu, 20 Sep 2012 12:10:14 +0300
 
  On Thu, Sep 20, 2012 at 05:36:22PM +1000, Stephen Rothwell wrote:
  Hi all,
  
  After merging the final tree, today's linux-next build (powerpc
  allyesconfig) failed like this:
  
  drivers/net/ethernet/i825xx/znet.c: In function 'hardware_init':
  drivers/net/ethernet/i825xx/znet.c:868:2: error: implicit declaration of 
  function 'isa_virt_to_bus' [-Werror=implicit-function-declaration]
  
  Caused by commit 1d3ff76759b7 (i825xx: znet: fix compiler warnings when
  building a 64-bit kernel).  Is there some Kconfig dependency missing 
  (CONFIG_ISA)?
  
  If we make it dependent on CONFIG_ISA then the driver cannot be built with
  64-bit kernel. Then again is there someone running 64-bit kernel on Zenith
  Z-note notebook? From the pictures it looks like very ancient laptop.
  
  An alternative is to make it depend on X86 like this:
 
 I think the powerpc port is at fault here.
 
 Part of being able to advertise ISA_DMA_API is providing isa_virt_to_bus().

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgp1w69z4ejdL.pgp
Description: PGP signature

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2012-09-20 Thread Benjamin Herrenschmidt 

  I think the powerpc port is at fault here.
  
  Part of being able to advertise ISA_DMA_API is providing isa_virt_to_bus().

Hrm, that's ancient gunk, I'll have to dig. We potentially can support
ISA devices DMA'ing from an ISA bridge... but via the iommu, which means
isa_virt_to_bus is a non-starter.

But then, do we really care ? IE. Is there single device that actually
requires ISA_DMA_API and that is expected to work on any currently
supported powerpc hw ? :-)

We don't even support PReP anymore, so that leaves us with what ?

Anybody has an objection to turning ISA_DMA_API off ?

Cheers,
Ben.


--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2012-09-20 Thread Stephen Rothwell 
Hi Dave,

On Thu, 20 Sep 2012 16:45:58 -0400 (EDT) David Miller da...@davemloft.net 
wrote:

 I think the powerpc port is at fault here.
 
 Part of being able to advertise ISA_DMA_API is providing isa_virt_to_bus().

Not disagreeing, but it would be nice if this was documented somewhere
(maybe in Documentation/DMA-ISA-LPC.txt).  We have not had this problem
before because all the other uses of isa_virt_to_bus() are in drivers
that depend on X86 or ARM or ISA or EISA.

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpH4fIlsoLks.pgp
Description: PGP signature

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2012-09-20 Thread David Miller 
From: Benjamin Herrenschmidt b...@kernel.crashing.org
Date: Fri, 21 Sep 2012 08:22:44 +1000

 Hrm, that's ancient gunk, I'll have to dig. We potentially can support
 ISA devices DMA'ing from an ISA bridge... but via the iommu, which means
 isa_virt_to_bus is a non-starter.
 
 But then, do we really care ? IE. Is there single device that actually
 requires ISA_DMA_API and that is expected to work on any currently
 supported powerpc hw ? :-)
 
 We don't even support PReP anymore, so that leaves us with what ?

ISA_DMA_API implies a fixed window of addresses which are = 32-bits
on the bus, which is a hardware requirement of these devices.

isa_virt_to_bus() goes to that physical address, and the expection is
that you use GFP_DMA and thus the physical addresses fit inside of
an unsigned int.

isa_virt_to_bus() basically amounts to a virt--phys plus a cast.

 Anybody has an objection to turning ISA_DMA_API off ?

Then you can remove all of the DMA api stuff in powerpc's asm/dma.h
but some of it looks like it might be in use.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2012-09-20 Thread Stephen Rothwell 
Hi Dave,

On Thu, 20 Sep 2012 17:36:22 +1000 Stephen Rothwell s...@canb.auug.org.au 
wrote:

 After merging the final tree, today's linux-next build (powerpc
 allyesconfig) failed like this:
 
 drivers/net/ethernet/i825xx/znet.c: In function 'hardware_init':
 drivers/net/ethernet/i825xx/znet.c:868:2: error: implicit declaration of 
 function 'isa_virt_to_bus' [-Werror=implicit-function-declaration]
 
 Caused by commit 1d3ff76759b7 (i825xx: znet: fix compiler warnings when
 building a 64-bit kernel).  Is there some Kconfig dependency missing 
 (CONFIG_ISA)?
 
 I have reverted that commit for today.

Today, I have added the following merge fix patch instead of reverting the
above (just until PowerPC can be fixed one way or the other).  I don't
know if you want to put this into the net-next tree, but it may be a
reasonable temporary measure.

From: Stephen Rothwell s...@canb.auug.org.au
Date: Fri, 21 Sep 2012 11:32:09 +1000
Subject: [PATCH] i825xx: znet: temporarily disable on PPC

due to build problems

Signed-off-by: Stephen Rothwell s...@canb.auug.org.au
---
 drivers/net/ethernet/i825xx/Kconfig |1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/i825xx/Kconfig 
b/drivers/net/ethernet/i825xx/Kconfig
index fed5080..9fce38b 100644
--- a/drivers/net/ethernet/i825xx/Kconfig
+++ b/drivers/net/ethernet/i825xx/Kconfig
@@ -151,6 +151,7 @@ config SUN3_82586
 config ZNET
tristate Zenith Z-Note support (EXPERIMENTAL)
depends on EXPERIMENTAL  ISA_DMA_API
+   depends on !PPC
---help---
  The Zenith Z-Note notebook computer has a built-in network
  (Ethernet) card, and this is the Linux driver for it. Note that the
-- 
1.7.10.280.gaa39

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpdoLLQvO0kM.pgp
Description: PGP signature

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2012-09-05 Thread David Miller 
From: Stephen Rothwell 
Date: Wed, 5 Sep 2012 15:39:32 +1000

> (I always thought IPv6 NAT was a bad idea ;-))

ROFL :)

> From: Stephen Rothwell 
> Date: Wed, 5 Sep 2012 15:34:58 +1000
> Subject: [PATCH] netfilter: ipv6: using csum_ipv6_magic requires
>  net/ip6_checksum.h
> 
> Fixes this build error:
> 
> net/ipv6/netfilter/nf_nat_l3proto_ipv6.c: In function 
> 'nf_nat_ipv6_csum_recalc':
> net/ipv6/netfilter/nf_nat_l3proto_ipv6.c:144:4: error: implicit declaration 
> of function 'csum_ipv6_magic' [-Werror=implicit-function-declaration]
> 
> Signed-off-by: Stephen Rothwell 

Applied, thanks Stephen.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2012-09-05 Thread David Miller 
From: Stephen Rothwell s...@canb.auug.org.au
Date: Wed, 5 Sep 2012 15:39:32 +1000

 (I always thought IPv6 NAT was a bad idea ;-))

ROFL :)

 From: Stephen Rothwell s...@canb.auug.org.au
 Date: Wed, 5 Sep 2012 15:34:58 +1000
 Subject: [PATCH] netfilter: ipv6: using csum_ipv6_magic requires
  net/ip6_checksum.h
 
 Fixes this build error:
 
 net/ipv6/netfilter/nf_nat_l3proto_ipv6.c: In function 
 'nf_nat_ipv6_csum_recalc':
 net/ipv6/netfilter/nf_nat_l3proto_ipv6.c:144:4: error: implicit declaration 
 of function 'csum_ipv6_magic' [-Werror=implicit-function-declaration]
 
 Signed-off-by: Stephen Rothwell s...@canb.auug.org.au

Applied, thanks Stephen.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

linux-next: build failure after merge of the final tree (net-next tree related)

2012-09-04 Thread Stephen Rothwell 
Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

net/ipv6/netfilter/nf_nat_l3proto_ipv6.c: In function 'nf_nat_ipv6_csum_recalc':
net/ipv6/netfilter/nf_nat_l3proto_ipv6.c:144:4: error: implicit declaration of 
function 'csum_ipv6_magic' [-Werror=implicit-function-declaration]

Caused by commit 58a317f1061c ("netfilter: ipv6: add IPv6 NAT support").

(I always thought IPv6 NAT was a bad idea ;-))

I have applied the following patch for today:

From: Stephen Rothwell 
Date: Wed, 5 Sep 2012 15:34:58 +1000
Subject: [PATCH] netfilter: ipv6: using csum_ipv6_magic requires
 net/ip6_checksum.h

Fixes this build error:

net/ipv6/netfilter/nf_nat_l3proto_ipv6.c: In function 'nf_nat_ipv6_csum_recalc':
net/ipv6/netfilter/nf_nat_l3proto_ipv6.c:144:4: error: implicit declaration of 
function 'csum_ipv6_magic' [-Werror=implicit-function-declaration]

Signed-off-by: Stephen Rothwell 
---
 net/ipv6/netfilter/nf_nat_l3proto_ipv6.c |1 +
 1 file changed, 1 insertion(+)

diff --git a/net/ipv6/netfilter/nf_nat_l3proto_ipv6.c 
b/net/ipv6/netfilter/nf_nat_l3proto_ipv6.c
index 81a2d1c..abfe75a 100644
--- a/net/ipv6/netfilter/nf_nat_l3proto_ipv6.c
+++ b/net/ipv6/netfilter/nf_nat_l3proto_ipv6.c
@@ -15,6 +15,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 
-- 
1.7.10.280.gaa39

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpdpyeIi1XDy.pgp
Description: PGP signature

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2012-09-04 Thread Jerry Chu 
On Tue, Sep 4, 2012 at 11:20 AM, David Miller  wrote:
> From: Stephen Rothwell 
> Date: Tue, 4 Sep 2012 16:58:53 +1000
>
>> net/built-in.o: In function `tcp_fastopen_ctx_free':
>> tcp_fastopen.c:(.text+0x5cc5c): undefined reference to `crypto_destroy_tfm'
>> net/built-in.o: In function `tcp_fastopen_reset_cipher':
>> (.text+0x5): undefined reference to `crypto_alloc_base'
>> net/built-in.o: In function `tcp_fastopen_reset_cipher':
>> (.text+0x5cd6c): undefined reference to `crypto_destroy_tfm'
>>
>> Presumably caused by commit 104671636897 ("tcp: TCP Fast Open Server -
>> header & support functions") from the net-next tree.  I assume that some
>> dependency on the CRYPTO infrastructure is missing.
>
> Thanks for the report, I've pushed the following change to net-next
> which should address this:
>
> 
> [PATCH] net: Add INET dependency on aes crypto for the sake of TCP fastopen.
>
> Stephen Rothwell says:
>
> 
> After merging the final tree, today's linux-next build (powerpc
> ppc44x_defconfig) failed like this:
>
> net/built-in.o: In function `tcp_fastopen_ctx_free':
> tcp_fastopen.c:(.text+0x5cc5c): undefined reference to `crypto_destroy_tfm'
> net/built-in.o: In function `tcp_fastopen_reset_cipher':
> (.text+0x5): undefined reference to `crypto_alloc_base'
> net/built-in.o: In function `tcp_fastopen_reset_cipher':
> (.text+0x5cd6c): undefined reference to `crypto_destroy_tfm'
>
> Presumably caused by commit 104671636897 ("tcp: TCP Fast Open Server -
> header & support functions") from the net-next tree.  I assume that some
> dependency on the CRYPTO infrastructure is missing.
>
> I have reverted commit 1bed966cc3bd ("Merge branch
> 'tcp_fastopen_server'") for today.
> 
>
> Reported-by: Stephen Rothwell 
> Signed-off-by: David S. Miller 
> ---
>  net/Kconfig |2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/net/Kconfig b/net/Kconfig
> index 245831b..30b48f5 100644
> --- a/net/Kconfig
> +++ b/net/Kconfig
> @@ -52,6 +52,8 @@ source "net/iucv/Kconfig"
>
>  config INET
> bool "TCP/IP networking"
> +   select CRYPTO
> +   select CRYPTO_AES
> ---help---
>   These are the protocols used on the Internet and on most local
>   Ethernets. It is highly recommended to say Y here (this will enlarge
> --
> 1.7.7.6
>

Thanks for fixing this, David. (Sorry for missing the dependency.)

Jerry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2012-09-04 Thread David Miller 
From: Stephen Rothwell 
Date: Tue, 4 Sep 2012 16:58:53 +1000

> net/built-in.o: In function `tcp_fastopen_ctx_free':
> tcp_fastopen.c:(.text+0x5cc5c): undefined reference to `crypto_destroy_tfm'
> net/built-in.o: In function `tcp_fastopen_reset_cipher':
> (.text+0x5): undefined reference to `crypto_alloc_base'
> net/built-in.o: In function `tcp_fastopen_reset_cipher':
> (.text+0x5cd6c): undefined reference to `crypto_destroy_tfm'
> 
> Presumably caused by commit 104671636897 ("tcp: TCP Fast Open Server -
> header & support functions") from the net-next tree.  I assume that some
> dependency on the CRYPTO infrastructure is missing.

Thanks for the report, I've pushed the following change to net-next
which should address this:


[PATCH] net: Add INET dependency on aes crypto for the sake of TCP fastopen.

Stephen Rothwell says:


After merging the final tree, today's linux-next build (powerpc
ppc44x_defconfig) failed like this:

net/built-in.o: In function `tcp_fastopen_ctx_free':
tcp_fastopen.c:(.text+0x5cc5c): undefined reference to `crypto_destroy_tfm'
net/built-in.o: In function `tcp_fastopen_reset_cipher':
(.text+0x5): undefined reference to `crypto_alloc_base'
net/built-in.o: In function `tcp_fastopen_reset_cipher':
(.text+0x5cd6c): undefined reference to `crypto_destroy_tfm'

Presumably caused by commit 104671636897 ("tcp: TCP Fast Open Server -
header & support functions") from the net-next tree.  I assume that some
dependency on the CRYPTO infrastructure is missing.

I have reverted commit 1bed966cc3bd ("Merge branch
'tcp_fastopen_server'") for today.


Reported-by: Stephen Rothwell 
Signed-off-by: David S. Miller 
---
 net/Kconfig |2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/net/Kconfig b/net/Kconfig
index 245831b..30b48f5 100644
--- a/net/Kconfig
+++ b/net/Kconfig
@@ -52,6 +52,8 @@ source "net/iucv/Kconfig"
 
 config INET
bool "TCP/IP networking"
+   select CRYPTO
+   select CRYPTO_AES
---help---
  These are the protocols used on the Internet and on most local
  Ethernets. It is highly recommended to say Y here (this will enlarge
-- 
1.7.7.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

linux-next: build failure after merge of the final tree (net-next tree related)

2012-09-04 Thread Stephen Rothwell 
Hi ,

After merging the final tree, today's linux-next build (powerpc
ppc44x_defconfig) failed like this:

net/built-in.o: In function `tcp_fastopen_ctx_free':
tcp_fastopen.c:(.text+0x5cc5c): undefined reference to `crypto_destroy_tfm'
net/built-in.o: In function `tcp_fastopen_reset_cipher':
(.text+0x5): undefined reference to `crypto_alloc_base'
net/built-in.o: In function `tcp_fastopen_reset_cipher':
(.text+0x5cd6c): undefined reference to `crypto_destroy_tfm'

Presumably caused by commit 104671636897 ("tcp: TCP Fast Open Server -
header & support functions") from the net-next tree.  I assume that some
dependency on the CRYPTO infrastructure is missing.

I have reverted commit 1bed966cc3bd ("Merge branch
'tcp_fastopen_server'") for today.
-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpLUpOujdrI8.pgp
Description: PGP signature

linux-next: build failure after merge of the final tree (net-next tree related)

2012-09-04 Thread Stephen Rothwell 
Hi ,

After merging the final tree, today's linux-next build (powerpc
ppc44x_defconfig) failed like this:

net/built-in.o: In function `tcp_fastopen_ctx_free':
tcp_fastopen.c:(.text+0x5cc5c): undefined reference to `crypto_destroy_tfm'
net/built-in.o: In function `tcp_fastopen_reset_cipher':
(.text+0x5): undefined reference to `crypto_alloc_base'
net/built-in.o: In function `tcp_fastopen_reset_cipher':
(.text+0x5cd6c): undefined reference to `crypto_destroy_tfm'

Presumably caused by commit 104671636897 (tcp: TCP Fast Open Server -
header  support functions) from the net-next tree.  I assume that some
dependency on the CRYPTO infrastructure is missing.

I have reverted commit 1bed966cc3bd (Merge branch
'tcp_fastopen_server') for today.
-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpLUpOujdrI8.pgp
Description: PGP signature

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2012-09-04 Thread David Miller 
From: Stephen Rothwell s...@canb.auug.org.au
Date: Tue, 4 Sep 2012 16:58:53 +1000

 net/built-in.o: In function `tcp_fastopen_ctx_free':
 tcp_fastopen.c:(.text+0x5cc5c): undefined reference to `crypto_destroy_tfm'
 net/built-in.o: In function `tcp_fastopen_reset_cipher':
 (.text+0x5): undefined reference to `crypto_alloc_base'
 net/built-in.o: In function `tcp_fastopen_reset_cipher':
 (.text+0x5cd6c): undefined reference to `crypto_destroy_tfm'
 
 Presumably caused by commit 104671636897 (tcp: TCP Fast Open Server -
 header  support functions) from the net-next tree.  I assume that some
 dependency on the CRYPTO infrastructure is missing.

Thanks for the report, I've pushed the following change to net-next
which should address this:


[PATCH] net: Add INET dependency on aes crypto for the sake of TCP fastopen.

Stephen Rothwell says:


After merging the final tree, today's linux-next build (powerpc
ppc44x_defconfig) failed like this:

net/built-in.o: In function `tcp_fastopen_ctx_free':
tcp_fastopen.c:(.text+0x5cc5c): undefined reference to `crypto_destroy_tfm'
net/built-in.o: In function `tcp_fastopen_reset_cipher':
(.text+0x5): undefined reference to `crypto_alloc_base'
net/built-in.o: In function `tcp_fastopen_reset_cipher':
(.text+0x5cd6c): undefined reference to `crypto_destroy_tfm'

Presumably caused by commit 104671636897 (tcp: TCP Fast Open Server -
header  support functions) from the net-next tree.  I assume that some
dependency on the CRYPTO infrastructure is missing.

I have reverted commit 1bed966cc3bd (Merge branch
'tcp_fastopen_server') for today.


Reported-by: Stephen Rothwell s...@canb.auug.org.au
Signed-off-by: David S. Miller da...@davemloft.net
---
 net/Kconfig |2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/net/Kconfig b/net/Kconfig
index 245831b..30b48f5 100644
--- a/net/Kconfig
+++ b/net/Kconfig
@@ -52,6 +52,8 @@ source net/iucv/Kconfig
 
 config INET
bool TCP/IP networking
+   select CRYPTO
+   select CRYPTO_AES
---help---
  These are the protocols used on the Internet and on most local
  Ethernets. It is highly recommended to say Y here (this will enlarge
-- 
1.7.7.6

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2012-09-04 Thread Jerry Chu 
On Tue, Sep 4, 2012 at 11:20 AM, David Miller da...@davemloft.net wrote:
 From: Stephen Rothwell s...@canb.auug.org.au
 Date: Tue, 4 Sep 2012 16:58:53 +1000

 net/built-in.o: In function `tcp_fastopen_ctx_free':
 tcp_fastopen.c:(.text+0x5cc5c): undefined reference to `crypto_destroy_tfm'
 net/built-in.o: In function `tcp_fastopen_reset_cipher':
 (.text+0x5): undefined reference to `crypto_alloc_base'
 net/built-in.o: In function `tcp_fastopen_reset_cipher':
 (.text+0x5cd6c): undefined reference to `crypto_destroy_tfm'

 Presumably caused by commit 104671636897 (tcp: TCP Fast Open Server -
 header  support functions) from the net-next tree.  I assume that some
 dependency on the CRYPTO infrastructure is missing.

 Thanks for the report, I've pushed the following change to net-next
 which should address this:

 
 [PATCH] net: Add INET dependency on aes crypto for the sake of TCP fastopen.

 Stephen Rothwell says:

 
 After merging the final tree, today's linux-next build (powerpc
 ppc44x_defconfig) failed like this:

 net/built-in.o: In function `tcp_fastopen_ctx_free':
 tcp_fastopen.c:(.text+0x5cc5c): undefined reference to `crypto_destroy_tfm'
 net/built-in.o: In function `tcp_fastopen_reset_cipher':
 (.text+0x5): undefined reference to `crypto_alloc_base'
 net/built-in.o: In function `tcp_fastopen_reset_cipher':
 (.text+0x5cd6c): undefined reference to `crypto_destroy_tfm'

 Presumably caused by commit 104671636897 (tcp: TCP Fast Open Server -
 header  support functions) from the net-next tree.  I assume that some
 dependency on the CRYPTO infrastructure is missing.

 I have reverted commit 1bed966cc3bd (Merge branch
 'tcp_fastopen_server') for today.
 

 Reported-by: Stephen Rothwell s...@canb.auug.org.au
 Signed-off-by: David S. Miller da...@davemloft.net
 ---
  net/Kconfig |2 ++
  1 files changed, 2 insertions(+), 0 deletions(-)

 diff --git a/net/Kconfig b/net/Kconfig
 index 245831b..30b48f5 100644
 --- a/net/Kconfig
 +++ b/net/Kconfig
 @@ -52,6 +52,8 @@ source net/iucv/Kconfig

  config INET
 bool TCP/IP networking
 +   select CRYPTO
 +   select CRYPTO_AES
 ---help---
   These are the protocols used on the Internet and on most local
   Ethernets. It is highly recommended to say Y here (this will enlarge
 --
 1.7.7.6


Thanks for fixing this, David. (Sorry for missing the dependency.)

Jerry
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

linux-next: build failure after merge of the final tree (net-next tree related)

2012-09-04 Thread Stephen Rothwell 
Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

net/ipv6/netfilter/nf_nat_l3proto_ipv6.c: In function 'nf_nat_ipv6_csum_recalc':
net/ipv6/netfilter/nf_nat_l3proto_ipv6.c:144:4: error: implicit declaration of 
function 'csum_ipv6_magic' [-Werror=implicit-function-declaration]

Caused by commit 58a317f1061c (netfilter: ipv6: add IPv6 NAT support).

(I always thought IPv6 NAT was a bad idea ;-))

I have applied the following patch for today:

From: Stephen Rothwell s...@canb.auug.org.au
Date: Wed, 5 Sep 2012 15:34:58 +1000
Subject: [PATCH] netfilter: ipv6: using csum_ipv6_magic requires
 net/ip6_checksum.h

Fixes this build error:

net/ipv6/netfilter/nf_nat_l3proto_ipv6.c: In function 'nf_nat_ipv6_csum_recalc':
net/ipv6/netfilter/nf_nat_l3proto_ipv6.c:144:4: error: implicit declaration of 
function 'csum_ipv6_magic' [-Werror=implicit-function-declaration]

Signed-off-by: Stephen Rothwell s...@canb.auug.org.au
---
 net/ipv6/netfilter/nf_nat_l3proto_ipv6.c |1 +
 1 file changed, 1 insertion(+)

diff --git a/net/ipv6/netfilter/nf_nat_l3proto_ipv6.c 
b/net/ipv6/netfilter/nf_nat_l3proto_ipv6.c
index 81a2d1c..abfe75a 100644
--- a/net/ipv6/netfilter/nf_nat_l3proto_ipv6.c
+++ b/net/ipv6/netfilter/nf_nat_l3proto_ipv6.c
@@ -15,6 +15,7 @@
 #include linux/netfilter_ipv6.h
 #include net/secure_seq.h
 #include net/checksum.h
+#include net/ip6_checksum.h
 #include net/ip6_route.h
 #include net/ipv6.h
 
-- 
1.7.10.280.gaa39

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpdpyeIi1XDy.pgp
Description: PGP signature

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2012-07-22 Thread Jiri Pirko 
Sun, Jul 22, 2012 at 08:34:08AM CEST, s...@canb.auug.org.au wrote:
>Hi Dave,
>
>After merging the final tree, today's linux-next build (powerpc
>ppc44x_defconfig) failed like this:
>
>net/core/rtnetlink.c: In function 'rtnl_fill_ifinfo':
>net/core/rtnetlink.c:895:46: error: 'struct net_device' has no member named 
>'num_rx_queues'
>
>Caused by commit 76ff5cc91935 ("rtnl: allow to specify number of rx and
>tx queues on device creation").  This build does not have CONFIG_RPS set.
>
>I have reverted that commit for today.


I just sent a fix ccing you, Stephen.

Apologies, Jirka

>-- 
>Cheers,
>Stephen Rothwells...@canb.auug.org.au


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

linux-next: build failure after merge of the final tree (net-next tree related)

2012-07-22 Thread Stephen Rothwell 
Hi Dave,

After merging the final tree, today's linux-next build (powerpc
ppc44x_defconfig) failed like this:

net/core/rtnetlink.c: In function 'rtnl_fill_ifinfo':
net/core/rtnetlink.c:895:46: error: 'struct net_device' has no member named 
'num_rx_queues'

Caused by commit 76ff5cc91935 ("rtnl: allow to specify number of rx and
tx queues on device creation").  This build does not have CONFIG_RPS set.

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpnOCJJ6QmhW.pgp
Description: PGP signature

linux-next: build failure after merge of the final tree (net-next tree related)

2012-07-22 Thread Stephen Rothwell 
Hi Dave,

After merging the final tree, today's linux-next build (powerpc
ppc44x_defconfig) failed like this:

net/core/rtnetlink.c: In function 'rtnl_fill_ifinfo':
net/core/rtnetlink.c:895:46: error: 'struct net_device' has no member named 
'num_rx_queues'

Caused by commit 76ff5cc91935 (rtnl: allow to specify number of rx and
tx queues on device creation).  This build does not have CONFIG_RPS set.

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpnOCJJ6QmhW.pgp
Description: PGP signature

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2012-07-22 Thread Jiri Pirko 
Sun, Jul 22, 2012 at 08:34:08AM CEST, s...@canb.auug.org.au wrote:
Hi Dave,

After merging the final tree, today's linux-next build (powerpc
ppc44x_defconfig) failed like this:

net/core/rtnetlink.c: In function 'rtnl_fill_ifinfo':
net/core/rtnetlink.c:895:46: error: 'struct net_device' has no member named 
'num_rx_queues'

Caused by commit 76ff5cc91935 (rtnl: allow to specify number of rx and
tx queues on device creation).  This build does not have CONFIG_RPS set.

I have reverted that commit for today.


I just sent a fix ccing you, Stephen.

Apologies, Jirka

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/