linux-next: build failure after merge of the uuid tree
Hi Christoph,
After merging the uuid tree, today's linux-next build (x86_64
allmodconfig) failed like this:
/home/sfr/next/next/drivers/thermal/int340x_thermal/int3400_thermal.c: In
function 'int3400_thermal_get_uuids':
/home/sfr/next/next/drivers/thermal/int340x_thermal/int3400_thermal.c:146:4:
error: implicit declaration of function 'acpi_str_to_uuid'
[-Werror=implicit-function-declaration]
acpi_str_to_uuid(int3400_thermal_uuids[j], uuid);
^
Caused by commit
94116f8126de ("ACPI: Switch to use generic guid_t in acpi_evaluate_dsm()")
I have used the uuid tree from next-20170607 again today.
--
Cheers,
Stephen Rothwell
linux-next: build failure after merge of the uuid tree
Hi Christoph,
After merging the uuid tree, today's linux-next build (x86_64
allmodconfig) failed like this:
/home/sfr/next/next/drivers/thermal/int340x_thermal/int3400_thermal.c: In
function 'int3400_thermal_get_uuids':
/home/sfr/next/next/drivers/thermal/int340x_thermal/int3400_thermal.c:146:4:
error: implicit declaration of function 'acpi_str_to_uuid'
[-Werror=implicit-function-declaration]
acpi_str_to_uuid(int3400_thermal_uuids[j], uuid);
^
Caused by commit
94116f8126de ("ACPI: Switch to use generic guid_t in acpi_evaluate_dsm()")
I have used the uuid tree from next-20170607 again today.
--
Cheers,
Stephen Rothwell
Re: linux-next: build failure after merge of the uuid tree
On Thu, 2017-06-08 at 09:04 +0200, Christoph Hellwig wrote:
> On Thu, Jun 08, 2017 at 04:04:15PM +1000, Stephen Rothwell wrote:
> > Hi Christoph,
> >
> > After merging the uuid tree, today's linux-next build (powerpc
> > ppc64_defconfig) failed like this:
> >
> > In file included from drivers/base/cpu.c:16:0:
> > include/linux/acpi.h:744:16: error: unknown type name 'guid_t'
> > const guid_t *guid,
> > ^
> >
> > Caused by commit
> >
> > 94116f8126de ("ACPI: Switch to use generic guid_t in
> > acpi_evaluate_dsm()")
> >
> > linux/uuid.h is only include for the CONFIG_ACPI case (in commit
> > 41c8bdb3ab10 "acpi, nfit: Switch to use new generic UUID
> > API"). This
> > build does not have CONFIG_ACPI set.
>
> Meh. Fix below:
Oh, indeed.
Thanks for taking care!
Acked-by: Andy Shevchenko
>
> ---
> From bcbc2265f269cc57924371e3bce8c3220d0270c5 Mon Sep 17 00:00:00 2001
> From: Christoph Hellwig
> Date: Thu, 8 Jun 2017 09:02:20 +0200
> Subject: acpi: always include uuid.h
>
> Without this the build will fail for !CONFIG_ACPI builds on x86.
>
> Fixes: 94116f81 ("ACPI: Switch to use generic guid_t in
> acpi_evaluate_dsm()")
> Signed-off-by: Christoph Hellwig
> ---
> include/linux/acpi.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/acpi.h b/include/linux/acpi.h
> index ab19365c905f..cafdfb84ca28 100644
> --- a/include/linux/acpi.h
> +++ b/include/linux/acpi.h
> @@ -26,6 +26,7 @@
> #include
> #include
> #include
> +#include
>
> #ifndef _LINUX
> #define _LINUX
> @@ -39,7 +40,6 @@
> #include
> #include
> #include
> -#include
>
> #include
> #include
--
Andy Shevchenko
Intel Finland Oy
Re: linux-next: build failure after merge of the uuid tree
On Thu, 2017-06-08 at 09:04 +0200, Christoph Hellwig wrote:
> On Thu, Jun 08, 2017 at 04:04:15PM +1000, Stephen Rothwell wrote:
> > Hi Christoph,
> >
> > After merging the uuid tree, today's linux-next build (powerpc
> > ppc64_defconfig) failed like this:
> >
> > In file included from drivers/base/cpu.c:16:0:
> > include/linux/acpi.h:744:16: error: unknown type name 'guid_t'
> > const guid_t *guid,
> > ^
> >
> > Caused by commit
> >
> > 94116f8126de ("ACPI: Switch to use generic guid_t in
> > acpi_evaluate_dsm()")
> >
> > linux/uuid.h is only include for the CONFIG_ACPI case (in commit
> > 41c8bdb3ab10 "acpi, nfit: Switch to use new generic UUID
> > API"). This
> > build does not have CONFIG_ACPI set.
>
> Meh. Fix below:
Oh, indeed.
Thanks for taking care!
Acked-by: Andy Shevchenko
>
> ---
> From bcbc2265f269cc57924371e3bce8c3220d0270c5 Mon Sep 17 00:00:00 2001
> From: Christoph Hellwig
> Date: Thu, 8 Jun 2017 09:02:20 +0200
> Subject: acpi: always include uuid.h
>
> Without this the build will fail for !CONFIG_ACPI builds on x86.
>
> Fixes: 94116f81 ("ACPI: Switch to use generic guid_t in
> acpi_evaluate_dsm()")
> Signed-off-by: Christoph Hellwig
> ---
> include/linux/acpi.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/acpi.h b/include/linux/acpi.h
> index ab19365c905f..cafdfb84ca28 100644
> --- a/include/linux/acpi.h
> +++ b/include/linux/acpi.h
> @@ -26,6 +26,7 @@
> #include
> #include
> #include
> +#include
>
> #ifndef _LINUX
> #define _LINUX
> @@ -39,7 +40,6 @@
> #include
> #include
> #include
> -#include
>
> #include
> #include
--
Andy Shevchenko
Intel Finland Oy
Re: linux-next: build failure after merge of the uuid tree
On Thu, Jun 08, 2017 at 04:04:15PM +1000, Stephen Rothwell wrote:
> Hi Christoph,
>
> After merging the uuid tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> In file included from drivers/base/cpu.c:16:0:
> include/linux/acpi.h:744:16: error: unknown type name 'guid_t'
> const guid_t *guid,
> ^
>
> Caused by commit
>
> 94116f8126de ("ACPI: Switch to use generic guid_t in acpi_evaluate_dsm()")
>
> linux/uuid.h is only include for the CONFIG_ACPI case (in commit
> 41c8bdb3ab10 "acpi, nfit: Switch to use new generic UUID API"). This
> build does not have CONFIG_ACPI set.
Meh. Fix below:
---
>From bcbc2265f269cc57924371e3bce8c3220d0270c5 Mon Sep 17 00:00:00 2001
From: Christoph Hellwig
Date: Thu, 8 Jun 2017 09:02:20 +0200
Subject: acpi: always include uuid.h
Without this the build will fail for !CONFIG_ACPI builds on x86.
Fixes: 94116f81 ("ACPI: Switch to use generic guid_t in acpi_evaluate_dsm()")
Signed-off-by: Christoph Hellwig
---
include/linux/acpi.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/acpi.h b/include/linux/acpi.h
index ab19365c905f..cafdfb84ca28 100644
--- a/include/linux/acpi.h
+++ b/include/linux/acpi.h
@@ -26,6 +26,7 @@
#include
#include
#include
+#include
#ifndef _LINUX
#define _LINUX
@@ -39,7 +40,6 @@
#include
#include
#include
-#include
#include
#include
--
2.11.0
Re: linux-next: build failure after merge of the uuid tree
On Thu, Jun 08, 2017 at 04:04:15PM +1000, Stephen Rothwell wrote:
> Hi Christoph,
>
> After merging the uuid tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> In file included from drivers/base/cpu.c:16:0:
> include/linux/acpi.h:744:16: error: unknown type name 'guid_t'
> const guid_t *guid,
> ^
>
> Caused by commit
>
> 94116f8126de ("ACPI: Switch to use generic guid_t in acpi_evaluate_dsm()")
>
> linux/uuid.h is only include for the CONFIG_ACPI case (in commit
> 41c8bdb3ab10 "acpi, nfit: Switch to use new generic UUID API"). This
> build does not have CONFIG_ACPI set.
Meh. Fix below:
---
>From bcbc2265f269cc57924371e3bce8c3220d0270c5 Mon Sep 17 00:00:00 2001
From: Christoph Hellwig
Date: Thu, 8 Jun 2017 09:02:20 +0200
Subject: acpi: always include uuid.h
Without this the build will fail for !CONFIG_ACPI builds on x86.
Fixes: 94116f81 ("ACPI: Switch to use generic guid_t in acpi_evaluate_dsm()")
Signed-off-by: Christoph Hellwig
---
include/linux/acpi.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/acpi.h b/include/linux/acpi.h
index ab19365c905f..cafdfb84ca28 100644
--- a/include/linux/acpi.h
+++ b/include/linux/acpi.h
@@ -26,6 +26,7 @@
#include
#include
#include
+#include
#ifndef _LINUX
#define _LINUX
@@ -39,7 +40,6 @@
#include
#include
#include
-#include
#include
#include
--
2.11.0
linux-next: build failure after merge of the uuid tree
Hi Christoph,
After merging the uuid tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:
In file included from drivers/base/cpu.c:16:0:
include/linux/acpi.h:744:16: error: unknown type name 'guid_t'
const guid_t *guid,
^
Caused by commit
94116f8126de ("ACPI: Switch to use generic guid_t in acpi_evaluate_dsm()")
linux/uuid.h is only include for the CONFIG_ACPI case (in commit
41c8bdb3ab10 "acpi, nfit: Switch to use new generic UUID API"). This
build does not have CONFIG_ACPI set.
I have used the uuid tree from next-20170607 for today.
--
Cheers,
Stephen Rothwell
linux-next: build failure after merge of the uuid tree
Hi Christoph,
After merging the uuid tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:
In file included from drivers/base/cpu.c:16:0:
include/linux/acpi.h:744:16: error: unknown type name 'guid_t'
const guid_t *guid,
^
Caused by commit
94116f8126de ("ACPI: Switch to use generic guid_t in acpi_evaluate_dsm()")
linux/uuid.h is only include for the CONFIG_ACPI case (in commit
41c8bdb3ab10 "acpi, nfit: Switch to use new generic UUID API"). This
build does not have CONFIG_ACPI set.
I have used the uuid tree from next-20170607 for today.
--
Cheers,
Stephen Rothwell
