Re: linux-next: build warning after merge of the drivers-x86 tree

[Andy Shevchenko]

On Thu, Feb 04, 2021 at 08:38:40AM +0100, Hans de Goede wrote:
> Hi Stephen, Andy,
> 
> On 2/4/21 6:13 AM, Stephen Rothwell wrote:
> > Hi all,
> > 
> > After merging the drivers-x86 tree, today's linux-next build (x86_64
> > allmodconfig) produced this warning:
> > 
> > drivers/platform/x86/intel_scu_wdt.c: In function 'register_mid_wdt':
> > drivers/platform/x86/intel_scu_wdt.c:66:28: warning: assignment discards 
> > 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
> >66 |  wdt_dev.dev.platform_data = (const struct intel_mid_wdt_pdata 
> > *)id->driver_data;
> >   |^
> > 
> > Introduced by commit
> > 
> >   a507e5d90f3d ("platform/x86: intel_scu_wdt: Get rid of custom x86 model 
> > comparison")
> 
> Thank you for the bug report.
> 
> Andy can you send me a fix for this please ?

Fix just has been sent.

-- 
With Best Regards,
Andy Shevchenko

Re: linux-next: build warning after merge of the drivers-x86 tree

[Hans de Goede]

Hi Stephen, Andy,

On 2/4/21 6:13 AM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the drivers-x86 tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/platform/x86/intel_scu_wdt.c: In function 'register_mid_wdt':
> drivers/platform/x86/intel_scu_wdt.c:66:28: warning: assignment discards 
> 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
>66 |  wdt_dev.dev.platform_data = (const struct intel_mid_wdt_pdata 
> *)id->driver_data;
>   |^
> 
> Introduced by commit
> 
>   a507e5d90f3d ("platform/x86: intel_scu_wdt: Get rid of custom x86 model 
> comparison")

Thank you for the bug report.

Andy can you send me a fix for this please ?

Regards,

Hans

linux-next: build warning after merge of the drivers-x86 tree

[Stephen Rothwell]

Hi all,

After merging the drivers-x86 tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/platform/x86/intel_scu_wdt.c: In function 'register_mid_wdt':
drivers/platform/x86/intel_scu_wdt.c:66:28: warning: assignment discards 
'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   66 |  wdt_dev.dev.platform_data = (const struct intel_mid_wdt_pdata 
*)id->driver_data;
  |^

Introduced by commit

  a507e5d90f3d ("platform/x86: intel_scu_wdt: Get rid of custom x86 model 
comparison")

-- 
Cheers,
Stephen Rothwell


pgp2IxpaoPtAV.pgp
Description: OpenPGP digital signature

Re: linux-next: build warning after merge of the drivers-x86 tree

[Darren Hart]

On Fri, Jun 30, 2017 at 02:00:54PM +1000, Stephen Rothwell wrote:
> Hi Darren,
> 
> After merging the drivers-x86 tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/platform/x86/sony-laptop.c: In function 'sony_laptop_setup_input':
> drivers/platform/x86/sony-laptop.c:494:19: warning: assignment discards 
> 'const' qualifier from pointer target type [-Wdiscarded-array-qualifiers]
>   key_dev->keycode = _laptop_input_keycode_map;
>^
> 
> Introduced by commit
> 
>   a0f0a5e1978b ("platform/x86: sony-laptop: constify few static structures")

Apologies, and thanks for the catch. Rolled the fix from Arnd together with this
and the new one from Arvind. for-next had to be rebased to avoid introducing
this error into mainline.

-- 
Darren Hart
VMware Open Source Technology Center

Re: linux-next: build warning after merge of the drivers-x86 tree

[Darren Hart]

On Fri, Jun 30, 2017 at 02:00:54PM +1000, Stephen Rothwell wrote:
> Hi Darren,
> 
> After merging the drivers-x86 tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/platform/x86/sony-laptop.c: In function 'sony_laptop_setup_input':
> drivers/platform/x86/sony-laptop.c:494:19: warning: assignment discards 
> 'const' qualifier from pointer target type [-Wdiscarded-array-qualifiers]
>   key_dev->keycode = _laptop_input_keycode_map;
>^
> 
> Introduced by commit
> 
>   a0f0a5e1978b ("platform/x86: sony-laptop: constify few static structures")

Apologies, and thanks for the catch. Rolled the fix from Arnd together with this
and the new one from Arvind. for-next had to be rebased to avoid introducing
this error into mainline.

-- 
Darren Hart
VMware Open Source Technology Center

Re: linux-next: build warning after merge of the drivers-x86 tree

[Arvind Yadav]

Hi,
 I have push one more patch which does not have this warning.
please avoid my first patch.

Thanks
~ arvind

On Friday 30 June 2017 09:30 AM, Stephen Rothwell wrote:

Hi Darren,

After merging the drivers-x86 tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/platform/x86/sony-laptop.c: In function 'sony_laptop_setup_input':
drivers/platform/x86/sony-laptop.c:494:19: warning: assignment discards 'const' 
qualifier from pointer target type [-Wdiscarded-array-qualifiers]
   key_dev->keycode = _laptop_input_keycode_map;
^

Introduced by commit

   a0f0a5e1978b ("platform/x86: sony-laptop: constify few static structures")

Re: linux-next: build warning after merge of the drivers-x86 tree

[Arvind Yadav]

Hi,
 I have push one more patch which does not have this warning.
please avoid my first patch.

Thanks
~ arvind

On Friday 30 June 2017 09:30 AM, Stephen Rothwell wrote:

Hi Darren,

After merging the drivers-x86 tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/platform/x86/sony-laptop.c: In function 'sony_laptop_setup_input':
drivers/platform/x86/sony-laptop.c:494:19: warning: assignment discards 'const' 
qualifier from pointer target type [-Wdiscarded-array-qualifiers]
   key_dev->keycode = _laptop_input_keycode_map;
^

Introduced by commit

   a0f0a5e1978b ("platform/x86: sony-laptop: constify few static structures")

linux-next: build warning after merge of the drivers-x86 tree

[Stephen Rothwell]

Hi Darren,

After merging the drivers-x86 tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/platform/x86/sony-laptop.c: In function 'sony_laptop_setup_input':
drivers/platform/x86/sony-laptop.c:494:19: warning: assignment discards 'const' 
qualifier from pointer target type [-Wdiscarded-array-qualifiers]
  key_dev->keycode = _laptop_input_keycode_map;
   ^

Introduced by commit

  a0f0a5e1978b ("platform/x86: sony-laptop: constify few static structures")

-- 
Cheers,
Stephen Rothwell

linux-next: build warning after merge of the drivers-x86 tree

[Stephen Rothwell]

Hi Darren,

After merging the drivers-x86 tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/platform/x86/sony-laptop.c: In function 'sony_laptop_setup_input':
drivers/platform/x86/sony-laptop.c:494:19: warning: assignment discards 'const' 
qualifier from pointer target type [-Wdiscarded-array-qualifiers]
  key_dev->keycode = _laptop_input_keycode_map;
   ^

Introduced by commit

  a0f0a5e1978b ("platform/x86: sony-laptop: constify few static structures")

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the drivers-x86 tree

[Andy Shevchenko]

On Fri, May 26, 2017 at 12:07 PM, Stephen Rothwell  
wrote:
> Hi Andy,
>
> On Fri, 26 May 2017 12:04:47 +0300 Andy Shevchenko 
>  wrote:
>>
>> On Fri, May 26, 2017 at 11:35 AM, Stephen Rothwell  
>> wrote:
>> > On Fri, 26 May 2017 10:25:36 +0200 Arnd Bergmann  wrote:
>> >>
>> >> Andy wrote that he committed an updated patch on May 23. The git tree
>> >> at 
>> >> git://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git#for-next
>> >> appears to currently contain an older state from May 15.
>> >
>> > So just not pushed out yet.  That's fine, I will hopefully notice when
>> > it turns up.  Just checking that it wasn't forgotten.
>>
>> No, it wasn't, it it in testing branch, I 'm about to push to for-next.
>
> Thanks.  No rush.

Pushed.

-- 
With Best Regards,
Andy Shevchenko

Re: linux-next: build warning after merge of the drivers-x86 tree

[Andy Shevchenko]

On Fri, May 26, 2017 at 12:07 PM, Stephen Rothwell  
wrote:
> Hi Andy,
>
> On Fri, 26 May 2017 12:04:47 +0300 Andy Shevchenko 
>  wrote:
>>
>> On Fri, May 26, 2017 at 11:35 AM, Stephen Rothwell  
>> wrote:
>> > On Fri, 26 May 2017 10:25:36 +0200 Arnd Bergmann  wrote:
>> >>
>> >> Andy wrote that he committed an updated patch on May 23. The git tree
>> >> at 
>> >> git://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git#for-next
>> >> appears to currently contain an older state from May 15.
>> >
>> > So just not pushed out yet.  That's fine, I will hopefully notice when
>> > it turns up.  Just checking that it wasn't forgotten.
>>
>> No, it wasn't, it it in testing branch, I 'm about to push to for-next.
>
> Thanks.  No rush.

Pushed.

-- 
With Best Regards,
Andy Shevchenko

Re: linux-next: build warning after merge of the drivers-x86 tree

[Andy Shevchenko]

On Fri, May 26, 2017 at 11:35 AM, Stephen Rothwell  
wrote:
> On Fri, 26 May 2017 10:25:36 +0200 Arnd Bergmann  wrote:
>>
>> Andy wrote that he committed an updated patch on May 23. The git tree
>> at 
>> git://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git#for-next
>> appears to currently contain an older state from May 15.
>
> So just not pushed out yet.  That's fine, I will hopefully notice when
> it turns up.  Just checking that it wasn't forgotten.

No, it wasn't, it it in testing branch, I 'm about to push to for-next.

-- 
With Best Regards,
Andy Shevchenko

Re: linux-next: build warning after merge of the drivers-x86 tree

[Andy Shevchenko]

On Fri, May 26, 2017 at 11:35 AM, Stephen Rothwell  
wrote:
> On Fri, 26 May 2017 10:25:36 +0200 Arnd Bergmann  wrote:
>>
>> Andy wrote that he committed an updated patch on May 23. The git tree
>> at 
>> git://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git#for-next
>> appears to currently contain an older state from May 15.
>
> So just not pushed out yet.  That's fine, I will hopefully notice when
> it turns up.  Just checking that it wasn't forgotten.

No, it wasn't, it it in testing branch, I 'm about to push to for-next.

-- 
With Best Regards,
Andy Shevchenko

Re: linux-next: build warning after merge of the drivers-x86 tree

[Stephen Rothwell]

Hi Andy,

On Fri, 26 May 2017 12:04:47 +0300 Andy Shevchenko  
wrote:
>
> On Fri, May 26, 2017 at 11:35 AM, Stephen Rothwell  
> wrote:
> > On Fri, 26 May 2017 10:25:36 +0200 Arnd Bergmann  wrote:  
> >>
> >> Andy wrote that he committed an updated patch on May 23. The git tree
> >> at 
> >> git://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git#for-next
> >> appears to currently contain an older state from May 15.  
> >
> > So just not pushed out yet.  That's fine, I will hopefully notice when
> > it turns up.  Just checking that it wasn't forgotten.  
> 
> No, it wasn't, it it in testing branch, I 'm about to push to for-next.

Thanks.  No rush.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the drivers-x86 tree

[Stephen Rothwell]

Hi Andy,

On Fri, 26 May 2017 12:04:47 +0300 Andy Shevchenko  
wrote:
>
> On Fri, May 26, 2017 at 11:35 AM, Stephen Rothwell  
> wrote:
> > On Fri, 26 May 2017 10:25:36 +0200 Arnd Bergmann  wrote:  
> >>
> >> Andy wrote that he committed an updated patch on May 23. The git tree
> >> at 
> >> git://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git#for-next
> >> appears to currently contain an older state from May 15.  
> >
> > So just not pushed out yet.  That's fine, I will hopefully notice when
> > it turns up.  Just checking that it wasn't forgotten.  
> 
> No, it wasn't, it it in testing branch, I 'm about to push to for-next.

Thanks.  No rush.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the drivers-x86 tree

[Stephen Rothwell]

Hi Arnd,

On Fri, 26 May 2017 10:25:36 +0200 Arnd Bergmann  wrote:
>
> Andy wrote that he committed an updated patch on May 23. The git tree
> at 
> git://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git#for-next
> appears to currently contain an older state from May 15.

So just not pushed out yet.  That's fine, I will hopefully notice when
it turns up.  Just checking that it wasn't forgotten.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the drivers-x86 tree

[Stephen Rothwell]

Hi Arnd,

On Fri, 26 May 2017 10:25:36 +0200 Arnd Bergmann  wrote:
>
> Andy wrote that he committed an updated patch on May 23. The git tree
> at 
> git://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git#for-next
> appears to currently contain an older state from May 15.

So just not pushed out yet.  That's fine, I will hopefully notice when
it turns up.  Just checking that it wasn't forgotten.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the drivers-x86 tree

[Arnd Bergmann]

On Fri, May 26, 2017 at 1:34 AM, Stephen Rothwell  wrote:
> On Mon, 22 May 2017 21:03:06 +0300 Andy Shevchenko 
>  wrote:
>> On Sat, May 20, 2017 at 1:09 AM, Darren Hart  wrote:
>> > On Fri, May 19, 2017 at 01:23:17PM +1000, Stephen Rothwell wrote:
>> >>
>> >> After merging the drivers-x86 tree, today's linux-next build (x86_64
>> >> allmodconfig) produced this warning:
>> >>
>> >> drivers/platform/x86/ideapad-laptop.c:438:16: warning: 'touchpad_store' 
>> >> defined but not used [-Wunused-function]
>> >>  static ssize_t touchpad_store(struct device *dev,
>> >> ^
>> >>
>> >> Introduced by commit
>> >>
>> >>   7f363145992c ("platform/x86: ideapad-laptop: Switch touchpad attribute 
>> >> to be RO")
>> >
>> >
>> > Andy, you warned me about this and I had forgotten before I included it in 
>> > next.
>> >
>> > Would you like to drop this change, or drop the touchpad_store function?
>>
>> I would go with Arnd's patch if he respins one addressing my comment.
>
> Any progress on this?

Andy wrote that he committed an updated patch on May 23. The git tree
at git://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git#for-next
appears to currently contain an older state from May 15.

Arnd

Re: linux-next: build warning after merge of the drivers-x86 tree

[Arnd Bergmann]

On Fri, May 26, 2017 at 1:34 AM, Stephen Rothwell  wrote:
> On Mon, 22 May 2017 21:03:06 +0300 Andy Shevchenko 
>  wrote:
>> On Sat, May 20, 2017 at 1:09 AM, Darren Hart  wrote:
>> > On Fri, May 19, 2017 at 01:23:17PM +1000, Stephen Rothwell wrote:
>> >>
>> >> After merging the drivers-x86 tree, today's linux-next build (x86_64
>> >> allmodconfig) produced this warning:
>> >>
>> >> drivers/platform/x86/ideapad-laptop.c:438:16: warning: 'touchpad_store' 
>> >> defined but not used [-Wunused-function]
>> >>  static ssize_t touchpad_store(struct device *dev,
>> >> ^
>> >>
>> >> Introduced by commit
>> >>
>> >>   7f363145992c ("platform/x86: ideapad-laptop: Switch touchpad attribute 
>> >> to be RO")
>> >
>> >
>> > Andy, you warned me about this and I had forgotten before I included it in 
>> > next.
>> >
>> > Would you like to drop this change, or drop the touchpad_store function?
>>
>> I would go with Arnd's patch if he respins one addressing my comment.
>
> Any progress on this?

Andy wrote that he committed an updated patch on May 23. The git tree
at git://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git#for-next
appears to currently contain an older state from May 15.

Arnd

Re: linux-next: build warning after merge of the drivers-x86 tree

[Stephen Rothwell]

Hi Andy,

On Mon, 22 May 2017 21:03:06 +0300 Andy Shevchenko  
wrote:
>
> On Sat, May 20, 2017 at 1:09 AM, Darren Hart  wrote:
> > On Fri, May 19, 2017 at 01:23:17PM +1000, Stephen Rothwell wrote:  
> >>
> >> After merging the drivers-x86 tree, today's linux-next build (x86_64
> >> allmodconfig) produced this warning:
> >>
> >> drivers/platform/x86/ideapad-laptop.c:438:16: warning: 'touchpad_store' 
> >> defined but not used [-Wunused-function]
> >>  static ssize_t touchpad_store(struct device *dev,
> >> ^
> >>
> >> Introduced by commit
> >>
> >>   7f363145992c ("platform/x86: ideapad-laptop: Switch touchpad attribute 
> >> to be RO")  
> >
> >
> > Andy, you warned me about this and I had forgotten before I included it in 
> > next.
> >
> > Would you like to drop this change, or drop the touchpad_store function?  
> 
> I would go with Arnd's patch if he respins one addressing my comment.

Any progress on this?

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the drivers-x86 tree

[Stephen Rothwell]

Hi Andy,

On Mon, 22 May 2017 21:03:06 +0300 Andy Shevchenko  
wrote:
>
> On Sat, May 20, 2017 at 1:09 AM, Darren Hart  wrote:
> > On Fri, May 19, 2017 at 01:23:17PM +1000, Stephen Rothwell wrote:  
> >>
> >> After merging the drivers-x86 tree, today's linux-next build (x86_64
> >> allmodconfig) produced this warning:
> >>
> >> drivers/platform/x86/ideapad-laptop.c:438:16: warning: 'touchpad_store' 
> >> defined but not used [-Wunused-function]
> >>  static ssize_t touchpad_store(struct device *dev,
> >> ^
> >>
> >> Introduced by commit
> >>
> >>   7f363145992c ("platform/x86: ideapad-laptop: Switch touchpad attribute 
> >> to be RO")  
> >
> >
> > Andy, you warned me about this and I had forgotten before I included it in 
> > next.
> >
> > Would you like to drop this change, or drop the touchpad_store function?  
> 
> I would go with Arnd's patch if he respins one addressing my comment.

Any progress on this?

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the drivers-x86 tree

[Andy Shevchenko]

On Sat, May 20, 2017 at 1:09 AM, Darren Hart  wrote:
> On Fri, May 19, 2017 at 01:23:17PM +1000, Stephen Rothwell wrote:
>> Hi Darren,
>>
>> After merging the drivers-x86 tree, today's linux-next build (x86_64
>> allmodconfig) produced this warning:
>>
>> drivers/platform/x86/ideapad-laptop.c:438:16: warning: 'touchpad_store' 
>> defined but not used [-Wunused-function]
>>  static ssize_t touchpad_store(struct device *dev,
>> ^
>>
>> Introduced by commit
>>
>>   7f363145992c ("platform/x86: ideapad-laptop: Switch touchpad attribute to 
>> be RO")
>
> Thank you Stephen,
>
> Andy, you warned me about this and I had forgotten before I included it in 
> next.
>
> Would you like to drop this change, or drop the touchpad_store function?

I would go with Arnd's patch if he respins one addressing my comment.

-- 
With Best Regards,
Andy Shevchenko

Re: linux-next: build warning after merge of the drivers-x86 tree

[Andy Shevchenko]

On Sat, May 20, 2017 at 1:09 AM, Darren Hart  wrote:
> On Fri, May 19, 2017 at 01:23:17PM +1000, Stephen Rothwell wrote:
>> Hi Darren,
>>
>> After merging the drivers-x86 tree, today's linux-next build (x86_64
>> allmodconfig) produced this warning:
>>
>> drivers/platform/x86/ideapad-laptop.c:438:16: warning: 'touchpad_store' 
>> defined but not used [-Wunused-function]
>>  static ssize_t touchpad_store(struct device *dev,
>> ^
>>
>> Introduced by commit
>>
>>   7f363145992c ("platform/x86: ideapad-laptop: Switch touchpad attribute to 
>> be RO")
>
> Thank you Stephen,
>
> Andy, you warned me about this and I had forgotten before I included it in 
> next.
>
> Would you like to drop this change, or drop the touchpad_store function?

I would go with Arnd's patch if he respins one addressing my comment.

-- 
With Best Regards,
Andy Shevchenko

Re: linux-next: build warning after merge of the drivers-x86 tree

[Darren Hart]

On Fri, May 19, 2017 at 01:23:17PM +1000, Stephen Rothwell wrote:
> Hi Darren,
> 
> After merging the drivers-x86 tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/platform/x86/ideapad-laptop.c:438:16: warning: 'touchpad_store' 
> defined but not used [-Wunused-function]
>  static ssize_t touchpad_store(struct device *dev,
> ^
> 
> Introduced by commit
> 
>   7f363145992c ("platform/x86: ideapad-laptop: Switch touchpad attribute to 
> be RO")

Thank you Stephen,

Andy, you warned me about this and I had forgotten before I included it in next.

Would you like to drop this change, or drop the touchpad_store function?

-- 
Darren Hart
VMware Open Source Technology Center

Re: linux-next: build warning after merge of the drivers-x86 tree

[Darren Hart]

On Fri, May 19, 2017 at 01:23:17PM +1000, Stephen Rothwell wrote:
> Hi Darren,
> 
> After merging the drivers-x86 tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/platform/x86/ideapad-laptop.c:438:16: warning: 'touchpad_store' 
> defined but not used [-Wunused-function]
>  static ssize_t touchpad_store(struct device *dev,
> ^
> 
> Introduced by commit
> 
>   7f363145992c ("platform/x86: ideapad-laptop: Switch touchpad attribute to 
> be RO")

Thank you Stephen,

Andy, you warned me about this and I had forgotten before I included it in next.

Would you like to drop this change, or drop the touchpad_store function?

-- 
Darren Hart
VMware Open Source Technology Center

linux-next: build warning after merge of the drivers-x86 tree

[Stephen Rothwell]

Hi Darren,

After merging the drivers-x86 tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/platform/x86/ideapad-laptop.c:438:16: warning: 'touchpad_store' defined 
but not used [-Wunused-function]
 static ssize_t touchpad_store(struct device *dev,
^

Introduced by commit

  7f363145992c ("platform/x86: ideapad-laptop: Switch touchpad attribute to be 
RO")

-- 
Cheers,
Stephen Rothwell

linux-next: build warning after merge of the drivers-x86 tree

[Stephen Rothwell]

Hi Darren,

After merging the drivers-x86 tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/platform/x86/ideapad-laptop.c:438:16: warning: 'touchpad_store' defined 
but not used [-Wunused-function]
 static ssize_t touchpad_store(struct device *dev,
^

Introduced by commit

  7f363145992c ("platform/x86: ideapad-laptop: Switch touchpad attribute to be 
RO")

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the drivers-x86 tree

[Darren Hart]

On Thu, Dec 15, 2016 at 11:02:19AM +1100, Stephen Rothwell wrote:
> Hi Darren,
> 
> On Wed, 14 Dec 2016 14:59:14 -0800 Darren Hart  wrote:
> >
> > On Wed, Dec 14, 2016 at 02:21:38PM -0800, Darren Hart wrote:
> > > On Wed, Dec 14, 2016 at 01:50:44PM +1100, Stephen Rothwell wrote:  
> > > > 
> > > > After merging the drivers-x86 tree, today's linux-next build (x86_64
> > > > allmodconfig) produced this warning:
> > > > 
> > > > In file included from include/linux/kernel.h:13:0,
> > > >  from drivers/platform/x86/thinkpad_acpi.c:52:
> > > > drivers/platform/x86/thinkpad_acpi.c: In function 'hotkey_init':
> > > > include/linux/printk.h:299:2: warning: 'type' may be used uninitialized 
> > > > in this function [-Wmaybe-uninitialized]
> > > >   printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
> > > >   ^
> > > > drivers/platform/x86/thinkpad_acpi.c:3147:8: note: 'type' was declared 
> > > > here
> > > >   char *type;
> > > > ^
> > > > In file included from include/linux/kernel.h:13:0,
> > > >  from drivers/platform/x86/thinkpad_acpi.c:52:
> > > > include/linux/printk.h:299:2: warning: 'in_tablet_mode' may be used 
> > > > uninitialized in this function [-Wmaybe-uninitialized]
> > > >   printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
> > > >   ^
> > > > drivers/platform/x86/thinkpad_acpi.c:3146:6: note: 'in_tablet_mode' was 
> > > > declared here
> > > >   int in_tablet_mode, res;
> > > >   ^
> > > > 
> > > > Introduced by commit
> > > > 
> > > >   b31800283868 ("platform/x86: thinkpad_acpi: Move tablet detection 
> > > > into separate function")
> > > > 
> > > > I can't tell if this is a false positive or not.  
> > > 
> > > That's an uninitialized local variable. Not sure how I missed that. I'll
> > > fix it up today. Thank you for the report.  
> > 
> > OK, no, it's a false positive because tp_features.hotkey_tablet is assigned 
> > in
> > both places where in_tablet_mode is assigned, and if the former is 0 (global
> > scope), the function returns without calling pr_info.
> 
> How about "type".

Ooops, indeed. Same exact issue. I'll update the patch.

-- 
Darren Hart
Intel Open Source Technology Center

Re: linux-next: build warning after merge of the drivers-x86 tree

[Darren Hart]

On Thu, Dec 15, 2016 at 11:02:19AM +1100, Stephen Rothwell wrote:
> Hi Darren,
> 
> On Wed, 14 Dec 2016 14:59:14 -0800 Darren Hart  wrote:
> >
> > On Wed, Dec 14, 2016 at 02:21:38PM -0800, Darren Hart wrote:
> > > On Wed, Dec 14, 2016 at 01:50:44PM +1100, Stephen Rothwell wrote:  
> > > > 
> > > > After merging the drivers-x86 tree, today's linux-next build (x86_64
> > > > allmodconfig) produced this warning:
> > > > 
> > > > In file included from include/linux/kernel.h:13:0,
> > > >  from drivers/platform/x86/thinkpad_acpi.c:52:
> > > > drivers/platform/x86/thinkpad_acpi.c: In function 'hotkey_init':
> > > > include/linux/printk.h:299:2: warning: 'type' may be used uninitialized 
> > > > in this function [-Wmaybe-uninitialized]
> > > >   printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
> > > >   ^
> > > > drivers/platform/x86/thinkpad_acpi.c:3147:8: note: 'type' was declared 
> > > > here
> > > >   char *type;
> > > > ^
> > > > In file included from include/linux/kernel.h:13:0,
> > > >  from drivers/platform/x86/thinkpad_acpi.c:52:
> > > > include/linux/printk.h:299:2: warning: 'in_tablet_mode' may be used 
> > > > uninitialized in this function [-Wmaybe-uninitialized]
> > > >   printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
> > > >   ^
> > > > drivers/platform/x86/thinkpad_acpi.c:3146:6: note: 'in_tablet_mode' was 
> > > > declared here
> > > >   int in_tablet_mode, res;
> > > >   ^
> > > > 
> > > > Introduced by commit
> > > > 
> > > >   b31800283868 ("platform/x86: thinkpad_acpi: Move tablet detection 
> > > > into separate function")
> > > > 
> > > > I can't tell if this is a false positive or not.  
> > > 
> > > That's an uninitialized local variable. Not sure how I missed that. I'll
> > > fix it up today. Thank you for the report.  
> > 
> > OK, no, it's a false positive because tp_features.hotkey_tablet is assigned 
> > in
> > both places where in_tablet_mode is assigned, and if the former is 0 (global
> > scope), the function returns without calling pr_info.
> 
> How about "type".

Ooops, indeed. Same exact issue. I'll update the patch.

-- 
Darren Hart
Intel Open Source Technology Center

Re: linux-next: build warning after merge of the drivers-x86 tree

[Stephen Rothwell]

Hi Darren,

On Wed, 14 Dec 2016 14:59:14 -0800 Darren Hart  wrote:
>
> On Wed, Dec 14, 2016 at 02:21:38PM -0800, Darren Hart wrote:
> > On Wed, Dec 14, 2016 at 01:50:44PM +1100, Stephen Rothwell wrote:  
> > > 
> > > After merging the drivers-x86 tree, today's linux-next build (x86_64
> > > allmodconfig) produced this warning:
> > > 
> > > In file included from include/linux/kernel.h:13:0,
> > >  from drivers/platform/x86/thinkpad_acpi.c:52:
> > > drivers/platform/x86/thinkpad_acpi.c: In function 'hotkey_init':
> > > include/linux/printk.h:299:2: warning: 'type' may be used uninitialized 
> > > in this function [-Wmaybe-uninitialized]
> > >   printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
> > >   ^
> > > drivers/platform/x86/thinkpad_acpi.c:3147:8: note: 'type' was declared 
> > > here
> > >   char *type;
> > > ^
> > > In file included from include/linux/kernel.h:13:0,
> > >  from drivers/platform/x86/thinkpad_acpi.c:52:
> > > include/linux/printk.h:299:2: warning: 'in_tablet_mode' may be used 
> > > uninitialized in this function [-Wmaybe-uninitialized]
> > >   printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
> > >   ^
> > > drivers/platform/x86/thinkpad_acpi.c:3146:6: note: 'in_tablet_mode' was 
> > > declared here
> > >   int in_tablet_mode, res;
> > >   ^
> > > 
> > > Introduced by commit
> > > 
> > >   b31800283868 ("platform/x86: thinkpad_acpi: Move tablet detection into 
> > > separate function")
> > > 
> > > I can't tell if this is a false positive or not.  
> > 
> > That's an uninitialized local variable. Not sure how I missed that. I'll
> > fix it up today. Thank you for the report.  
> 
> OK, no, it's a false positive because tp_features.hotkey_tablet is assigned in
> both places where in_tablet_mode is assigned, and if the former is 0 (global
> scope), the function returns without calling pr_info.

How about "type".

> Lyude, Henrique, please confirm.
> 
> Regardless, I'll add a patch to init in_tablet_mode to 0 so it is explicit - 
> but
> will not rebase as it isn't technically an error.

No problem, it is only a warning after all.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the drivers-x86 tree

[Stephen Rothwell]

Hi Darren,

On Wed, 14 Dec 2016 14:59:14 -0800 Darren Hart  wrote:
>
> On Wed, Dec 14, 2016 at 02:21:38PM -0800, Darren Hart wrote:
> > On Wed, Dec 14, 2016 at 01:50:44PM +1100, Stephen Rothwell wrote:  
> > > 
> > > After merging the drivers-x86 tree, today's linux-next build (x86_64
> > > allmodconfig) produced this warning:
> > > 
> > > In file included from include/linux/kernel.h:13:0,
> > >  from drivers/platform/x86/thinkpad_acpi.c:52:
> > > drivers/platform/x86/thinkpad_acpi.c: In function 'hotkey_init':
> > > include/linux/printk.h:299:2: warning: 'type' may be used uninitialized 
> > > in this function [-Wmaybe-uninitialized]
> > >   printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
> > >   ^
> > > drivers/platform/x86/thinkpad_acpi.c:3147:8: note: 'type' was declared 
> > > here
> > >   char *type;
> > > ^
> > > In file included from include/linux/kernel.h:13:0,
> > >  from drivers/platform/x86/thinkpad_acpi.c:52:
> > > include/linux/printk.h:299:2: warning: 'in_tablet_mode' may be used 
> > > uninitialized in this function [-Wmaybe-uninitialized]
> > >   printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
> > >   ^
> > > drivers/platform/x86/thinkpad_acpi.c:3146:6: note: 'in_tablet_mode' was 
> > > declared here
> > >   int in_tablet_mode, res;
> > >   ^
> > > 
> > > Introduced by commit
> > > 
> > >   b31800283868 ("platform/x86: thinkpad_acpi: Move tablet detection into 
> > > separate function")
> > > 
> > > I can't tell if this is a false positive or not.  
> > 
> > That's an uninitialized local variable. Not sure how I missed that. I'll
> > fix it up today. Thank you for the report.  
> 
> OK, no, it's a false positive because tp_features.hotkey_tablet is assigned in
> both places where in_tablet_mode is assigned, and if the former is 0 (global
> scope), the function returns without calling pr_info.

How about "type".

> Lyude, Henrique, please confirm.
> 
> Regardless, I'll add a patch to init in_tablet_mode to 0 so it is explicit - 
> but
> will not rebase as it isn't technically an error.

No problem, it is only a warning after all.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the drivers-x86 tree

[Darren Hart]

On Wed, Dec 14, 2016 at 02:21:38PM -0800, Darren Hart wrote:
> On Wed, Dec 14, 2016 at 01:50:44PM +1100, Stephen Rothwell wrote:
> > Hi Darren,
> > 
> > After merging the drivers-x86 tree, today's linux-next build (x86_64
> > allmodconfig) produced this warning:
> > 
> > In file included from include/linux/kernel.h:13:0,
> >  from drivers/platform/x86/thinkpad_acpi.c:52:
> > drivers/platform/x86/thinkpad_acpi.c: In function 'hotkey_init':
> > include/linux/printk.h:299:2: warning: 'type' may be used uninitialized in 
> > this function [-Wmaybe-uninitialized]
> >   printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
> >   ^
> > drivers/platform/x86/thinkpad_acpi.c:3147:8: note: 'type' was declared here
> >   char *type;
> > ^
> > In file included from include/linux/kernel.h:13:0,
> >  from drivers/platform/x86/thinkpad_acpi.c:52:
> > include/linux/printk.h:299:2: warning: 'in_tablet_mode' may be used 
> > uninitialized in this function [-Wmaybe-uninitialized]
> >   printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
> >   ^
> > drivers/platform/x86/thinkpad_acpi.c:3146:6: note: 'in_tablet_mode' was 
> > declared here
> >   int in_tablet_mode, res;
> >   ^
> > 
> > Introduced by commit
> > 
> >   b31800283868 ("platform/x86: thinkpad_acpi: Move tablet detection into 
> > separate function")
> > 
> > I can't tell if this is a false positive or not.
> 
> That's an uninitialized local variable. Not sure how I missed that. I'll
> fix it up today. Thank you for the report.

OK, no, it's a false positive because tp_features.hotkey_tablet is assigned in
both places where in_tablet_mode is assigned, and if the former is 0 (global
scope), the function returns without calling pr_info.

Lyude, Henrique, please confirm.

Regardless, I'll add a patch to init in_tablet_mode to 0 so it is explicit - but
will not rebase as it isn't technically an error.

-- 
Darren Hart
Intel Open Source Technology Center

Re: linux-next: build warning after merge of the drivers-x86 tree

[Darren Hart]

On Wed, Dec 14, 2016 at 02:21:38PM -0800, Darren Hart wrote:
> On Wed, Dec 14, 2016 at 01:50:44PM +1100, Stephen Rothwell wrote:
> > Hi Darren,
> > 
> > After merging the drivers-x86 tree, today's linux-next build (x86_64
> > allmodconfig) produced this warning:
> > 
> > In file included from include/linux/kernel.h:13:0,
> >  from drivers/platform/x86/thinkpad_acpi.c:52:
> > drivers/platform/x86/thinkpad_acpi.c: In function 'hotkey_init':
> > include/linux/printk.h:299:2: warning: 'type' may be used uninitialized in 
> > this function [-Wmaybe-uninitialized]
> >   printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
> >   ^
> > drivers/platform/x86/thinkpad_acpi.c:3147:8: note: 'type' was declared here
> >   char *type;
> > ^
> > In file included from include/linux/kernel.h:13:0,
> >  from drivers/platform/x86/thinkpad_acpi.c:52:
> > include/linux/printk.h:299:2: warning: 'in_tablet_mode' may be used 
> > uninitialized in this function [-Wmaybe-uninitialized]
> >   printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
> >   ^
> > drivers/platform/x86/thinkpad_acpi.c:3146:6: note: 'in_tablet_mode' was 
> > declared here
> >   int in_tablet_mode, res;
> >   ^
> > 
> > Introduced by commit
> > 
> >   b31800283868 ("platform/x86: thinkpad_acpi: Move tablet detection into 
> > separate function")
> > 
> > I can't tell if this is a false positive or not.
> 
> That's an uninitialized local variable. Not sure how I missed that. I'll
> fix it up today. Thank you for the report.

OK, no, it's a false positive because tp_features.hotkey_tablet is assigned in
both places where in_tablet_mode is assigned, and if the former is 0 (global
scope), the function returns without calling pr_info.

Lyude, Henrique, please confirm.

Regardless, I'll add a patch to init in_tablet_mode to 0 so it is explicit - but
will not rebase as it isn't technically an error.

-- 
Darren Hart
Intel Open Source Technology Center

Re: linux-next: build warning after merge of the drivers-x86 tree

[Darren Hart]

On Wed, Dec 14, 2016 at 01:50:44PM +1100, Stephen Rothwell wrote:
> Hi Darren,
> 
> After merging the drivers-x86 tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> In file included from include/linux/kernel.h:13:0,
>  from drivers/platform/x86/thinkpad_acpi.c:52:
> drivers/platform/x86/thinkpad_acpi.c: In function 'hotkey_init':
> include/linux/printk.h:299:2: warning: 'type' may be used uninitialized in 
> this function [-Wmaybe-uninitialized]
>   printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
>   ^
> drivers/platform/x86/thinkpad_acpi.c:3147:8: note: 'type' was declared here
>   char *type;
> ^
> In file included from include/linux/kernel.h:13:0,
>  from drivers/platform/x86/thinkpad_acpi.c:52:
> include/linux/printk.h:299:2: warning: 'in_tablet_mode' may be used 
> uninitialized in this function [-Wmaybe-uninitialized]
>   printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
>   ^
> drivers/platform/x86/thinkpad_acpi.c:3146:6: note: 'in_tablet_mode' was 
> declared here
>   int in_tablet_mode, res;
>   ^
> 
> Introduced by commit
> 
>   b31800283868 ("platform/x86: thinkpad_acpi: Move tablet detection into 
> separate function")
> 
> I can't tell if this is a false positive or not.

That's an uninitialized local variable. Not sure how I missed that. I'll
fix it up today. Thank you for the report.

-- 
Darren Hart
Intel Open Source Technology Center

Re: linux-next: build warning after merge of the drivers-x86 tree

[Darren Hart]

On Wed, Dec 14, 2016 at 01:50:44PM +1100, Stephen Rothwell wrote:
> Hi Darren,
> 
> After merging the drivers-x86 tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> In file included from include/linux/kernel.h:13:0,
>  from drivers/platform/x86/thinkpad_acpi.c:52:
> drivers/platform/x86/thinkpad_acpi.c: In function 'hotkey_init':
> include/linux/printk.h:299:2: warning: 'type' may be used uninitialized in 
> this function [-Wmaybe-uninitialized]
>   printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
>   ^
> drivers/platform/x86/thinkpad_acpi.c:3147:8: note: 'type' was declared here
>   char *type;
> ^
> In file included from include/linux/kernel.h:13:0,
>  from drivers/platform/x86/thinkpad_acpi.c:52:
> include/linux/printk.h:299:2: warning: 'in_tablet_mode' may be used 
> uninitialized in this function [-Wmaybe-uninitialized]
>   printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
>   ^
> drivers/platform/x86/thinkpad_acpi.c:3146:6: note: 'in_tablet_mode' was 
> declared here
>   int in_tablet_mode, res;
>   ^
> 
> Introduced by commit
> 
>   b31800283868 ("platform/x86: thinkpad_acpi: Move tablet detection into 
> separate function")
> 
> I can't tell if this is a false positive or not.

That's an uninitialized local variable. Not sure how I missed that. I'll
fix it up today. Thank you for the report.

-- 
Darren Hart
Intel Open Source Technology Center

linux-next: build warning after merge of the drivers-x86 tree

[Stephen Rothwell]

Hi Darren,

After merging the drivers-x86 tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

In file included from include/linux/kernel.h:13:0,
 from drivers/platform/x86/thinkpad_acpi.c:52:
drivers/platform/x86/thinkpad_acpi.c: In function 'hotkey_init':
include/linux/printk.h:299:2: warning: 'type' may be used uninitialized in this 
function [-Wmaybe-uninitialized]
  printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
  ^
drivers/platform/x86/thinkpad_acpi.c:3147:8: note: 'type' was declared here
  char *type;
^
In file included from include/linux/kernel.h:13:0,
 from drivers/platform/x86/thinkpad_acpi.c:52:
include/linux/printk.h:299:2: warning: 'in_tablet_mode' may be used 
uninitialized in this function [-Wmaybe-uninitialized]
  printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
  ^
drivers/platform/x86/thinkpad_acpi.c:3146:6: note: 'in_tablet_mode' was 
declared here
  int in_tablet_mode, res;
  ^

Introduced by commit

  b31800283868 ("platform/x86: thinkpad_acpi: Move tablet detection into 
separate function")

I can't tell if this is a false positive or not.

-- 
Cheers,
Stephen Rothwell

linux-next: build warning after merge of the drivers-x86 tree

[Stephen Rothwell]

Hi Darren,

After merging the drivers-x86 tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

In file included from include/linux/kernel.h:13:0,
 from drivers/platform/x86/thinkpad_acpi.c:52:
drivers/platform/x86/thinkpad_acpi.c: In function 'hotkey_init':
include/linux/printk.h:299:2: warning: 'type' may be used uninitialized in this 
function [-Wmaybe-uninitialized]
  printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
  ^
drivers/platform/x86/thinkpad_acpi.c:3147:8: note: 'type' was declared here
  char *type;
^
In file included from include/linux/kernel.h:13:0,
 from drivers/platform/x86/thinkpad_acpi.c:52:
include/linux/printk.h:299:2: warning: 'in_tablet_mode' may be used 
uninitialized in this function [-Wmaybe-uninitialized]
  printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
  ^
drivers/platform/x86/thinkpad_acpi.c:3146:6: note: 'in_tablet_mode' was 
declared here
  int in_tablet_mode, res;
  ^

Introduced by commit

  b31800283868 ("platform/x86: thinkpad_acpi: Move tablet detection into 
separate function")

I can't tell if this is a false positive or not.

-- 
Cheers,
Stephen Rothwell