Re: mm snapshot broken-out-2007-11-20-01-45.tar.gz uploaded

2007-11-21 Thread David Howells

What does broken-out-2007-11-20-01-45.tar.gz apply to?  I can't get it to
apply to either Linus's current GIT tree or the 2.6.24-rc3 tree.  Both result
in errors.

On the other hand, I have managed to adjust my patches to work with the
2.6.24-rc3-mm1 applied to 2.6.24-rc3.  It builds for:

MN10300 defconfig
MN10300 allnoconfig
X86_64 defconfig CONFIG_IA32_AOUT=n
X86_64 defconfig CONFIG_IA32_AOUT=m
X86_64 defconfig CONFIG_IA32_AOUT=y
i386 defconfig CONFIG_BINFMT_AOUT=n
i386 defconfig CONFIG_BINFMT_AOUT=m
i386 defconfig CONFIG_BINFMT_AOUT=y
sparc defconfig
sparc64 defconfig CONFIG_BINFMT_AOUT32=n
sparc64 defconfig CONFIG_BINFMT_AOUT32=y

It almost completely builds for MN10300 allyesconfig and allmodconfig, but for
asm/kvm.h not existing (header checking bug?) and a sample program not
compiling (uses something not provided by most arches).

Most other arches just don't compile to some extent or other for reasons that
aren't to do with my patches, but mostly due to pgtable_t not being defined.

I can even use the MN10300 defconfig kernel:

-bash-3.00# uname -a
Linux asb2303-4 2.6.24-rc3-mm1-g026f9b13 #3 PREEMPT Wed Nov 21 15:02:37 
GMT 2007 mn10300 mn10300 mn10300 GNU/Linux

Note, however, I don't expect these modified patches to necessarily work with
Linus's kernel.  There seem to be some general changes in -mm that I don't
know whether you'll be sending them upstream or not.

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: mm snapshot broken-out-2007-11-20-01-45.tar.gz uploaded

2007-11-21 Thread David Howells
Andrew Morton <[EMAIL PROTECTED]> wrote:

> So... what went wrong with broken-out-2007-11-20-01-45.tar.gz?

It differs too much from Linus's base.

> But sometimes it doesn't work out very well.  There's lot of stuff
> outstanding again.  Immediate problems are from an x86 exec randomisation
> thingy in git-x86 and pie-executable-randomization.patch in -mm, which both
> hit on binfmt_elf.c

Hmmm...  I can't apply your combined patch:


ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc3/2.6.24-rc3-mm1/2.6.24-rc3-mm1.bz2

to Linus's GIT tree.  Quite a few errors occur.  Do you just use Linus's
released tarball as a base?

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: mm snapshot broken-out-2007-11-20-01-45.tar.gz uploaded

2007-11-21 Thread David Howells
Andrew Morton [EMAIL PROTECTED] wrote:

 So... what went wrong with broken-out-2007-11-20-01-45.tar.gz?

It differs too much from Linus's base.

 But sometimes it doesn't work out very well.  There's lot of stuff
 outstanding again.  Immediate problems are from an x86 exec randomisation
 thingy in git-x86 and pie-executable-randomization.patch in -mm, which both
 hit on binfmt_elf.c

Hmmm...  I can't apply your combined patch:


ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc3/2.6.24-rc3-mm1/2.6.24-rc3-mm1.bz2

to Linus's GIT tree.  Quite a few errors occur.  Do you just use Linus's
released tarball as a base?

David
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: mm snapshot broken-out-2007-11-20-01-45.tar.gz uploaded

2007-11-21 Thread David Howells

What does broken-out-2007-11-20-01-45.tar.gz apply to?  I can't get it to
apply to either Linus's current GIT tree or the 2.6.24-rc3 tree.  Both result
in errors.

On the other hand, I have managed to adjust my patches to work with the
2.6.24-rc3-mm1 applied to 2.6.24-rc3.  It builds for:

MN10300 defconfig
MN10300 allnoconfig
X86_64 defconfig CONFIG_IA32_AOUT=n
X86_64 defconfig CONFIG_IA32_AOUT=m
X86_64 defconfig CONFIG_IA32_AOUT=y
i386 defconfig CONFIG_BINFMT_AOUT=n
i386 defconfig CONFIG_BINFMT_AOUT=m
i386 defconfig CONFIG_BINFMT_AOUT=y
sparc defconfig
sparc64 defconfig CONFIG_BINFMT_AOUT32=n
sparc64 defconfig CONFIG_BINFMT_AOUT32=y

It almost completely builds for MN10300 allyesconfig and allmodconfig, but for
asm/kvm.h not existing (header checking bug?) and a sample program not
compiling (uses something not provided by most arches).

Most other arches just don't compile to some extent or other for reasons that
aren't to do with my patches, but mostly due to pgtable_t not being defined.

I can even use the MN10300 defconfig kernel:

-bash-3.00# uname -a
Linux asb2303-4 2.6.24-rc3-mm1-g026f9b13 #3 PREEMPT Wed Nov 21 15:02:37 
GMT 2007 mn10300 mn10300 mn10300 GNU/Linux

Note, however, I don't expect these modified patches to necessarily work with
Linus's kernel.  There seem to be some general changes in -mm that I don't
know whether you'll be sending them upstream or not.

David
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: mm snapshot broken-out-2007-11-20-01-45.tar.gz uploaded

2007-11-20 Thread Andrew Morton
On Wed, 21 Nov 2007 01:32:48 + David Howells <[EMAIL PROTECTED]> wrote:

> Andrew Morton <[EMAIL PROTECTED]> wrote:
> 
> > > The patch
> > > aout-suppress-aout-library-support-if-config_arch_supports_aout.patch,
> > > creates a struct exec in linux/a.out.h and asm/a.out.h already has it, for
> > > the struct related warnings.
> 
> Nothing should be including {asm,linux}/a.out.h unless it absolutely needs it.
> I removed all the places it did so extraneously, after moving out STACK_TOP.

So... what went wrong with broken-out-2007-11-20-01-45.tar.gz?

> > OK, I've had it with trying to get that patch to vaguely work.  I'll drop
> > it and will then fix up the extensive dependency trail which it drags along
> > behind it.
> > 
> > David, please do not bring it back until it has had a *lot* of testing.
> 
> It compiles for all the archs for which I have a compiler, and the x86_64 and
> i386 kernels all build and boot for the following combinations of AOUT
> configs:
> 
>   x86_64  CONFIG_IA32_AOUT=n
>   CONFIG_IA32_AOUT=y
>   CONFIG_IA32_AOUT=m
>   i386CONFIG_BINFMT_AOUT=n
>   CONFIG_BINFMT_AOUT=y
>   CONFIG_BINFMT_AOUT=m
> 
> It seems I had forgetten to include:
> 
>   config ARCH_SUPPORTS_AOUT
>   def_bool y
> 
> in arch/x86/Kconfig, but it builds without that too for both subarchs.
> 
> The kernel also builds and boots for MN10300 and FRV.
> 
> 
> The problem is that your -mm patchset doesn't match Linus's as a base.  I'm
> still not sure what the right procedure is for that.  I can give you some
> altered patches, but there's no guarantee you'll be able to pass them on to
> Linus without breaking his tree.  What do *you* want?

Often when people base a patch on -mm it is worse than basing it on
mainline - I usually prefer patches against mainline; partly because that's
less work for originators too.

But sometimes it doesn't work out very well.  There's lot of stuff
outstanding again.  Immediate problems are from an x86 exec randomisation
thingy in git-x86 and pie-executable-randomization.patch in -mm, which both
hit on binfmt_elf.c

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: mm snapshot broken-out-2007-11-20-01-45.tar.gz uploaded

2007-11-20 Thread David Howells
Andrew Morton <[EMAIL PROTECTED]> wrote:

> > The patch
> > aout-suppress-aout-library-support-if-config_arch_supports_aout.patch,
> > creates a struct exec in linux/a.out.h and asm/a.out.h already has it, for
> > the struct related warnings.

Nothing should be including {asm,linux}/a.out.h unless it absolutely needs it.
I removed all the places it did so extraneously, after moving out STACK_TOP.

> OK, I've had it with trying to get that patch to vaguely work.  I'll drop
> it and will then fix up the extensive dependency trail which it drags along
> behind it.
> 
> David, please do not bring it back until it has had a *lot* of testing.

It compiles for all the archs for which I have a compiler, and the x86_64 and
i386 kernels all build and boot for the following combinations of AOUT
configs:

x86_64  CONFIG_IA32_AOUT=n
CONFIG_IA32_AOUT=y
CONFIG_IA32_AOUT=m
i386CONFIG_BINFMT_AOUT=n
CONFIG_BINFMT_AOUT=y
CONFIG_BINFMT_AOUT=m

It seems I had forgetten to include:

config ARCH_SUPPORTS_AOUT
def_bool y

in arch/x86/Kconfig, but it builds without that too for both subarchs.

The kernel also builds and boots for MN10300 and FRV.


The problem is that your -mm patchset doesn't match Linus's as a base.  I'm
still not sure what the right procedure is for that.  I can give you some
altered patches, but there's no guarantee you'll be able to pass them on to
Linus without breaking his tree.  What do *you* want?

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: mm snapshot broken-out-2007-11-20-01-45.tar.gz uploaded

2007-11-20 Thread Paul Moore
On Tuesday 20 November 2007 3:48:44 pm Paul Moore wrote:
> On Tuesday 20 November 2007 3:34:24 pm Kamalesh Babulal wrote:
> > Hi Andrew,
> >
> > The kernel build fails, in selinux with following error
> >
> >   CHK include/linux/compile.h
> >   UPD include/linux/compile.h
> >   CC  init/version.o
> >   LD  init/built-in.o
> >   LD  .tmp_vmlinux1
> > security/built-in.o(.toc1+0x928): undefined reference to
> > `selinux_xfrm_refcount' make: *** [.tmp_vmlinux1] Error 1
> > 11/20/2007-14:42:08 Build the kernel. Failed rc = 2
> > 11/20/2007-14:42:08 build: Building kernel... Failed rc = 1
> >
> > The patch causing this error is git-lblnet.patch, where in the
> > selinux_xfrm_enabled() is called from security/selinux/hooks.c, depends
> > on the extern atomic_tselinux_xfrm_refcount.
>
> The problem appears to be that the selinux_xfrm_refcount functionality is
> not properly protected by CONFIG_SECURITY_NETWORK_XFRM.  I'm fixing that
> now.

I've fixed the problem in the git tree below, meaning I just did a quick 
compile without defining CONFIG_SECURITY_NETWORK_XFRM and everything appeared 
to link correctly.  I haven't had a chance to try booting the fix yet because 
my test machine is a little slow compiling right now, but the fix was pretty 
trivial (simply move the extern and the inline function) so I don't expect 
any problems.

 * git://git.infradead.org/users/pcmoore/lblnet-2.6_testing

-- 
paul moore
linux security @ hp
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: mm snapshot broken-out-2007-11-20-01-45.tar.gz uploaded

2007-11-20 Thread Paul Moore
On Tuesday 20 November 2007 3:34:24 pm Kamalesh Babulal wrote:
> Hi Andrew,
>
> The kernel build fails, in selinux with following error
>
>   CHK include/linux/compile.h
>   UPD include/linux/compile.h
>   CC  init/version.o
>   LD  init/built-in.o
>   LD  .tmp_vmlinux1
> security/built-in.o(.toc1+0x928): undefined reference to
> `selinux_xfrm_refcount' make: *** [.tmp_vmlinux1] Error 1
> 11/20/2007-14:42:08 Build the kernel. Failed rc = 2
> 11/20/2007-14:42:08 build: Building kernel... Failed rc = 1
>
> The patch causing this error is git-lblnet.patch, where in the
> selinux_xfrm_enabled() is called from security/selinux/hooks.c, depends on
> the extern atomic_tselinux_xfrm_refcount.

The problem appears to be that the selinux_xfrm_refcount functionality is not 
properly protected by CONFIG_SECURITY_NETWORK_XFRM.  I'm fixing that now.

-- 
paul moore
linux security @ hp
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: mm snapshot broken-out-2007-11-20-01-45.tar.gz uploaded

2007-11-20 Thread Andrew Morton
On Tue, 20 Nov 2007 20:48:39 +0530
Kamalesh Babulal <[EMAIL PROTECTED]> wrote:

> Hi Andrew,
> 
> The kernel build fails, on the AMD machine with following message
> 
> arch/x86/ia32/ia32_aout.c: In function ___load_aout_binary___:
> arch/x86/ia32/ia32_aout.c:283: error: implicit declaration of function 
> ___N_MAGIC___
> arch/x86/ia32/ia32_aout.c:283: error: ___ZMAGIC___ undeclared (first use in 
> this function)
> arch/x86/ia32/ia32_aout.c:283: error: (Each undeclared identifier is reported 
> only once
> arch/x86/ia32/ia32_aout.c:283: error: for each function it appears in.)
> arch/x86/ia32/ia32_aout.c:283: error: ___OMAGIC___ undeclared (first use in 
> this function)
> arch/x86/ia32/ia32_aout.c:284: error: ___QMAGIC___ undeclared (first use in 
> this function)
> arch/x86/ia32/ia32_aout.c:284: error: ___NMAGIC___ undeclared (first use in 
> this function)
> arch/x86/ia32/ia32_aout.c:285: error: implicit declaration of function 
> ___N_TRSIZE___
> arch/x86/ia32/ia32_aout.c:285: error: implicit declaration of function 
> ___N_DRSIZE___
> arch/x86/ia32/ia32_aout.c:287: error: ___struct exec___ has no member named 
> ___a_text___
> arch/x86/ia32/ia32_aout.c:287: error: ___struct exec___ has no member named 
> ___a_data___
> arch/x86/ia32/ia32_aout.c:287: error: implicit declaration of function 
> ___N_SYMSIZE___
> arch/x86/ia32/ia32_aout.c:287: error: implicit declaration of function 
> ___N_TXTOFF___
> arch/x86/ia32/ia32_aout.c:300: error: ___struct exec___ has no member named 
> ___a_data___
> arch/x86/ia32/ia32_aout.c:300: error: ___struct exec___ has no member named 
> ___a_bss___
> arch/x86/ia32/ia32_aout.c:317: error: ___struct exec___ has no member named 
> ___a_text___
> arch/x86/ia32/ia32_aout.c:318: error: implicit declaration of function 
> ___N_TXTADDR___
> arch/x86/ia32/ia32_aout.c:319: error: ___struct exec___ has no member named 
> ___a_data___
> arch/x86/ia32/ia32_aout.c:320: error: implicit declaration of function 
> ___N_DATADDR___
> arch/x86/ia32/ia32_aout.c:321: error: ___struct exec___ has no member named 
> ___a_bss___
> arch/x86/ia32/ia32_aout.c:322: error: implicit declaration of function 
> ___N_BSSADDR___
> arch/x86/ia32/ia32_aout.c:337: error: ___struct exec___ has no member named 
> ___a_text___
> arch/x86/ia32/ia32_aout.c:337: error: ___struct exec___ has no member named 
> ___a_data___
> arch/x86/ia32/ia32_aout.c:350: error: ___struct exec___ has no member named 
> ___a_text___
> arch/x86/ia32/ia32_aout.c:350: error: ___struct exec___ has no member named 
> ___a_data___
> arch/x86/ia32/ia32_aout.c:380: error: ___struct exec___ has no member named 
> ___a_text___
> arch/x86/ia32/ia32_aout.c:380: error: ___struct exec___ has no member named 
> ___a_data___
> arch/x86/ia32/ia32_aout.c:383: warning: cast to pointer from integer of 
> different size
> arch/x86/ia32/ia32_aout.c:384: error: ___struct exec___ has no member named 
> ___a_text___
> arch/x86/ia32/ia32_aout.c:384: error: ___struct exec___ has no member named 
> ___a_data___
> arch/x86/ia32/ia32_aout.c:392: error: ___struct exec___ has no member named 
> ___a_text___
> arch/x86/ia32/ia32_aout.c:405: error: ___struct exec___ has no member named 
> ___a_data___
> arch/x86/ia32/ia32_aout.c:409: error: ___struct exec___ has no member named 
> ___a_text___
> arch/x86/ia32/ia32_aout.c:434: error: ___struct exec___ has no member named 
> ___a_entry___
> arch/x86/ia32/ia32_aout.c: In function ___load_aout_library___:
> arch/x86/ia32/ia32_aout.c:466: error: ___ZMAGIC___ undeclared (first use in 
> this function)
> arch/x86/ia32/ia32_aout.c:466: error: ___QMAGIC___ undeclared (first use in 
> this function)
> arch/x86/ia32/ia32_aout.c:467: error: ___struct exec___ has no member named 
> ___a_entry___
> arch/x86/ia32/ia32_aout.c:469: error: ___struct exec___ has no member named 
> ___a_text___
> arch/x86/ia32/ia32_aout.c:469: error: ___struct exec___ has no member named 
> ___a_data___
> arch/x86/ia32/ia32_aout.c:473: error: implicit declaration of function 
> ___N_FLAGS___
> arch/x86/ia32/ia32_aout.c:479: error: ___struct exec___ has no member named 
> ___a_entry___
> arch/x86/ia32/ia32_aout.c:495: error: ___struct exec___ has no member named 
> ___a_text___
> arch/x86/ia32/ia32_aout.c:495: error: ___struct exec___ has no member named 
> ___a_data___
> arch/x86/ia32/ia32_aout.c:495: error: ___struct exec___ has no member named 
> ___a_bss___
> arch/x86/ia32/ia32_aout.c:499: error: ___struct exec___ has no member named 
> ___a_text___
> arch/x86/ia32/ia32_aout.c:499: error: ___struct exec___ has no member named 
> ___a_data___
> arch/x86/ia32/ia32_aout.c:509: error: ___struct exec___ has no member named 
> ___a_text___
> arch/x86/ia32/ia32_aout.c:509: error: ___struct exec___ has no member named 
> ___a_data___
> arch/x86/ia32/ia32_aout.c:518: error: ___struct exec___ has no member named 
> ___a_text___
> arch/x86/ia32/ia32_aout.c:518: error: ___struct exec___ has no member named 
> ___a_data___
> arch/x86/ia32/ia32_aout.c:519: 

Re: mm snapshot broken-out-2007-11-20-01-45.tar.gz uploaded

2007-11-20 Thread Kamalesh Babulal
Hi Andrew,

The kernel build fails, in selinux with following error

  CHK include/linux/compile.h
  UPD include/linux/compile.h
  CC  init/version.o
  LD  init/built-in.o
  LD  .tmp_vmlinux1
security/built-in.o(.toc1+0x928): undefined reference to `selinux_xfrm_refcount'
make: *** [.tmp_vmlinux1] Error 1
11/20/2007-14:42:08 Build the kernel. Failed rc = 2
11/20/2007-14:42:08 build: Building kernel... Failed rc = 1

The patch causing this error is git-lblnet.patch, where in the 
selinux_xfrm_enabled()
is called from security/selinux/hooks.c, depends on the extern 
atomic_tselinux_xfrm_refcount.

-- 
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: mm snapshot broken-out-2007-11-20-01-45.tar.gz uploaded

2007-11-20 Thread Kamalesh Babulal
Hi Andrew,

The kernel build fails, on the AMD machine with following message

arch/x86/ia32/ia32_aout.c: In function ‘load_aout_binary’:
arch/x86/ia32/ia32_aout.c:283: error: implicit declaration of function ‘N_MAGIC’
arch/x86/ia32/ia32_aout.c:283: error: ‘ZMAGIC’ undeclared (first use in this 
function)
arch/x86/ia32/ia32_aout.c:283: error: (Each undeclared identifier is reported 
only once
arch/x86/ia32/ia32_aout.c:283: error: for each function it appears in.)
arch/x86/ia32/ia32_aout.c:283: error: ‘OMAGIC’ undeclared (first use in this 
function)
arch/x86/ia32/ia32_aout.c:284: error: ‘QMAGIC’ undeclared (first use in this 
function)
arch/x86/ia32/ia32_aout.c:284: error: ‘NMAGIC’ undeclared (first use in this 
function)
arch/x86/ia32/ia32_aout.c:285: error: implicit declaration of function 
‘N_TRSIZE’
arch/x86/ia32/ia32_aout.c:285: error: implicit declaration of function 
‘N_DRSIZE’
arch/x86/ia32/ia32_aout.c:287: error: ‘struct exec’ has no member named ‘a_text’
arch/x86/ia32/ia32_aout.c:287: error: ‘struct exec’ has no member named ‘a_data’
arch/x86/ia32/ia32_aout.c:287: error: implicit declaration of function 
‘N_SYMSIZE’
arch/x86/ia32/ia32_aout.c:287: error: implicit declaration of function 
‘N_TXTOFF’
arch/x86/ia32/ia32_aout.c:300: error: ‘struct exec’ has no member named ‘a_data’
arch/x86/ia32/ia32_aout.c:300: error: ‘struct exec’ has no member named ‘a_bss’
arch/x86/ia32/ia32_aout.c:317: error: ‘struct exec’ has no member named ‘a_text’
arch/x86/ia32/ia32_aout.c:318: error: implicit declaration of function 
‘N_TXTADDR’
arch/x86/ia32/ia32_aout.c:319: error: ‘struct exec’ has no member named ‘a_data’
arch/x86/ia32/ia32_aout.c:320: error: implicit declaration of function 
‘N_DATADDR’
arch/x86/ia32/ia32_aout.c:321: error: ‘struct exec’ has no member named ‘a_bss’
arch/x86/ia32/ia32_aout.c:322: error: implicit declaration of function 
‘N_BSSADDR’
arch/x86/ia32/ia32_aout.c:337: error: ‘struct exec’ has no member named ‘a_text’
arch/x86/ia32/ia32_aout.c:337: error: ‘struct exec’ has no member named ‘a_data’
arch/x86/ia32/ia32_aout.c:350: error: ‘struct exec’ has no member named ‘a_text’
arch/x86/ia32/ia32_aout.c:350: error: ‘struct exec’ has no member named ‘a_data’
arch/x86/ia32/ia32_aout.c:380: error: ‘struct exec’ has no member named ‘a_text’
arch/x86/ia32/ia32_aout.c:380: error: ‘struct exec’ has no member named ‘a_data’
arch/x86/ia32/ia32_aout.c:383: warning: cast to pointer from integer of 
different size
arch/x86/ia32/ia32_aout.c:384: error: ‘struct exec’ has no member named ‘a_text’
arch/x86/ia32/ia32_aout.c:384: error: ‘struct exec’ has no member named ‘a_data’
arch/x86/ia32/ia32_aout.c:392: error: ‘struct exec’ has no member named ‘a_text’
arch/x86/ia32/ia32_aout.c:405: error: ‘struct exec’ has no member named ‘a_data’
arch/x86/ia32/ia32_aout.c:409: error: ‘struct exec’ has no member named ‘a_text’
arch/x86/ia32/ia32_aout.c:434: error: ‘struct exec’ has no member named 
‘a_entry’
arch/x86/ia32/ia32_aout.c: In function ‘load_aout_library’:
arch/x86/ia32/ia32_aout.c:466: error: ‘ZMAGIC’ undeclared (first use in this 
function)
arch/x86/ia32/ia32_aout.c:466: error: ‘QMAGIC’ undeclared (first use in this 
function)
arch/x86/ia32/ia32_aout.c:467: error: ‘struct exec’ has no member named 
‘a_entry’
arch/x86/ia32/ia32_aout.c:469: error: ‘struct exec’ has no member named ‘a_text’
arch/x86/ia32/ia32_aout.c:469: error: ‘struct exec’ has no member named ‘a_data’
arch/x86/ia32/ia32_aout.c:473: error: implicit declaration of function ‘N_FLAGS’
arch/x86/ia32/ia32_aout.c:479: error: ‘struct exec’ has no member named 
‘a_entry’
arch/x86/ia32/ia32_aout.c:495: error: ‘struct exec’ has no member named ‘a_text’
arch/x86/ia32/ia32_aout.c:495: error: ‘struct exec’ has no member named ‘a_data’
arch/x86/ia32/ia32_aout.c:495: error: ‘struct exec’ has no member named ‘a_bss’
arch/x86/ia32/ia32_aout.c:499: error: ‘struct exec’ has no member named ‘a_text’
arch/x86/ia32/ia32_aout.c:499: error: ‘struct exec’ has no member named ‘a_data’
arch/x86/ia32/ia32_aout.c:509: error: ‘struct exec’ has no member named ‘a_text’
arch/x86/ia32/ia32_aout.c:509: error: ‘struct exec’ has no member named ‘a_data’
arch/x86/ia32/ia32_aout.c:518: error: ‘struct exec’ has no member named ‘a_text’
arch/x86/ia32/ia32_aout.c:518: error: ‘struct exec’ has no member named ‘a_data’
arch/x86/ia32/ia32_aout.c:519: error: ‘struct exec’ has no member named ‘a_text’
arch/x86/ia32/ia32_aout.c:519: error: ‘struct exec’ has no member named ‘a_data’
arch/x86/ia32/ia32_aout.c:519: error: ‘struct exec’ has no member named ‘a_bss’
make[1]: *** [arch/x86/ia32/ia32_aout.o] Error 1
make: *** [arch/x86/ia32] Error 2

The patch aout-suppress-aout-library-support-if-config_arch_supports_aout.patch,
creates a struct exec in linux/a.out.h and asm/a.out.h already has it, for the 
struct
related warnings.

-- 
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a 

Re: mm snapshot broken-out-2007-11-20-01-45.tar.gz uploaded

2007-11-20 Thread Kamalesh Babulal
On Tue, Nov 20, 2007 at 03:21:38PM +0100, Thomas Gleixner wrote:
> On Tue, 20 Nov 2007, Thomas Gleixner wrote:
> > > arch/x86/kernel/setup_64.c:991: error: redefinition of ‘identify_cpu’
> > > arch/x86/kernel/setup_64.c:958: error: previous definition of 
> > > ‘identify_cpu’ was here
> > > make[1]: *** [arch/x86/kernel/setup_64.o] Error 1
> > > make: *** [arch/x86/kernel] Error 2
> > > 
> > > The patch causing this error is git-x86.patch
> > 
> > Jeremy pointed me to this already. I'm looking into this.
> 
> Fix below.
> 
> tglx
>
Hi Thomas,

Thanks for the fix, the patch solves the build failure.

Tested-by: Kamalesh Babulal <[EMAIL PROTECTED]>
---
 arch/x86/kernel/setup_64.c |   10 +-
 1 file changed, 1 insertion(+), 9 deletions(-)

Index: linux-2.6-x86/arch/x86/kernel/setup_64.c
===
--- linux-2.6-x86.orig/arch/x86/kernel/setup_64.c   2007-11-20 
15:18:20.0 +0100
+++ linux-2.6-x86/arch/x86/kernel/setup_64.c2007-11-20 15:18:57.0 
+0100
@@ -634,8 +634,7 @@ static __cpuinit int amd_apic_timer_brok
 static void __cpuinit early_init_amd(struct cpuinfo_x86 *c)
 {
 #ifdef CONFIG_SMP
-   unsigned bits;
-   unsigned ecx;
+   unsigned bits, ecx;
 
/* Multi core CPU? */
if (c->extended_cpuid_level < 0x8008)
@@ -942,13 +941,6 @@ static void __cpuinit early_identify_cpu
 #ifdef CONFIG_SMP
c->phys_proc_id = (cpuid_ebx(1) >> 24) & 0xff;
 #endif
-}
-
-/*
- * This does the hard work of actually picking apart the CPU stuff...
- */
-void __cpuinit identify_cpu(struct cpuinfo_x86 *c)
-{
/* AMD-defined flags: level 0x8001 */
xlvl = cpuid_eax(0x8000);
c->extended_cpuid_level = xlvl;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: mm snapshot broken-out-2007-11-20-01-45.tar.gz uploaded

2007-11-20 Thread Thomas Gleixner
On Tue, 20 Nov 2007, Thomas Gleixner wrote:
> > arch/x86/kernel/setup_64.c:991: error: redefinition of ‘identify_cpu’
> > arch/x86/kernel/setup_64.c:958: error: previous definition of 
> > ‘identify_cpu’ was here
> > make[1]: *** [arch/x86/kernel/setup_64.o] Error 1
> > make: *** [arch/x86/kernel] Error 2
> > 
> > The patch causing this error is git-x86.patch
> 
> Jeremy pointed me to this already. I'm looking into this.

Fix below.

tglx

---
 arch/x86/kernel/setup_64.c |   10 +-
 1 file changed, 1 insertion(+), 9 deletions(-)

Index: linux-2.6-x86/arch/x86/kernel/setup_64.c
===
--- linux-2.6-x86.orig/arch/x86/kernel/setup_64.c   2007-11-20 
15:18:20.0 +0100
+++ linux-2.6-x86/arch/x86/kernel/setup_64.c2007-11-20 15:18:57.0 
+0100
@@ -634,8 +634,7 @@ static __cpuinit int amd_apic_timer_brok
 static void __cpuinit early_init_amd(struct cpuinfo_x86 *c)
 {
 #ifdef CONFIG_SMP
-   unsigned bits;
-   unsigned ecx;
+   unsigned bits, ecx;
 
/* Multi core CPU? */
if (c->extended_cpuid_level < 0x8008)
@@ -942,13 +941,6 @@ static void __cpuinit early_identify_cpu
 #ifdef CONFIG_SMP
c->phys_proc_id = (cpuid_ebx(1) >> 24) & 0xff;
 #endif
-}
-
-/*
- * This does the hard work of actually picking apart the CPU stuff...
- */
-void __cpuinit identify_cpu(struct cpuinfo_x86 *c)
-{
/* AMD-defined flags: level 0x8001 */
xlvl = cpuid_eax(0x8000);
c->extended_cpuid_level = xlvl;
 

Re: mm snapshot broken-out-2007-11-20-01-45.tar.gz uploaded

2007-11-20 Thread Kamalesh Babulal
Hi Andrew,

The kernel build fails, with following message

  LD  drivers/net/wireless/built-in.o
drivers/net/wireless/rtl8187.o: In function `rtl8225z2_rf_init':
(.opd+0x180): multiple definition of `rtl8225z2_rf_init'
drivers/net/wireless/rtl8180.o:(.opd+0x1b0): first defined here
drivers/net/wireless/rtl8187.o: In function `rtl8225z2_rf_init':
/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8187_rtl8225.c:571: multiple 
definition of `.rtl8225z2_rf_init'
drivers/net/wireless/rtl8180.o:/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8180_rtl8225.c:561:
 first defined here
ld: Warning: size of symbol `.rtl8225z2_rf_init' changed from 3836 in 
drivers/net/wireless/rtl8180.o to 3544 in drivers/net/wireless/rtl8187.o
drivers/net/wireless/rtl8187.o: In function `rtl8225_rf_set_channel':
(.opd+0x160): multiple definition of `rtl8225_rf_set_channel'
drivers/net/wireless/rtl8180.o:(.opd+0x1d0): first defined here
drivers/net/wireless/rtl8187.o: In function `rtl8225_rf_init':
/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8187_rtl8225.c:329: multiple 
definition of `.rtl8225_rf_init'
drivers/net/wireless/rtl8180.o:/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8180_rtl8225.c:322:
 first defined here
ld: Warning: size of symbol `.rtl8225_rf_init' changed from 3492 in 
drivers/net/wireless/rtl8180.o to 3528 in drivers/net/wireless/rtl8187.o
drivers/net/wireless/rtl8187.o: In function `rtl8225_rf_stop':
(.opd+0x190): multiple definition of `rtl8225_rf_stop'
drivers/net/wireless/rtl8180.o:(.opd+0x1c0): first defined here
drivers/net/wireless/rtl8187.o: In function `rtl8225_rf_set_channel':
/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8187_rtl8225.c:735: multiple 
definition of `.rtl8225_rf_set_channel'
drivers/net/wireless/rtl8180.o:/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8180_rtl8225.c:753:
 first defined here
ld: Warning: size of symbol `.rtl8225_rf_set_channel' changed from 360 in 
drivers/net/wireless/rtl8180.o to 136 in drivers/net/wireless/rtl8187.o
drivers/net/wireless/rtl8187.o: In function `rtl8225_rf_init':
(.opd+0x170): multiple definition of `rtl8225_rf_init'
drivers/net/wireless/rtl8180.o:(.opd+0x1a0): first defined here
drivers/net/wireless/rtl8187.o: In function `rtl8225_rf_stop':
/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8187_rtl8225.c:719: multiple 
definition of `.rtl8225_rf_stop'
drivers/net/wireless/rtl8180.o:/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8180_rtl8225.c:736:
 first defined here
ld: Warning: size of symbol `.rtl8225_rf_stop' changed from 244 in 
drivers/net/wireless/rtl8180.o to 632 in drivers/net/wireless/rtl8187.o
make[3]: *** [drivers/net/wireless/built-in.o] Error 1
make[2]: *** [drivers/net/wireless] Error 2
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2

The patch causing this build failure, might be git-wireless.patch.
-- 
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: mm snapshot broken-out-2007-11-20-01-45.tar.gz uploaded

2007-11-20 Thread Thomas Gleixner
On Tue, 20 Nov 2007, Kamalesh Babulal wrote:

> Hi Andrew,
> 
> The kernel build fails on AMD Opteron
> 
>   CC  arch/x86/kernel/setup_64.o
> arch/x86/kernel/setup_64.c: In function ‘early_identify_cpu’:
> arch/x86/kernel/setup_64.c:904: warning: unused variable ‘xlvl’
> arch/x86/kernel/setup_64.c: In function ‘identify_cpu’:
> arch/x86/kernel/setup_64.c:960: error: ‘xlvl’ undeclared (first use in this 
> function)
> arch/x86/kernel/setup_64.c:960: error: (Each undeclared identifier is 
> reported only once
> arch/x86/kernel/setup_64.c:960: error: for each function it appears in.)
> arch/x86/kernel/setup_64.c: At top level:
> arch/x86/kernel/setup_64.c:991: error: redefinition of ‘identify_cpu’
> arch/x86/kernel/setup_64.c:958: error: previous definition of ‘identify_cpu’ 
> was here
> make[1]: *** [arch/x86/kernel/setup_64.o] Error 1
> make: *** [arch/x86/kernel] Error 2
> 
> The patch causing this error is git-x86.patch

Jeremy pointed me to this already. I'm looking into this.

Thanks,

tglx

Re: mm snapshot broken-out-2007-11-20-01-45.tar.gz uploaded

2007-11-20 Thread Kamalesh Babulal
Hi Andrew,

The kernel build fails on AMD Opteron

  CC  arch/x86/kernel/setup_64.o
arch/x86/kernel/setup_64.c: In function ‘early_identify_cpu’:
arch/x86/kernel/setup_64.c:904: warning: unused variable ‘xlvl’
arch/x86/kernel/setup_64.c: In function ‘identify_cpu’:
arch/x86/kernel/setup_64.c:960: error: ‘xlvl’ undeclared (first use in this 
function)
arch/x86/kernel/setup_64.c:960: error: (Each undeclared identifier is reported 
only once
arch/x86/kernel/setup_64.c:960: error: for each function it appears in.)
arch/x86/kernel/setup_64.c: At top level:
arch/x86/kernel/setup_64.c:991: error: redefinition of ‘identify_cpu’
arch/x86/kernel/setup_64.c:958: error: previous definition of ‘identify_cpu’ 
was here
make[1]: *** [arch/x86/kernel/setup_64.o] Error 1
make: *** [arch/x86/kernel] Error 2

The patch causing this error is git-x86.patch

-- 
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: mm snapshot broken-out-2007-11-20-01-45.tar.gz uploaded

2007-11-20 Thread Kamalesh Babulal
Hi Andrew,

The kernel build fails on AMD Opteron

  CC  arch/x86/kernel/setup_64.o
arch/x86/kernel/setup_64.c: In function ‘early_identify_cpu’:
arch/x86/kernel/setup_64.c:904: warning: unused variable ‘xlvl’
arch/x86/kernel/setup_64.c: In function ‘identify_cpu’:
arch/x86/kernel/setup_64.c:960: error: ‘xlvl’ undeclared (first use in this 
function)
arch/x86/kernel/setup_64.c:960: error: (Each undeclared identifier is reported 
only once
arch/x86/kernel/setup_64.c:960: error: for each function it appears in.)
arch/x86/kernel/setup_64.c: At top level:
arch/x86/kernel/setup_64.c:991: error: redefinition of ‘identify_cpu’
arch/x86/kernel/setup_64.c:958: error: previous definition of ‘identify_cpu’ 
was here
make[1]: *** [arch/x86/kernel/setup_64.o] Error 1
make: *** [arch/x86/kernel] Error 2

The patch causing this error is git-x86.patch

-- 
Thanks  Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: mm snapshot broken-out-2007-11-20-01-45.tar.gz uploaded

2007-11-20 Thread Thomas Gleixner
On Tue, 20 Nov 2007, Kamalesh Babulal wrote:

 Hi Andrew,
 
 The kernel build fails on AMD Opteron
 
   CC  arch/x86/kernel/setup_64.o
 arch/x86/kernel/setup_64.c: In function ‘early_identify_cpu’:
 arch/x86/kernel/setup_64.c:904: warning: unused variable ‘xlvl’
 arch/x86/kernel/setup_64.c: In function ‘identify_cpu’:
 arch/x86/kernel/setup_64.c:960: error: ‘xlvl’ undeclared (first use in this 
 function)
 arch/x86/kernel/setup_64.c:960: error: (Each undeclared identifier is 
 reported only once
 arch/x86/kernel/setup_64.c:960: error: for each function it appears in.)
 arch/x86/kernel/setup_64.c: At top level:
 arch/x86/kernel/setup_64.c:991: error: redefinition of ‘identify_cpu’
 arch/x86/kernel/setup_64.c:958: error: previous definition of ‘identify_cpu’ 
 was here
 make[1]: *** [arch/x86/kernel/setup_64.o] Error 1
 make: *** [arch/x86/kernel] Error 2
 
 The patch causing this error is git-x86.patch

Jeremy pointed me to this already. I'm looking into this.

Thanks,

tglx

Re: mm snapshot broken-out-2007-11-20-01-45.tar.gz uploaded

2007-11-20 Thread Kamalesh Babulal
Hi Andrew,

The kernel build fails, with following message

  LD  drivers/net/wireless/built-in.o
drivers/net/wireless/rtl8187.o: In function `rtl8225z2_rf_init':
(.opd+0x180): multiple definition of `rtl8225z2_rf_init'
drivers/net/wireless/rtl8180.o:(.opd+0x1b0): first defined here
drivers/net/wireless/rtl8187.o: In function `rtl8225z2_rf_init':
/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8187_rtl8225.c:571: multiple 
definition of `.rtl8225z2_rf_init'
drivers/net/wireless/rtl8180.o:/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8180_rtl8225.c:561:
 first defined here
ld: Warning: size of symbol `.rtl8225z2_rf_init' changed from 3836 in 
drivers/net/wireless/rtl8180.o to 3544 in drivers/net/wireless/rtl8187.o
drivers/net/wireless/rtl8187.o: In function `rtl8225_rf_set_channel':
(.opd+0x160): multiple definition of `rtl8225_rf_set_channel'
drivers/net/wireless/rtl8180.o:(.opd+0x1d0): first defined here
drivers/net/wireless/rtl8187.o: In function `rtl8225_rf_init':
/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8187_rtl8225.c:329: multiple 
definition of `.rtl8225_rf_init'
drivers/net/wireless/rtl8180.o:/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8180_rtl8225.c:322:
 first defined here
ld: Warning: size of symbol `.rtl8225_rf_init' changed from 3492 in 
drivers/net/wireless/rtl8180.o to 3528 in drivers/net/wireless/rtl8187.o
drivers/net/wireless/rtl8187.o: In function `rtl8225_rf_stop':
(.opd+0x190): multiple definition of `rtl8225_rf_stop'
drivers/net/wireless/rtl8180.o:(.opd+0x1c0): first defined here
drivers/net/wireless/rtl8187.o: In function `rtl8225_rf_set_channel':
/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8187_rtl8225.c:735: multiple 
definition of `.rtl8225_rf_set_channel'
drivers/net/wireless/rtl8180.o:/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8180_rtl8225.c:753:
 first defined here
ld: Warning: size of symbol `.rtl8225_rf_set_channel' changed from 360 in 
drivers/net/wireless/rtl8180.o to 136 in drivers/net/wireless/rtl8187.o
drivers/net/wireless/rtl8187.o: In function `rtl8225_rf_init':
(.opd+0x170): multiple definition of `rtl8225_rf_init'
drivers/net/wireless/rtl8180.o:(.opd+0x1a0): first defined here
drivers/net/wireless/rtl8187.o: In function `rtl8225_rf_stop':
/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8187_rtl8225.c:719: multiple 
definition of `.rtl8225_rf_stop'
drivers/net/wireless/rtl8180.o:/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8180_rtl8225.c:736:
 first defined here
ld: Warning: size of symbol `.rtl8225_rf_stop' changed from 244 in 
drivers/net/wireless/rtl8180.o to 632 in drivers/net/wireless/rtl8187.o
make[3]: *** [drivers/net/wireless/built-in.o] Error 1
make[2]: *** [drivers/net/wireless] Error 2
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2

The patch causing this build failure, might be git-wireless.patch.
-- 
Thanks  Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: mm snapshot broken-out-2007-11-20-01-45.tar.gz uploaded

2007-11-20 Thread Kamalesh Babulal
On Tue, Nov 20, 2007 at 03:21:38PM +0100, Thomas Gleixner wrote:
 On Tue, 20 Nov 2007, Thomas Gleixner wrote:
   arch/x86/kernel/setup_64.c:991: error: redefinition of ‘identify_cpu’
   arch/x86/kernel/setup_64.c:958: error: previous definition of 
   ‘identify_cpu’ was here
   make[1]: *** [arch/x86/kernel/setup_64.o] Error 1
   make: *** [arch/x86/kernel] Error 2
   
   The patch causing this error is git-x86.patch
  
  Jeremy pointed me to this already. I'm looking into this.
 
 Fix below.
 
 tglx

Hi Thomas,

Thanks for the fix, the patch solves the build failure.

Tested-by: Kamalesh Babulal [EMAIL PROTECTED]
---
 arch/x86/kernel/setup_64.c |   10 +-
 1 file changed, 1 insertion(+), 9 deletions(-)

Index: linux-2.6-x86/arch/x86/kernel/setup_64.c
===
--- linux-2.6-x86.orig/arch/x86/kernel/setup_64.c   2007-11-20 
15:18:20.0 +0100
+++ linux-2.6-x86/arch/x86/kernel/setup_64.c2007-11-20 15:18:57.0 
+0100
@@ -634,8 +634,7 @@ static __cpuinit int amd_apic_timer_brok
 static void __cpuinit early_init_amd(struct cpuinfo_x86 *c)
 {
 #ifdef CONFIG_SMP
-   unsigned bits;
-   unsigned ecx;
+   unsigned bits, ecx;
 
/* Multi core CPU? */
if (c-extended_cpuid_level  0x8008)
@@ -942,13 +941,6 @@ static void __cpuinit early_identify_cpu
 #ifdef CONFIG_SMP
c-phys_proc_id = (cpuid_ebx(1)  24)  0xff;
 #endif
-}
-
-/*
- * This does the hard work of actually picking apart the CPU stuff...
- */
-void __cpuinit identify_cpu(struct cpuinfo_x86 *c)
-{
/* AMD-defined flags: level 0x8001 */
xlvl = cpuid_eax(0x8000);
c-extended_cpuid_level = xlvl;

-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: mm snapshot broken-out-2007-11-20-01-45.tar.gz uploaded

2007-11-20 Thread Thomas Gleixner
On Tue, 20 Nov 2007, Thomas Gleixner wrote:
  arch/x86/kernel/setup_64.c:991: error: redefinition of ‘identify_cpu’
  arch/x86/kernel/setup_64.c:958: error: previous definition of 
  ‘identify_cpu’ was here
  make[1]: *** [arch/x86/kernel/setup_64.o] Error 1
  make: *** [arch/x86/kernel] Error 2
  
  The patch causing this error is git-x86.patch
 
 Jeremy pointed me to this already. I'm looking into this.

Fix below.

tglx

---
 arch/x86/kernel/setup_64.c |   10 +-
 1 file changed, 1 insertion(+), 9 deletions(-)

Index: linux-2.6-x86/arch/x86/kernel/setup_64.c
===
--- linux-2.6-x86.orig/arch/x86/kernel/setup_64.c   2007-11-20 
15:18:20.0 +0100
+++ linux-2.6-x86/arch/x86/kernel/setup_64.c2007-11-20 15:18:57.0 
+0100
@@ -634,8 +634,7 @@ static __cpuinit int amd_apic_timer_brok
 static void __cpuinit early_init_amd(struct cpuinfo_x86 *c)
 {
 #ifdef CONFIG_SMP
-   unsigned bits;
-   unsigned ecx;
+   unsigned bits, ecx;
 
/* Multi core CPU? */
if (c-extended_cpuid_level  0x8008)
@@ -942,13 +941,6 @@ static void __cpuinit early_identify_cpu
 #ifdef CONFIG_SMP
c-phys_proc_id = (cpuid_ebx(1)  24)  0xff;
 #endif
-}
-
-/*
- * This does the hard work of actually picking apart the CPU stuff...
- */
-void __cpuinit identify_cpu(struct cpuinfo_x86 *c)
-{
/* AMD-defined flags: level 0x8001 */
xlvl = cpuid_eax(0x8000);
c-extended_cpuid_level = xlvl;
 

Re: mm snapshot broken-out-2007-11-20-01-45.tar.gz uploaded

2007-11-20 Thread Kamalesh Babulal
Hi Andrew,

The kernel build fails, on the AMD machine with following message

arch/x86/ia32/ia32_aout.c: In function ‘load_aout_binary’:
arch/x86/ia32/ia32_aout.c:283: error: implicit declaration of function ‘N_MAGIC’
arch/x86/ia32/ia32_aout.c:283: error: ‘ZMAGIC’ undeclared (first use in this 
function)
arch/x86/ia32/ia32_aout.c:283: error: (Each undeclared identifier is reported 
only once
arch/x86/ia32/ia32_aout.c:283: error: for each function it appears in.)
arch/x86/ia32/ia32_aout.c:283: error: ‘OMAGIC’ undeclared (first use in this 
function)
arch/x86/ia32/ia32_aout.c:284: error: ‘QMAGIC’ undeclared (first use in this 
function)
arch/x86/ia32/ia32_aout.c:284: error: ‘NMAGIC’ undeclared (first use in this 
function)
arch/x86/ia32/ia32_aout.c:285: error: implicit declaration of function 
‘N_TRSIZE’
arch/x86/ia32/ia32_aout.c:285: error: implicit declaration of function 
‘N_DRSIZE’
arch/x86/ia32/ia32_aout.c:287: error: ‘struct exec’ has no member named ‘a_text’
arch/x86/ia32/ia32_aout.c:287: error: ‘struct exec’ has no member named ‘a_data’
arch/x86/ia32/ia32_aout.c:287: error: implicit declaration of function 
‘N_SYMSIZE’
arch/x86/ia32/ia32_aout.c:287: error: implicit declaration of function 
‘N_TXTOFF’
arch/x86/ia32/ia32_aout.c:300: error: ‘struct exec’ has no member named ‘a_data’
arch/x86/ia32/ia32_aout.c:300: error: ‘struct exec’ has no member named ‘a_bss’
arch/x86/ia32/ia32_aout.c:317: error: ‘struct exec’ has no member named ‘a_text’
arch/x86/ia32/ia32_aout.c:318: error: implicit declaration of function 
‘N_TXTADDR’
arch/x86/ia32/ia32_aout.c:319: error: ‘struct exec’ has no member named ‘a_data’
arch/x86/ia32/ia32_aout.c:320: error: implicit declaration of function 
‘N_DATADDR’
arch/x86/ia32/ia32_aout.c:321: error: ‘struct exec’ has no member named ‘a_bss’
arch/x86/ia32/ia32_aout.c:322: error: implicit declaration of function 
‘N_BSSADDR’
arch/x86/ia32/ia32_aout.c:337: error: ‘struct exec’ has no member named ‘a_text’
arch/x86/ia32/ia32_aout.c:337: error: ‘struct exec’ has no member named ‘a_data’
arch/x86/ia32/ia32_aout.c:350: error: ‘struct exec’ has no member named ‘a_text’
arch/x86/ia32/ia32_aout.c:350: error: ‘struct exec’ has no member named ‘a_data’
arch/x86/ia32/ia32_aout.c:380: error: ‘struct exec’ has no member named ‘a_text’
arch/x86/ia32/ia32_aout.c:380: error: ‘struct exec’ has no member named ‘a_data’
arch/x86/ia32/ia32_aout.c:383: warning: cast to pointer from integer of 
different size
arch/x86/ia32/ia32_aout.c:384: error: ‘struct exec’ has no member named ‘a_text’
arch/x86/ia32/ia32_aout.c:384: error: ‘struct exec’ has no member named ‘a_data’
arch/x86/ia32/ia32_aout.c:392: error: ‘struct exec’ has no member named ‘a_text’
arch/x86/ia32/ia32_aout.c:405: error: ‘struct exec’ has no member named ‘a_data’
arch/x86/ia32/ia32_aout.c:409: error: ‘struct exec’ has no member named ‘a_text’
arch/x86/ia32/ia32_aout.c:434: error: ‘struct exec’ has no member named 
‘a_entry’
arch/x86/ia32/ia32_aout.c: In function ‘load_aout_library’:
arch/x86/ia32/ia32_aout.c:466: error: ‘ZMAGIC’ undeclared (first use in this 
function)
arch/x86/ia32/ia32_aout.c:466: error: ‘QMAGIC’ undeclared (first use in this 
function)
arch/x86/ia32/ia32_aout.c:467: error: ‘struct exec’ has no member named 
‘a_entry’
arch/x86/ia32/ia32_aout.c:469: error: ‘struct exec’ has no member named ‘a_text’
arch/x86/ia32/ia32_aout.c:469: error: ‘struct exec’ has no member named ‘a_data’
arch/x86/ia32/ia32_aout.c:473: error: implicit declaration of function ‘N_FLAGS’
arch/x86/ia32/ia32_aout.c:479: error: ‘struct exec’ has no member named 
‘a_entry’
arch/x86/ia32/ia32_aout.c:495: error: ‘struct exec’ has no member named ‘a_text’
arch/x86/ia32/ia32_aout.c:495: error: ‘struct exec’ has no member named ‘a_data’
arch/x86/ia32/ia32_aout.c:495: error: ‘struct exec’ has no member named ‘a_bss’
arch/x86/ia32/ia32_aout.c:499: error: ‘struct exec’ has no member named ‘a_text’
arch/x86/ia32/ia32_aout.c:499: error: ‘struct exec’ has no member named ‘a_data’
arch/x86/ia32/ia32_aout.c:509: error: ‘struct exec’ has no member named ‘a_text’
arch/x86/ia32/ia32_aout.c:509: error: ‘struct exec’ has no member named ‘a_data’
arch/x86/ia32/ia32_aout.c:518: error: ‘struct exec’ has no member named ‘a_text’
arch/x86/ia32/ia32_aout.c:518: error: ‘struct exec’ has no member named ‘a_data’
arch/x86/ia32/ia32_aout.c:519: error: ‘struct exec’ has no member named ‘a_text’
arch/x86/ia32/ia32_aout.c:519: error: ‘struct exec’ has no member named ‘a_data’
arch/x86/ia32/ia32_aout.c:519: error: ‘struct exec’ has no member named ‘a_bss’
make[1]: *** [arch/x86/ia32/ia32_aout.o] Error 1
make: *** [arch/x86/ia32] Error 2

The patch aout-suppress-aout-library-support-if-config_arch_supports_aout.patch,
creates a struct exec in linux/a.out.h and asm/a.out.h already has it, for the 
struct
related warnings.

-- 
Thanks  Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a 

Re: mm snapshot broken-out-2007-11-20-01-45.tar.gz uploaded

2007-11-20 Thread Kamalesh Babulal
Hi Andrew,

The kernel build fails, in selinux with following error

  CHK include/linux/compile.h
  UPD include/linux/compile.h
  CC  init/version.o
  LD  init/built-in.o
  LD  .tmp_vmlinux1
security/built-in.o(.toc1+0x928): undefined reference to `selinux_xfrm_refcount'
make: *** [.tmp_vmlinux1] Error 1
11/20/2007-14:42:08 Build the kernel. Failed rc = 2
11/20/2007-14:42:08 build: Building kernel... Failed rc = 1

The patch causing this error is git-lblnet.patch, where in the 
selinux_xfrm_enabled()
is called from security/selinux/hooks.c, depends on the extern 
atomic_tselinux_xfrm_refcount.

-- 
Thanks  Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: mm snapshot broken-out-2007-11-20-01-45.tar.gz uploaded

2007-11-20 Thread Andrew Morton
On Tue, 20 Nov 2007 20:48:39 +0530
Kamalesh Babulal [EMAIL PROTECTED] wrote:

 Hi Andrew,
 
 The kernel build fails, on the AMD machine with following message
 
 arch/x86/ia32/ia32_aout.c: In function ___load_aout_binary___:
 arch/x86/ia32/ia32_aout.c:283: error: implicit declaration of function 
 ___N_MAGIC___
 arch/x86/ia32/ia32_aout.c:283: error: ___ZMAGIC___ undeclared (first use in 
 this function)
 arch/x86/ia32/ia32_aout.c:283: error: (Each undeclared identifier is reported 
 only once
 arch/x86/ia32/ia32_aout.c:283: error: for each function it appears in.)
 arch/x86/ia32/ia32_aout.c:283: error: ___OMAGIC___ undeclared (first use in 
 this function)
 arch/x86/ia32/ia32_aout.c:284: error: ___QMAGIC___ undeclared (first use in 
 this function)
 arch/x86/ia32/ia32_aout.c:284: error: ___NMAGIC___ undeclared (first use in 
 this function)
 arch/x86/ia32/ia32_aout.c:285: error: implicit declaration of function 
 ___N_TRSIZE___
 arch/x86/ia32/ia32_aout.c:285: error: implicit declaration of function 
 ___N_DRSIZE___
 arch/x86/ia32/ia32_aout.c:287: error: ___struct exec___ has no member named 
 ___a_text___
 arch/x86/ia32/ia32_aout.c:287: error: ___struct exec___ has no member named 
 ___a_data___
 arch/x86/ia32/ia32_aout.c:287: error: implicit declaration of function 
 ___N_SYMSIZE___
 arch/x86/ia32/ia32_aout.c:287: error: implicit declaration of function 
 ___N_TXTOFF___
 arch/x86/ia32/ia32_aout.c:300: error: ___struct exec___ has no member named 
 ___a_data___
 arch/x86/ia32/ia32_aout.c:300: error: ___struct exec___ has no member named 
 ___a_bss___
 arch/x86/ia32/ia32_aout.c:317: error: ___struct exec___ has no member named 
 ___a_text___
 arch/x86/ia32/ia32_aout.c:318: error: implicit declaration of function 
 ___N_TXTADDR___
 arch/x86/ia32/ia32_aout.c:319: error: ___struct exec___ has no member named 
 ___a_data___
 arch/x86/ia32/ia32_aout.c:320: error: implicit declaration of function 
 ___N_DATADDR___
 arch/x86/ia32/ia32_aout.c:321: error: ___struct exec___ has no member named 
 ___a_bss___
 arch/x86/ia32/ia32_aout.c:322: error: implicit declaration of function 
 ___N_BSSADDR___
 arch/x86/ia32/ia32_aout.c:337: error: ___struct exec___ has no member named 
 ___a_text___
 arch/x86/ia32/ia32_aout.c:337: error: ___struct exec___ has no member named 
 ___a_data___
 arch/x86/ia32/ia32_aout.c:350: error: ___struct exec___ has no member named 
 ___a_text___
 arch/x86/ia32/ia32_aout.c:350: error: ___struct exec___ has no member named 
 ___a_data___
 arch/x86/ia32/ia32_aout.c:380: error: ___struct exec___ has no member named 
 ___a_text___
 arch/x86/ia32/ia32_aout.c:380: error: ___struct exec___ has no member named 
 ___a_data___
 arch/x86/ia32/ia32_aout.c:383: warning: cast to pointer from integer of 
 different size
 arch/x86/ia32/ia32_aout.c:384: error: ___struct exec___ has no member named 
 ___a_text___
 arch/x86/ia32/ia32_aout.c:384: error: ___struct exec___ has no member named 
 ___a_data___
 arch/x86/ia32/ia32_aout.c:392: error: ___struct exec___ has no member named 
 ___a_text___
 arch/x86/ia32/ia32_aout.c:405: error: ___struct exec___ has no member named 
 ___a_data___
 arch/x86/ia32/ia32_aout.c:409: error: ___struct exec___ has no member named 
 ___a_text___
 arch/x86/ia32/ia32_aout.c:434: error: ___struct exec___ has no member named 
 ___a_entry___
 arch/x86/ia32/ia32_aout.c: In function ___load_aout_library___:
 arch/x86/ia32/ia32_aout.c:466: error: ___ZMAGIC___ undeclared (first use in 
 this function)
 arch/x86/ia32/ia32_aout.c:466: error: ___QMAGIC___ undeclared (first use in 
 this function)
 arch/x86/ia32/ia32_aout.c:467: error: ___struct exec___ has no member named 
 ___a_entry___
 arch/x86/ia32/ia32_aout.c:469: error: ___struct exec___ has no member named 
 ___a_text___
 arch/x86/ia32/ia32_aout.c:469: error: ___struct exec___ has no member named 
 ___a_data___
 arch/x86/ia32/ia32_aout.c:473: error: implicit declaration of function 
 ___N_FLAGS___
 arch/x86/ia32/ia32_aout.c:479: error: ___struct exec___ has no member named 
 ___a_entry___
 arch/x86/ia32/ia32_aout.c:495: error: ___struct exec___ has no member named 
 ___a_text___
 arch/x86/ia32/ia32_aout.c:495: error: ___struct exec___ has no member named 
 ___a_data___
 arch/x86/ia32/ia32_aout.c:495: error: ___struct exec___ has no member named 
 ___a_bss___
 arch/x86/ia32/ia32_aout.c:499: error: ___struct exec___ has no member named 
 ___a_text___
 arch/x86/ia32/ia32_aout.c:499: error: ___struct exec___ has no member named 
 ___a_data___
 arch/x86/ia32/ia32_aout.c:509: error: ___struct exec___ has no member named 
 ___a_text___
 arch/x86/ia32/ia32_aout.c:509: error: ___struct exec___ has no member named 
 ___a_data___
 arch/x86/ia32/ia32_aout.c:518: error: ___struct exec___ has no member named 
 ___a_text___
 arch/x86/ia32/ia32_aout.c:518: error: ___struct exec___ has no member named 
 ___a_data___
 arch/x86/ia32/ia32_aout.c:519: error: ___struct exec___ has no member named 
 ___a_text___
 arch/x86/ia32/ia32_aout.c:519: error: ___struct 

Re: mm snapshot broken-out-2007-11-20-01-45.tar.gz uploaded

2007-11-20 Thread Paul Moore
On Tuesday 20 November 2007 3:34:24 pm Kamalesh Babulal wrote:
 Hi Andrew,

 The kernel build fails, in selinux with following error

   CHK include/linux/compile.h
   UPD include/linux/compile.h
   CC  init/version.o
   LD  init/built-in.o
   LD  .tmp_vmlinux1
 security/built-in.o(.toc1+0x928): undefined reference to
 `selinux_xfrm_refcount' make: *** [.tmp_vmlinux1] Error 1
 11/20/2007-14:42:08 Build the kernel. Failed rc = 2
 11/20/2007-14:42:08 build: Building kernel... Failed rc = 1

 The patch causing this error is git-lblnet.patch, where in the
 selinux_xfrm_enabled() is called from security/selinux/hooks.c, depends on
 the extern atomic_tselinux_xfrm_refcount.

The problem appears to be that the selinux_xfrm_refcount functionality is not 
properly protected by CONFIG_SECURITY_NETWORK_XFRM.  I'm fixing that now.

-- 
paul moore
linux security @ hp
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: mm snapshot broken-out-2007-11-20-01-45.tar.gz uploaded

2007-11-20 Thread Paul Moore
On Tuesday 20 November 2007 3:48:44 pm Paul Moore wrote:
 On Tuesday 20 November 2007 3:34:24 pm Kamalesh Babulal wrote:
  Hi Andrew,
 
  The kernel build fails, in selinux with following error
 
CHK include/linux/compile.h
UPD include/linux/compile.h
CC  init/version.o
LD  init/built-in.o
LD  .tmp_vmlinux1
  security/built-in.o(.toc1+0x928): undefined reference to
  `selinux_xfrm_refcount' make: *** [.tmp_vmlinux1] Error 1
  11/20/2007-14:42:08 Build the kernel. Failed rc = 2
  11/20/2007-14:42:08 build: Building kernel... Failed rc = 1
 
  The patch causing this error is git-lblnet.patch, where in the
  selinux_xfrm_enabled() is called from security/selinux/hooks.c, depends
  on the extern atomic_tselinux_xfrm_refcount.

 The problem appears to be that the selinux_xfrm_refcount functionality is
 not properly protected by CONFIG_SECURITY_NETWORK_XFRM.  I'm fixing that
 now.

I've fixed the problem in the git tree below, meaning I just did a quick 
compile without defining CONFIG_SECURITY_NETWORK_XFRM and everything appeared 
to link correctly.  I haven't had a chance to try booting the fix yet because 
my test machine is a little slow compiling right now, but the fix was pretty 
trivial (simply move the extern and the inline function) so I don't expect 
any problems.

 * git://git.infradead.org/users/pcmoore/lblnet-2.6_testing

-- 
paul moore
linux security @ hp
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: mm snapshot broken-out-2007-11-20-01-45.tar.gz uploaded

2007-11-20 Thread David Howells
Andrew Morton [EMAIL PROTECTED] wrote:

  The patch
  aout-suppress-aout-library-support-if-config_arch_supports_aout.patch,
  creates a struct exec in linux/a.out.h and asm/a.out.h already has it, for
  the struct related warnings.

Nothing should be including {asm,linux}/a.out.h unless it absolutely needs it.
I removed all the places it did so extraneously, after moving out STACK_TOP.

 OK, I've had it with trying to get that patch to vaguely work.  I'll drop
 it and will then fix up the extensive dependency trail which it drags along
 behind it.
 
 David, please do not bring it back until it has had a *lot* of testing.

It compiles for all the archs for which I have a compiler, and the x86_64 and
i386 kernels all build and boot for the following combinations of AOUT
configs:

x86_64  CONFIG_IA32_AOUT=n
CONFIG_IA32_AOUT=y
CONFIG_IA32_AOUT=m
i386CONFIG_BINFMT_AOUT=n
CONFIG_BINFMT_AOUT=y
CONFIG_BINFMT_AOUT=m

It seems I had forgetten to include:

config ARCH_SUPPORTS_AOUT
def_bool y

in arch/x86/Kconfig, but it builds without that too for both subarchs.

The kernel also builds and boots for MN10300 and FRV.


The problem is that your -mm patchset doesn't match Linus's as a base.  I'm
still not sure what the right procedure is for that.  I can give you some
altered patches, but there's no guarantee you'll be able to pass them on to
Linus without breaking his tree.  What do *you* want?

David
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: mm snapshot broken-out-2007-11-20-01-45.tar.gz uploaded

2007-11-20 Thread Andrew Morton
On Wed, 21 Nov 2007 01:32:48 + David Howells [EMAIL PROTECTED] wrote:

 Andrew Morton [EMAIL PROTECTED] wrote:
 
   The patch
   aout-suppress-aout-library-support-if-config_arch_supports_aout.patch,
   creates a struct exec in linux/a.out.h and asm/a.out.h already has it, for
   the struct related warnings.
 
 Nothing should be including {asm,linux}/a.out.h unless it absolutely needs it.
 I removed all the places it did so extraneously, after moving out STACK_TOP.

So... what went wrong with broken-out-2007-11-20-01-45.tar.gz?

  OK, I've had it with trying to get that patch to vaguely work.  I'll drop
  it and will then fix up the extensive dependency trail which it drags along
  behind it.
  
  David, please do not bring it back until it has had a *lot* of testing.
 
 It compiles for all the archs for which I have a compiler, and the x86_64 and
 i386 kernels all build and boot for the following combinations of AOUT
 configs:
 
   x86_64  CONFIG_IA32_AOUT=n
   CONFIG_IA32_AOUT=y
   CONFIG_IA32_AOUT=m
   i386CONFIG_BINFMT_AOUT=n
   CONFIG_BINFMT_AOUT=y
   CONFIG_BINFMT_AOUT=m
 
 It seems I had forgetten to include:
 
   config ARCH_SUPPORTS_AOUT
   def_bool y
 
 in arch/x86/Kconfig, but it builds without that too for both subarchs.
 
 The kernel also builds and boots for MN10300 and FRV.
 
 
 The problem is that your -mm patchset doesn't match Linus's as a base.  I'm
 still not sure what the right procedure is for that.  I can give you some
 altered patches, but there's no guarantee you'll be able to pass them on to
 Linus without breaking his tree.  What do *you* want?

Often when people base a patch on -mm it is worse than basing it on
mainline - I usually prefer patches against mainline; partly because that's
less work for originators too.

But sometimes it doesn't work out very well.  There's lot of stuff
outstanding again.  Immediate problems are from an x86 exec randomisation
thingy in git-x86 and pie-executable-randomization.patch in -mm, which both
hit on binfmt_elf.c

-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/