[PATCH] w1: fix w1_ds2438 documentation

2018-03-02 Thread Mariusz Bialonczyk
Signed-off-by: Mariusz Bialonczyk <ma...@skyboo.net>
---
 Documentation/w1/slaves/w1_ds2438 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/w1/slaves/w1_ds2438 
b/Documentation/w1/slaves/w1_ds2438
index b99f3674c5b4..e64f65a09387 100644
--- a/Documentation/w1/slaves/w1_ds2438
+++ b/Documentation/w1/slaves/w1_ds2438
@@ -60,4 +60,4 @@ vad: general purpose A/D input (VAD)
 vdd: battery input (VDD)
 
 After the voltage conversion the value is returned as decimal ASCII.
-Note: The value is in mV, so to get a volts the value has to be divided by 10.
+Note: To get a volts the value has to be divided by 100.
-- 
2.16.2



Re: stv090x vs stv0900 support

2013-08-16 Thread Mariusz Bialonczyk
On 07/24/2013 06:39 PM, Chris Lee wrote:
 Im looking for comments on these two modules, they overlap support for
 the same demods. stv0900 supporting stv0900 and stv090x supporting
 stv0900 and stv0903. Ive flipped a few cards from one to the other and
 they function fine. In some ways stv090x is better suited. Its a pain
 supporting two modules that are written differently but do the same
 thing, a fix in one almost always means it has to be implemented in
 the other as well.
I totally agree with you.

 Im not necessarily suggesting dumping stv0900, but Id like to flip a
 few cards that I own over to stv090x just to standardize it. The Prof
 7301 and Prof 7500.
I did it already for 7301, see here:
http://thread.gmane.org/gmane.linux.drivers.video-input-infrastructure/28082
but due to 'political' reasons it doesn't went upstream.
For private use i am still using this patch on recent kernels, because
it is working much more stable for my card comparing to stv0900.
I think that moving prof 7500 should be relative easy, i even prepared
a patch for this but I was not able to test it due to lack of hardware.

 Whats everyones thoughts on this? It will cut the number of patch''s
 in half when it comes to these demods. Ive got alot more coming lol :)
Oh yes, you could also take into account another duplicate code:
stb6100_cfg.h used for stv090x
stb6100_proc.h used for stv0900
In my patch I've successfully switched to stb6100_cfg.h.
 
 Chris
 --
 To unsubscribe from this list: send the line unsubscribe linux-media in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html
 

regards,
-- 
Mariusz Białończyk | xmpp/e-mail: ma...@skyboo.net
http://manio.skyboo.net | https://github.com/manio

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH v2] Add support for Prof Revolution DVB-S2 8000 PCI-E card

2012-09-12 Thread Mariusz Bialonczyk
The device is based on STV0903 demodulator, STB6100 tuner
and CX23885 chipset; subsystem id: 8000:3034

This is a modified version of the official Prof Tuners Group patch:
http://www.proftuners.com/sites/default/files/prof8000_0.patch

Signed-off-by: Mariusz Bialonczyk ma...@skyboo.net
---
 Documentation/video4linux/CARDLIST.cx23885  |1 +
 drivers/media/video/cx23885/Kconfig |2 +
 drivers/media/video/cx23885/cx23885-cards.c |   10 +
 drivers/media/video/cx23885/cx23885-dvb.c   |   56 +++
 drivers/media/video/cx23885/cx23885.h   |1 +
 5 files changed, 70 insertions(+)

diff --git a/Documentation/video4linux/CARDLIST.cx23885 
b/Documentation/video4linux/CARDLIST.cx23885
index 652aecd..1299b5e 100644
--- a/Documentation/video4linux/CARDLIST.cx23885
+++ b/Documentation/video4linux/CARDLIST.cx23885
@@ -35,3 +35,4 @@
  34 - TerraTec Cinergy T PCIe Dual[153b:117e]
  35 - TeVii S471  [d471:9022]
  36 - Hauppauge WinTV-HVR1255 [0070:2259]
+ 37 - Prof Revolution DVB-S2 8000 [8000:3034]
diff --git a/drivers/media/video/cx23885/Kconfig 
b/drivers/media/video/cx23885/Kconfig
index b391e9b..e1c7599 100644
--- a/drivers/media/video/cx23885/Kconfig
+++ b/drivers/media/video/cx23885/Kconfig
@@ -21,6 +21,8 @@ config VIDEO_CX23885
select DVB_STV6110 if !DVB_FE_CUSTOMISE
select DVB_CX24116 if !DVB_FE_CUSTOMISE
select DVB_STV0900 if !DVB_FE_CUSTOMISE
+   select DVB_STV090x if !DVB_FE_CUSTOMISE
+   select DVB_STB6100 if !DVB_FE_CUSTOMISE
select DVB_DS3000 if !DVB_FE_CUSTOMISE
select DVB_STV0367 if !DVB_FE_CUSTOMISE
select MEDIA_TUNER_MT2131 if !MEDIA_TUNER_CUSTOMISE
diff --git a/drivers/media/video/cx23885/cx23885-cards.c 
b/drivers/media/video/cx23885/cx23885-cards.c
index 080e111..50fedff 100644
--- a/drivers/media/video/cx23885/cx23885-cards.c
+++ b/drivers/media/video/cx23885/cx23885-cards.c
@@ -564,6 +564,10 @@ struct cx23885_board cx23885_boards[] = {
[CX23885_BOARD_TEVII_S471] = {
.name   = TeVii S471,
.portb  = CX23885_MPEG_DVB,
+   },
+   [CX23885_BOARD_PROF_8000] = {
+   .name   = Prof Revolution DVB-S2 8000,
+   .portb  = CX23885_MPEG_DVB,
}
 };
 const unsigned int cx23885_bcount = ARRAY_SIZE(cx23885_boards);
@@ -776,6 +780,10 @@ struct cx23885_subid cx23885_subids[] = {
.subvendor = 0xd471,
.subdevice = 0x9022,
.card  = CX23885_BOARD_TEVII_S471,
+   }, {
+   .subvendor = 0x8000,
+   .subdevice = 0x3034,
+   .card  = CX23885_BOARD_PROF_8000,
},
 };
 const unsigned int cx23885_idcount = ARRAY_SIZE(cx23885_subids);
@@ -1155,6 +1163,7 @@ void cx23885_gpio_setup(struct cx23885_dev *dev)
cx_set(GP0_IO, 0x00040004);
break;
case CX23885_BOARD_TBS_6920:
+   case CX23885_BOARD_PROF_8000:
cx_write(MC417_CTL, 0x0036);
cx_write(MC417_OEN, 0x1000);
cx_set(MC417_RWD, 0x0002);
@@ -1536,6 +1545,7 @@ void cx23885_card_setup(struct cx23885_dev *dev)
case CX23885_BOARD_TEVII_S470:
case CX23885_BOARD_TEVII_S471:
case CX23885_BOARD_DVBWORLD_2005:
+   case CX23885_BOARD_PROF_8000:
ts1-gen_ctrl_val  = 0x5; /* Parallel */
ts1-ts_clk_en_val = 0x1; /* Enable TS_CLK */
ts1-src_sel_val   = CX23885_SRC_SEL_PARALLEL_MPEG_VIDEO;
diff --git a/drivers/media/video/cx23885/cx23885-dvb.c 
b/drivers/media/video/cx23885/cx23885-dvb.c
index cd54268..ba046ea 100644
--- a/drivers/media/video/cx23885/cx23885-dvb.c
+++ b/drivers/media/video/cx23885/cx23885-dvb.c
@@ -63,6 +63,9 @@
 #include stv0367.h
 #include drxk.h
 #include mt2063.h
+#include stv090x.h
+#include stb6100.h
+#include stb6100_cfg.h
 
 static unsigned int debug;
 
@@ -489,6 +492,42 @@ static struct xc5000_config mygica_x8506_xc5000_config = {
.if_khz = 5380,
 };
 
+static struct stv090x_config prof_8000_stv090x_config = {
+.device = STV0903,
+.demod_mode = STV090x_SINGLE,
+.clk_mode   = STV090x_CLK_EXT,
+.xtal   = 2700,
+.address= 0x6A,
+.ts1_mode   = STV090x_TSMODE_PARALLEL_PUNCTURED,
+.repeater_level = STV090x_RPTLEVEL_64,
+.adc1_range = STV090x_ADC_2Vpp,
+.diseqc_envelope_mode   = false,
+
+.tuner_get_frequency= stb6100_get_frequency,
+.tuner_set_frequency= stb6100_set_frequency,
+.tuner_set_bandwidth= stb6100_set_bandwidth,
+.tuner_get_bandwidth= stb6100_get_bandwidth,
+};
+
+static struct stb6100_config prof_8000_stb6100_config

Re: [PATCH] Add support for Prof Revolution DVB-S2 8000 PCI-E card

2012-08-01 Thread Mariusz Bialonczyk
On 07/26/2012 08:08 PM, Mariusz Bialonczyk wrote:
 The device is based on STV0903 demodulator, STB6100 tuner
 and CX23885 chipset; subsystem id: 8000:3034
 
 Signed-off-by: Mariusz Bialonczyk ma...@skyboo.net
Igor, can I please get your ACK on this patch?
I was contacting proftuners for information who is the author of the prof8000 
patch (on their website), but i haven't got a clear answer, they only point me 
your hg repo.

regards,
-- 
Mariusz Białończyk
jabber/e-mail: ma...@skyboo.net
http://manio.skyboo.net
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] Add support for Prof Revolution DVB-S2 8000 PCI-E card

2012-07-31 Thread Mariusz Bialonczyk
On 07/31/2012 05:08 AM, Mauro Carvalho Chehab wrote:
 Em 26-07-2012 15:08, Mariusz Bialonczyk escreveu:
 The device is based on STV0903 demodulator, STB6100 tuner
 and CX23885 chipset; subsystem id: 8000:3034

 Signed-off-by: Mariusz Bialonczyk ma...@skyboo.net
 
 This is the second time I see this patch. It seems very similar to the
 one sent by Wojciech. So, who is the author of this patch?
Hi!
Wojciech Myrda's patch was based on original producer patch from here:
http://www.proftuners.com/sites/default/files/prof8000_0.patch

From my diagnose (diff original and his patch) he rebased it to take
into account later kernel sources.

You ask him to post it again with Signed-off-by line, but he doesn't
respond for over a year (at least to linux media mailing list).

My patch uses stv090x frontend instead and I assumed that I can
ommit additional signed-off-by lines in this case.

If it is not ok, please tell me and I will prepare second patch
with additional Signed-off-by lines.

regards!
-- 
Mariusz Białończyk
jabber/e-mail: ma...@skyboo.net
http://manio.skyboo.net
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH] Add support for Prof Revolution DVB-S2 8000 PCI-E card

2012-07-26 Thread Mariusz Bialonczyk
The device is based on STV0903 demodulator, STB6100 tuner
and CX23885 chipset; subsystem id: 8000:3034

Signed-off-by: Mariusz Bialonczyk ma...@skyboo.net
---
 drivers/media/video/cx23885/Kconfig |1 +
 drivers/media/video/cx23885/cx23885-cards.c |   10 +
 drivers/media/video/cx23885/cx23885-dvb.c   |   56 +++
 drivers/media/video/cx23885/cx23885.h   |1 +
 4 files changed, 68 insertions(+)

diff --git a/drivers/media/video/cx23885/Kconfig 
b/drivers/media/video/cx23885/Kconfig
index b391e9b..510adfe 100644
--- a/drivers/media/video/cx23885/Kconfig
+++ b/drivers/media/video/cx23885/Kconfig
@@ -21,6 +21,7 @@ config VIDEO_CX23885
select DVB_STV6110 if !DVB_FE_CUSTOMISE
select DVB_CX24116 if !DVB_FE_CUSTOMISE
select DVB_STV0900 if !DVB_FE_CUSTOMISE
+   select DVB_STV090x if !DVB_FE_CUSTOMISE
select DVB_DS3000 if !DVB_FE_CUSTOMISE
select DVB_STV0367 if !DVB_FE_CUSTOMISE
select MEDIA_TUNER_MT2131 if !MEDIA_TUNER_CUSTOMISE
diff --git a/drivers/media/video/cx23885/cx23885-cards.c 
b/drivers/media/video/cx23885/cx23885-cards.c
index 080e111..50fedff 100644
--- a/drivers/media/video/cx23885/cx23885-cards.c
+++ b/drivers/media/video/cx23885/cx23885-cards.c
@@ -564,6 +564,10 @@ struct cx23885_board cx23885_boards[] = {
[CX23885_BOARD_TEVII_S471] = {
.name   = TeVii S471,
.portb  = CX23885_MPEG_DVB,
+   },
+   [CX23885_BOARD_PROF_8000] = {
+   .name   = Prof Revolution DVB-S2 8000,
+   .portb  = CX23885_MPEG_DVB,
}
 };
 const unsigned int cx23885_bcount = ARRAY_SIZE(cx23885_boards);
@@ -776,6 +780,10 @@ struct cx23885_subid cx23885_subids[] = {
.subvendor = 0xd471,
.subdevice = 0x9022,
.card  = CX23885_BOARD_TEVII_S471,
+   }, {
+   .subvendor = 0x8000,
+   .subdevice = 0x3034,
+   .card  = CX23885_BOARD_PROF_8000,
},
 };
 const unsigned int cx23885_idcount = ARRAY_SIZE(cx23885_subids);
@@ -1155,6 +1163,7 @@ void cx23885_gpio_setup(struct cx23885_dev *dev)
cx_set(GP0_IO, 0x00040004);
break;
case CX23885_BOARD_TBS_6920:
+   case CX23885_BOARD_PROF_8000:
cx_write(MC417_CTL, 0x0036);
cx_write(MC417_OEN, 0x1000);
cx_set(MC417_RWD, 0x0002);
@@ -1536,6 +1545,7 @@ void cx23885_card_setup(struct cx23885_dev *dev)
case CX23885_BOARD_TEVII_S470:
case CX23885_BOARD_TEVII_S471:
case CX23885_BOARD_DVBWORLD_2005:
+   case CX23885_BOARD_PROF_8000:
ts1-gen_ctrl_val  = 0x5; /* Parallel */
ts1-ts_clk_en_val = 0x1; /* Enable TS_CLK */
ts1-src_sel_val   = CX23885_SRC_SEL_PARALLEL_MPEG_VIDEO;
diff --git a/drivers/media/video/cx23885/cx23885-dvb.c 
b/drivers/media/video/cx23885/cx23885-dvb.c
index cd54268..ba046ea 100644
--- a/drivers/media/video/cx23885/cx23885-dvb.c
+++ b/drivers/media/video/cx23885/cx23885-dvb.c
@@ -63,6 +63,9 @@
 #include stv0367.h
 #include drxk.h
 #include mt2063.h
+#include stv090x.h
+#include stb6100.h
+#include stb6100_cfg.h
 
 static unsigned int debug;
 
@@ -489,6 +492,42 @@ static struct xc5000_config mygica_x8506_xc5000_config = {
.if_khz = 5380,
 };
 
+static struct stv090x_config prof_8000_stv090x_config = {
+.device = STV0903,
+.demod_mode = STV090x_SINGLE,
+.clk_mode   = STV090x_CLK_EXT,
+.xtal   = 2700,
+.address= 0x6A,
+.ts1_mode   = STV090x_TSMODE_PARALLEL_PUNCTURED,
+.repeater_level = STV090x_RPTLEVEL_64,
+.adc1_range = STV090x_ADC_2Vpp,
+.diseqc_envelope_mode   = false,
+
+.tuner_get_frequency= stb6100_get_frequency,
+.tuner_set_frequency= stb6100_set_frequency,
+.tuner_set_bandwidth= stb6100_set_bandwidth,
+.tuner_get_bandwidth= stb6100_get_bandwidth,
+};
+
+static struct stb6100_config prof_8000_stb6100_config = {
+   .tuner_address = 0x60,
+   .refclock = 2700,
+};
+
+static int p8000_set_voltage(struct dvb_frontend *fe, fe_sec_voltage_t voltage)
+{
+   struct cx23885_tsport *port = fe-dvb-priv;
+   struct cx23885_dev *dev = port-dev;
+
+   if (voltage == SEC_VOLTAGE_18)
+   cx_write(MC417_RWD, 0x1e00);
+   else if (voltage == SEC_VOLTAGE_13)
+   cx_write(MC417_RWD, 0x1a00);
+   else
+   cx_write(MC417_RWD, 0x1800);
+   return 0;
+}
+
 static int cx23885_dvb_set_frontend(struct dvb_frontend *fe)
 {
struct dtv_frontend_properties *p = fe-dtv_property_cache;
@@ -1186,6 +1225,23 @@ static int dvb_register(struct cx23885_tsport *port)
tevii_ds3000_config

Re: [PATCH] stv090x: implement function for reading uncorrected blocks count

2011-12-29 Thread Mariusz Bialonczyk
On 12/06/2011 07:48 PM, Manu Abraham wrote:
 With UCB, what we imply is the uncorrectable blocks in the Outer
 coding. The CRC encoder/decoder is at the Physical layer, much prior
 and is completely different from what is expected of UCB.

 With the stv0900/3, you don't really have a Uncorrectable 's register
 field, one would need to really calculate that out, rather than
 reading out CRC errors.
 
 Maybe you can try something like this:
 setup ERRCTRL1 to
 
 Bit7-4:1100 (TS error count, packet error final)
 Bit3:reserved:0
 Bit2-0:000 (reset counter on read) 001 (without reset of counter on read)
 
 and the resultant values can be read from
 ERRCNT10
 
 Note that, you get the resultant values as Packet Errors, rather than
 bit errors, so you might need to multiply that by 8.
 
 I have not tried this out. but you can possibly try it.
Thank you for your tips
I try it using the following code:

static int stv090x_read_ucblocks(struct dvb_frontend *fe, u32 *ucblocks)
{
  struct stv090x_state *state = fe-demodulator_priv;
  u32 reg, v;
  u32 val_header_err, val_packet_err;

  switch (state-delsys) {
  case STV090x_DVBS2:
/* Reset the packet Error counter1 */
if (STV090x_WRITE_DEMOD(state, ERRCTRL1, 0xc1)  0)
  goto err;

/* Obtain value */
reg = STV090x_READ_DEMOD(state, ERRCNT10);
v = STV090x_GETFIELD_Px(reg, ERR_CNT10_FIELD);

*ucblocks = (v  3);-// value * 2^3
break;
  default:
return -EINVAL;
  }

  return 0;
err:
  dprintk(FE_ERROR, 1, I/O error);
  return -1;
}

Unfortunately I always obtain value 0. I was also trying with DVB-S2 channel 
tunned for the whole night - and morning I still see 0 value.
Is it possible that it is normal when satellite installation is correctly set?
Maybe i need to wait for some difficulties - like snow on dish?
I think we may leave it as it is now if there's no UCB register...

Another thing related with this frontend:
I am not sure but I think that btw I found some c-p mistake. Please correct if 
I am wrong.
Here's the diff:

diff --git a/drivers/media/dvb/frontends/stv090x.c 
b/drivers/media/dvb/frontends/stv090x.c
index e448851..dd02f9a 100644
--- a/drivers/media/dvb/frontends/stv090x.c
+++ b/drivers/media/dvb/frontends/stv090x.c
@@ -3531,7 +3531,7 @@ static int stv090x_read_per(struct dvb_frontend *fe, u32 
*per)
} else {
/* Counter 2 */
reg = STV090x_READ_DEMOD(state, ERRCNT22);
-   h = STV090x_GETFIELD_Px(reg, ERR_CNT2_FIELD);
+   h = STV090x_GETFIELD_Px(reg, ERR_CNT22_FIELD);
 
reg = STV090x_READ_DEMOD(state, ERRCNT21);
m = STV090x_GETFIELD_Px(reg, ERR_CNT21_FIELD);

regards,
-- 
Mariusz Białończyk
jabber/e-mail: ma...@skyboo.net
http://manio.skyboo.net
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH] stv090x: implement function for reading uncorrected blocks count

2011-11-29 Thread Mariusz Bialonczyk
This patch add support for reading UNC blocks for stv090x frontend.
Partially based on stv0900 code by Abylay Ospan aos...@netup.ru

Signed-off-by: Mariusz Bialonczyk ma...@skyboo.net
---
 drivers/media/dvb/frontends/stv090x.c |   32 +++-
 1 files changed, 31 insertions(+), 1 deletions(-)

diff --git a/drivers/media/dvb/frontends/stv090x.c 
b/drivers/media/dvb/frontends/stv090x.c
index 52d8712..ad6141f 100644
--- a/drivers/media/dvb/frontends/stv090x.c
+++ b/drivers/media/dvb/frontends/stv090x.c
@@ -3687,6 +3687,35 @@ static int stv090x_read_cnr(struct dvb_frontend *fe, u16 
*cnr)
return 0;
 }
 
+static int stv090x_read_ucblocks(struct dvb_frontend *fe, u32 *ucblocks)
+{
+   struct stv090x_state *state = fe-demodulator_priv;
+   u32 reg_0, reg_1;
+   u32 val_header_err, val_packet_err;
+
+   switch (state-delsys) {
+   case STV090x_DVBS2:
+   /* DVB-S2 delineator error count */
+
+   /* retrieving number for erronous headers */
+   reg_1 = stv090x_read_reg(state, STV090x_P1_BBFCRCKO1);
+   reg_0 = stv090x_read_reg(state, STV090x_P1_BBFCRCKO0);
+   val_header_err = MAKEWORD16(reg_1, reg_0);
+
+   /* retrieving number for erronous packets */
+   reg_1 = stv090x_read_reg(state, STV090x_P1_UPCRCKO1);
+   reg_0 = stv090x_read_reg(state, STV090x_P1_UPCRCKO0);
+   val_packet_err = MAKEWORD16(reg_1, reg_0);
+
+   *ucblocks = val_packet_err + val_header_err;
+   break;
+   default:
+   return -EINVAL;
+   }
+
+   return 0;
+}
+
 static int stv090x_set_tone(struct dvb_frontend *fe, fe_sec_tone_mode_t tone)
 {
struct stv090x_state *state = fe-demodulator_priv;
@@ -4748,7 +4777,8 @@ static struct dvb_frontend_ops stv090x_ops = {
.read_status= stv090x_read_status,
.read_ber   = stv090x_read_per,
.read_signal_strength   = stv090x_read_signal_strength,
-   .read_snr   = stv090x_read_cnr
+   .read_snr   = stv090x_read_cnr,
+   .read_ucblocks  = stv090x_read_ucblocks
 };
 
 
-- 
1.7.7.3

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v3] Fix the derot zig-zag to work with TT-USB2.0 TechnoTrend.

2011-05-28 Thread Mariusz Bialonczyk
Hello
I don't know what mailer you're using but your patches
to the ML are malformed (word wrapped).

Please have a look:
http://www.kernel.org/doc/Documentation/email-clients.txt

I don't know for sure but you may need to send them
again (all those malformed)...

regards,
-- 
Mariusz Bialonczyk
jabber/e-mail: ma...@skyboo.net
http://manio.skyboo.net
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] Prof 7301: switching frontend to stv090x, fixing LOCK FAILED issue

2011-02-28 Thread Mariusz Bialonczyk

On 2011-01-16 21:44, Mariusz Bialonczyk wrote:

Fixing the very annoying tunning issue. When switching from DVB-S2 to DVB-S,
it often took minutes to have a lock.

 [...]

The patch is changing the frontend from stv0900 to stv090x.
The card now works much more reliable. There is no problem with switching
from DVB-S2 to DVB-S, tunning works flawless.


Igor, can I get your ACK on this patch?

regards,
--
Mariusz Bialonczyk
jabber/e-mail: ma...@skyboo.net
http://manio.skyboo.net
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] Prof 7301: switching frontend to stv090x, fixing LOCK FAILED issue

2011-02-28 Thread Mariusz Bialonczyk

Tested-by: Michal Wegrzynek michal.wegrzy...@malloc.com.pl
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] Prof 7301: switching frontend to stv090x, fixing LOCK FAILED issue

2011-02-28 Thread Mariusz Bialonczyk
On 02/28/2011 06:01 PM, Igor M. Liplianin wrote:
 For those who ...
 He asked me to get rid of my driver. Why should I?
Maybe because (now) your frontend has problems with tunning on this card?
I though that references are known for you:
1. http://article.gmane.org/gmane.linux.drivers.video-input-infrastructure/24573
2. http://article.gmane.org/gmane.linux.drivers.video-input-infrastructure/25275
3. http://linuxdvb.org.ru/wbb/index.php?page=ThreadthreadID=641

And to be more specific: I am not asking to get rid of your driver,
my patch doesn't touch your stv0900 implementation, it only change the
frontend for one particular card.

 I have 7301, test it myself and see nothing bad with stv0900.
If it is working for you - lucky you! But keep in mind that it it doesn't
mean that it is working for others. Have you tested it with my patch applied?
Besides it is not using your frontend, maybe it just *work*?

 Obviously, I better patch stv0900 then convert the driver to stv090x.
Sure, go ahead... I am only wondering why wasn't you so helpful when I was
trying to contact you and offer debugging help when I discovered the problem
after I started using this card. Your only response was:
I know this issue. Your card is fine.
So now I resolved the problem myself and sent a working solution (tested
by some people - always with good results) and you disagree now.

I'm only hoping that a hardware *usability* will win over an ego!

regards,
-- 
Mariusz Bialonczyk
jabber/e-mail: ma...@skyboo.net
http://manio.skyboo.net
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] Prof 7301: switching frontend to stv090x, fixing LOCK FAILED issue

2011-02-28 Thread Mariusz Bialonczyk
On 02/28/2011 09:37 PM, Igor M. Liplianin wrote:
 Sorry, I have nothing against you personally.
me too :)

 I have excuses, but you not intresting, I think.
 Peace, friendship, chewing gum, like we use to say in my childhood :)
 
 Switching to other driver not helps me, so be patient.
 
 I patched stv0900 and send pull request.
I've tested it - and for the first sight it seems that it indeed
solves the problem. Thank you :)

And about frontend: I think I found a solution which I hope will
satisfy all of us. I think it would be great if user have
an alternative option to use stv090x frontend anyway. I mean your
frontend as default, but a module parameter which enables using
stv090x instead of stv0900 (enabling what's is inside my patch).
This will be a flexible solution which shouldn't harm anyone,
but instead gives an option.

Igor, Mauro, do you have objections against this solution?
If you agree, then I'll try to prepare an RFC patch for that.

regards,
-- 
Mariusz Bialonczyk
jabber/e-mail: ma...@skyboo.net
http://manio.skyboo.net
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH] Prof 7301: switching frontend to stv090x, fixing LOCK FAILED issue

2011-01-16 Thread Mariusz Bialonczyk
Fixing the very annoying tunning issue. When switching from DVB-S2 to DVB-S,
it often took minutes to have a lock.
This issue is known to Igor M. Liplianin and was also reported ie. in the
following posts:
http://article.gmane.org/gmane.linux.drivers.video-input-infrastructure/24573
http://article.gmane.org/gmane.linux.drivers.video-input-infrastructure/25275

The patch is changing the frontend from stv0900 to stv090x.
The card now works much more reliable. There is no problem with switching
from DVB-S2 to DVB-S, tunning works flawless.

Signed-off-by: Mariusz Bialonczyk ma...@skyboo.net
Tested-by: Warpme war...@o2.pl
---
 drivers/media/video/cx88/Kconfig   |2 +-
 drivers/media/video/cx88/cx88-dvb.c|   56 
 2 files changed, 25 insertions(+), 33 deletions(-)

diff --git a/drivers/media/video/cx88/Kconfig b/drivers/media/video/cx88/Kconfig
index 5c42abd..57316bb 100644
--- a/drivers/media/video/cx88/Kconfig
+++ b/drivers/media/video/cx88/Kconfig
@@ -60,7 +60,7 @@ config VIDEO_CX88_DVB
select DVB_STV0299 if !DVB_FE_CUSTOMISE
select DVB_STV0288 if !DVB_FE_CUSTOMISE
select DVB_STB6000 if !DVB_FE_CUSTOMISE
-   select DVB_STV0900 if !DVB_FE_CUSTOMISE
+   select DVB_STV090x if !DVB_FE_CUSTOMISE
select DVB_STB6100 if !DVB_FE_CUSTOMISE
select MEDIA_TUNER_SIMPLE if !MEDIA_TUNER_CUSTOMISE
---help---
diff --git a/drivers/media/video/cx88/cx88-dvb.c 
b/drivers/media/video/cx88/cx88-dvb.c
index 90717ee..3f25872 100644
--- a/drivers/media/video/cx88/cx88-dvb.c
+++ b/drivers/media/video/cx88/cx88-dvb.c
@@ -53,9 +53,9 @@
 #include stv0288.h
 #include stb6000.h
 #include cx24116.h
-#include stv0900.h
+#include stv090x.h
 #include stb6100.h
-#include stb6100_proc.h
+#include stb6100_cfg.h
 #include mb86a16.h
 
 MODULE_DESCRIPTION(driver for cx2388x based DVB cards);
@@ -611,15 +611,6 @@ static int cx24116_set_ts_param(struct dvb_frontend *fe,
return 0;
 }
 
-static int stv0900_set_ts_param(struct dvb_frontend *fe,
-   int is_punctured)
-{
-   struct cx8802_dev *dev = fe-dvb-priv;
-   dev-ts_gen_cntrl = 0;
-
-   return 0;
-}
-
 static int cx24116_reset_device(struct dvb_frontend *fe)
 {
struct cx8802_dev *dev = fe-dvb-priv;
@@ -648,16 +639,21 @@ static const struct cx24116_config tevii_s460_config = {
.reset_device  = cx24116_reset_device,
 };
 
-static const struct stv0900_config prof_7301_stv0900_config = {
-   .demod_address = 0x6a,
-/* demod_mode = 0,*/
-   .xtal = 2700,
-   .clkmode = 3,/* 0-CLKI, 2-XTALI, else AUTO */
-   .diseqc_mode = 2,/* 2/3 PWM */
-   .tun1_maddress = 0,/* 0x60 */
-   .tun1_adc = 0,/* 2 Vpp */
-   .path1_mode = 3,
-   .set_ts_params = stv0900_set_ts_param,
+static struct stv090x_config prof_7301_stv090x_config = {
+.device = STV0903,
+.demod_mode = STV090x_SINGLE,
+.clk_mode   = STV090x_CLK_EXT,
+.xtal   = 2700,
+.address= 0x6A,
+.ts1_mode   = STV090x_TSMODE_PARALLEL_PUNCTURED,
+.repeater_level = STV090x_RPTLEVEL_64,
+.adc1_range = STV090x_ADC_2Vpp,
+.diseqc_envelope_mode   = false,
+
+.tuner_get_frequency= stb6100_get_frequency,
+.tuner_set_frequency= stb6100_set_frequency,
+.tuner_set_bandwidth= stb6100_set_bandwidth,
+.tuner_get_bandwidth= stb6100_get_bandwidth,
 };
 
 static const struct stb6100_config prof_7301_stb6100_config = {
@@ -1402,23 +1398,19 @@ static int dvb_register(struct cx8802_dev *dev)
}
break;
case CX88_BOARD_PROF_7301:{
-   struct dvb_tuner_ops *tuner_ops = NULL;
+   dev-ts_gen_cntrl = 0x00;
 
-   fe0-dvb.frontend = dvb_attach(stv0900_attach,
-   prof_7301_stv0900_config,
-   core-i2c_adap, 0);
+   fe0-dvb.frontend = dvb_attach(stv090x_attach,
+   prof_7301_stv090x_config,
+   core-i2c_adap,
+   STV090x_DEMODULATOR_0);
if (fe0-dvb.frontend != NULL) {
-   if (!dvb_attach(stb6100_attach, fe0-dvb.frontend,
+   if (!dvb_attach(stb6100_attach,
+   fe0-dvb.frontend,
prof_7301_stb6100_config,
core-i2c_adap))
goto frontend_detach;
 
-   tuner_ops = fe0-dvb.frontend-ops.tuner_ops;
-   tuner_ops-set_frequency = stb6100_set_freq;
-   tuner_ops-get_frequency = stb6100_get_freq;
-   tuner_ops

Re: HVR900H : IR Remote Control

2010-11-14 Thread Mariusz Bialonczyk

Hello Massis,

On 11/14/2010 08:22 PM, Massis Sirapian wrote:

Thanks Stefan. I've checked the /drivers/media/IR/keymaps of the kernel
source directory, but nothing seems to fit my remote, which is a
DSR-0012 : http://lirc.sourceforge.net/remotes/hauppauge/DSR-0112.jpg.



Were you talking about these rc_map modules? If so and if there is
corresponding module for my remote, how can I contribute as I have one?


First of all you need to check for the codes if they appear when you
pressing buttons. If you have /dev/input/eventX number then you can use:
input-events X
where X is the event number related with you IR receiver

then you can make a map for you remote (based on that codes you've got)
you can also create the temporary map for testing and load it using
command:
input-kbd -f your_map_file X
where X - event number,
your_map_file - a file with key mappings in format:
key_code = KEY_something, ie:
146 = KEY_0

regards
--
Mariusz Bialonczyk
jabber/e-mail: ma...@skyboo.net
http://manio.skyboo.net
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Fixing tbs-nec table after converting to cx88 driver ir-core

2010-11-12 Thread Mariusz Bialonczyk

Hello
I am using Prof 7301 PCI card.
After converting cx88 driver to ir-core (thank you very much for your
work, David) the table rc-tbs-nec (for bundled remote) has incorrect
values.
I was comparing the results and there is a regularity (constant offset):
If i add 0x80 (128 decimal) value to every code in rc-tbs-nec.c then
original remote gives correct EV_KEY events (just like before cx88
conversion) :)
Despite the fact that my IR receiver is now able to work with many
remotes it is still using standard remote which is in mentioned table,
so I think that we should correct the table to have it correct, what do
you think?

I also need to mention that the table is incomplete.
Please have a look at remote:
http://www.prof-tuners.com/eng/images/review/review_prof_7301/prof_7301_6.jpg

As you can see there are two buttons (10+ and 10-), which the table
doesn't take into account. Correct me if i'm wrong, but i believe it
means: 10 channels up, and 10 channels down.
So my proposition is to add new definitions for this buttons.
Maybe: KEY_10CHANNELSUP and KEY_10CHANNELSDOWN, what do you think?
Unfortunately I can't test the button meaning, because i don't have
windows at home computer with original software for the card.

I can provide full and fixed rc-tbs-nec table patch then.

regards,
--
Mariusz Bialonczyk
jabber/e-mail: ma...@skyboo.net
http://manio.skyboo.net
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html