Re: [GIT PULL for v4.15-rc3] media fixes

[Mauro Carvalho Chehab]

Em Wed, 13 Dec 2017 13:27:47 +0100
Geert Uytterhoeven  escreveu:

> Hi Mauro,
> 
> On Wed, Dec 13, 2017 at 12:53 PM, Mauro Carvalho Chehab
>  wrote:
> > Em Wed, 13 Dec 2017 10:03:56 +0100
> > Geert Uytterhoeven  escreveu:  
> >> On Mon, Dec 11, 2017 at 12:12 PM, Mauro Carvalho Chehab
> >>  wrote:  
> >> > Without this series, I was getting 809 lines of bogus warnings (see 
> >> > below),
> >> > with was preventing me to see new warnings on my incremental builds
> >> > while applying new patches at the media tree.  
> >>
> >> $ linux-log-diff build.log{.old,}
> >>
> >> (from https://github.com/geertu/linux-scripts)  
> >
> > That's nice!
> >
> > Yet, it is producing some noise. I did a clean build with:
> >
> > $ make ARCH=i386  CF=-D__CHECK_ENDIAN__ CONFIG_DEBUG_SECTION_MISMATCH=y W=1 
> > CHECK='' M=drivers/staging/media | grep -v -e " CC " -e " LD " -e " AR " -e 
> > " CHK " -e " CALL " -e " UPD " -e "scripts/kconfig/conf " -e " CHECK " 
> > >old.log
> > $ make ARCH=i386  CF=-D__CHECK_ENDIAN__ CONFIG_DEBUG_SECTION_MISMATCH=y W=1 
> > CHECK='' M=drivers/media| grep -v -e " CC " -e " LD " -e " AR " -e " CHK " 
> > -e " CALL " -e " UPD " -e "scripts/kconfig/conf " -e " CHECK "  >>old.log
> >
> > and added a new uninitialized "foo" var to a random driver, doing an
> > incremental build with:
> >
> > $ make ARCH=i386  CF=-D__CHECK_ENDIAN__ CONFIG_DEBUG_SECTION_MISMATCH=y W=1 
> > CHECK='' | grep -v -e " CC " -e " LD " -e " AR " -e " CHK " -e " CALL " -e 
> > " UPD " -e "scripts/kconfig/conf " -e " CHECK " M=drivers/staging/media 
> > >new.log
> > $ make ARCH=i386  CF=-D__CHECK_ENDIAN__ CONFIG_DEBUG_SECTION_MISMATCH=y W=1 
> > CHECK='' | grep -v -e " CC " -e " LD " -e " AR " -e " CHK " -e " CALL " -e 
> > " UPD " -e "scripts/kconfig/conf " -e " CHECK " M=drivers/media >new.log
> >
> > Then, I ran the script:
> >
> > $ linux-log-diff old.log new.log
> >
> > *** ERRORS ***
> >
> >
> > *** WARNINGS ***
> >
> > 1 warning regressions:
> >   + drivers/media/dvb-frontends/dibx000_common.c: warning: unused variable 
> > 'foo' [-Wunused-variable]:  => 22:5
> >
> > 3 warning improvements:
> >   - ./arch/x86/include/asm/bitops.h: warning: asm output is not an lvalue: 
> > 430:22 =>
> >   - 
> > drivers/staging/media/atomisp/pci/atomisp2/css2400/hive_isp_css_common/host/mmu_private.h:
> >  warning: function 'mmu_reg_load' with external linkage has definition: 
> > 35:30 =>
> >   - 
> > drivers/staging/media/atomisp/pci/atomisp2/css2400/hive_isp_css_common/host/mmu_private.h:
> >  warning: function 'mmu_reg_store' with external linkage has definition: 
> > 24:26 =>
> >
> > It detected the "foo" var warning, but it outputs 3 warning improvements
> > on files that were not even built the second time.  
> 
> If the file wasn't built, the warning cannot be in the log ;-)
> So yes, it works best for full builds, only flagging warnings that
> (dis)appeared (and ignoring changes due to changed line numbers!).
> 
> If you do lots of incremental builds, you want to append the last incremental
> log to the existing full log before doing a new build, to avoid false 
> positives
> from files that weren't built in the previous run:
> 
> $ cat new.log >> old.log
> $ make ... > new.log
> $ linux-log-diff old.log new.log
> 
> And only new warnings should be reported.

Ok. I'll do some trials with this script, as it sounds promising!

Regards,
Mauro


-- 
Thanks,
Mauro

Re: [GIT PULL for v4.15-rc3] media fixes

[Geert Uytterhoeven]

Hi Mauro,

On Wed, Dec 13, 2017 at 12:53 PM, Mauro Carvalho Chehab
 wrote:
> Em Wed, 13 Dec 2017 10:03:56 +0100
> Geert Uytterhoeven  escreveu:
>> On Mon, Dec 11, 2017 at 12:12 PM, Mauro Carvalho Chehab
>>  wrote:
>> > Without this series, I was getting 809 lines of bogus warnings (see below),
>> > with was preventing me to see new warnings on my incremental builds
>> > while applying new patches at the media tree.
>>
>> $ linux-log-diff build.log{.old,}
>>
>> (from https://github.com/geertu/linux-scripts)
>
> That's nice!
>
> Yet, it is producing some noise. I did a clean build with:
>
> $ make ARCH=i386  CF=-D__CHECK_ENDIAN__ CONFIG_DEBUG_SECTION_MISMATCH=y W=1 
> CHECK='' M=drivers/staging/media | grep -v -e " CC " -e " LD " -e " AR " -e " 
> CHK " -e " CALL " -e " UPD " -e "scripts/kconfig/conf " -e " CHECK " >old.log
> $ make ARCH=i386  CF=-D__CHECK_ENDIAN__ CONFIG_DEBUG_SECTION_MISMATCH=y W=1 
> CHECK='' M=drivers/media| grep -v -e " CC " -e " LD " -e " AR " -e " CHK " -e 
> " CALL " -e " UPD " -e "scripts/kconfig/conf " -e " CHECK "  >>old.log
>
> and added a new uninitialized "foo" var to a random driver, doing an
> incremental build with:
>
> $ make ARCH=i386  CF=-D__CHECK_ENDIAN__ CONFIG_DEBUG_SECTION_MISMATCH=y W=1 
> CHECK='' | grep -v -e " CC " -e " LD " -e " AR " -e " CHK " -e " CALL " -e " 
> UPD " -e "scripts/kconfig/conf " -e " CHECK " M=drivers/staging/media >new.log
> $ make ARCH=i386  CF=-D__CHECK_ENDIAN__ CONFIG_DEBUG_SECTION_MISMATCH=y W=1 
> CHECK='' | grep -v -e " CC " -e " LD " -e " AR " -e " CHK " -e " CALL " -e " 
> UPD " -e "scripts/kconfig/conf " -e " CHECK " M=drivers/media >new.log
>
> Then, I ran the script:
>
> $ linux-log-diff old.log new.log
>
> *** ERRORS ***
>
>
> *** WARNINGS ***
>
> 1 warning regressions:
>   + drivers/media/dvb-frontends/dibx000_common.c: warning: unused variable 
> 'foo' [-Wunused-variable]:  => 22:5
>
> 3 warning improvements:
>   - ./arch/x86/include/asm/bitops.h: warning: asm output is not an lvalue: 
> 430:22 =>
>   - 
> drivers/staging/media/atomisp/pci/atomisp2/css2400/hive_isp_css_common/host/mmu_private.h:
>  warning: function 'mmu_reg_load' with external linkage has definition: 35:30 
> =>
>   - 
> drivers/staging/media/atomisp/pci/atomisp2/css2400/hive_isp_css_common/host/mmu_private.h:
>  warning: function 'mmu_reg_store' with external linkage has definition: 
> 24:26 =>
>
> It detected the "foo" var warning, but it outputs 3 warning improvements
> on files that were not even built the second time.

If the file wasn't built, the warning cannot be in the log ;-)
So yes, it works best for full builds, only flagging warnings that
(dis)appeared (and ignoring changes due to changed line numbers!).

If you do lots of incremental builds, you want to append the last incremental
log to the existing full log before doing a new build, to avoid false positives
from files that weren't built in the previous run:

$ cat new.log >> old.log
$ make ... > new.log
$ linux-log-diff old.log new.log

And only new warnings should be reported.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Re: [GIT PULL for v4.15-rc3] media fixes

[Mauro Carvalho Chehab]

Em Wed, 13 Dec 2017 10:03:56 +0100
Geert Uytterhoeven  escreveu:

> Hi Mauro,
> 
> On Mon, Dec 11, 2017 at 12:12 PM, Mauro Carvalho Chehab
>  wrote:
> > Without this series, I was getting 809 lines of bogus warnings (see below),
> > with was preventing me to see new warnings on my incremental builds
> > while applying new patches at the media tree.  
> 
> $ linux-log-diff build.log{.old,}
> 
> (from https://github.com/geertu/linux-scripts)

That's nice!

Yet, it is producing some noise. I did a clean build with:

$ make ARCH=i386  CF=-D__CHECK_ENDIAN__ CONFIG_DEBUG_SECTION_MISMATCH=y W=1 
CHECK='' M=drivers/staging/media | grep -v -e " CC " -e " LD " -e " AR " -e " 
CHK " -e " CALL " -e " UPD " -e "scripts/kconfig/conf " -e " CHECK " >old.log
$ make ARCH=i386  CF=-D__CHECK_ENDIAN__ CONFIG_DEBUG_SECTION_MISMATCH=y W=1 
CHECK='' M=drivers/media| grep -v -e " CC " -e " LD " -e " AR " -e " CHK " -e " 
CALL " -e " UPD " -e "scripts/kconfig/conf " -e " CHECK "  >>old.log

and added a new uninitialized "foo" var to a random driver, doing an
incremental build with:

$ make ARCH=i386  CF=-D__CHECK_ENDIAN__ CONFIG_DEBUG_SECTION_MISMATCH=y W=1 
CHECK='' | grep -v -e " CC " -e " LD " -e " AR " -e " CHK " -e " CALL " -e " 
UPD " -e "scripts/kconfig/conf " -e " CHECK " M=drivers/staging/media >new.log
$ make ARCH=i386  CF=-D__CHECK_ENDIAN__ CONFIG_DEBUG_SECTION_MISMATCH=y W=1 
CHECK='' | grep -v -e " CC " -e " LD " -e " AR " -e " CHK " -e " CALL " -e " 
UPD " -e "scripts/kconfig/conf " -e " CHECK " M=drivers/media >new.log

Then, I ran the script:

$ linux-log-diff old.log new.log

*** ERRORS ***


*** WARNINGS ***

1 warning regressions:
  + drivers/media/dvb-frontends/dibx000_common.c: warning: unused variable 
'foo' [-Wunused-variable]:  => 22:5

3 warning improvements:
  - ./arch/x86/include/asm/bitops.h: warning: asm output is not an lvalue: 
430:22 => 
  - 
drivers/staging/media/atomisp/pci/atomisp2/css2400/hive_isp_css_common/host/mmu_private.h:
 warning: function 'mmu_reg_load' with external linkage has definition: 35:30 
=> 
  - 
drivers/staging/media/atomisp/pci/atomisp2/css2400/hive_isp_css_common/host/mmu_private.h:
 warning: function 'mmu_reg_store' with external linkage has definition: 24:26 
=> 

It detected the "foo" var warning, but it outputs 3 warning improvements
on files that were not even built the second time.

-- 
Thanks,
Mauro

Re: [GIT PULL for v4.15-rc3] media fixes

[Geert Uytterhoeven]

Hi Mauro,

On Mon, Dec 11, 2017 at 12:12 PM, Mauro Carvalho Chehab
 wrote:
> Without this series, I was getting 809 lines of bogus warnings (see below),
> with was preventing me to see new warnings on my incremental builds
> while applying new patches at the media tree.

$ linux-log-diff build.log{.old,}

(from https://github.com/geertu/linux-scripts)

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Re: [GIT PULL for v4.15-rc3] media fixes

[Mauro Carvalho Chehab]

Hi Linus,

Em Fri, 8 Dec 2017 13:28:57 -0800
Linus Torvalds  escreveu:

> On Fri, Dec 8, 2017 at 7:56 AM, Mauro Carvalho Chehab
>  wrote:
> >
> > - The largest amount of fixes in this series is with regards to comments
> >   that aren't kernel-doc, but start with "/**". A new check added for
> >   4.15 makes it to produce a *huge* amount of new warnings (I'm compiling
> >   here with W=1). Most of the patches in this series fix those. No code
> >   changes - just comment changes at the source files;  
> 
> Guys, this was just pure garbage, and obviously noboduy actually
> looked at that shit-for-brains patch.
> 
> There were several idiotic things like this:
> 
>   -/**
>   +/*
> 
> because part of it was apparently generated with some overly stupid
> search-and-replace. So when replacing "/**" with "/*", it also just
> removed a star from those boxed-in comments.
> 
> In the process that thing also made some of those boxes no longer aligned.
> 
> Now, box comments are stupid anyway, but they become truly
> mind-bogglingly pointless when they are then edited like this.

Sorry for that. On most patches, the regex was more smart than that,
but on a few I had to use a more stupid regex, and used git citool
to exclude the hunks like above. Clearly, I missed some such blocks at
dvb-frontends/drx* and stating/atomisp drivers.

The comments on both drivers need to be reviewed anyway. Both have
a large amount of comments using alien formats (doxygen, apparently),
like this (before this changeset):

/**
 * \def DRXJ_DEF_I2C_ADDR
 * \brief Default I2C address of a demodulator instance.
 */
#define DRXJ_DEF_I2C_ADDR (0x52)

Once I tried to cleanup those comments, but there are just too many
things there that would require manual fix, requiring a large amount
of time to do it manually. Maybe one day I may do it.

Also, on several of them (like the above), we don't even have a way
to convert to docbook, as docbook currently doesn't allow documenting
defines and static vars.

> I've pulled this, but dammit, show some amount of sense. We shouldn't
> have this kind of pointless noise in the rc series. That pointless
> noise may now be hiding the real changes.

Thanks for pulling it, and sorry for the noise.

Without this series, I was getting 809 lines of bogus warnings (see below),
with was preventing me to see new warnings on my incremental builds
while applying new patches at the media tree.

-- 
Thanks,
Mauro


$ make ARCH=i386  CF=-D__CHECK_ENDIAN__ CONFIG_DEBUG_SECTION_MISMATCH=y W=1 
CHECK='' M=drivers/staging/media
drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/isys_stream2mmio_rmgr.c:17:
 warning: Cannot understand Support for Intel Camera Imaging ISP subsystem.
 on line 17 - I thought it was a doc line
drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/eventq/src/eventq.c:41:
 warning: Cannot understand  * @brief The Host sends the event to the SP.
 on line 41 - I thought it was a doc line
drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/rmgr/src/rmgr.c:17: 
warning: Cannot understand Support for Intel Camera Imaging ISP subsystem.
 on line 17 - I thought it was a doc line
drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/rmgr/src/rmgr.c:48: 
warning: Cannot understand  * @brief Uninitialize resource pool (host)
 on line 48 - I thought it was a doc line
drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/virtual_isys.c:17:
 warning: Cannot understand Support for Intel Camera Imaging ISP subsystem.
 on line 17 - I thought it was a doc line
drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/timer/src/timer.c:17:
 warning: Cannot understand Support for Intel Camera Imaging ISP subsystem.
 on line 17 - I thought it was a doc line
drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/ibuf_ctrl_rmgr.c:40:
 warning: cannot understand function prototype: 'ibuf_rsrc_tibuf_rsrc; '
drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/isys_init.c:17:
 warning: Cannot understand Support for Intel Camera Imaging ISP subsystem.
 on line 17 - I thought it was a doc line
drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/isys_dma_rmgr.c:17:
 warning: Cannot understand Support for Intel Camera Imaging ISP subsystem.
 on line 17 - I thought it was a doc line
drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/csi_rx_rmgr.c:17:
 warning: Cannot understand Support for Intel Camera Imaging ISP subsystem.
 on line 17 - I thought it was a doc line
drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/rx.c:17: 
warning: Cannot understand Support for Intel Camera Imaging ISP subsystem.
 on line 17 - I thought it was a doc line
drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/inputfifo/src/inputfifo.c:17:
 warning: Cannot understand Support for Intel Camera Imaging ISP 

Re: [GIT PULL for v4.15-rc3] media fixes

[Linus Torvalds]

On Fri, Dec 8, 2017 at 7:56 AM, Mauro Carvalho Chehab
 wrote:
>
> - The largest amount of fixes in this series is with regards to comments
>   that aren't kernel-doc, but start with "/**". A new check added for
>   4.15 makes it to produce a *huge* amount of new warnings (I'm compiling
>   here with W=1). Most of the patches in this series fix those. No code
>   changes - just comment changes at the source files;

Guys, this was just pure garbage, and obviously noboduy actually
looked at that shit-for-brains patch.

There were several idiotic things like this:

  -/**
  +/*

because part of it was apparently generated with some overly stupid
search-and-replace. So when replacing "/**" with "/*", it also just
removed a star from those boxed-in comments.

In the process that thing also made some of those boxes no longer aligned.

Now, box comments are stupid anyway, but they become truly
mind-bogglingly pointless when they are then edited like this.

I've pulled this, but dammit, show some amount of sense. We shouldn't
have this kind of pointless noise in the rc series. That pointless
noise may now be hiding the real changes.

  Linus

[GIT PULL for v4.15-rc3] media fixes

[Mauro Carvalho Chehab]

Hi Linus,

Please pull from:
  git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media 
tags/media/v4.15-2

For a series of fixes for the media subsytem:

- The largest amount of fixes in this series is with regards to comments
  that aren't kernel-doc, but start with "/**". A new check added for
  4.15 makes it to produce a *huge* amount of new warnings (I'm compiling
  here with W=1). Most of the patches in this series fix those. No code
  changes - just comment changes at the source files;
- rc: some fixed in order to better handle RC repetition codes;
- v4l-async: use the v4l2_dev from the root notifier when matching sub-devices;
- v4l2-fwnode: Check subdev count after checking port
- ov 13858 and et8ek8: compilation fix with randconfigs;
- usbtv: a trivial new USB ID addition;
- dibusb-common: don't do DMA on stack on firmware load;
- imx274: Fix error handling, add MAINTAINERS entry;
- sir_ir: detect presence of port.

The following changes since commit 4fbd8d194f06c8a3fd2af1ce560ddb31f7ec8323:

  Linux 4.15-rc1 (2017-11-26 16:01:47 -0800)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media 
tags/media/v4.15-2

for you to fetch changes up to 781b045baefdabf7e0bc9f33672ca830d3db9f27:

  media: imx274: Fix error handling, add MAINTAINERS entry (2017-11-30 04:45:12 
-0500)


media fixes for v4.15-rc3


Arnd Bergmann (1):
  media: et8ek8: select V4L2_FWNODE

Icenowy Zheng (1):
  media: usbtv: add a new usbid

Laurent Caumont (1):
  media: dvb: i2c transfers over usb cannot be done from stack

Mauro Carvalho Chehab (42):
  Merge tag 'v4.15-rc1' into patchwork
  media: dvb_ca_en50221: fix lots of documentation warnings
  media: rc: fix lots of documentation warnings
  media: siano: get rid of documentation warnings
  media: img-ir-hw: fix one kernel-doc comment
  media: drxj and drxk: don't produce kernel-doc warnings
  media: vpif: don't generate a kernel-doc warning on a constant
  media: dvb_frontend fix kernel_doc markups
  media: rc-ir-raw: cleanup kernel-doc markups
  media: dvb_net: stop abusing /** for comments
  media: ir-nec-decoder: fix kernel-doc parameters
  media: imon: don't use kernel-doc "/**" markups
  media: videobuf2: don't use kernel-doc "/**" markups
  media: atomisp: stop producing hundreds of kernel-doc warnings
  media: rc: fix kernel-doc parameter names
  media: v4l2-core: Fix kernel-doc markups
  media: davinci: fix kernel-doc warnings
  media: venc: don't use kernel-doc for undescribed enums
  media: exynos4-is: fix kernel-doc warnings
  media: m5mols: fix some kernel-doc markups
  media: sta2x11: document missing function parameters
  media: pxa_camera: get rid of kernel_doc warnings
  media: tw68: fix kernel-doc markups
  media: ix2505v: get rid of /** comments
  media: radio-si476x: fix kernel-doc markups
  media: s5k6a3: document some fields at struct s5k6a3
  media: s5k6aa: describe some function parameters
  media: netup_unidvb: fix a bad kernel-doc markup
  media: tvp514x: fix kernel-doc parameters
  media: vdec: fix some kernel-doc warnings
  media: mtk-vpu: add description for wdt fields at struct mtk_vpu
  media: s3c-camif: add missing description at s3c_camif_find_format()
  media: radio-wl1273: fix a parameter name at kernel-doc macro
  media: mt2063: fix some kernel-doc warnings
  media: soc_camera: fix a kernel-doc markup
  media: vsp1: add a missing kernel-doc parameter
  media: rcar_jpu: fix two kernel-doc markups
  media: lm3560: add a missing kernel-doc parameter
  media: drivers: remove "/**" from non-kernel-doc comments
  media: dvb_frontends: fix kernel-doc macros
  media: docs: add documentation for frontend attach info
  media: dvb-frontends: complete kernel-doc markups

Niklas Söderlund (1):
  media: v4l: async: use the v4l2_dev from the root notifier when matching 
sub-devices

Sakari Ailus (2):
  media: ov13858: Select V4L2_FWNODE
  media: imx274: Fix error handling, add MAINTAINERS entry

Sean Young (2):
  media: rc: sir_ir: detect presence of port
  media: rc: partial revert of "media: rc: per-protocol repeat period"

Tomasz Figa (1):
  media: v4l2-fwnode: Check subdev count after checking port

 Documentation/media/dvb-drivers/frontends.rst  |  30 +
 Documentation/media/dvb-drivers/index.rst  |   1 +
 MAINTAINERS|   8 +
 drivers/media/common/siano/smscoreapi.c|  66 +-
 drivers/media/dvb-core/dvb_ca_en50221.c|  68 +-
 drivers/media/dvb-core/dvb_frontend.c  |  13 +-
 drivers/media/dvb-core/dvb_net.c   |  15 +-
 drivers/media/dvb-frontends/af9013.h