Re: [PATCH] staging: media: use octal permissions

[Sean Young]

On Wed, Feb 15, 2017 at 04:27:01PM -0600, d...@cako.io wrote:
> Replace all instances of permission macros with octal permissions
> 
> Signed-off-by: David Cako 
> ---
>  drivers/staging/media/lirc/lirc_parallel.c | 10 +-
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/media/lirc/lirc_parallel.c

lirc_parallel has been dropped, I'm afraid so the patch no longer applies.

Thanks
Sean

[PATCH] staging: media: use octal permissions

[dc]

Replace all instances of permission macros with octal permissions

Signed-off-by: David Cako 
---
 drivers/staging/media/lirc/lirc_parallel.c | 10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/media/lirc/lirc_parallel.c  
b/drivers/staging/media/lirc/lirc_parallel.c

index 0a43bac2b..94d2c61 100644
--- a/drivers/staging/media/lirc/lirc_parallel.c
+++ b/drivers/staging/media/lirc/lirc_parallel.c
@@ -756,17 +756,17 @@ MODULE_DESCRIPTION("Infrared receiver driver for  
parallel ports.");

 MODULE_AUTHOR("Christoph Bartelmus");
 MODULE_LICENSE("GPL");

-module_param(io, int, S_IRUGO);
+module_param(io, int, 0444);
 MODULE_PARM_DESC(io, "I/O address base (0x3bc, 0x378 or 0x278)");

-module_param(irq, int, S_IRUGO);
+module_param(irq, int, 0444);
 MODULE_PARM_DESC(irq, "Interrupt (7 or 5)");

-module_param(tx_mask, int, S_IRUGO);
+module_param(tx_mask, int, 0444);
 MODULE_PARM_DESC(tx_mask, "Transmitter mask (default: 0x01)");

-module_param(debug, bool, S_IRUGO | S_IWUSR);
+module_param(debug, bool, 0644);
 MODULE_PARM_DESC(debug, "Enable debugging messages");

-module_param(check_pselecd, bool, S_IRUGO | S_IWUSR);
+module_param(check_pselecd, bool, 0644);
 MODULE_PARM_DESC(check_pselecd, "Check for printer (default: 0)");
--
2.7.4