Re: [PATCH 0/9] Unify i2c_mux_add_adapter error reporting

[Mauro Carvalho Chehab]

Em Mon, 3 Apr 2017 13:27:48 +0200
Peter Rosin  escreveu:

> On 2017-04-03 12:27, Wolfram Sang wrote:
> > On Mon, Apr 03, 2017 at 10:38:29AM +0200, Peter Rosin wrote:  
> >> Hi!
> >>
> >> Many users of the i2c_mux_add_adapter interface log a message
> >> on failure, but the function already logs such a message. One
> >> or two of those users actually add more information than already
> >> provided by the central failure message.
> >>
> >> So, first fix the central error reporting to provide as much
> >> information as any current user, and then remove the surplus
> >> error reporting at the call sites.  
> > 
> > Yes, I like.
> > 
> > Reviewed-by: Wolfram Sang   
> 
> Thanks!
> 
> BTW, the improved error reporting in patch 1/9 is not needed for
> patches 8/9 and 9/9 to make sense, the existing central error
> message is already good enough. So, iio and media maintainers,
> feel free to just grab those two patches. Or, they can go via
> Wolfram and the i2c tree with the rest of the series. Either way
> is fine with me, just let me know.

Feel free to submit via I2C tree, together with the patch series:

Reviewed-by: Mauro Carvalho Chehab 

> 
> Cheers,
> peda



Thanks,
Mauro

Re: [PATCH 0/9] Unify i2c_mux_add_adapter error reporting

[Peter Rosin]

On 2017-04-03 10:38, Peter Rosin wrote:
> Hi!
> 
> Many users of the i2c_mux_add_adapter interface log a message
> on failure, but the function already logs such a message. One
> or two of those users actually add more information than already
> provided by the central failure message.
> 
> So, first fix the central error reporting to provide as much
> information as any current user, and then remove the surplus
> error reporting at the call sites.

I have now pushed patches 1-7 to i2c-mux/for-next.
Jonathan grabbed patch 8 and it's going through the iio tree.
Still waiting on patch 9 and the media maintainers.

Cheers,
Peter

> 
> Cheers,
> peda
> 
> Peter Rosin (9):
>   i2c: mux: provide more info on failure in i2c_mux_add_adapter
>   i2c: arb: gpio-challenge: stop double error reporting
>   i2c: mux: gpio: stop double error reporting
>   i2c: mux: pca9541: stop double error reporting
>   i2c: mux: pca954x: stop double error reporting
>   i2c: mux: pinctrl: stop double error reporting
>   i2c: mux: reg: stop double error reporting
>   iio: gyro: mpu3050: stop double error reporting
>   [media] cx231xx: stop double error reporting
> 
>  drivers/i2c/i2c-mux.c  |  9 ++---
>  drivers/i2c/muxes/i2c-arb-gpio-challenge.c |  4 +---
>  drivers/i2c/muxes/i2c-mux-gpio.c   |  4 +---
>  drivers/i2c/muxes/i2c-mux-pca9541.c|  4 +---
>  drivers/i2c/muxes/i2c-mux-pca954x.c|  7 +--
>  drivers/i2c/muxes/i2c-mux-pinctrl.c|  4 +---
>  drivers/i2c/muxes/i2c-mux-reg.c|  4 +---
>  drivers/iio/gyro/mpu3050-i2c.c |  5 ++---
>  drivers/media/usb/cx231xx/cx231xx-i2c.c| 15 ---
>  9 files changed, 18 insertions(+), 38 deletions(-)
> 

Re: [PATCH 0/9] Unify i2c_mux_add_adapter error reporting

[Peter Rosin]

On 2017-04-03 12:27, Wolfram Sang wrote:
> On Mon, Apr 03, 2017 at 10:38:29AM +0200, Peter Rosin wrote:
>> Hi!
>>
>> Many users of the i2c_mux_add_adapter interface log a message
>> on failure, but the function already logs such a message. One
>> or two of those users actually add more information than already
>> provided by the central failure message.
>>
>> So, first fix the central error reporting to provide as much
>> information as any current user, and then remove the surplus
>> error reporting at the call sites.
> 
> Yes, I like.
> 
> Reviewed-by: Wolfram Sang 

Thanks!

BTW, the improved error reporting in patch 1/9 is not needed for
patches 8/9 and 9/9 to make sense, the existing central error
message is already good enough. So, iio and media maintainers,
feel free to just grab those two patches. Or, they can go via
Wolfram and the i2c tree with the rest of the series. Either way
is fine with me, just let me know.

Cheers,
peda

Re: [PATCH 0/9] Unify i2c_mux_add_adapter error reporting

[Wolfram Sang]

On Mon, Apr 03, 2017 at 10:38:29AM +0200, Peter Rosin wrote:
> Hi!
> 
> Many users of the i2c_mux_add_adapter interface log a message
> on failure, but the function already logs such a message. One
> or two of those users actually add more information than already
> provided by the central failure message.
> 
> So, first fix the central error reporting to provide as much
> information as any current user, and then remove the surplus
> error reporting at the call sites.

Yes, I like.

Reviewed-by: Wolfram Sang 



signature.asc
Description: PGP signature

[PATCH 0/9] Unify i2c_mux_add_adapter error reporting

[Peter Rosin]

Hi!

Many users of the i2c_mux_add_adapter interface log a message
on failure, but the function already logs such a message. One
or two of those users actually add more information than already
provided by the central failure message.

So, first fix the central error reporting to provide as much
information as any current user, and then remove the surplus
error reporting at the call sites.

Cheers,
peda

Peter Rosin (9):
  i2c: mux: provide more info on failure in i2c_mux_add_adapter
  i2c: arb: gpio-challenge: stop double error reporting
  i2c: mux: gpio: stop double error reporting
  i2c: mux: pca9541: stop double error reporting
  i2c: mux: pca954x: stop double error reporting
  i2c: mux: pinctrl: stop double error reporting
  i2c: mux: reg: stop double error reporting
  iio: gyro: mpu3050: stop double error reporting
  [media] cx231xx: stop double error reporting

 drivers/i2c/i2c-mux.c  |  9 ++---
 drivers/i2c/muxes/i2c-arb-gpio-challenge.c |  4 +---
 drivers/i2c/muxes/i2c-mux-gpio.c   |  4 +---
 drivers/i2c/muxes/i2c-mux-pca9541.c|  4 +---
 drivers/i2c/muxes/i2c-mux-pca954x.c|  7 +--
 drivers/i2c/muxes/i2c-mux-pinctrl.c|  4 +---
 drivers/i2c/muxes/i2c-mux-reg.c|  4 +---
 drivers/iio/gyro/mpu3050-i2c.c |  5 ++---
 drivers/media/usb/cx231xx/cx231xx-i2c.c| 15 ---
 9 files changed, 18 insertions(+), 38 deletions(-)

-- 
2.1.4