Re: [PATCH 03/10] media: dt-bindings: vpif: extend the example with an output port

[Bartosz Golaszewski]

2017-02-15 23:08 GMT+01:00 Rob Herring :
> On Tue, Feb 07, 2017 at 05:41:16PM +0100, Bartosz Golaszewski wrote:
>> This makes the example more or less correspond with the da850-evm
>> hardware setup.
>>
>> Signed-off-by: Bartosz Golaszewski 
>> ---
>>  .../devicetree/bindings/media/ti,da850-vpif.txt| 35 
>> ++
>>  1 file changed, 29 insertions(+), 6 deletions(-)
>
> Spoke too soon...
>
>>
>> diff --git a/Documentation/devicetree/bindings/media/ti,da850-vpif.txt 
>> b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt
>> index 9c7510b..543f6f3 100644
>> --- a/Documentation/devicetree/bindings/media/ti,da850-vpif.txt
>> +++ b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt
>> @@ -28,19 +28,27 @@ I2C-connected TVP5147 decoder:
>>   reg = <0x217000 0x1000>;
>>   interrupts = <92>;
>>
>> - port {
>> - vpif_ch0: endpoint@0 {
>> + port@0 {
>> + vpif_input_ch0: endpoint@0 {
>>   reg = <0>;
>>   bus-width = <8>;
>> - remote-endpoint = <>;
>> + remote-endpoint = <_in>;
>>   };
>>
>> - vpif_ch1: endpoint@1 {
>> + vpif_input_ch1: endpoint@1 {
>>   reg = <1>;
>>   bus-width = <8>;
>>   data-shift = <8>;
>>   };
>>   };
>> +
>> + port@1 {
>
> The binding doc says nothing about supporting a 2nd port.
>

I assumed that "It should contain at least one port child node" means
there can be more than one.

Thanks,
Bartosz

>
>> + vpif_output_ch0: endpoint@0 {
>> + reg = <0>;
>
> Don't need reg here.
>
>> + bus-width = <8>;
>> + remote-endpoint = <_out>;
>> + };
>> + };
>>   };

Re: [PATCH 03/10] media: dt-bindings: vpif: extend the example with an output port

[Laurent Pinchart]

Hi Rob,

On Wednesday 15 Feb 2017 16:08:22 Rob Herring wrote:
> On Tue, Feb 07, 2017 at 05:41:16PM +0100, Bartosz Golaszewski wrote:
> > This makes the example more or less correspond with the da850-evm
> > hardware setup.
> > 
> > Signed-off-by: Bartosz Golaszewski 
> > ---
> > 
> >  .../devicetree/bindings/media/ti,da850-vpif.txt| 35 +
> >  1 file changed, 29 insertions(+), 6 deletions(-)
> 
> Spoke too soon...
> 
> > diff --git a/Documentation/devicetree/bindings/media/ti,da850-vpif.txt
> > b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt index
> > 9c7510b..543f6f3 100644
> > --- a/Documentation/devicetree/bindings/media/ti,da850-vpif.txt
> > +++ b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt
> > @@ -28,19 +28,27 @@ I2C-connected TVP5147 decoder:
> > reg = <0x217000 0x1000>;
> > interrupts = <92>;
> > 
> > -   port {
> > -   vpif_ch0: endpoint@0 {
> > +   port@0 {
> > +   vpif_input_ch0: endpoint@0 {
> > reg = <0>;
> > bus-width = <8>;
> > -   remote-endpoint = <>;
> > +   remote-endpoint = <_in>;
> > };
> > 
> > -   vpif_ch1: endpoint@1 {
> > +   vpif_input_ch1: endpoint@1 {
> > reg = <1>;
> > bus-width = <8>;
> > data-shift = <8>;
> > };
> > };
> > +
> > +   port@1 {
> 
> The binding doc says nothing about supporting a 2nd port.
> 
> > +   vpif_output_ch0: endpoint@0 {
> > +   reg = <0>;
> 
> Don't need reg here.

And the node should then be named endpoint, not endpoint@0.

> > +   bus-width = <8>;
> > +   remote-endpoint = <_out>;
> > +   };
> > +   };
> > };

-- 
Regards,

Laurent Pinchart

Re: [PATCH 03/10] media: dt-bindings: vpif: extend the example with an output port

[Rob Herring]

On Tue, Feb 07, 2017 at 05:41:16PM +0100, Bartosz Golaszewski wrote:
> This makes the example more or less correspond with the da850-evm
> hardware setup.
> 
> Signed-off-by: Bartosz Golaszewski 
> ---
>  .../devicetree/bindings/media/ti,da850-vpif.txt| 35 
> ++
>  1 file changed, 29 insertions(+), 6 deletions(-)

Spoke too soon...

> 
> diff --git a/Documentation/devicetree/bindings/media/ti,da850-vpif.txt 
> b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt
> index 9c7510b..543f6f3 100644
> --- a/Documentation/devicetree/bindings/media/ti,da850-vpif.txt
> +++ b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt
> @@ -28,19 +28,27 @@ I2C-connected TVP5147 decoder:
>   reg = <0x217000 0x1000>;
>   interrupts = <92>;
>  
> - port {
> - vpif_ch0: endpoint@0 {
> + port@0 {
> + vpif_input_ch0: endpoint@0 {
>   reg = <0>;
>   bus-width = <8>;
> - remote-endpoint = <>;
> + remote-endpoint = <_in>;
>   };
>  
> - vpif_ch1: endpoint@1 {
> + vpif_input_ch1: endpoint@1 {
>   reg = <1>;
>   bus-width = <8>;
>   data-shift = <8>;
>   };
>   };
> +
> + port@1 {

The binding doc says nothing about supporting a 2nd port. 


> + vpif_output_ch0: endpoint@0 {
> + reg = <0>;

Don't need reg here.

> + bus-width = <8>;
> + remote-endpoint = <_out>;
> + };
> + };
>   };

Re: [PATCH 03/10] media: dt-bindings: vpif: extend the example with an output port

[Rob Herring]

On Tue, Feb 07, 2017 at 05:41:16PM +0100, Bartosz Golaszewski wrote:
> This makes the example more or less correspond with the da850-evm
> hardware setup.
> 
> Signed-off-by: Bartosz Golaszewski 
> ---
>  .../devicetree/bindings/media/ti,da850-vpif.txt| 35 
> ++
>  1 file changed, 29 insertions(+), 6 deletions(-)

Acked-by: Rob Herring  

[PATCH 03/10] media: dt-bindings: vpif: extend the example with an output port

[Bartosz Golaszewski]

This makes the example more or less correspond with the da850-evm
hardware setup.

Signed-off-by: Bartosz Golaszewski 
---
 .../devicetree/bindings/media/ti,da850-vpif.txt| 35 ++
 1 file changed, 29 insertions(+), 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/media/ti,da850-vpif.txt 
b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt
index 9c7510b..543f6f3 100644
--- a/Documentation/devicetree/bindings/media/ti,da850-vpif.txt
+++ b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt
@@ -28,19 +28,27 @@ I2C-connected TVP5147 decoder:
reg = <0x217000 0x1000>;
interrupts = <92>;
 
-   port {
-   vpif_ch0: endpoint@0 {
+   port@0 {
+   vpif_input_ch0: endpoint@0 {
reg = <0>;
bus-width = <8>;
-   remote-endpoint = <>;
+   remote-endpoint = <_in>;
};
 
-   vpif_ch1: endpoint@1 {
+   vpif_input_ch1: endpoint@1 {
reg = <1>;
bus-width = <8>;
data-shift = <8>;
};
};
+
+   port@1 {
+   vpif_output_ch0: endpoint@0 {
+   reg = <0>;
+   bus-width = <8>;
+   remote-endpoint = <_out>;
+   };
+   };
};
 
 [ ... ]
@@ -53,13 +61,28 @@ I2C-connected TVP5147 decoder:
status = "okay";
 
port {
-   composite: endpoint {
+   composite_in: endpoint {
hsync-active = <1>;
vsync-active = <1>;
pclk-sample = <0>;
 
/* VPIF channel 0 (lower 8-bits) */
-   remote-endpoint = <_ch0>;
+   remote-endpoint = <_input_ch0>;
+   bus-width = <8>;
+   };
+   };
+   };
+
+   adv7343@2a {
+   compatible = "adi,adv7343";
+   reg = <0x2a>;
+
+   port {
+   composite_out: endpoint {
+   adi,dac-enable = <1 1 1>;
+   adi,sd-dac-enable = <1>;
+
+   remote-endpoint = <_output_ch0>;
bus-width = <8>;
};
};
-- 
2.9.3

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html