RE: [PATCH 1/2] dt-bindings: media: rcar_vin: add device tree support for r8a774[35]

[Fabrizio Castro]

Hi Geert,

> >>
> >> Please keep the list sorted by SoC part number.
> >
> > It is sorted, just in descending order. Do you want me to re-order the full 
> > list in ascending order?
>
> That may be a good idea, given the current order is non-standard and
> counter-intuitive.

sure, dropping this series and sending a v2 then.

Cheers,
Fab

>
> Thanks!
>
> Gr{oetje,eeting}s,
>
> Geert



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, 
Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered 
No. 04586709.

Re: [PATCH 1/2] dt-bindings: media: rcar_vin: add device tree support for r8a774[35]

[Geert Uytterhoeven]

Hi Fabrizio,

On Thu, Nov 16, 2017 at 2:45 PM, Fabrizio Castro
<fabrizio.cas...@bp.renesas.com> wrote:
>> Subject: Re: [PATCH 1/2] dt-bindings: media: rcar_vin: add device tree 
>> support for r8a774[35]
>>
>> On Thu, Nov 16, 2017 at 1:11 PM, Fabrizio Castro
>> <fabrizio.cas...@bp.renesas.com> wrote:
>> > --- a/Documentation/devicetree/bindings/media/rcar_vin.txt
>> > +++ b/Documentation/devicetree/bindings/media/rcar_vin.txt
>> > @@ -14,7 +14,10 @@ channel which can be either RGB, YUYV or BT656.
>> > - "renesas,vin-r8a7790" for the R8A7790 device
>> > - "renesas,vin-r8a7779" for the R8A7779 device
>> > - "renesas,vin-r8a7778" for the R8A7778 device
>> > -   - "renesas,rcar-gen2-vin" for a generic R-Car Gen2 compatible device.
>> > +   - "renesas,vin-r8a7745" for the R8A7745 device
>> > +   - "renesas,vin-r8a7743" for the R8A7743 device
>>
>> Please keep the list sorted by SoC part number.
>
> It is sorted, just in descending order. Do you want me to re-order the full 
> list in ascending order?

That may be a good idea, given the current order is non-standard and
counter-intuitive.

Thanks!

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

RE: [PATCH 1/2] dt-bindings: media: rcar_vin: add device tree support for r8a774[35]

[Fabrizio Castro]

Hello Geert,

thank you for your comment!

> Subject: Re: [PATCH 1/2] dt-bindings: media: rcar_vin: add device tree 
> support for r8a774[35]
>
> On Thu, Nov 16, 2017 at 1:11 PM, Fabrizio Castro
> <fabrizio.cas...@bp.renesas.com> wrote:
> > --- a/Documentation/devicetree/bindings/media/rcar_vin.txt
> > +++ b/Documentation/devicetree/bindings/media/rcar_vin.txt
> > @@ -14,7 +14,10 @@ channel which can be either RGB, YUYV or BT656.
> > - "renesas,vin-r8a7790" for the R8A7790 device
> > - "renesas,vin-r8a7779" for the R8A7779 device
> > - "renesas,vin-r8a7778" for the R8A7778 device
> > -   - "renesas,rcar-gen2-vin" for a generic R-Car Gen2 compatible device.
> > +   - "renesas,vin-r8a7745" for the R8A7745 device
> > +   - "renesas,vin-r8a7743" for the R8A7743 device
>
> Please keep the list sorted by SoC part number.
>

It is sorted, just in descending order. Do you want me to re-order the full 
list in ascending order?

Thanks,
Fab





Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, 
Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered 
No. 04586709.

RE: [PATCH 1/2] dt-bindings: media: rcar_vin: add device tree support for r8a774[35]

[Fabrizio Castro]

Hello Geert,

thank you for your comment!

> > Add compatible strings for r8a7743 and r8a7745. No driver change
> > change is needed as "renesas,rcar-gen2-vin" will activate the right
>
> double "change"

ps, do you think a v2 is in order?

Thanks,
Fab



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, 
Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered 
No. 04586709.

Re: [PATCH 1/2] dt-bindings: media: rcar_vin: add device tree support for r8a774[35]

[Geert Uytterhoeven]

On Thu, Nov 16, 2017 at 1:11 PM, Fabrizio Castro
 wrote:
> --- a/Documentation/devicetree/bindings/media/rcar_vin.txt
> +++ b/Documentation/devicetree/bindings/media/rcar_vin.txt
> @@ -14,7 +14,10 @@ channel which can be either RGB, YUYV or BT656.
> - "renesas,vin-r8a7790" for the R8A7790 device
> - "renesas,vin-r8a7779" for the R8A7779 device
> - "renesas,vin-r8a7778" for the R8A7778 device
> -   - "renesas,rcar-gen2-vin" for a generic R-Car Gen2 compatible device.
> +   - "renesas,vin-r8a7745" for the R8A7745 device
> +   - "renesas,vin-r8a7743" for the R8A7743 device

Please keep the list sorted by SoC part number.

> +   - "renesas,rcar-gen2-vin" for a generic R-Car Gen2 or RZ/G1 compatible
> + device.
> - "renesas,rcar-gen3-vin" for a generic R-Car Gen3 compatible device.
>
> When compatible with the generic version nodes must list the

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Re: [PATCH 1/2] dt-bindings: media: rcar_vin: add device tree support for r8a774[35]

[Geert Uytterhoeven]

On Thu, Nov 16, 2017 at 1:11 PM, Fabrizio Castro
 wrote:
> Add compatible strings for r8a7743 and r8a7745. No driver change
> change is needed as "renesas,rcar-gen2-vin" will activate the right

double "change"

> code. However, it is good practice to document compatible strings
> for the specific SoC as this allows SoC specific changes to the
> driver if needed, in addition to document SoC support and therefore
> allow checkpatch.pl to validate compatible string values.
>
> Signed-off-by: Fabrizio Castro 
> Reviewed-by: Biju Das 

Reviewed-by: Geert Uytterhoeven 

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

[PATCH 1/2] dt-bindings: media: rcar_vin: add device tree support for r8a774[35]

[Fabrizio Castro]

Add compatible strings for r8a7743 and r8a7745. No driver change
change is needed as "renesas,rcar-gen2-vin" will activate the right
code. However, it is good practice to document compatible strings
for the specific SoC as this allows SoC specific changes to the
driver if needed, in addition to document SoC support and therefore
allow checkpatch.pl to validate compatible string values.

Signed-off-by: Fabrizio Castro 
Reviewed-by: Biju Das 
---
 Documentation/devicetree/bindings/media/rcar_vin.txt | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/media/rcar_vin.txt 
b/Documentation/devicetree/bindings/media/rcar_vin.txt
index 6e4ef8c..0042ef2 100644
--- a/Documentation/devicetree/bindings/media/rcar_vin.txt
+++ b/Documentation/devicetree/bindings/media/rcar_vin.txt
@@ -14,7 +14,10 @@ channel which can be either RGB, YUYV or BT656.
- "renesas,vin-r8a7790" for the R8A7790 device
- "renesas,vin-r8a7779" for the R8A7779 device
- "renesas,vin-r8a7778" for the R8A7778 device
-   - "renesas,rcar-gen2-vin" for a generic R-Car Gen2 compatible device.
+   - "renesas,vin-r8a7745" for the R8A7745 device
+   - "renesas,vin-r8a7743" for the R8A7743 device
+   - "renesas,rcar-gen2-vin" for a generic R-Car Gen2 or RZ/G1 compatible
+ device.
- "renesas,rcar-gen3-vin" for a generic R-Car Gen3 compatible device.
 
When compatible with the generic version nodes must list the
-- 
2.7.4