Re: [PATCH 2/3] [media] adv7180: Add cropcap operation

2016-04-03 Thread Hans Verkuil



On 04/02/2016 10:42 AM, Niklas Söderlund wrote:

Add support to get the pixel aspect ratio depending on the current
standard (50 vs 60 Hz).

Signed-off-by: Niklas Söderlund 


Acked-by: Hans Verkuil 

Thanks!

Hans


---
  drivers/media/i2c/adv7180.c | 16 
  1 file changed, 16 insertions(+)

diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv7180.c
index d680d76..80ded70 100644
--- a/drivers/media/i2c/adv7180.c
+++ b/drivers/media/i2c/adv7180.c
@@ -726,6 +726,21 @@ static int adv7180_g_mbus_config(struct v4l2_subdev *sd,
return 0;
  }

+static int adv7180_cropcap(struct v4l2_subdev *sd, struct v4l2_cropcap 
*cropcap)
+{
+   struct adv7180_state *state = to_state(sd);
+
+   if (state->curr_norm & V4L2_STD_525_60) {
+   cropcap->pixelaspect.numerator = 11;
+   cropcap->pixelaspect.denominator = 10;
+   } else {
+   cropcap->pixelaspect.numerator = 54;
+   cropcap->pixelaspect.denominator = 59;
+   }
+
+   return 0;
+}
+
  static const struct v4l2_subdev_video_ops adv7180_video_ops = {
.s_std = adv7180_s_std,
.g_std = adv7180_g_std,
@@ -733,6 +748,7 @@ static const struct v4l2_subdev_video_ops adv7180_video_ops 
= {
.g_input_status = adv7180_g_input_status,
.s_routing = adv7180_s_routing,
.g_mbus_config = adv7180_g_mbus_config,
+   .cropcap = adv7180_cropcap,
  };




--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH 2/3] [media] adv7180: Add cropcap operation

2016-04-02 Thread Niklas Söderlund
Add support to get the pixel aspect ratio depending on the current
standard (50 vs 60 Hz).

Signed-off-by: Niklas Söderlund 
---
 drivers/media/i2c/adv7180.c | 16 
 1 file changed, 16 insertions(+)

diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv7180.c
index d680d76..80ded70 100644
--- a/drivers/media/i2c/adv7180.c
+++ b/drivers/media/i2c/adv7180.c
@@ -726,6 +726,21 @@ static int adv7180_g_mbus_config(struct v4l2_subdev *sd,
return 0;
 }
 
+static int adv7180_cropcap(struct v4l2_subdev *sd, struct v4l2_cropcap 
*cropcap)
+{
+   struct adv7180_state *state = to_state(sd);
+
+   if (state->curr_norm & V4L2_STD_525_60) {
+   cropcap->pixelaspect.numerator = 11;
+   cropcap->pixelaspect.denominator = 10;
+   } else {
+   cropcap->pixelaspect.numerator = 54;
+   cropcap->pixelaspect.denominator = 59;
+   }
+
+   return 0;
+}
+
 static const struct v4l2_subdev_video_ops adv7180_video_ops = {
.s_std = adv7180_s_std,
.g_std = adv7180_g_std,
@@ -733,6 +748,7 @@ static const struct v4l2_subdev_video_ops adv7180_video_ops 
= {
.g_input_status = adv7180_g_input_status,
.s_routing = adv7180_s_routing,
.g_mbus_config = adv7180_g_mbus_config,
+   .cropcap = adv7180_cropcap,
 };
 
 
-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html