Re: [PATCH 4/6] [media] tw5864: improve subscribe event handling

[Andrey Utkin]

Hi Gustavo,

Thanks for the patches, and sorry for delay.

Acked-by: Andrey Utkin 

[PATCH 4/6] [media] tw5864: improve subscribe event handling

[Gustavo Padovan]

From: Gustavo Padovan 

We already check for the V4L2_EVENT_CTRL inside
v4l2_ctrl_subscribe_event() so just move this function to the default:
branch of the switch and let it does the job for us.

Signed-off-by: Gustavo Padovan 
---
 drivers/media/pci/tw5864/tw5864-video.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/media/pci/tw5864/tw5864-video.c 
b/drivers/media/pci/tw5864/tw5864-video.c
index 9421216..6d5ed8e 100644
--- a/drivers/media/pci/tw5864/tw5864-video.c
+++ b/drivers/media/pci/tw5864/tw5864-video.c
@@ -664,15 +664,14 @@ static int tw5864_subscribe_event(struct v4l2_fh *fh,
  const struct v4l2_event_subscription *sub)
 {
switch (sub->type) {
-   case V4L2_EVENT_CTRL:
-   return v4l2_ctrl_subscribe_event(fh, sub);
case V4L2_EVENT_MOTION_DET:
/*
 * Allow for up to 30 events (1 second for NTSC) to be stored.
 */
return v4l2_event_subscribe(fh, sub, 30, NULL);
+   default:
+   return v4l2_ctrl_subscribe_event(fh, sub);
}
-   return -EINVAL;
 }
 
 static void tw5864_frame_interval_set(struct tw5864_input *input)
-- 
2.9.3