Re: [PATCH v4 17/36] media: Add userspace header file for i.MX
On 02/16/2017 03:33 AM, Philipp Zabel wrote: On Wed, 2017-02-15 at 18:19 -0800, Steve Longerbeam wrote: +/* + * events from the subdevs + */ +#define V4L2_EVENT_IMX_CLASS V4L2_EVENT_PRIVATE_START +#define V4L2_EVENT_IMX_NFB4EOF(V4L2_EVENT_IMX_CLASS + 1) +#define V4L2_EVENT_IMX_FRAME_INTERVAL (V4L2_EVENT_IMX_CLASS + 2) These events are still i.MX specific. I think they shouldn't be. Done, I've exported them to V4L2_EVENT_FRAME_INTERVAL_ERROR V4L2_EVENT_NEW_FRAME_BEFORE_EOF Steve
Re: [PATCH v4 17/36] media: Add userspace header file for i.MX
On Wed, 2017-02-15 at 18:19 -0800, Steve Longerbeam wrote: > This adds a header file for use by userspace programs wanting to interact > with the i.MX media driver. It defines custom v4l2 controls and events > generated by the i.MX v4l2 subdevices. > > Signed-off-by: Steve Longerbeam> --- > include/uapi/media/Kbuild | 1 + > include/uapi/media/imx.h | 29 + > 2 files changed, 30 insertions(+) > create mode 100644 include/uapi/media/imx.h > > diff --git a/include/uapi/media/Kbuild b/include/uapi/media/Kbuild > index aafaa5a..fa78958 100644 > --- a/include/uapi/media/Kbuild > +++ b/include/uapi/media/Kbuild > @@ -1 +1,2 @@ > # UAPI Header export list > +header-y += imx.h > diff --git a/include/uapi/media/imx.h b/include/uapi/media/imx.h > new file mode 100644 > index 000..1fdd1c1 > --- /dev/null > +++ b/include/uapi/media/imx.h > @@ -0,0 +1,29 @@ > +/* > + * Copyright (c) 2014-2015 Mentor Graphics Inc. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by the > + * Free Software Foundation; either version 2 of the > + * License, or (at your option) any later version > + */ > + > +#ifndef __UAPI_MEDIA_IMX_H__ > +#define __UAPI_MEDIA_IMX_H__ > + > +/* > + * events from the subdevs > + */ > +#define V4L2_EVENT_IMX_CLASS V4L2_EVENT_PRIVATE_START > +#define V4L2_EVENT_IMX_NFB4EOF(V4L2_EVENT_IMX_CLASS + 1) > +#define V4L2_EVENT_IMX_FRAME_INTERVAL (V4L2_EVENT_IMX_CLASS + 2) These events are still i.MX specific. I think they shouldn't be. > +enum imx_ctrl_id { > + V4L2_CID_IMX_MOTION = (V4L2_CID_USER_IMX_BASE + 0), > + V4L2_CID_IMX_FIM_ENABLE, > + V4L2_CID_IMX_FIM_NUM, > + V4L2_CID_IMX_FIM_TOLERANCE_MIN, > + V4L2_CID_IMX_FIM_TOLERANCE_MAX, > + V4L2_CID_IMX_FIM_NUM_SKIP, > +}; > + > +#endif regards Philipp
[PATCH v4 17/36] media: Add userspace header file for i.MX
This adds a header file for use by userspace programs wanting to interact with the i.MX media driver. It defines custom v4l2 controls and events generated by the i.MX v4l2 subdevices. Signed-off-by: Steve Longerbeam--- include/uapi/media/Kbuild | 1 + include/uapi/media/imx.h | 29 + 2 files changed, 30 insertions(+) create mode 100644 include/uapi/media/imx.h diff --git a/include/uapi/media/Kbuild b/include/uapi/media/Kbuild index aafaa5a..fa78958 100644 --- a/include/uapi/media/Kbuild +++ b/include/uapi/media/Kbuild @@ -1 +1,2 @@ # UAPI Header export list +header-y += imx.h diff --git a/include/uapi/media/imx.h b/include/uapi/media/imx.h new file mode 100644 index 000..1fdd1c1 --- /dev/null +++ b/include/uapi/media/imx.h @@ -0,0 +1,29 @@ +/* + * Copyright (c) 2014-2015 Mentor Graphics Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by the + * Free Software Foundation; either version 2 of the + * License, or (at your option) any later version + */ + +#ifndef __UAPI_MEDIA_IMX_H__ +#define __UAPI_MEDIA_IMX_H__ + +/* + * events from the subdevs + */ +#define V4L2_EVENT_IMX_CLASS V4L2_EVENT_PRIVATE_START +#define V4L2_EVENT_IMX_NFB4EOF(V4L2_EVENT_IMX_CLASS + 1) +#define V4L2_EVENT_IMX_FRAME_INTERVAL (V4L2_EVENT_IMX_CLASS + 2) + +enum imx_ctrl_id { + V4L2_CID_IMX_MOTION = (V4L2_CID_USER_IMX_BASE + 0), + V4L2_CID_IMX_FIM_ENABLE, + V4L2_CID_IMX_FIM_NUM, + V4L2_CID_IMX_FIM_TOLERANCE_MIN, + V4L2_CID_IMX_FIM_TOLERANCE_MAX, + V4L2_CID_IMX_FIM_NUM_SKIP, +}; + +#endif -- 2.7.4