Re: [PATCH v6 0/8] Move device tree graph parsing helpers to drivers/of
On Thu, Mar 06, 2014 at 05:50:30PM +0100, Philipp Zabel wrote: Am Donnerstag, den 06.03.2014, 17:32 +0100 schrieb Sylwester Nawrocki: On 06/03/14 17:21, Philipp Zabel wrote: Am Donnerstag, den 06.03.2014, 16:47 +0100 schrieb Sylwester Nawrocki: Yes, it's going to conflict with my patch series. I thought it could be put onto a stable a topic branch, e.g. at git://linuxtv.org/media_tree.git, which could be then pulled into the media master branch and anywhere else it is needed ? Mauro, are you ok with handling the conflict in the merge, or should I rebase on top of the media tree after you merged Sylwester's changes? I could rebase and resolve any conflicts before sending my pull request to Mauro. I don't think it's a good idea to rebase this series onto the media tree, since it is touching drivers/of. Excellent, thanks. I will send a pull request to Mauro and Russell shortly. Unless we can find some way to resolve the problem which just happened (Mauro applied the of-graph as patches to his tree inspite of this discussion), I don't see the imx-drm DT changes being able to be pulled in for the upcoming merge window - because otherwise it means that whatever Mauro has applied your of-graph changes on top of in his tree also gets pulled into my tree and Greg's tree. I'm afraid this has turned into a total shambles, and I'm totally hacked off at Mauro over this. -- FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly improving, and getting towards what was expected from it. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 0/8] Move device tree graph parsing helpers to drivers/of
On Thu, 6 Mar 2014 15:50:18 +, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Thu, Mar 06, 2014 at 04:39:39PM +0100, Philipp Zabel wrote: Am Donnerstag, den 06.03.2014, 15:24 + schrieb Russell King - ARM Linux: On Wed, Mar 05, 2014 at 10:20:34AM +0100, Philipp Zabel wrote: this version of the OF graph helper move series further addresses a few of Tomi's and Sylwester's comments. Philipp, You mention in your other cover for imx-drm bits that this is available via: git://git.pengutronix.de/git/pza/linux.git topic/of-graph What is this tree based upon? It is based on v3.14-rc5. Great. As everyone seems happy, can you both send me and Mauro a pull request for this please? Once Mauro says it's in his tree, I'll pull it in for imx-drm stuff. Thanks. I'm really not. There are still unresolved issues. g. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 0/8] Move device tree graph parsing helpers to drivers/of
On Thu, 06 Mar 2014 12:17:21 -0300, Mauro Carvalho Chehab m.che...@samsung.com wrote: Em Thu, 06 Mar 2014 14:16:57 + Russell King - ARM Linux li...@arm.linux.org.uk escreveu: On Wed, Mar 05, 2014 at 03:42:34PM +0100, Philipp Zabel wrote: Am Mittwoch, den 05.03.2014, 13:35 +0200 schrieb Tomi Valkeinen: Hi, On 05/03/14 11:20, Philipp Zabel wrote: Hi, this version of the OF graph helper move series further addresses a few of Tomi's and Sylwester's comments. Changes since v5: - Fixed spelling errors and a wrong device node name in the link section - Added parentless previous endpoint's full name to warning - Fixed documentation comment for of_graph_parse_endpoint - Unrolled for-loop in of_graph_get_remote_port_parent Philipp Zabel (8): [media] of: move graph helpers from drivers/media/v4l2-core to drivers/of Documentation: of: Document graph bindings of: Warn if of_graph_get_next_endpoint is called with the root node of: Reduce indentation in of_graph_get_next_endpoint [media] of: move common endpoint parsing to drivers/of of: Implement simplified graph binding for single port devices of: Document simplified graph binding for single port devices of: Warn if of_graph_parse_endpoint is called with the root node So, as I've pointed out, I don't agree with the API, as it's too limited and I can't use it, but as this series is (mostly) about moving the current API to a common place, it's fine for me. Acked-by: Tomi Valkeinen tomi.valkei...@ti.com Thanks. I'll be happy to help expanding the API to parse ports individually, once this gets accepted. Mauro, Guennadi, are you fine with how this turned out? I'd like to get your acks again, for the changed location. From my side, there's nothing on such code that is V4L2 specific. Moving it to drivers/of makes sense on my eyes. Acked-by: Mauro Carvalho Chehab m.che...@samsung.com I'll need those acks before I can even think about queuing up the imx-drm bits. Another way to deal with this is if this gets pulled into the V4L tree from Philipp's git tree, I can also pull that in myself. What mustn't happen is for these to be committed independently as patches. If everyone agrees, I actually prefer have this patch applied on my tree, in order to avoid some potential merge conflicts at the merge window, as we might have other drivers and changes there touching on those API calls (I'm aware of a series of patches from Sylwester with some DT stuff on it. Not sure if it would be affected by such changes or not). No. I disagree. Aside from the api changes this is primarily a drivers/of series. I should go via me or Rob Herring. If you're concerned about resolving conflicts then I can put it into a separate branch that you can merge into your tree also. g. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 0/8] Move device tree graph parsing helpers to drivers/of
On Wed, Mar 05, 2014 at 03:42:34PM +0100, Philipp Zabel wrote: Am Mittwoch, den 05.03.2014, 13:35 +0200 schrieb Tomi Valkeinen: Hi, On 05/03/14 11:20, Philipp Zabel wrote: Hi, this version of the OF graph helper move series further addresses a few of Tomi's and Sylwester's comments. Changes since v5: - Fixed spelling errors and a wrong device node name in the link section - Added parentless previous endpoint's full name to warning - Fixed documentation comment for of_graph_parse_endpoint - Unrolled for-loop in of_graph_get_remote_port_parent Philipp Zabel (8): [media] of: move graph helpers from drivers/media/v4l2-core to drivers/of Documentation: of: Document graph bindings of: Warn if of_graph_get_next_endpoint is called with the root node of: Reduce indentation in of_graph_get_next_endpoint [media] of: move common endpoint parsing to drivers/of of: Implement simplified graph binding for single port devices of: Document simplified graph binding for single port devices of: Warn if of_graph_parse_endpoint is called with the root node So, as I've pointed out, I don't agree with the API, as it's too limited and I can't use it, but as this series is (mostly) about moving the current API to a common place, it's fine for me. Acked-by: Tomi Valkeinen tomi.valkei...@ti.com Thanks. I'll be happy to help expanding the API to parse ports individually, once this gets accepted. Mauro, Guennadi, are you fine with how this turned out? I'd like to get your acks again, for the changed location. I'll need those acks before I can even think about queuing up the imx-drm bits. Another way to deal with this is if this gets pulled into the V4L tree from Philipp's git tree, I can also pull that in myself. What mustn't happen is for these to be committed independently as patches. -- FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly improving, and getting towards what was expected from it. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 0/8] Move device tree graph parsing helpers to drivers/of
Em Thu, 06 Mar 2014 14:16:57 + Russell King - ARM Linux li...@arm.linux.org.uk escreveu: On Wed, Mar 05, 2014 at 03:42:34PM +0100, Philipp Zabel wrote: Am Mittwoch, den 05.03.2014, 13:35 +0200 schrieb Tomi Valkeinen: Hi, On 05/03/14 11:20, Philipp Zabel wrote: Hi, this version of the OF graph helper move series further addresses a few of Tomi's and Sylwester's comments. Changes since v5: - Fixed spelling errors and a wrong device node name in the link section - Added parentless previous endpoint's full name to warning - Fixed documentation comment for of_graph_parse_endpoint - Unrolled for-loop in of_graph_get_remote_port_parent Philipp Zabel (8): [media] of: move graph helpers from drivers/media/v4l2-core to drivers/of Documentation: of: Document graph bindings of: Warn if of_graph_get_next_endpoint is called with the root node of: Reduce indentation in of_graph_get_next_endpoint [media] of: move common endpoint parsing to drivers/of of: Implement simplified graph binding for single port devices of: Document simplified graph binding for single port devices of: Warn if of_graph_parse_endpoint is called with the root node So, as I've pointed out, I don't agree with the API, as it's too limited and I can't use it, but as this series is (mostly) about moving the current API to a common place, it's fine for me. Acked-by: Tomi Valkeinen tomi.valkei...@ti.com Thanks. I'll be happy to help expanding the API to parse ports individually, once this gets accepted. Mauro, Guennadi, are you fine with how this turned out? I'd like to get your acks again, for the changed location. From my side, there's nothing on such code that is V4L2 specific. Moving it to drivers/of makes sense on my eyes. Acked-by: Mauro Carvalho Chehab m.che...@samsung.com I'll need those acks before I can even think about queuing up the imx-drm bits. Another way to deal with this is if this gets pulled into the V4L tree from Philipp's git tree, I can also pull that in myself. What mustn't happen is for these to be committed independently as patches. If everyone agrees, I actually prefer have this patch applied on my tree, in order to avoid some potential merge conflicts at the merge window, as we might have other drivers and changes there touching on those API calls (I'm aware of a series of patches from Sylwester with some DT stuff on it. Not sure if it would be affected by such changes or not). -- Cheers, Mauro -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 0/8] Move device tree graph parsing helpers to drivers/of
On Wed, Mar 05, 2014 at 10:20:34AM +0100, Philipp Zabel wrote: this version of the OF graph helper move series further addresses a few of Tomi's and Sylwester's comments. Philipp, You mention in your other cover for imx-drm bits that this is available via: git://git.pengutronix.de/git/pza/linux.git topic/of-graph What is this tree based upon? -- FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly improving, and getting towards what was expected from it. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 0/8] Move device tree graph parsing helpers to drivers/of
Am Donnerstag, den 06.03.2014, 15:24 + schrieb Russell King - ARM Linux: On Wed, Mar 05, 2014 at 10:20:34AM +0100, Philipp Zabel wrote: this version of the OF graph helper move series further addresses a few of Tomi's and Sylwester's comments. Philipp, You mention in your other cover for imx-drm bits that this is available via: git://git.pengutronix.de/git/pza/linux.git topic/of-graph What is this tree based upon? It is based on v3.14-rc5. regards Philipp -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 0/8] Move device tree graph parsing helpers to drivers/of
On 06/03/14 16:17, Mauro Carvalho Chehab wrote: Em Thu, 06 Mar 2014 14:16:57 + Russell King - ARM Linux li...@arm.linux.org.uk escreveu: On Wed, Mar 05, 2014 at 03:42:34PM +0100, Philipp Zabel wrote: Am Mittwoch, den 05.03.2014, 13:35 +0200 schrieb Tomi Valkeinen: Hi, On 05/03/14 11:20, Philipp Zabel wrote: Hi, this version of the OF graph helper move series further addresses a few of Tomi's and Sylwester's comments. Changes since v5: - Fixed spelling errors and a wrong device node name in the link section - Added parentless previous endpoint's full name to warning - Fixed documentation comment for of_graph_parse_endpoint - Unrolled for-loop in of_graph_get_remote_port_parent Philipp Zabel (8): [media] of: move graph helpers from drivers/media/v4l2-core to drivers/of Documentation: of: Document graph bindings of: Warn if of_graph_get_next_endpoint is called with the root node of: Reduce indentation in of_graph_get_next_endpoint [media] of: move common endpoint parsing to drivers/of of: Implement simplified graph binding for single port devices of: Document simplified graph binding for single port devices of: Warn if of_graph_parse_endpoint is called with the root node So, as I've pointed out, I don't agree with the API, as it's too limited and I can't use it, but as this series is (mostly) about moving the current API to a common place, it's fine for me. Acked-by: Tomi Valkeinen tomi.valkei...@ti.com Thanks. I'll be happy to help expanding the API to parse ports individually, once this gets accepted. Mauro, Guennadi, are you fine with how this turned out? I'd like to get your acks again, for the changed location. From my side, there's nothing on such code that is V4L2 specific. Moving it to drivers/of makes sense on my eyes. Acked-by: Mauro Carvalho Chehab m.che...@samsung.com I'm OK with patches 1...5, 8, so for these: Acked-by: Sylwester Nawrocki s.nawro...@samsung.com Regarding the simplified version of the binding, I thought we should leave 'port' instead of 'endpoint' node. This could cover more hardware configurations. Are there any users of this simplified binding queued for v3.15 ? If not, perhaps we can postpone it and discuss it a bit more (sorry, couldn't find time to comment on that earlier) ? I'll need those acks before I can even think about queuing up the imx-drm bits. Another way to deal with this is if this gets pulled into the V4L tree from Philipp's git tree, I can also pull that in myself. What mustn't happen is for these to be committed independently as patches. If everyone agrees, I actually prefer have this patch applied on my tree, in order to avoid some potential merge conflicts at the merge window, as we might have other drivers and changes there touching on those API calls (I'm aware of a series of patches from Sylwester with some DT stuff on it. Not sure if it would be affected by such changes or not). Yes, it's going to conflict with my patch series. I thought it could be put onto a stable a topic branch, e.g. at git://linuxtv.org/media_tree.git, which could be then pulled into the media master branch and anywhere else it is needed ? -- Regards, Sylwester -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 0/8] Move device tree graph parsing helpers to drivers/of
On Thu, Mar 06, 2014 at 04:39:39PM +0100, Philipp Zabel wrote: Am Donnerstag, den 06.03.2014, 15:24 + schrieb Russell King - ARM Linux: On Wed, Mar 05, 2014 at 10:20:34AM +0100, Philipp Zabel wrote: this version of the OF graph helper move series further addresses a few of Tomi's and Sylwester's comments. Philipp, You mention in your other cover for imx-drm bits that this is available via: git://git.pengutronix.de/git/pza/linux.git topic/of-graph What is this tree based upon? It is based on v3.14-rc5. Great. As everyone seems happy, can you both send me and Mauro a pull request for this please? Once Mauro says it's in his tree, I'll pull it in for imx-drm stuff. Thanks. -- FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly improving, and getting towards what was expected from it. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 0/8] Move device tree graph parsing helpers to drivers/of
Am Donnerstag, den 06.03.2014, 16:47 +0100 schrieb Sylwester Nawrocki: On 06/03/14 16:17, Mauro Carvalho Chehab wrote: Em Thu, 06 Mar 2014 14:16:57 + Russell King - ARM Linux li...@arm.linux.org.uk escreveu: On Wed, Mar 05, 2014 at 03:42:34PM +0100, Philipp Zabel wrote: Am Mittwoch, den 05.03.2014, 13:35 +0200 schrieb Tomi Valkeinen: [...] So, as I've pointed out, I don't agree with the API, as it's too limited and I can't use it, but as this series is (mostly) about moving the current API to a common place, it's fine for me. Acked-by: Tomi Valkeinen tomi.valkei...@ti.com Thanks. I'll be happy to help expanding the API to parse ports individually, once this gets accepted. Mauro, Guennadi, are you fine with how this turned out? I'd like to get your acks again, for the changed location. From my side, there's nothing on such code that is V4L2 specific. Moving it to drivers/of makes sense on my eyes. Acked-by: Mauro Carvalho Chehab m.che...@samsung.com I'm OK with patches 1...5, 8, so for these: Acked-by: Sylwester Nawrocki s.nawro...@samsung.com Regarding the simplified version of the binding, I thought we should leave 'port' instead of 'endpoint' node. This could cover more hardware configurations. Are there any users of this simplified binding queued for v3.15 ? If not, perhaps we can postpone it and discuss it a bit more (sorry, couldn't find time to comment on that earlier) ? Since Tomi needs the separate port/endpoint iteration anyway, postponing the simple bindings shouldn't hurt. I'll (re)submit them together in a second series. I'll need those acks before I can even think about queuing up the imx-drm bits. Another way to deal with this is if this gets pulled into the V4L tree from Philipp's git tree, I can also pull that in myself. What mustn't happen is for these to be committed independently as patches. If everyone agrees, I actually prefer have this patch applied on my tree, in order to avoid some potential merge conflicts at the merge window, as we might have other drivers and changes there touching on those API calls (I'm aware of a series of patches from Sylwester with some DT stuff on it. Not sure if it would be affected by such changes or not). Yes, it's going to conflict with my patch series. I thought it could be put onto a stable a topic branch, e.g. at git://linuxtv.org/media_tree.git, which could be then pulled into the media master branch and anywhere else it is needed ? Mauro, are you ok with handling the conflict in the merge, or should I rebase on top of the media tree after you merged Sylwester's changes? regards Philipp -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 0/8] Move device tree graph parsing helpers to drivers/of
Am Donnerstag, den 06.03.2014, 17:32 +0100 schrieb Sylwester Nawrocki: On 06/03/14 17:21, Philipp Zabel wrote: Am Donnerstag, den 06.03.2014, 16:47 +0100 schrieb Sylwester Nawrocki: Yes, it's going to conflict with my patch series. I thought it could be put onto a stable a topic branch, e.g. at git://linuxtv.org/media_tree.git, which could be then pulled into the media master branch and anywhere else it is needed ? Mauro, are you ok with handling the conflict in the merge, or should I rebase on top of the media tree after you merged Sylwester's changes? I could rebase and resolve any conflicts before sending my pull request to Mauro. I don't think it's a good idea to rebase this series onto the media tree, since it is touching drivers/of. Excellent, thanks. I will send a pull request to Mauro and Russell shortly. regards Philipp -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 0/8] Move device tree graph parsing helpers to drivers/of
Hi Philipp, Thank you for the patches. On Thursday 06 March 2014 16:47:24 Sylwester Nawrocki wrote: On 06/03/14 16:17, Mauro Carvalho Chehab wrote: Em Thu, 06 Mar 2014 14:16:57 + Russell King - ARM Linux escreveu: On Wed, Mar 05, 2014 at 03:42:34PM +0100, Philipp Zabel wrote: Am Mittwoch, den 05.03.2014, 13:35 +0200 schrieb Tomi Valkeinen: On 05/03/14 11:20, Philipp Zabel wrote: Hi, this version of the OF graph helper move series further addresses a few of Tomi's and Sylwester's comments. Changes since v5: - Fixed spelling errors and a wrong device node name in the link section - Added parentless previous endpoint's full name to warning - Fixed documentation comment for of_graph_parse_endpoint - Unrolled for-loop in of_graph_get_remote_port_parent Philipp Zabel (8): [media] of: move graph helpers from drivers/media/v4l2-core to drivers/of Documentation: of: Document graph bindings of: Warn if of_graph_get_next_endpoint is called with the root node of: Reduce indentation in of_graph_get_next_endpoint [media] of: move common endpoint parsing to drivers/of of: Implement simplified graph binding for single port devices of: Document simplified graph binding for single port devices of: Warn if of_graph_parse_endpoint is called with the root node So, as I've pointed out, I don't agree with the API, as it's too limited and I can't use it, but as this series is (mostly) about moving the current API to a common place, it's fine for me. Acked-by: Tomi Valkeinen tomi.valkei...@ti.com Thanks. I'll be happy to help expanding the API to parse ports individually, once this gets accepted. Mauro, Guennadi, are you fine with how this turned out? I'd like to get your acks again, for the changed location. From my side, there's nothing on such code that is V4L2 specific. Moving it to drivers/of makes sense on my eyes. Acked-by: Mauro Carvalho Chehab m.che...@samsung.com I'm OK with patches 1...5, 8, so for these: Acked-by: Sylwester Nawrocki s.nawro...@samsung.com For what it's worth given that you've sent a pull request already, for the same patches, Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v6 0/8] Move device tree graph parsing helpers to drivers/of
Hi, this version of the OF graph helper move series further addresses a few of Tomi's and Sylwester's comments. Changes since v5: - Fixed spelling errors and a wrong device node name in the link section - Added parentless previous endpoint's full name to warning - Fixed documentation comment for of_graph_parse_endpoint - Unrolled for-loop in of_graph_get_remote_port_parent Philipp Zabel (8): [media] of: move graph helpers from drivers/media/v4l2-core to drivers/of Documentation: of: Document graph bindings of: Warn if of_graph_get_next_endpoint is called with the root node of: Reduce indentation in of_graph_get_next_endpoint [media] of: move common endpoint parsing to drivers/of of: Implement simplified graph binding for single port devices of: Document simplified graph binding for single port devices of: Warn if of_graph_parse_endpoint is called with the root node Documentation/devicetree/bindings/graph.txt | 137 + drivers/media/i2c/adv7343.c | 4 +- drivers/media/i2c/mt9p031.c | 4 +- drivers/media/i2c/s5k5baf.c | 3 +- drivers/media/i2c/tvp514x.c | 3 +- drivers/media/i2c/tvp7002.c | 3 +- drivers/media/platform/exynos4-is/fimc-is.c | 6 +- drivers/media/platform/exynos4-is/media-dev.c | 13 +- drivers/media/platform/exynos4-is/mipi-csis.c | 5 +- drivers/media/v4l2-core/v4l2-of.c | 133 +--- drivers/of/base.c | 167 ++ include/linux/of_graph.h | 66 ++ include/media/v4l2-of.h | 33 + 13 files changed, 399 insertions(+), 178 deletions(-) create mode 100644 Documentation/devicetree/bindings/graph.txt create mode 100644 include/linux/of_graph.h -- 1.9.0.rc3 -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 0/8] Move device tree graph parsing helpers to drivers/of
Hi, On 05/03/14 11:20, Philipp Zabel wrote: Hi, this version of the OF graph helper move series further addresses a few of Tomi's and Sylwester's comments. Changes since v5: - Fixed spelling errors and a wrong device node name in the link section - Added parentless previous endpoint's full name to warning - Fixed documentation comment for of_graph_parse_endpoint - Unrolled for-loop in of_graph_get_remote_port_parent Philipp Zabel (8): [media] of: move graph helpers from drivers/media/v4l2-core to drivers/of Documentation: of: Document graph bindings of: Warn if of_graph_get_next_endpoint is called with the root node of: Reduce indentation in of_graph_get_next_endpoint [media] of: move common endpoint parsing to drivers/of of: Implement simplified graph binding for single port devices of: Document simplified graph binding for single port devices of: Warn if of_graph_parse_endpoint is called with the root node So, as I've pointed out, I don't agree with the API, as it's too limited and I can't use it, but as this series is (mostly) about moving the current API to a common place, it's fine for me. Acked-by: Tomi Valkeinen tomi.valkei...@ti.com Tomi signature.asc Description: OpenPGP digital signature
Re: [PATCH v6 0/8] Move device tree graph parsing helpers to drivers/of
Hi Tomi, Am Mittwoch, den 05.03.2014, 13:35 +0200 schrieb Tomi Valkeinen: Hi, On 05/03/14 11:20, Philipp Zabel wrote: Hi, this version of the OF graph helper move series further addresses a few of Tomi's and Sylwester's comments. Changes since v5: - Fixed spelling errors and a wrong device node name in the link section - Added parentless previous endpoint's full name to warning - Fixed documentation comment for of_graph_parse_endpoint - Unrolled for-loop in of_graph_get_remote_port_parent Philipp Zabel (8): [media] of: move graph helpers from drivers/media/v4l2-core to drivers/of Documentation: of: Document graph bindings of: Warn if of_graph_get_next_endpoint is called with the root node of: Reduce indentation in of_graph_get_next_endpoint [media] of: move common endpoint parsing to drivers/of of: Implement simplified graph binding for single port devices of: Document simplified graph binding for single port devices of: Warn if of_graph_parse_endpoint is called with the root node So, as I've pointed out, I don't agree with the API, as it's too limited and I can't use it, but as this series is (mostly) about moving the current API to a common place, it's fine for me. Acked-by: Tomi Valkeinen tomi.valkei...@ti.com Thanks. I'll be happy to help expanding the API to parse ports individually, once this gets accepted. Mauro, Guennadi, are you fine with how this turned out? I'd like to get your acks again, for the changed location. regards Philipp -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
