Re: next build: 9 warnings 0 failures (next/next-20170215)

[Hans Verkuil]

On 02/15/2017 09:39 AM, Arnd Bergmann wrote:
> On Wed, Feb 15, 2017 at 9:30 AM, Hans Verkuil  wrote:
>> On 02/15/2017 09:24 AM, Arnd Bergmann wrote:
>>> On Wed, Feb 15, 2017 at 9:02 AM, Olof's autobuilder  wrote:
> 
   1 drivers/media/platform/coda/imx-vdoa.c:333:571: warning: passing 
 argument 1 of 'platform_driver_unregister' discards 'const' qualifier from 
 pointer target type [-Wdiscarded-qualifiers]
   1 drivers/media/platform/coda/imx-vdoa.c:333:625: warning: passing 
 argument 1 of 'platform_driver_unregister' discards 'const' qualifier from 
 pointer target type [-Wdiscarded-qualifiers]
   1 drivers/usb/gadget/udc/atmel_usba_udc.c:636:38: warning: 'ept_cfg' 
 may be used uninitialized in this function [-Wmaybe-uninitialized]
   2 drivers/media/platform/coda/imx-vdoa.c:333:181: warning: passing 
 argument 1 of '__platform_driver_register' discards 'const' qualifier from 
 pointer target type [-Wdiscarded-qualifiers]
>>>
>>> This was "[media] coda/imx-vdoa: platform_driver should not be const",
>>> https://patchwork.linuxtv.org/patch/39288/ Hans already marked this as
>>> 'merged', so I assume it's on its way in, but just hasn't appeared in
>>> linux-next as of today.
>>
>> It's part of a pull request for 4.12 for Mauro to pick up. If this should
>> go into 4.10 or 4.11, then Greg should take this particular patch. Mauro is 
>> moving
>> to a new house this week and won't have time (or quite possibly even network
>> connectivity).
> 
> Ok, good to know, thanks for your quick reply. I checked the commit
> that caused the
> warning, d2fe28feaebb ("[media] coda/imx-vdoa: constify structs"), and
> it is currently
> part of git://linuxtv.org/media_tree.git#master . My fix should go on
> top of this branch
> and picked up by whoever is going to send it during the merge window.
> As I'm reverting
> half of Mauro's patch, we can't merge it through any other tree at the moment.

OK, we'll take care of this in that case.

I hope I'll remember this :-)

Regards,

Hans

Re: next build: 9 warnings 0 failures (next/next-20170215)

[Arnd Bergmann]

On Wed, Feb 15, 2017 at 9:30 AM, Hans Verkuil  wrote:
> On 02/15/2017 09:24 AM, Arnd Bergmann wrote:
>> On Wed, Feb 15, 2017 at 9:02 AM, Olof's autobuilder  wrote:

>>>   1 drivers/media/platform/coda/imx-vdoa.c:333:571: warning: passing 
>>> argument 1 of 'platform_driver_unregister' discards 'const' qualifier from 
>>> pointer target type [-Wdiscarded-qualifiers]
>>>   1 drivers/media/platform/coda/imx-vdoa.c:333:625: warning: passing 
>>> argument 1 of 'platform_driver_unregister' discards 'const' qualifier from 
>>> pointer target type [-Wdiscarded-qualifiers]
>>>   1 drivers/usb/gadget/udc/atmel_usba_udc.c:636:38: warning: 'ept_cfg' 
>>> may be used uninitialized in this function [-Wmaybe-uninitialized]
>>>   2 drivers/media/platform/coda/imx-vdoa.c:333:181: warning: passing 
>>> argument 1 of '__platform_driver_register' discards 'const' qualifier from 
>>> pointer target type [-Wdiscarded-qualifiers]
>>
>> This was "[media] coda/imx-vdoa: platform_driver should not be const",
>> https://patchwork.linuxtv.org/patch/39288/ Hans already marked this as
>> 'merged', so I assume it's on its way in, but just hasn't appeared in
>> linux-next as of today.
>
> It's part of a pull request for 4.12 for Mauro to pick up. If this should
> go into 4.10 or 4.11, then Greg should take this particular patch. Mauro is 
> moving
> to a new house this week and won't have time (or quite possibly even network
> connectivity).

Ok, good to know, thanks for your quick reply. I checked the commit
that caused the
warning, d2fe28feaebb ("[media] coda/imx-vdoa: constify structs"), and
it is currently
part of git://linuxtv.org/media_tree.git#master . My fix should go on
top of this branch
and picked up by whoever is going to send it during the merge window.
As I'm reverting
half of Mauro's patch, we can't merge it through any other tree at the moment.

 Arnd

Re: next build: 9 warnings 0 failures (next/next-20170215)

[Hans Verkuil]

On 02/15/2017 09:24 AM, Arnd Bergmann wrote:
> On Wed, Feb 15, 2017 at 9:02 AM, Olof's autobuilder  wrote:
>> Here are the build results from automated periodic testing.
> 
>>
>> Warnings:   9
> 
> It seems we're closing in on zero again, with just two build regressions
> against 4.10 in linux-next. I did patches for both, and they made it into
> maintainer trees but not yet into linux-next
> 
>> Warnings:
>>
>>   1 drivers/iio/adc/rcar-gyroadc.c:398:26: warning: 'adcmode' may be 
>> used uninitialized in this function [-Wmaybe-uninitialized]
>>   1 drivers/iio/adc/rcar-gyroadc.c:426:22: warning: 'sample_width' may 
>> be used uninitialized in this function [-Wmaybe-uninitialized]
>>   1 drivers/iio/adc/rcar-gyroadc.c:428:23: warning: 'channels' may be 
>> used uninitialized in this function [-Wmaybe-uninitialized]
>>   1 drivers/iio/adc/rcar-gyroadc.c:429:27: warning: 'num_channels' may 
>> be used uninitialized in this function [-Wmaybe-uninitialized]
> 
> This was "iio: adc: handle unknow of_device_id data",
> http://lkml.iu.edu/hypermail/linux/kernel/1702.0/02707.html
> 
> Jonathan applied it into 'fixes-togreg-post-rc1', which is probably
> enough, though I'd expect that Greg would take it earlier as it
> addresses a (harmless) regression in -next.
> 
>>   1 drivers/media/platform/coda/imx-vdoa.c:333:571: warning: passing 
>> argument 1 of 'platform_driver_unregister' discards 'const' qualifier from 
>> pointer target type [-Wdiscarded-qualifiers]
>>   1 drivers/media/platform/coda/imx-vdoa.c:333:625: warning: passing 
>> argument 1 of 'platform_driver_unregister' discards 'const' qualifier from 
>> pointer target type [-Wdiscarded-qualifiers]
>>   1 drivers/usb/gadget/udc/atmel_usba_udc.c:636:38: warning: 'ept_cfg' 
>> may be used uninitialized in this function [-Wmaybe-uninitialized]
>>   2 drivers/media/platform/coda/imx-vdoa.c:333:181: warning: passing 
>> argument 1 of '__platform_driver_register' discards 'const' qualifier from 
>> pointer target type [-Wdiscarded-qualifiers]
> 
> This was "[media] coda/imx-vdoa: platform_driver should not be const",
> https://patchwork.linuxtv.org/patch/39288/ Hans already marked this as
> 'merged', so I assume it's on its way in, but just hasn't appeared in
> linux-next as of today.

It's part of a pull request for 4.12 for Mauro to pick up. If this should
go into 4.10 or 4.11, then Greg should take this particular patch. Mauro is 
moving
to a new house this week and won't have time (or quite possibly even network
connectivity).

Regards,

Hans

Re: next build: 9 warnings 0 failures (next/next-20170215)

[Arnd Bergmann]

On Wed, Feb 15, 2017 at 9:02 AM, Olof's autobuilder  wrote:
> Here are the build results from automated periodic testing.

>
> Warnings:   9

It seems we're closing in on zero again, with just two build regressions
against 4.10 in linux-next. I did patches for both, and they made it into
maintainer trees but not yet into linux-next

> Warnings:
>
>   1 drivers/iio/adc/rcar-gyroadc.c:398:26: warning: 'adcmode' may be used 
> uninitialized in this function [-Wmaybe-uninitialized]
>   1 drivers/iio/adc/rcar-gyroadc.c:426:22: warning: 'sample_width' may be 
> used uninitialized in this function [-Wmaybe-uninitialized]
>   1 drivers/iio/adc/rcar-gyroadc.c:428:23: warning: 'channels' may be 
> used uninitialized in this function [-Wmaybe-uninitialized]
>   1 drivers/iio/adc/rcar-gyroadc.c:429:27: warning: 'num_channels' may be 
> used uninitialized in this function [-Wmaybe-uninitialized]

This was "iio: adc: handle unknow of_device_id data",
http://lkml.iu.edu/hypermail/linux/kernel/1702.0/02707.html

Jonathan applied it into 'fixes-togreg-post-rc1', which is probably
enough, though I'd expect that Greg would take it earlier as it
addresses a (harmless) regression in -next.

>   1 drivers/media/platform/coda/imx-vdoa.c:333:571: warning: passing 
> argument 1 of 'platform_driver_unregister' discards 'const' qualifier from 
> pointer target type [-Wdiscarded-qualifiers]
>   1 drivers/media/platform/coda/imx-vdoa.c:333:625: warning: passing 
> argument 1 of 'platform_driver_unregister' discards 'const' qualifier from 
> pointer target type [-Wdiscarded-qualifiers]
>   1 drivers/usb/gadget/udc/atmel_usba_udc.c:636:38: warning: 'ept_cfg' 
> may be used uninitialized in this function [-Wmaybe-uninitialized]
>   2 drivers/media/platform/coda/imx-vdoa.c:333:181: warning: passing 
> argument 1 of '__platform_driver_register' discards 'const' qualifier from 
> pointer target type [-Wdiscarded-qualifiers]

This was "[media] coda/imx-vdoa: platform_driver should not be const",
https://patchwork.linuxtv.org/patch/39288/ Hans already marked this as
'merged', so I assume it's on its way in, but just hasn't appeared in
linux-next as of today.

I think there were a couple of other new build warnings in the
kernelci builder, I'll have another look when today's linux-next build
results come in from there.

Arnd