Re: [PATCH v2 2/3] hwrng: OMAP3 ROM Random Number Generator support
On Tuesday 19 November 2013 03:14:09 Herbert Xu wrote: On Mon, Nov 18, 2013 at 10:51:30PM +0100, Pali Rohár wrote: On Wednesday 16 October 2013 14:57:34 Herbert Xu wrote: On Tue, Oct 08, 2013 at 12:04:09PM -0700, Tony Lindgren wrote: * Pali Rohár pali.ro...@gmail.com [130920 06:33]: This driver provides kernel-side support for the Random Number Generator hardware found on OMAP34xx processors. This driver comes from Maemo 2.6.28 kernel and was tested on Nokia RX-51. It is platform device because it needs board specific function for smc calls. This one is should be merged via the hw_random patches seprately: Acked-by: Tony Lindgren t...@atomide.com Patch applied. Thanks! Hello, I still do not see this patch (2/3) in linus tree. But patch 1/3 and 3/3 are already merged. So is there any problem? 2/3 is still in my tree so when Linus pulls it it'll be there. Cheers, Now 3.13-rc1 is out [1], but your tree was not merged. Can you try to ping Linus what happened? [1] - https://lkml.org/lkml/2013/11/22/439 -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.
Re: [PATCH v2 2/3] hwrng: OMAP3 ROM Random Number Generator support
On Sat, Nov 23, 2013 at 10:37:13AM +0100, Pali Rohár wrote: Now 3.13-rc1 is out, but your tree was not merged. Can you try to ping Linus what happened? See here: http://www.spinics.net/lists/arm-kernel/msg288508.html -- Sebastian signature.asc Description: Digital signature
Re: [PATCH 5/8] ARM: OMAP2+: timer: Introduce OF-friendly clocksource/clockevent system timers
On Fri, Nov 22, 2013 at 7:12 PM, Joel Fernandes jo...@ti.com wrote: Adding Thomas to the thread since discussion is about clocksource, and Mark Rutland as discussion is related to timers and DT, thanks. On 11/22/2013 02:01 PM, Rob Herring wrote: On Fri, Nov 22, 2013 at 10:42 AM, Joel Fernandes jo...@ti.com wrote: On 11/22/2013 09:58 AM, Rob Herring wrote: On Thu, Nov 21, 2013 at 7:56 PM, Joel Fernandes jo...@ti.com wrote: This work is a migration effort of OMAP system timers to the clocksource/clockevent framework. Consider this as a first-pass in this effort. There are few cleanups that need to be done first. The HWMOD code is intertwined with the timer code. HWMOD code cleanups in the future will hopefully make most of this code go away, so till then we separate out the power/clocks portion of the code from the actual timer bits. This will facilitate near-future work of adapting the system timer as a clocksource. New functions for OF-only boot are introduced, and we can soon delete the old versions once we migrate all platforms. Currently only AM335x is migrated and testedA new omap_generic_timer_init function is introduced for DT platforms. Code required earlier for non-DT platforms such as setup of timer IDs and timer parent clock is not required. parent clocks are automatically setup by the mux clock driver through DT so they no longer need to be hardcoded. The init code will try to pick the best timer for clocksource and clockevent however bindings are added to force a particular timer as clocksource or clockevent through DT. Signed-off-by: Joel Fernandes jo...@ti.com --- .../devicetree/bindings/arm/omap/timer.txt | 12 ++ arch/arm/mach-omap2/common.h | 1 + arch/arm/mach-omap2/timer.c| 235 + 3 files changed, 248 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/omap/timer.txt b/Documentation/devicetree/bindings/arm/omap/timer.txt index d02e27c..6cf7a75 100644 --- a/Documentation/devicetree/bindings/arm/omap/timer.txt +++ b/Documentation/devicetree/bindings/arm/omap/timer.txt @@ -32,6 +32,18 @@ Optional properties: - ti,timer-secure: Indicates the timer is reserved on a secure OMAP device and therefore cannot be used by the kernel. +- ti,timer-clockevent, + ti,timer-clocksource These properties force the system timer code to choose + the particular timer as a clockevent or clocksource. + If these properties are not specified, the timer code + picks up a ti,timer-alwon as the clocksource and a + timer containing one of the following properties as + the clockevent in the following order: + ti,timer-alwon + ti,timer-dsp + ti,timer-pwm + ti,timer-secure These properties were added specifically for the reason of avoiding linux specific properties like these. When is this not sufficient? Some platforms cannot use certain timers as clockevents and clocksource, to keep this code functionally equivalent and working, I added these properties so that its possible to select specific timers as clockevents/sources as was being done in the non-DT case. I'm open to suggestions for doing this in a better way for DT. There has to be a defined reason why a given timer cannot be used. You are not explaining what that reason is. Define a property or set of properties that describe the h/w feature or quirk. Reason? There are HW bugs that prevent a timer from being used. See [1]. And there may be other reasons, I haven't written this code but I know that there are other HW bugs that made authors pick a specific timer such as board issues or accuracy. Bugs are a feature of the h/w. Add a ti,timer-broken property if you don't know the specific bug. Accuracy is a function of counter bit size and frequency. The only board issues for a timer I can imagine is you want to reserve timers with output compare or input capture pins for other uses. These are all properties that you can describe in the binding. If you just don't want to use a timer for some arbitrary reason, then add a 'status = disabled;' property. This is nothing new, just that I'm trying to find a way to do it from DT. You can see the ifdef'ry below in mach-omap2/timer.c. All I'm trying to do is make it simpler and cleaner by adding these properties to DT so that we can delete this code entirely. #ifdef CONFIG_ARCH_OMAP2 OMAP_SYS_32K_TIMER_INIT(2, 1, timer_32k_ck, ti,timer-alwon, 2, timer_sys_ck, NULL); #endif /* CONFIG_ARCH_OMAP2 */ #if defined(CONFIG_ARCH_OMAP3) || defined(CONFIG_SOC_AM43XX) OMAP_SYS_32K_TIMER_INIT(3, 1, timer_32k_ck, ti,timer-alwon,
Re: [rtc-linux] Re: [PATCH v4 0/4] pm: Add power off control
On Fri, Nov 22, 2013 at 2:50 PM, Ezequiel Garcia ezequiel.gar...@free-electrons.com wrote: [...] And why specifically *2* seconds, instead of *1* or *33* ? Sounds a bit like voodoo magic on this side :-) Consider the scenario where the actual time is 00:00:01.95 secs. Due to the 1 second resolution of the RTC, reading the registers would return 00:00:01. By the time we get to updating the RTC register for the shutdown by adding 1 sec (theoretically the smallest delta) we could end up programming the time that's already passed and in such cases the system will never shut down. 2 secs is the smallest delay that we can use to get the system to shutdown reliably. So it's not voodoo magic after all ;) Regards, Vaibhav -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 3/5] DTS: ARM: OMAP3-N900: Add reset gpio to lcd node
This adds reset-gpio property to the Nokia N900's lcd node. Signed-off-by: Sebastian Reichel s...@debian.org --- arch/arm/boot/dts/omap3-n900.dts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts index 6ad5ae9..ac725e0 100644 --- a/arch/arm/boot/dts/omap3-n900.dts +++ b/arch/arm/boot/dts/omap3-n900.dts @@ -585,6 +585,9 @@ spi-max-frequency = 600; reg = 2; + label = lcd; + reset-gpio = gpio3 26 GPIO_ACTIVE_HIGH; /* 90 */ + pinctrl-names = default; pinctrl-0 = display_pins; }; -- 1.8.4.3 -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 2/5] DTS: ARM: OMAP3-N900: Add vendor prefixes to SPI devices
SPI attached devices are currently missing vendor
prefixes. This patch adds them.
Signed-off-by: Sebastian Reichel s...@debian.org
---
arch/arm/boot/dts/omap3-n900.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
index 3900f84..6ad5ae9 100644
--- a/arch/arm/boot/dts/omap3-n900.dts
+++ b/arch/arm/boot/dts/omap3-n900.dts
@@ -576,12 +576,12 @@
* Also... order in the device tree actually matters here.
*/
tsc2005@0 {
- compatible = tsc2005;
+ compatible = ti,tsc2005;
spi-max-frequency = 600;
reg = 0;
};
mipid@2 {
- compatible = acx565akm;
+ compatible = sony,acx565akm;
spi-max-frequency = 600;
reg = 2;
--
1.8.4.3
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 5/5] Documentation: dt: Document ACX565AKM DT binding
Add devicetree binding documentation for ACX565AKM panel.
Signed-off-by: Sebastian Reichel s...@debian.org
---
.../devicetree/bindings/video/sony,acx565akm.txt | 22 ++
1 file changed, 22 insertions(+)
create mode 100644 Documentation/devicetree/bindings/video/sony,acx565akm.txt
diff --git a/Documentation/devicetree/bindings/video/sony,acx565akm.txt
b/Documentation/devicetree/bindings/video/sony,acx565akm.txt
new file mode 100644
index 000..41f2284
--- /dev/null
+++ b/Documentation/devicetree/bindings/video/sony,acx565akm.txt
@@ -0,0 +1,22 @@
+Device-Tree bindings for Sony ACX565AKM panel driver
+
+Required properties:
+- compatible: value should be one among the following:
+ * sony,acx565akm
+- reg: integer, chip select id of the panel
+- spi-max-frequency: integer, maximal frequency of spi connection
+- label: string, label for the panel (e.g. lcd)
+- reset-gpio: phandle + gpio specifier for the reset gpio
+
+Example:
+
+mcspi1 {
+ mipid@2 {
+ compatible = sony,acx565akm;
+ spi-max-frequency = 600;
+ reg = 2;
+
+ label = lcd;
+ reset-gpio = gpio3 26 GPIO_ACTIVE_HIGH; /* gpio 90 */
+ };
+};
--
1.8.4.3
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/5] N900 DT support for N900 panel
Hi, This patchset adds DT support for the N900 panel. The panel bindings will be extended once omapdss has DT support. Until then the panel driver defaults to omapdss.sdi0 in DT mode. -- Sebastian Sebastian Reichel (5): OMAPDSS: ACX565AKM: Add basic DT support DTS: ARM: OMAP3-N900: Add vendor prefixes to SPI devices DTS: ARM: OMAP3-N900: Add reset gpio to lcd node OMAPDSS: SDI: Use V28 as regulator for N900 Documentation: dt: Document ACX565AKM DT binding .../devicetree/bindings/video/sony,acx565akm.txt | 22 arch/arm/boot/dts/omap3-n900.dts | 7 -- .../omap2/displays-new/panel-sony-acx565akm.c | 29 ++ drivers/video/omap2/dss/sdi.c | 8 +- 4 files changed, 63 insertions(+), 3 deletions(-) create mode 100644 Documentation/devicetree/bindings/video/sony,acx565akm.txt -- 1.8.4.3 -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 4/5] OMAPDSS: SDI: Use V28 as regulator for N900
This adds a Nokia N900 quirk, so that the V28
regulator is used for the omapdss.sdi port.
This quirk is needed until omapdss is converted
to DT, so that the regulator can be acquired via
a phandle.
On other boards the regulator can be renamed in
the DT data, but on the Nokia N900 the regulator
is also used for other hardware components.
Signed-off-by: Sebastian Reichel s...@debian.org
---
drivers/video/omap2/dss/sdi.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/video/omap2/dss/sdi.c b/drivers/video/omap2/dss/sdi.c
index ccc569a..ca8f102 100644
--- a/drivers/video/omap2/dss/sdi.c
+++ b/drivers/video/omap2/dss/sdi.c
@@ -26,6 +26,7 @@
#include linux/export.h
#include linux/platform_device.h
#include linux/string.h
+#include linux/of.h
#include video/omapdss.h
#include dss.h
@@ -263,7 +264,12 @@ static int sdi_init_regulator(void)
if (sdi.vdds_sdi_reg)
return 0;
- vdds_sdi = devm_regulator_get(sdi.pdev-dev, vdds_sdi);
+ /* TODO: remove this hack, once we acquire regulator via DT phandle */
+ if (of_machine_is_compatible(nokia,omap3-n900))
+ vdds_sdi = devm_regulator_get(sdi.pdev-dev, V28);
+ else
+ vdds_sdi = devm_regulator_get(sdi.pdev-dev, vdds_sdi);
+
if (IS_ERR(vdds_sdi)) {
DSSERR(can't get VDDS_SDI regulator\n);
return PTR_ERR(vdds_sdi);
--
1.8.4.3
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 1/5] OMAPDSS: ACX565AKM: Add basic DT support
This adds basic DT support to the ACX565AKM panel driver.
Signed-off-by: Sebastian Reichel s...@debian.org
---
.../omap2/displays-new/panel-sony-acx565akm.c | 29 ++
1 file changed, 29 insertions(+)
diff --git a/drivers/video/omap2/displays-new/panel-sony-acx565akm.c
b/drivers/video/omap2/displays-new/panel-sony-acx565akm.c
index e6d56f7..5d3fb9d 100644
--- a/drivers/video/omap2/displays-new/panel-sony-acx565akm.c
+++ b/drivers/video/omap2/displays-new/panel-sony-acx565akm.c
@@ -30,6 +30,8 @@
#include linux/backlight.h
#include linux/fb.h
#include linux/gpio.h
+#include linux/of.h
+#include linux/of_gpio.h
#include video/omapdss.h
#include video/omap-panel-data.h
@@ -711,6 +713,28 @@ static int acx565akm_probe_pdata(struct spi_device *spi)
return 0;
}
+static int acx565akm_probe_of(struct spi_device *spi)
+{
+ struct panel_drv_data *ddata = dev_get_drvdata(spi-dev);
+ struct device_node *np = spi-dev.of_node;
+ struct omap_dss_device *dssdev;
+ int ret;
+
+ ddata-reset_gpio = of_get_named_gpio(np, reset-gpio, 0);
+
+ /* TODO: there is currently no DT binding for omapdss, so
+* we use sdi.0 with 2 data lanes per default. */
+ ddata-in = omap_dss_find_output(sdi.0);
+ ddata-datapairs = 2;
+
+ dssdev = ddata-dssdev;
+ ret = of_property_read_string(np, label, dssdev-name);
+ if (ret 0)
+ return ret;
+
+ return 0;
+}
+
static int acx565akm_probe(struct spi_device *spi)
{
struct panel_drv_data *ddata;
@@ -738,7 +762,12 @@ static int acx565akm_probe(struct spi_device *spi)
r = acx565akm_probe_pdata(spi);
if (r)
return r;
+ } else if (spi-dev.of_node) {
+ r = acx565akm_probe_of(spi);
+ if (r)
+ return r;
} else {
+ dev_err(spi-dev, platform data missing!\n);
return -ENODEV;
}
--
1.8.4.3
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: N900 board code in 3.14
Hi,
On Fri, Nov 22, 2013 at 11:41:27AM +0100, Javier Martinez Canillas wrote:
I dropped that patch from my series and posted a v2 that just name the
VPLL2 regulator as vdds_dsi [1]. That way will be safer for Tony and
Benoit to take this series as a fix for the -rc cycle since the
changes are contained within IGEP boards DTS.
I know, but the patch serves as example for me :)
My suggestion would be to add something like this pseudocode to
omapdss:
if(board_is_n900_dt()) {
vdds_dsi = devm_regulator_get(dpi.pdev-dev, V28);
}
The problem is, that we do not want to name the regulator
vdds_dsi, since it's not used exclusivly for omapdss.
In the future it can get the regulator via phandle of course.
For what is worth I think that your suggestion is a good workaround.
Please just add a comment specifying that it is a hack and that we
have to get rid of these once the DSS DT bindings land on mainline and
we can use a phandle to get the regulator.
I just sent a patchset, that adds DT panel support for N900.
-- Sebastian
signature.asc
Description: Digital signature
[PATCH 1/2] ARM: dts: OMAP5: Add maintenance interrupt for virtualisation
Add a maintenance IRQ using PPI 9 to OMAP5 device tree needed for virtualisation. Cc: Marc Zyngier marc.zyng...@arm.com Cc: Christoffer Dall christoffer.d...@linaro.org Cc: Benoît Cousson bcous...@baylibre.com Cc: Tony Lindgren t...@atomide.com Signed-off-by: Santosh Shilimkar santosh.shilim...@ti.com --- arch/arm/boot/dts/omap5.dtsi |1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi index fc3fad5..c9f1ae4 100644 --- a/arch/arm/boot/dts/omap5.dtsi +++ b/arch/arm/boot/dts/omap5.dtsi @@ -74,6 +74,7 @@ 0x48212000 0x1000, 0x48214000 0x2000, 0x48216000 0x2000; + interrupts = 1 9 0x304; }; /* -- 1.7.9.5 -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/2] ARM: OMAP5: Couple of patches for KVM
Couple of patches for OMAP5 machines towards KVM support. Cc: Marc Zyngier marc.zyng...@arm.com Cc: Christoffer Dall christoffer.d...@linaro.org Cc: Tony Lindgren t...@atomide.com Santosh Shilimkar (2): ARM: dts: OMAP5: Add maintenance interrupt for virtualisation ARM: OMAP5: Add HYP mode entry support for secondary CPUs arch/arm/boot/dts/omap5.dtsi |1 + arch/arm/mach-omap2/omap-headsmp.S |7 +++ 2 files changed, 8 insertions(+) -- 1.7.9.5 -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 2/2] ARM: OMAP5: Add HYP mode entry support for secondary CPUs
Boot-CPU entry into the HYP mode is managed in boot-loader but the secondary CPUs directly jumps to kernel during boot. Same path is also used for CPU hotplug as well during suspend for secondary CPU. Hence patch the secondary CPU boot path for hyp mode etry. Cc: Marc Zyngier marc.zyng...@arm.com Cc: Christoffer Dall christoffer.d...@linaro.org Cc: Tony Lindgren t...@atomide.com Signed-off-by: Santosh Shilimkar santosh.shilim...@ti.com --- arch/arm/mach-omap2/omap-headsmp.S |7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/mach-omap2/omap-headsmp.S b/arch/arm/mach-omap2/omap-headsmp.S index 75e9295..4844dd8 100644 --- a/arch/arm/mach-omap2/omap-headsmp.S +++ b/arch/arm/mach-omap2/omap-headsmp.S @@ -22,6 +22,7 @@ /* Physical address needed since MMU not enabled yet on secondary core */ #define AUX_CORE_BOOT0_PA 0x48281800 +#define API_HYP_ENTRY 0x102 /* * OMAP5 specific entry point for secondary CPU to jump from ROM @@ -38,6 +39,12 @@ wait:ldr r2, =AUX_CORE_BOOT0_PA @ read from AuxCoreBoot0 and r4, r4, #0x0f cmp r0, r4 bne wait +#ifdef CONFIG_KVM_ARM_HOST + ldr r12, =API_HYP_ENTRY + adr r0, hyp_boot + smc #0 +hyp_boot: +#endif b secondary_startup END(omap5_secondary_startup) /* -- 1.7.9.5 -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] ARM: dts: OMAP5: Add maintenance interrupt for virtualisation
On Saturday 23 November 2013 07:07 PM, Santosh Shilimkar wrote: Add a maintenance IRQ using PPI 9 to OMAP5 device tree needed for virtualisation. Cc: Marc Zyngier marc.zyng...@arm.com Cc: Christoffer Dall christoffer.d...@linaro.org Cc: Benoît Cousson bcous...@baylibre.com Cc: Tony Lindgren t...@atomide.com Signed-off-by: Santosh Shilimkar santosh.shilim...@ti.com --- arch/arm/boot/dts/omap5.dtsi |1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi index fc3fad5..c9f1ae4 100644 --- a/arch/arm/boot/dts/omap5.dtsi +++ b/arch/arm/boot/dts/omap5.dtsi @@ -74,6 +74,7 @@ 0x48212000 0x1000, 0x48214000 0x2000, 0x48216000 0x2000; + interrupts = 1 9 0x304; I should have used the GIC flags. Updated version end of the email. Regards, Santosh From 91cbd5f65ccd9a0780614fa7ab5505922bdce577 Mon Sep 17 00:00:00 2001 From: Santosh Shilimkar santosh.shilim...@ti.com Date: Thu, 12 Sep 2013 15:53:13 -0400 Subject: [PATCH 1/2] ARM: dts: OMAP5: Add maintenance interrupt for virtualisation Add a maintenance IRQ using PPI 9 to OMAP5 device tree needed for virtualisation. Cc: Marc Zyngier marc.zyng...@arm.com Cc: Christoffer Dall christoffer.d...@linaro.org Cc: Benoît Cousson bcous...@baylibre.com Cc: Tony Lindgren t...@atomide.com Signed-off-by: Santosh Shilimkar santosh.shilim...@ti.com --- arch/arm/boot/dts/omap5.dtsi |1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi index fc3fad5..907ab7b 100644 --- a/arch/arm/boot/dts/omap5.dtsi +++ b/arch/arm/boot/dts/omap5.dtsi @@ -74,6 +74,7 @@ 0x48212000 0x1000, 0x48214000 0x2000, 0x48216000 0x2000; + interrupts = GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_HIGH); }; /* -- 1.7.9.5 -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
