Re: [PATCH] ARM: OMAP1: fix compilation issue in board-sx1.c

2012-05-09 Thread Artem Bityutskiy 
On Tue, 2012-05-08 at 17:17 -0700, Tony Lindgren wrote:
 * Artem Bityutskiy dedeki...@gmail.com [120508 07:02]:
  From: Artem Bityutskiy artem.bityuts...@linux.intel.com
  
  SX1 board requirese i2c, so select it in Kconfig, otherwise I have the
  following build error:
 
 Thanks applying into fixes-non-critical as this seems to build
 with omap1_defconfig.

Right, because omap1_defconfig has i2c enabled. The build fails if I
disable it. But this is not critical to me at all.

-- 
Best Regards,
Artem Bityutskiy


signature.asc
Description: This is a digitally signed message part

[PATCH] ARM: OMAP1: fix compilation issue in board-sx1.c

2012-05-08 Thread Artem Bityutskiy 
From: Artem Bityutskiy artem.bityuts...@linux.intel.com

SX1 board requirese i2c, so select it in Kconfig, otherwise I have the
following build error:

arch/arm/mach-omap1/board-sx1.c: In function 'sx1_i2c_write_byte':
arch/arm/mach-omap1/board-sx1.c:58:2: error: implicit declaration of function 
'i2c_get_adapter' [-Werror=implicit-function-declaration]
arch/arm/mach-omap1/board-sx1.c:58:7: warning: assignment makes pointer from 
integer without a cast [enabled by default]
arch/arm/mach-omap1/board-sx1.c:67:2: error: implicit declaration of function 
'i2c_transfer' [-Werror=implicit-function-declaration]
arch/arm/mach-omap1/board-sx1.c:68:2: error: implicit declaration of function 
'i2c_put_adapter' [-Werror=implicit-function-declaration]
arch/arm/mach-omap1/board-sx1.c: In function 'sx1_i2c_read_byte':
arch/arm/mach-omap1/board-sx1.c:82:7: warning: assignment makes pointer from 
integer without a cast [enabled by default]
cc1: some warnings being treated as errors
make[1]: *** [arch/arm/mach-omap1/board-sx1.o] Error 1
make: *** [arch/arm/mach-omap1] Error 2
make: *** Waiting for unfinished jobs

Signed-off-by: Artem Bityutskiy artem.bityuts...@linux.intel.com
---
 arch/arm/mach-omap1/Kconfig |1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap1/Kconfig b/arch/arm/mach-omap1/Kconfig
index dfab466..cba3f71 100644
--- a/arch/arm/mach-omap1/Kconfig
+++ b/arch/arm/mach-omap1/Kconfig
@@ -132,6 +132,7 @@ config MACH_OMAP_PALMTT
 
 config MACH_SX1
bool Siemens SX1
+   select I2C
depends on ARCH_OMAP1  ARCH_OMAP15XX
help
  Support for the Siemens SX1 phone. To boot the kernel,
-- 
1.7.9.1

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: OMAP1: fix compilation issue in board-sx1.c

2012-05-08 Thread Tony Lindgren 
* Artem Bityutskiy dedeki...@gmail.com [120508 07:02]:
 From: Artem Bityutskiy artem.bityuts...@linux.intel.com
 
 SX1 board requirese i2c, so select it in Kconfig, otherwise I have the
 following build error:

Thanks applying into fixes-non-critical as this seems to build
with omap1_defconfig.

Tony
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html