Re: [PATCH] Fix build breakage in omap-usb-host.c
Hi Russ, On Sun, Apr 22, 2012 at 01:48:18AM -0700, Russ Dill wrote: 'ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue' removes the include for linux/gpio.h from omap-usb-host.c. This include indirectly includes plat/cpu.h which is required by omap-usb-host.c. Fix the build breakage by including it directly. Signed-off-by: Russ Dill russ.d...@ti.com Patch applied, thanks. I'm planning to send an MFD pull request including this fix to Linus, in time for rc6. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Fix build breakage in omap-usb-host.c
Hi Kevin, On Fri, Apr 27, 2012 at 01:36:28PM -0700, Kevin Hilman wrote: Samuel, Munegowda, Keshava keshava_mgo...@ti.com writes: On Sun, Apr 22, 2012 at 2:20 PM, Russ Dill russ.d...@ti.com wrote: On Sun, Apr 22, 2012 at 1:48 AM, Russ Dill russ.d...@ti.com wrote: 'ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue' removes the include for linux/gpio.h from omap-usb-host.c. This include indirectly includes plat/cpu.h which is required by omap-usb-host.c. Fix the build breakage by including it directly. (Sorry, I should add some detail, this is a build breakage in linux-next) Russ Dill and Anatolij Gustschin Both patches fixes the same issue; But here , I am seeing Russ Dill has sent earlier (in my mailbox it shows 21 hours ago) Here my ack by: Acked-by: Keshava Munegowda keshava_mgo...@ti.com Acked-by: Kevin Hilman khil...@ti.com Can you pick this up for v3.4-rc5? The breakage was introduced in v3.4-rc4. I will, yes. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Fix build breakage in omap-usb-host.c
On Sun, Apr 22, 2012 at 2:20 PM, Russ Dill russ.d...@ti.com wrote: On Sun, Apr 22, 2012 at 1:48 AM, Russ Dill russ.d...@ti.com wrote: 'ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue' removes the include for linux/gpio.h from omap-usb-host.c. This include indirectly includes plat/cpu.h which is required by omap-usb-host.c. Fix the build breakage by including it directly. (Sorry, I should add some detail, this is a build breakage in linux-next) Russ Dill and Anatolij Gustschin Both patches fixes the same issue; But here , I am seeing Russ Dill has sent earlier (in my mailbox it shows 21 hours ago) Here my ack by: Acked-by: Keshava Munegowda keshava_mgo...@ti.com Regards Keshava -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Fix build breakage in omap-usb-host.c
On Mon, 23 Apr 2012 11:55:49 +0530 Munegowda, Keshava keshava_mgo...@ti.com wrote: On Sun, Apr 22, 2012 at 2:20 PM, Russ Dill russ.d...@ti.com wrote: On Sun, Apr 22, 2012 at 1:48 AM, Russ Dill russ.d...@ti.com wrote: 'ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue' removes the include for linux/gpio.h from omap-usb-host.c. This include indirectly includes plat/cpu.h which is required by omap-usb-host.c. Fix the build breakage by including it directly. (Sorry, I should add some detail, this is a build breakage in linux-next) Russ Dill and Anatolij Gustschin Both patches fixes the same issue; But here , I am seeing Russ Dill has sent earlier (in my mailbox it shows 21 hours ago) Great! I'm not on linux-omap list and didn't see this patch unfortunately. Sure, the patch from Russ Dill should be applied. Thanks, Anatolij -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] Fix build breakage in omap-usb-host.c
'ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue' removes the include for linux/gpio.h from omap-usb-host.c. This include indirectly includes plat/cpu.h which is required by omap-usb-host.c. Fix the build breakage by including it directly. Signed-off-by: Russ Dill russ.d...@ti.com --- drivers/mfd/omap-usb-host.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c index c8aae66..7e96bb2 100644 --- a/drivers/mfd/omap-usb-host.c +++ b/drivers/mfd/omap-usb-host.c @@ -25,6 +25,7 @@ #include linux/clk.h #include linux/dma-mapping.h #include linux/spinlock.h +#include plat/cpu.h #include plat/usb.h #include linux/pm_runtime.h -- 1.7.9.5 -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Fix build breakage in omap-usb-host.c
On Sun, Apr 22, 2012 at 1:48 AM, Russ Dill russ.d...@ti.com wrote: 'ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue' removes the include for linux/gpio.h from omap-usb-host.c. This include indirectly includes plat/cpu.h which is required by omap-usb-host.c. Fix the build breakage by including it directly. (Sorry, I should add some detail, this is a build breakage in linux-next) -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
