Re: [PATCH 02/12] Fix possible stale smsc911x flags.

2012-03-27 Thread Igor Grinberg
On 03/23/12 11:21, Russ Dill wrote:
 If this function is called the first time with flags set, and the
 second time without flags set then the leftover flags from the first
 called will be used rather than the desired default flags.
 
 Signed-off-by: Russ Dill russ.d...@ti.com

Tested-by: Igor Grinberg grinb...@compulab.co.il


-- 
Regards,
Igor.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH 02/12] Fix possible stale smsc911x flags.

2012-03-23 Thread Russ Dill
If this function is called the first time with flags set, and the
second time without flags set then the leftover flags from the first
called will be used rather than the desired default flags.

Signed-off-by: Russ Dill russ.d...@ti.com
---
 arch/arm/mach-omap2/gpmc-smsc911x.c |4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mach-omap2/gpmc-smsc911x.c 
b/arch/arm/mach-omap2/gpmc-smsc911x.c
index aa0c296..f9446ea 100644
--- a/arch/arm/mach-omap2/gpmc-smsc911x.c
+++ b/arch/arm/mach-omap2/gpmc-smsc911x.c
@@ -39,7 +39,6 @@ static struct smsc911x_platform_config gpmc_smsc911x_config = 
{
.phy_interface  = PHY_INTERFACE_MODE_MII,
.irq_polarity   = SMSC911X_IRQ_POLARITY_ACTIVE_LOW,
.irq_type   = SMSC911X_IRQ_TYPE_OPEN_DRAIN,
-   .flags  = SMSC911X_USE_16BIT,
 };
 
 static struct regulator_consumer_supply gpmc_smsc911x_supply[] = {
@@ -135,8 +134,7 @@ void __init gpmc_smsc911x_init(struct 
omap_smsc911x_platform_data *gpmc_cfg)
gpio_set_value(gpmc_cfg-gpio_reset, 1);
}
 
-   if (gpmc_cfg-flags)
-   gpmc_smsc911x_config.flags = gpmc_cfg-flags;
+   gpmc_smsc911x_config.flags = gpmc_cfg-flags ? : SMSC911X_USE_16BIT;
 
pdev = platform_device_register_resndata(NULL, smsc911x, gpmc_cfg-id,
 gpmc_smsc911x_resources, ARRAY_SIZE(gpmc_smsc911x_resources),
-- 
1.7.9.1

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html