Re: [PATCH 1/3] OMAP: DSS2: Add generic DPI panel display driver

2010-11-17 Thread Tomi Valkeinen 
On Wed, 2010-11-17 at 10:23 +0800, ext Bryan Wu wrote:
 Generic DPI panel driver includes the driver and 4 similar panel 
 configurations. It
 will match the panel name which is passed from platform data and setup the
 right configurations.
 
 With generic DPI panel driver, we can remove those 4 duplicated panel display
 drivers. In the future, it is simple for us just add new panel configuration
 date in panel-generic-dpi.c to support new display panel.
 
 Signed-off-by: Bryan Wu bryan...@canonical.com
 ---
  .../arm/plat-omap/include/plat/panel-generic-dpi.h |   37 ++
  drivers/video/omap2/displays/Kconfig   |8 +
  drivers/video/omap2/displays/Makefile  |1 +
  drivers/video/omap2/displays/panel-generic-dpi.c   |  348 
 
  4 files changed, 394 insertions(+), 0 deletions(-)
  create mode 100644 arch/arm/plat-omap/include/plat/panel-generic-dpi.h
  create mode 100644 drivers/video/omap2/displays/panel-generic-dpi.c
 

snip

 +static int generic_dpi_panel_probe(struct omap_dss_device *dssdev)
 +{
 + struct panel_generic_dpi_data *panel_data = get_panel_data(dssdev);
 + struct panel_config *panel_config = NULL;
 + struct panel_drv_data *drv_data = NULL;
 + int i;
 +
 + dev_dbg(dssdev-dev, probe\n);
 +
 + if (!panel_data || !panel_data-name)
 + return -EINVAL;
 +
 + for (i = 0; i  ARRAY_SIZE(generic_dpi_panels); i++) {
 + if (strcmp(panel_data-name, generic_dpi_panels[i].name) == 0) {
 + panel_config = generic_dpi_panels[i];
 + break;
 + }
 + }
 +
 + if (!panel_config)
 + return -EINVAL;
 +
 + dssdev-panel.config = panel_config-config;
 + dssdev-panel.timings = panel_config-timings;
 + dssdev-panel.acb = panel_config-acb;
 + dssdev-panel.acbi = panel_config-acbi;
 +
 + drv_data = kzalloc(sizeof(*drv_data), GFP_KERNEL);
 + if (!drv_data)
 + return -ENOMEM;
 +
 + drv_data-dssdev = dssdev;
 + drv_data-panel_config = panel_config;
 +
 + dev_set_drvdata(dssdev-dev, drv_data);
 +
 + return 0;
 +}
 +
 +static void generic_dpi_panel_remove(struct omap_dss_device *dssdev)
 +{
 +}

You need to free the drv_data here.

Perhaps this will be the last fix =).

 Tomi


--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/3] OMAP: DSS2: Add generic DPI panel display driver

2010-11-17 Thread Bryan Wu 
Generic DPI panel driver includes the driver and 4 similar panel 
configurations. It
will match the panel name which is passed from platform data and setup the
right configurations.

With generic DPI panel driver, we can remove those 4 duplicated panel display
drivers. In the future, it is simple for us just add new panel configuration
date in panel-generic-dpi.c to support new display panel.

Signed-off-by: Bryan Wu bryan...@canonical.com
---
 .../arm/plat-omap/include/plat/panel-generic-dpi.h |   37 ++
 drivers/video/omap2/displays/Kconfig   |8 +
 drivers/video/omap2/displays/Makefile  |1 +
 drivers/video/omap2/displays/panel-generic-dpi.c   |  355 
 4 files changed, 401 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/plat-omap/include/plat/panel-generic-dpi.h
 create mode 100644 drivers/video/omap2/displays/panel-generic-dpi.c

diff --git a/arch/arm/plat-omap/include/plat/panel-generic-dpi.h 
b/arch/arm/plat-omap/include/plat/panel-generic-dpi.h
new file mode 100644
index 000..7906197
--- /dev/null
+++ b/arch/arm/plat-omap/include/plat/panel-generic-dpi.h
@@ -0,0 +1,37 @@
+/*
+ * Header for generic DPI panel driver
+ *
+ * Copyright (C) 2010 Canonical Ltd.
+ * Author: Bryan Wu bryan...@canonical.com
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 as published by
+ * the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program.  If not, see http://www.gnu.org/licenses/.
+ */
+
+#ifndef __ARCH_ARM_PLAT_OMAP_PANEL_GENERIC_DPI_H
+#define __ARCH_ARM_PLAT_OMAP_PANEL_GENERIC_DPI_H
+
+#include display.h
+
+/**
+ * struct panel_generic_dpi_data - panel driver configuration data
+ * @name: panel name
+ * @platform_enable: platform specific panel enable function
+ * @platform_disable: platform specific panel disable function
+ */
+struct panel_generic_dpi_data {
+   const char *name;
+   int (*platform_enable)(struct omap_dss_device *dssdev);
+   void (*platform_disable)(struct omap_dss_device *dssdev);
+};
+
+#endif /* __ARCH_ARM_PLAT_OMAP_PANEL_GENERIC_DPI_H */
diff --git a/drivers/video/omap2/displays/Kconfig 
b/drivers/video/omap2/displays/Kconfig
index 12327bb..cb3e339 100644
--- a/drivers/video/omap2/displays/Kconfig
+++ b/drivers/video/omap2/displays/Kconfig
@@ -1,6 +1,14 @@
 menu OMAP2/3 Display Device Drivers
 depends on OMAP2_DSS
 
+config PANEL_GENERIC_DPI
+tristate Generic DPI Panel
+help
+ Generic DPI panel driver.
+ Supports DVI output for Beagle and OMAP3 SDP.
+ Supports LCD Panel used in TI SDP3430 and EVM boards,
+ OMAP3517 EVM boards and CM-T35.
+
 config PANEL_GENERIC
 tristate Generic Panel
 help
diff --git a/drivers/video/omap2/displays/Makefile 
b/drivers/video/omap2/displays/Makefile
index aa38609..022058c 100644
--- a/drivers/video/omap2/displays/Makefile
+++ b/drivers/video/omap2/displays/Makefile
@@ -1,3 +1,4 @@
+obj-$(CONFIG_PANEL_GENERIC_DPI) += panel-generic-dpi.o
 obj-$(CONFIG_PANEL_GENERIC) += panel-generic.o
 obj-$(CONFIG_PANEL_SHARP_LS037V7DW01) += panel-sharp-ls037v7dw01.o
 obj-$(CONFIG_PANEL_SHARP_LQ043T1DG01) += panel-sharp-lq043t1dg01.o
diff --git a/drivers/video/omap2/displays/panel-generic-dpi.c 
b/drivers/video/omap2/displays/panel-generic-dpi.c
new file mode 100644
index 000..6702cf6
--- /dev/null
+++ b/drivers/video/omap2/displays/panel-generic-dpi.c
@@ -0,0 +1,355 @@
+/*
+ * Generic DPI Panels support
+ *
+ * Copyright (C) 2010 Canonical Ltd.
+ * Author: Bryan Wu bryan...@canonical.com
+ *
+ * Copyright (C) 2008 Nokia Corporation
+ * Author: Tomi Valkeinen tomi.valkei...@nokia.com
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 as published by
+ * the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program.  If not, see http://www.gnu.org/licenses/.
+ */
+
+#include linux/module.h
+#include linux/delay.h
+#include linux/slab.h
+
+#include plat/panel-generic-dpi.h
+
+struct panel_config {
+   struct omap_video_timings timings;
+
+   int acbi;   /* ac-bias pin transitions per interrupt */
+   /* Unit: line clocks */
+   int acb;/* ac-bias pin frequency */
+
+

Re: [PATCH 1/3] OMAP: DSS2: Add generic DPI panel display driver

2010-11-17 Thread Bryan Wu 
On Wed, Nov 17, 2010 at 8:44 PM, Tomi Valkeinen
tomi.valkei...@nokia.com wrote:
 On Wed, 2010-11-17 at 10:23 +0800, ext Bryan Wu wrote:
 Generic DPI panel driver includes the driver and 4 similar panel 
 configurations. It
 will match the panel name which is passed from platform data and setup the
 right configurations.

 With generic DPI panel driver, we can remove those 4 duplicated panel display
 drivers. In the future, it is simple for us just add new panel configuration
 date in panel-generic-dpi.c to support new display panel.

 Signed-off-by: Bryan Wu bryan...@canonical.com
 ---
  .../arm/plat-omap/include/plat/panel-generic-dpi.h |   37 ++
  drivers/video/omap2/displays/Kconfig               |    8 +
  drivers/video/omap2/displays/Makefile              |    1 +
  drivers/video/omap2/displays/panel-generic-dpi.c   |  348 
 
  4 files changed, 394 insertions(+), 0 deletions(-)
  create mode 100644 arch/arm/plat-omap/include/plat/panel-generic-dpi.h
  create mode 100644 drivers/video/omap2/displays/panel-generic-dpi.c


[snip]

 +
 +static void generic_dpi_panel_remove(struct omap_dss_device *dssdev)
 +{
 +}

 You need to free the drv_data here.

 Perhaps this will be the last fix =).


My bad, I just sent out the 8th version for review. Moreover, I think
in panel-taal.c it also misses call dev_set_drvdata(dssdev-dev,
NULL); after we kfree(td) in taal_remove().

Thanks,
-- 
Bryan Wu bryan...@canonical.com
Kernel Developer    +86.138-1617-6545 Mobile
Ubuntu Kernel Team
Canonical Ltd.      www.canonical.com
Ubuntu - Linux for human beings | www.ubuntu.com
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 1/3] OMAP: DSS2: Add generic DPI panel display driver

2010-11-17 Thread Premi, Sanjeev 
 -Original Message-
 From: linux-omap-ow...@vger.kernel.org 
 [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Bryan Wu
 Sent: Wednesday, November 17, 2010 7:05 PM
 To: tomi.valkei...@nokia.com; linux-omap@vger.kernel.org; 
 linux-arm-ker...@lists.infradead.org; Gadiyar, Anand
 Subject: [PATCH 1/3] OMAP: DSS2: Add generic DPI panel display driver
 
 Generic DPI panel driver includes the driver and 4 similar 
 panel configurations. It
 will match the panel name which is passed from platform data 
 and setup the
 right configurations.
 
 With generic DPI panel driver, we can remove those 4 
 duplicated panel display
 drivers. In the future, it is simple for us just add new 
 panel configuration
 date in panel-generic-dpi.c to support new display panel.
 
 Signed-off-by: Bryan Wu bryan...@canonical.com
 ---
  .../arm/plat-omap/include/plat/panel-generic-dpi.h |   37 ++
  drivers/video/omap2/displays/Kconfig   |8 +
  drivers/video/omap2/displays/Makefile  |1 +
  drivers/video/omap2/displays/panel-generic-dpi.c   |  355 
 
  4 files changed, 401 insertions(+), 0 deletions(-)
  create mode 100644 
 arch/arm/plat-omap/include/plat/panel-generic-dpi.h
  create mode 100644 drivers/video/omap2/displays/panel-generic-dpi.c
 
 diff --git 
 a/arch/arm/plat-omap/include/plat/panel-generic-dpi.h 
 b/arch/arm/plat-omap/include/plat/panel-generic-dpi.h
 new file mode 100644
 index 000..7906197
 --- /dev/null
 +++ b/arch/arm/plat-omap/include/plat/panel-generic-dpi.h
 @@ -0,0 +1,37 @@
 +/*
 + * Header for generic DPI panel driver
 + *
 + * Copyright (C) 2010 Canonical Ltd.
 + * Author: Bryan Wu bryan...@canonical.com
 + *
 + * This program is free software; you can redistribute it 
 and/or modify it
 + * under the terms of the GNU General Public License version 
 2 as published by
 + * the Free Software Foundation.
 + *
 + * This program is distributed in the hope that it will be 
 useful, but WITHOUT
 + * ANY WARRANTY; without even the implied warranty of 
 MERCHANTABILITY or
 + * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General 
 Public License for
 + * more details.
 + *
 + * You should have received a copy of the GNU General Public 
 License along with
 + * this program.  If not, see http://www.gnu.org/licenses/.
 + */
 +
 +#ifndef __ARCH_ARM_PLAT_OMAP_PANEL_GENERIC_DPI_H
 +#define __ARCH_ARM_PLAT_OMAP_PANEL_GENERIC_DPI_H
 +
 +#include display.h
 +
 +/**
 + * struct panel_generic_dpi_data - panel driver configuration data
 + * @name: panel name
 + * @platform_enable: platform specific panel enable function
 + * @platform_disable: platform specific panel disable function
 + */
 +struct panel_generic_dpi_data {
 + const char *name;
 + int (*platform_enable)(struct omap_dss_device *dssdev);
 + void (*platform_disable)(struct omap_dss_device *dssdev);
 +};
 +
 +#endif /* __ARCH_ARM_PLAT_OMAP_PANEL_GENERIC_DPI_H */
 diff --git a/drivers/video/omap2/displays/Kconfig 
 b/drivers/video/omap2/displays/Kconfig
 index 12327bb..cb3e339 100644
 --- a/drivers/video/omap2/displays/Kconfig
 +++ b/drivers/video/omap2/displays/Kconfig
 @@ -1,6 +1,14 @@
  menu OMAP2/3 Display Device Drivers
  depends on OMAP2_DSS
  
 +config PANEL_GENERIC_DPI
 +tristate Generic DPI Panel
 +help
 +   Generic DPI panel driver.
 +   Supports DVI output for Beagle and OMAP3 SDP.
 +   Supports LCD Panel used in TI SDP3430 and EVM boards,
 +   OMAP3517 EVM boards and CM-T35.
 +
  config PANEL_GENERIC
  tristate Generic Panel
  help
 diff --git a/drivers/video/omap2/displays/Makefile 
 b/drivers/video/omap2/displays/Makefile
 index aa38609..022058c 100644
 --- a/drivers/video/omap2/displays/Makefile
 +++ b/drivers/video/omap2/displays/Makefile
 @@ -1,3 +1,4 @@
 +obj-$(CONFIG_PANEL_GENERIC_DPI) += panel-generic-dpi.o
  obj-$(CONFIG_PANEL_GENERIC) += panel-generic.o
  obj-$(CONFIG_PANEL_SHARP_LS037V7DW01) += panel-sharp-ls037v7dw01.o
  obj-$(CONFIG_PANEL_SHARP_LQ043T1DG01) += panel-sharp-lq043t1dg01.o
 diff --git a/drivers/video/omap2/displays/panel-generic-dpi.c 
 b/drivers/video/omap2/displays/panel-generic-dpi.c
 new file mode 100644
 index 000..6702cf6
 --- /dev/null
 +++ b/drivers/video/omap2/displays/panel-generic-dpi.c
 @@ -0,0 +1,355 @@
 +/*
 + * Generic DPI Panels support
 + *
 + * Copyright (C) 2010 Canonical Ltd.
 + * Author: Bryan Wu bryan...@canonical.com
 + *
 + * Copyright (C) 2008 Nokia Corporation
 + * Author: Tomi Valkeinen tomi.valkei...@nokia.com
 + *

[sp] Shouldn't all authors (from the files being coalesced) be
 listed here.

 I see this missing from PATCH3/3 in your series:

[quote]
- * LCD panel driver for Sharp LQ043T1DG01
- *
- * Copyright (C) 2009 Texas Instruments Inc
- * Author: Vaibhav Hiremath hvaib...@ti.com
- *
[/quote]


[snip]...[snip]

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo

Re: [PATCH 1/3] OMAP: DSS2: Add generic DPI panel display driver

2010-11-17 Thread Bryan Wu 
On Thu, Nov 18, 2010 at 12:13 AM, Premi, Sanjeev pr...@ti.com wrote:
 -Original Message-
 From: linux-omap-ow...@vger.kernel.org
 [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Bryan Wu
 Sent: Wednesday, November 17, 2010 7:05 PM
 To: tomi.valkei...@nokia.com; linux-omap@vger.kernel.org;
 linux-arm-ker...@lists.infradead.org; Gadiyar, Anand
 Subject: [PATCH 1/3] OMAP: DSS2: Add generic DPI panel display driver

 Generic DPI panel driver includes the driver and 4 similar
 panel configurations. It
 will match the panel name which is passed from platform data
 and setup the
 right configurations.

 With generic DPI panel driver, we can remove those 4
 duplicated panel display
 drivers. In the future, it is simple for us just add new
 panel configuration
 date in panel-generic-dpi.c to support new display panel.

 Signed-off-by: Bryan Wu bryan...@canonical.com
 ---
  .../arm/plat-omap/include/plat/panel-generic-dpi.h |   37 ++
  drivers/video/omap2/displays/Kconfig               |    8 +
  drivers/video/omap2/displays/Makefile              |    1 +
  drivers/video/omap2/displays/panel-generic-dpi.c   |  355
 
  4 files changed, 401 insertions(+), 0 deletions(-)
  create mode 100644
 arch/arm/plat-omap/include/plat/panel-generic-dpi.h
  create mode 100644 drivers/video/omap2/displays/panel-generic-dpi.c

 diff --git
 a/arch/arm/plat-omap/include/plat/panel-generic-dpi.h
 b/arch/arm/plat-omap/include/plat/panel-generic-dpi.h
 new file mode 100644
 index 000..7906197
 --- /dev/null
 +++ b/arch/arm/plat-omap/include/plat/panel-generic-dpi.h
 @@ -0,0 +1,37 @@
 +/*
 + * Header for generic DPI panel driver
 + *
 + * Copyright (C) 2010 Canonical Ltd.
 + * Author: Bryan Wu bryan...@canonical.com
 + *
 + * This program is free software; you can redistribute it
 and/or modify it
 + * under the terms of the GNU General Public License version
 2 as published by
 + * the Free Software Foundation.
 + *
 + * This program is distributed in the hope that it will be
 useful, but WITHOUT
 + * ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or
 + * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General
 Public License for
 + * more details.
 + *
 + * You should have received a copy of the GNU General Public
 License along with
 + * this program.  If not, see http://www.gnu.org/licenses/.
 + */
 +
 +#ifndef __ARCH_ARM_PLAT_OMAP_PANEL_GENERIC_DPI_H
 +#define __ARCH_ARM_PLAT_OMAP_PANEL_GENERIC_DPI_H
 +
 +#include display.h
 +
 +/**
 + * struct panel_generic_dpi_data - panel driver configuration data
 + * @name: panel name
 + * @platform_enable: platform specific panel enable function
 + * @platform_disable: platform specific panel disable function
 + */
 +struct panel_generic_dpi_data {
 +     const char *name;
 +     int (*platform_enable)(struct omap_dss_device *dssdev);
 +     void (*platform_disable)(struct omap_dss_device *dssdev);
 +};
 +
 +#endif /* __ARCH_ARM_PLAT_OMAP_PANEL_GENERIC_DPI_H */
 diff --git a/drivers/video/omap2/displays/Kconfig
 b/drivers/video/omap2/displays/Kconfig
 index 12327bb..cb3e339 100644
 --- a/drivers/video/omap2/displays/Kconfig
 +++ b/drivers/video/omap2/displays/Kconfig
 @@ -1,6 +1,14 @@
  menu OMAP2/3 Display Device Drivers
          depends on OMAP2_DSS

 +config PANEL_GENERIC_DPI
 +        tristate Generic DPI Panel
 +        help
 +       Generic DPI panel driver.
 +       Supports DVI output for Beagle and OMAP3 SDP.
 +       Supports LCD Panel used in TI SDP3430 and EVM boards,
 +       OMAP3517 EVM boards and CM-T35.
 +
  config PANEL_GENERIC
          tristate Generic Panel
          help
 diff --git a/drivers/video/omap2/displays/Makefile
 b/drivers/video/omap2/displays/Makefile
 index aa38609..022058c 100644
 --- a/drivers/video/omap2/displays/Makefile
 +++ b/drivers/video/omap2/displays/Makefile
 @@ -1,3 +1,4 @@
 +obj-$(CONFIG_PANEL_GENERIC_DPI) += panel-generic-dpi.o
  obj-$(CONFIG_PANEL_GENERIC) += panel-generic.o
  obj-$(CONFIG_PANEL_SHARP_LS037V7DW01) += panel-sharp-ls037v7dw01.o
  obj-$(CONFIG_PANEL_SHARP_LQ043T1DG01) += panel-sharp-lq043t1dg01.o
 diff --git a/drivers/video/omap2/displays/panel-generic-dpi.c
 b/drivers/video/omap2/displays/panel-generic-dpi.c
 new file mode 100644
 index 000..6702cf6
 --- /dev/null
 +++ b/drivers/video/omap2/displays/panel-generic-dpi.c
 @@ -0,0 +1,355 @@
 +/*
 + * Generic DPI Panels support
 + *
 + * Copyright (C) 2010 Canonical Ltd.
 + * Author: Bryan Wu bryan...@canonical.com
 + *
 + * Copyright (C) 2008 Nokia Corporation
 + * Author: Tomi Valkeinen tomi.valkei...@nokia.com
 + *

 [sp] Shouldn't all authors (from the files being coalesced) be
     listed here.


No problem, I will provide an incremental patch for Tomi.

-Bryan

     I see this missing from PATCH3/3 in your series:

 [quote]
 - * LCD panel driver for Sharp LQ043T1DG01
 - *
 - * Copyright (C) 2009 Texas Instruments Inc
 - * Author: Vaibhav Hiremath hvaib...@ti.com
 - *
 [/quote]


 [snip]...[snip]


--
To unsubscribe

Re: [PATCH 1/3] OMAP: DSS2: Add generic DPI panel display driver

2010-11-16 Thread Tomi Valkeinen 
Hi,

On Tue, 2010-11-16 at 05:17 +0100, ext Bryan Wu wrote:
 Generic DPI panel driver includes the driver and 4 similar panel 
 configurations. It
 will match the panel name which is passed from platform data and setup the
 right configurations.
 
 With generic DPI panel driver, we can remove those 4 duplicated panel display
 drivers. In the future, it is simple for us just add new panel configuration
 date in panel-generic-dpi.c to support new display panel.
 
 Signed-off-by: Bryan Wu bryan...@canonical.com
 ---
  .../arm/plat-omap/include/plat/panel-generic-dpi.h |   37 +++
  drivers/video/omap2/displays/Kconfig   |8 +
  drivers/video/omap2/displays/Makefile  |1 +
  drivers/video/omap2/displays/panel-generic-dpi.c   |  333 
 
  4 files changed, 379 insertions(+), 0 deletions(-)
  create mode 100644 arch/arm/plat-omap/include/plat/panel-generic-dpi.h
  create mode 100644 drivers/video/omap2/displays/panel-generic-dpi.c
 
 diff --git a/arch/arm/plat-omap/include/plat/panel-generic-dpi.h 
 b/arch/arm/plat-omap/include/plat/panel-generic-dpi.h
 new file mode 100644
 index 000..7906197
 --- /dev/null
 +++ b/arch/arm/plat-omap/include/plat/panel-generic-dpi.h
 @@ -0,0 +1,37 @@
 +/*
 + * Header for generic DPI panel driver
 + *
 + * Copyright (C) 2010 Canonical Ltd.
 + * Author: Bryan Wu bryan...@canonical.com
 + *
 + * This program is free software; you can redistribute it and/or modify it
 + * under the terms of the GNU General Public License version 2 as published 
 by
 + * the Free Software Foundation.
 + *
 + * This program is distributed in the hope that it will be useful, but 
 WITHOUT
 + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 + * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
 + * more details.
 + *
 + * You should have received a copy of the GNU General Public License along 
 with
 + * this program.  If not, see http://www.gnu.org/licenses/.
 + */
 +
 +#ifndef __ARCH_ARM_PLAT_OMAP_PANEL_GENERIC_DPI_H
 +#define __ARCH_ARM_PLAT_OMAP_PANEL_GENERIC_DPI_H
 +
 +#include display.h
 +
 +/**
 + * struct panel_generic_dpi_data - panel driver configuration data
 + * @name: panel name
 + * @platform_enable: platform specific panel enable function
 + * @platform_disable: platform specific panel disable function
 + */
 +struct panel_generic_dpi_data {
 + const char *name;
 + int (*platform_enable)(struct omap_dss_device *dssdev);
 + void (*platform_disable)(struct omap_dss_device *dssdev);
 +};
 +
 +#endif /* __ARCH_ARM_PLAT_OMAP_PANEL_GENERIC_DPI_H */
 diff --git a/drivers/video/omap2/displays/Kconfig 
 b/drivers/video/omap2/displays/Kconfig
 index 12327bb..cb3e339 100644
 --- a/drivers/video/omap2/displays/Kconfig
 +++ b/drivers/video/omap2/displays/Kconfig
 @@ -1,6 +1,14 @@
  menu OMAP2/3 Display Device Drivers
  depends on OMAP2_DSS
  
 +config PANEL_GENERIC_DPI
 +tristate Generic DPI Panel
 +help
 +   Generic DPI panel driver.
 +   Supports DVI output for Beagle and OMAP3 SDP.
 +   Supports LCD Panel used in TI SDP3430 and EVM boards,
 +   OMAP3517 EVM boards and CM-T35.
 +
  config PANEL_GENERIC
  tristate Generic Panel
  help
 diff --git a/drivers/video/omap2/displays/Makefile 
 b/drivers/video/omap2/displays/Makefile
 index aa38609..022058c 100644
 --- a/drivers/video/omap2/displays/Makefile
 +++ b/drivers/video/omap2/displays/Makefile
 @@ -1,3 +1,4 @@
 +obj-$(CONFIG_PANEL_GENERIC_DPI) += panel-generic-dpi.o
  obj-$(CONFIG_PANEL_GENERIC) += panel-generic.o
  obj-$(CONFIG_PANEL_SHARP_LS037V7DW01) += panel-sharp-ls037v7dw01.o
  obj-$(CONFIG_PANEL_SHARP_LQ043T1DG01) += panel-sharp-lq043t1dg01.o
 diff --git a/drivers/video/omap2/displays/panel-generic-dpi.c 
 b/drivers/video/omap2/displays/panel-generic-dpi.c
 new file mode 100644
 index 000..c3fff9e
 --- /dev/null
 +++ b/drivers/video/omap2/displays/panel-generic-dpi.c
 @@ -0,0 +1,333 @@
 +/*
 + * Generic DPI Panels support
 + *
 + * Copyright (C) 2010 Canonical Ltd.
 + * Author: Bryan Wu bryan...@canonical.com
 + *
 + * Copyright (C) 2008 Nokia Corporation
 + * Author: Tomi Valkeinen tomi.valkei...@nokia.com
 + *
 + * This program is free software; you can redistribute it and/or modify it
 + * under the terms of the GNU General Public License version 2 as published 
 by
 + * the Free Software Foundation.
 + *
 + * This program is distributed in the hope that it will be useful, but 
 WITHOUT
 + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 + * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
 + * more details.
 + *
 + * You should have received a copy of the GNU General Public License along 
 with
 + * this program.  If not, see http://www.gnu.org/licenses/.
 + */
 +
 +#include linux/module.h
 +#include linux/delay.h
 +
 +#include plat/panel-generic-dpi.h
 +
 +struct panel_config {
 + struct omap_video_timings timings;

[PATCH 1/3] OMAP: DSS2: Add generic DPI panel display driver

2010-11-16 Thread Bryan Wu 
Generic DPI panel driver includes the driver and 4 similar panel 
configurations. It
will match the panel name which is passed from platform data and setup the
right configurations.

With generic DPI panel driver, we can remove those 4 duplicated panel display
drivers. In the future, it is simple for us just add new panel configuration
date in panel-generic-dpi.c to support new display panel.

Signed-off-by: Bryan Wu bryan...@canonical.com
---
 .../arm/plat-omap/include/plat/panel-generic-dpi.h |   37 ++
 drivers/video/omap2/displays/Kconfig   |8 +
 drivers/video/omap2/displays/Makefile  |1 +
 drivers/video/omap2/displays/panel-generic-dpi.c   |  348 
 4 files changed, 394 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/plat-omap/include/plat/panel-generic-dpi.h
 create mode 100644 drivers/video/omap2/displays/panel-generic-dpi.c

diff --git a/arch/arm/plat-omap/include/plat/panel-generic-dpi.h 
b/arch/arm/plat-omap/include/plat/panel-generic-dpi.h
new file mode 100644
index 000..7906197
--- /dev/null
+++ b/arch/arm/plat-omap/include/plat/panel-generic-dpi.h
@@ -0,0 +1,37 @@
+/*
+ * Header for generic DPI panel driver
+ *
+ * Copyright (C) 2010 Canonical Ltd.
+ * Author: Bryan Wu bryan...@canonical.com
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 as published by
+ * the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program.  If not, see http://www.gnu.org/licenses/.
+ */
+
+#ifndef __ARCH_ARM_PLAT_OMAP_PANEL_GENERIC_DPI_H
+#define __ARCH_ARM_PLAT_OMAP_PANEL_GENERIC_DPI_H
+
+#include display.h
+
+/**
+ * struct panel_generic_dpi_data - panel driver configuration data
+ * @name: panel name
+ * @platform_enable: platform specific panel enable function
+ * @platform_disable: platform specific panel disable function
+ */
+struct panel_generic_dpi_data {
+   const char *name;
+   int (*platform_enable)(struct omap_dss_device *dssdev);
+   void (*platform_disable)(struct omap_dss_device *dssdev);
+};
+
+#endif /* __ARCH_ARM_PLAT_OMAP_PANEL_GENERIC_DPI_H */
diff --git a/drivers/video/omap2/displays/Kconfig 
b/drivers/video/omap2/displays/Kconfig
index 12327bb..cb3e339 100644
--- a/drivers/video/omap2/displays/Kconfig
+++ b/drivers/video/omap2/displays/Kconfig
@@ -1,6 +1,14 @@
 menu OMAP2/3 Display Device Drivers
 depends on OMAP2_DSS
 
+config PANEL_GENERIC_DPI
+tristate Generic DPI Panel
+help
+ Generic DPI panel driver.
+ Supports DVI output for Beagle and OMAP3 SDP.
+ Supports LCD Panel used in TI SDP3430 and EVM boards,
+ OMAP3517 EVM boards and CM-T35.
+
 config PANEL_GENERIC
 tristate Generic Panel
 help
diff --git a/drivers/video/omap2/displays/Makefile 
b/drivers/video/omap2/displays/Makefile
index aa38609..022058c 100644
--- a/drivers/video/omap2/displays/Makefile
+++ b/drivers/video/omap2/displays/Makefile
@@ -1,3 +1,4 @@
+obj-$(CONFIG_PANEL_GENERIC_DPI) += panel-generic-dpi.o
 obj-$(CONFIG_PANEL_GENERIC) += panel-generic.o
 obj-$(CONFIG_PANEL_SHARP_LS037V7DW01) += panel-sharp-ls037v7dw01.o
 obj-$(CONFIG_PANEL_SHARP_LQ043T1DG01) += panel-sharp-lq043t1dg01.o
diff --git a/drivers/video/omap2/displays/panel-generic-dpi.c 
b/drivers/video/omap2/displays/panel-generic-dpi.c
new file mode 100644
index 000..1f208e3
--- /dev/null
+++ b/drivers/video/omap2/displays/panel-generic-dpi.c
@@ -0,0 +1,348 @@
+/*
+ * Generic DPI Panels support
+ *
+ * Copyright (C) 2010 Canonical Ltd.
+ * Author: Bryan Wu bryan...@canonical.com
+ *
+ * Copyright (C) 2008 Nokia Corporation
+ * Author: Tomi Valkeinen tomi.valkei...@nokia.com
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 as published by
+ * the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program.  If not, see http://www.gnu.org/licenses/.
+ */
+
+#include linux/module.h
+#include linux/delay.h
+#include linux/slab.h
+
+#include plat/panel-generic-dpi.h
+
+struct panel_config {
+   struct omap_video_timings timings;
+
+   int acbi;   /* ac-bias pin transitions per interrupt */
+   /* Unit: line clocks */
+   int acb;/* ac-bias pin frequency */
+
+

Re: [PATCH 1/3] OMAP: DSS2: Add generic DPI panel display driver

2010-11-16 Thread Bryan Wu 
On Tue, Nov 16, 2010 at 11:21 PM, Tomi Valkeinen
tomi.valkei...@nokia.com wrote:
 Hi,

 On Tue, 2010-11-16 at 05:17 +0100, ext Bryan Wu wrote:
 Generic DPI panel driver includes the driver and 4 similar panel 
 configurations. It
 will match the panel name which is passed from platform data and setup the
 right configurations.

 With generic DPI panel driver, we can remove those 4 duplicated panel display
 drivers. In the future, it is simple for us just add new panel configuration
 date in panel-generic-dpi.c to support new display panel.

 Signed-off-by: Bryan Wu bryan...@canonical.com
 ---
  .../arm/plat-omap/include/plat/panel-generic-dpi.h |   37 +++

[snip]

 +
 +static power_on_delay = 0;
 +
 +static power_off_delay = 0;

 This is not right. There may be multiple panels in a single board, and
 these would be shared by both of the panels.

 What you need to do is have a struct, which contains pointer to the
 panel configuration used with that particular dssdev, and set the struct
 with dev_set_drvdata().

 Check panel-taal.c for an example. There's struct taal_data, which
 contains also quite a bit other data, but also a pointer to the panel
 config.


Exactly, I just fixed it and sent the updated patchset.

Thanks,
-- 
Bryan Wu bryan...@canonical.com
Kernel Developer    +86.138-1617-6545 Mobile
Ubuntu Kernel Team
Canonical Ltd.      www.canonical.com
Ubuntu - Linux for human beings | www.ubuntu.com
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 1/3] OMAP: DSS2: Add generic DPI panel display driver

2010-11-15 Thread Taneja, Archit 
Hi,

Bryan Wu wrote:
 On Mon, Nov 15, 2010 at 12:05 PM, Taneja, Archit
 arc...@ti.com wrote:
 Hi,
 
 bryan...@canonical.com wrote:
 On Wed, Nov 10, 2010 at 10:35 PM, Tomi Valkeinen
 
 [snip]
 
 
 For both panel power on and off some panels require some sleep times:
 when powering on, the video interface has to be enabled for some
 time before the panel can be enabled, and similarly when powering
 off the video interface needs to be on for some time after the panel has
 been disabled. 
 
 
 Actually, in my previous version patches, I introduced
 .power_on_delay and .power_off_delay in panel_configs, which contains
 the sleep value for msleep(). But Archit told me this is not
 necessary, so I removed that.
 
 I had asked you to remove it from omap_dss_device to a more specific
 struct for the generic dpi driver :)
 
 
 Yeah, no problem.
 
 It should be in the 'panel_generic_dpi_data' struct now.
 
 
 I think the delay value is related to panel, which can be
 found in sharp_ls and sharp_lq drivers. So it might be in the panel_configs
 struct?

Yes, I think that makes more sense.

Thanks,
Archit--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] OMAP: DSS2: Add generic DPI panel display driver

2010-11-15 Thread Tomi Valkeinen 
On Sun, 2010-11-14 at 02:42 +0100, ext Bryan Wu wrote:
 On Wed, Nov 10, 2010 at 10:35 PM, Tomi Valkeinen
 tomi.valkei...@nokia.com wrote:
  Hi,
 
  On Tue, 2010-11-09 at 18:12 +0100, ext Bryan Wu wrote:
  Generic DPI panel driver includes the driver and 4 similar panel 
  configurations. It
  will match the panel name which is passed from platform data and setup the
  right configurations.
 
  With generic DPI panel driver, we can remove those 4 duplicated panel 
  display
  drivers. In the future, it is simple for us just add new panel 
  configuration
  date in panel-generic-dpi.c to support new display panel.
 
  This is looking good, but still a couple of comments inline:
 

snip

  I think otherwise the patches look good. At some point we should add
  backlight support also, so that we can remove a few drivers more (and
  get rid of the extra backlight stuff in omap_dss_device struct).
 
 
 Yeah, I plan to do that. But IMHO, how about just move those backlight
 support as backlight drivers and only remain display control in this
 directory.

Hmm, yes, perhaps that would work for these DPI panels.

The reason I originally put the backlight driver inside the panel driver
is that there are many panels for which the backlight is a part of the
panel, in the sense that the backlight is controlled by sending messages
to the panel. For these the backlight needs to be somewhat integrated
into the panel driver.

 Tomi


--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/3] OMAP: DSS2: Add generic DPI panel display driver

2010-11-15 Thread Bryan Wu 
Generic DPI panel driver includes the driver and 4 similar panel 
configurations. It
will match the panel name which is passed from platform data and setup the
right configurations.

With generic DPI panel driver, we can remove those 4 duplicated panel display
drivers. In the future, it is simple for us just add new panel configuration
date in panel-generic-dpi.c to support new display panel.

Signed-off-by: Bryan Wu bryan...@canonical.com
---
 .../arm/plat-omap/include/plat/panel-generic-dpi.h |   37 +++
 drivers/video/omap2/displays/Kconfig   |8 +
 drivers/video/omap2/displays/Makefile  |1 +
 drivers/video/omap2/displays/panel-generic-dpi.c   |  333 
 4 files changed, 379 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/plat-omap/include/plat/panel-generic-dpi.h
 create mode 100644 drivers/video/omap2/displays/panel-generic-dpi.c

diff --git a/arch/arm/plat-omap/include/plat/panel-generic-dpi.h 
b/arch/arm/plat-omap/include/plat/panel-generic-dpi.h
new file mode 100644
index 000..7906197
--- /dev/null
+++ b/arch/arm/plat-omap/include/plat/panel-generic-dpi.h
@@ -0,0 +1,37 @@
+/*
+ * Header for generic DPI panel driver
+ *
+ * Copyright (C) 2010 Canonical Ltd.
+ * Author: Bryan Wu bryan...@canonical.com
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 as published by
+ * the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program.  If not, see http://www.gnu.org/licenses/.
+ */
+
+#ifndef __ARCH_ARM_PLAT_OMAP_PANEL_GENERIC_DPI_H
+#define __ARCH_ARM_PLAT_OMAP_PANEL_GENERIC_DPI_H
+
+#include display.h
+
+/**
+ * struct panel_generic_dpi_data - panel driver configuration data
+ * @name: panel name
+ * @platform_enable: platform specific panel enable function
+ * @platform_disable: platform specific panel disable function
+ */
+struct panel_generic_dpi_data {
+   const char *name;
+   int (*platform_enable)(struct omap_dss_device *dssdev);
+   void (*platform_disable)(struct omap_dss_device *dssdev);
+};
+
+#endif /* __ARCH_ARM_PLAT_OMAP_PANEL_GENERIC_DPI_H */
diff --git a/drivers/video/omap2/displays/Kconfig 
b/drivers/video/omap2/displays/Kconfig
index 12327bb..cb3e339 100644
--- a/drivers/video/omap2/displays/Kconfig
+++ b/drivers/video/omap2/displays/Kconfig
@@ -1,6 +1,14 @@
 menu OMAP2/3 Display Device Drivers
 depends on OMAP2_DSS
 
+config PANEL_GENERIC_DPI
+tristate Generic DPI Panel
+help
+ Generic DPI panel driver.
+ Supports DVI output for Beagle and OMAP3 SDP.
+ Supports LCD Panel used in TI SDP3430 and EVM boards,
+ OMAP3517 EVM boards and CM-T35.
+
 config PANEL_GENERIC
 tristate Generic Panel
 help
diff --git a/drivers/video/omap2/displays/Makefile 
b/drivers/video/omap2/displays/Makefile
index aa38609..022058c 100644
--- a/drivers/video/omap2/displays/Makefile
+++ b/drivers/video/omap2/displays/Makefile
@@ -1,3 +1,4 @@
+obj-$(CONFIG_PANEL_GENERIC_DPI) += panel-generic-dpi.o
 obj-$(CONFIG_PANEL_GENERIC) += panel-generic.o
 obj-$(CONFIG_PANEL_SHARP_LS037V7DW01) += panel-sharp-ls037v7dw01.o
 obj-$(CONFIG_PANEL_SHARP_LQ043T1DG01) += panel-sharp-lq043t1dg01.o
diff --git a/drivers/video/omap2/displays/panel-generic-dpi.c 
b/drivers/video/omap2/displays/panel-generic-dpi.c
new file mode 100644
index 000..c3fff9e
--- /dev/null
+++ b/drivers/video/omap2/displays/panel-generic-dpi.c
@@ -0,0 +1,333 @@
+/*
+ * Generic DPI Panels support
+ *
+ * Copyright (C) 2010 Canonical Ltd.
+ * Author: Bryan Wu bryan...@canonical.com
+ *
+ * Copyright (C) 2008 Nokia Corporation
+ * Author: Tomi Valkeinen tomi.valkei...@nokia.com
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 as published by
+ * the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program.  If not, see http://www.gnu.org/licenses/.
+ */
+
+#include linux/module.h
+#include linux/delay.h
+
+#include plat/panel-generic-dpi.h
+
+struct panel_config {
+   struct omap_video_timings timings;
+
+   int acbi;   /* ac-bias pin transitions per interrupt */
+   /* Unit: line clocks */
+   int acb;/* ac-bias pin frequency */
+
+   enum omap_panel_config

RE: [PATCH 1/3] OMAP: DSS2: Add generic DPI panel display driver

2010-11-14 Thread Taneja, Archit 
Hi,

bryan...@canonical.com wrote:
 On Wed, Nov 10, 2010 at 10:35 PM, Tomi Valkeinen

[snip]

 
 For both panel power on and off some panels require some sleep times:
 when powering on, the video interface has to be enabled for some time
 before the panel can be enabled, and similarly when powering off the
 video interface needs to be on for some time after the panel has been
 disabled. 
 
 
 Actually, in my previous version patches, I introduced
 .power_on_delay and .power_off_delay in panel_configs, which
 contains the sleep value for msleep(). But Archit told me
 this is not necessary, so I removed that.

I had asked you to remove it from omap_dss_device to a more
specific struct for the generic dpi driver :)

It should be in the 'panel_generic_dpi_data' struct now.

Regards,
Archit
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] OMAP: DSS2: Add generic DPI panel display driver

2010-11-14 Thread Bryan Wu 
On Mon, Nov 15, 2010 at 12:05 PM, Taneja, Archit arc...@ti.com wrote:
 Hi,

 bryan...@canonical.com wrote:
 On Wed, Nov 10, 2010 at 10:35 PM, Tomi Valkeinen

 [snip]


 For both panel power on and off some panels require some sleep times:
 when powering on, the video interface has to be enabled for some time
 before the panel can be enabled, and similarly when powering off the
 video interface needs to be on for some time after the panel has been
 disabled.


 Actually, in my previous version patches, I introduced
 .power_on_delay and .power_off_delay in panel_configs, which
 contains the sleep value for msleep(). But Archit told me
 this is not necessary, so I removed that.

 I had asked you to remove it from omap_dss_device to a more
 specific struct for the generic dpi driver :)


Yeah, no problem.

 It should be in the 'panel_generic_dpi_data' struct now.


I think the delay value is related to panel, which can be found in
sharp_ls and sharp_lq drivers. So it might be in the panel_configs
struct?

Thanks,
-Bryan
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] OMAP: DSS2: Add generic DPI panel display driver

2010-11-13 Thread Bryan Wu 
On Wed, Nov 10, 2010 at 10:35 PM, Tomi Valkeinen
tomi.valkei...@nokia.com wrote:
 Hi,

 On Tue, 2010-11-09 at 18:12 +0100, ext Bryan Wu wrote:
 Generic DPI panel driver includes the driver and 4 similar panel 
 configurations. It
 will match the panel name which is passed from platform data and setup the
 right configurations.

 With generic DPI panel driver, we can remove those 4 duplicated panel display
 drivers. In the future, it is simple for us just add new panel configuration
 date in panel-generic-dpi.c to support new display panel.

 This is looking good, but still a couple of comments inline:

 Signed-off-by: Bryan Wu bryan...@canonical.com
 ---
  .../arm/plat-omap/include/plat/panel-generic-dpi.h |   37 +++
  drivers/video/omap2/displays/Kconfig               |    8 +
  drivers/video/omap2/displays/Makefile              |    1 +
  drivers/video/omap2/displays/panel-generic-dpi.c   |  309 
 
  4 files changed, 355 insertions(+), 0 deletions(-)
  create mode 100644 arch/arm/plat-omap/include/plat/panel-generic-dpi.h
  create mode 100644 drivers/video/omap2/displays/panel-generic-dpi.c

 diff --git a/arch/arm/plat-omap/include/plat/panel-generic-dpi.h 
 b/arch/arm/plat-omap/include/plat/panel-generic-dpi.h
 new file mode 100644
 index 000..7906197
 --- /dev/null
 +++ b/arch/arm/plat-omap/include/plat/panel-generic-dpi.h
 @@ -0,0 +1,37 @@
 +/*
 + * Header for generic DPI panel driver
 + *
 + * Copyright (C) 2010 Canonical Ltd.
 + * Author: Bryan Wu bryan...@canonical.com
 + *
 + * This program is free software; you can redistribute it and/or modify it
 + * under the terms of the GNU General Public License version 2 as published 
 by
 + * the Free Software Foundation.
 + *
 + * This program is distributed in the hope that it will be useful, but 
 WITHOUT
 + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 + * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
 + * more details.
 + *
 + * You should have received a copy of the GNU General Public License along 
 with
 + * this program.  If not, see http://www.gnu.org/licenses/.
 + */
 +
 +#ifndef __ARCH_ARM_PLAT_OMAP_PANEL_GENERIC_DPI_H
 +#define __ARCH_ARM_PLAT_OMAP_PANEL_GENERIC_DPI_H
 +
 +#include display.h
 +
 +/**
 + * struct panel_generic_dpi_data - panel driver configuration data
 + * @name: panel name
 + * @platform_enable: platform specific panel enable function
 + * @platform_disable: platform specific panel disable function
 + */
 +struct panel_generic_dpi_data {
 +     const char *name;
 +     int (*platform_enable)(struct omap_dss_device *dssdev);
 +     void (*platform_disable)(struct omap_dss_device *dssdev);
 +};
 +
 +#endif /* __ARCH_ARM_PLAT_OMAP_PANEL_GENERIC_DPI_H */
 diff --git a/drivers/video/omap2/displays/Kconfig 
 b/drivers/video/omap2/displays/Kconfig
 index 12327bb..cb3e339 100644
 --- a/drivers/video/omap2/displays/Kconfig
 +++ b/drivers/video/omap2/displays/Kconfig
 @@ -1,6 +1,14 @@
  menu OMAP2/3 Display Device Drivers
          depends on OMAP2_DSS

 +config PANEL_GENERIC_DPI
 +        tristate Generic DPI Panel
 +        help
 +       Generic DPI panel driver.
 +       Supports DVI output for Beagle and OMAP3 SDP.
 +       Supports LCD Panel used in TI SDP3430 and EVM boards,
 +       OMAP3517 EVM boards and CM-T35.
 +
  config PANEL_GENERIC
          tristate Generic Panel
          help
 diff --git a/drivers/video/omap2/displays/Makefile 
 b/drivers/video/omap2/displays/Makefile
 index aa38609..022058c 100644
 --- a/drivers/video/omap2/displays/Makefile
 +++ b/drivers/video/omap2/displays/Makefile
 @@ -1,3 +1,4 @@
 +obj-$(CONFIG_PANEL_GENERIC_DPI) += panel-generic-dpi.o
  obj-$(CONFIG_PANEL_GENERIC) += panel-generic.o
  obj-$(CONFIG_PANEL_SHARP_LS037V7DW01) += panel-sharp-ls037v7dw01.o
  obj-$(CONFIG_PANEL_SHARP_LQ043T1DG01) += panel-sharp-lq043t1dg01.o
 diff --git a/drivers/video/omap2/displays/panel-generic-dpi.c 
 b/drivers/video/omap2/displays/panel-generic-dpi.c
 new file mode 100644
 index 000..7ddd631
 --- /dev/null
 +++ b/drivers/video/omap2/displays/panel-generic-dpi.c
 @@ -0,0 +1,309 @@
 +/*
 + * Generic DPI Panels support
 + *
 + * Copyright (C) 2010 Canonical Ltd.
 + * Author: Bryan Wu bryan...@canonical.com
 + *
 + * Copyright (C) 2008 Nokia Corporation
 + * Author: Tomi Valkeinen tomi.valkei...@nokia.com
 + *
 + * This program is free software; you can redistribute it and/or modify it
 + * under the terms of the GNU General Public License version 2 as published 
 by
 + * the Free Software Foundation.
 + *
 + * This program is distributed in the hope that it will be useful, but 
 WITHOUT
 + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 + * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
 + * more details.
 + *
 + * You should have received a copy of the GNU General Public License along 
 with
 + * this program.  If not, see http://www.gnu.org/licenses/.
 + */
 +
 +#include

Re: [PATCH 1/3] OMAP: DSS2: Add generic DPI panel display driver

2010-11-10 Thread Tomi Valkeinen 
Hi,

On Tue, 2010-11-09 at 18:12 +0100, ext Bryan Wu wrote:
 Generic DPI panel driver includes the driver and 4 similar panel 
 configurations. It
 will match the panel name which is passed from platform data and setup the
 right configurations.
 
 With generic DPI panel driver, we can remove those 4 duplicated panel display
 drivers. In the future, it is simple for us just add new panel configuration
 date in panel-generic-dpi.c to support new display panel.

This is looking good, but still a couple of comments inline:

 Signed-off-by: Bryan Wu bryan...@canonical.com
 ---
  .../arm/plat-omap/include/plat/panel-generic-dpi.h |   37 +++
  drivers/video/omap2/displays/Kconfig   |8 +
  drivers/video/omap2/displays/Makefile  |1 +
  drivers/video/omap2/displays/panel-generic-dpi.c   |  309 
 
  4 files changed, 355 insertions(+), 0 deletions(-)
  create mode 100644 arch/arm/plat-omap/include/plat/panel-generic-dpi.h
  create mode 100644 drivers/video/omap2/displays/panel-generic-dpi.c
 
 diff --git a/arch/arm/plat-omap/include/plat/panel-generic-dpi.h 
 b/arch/arm/plat-omap/include/plat/panel-generic-dpi.h
 new file mode 100644
 index 000..7906197
 --- /dev/null
 +++ b/arch/arm/plat-omap/include/plat/panel-generic-dpi.h
 @@ -0,0 +1,37 @@
 +/*
 + * Header for generic DPI panel driver
 + *
 + * Copyright (C) 2010 Canonical Ltd.
 + * Author: Bryan Wu bryan...@canonical.com
 + *
 + * This program is free software; you can redistribute it and/or modify it
 + * under the terms of the GNU General Public License version 2 as published 
 by
 + * the Free Software Foundation.
 + *
 + * This program is distributed in the hope that it will be useful, but 
 WITHOUT
 + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 + * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
 + * more details.
 + *
 + * You should have received a copy of the GNU General Public License along 
 with
 + * this program.  If not, see http://www.gnu.org/licenses/.
 + */
 +
 +#ifndef __ARCH_ARM_PLAT_OMAP_PANEL_GENERIC_DPI_H
 +#define __ARCH_ARM_PLAT_OMAP_PANEL_GENERIC_DPI_H
 +
 +#include display.h
 +
 +/**
 + * struct panel_generic_dpi_data - panel driver configuration data
 + * @name: panel name
 + * @platform_enable: platform specific panel enable function
 + * @platform_disable: platform specific panel disable function
 + */
 +struct panel_generic_dpi_data {
 + const char *name;
 + int (*platform_enable)(struct omap_dss_device *dssdev);
 + void (*platform_disable)(struct omap_dss_device *dssdev);
 +};
 +
 +#endif /* __ARCH_ARM_PLAT_OMAP_PANEL_GENERIC_DPI_H */
 diff --git a/drivers/video/omap2/displays/Kconfig 
 b/drivers/video/omap2/displays/Kconfig
 index 12327bb..cb3e339 100644
 --- a/drivers/video/omap2/displays/Kconfig
 +++ b/drivers/video/omap2/displays/Kconfig
 @@ -1,6 +1,14 @@
  menu OMAP2/3 Display Device Drivers
  depends on OMAP2_DSS
  
 +config PANEL_GENERIC_DPI
 +tristate Generic DPI Panel
 +help
 +   Generic DPI panel driver.
 +   Supports DVI output for Beagle and OMAP3 SDP.
 +   Supports LCD Panel used in TI SDP3430 and EVM boards,
 +   OMAP3517 EVM boards and CM-T35.
 +
  config PANEL_GENERIC
  tristate Generic Panel
  help
 diff --git a/drivers/video/omap2/displays/Makefile 
 b/drivers/video/omap2/displays/Makefile
 index aa38609..022058c 100644
 --- a/drivers/video/omap2/displays/Makefile
 +++ b/drivers/video/omap2/displays/Makefile
 @@ -1,3 +1,4 @@
 +obj-$(CONFIG_PANEL_GENERIC_DPI) += panel-generic-dpi.o
  obj-$(CONFIG_PANEL_GENERIC) += panel-generic.o
  obj-$(CONFIG_PANEL_SHARP_LS037V7DW01) += panel-sharp-ls037v7dw01.o
  obj-$(CONFIG_PANEL_SHARP_LQ043T1DG01) += panel-sharp-lq043t1dg01.o
 diff --git a/drivers/video/omap2/displays/panel-generic-dpi.c 
 b/drivers/video/omap2/displays/panel-generic-dpi.c
 new file mode 100644
 index 000..7ddd631
 --- /dev/null
 +++ b/drivers/video/omap2/displays/panel-generic-dpi.c
 @@ -0,0 +1,309 @@
 +/*
 + * Generic DPI Panels support
 + *
 + * Copyright (C) 2010 Canonical Ltd.
 + * Author: Bryan Wu bryan...@canonical.com
 + *
 + * Copyright (C) 2008 Nokia Corporation
 + * Author: Tomi Valkeinen tomi.valkei...@nokia.com
 + *
 + * This program is free software; you can redistribute it and/or modify it
 + * under the terms of the GNU General Public License version 2 as published 
 by
 + * the Free Software Foundation.
 + *
 + * This program is distributed in the hope that it will be useful, but 
 WITHOUT
 + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 + * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
 + * more details.
 + *
 + * You should have received a copy of the GNU General Public License along 
 with
 + * this program.  If not, see http://www.gnu.org/licenses/.
 + */
 +
 +#include linux/module.h
 +#include linux/delay.h
 +
 +#include plat/panel-generic-dpi.h
 +

Re: [PATCH 1/3] OMAP: DSS2: Add generic DPI panel display driver

2010-11-09 Thread Tomi Valkeinen 
Hi,

On Mon, 2010-11-08 at 22:44 +0100, ext Bryan Wu wrote:
 Generic DPI panel driver includes the driver and 4 similar panel 
 configurations. It
 will match the panel name which is passed from platform data and setup the
 right configurations.
 
 With generic DPI panel driver, we can remove those 4 duplicated panel display
 drivers. In the future, it is simple for us just add new panel configuration
 date in panel-generic-dpi.c to support new display panel.
 
 Signed-off-by: Bryan Wu bryan...@canonical.com
 ---
  .../arm/plat-omap/include/plat/panel-generic-dpi.h |   31 ++
  drivers/video/omap2/displays/Kconfig   |8 +
  drivers/video/omap2/displays/Makefile  |1 +
  drivers/video/omap2/displays/panel-generic-dpi.c   |  314 
 
  4 files changed, 354 insertions(+), 0 deletions(-)
  create mode 100644 arch/arm/plat-omap/include/plat/panel-generic-dpi.h
  create mode 100644 drivers/video/omap2/displays/panel-generic-dpi.c
 
 diff --git a/arch/arm/plat-omap/include/plat/panel-generic-dpi.h 
 b/arch/arm/plat-omap/include/plat/panel-generic-dpi.h
 new file mode 100644
 index 000..da50756
 --- /dev/null
 +++ b/arch/arm/plat-omap/include/plat/panel-generic-dpi.h
 @@ -0,0 +1,31 @@
 +/*
 + * Header for generic DPI panel driver
 + *
 + * Copyright (C) 2010 Canonical Ltd.
 + * Author: Bryan Wu bryan...@canonical.com
 + *
 + * This program is free software; you can redistribute it and/or modify it
 + * under the terms of the GNU General Public License version 2 as published 
 by
 + * the Free Software Foundation.
 + *
 + * This program is distributed in the hope that it will be useful, but 
 WITHOUT
 + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 + * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
 + * more details.
 + *
 + * You should have received a copy of the GNU General Public License along 
 with
 + * this program.  If not, see http://www.gnu.org/licenses/.
 + */
 +
 +#ifndef __ARCH_ARM_PLAT_OMAP_GENERIC_DPI_PANEL_H
 +#define __ARCH_ARM_PLAT_OMAP_GENERIC_DPI_PANEL_H

Should be __ARCH_ARM_PLAT_OMAP_PANEL_GENERIC_DPI_H

 +
 +/**
 + * struct panel_data - panel driver configuration
 + * @name: panel name
 + */
 +struct generic_dpi_panel_data {

I think the struct name should be panel_generic_dpi_data.

 + const char *name;
 +};

Please add here also the fields platform_enable/disable and use them
instead of the ones in dssdev.

 Tomi


--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/3] OMAP: DSS2: Add generic DPI panel display driver

2010-11-09 Thread Bryan Wu 
Generic DPI panel driver includes the driver and 4 similar panel 
configurations. It
will match the panel name which is passed from platform data and setup the
right configurations.

With generic DPI panel driver, we can remove those 4 duplicated panel display
drivers. In the future, it is simple for us just add new panel configuration
date in panel-generic-dpi.c to support new display panel.

Signed-off-by: Bryan Wu bryan...@canonical.com
---
 .../arm/plat-omap/include/plat/panel-generic-dpi.h |   37 +++
 drivers/video/omap2/displays/Kconfig   |8 +
 drivers/video/omap2/displays/Makefile  |1 +
 drivers/video/omap2/displays/panel-generic-dpi.c   |  309 
 4 files changed, 355 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/plat-omap/include/plat/panel-generic-dpi.h
 create mode 100644 drivers/video/omap2/displays/panel-generic-dpi.c

diff --git a/arch/arm/plat-omap/include/plat/panel-generic-dpi.h 
b/arch/arm/plat-omap/include/plat/panel-generic-dpi.h
new file mode 100644
index 000..7906197
--- /dev/null
+++ b/arch/arm/plat-omap/include/plat/panel-generic-dpi.h
@@ -0,0 +1,37 @@
+/*
+ * Header for generic DPI panel driver
+ *
+ * Copyright (C) 2010 Canonical Ltd.
+ * Author: Bryan Wu bryan...@canonical.com
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 as published by
+ * the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program.  If not, see http://www.gnu.org/licenses/.
+ */
+
+#ifndef __ARCH_ARM_PLAT_OMAP_PANEL_GENERIC_DPI_H
+#define __ARCH_ARM_PLAT_OMAP_PANEL_GENERIC_DPI_H
+
+#include display.h
+
+/**
+ * struct panel_generic_dpi_data - panel driver configuration data
+ * @name: panel name
+ * @platform_enable: platform specific panel enable function
+ * @platform_disable: platform specific panel disable function
+ */
+struct panel_generic_dpi_data {
+   const char *name;
+   int (*platform_enable)(struct omap_dss_device *dssdev);
+   void (*platform_disable)(struct omap_dss_device *dssdev);
+};
+
+#endif /* __ARCH_ARM_PLAT_OMAP_PANEL_GENERIC_DPI_H */
diff --git a/drivers/video/omap2/displays/Kconfig 
b/drivers/video/omap2/displays/Kconfig
index 12327bb..cb3e339 100644
--- a/drivers/video/omap2/displays/Kconfig
+++ b/drivers/video/omap2/displays/Kconfig
@@ -1,6 +1,14 @@
 menu OMAP2/3 Display Device Drivers
 depends on OMAP2_DSS
 
+config PANEL_GENERIC_DPI
+tristate Generic DPI Panel
+help
+ Generic DPI panel driver.
+ Supports DVI output for Beagle and OMAP3 SDP.
+ Supports LCD Panel used in TI SDP3430 and EVM boards,
+ OMAP3517 EVM boards and CM-T35.
+
 config PANEL_GENERIC
 tristate Generic Panel
 help
diff --git a/drivers/video/omap2/displays/Makefile 
b/drivers/video/omap2/displays/Makefile
index aa38609..022058c 100644
--- a/drivers/video/omap2/displays/Makefile
+++ b/drivers/video/omap2/displays/Makefile
@@ -1,3 +1,4 @@
+obj-$(CONFIG_PANEL_GENERIC_DPI) += panel-generic-dpi.o
 obj-$(CONFIG_PANEL_GENERIC) += panel-generic.o
 obj-$(CONFIG_PANEL_SHARP_LS037V7DW01) += panel-sharp-ls037v7dw01.o
 obj-$(CONFIG_PANEL_SHARP_LQ043T1DG01) += panel-sharp-lq043t1dg01.o
diff --git a/drivers/video/omap2/displays/panel-generic-dpi.c 
b/drivers/video/omap2/displays/panel-generic-dpi.c
new file mode 100644
index 000..7ddd631
--- /dev/null
+++ b/drivers/video/omap2/displays/panel-generic-dpi.c
@@ -0,0 +1,309 @@
+/*
+ * Generic DPI Panels support
+ *
+ * Copyright (C) 2010 Canonical Ltd.
+ * Author: Bryan Wu bryan...@canonical.com
+ *
+ * Copyright (C) 2008 Nokia Corporation
+ * Author: Tomi Valkeinen tomi.valkei...@nokia.com
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 as published by
+ * the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program.  If not, see http://www.gnu.org/licenses/.
+ */
+
+#include linux/module.h
+#include linux/delay.h
+
+#include plat/panel-generic-dpi.h
+
+struct panel_config {
+   struct omap_video_timings timings;
+
+   int acbi;   /* ac-bias pin transitions per interrupt */
+   /* Unit: line clocks */
+   int acb;/* ac-bias pin frequency */
+
+   enum omap_panel_config

[PATCH 1/3] OMAP: DSS2: Add generic DPI panel display driver

2010-11-08 Thread Bryan Wu 
Generic DPI panel driver includes the driver and 4 similar panel 
configurations. It
will match the panel name which is passed from platform data and setup the
right configurations.

With generic DPI panel driver, we can remove those 4 duplicated panel display
drivers. In the future, it is simple for us just add new panel configuration
date in panel-generic-dpi.c to support new display panel.

Signed-off-by: Bryan Wu bryan...@canonical.com
---
 .../arm/plat-omap/include/plat/panel-generic-dpi.h |   31 ++
 drivers/video/omap2/displays/Kconfig   |8 +
 drivers/video/omap2/displays/Makefile  |1 +
 drivers/video/omap2/displays/panel-generic-dpi.c   |  314 
 4 files changed, 354 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/plat-omap/include/plat/panel-generic-dpi.h
 create mode 100644 drivers/video/omap2/displays/panel-generic-dpi.c

diff --git a/arch/arm/plat-omap/include/plat/panel-generic-dpi.h 
b/arch/arm/plat-omap/include/plat/panel-generic-dpi.h
new file mode 100644
index 000..da50756
--- /dev/null
+++ b/arch/arm/plat-omap/include/plat/panel-generic-dpi.h
@@ -0,0 +1,31 @@
+/*
+ * Header for generic DPI panel driver
+ *
+ * Copyright (C) 2010 Canonical Ltd.
+ * Author: Bryan Wu bryan...@canonical.com
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 as published by
+ * the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program.  If not, see http://www.gnu.org/licenses/.
+ */
+
+#ifndef __ARCH_ARM_PLAT_OMAP_GENERIC_DPI_PANEL_H
+#define __ARCH_ARM_PLAT_OMAP_GENERIC_DPI_PANEL_H
+
+/**
+ * struct panel_data - panel driver configuration
+ * @name: panel name
+ */
+struct generic_dpi_panel_data {
+   const char *name;
+};
+
+#endif /* __ARCH_ARM_PLAT_OMAP_GENERIC_DPI_PANEL_H */
diff --git a/drivers/video/omap2/displays/Kconfig 
b/drivers/video/omap2/displays/Kconfig
index 12327bb..cb3e339 100644
--- a/drivers/video/omap2/displays/Kconfig
+++ b/drivers/video/omap2/displays/Kconfig
@@ -1,6 +1,14 @@
 menu OMAP2/3 Display Device Drivers
 depends on OMAP2_DSS
 
+config PANEL_GENERIC_DPI
+tristate Generic DPI Panel
+help
+ Generic DPI panel driver.
+ Supports DVI output for Beagle and OMAP3 SDP.
+ Supports LCD Panel used in TI SDP3430 and EVM boards,
+ OMAP3517 EVM boards and CM-T35.
+
 config PANEL_GENERIC
 tristate Generic Panel
 help
diff --git a/drivers/video/omap2/displays/Makefile 
b/drivers/video/omap2/displays/Makefile
index aa38609..022058c 100644
--- a/drivers/video/omap2/displays/Makefile
+++ b/drivers/video/omap2/displays/Makefile
@@ -1,3 +1,4 @@
+obj-$(CONFIG_PANEL_GENERIC_DPI) += panel-generic-dpi.o
 obj-$(CONFIG_PANEL_GENERIC) += panel-generic.o
 obj-$(CONFIG_PANEL_SHARP_LS037V7DW01) += panel-sharp-ls037v7dw01.o
 obj-$(CONFIG_PANEL_SHARP_LQ043T1DG01) += panel-sharp-lq043t1dg01.o
diff --git a/drivers/video/omap2/displays/panel-generic-dpi.c 
b/drivers/video/omap2/displays/panel-generic-dpi.c
new file mode 100644
index 000..b252e0f
--- /dev/null
+++ b/drivers/video/omap2/displays/panel-generic-dpi.c
@@ -0,0 +1,314 @@
+/*
+ * Generic DPI Panels support
+ *
+ * Copyright (C) 2010 Canonical Ltd.
+ * Author: Bryan Wu bryan...@canonical.com
+ *
+ * Copyright (C) 2008 Nokia Corporation
+ * Author: Tomi Valkeinen tomi.valkei...@nokia.com
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 as published by
+ * the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program.  If not, see http://www.gnu.org/licenses/.
+ */
+
+#include linux/module.h
+#include linux/delay.h
+
+#include plat/display.h
+#include plat/panel-generic-dpi.h
+
+struct panel_config {
+   struct omap_video_timings timings;
+
+   int acbi;   /* ac-bias pin transitions per interrupt */
+   /* Unit: line clocks */
+   int acb;/* ac-bias pin frequency */
+
+   enum omap_panel_config config;
+
+   /*
+* Used to match device to panel configuration
+* when use generic panel driver
+*/
+   const char *name;
+
+   int data_lines;
+};
+
+/* Panel configurations */
+static struct panel_config generic_dpi_panels[] = {
+